Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Group Data Provider updated to newest Group Key Management spec. #12840

Merged
merged 2 commits into from
Dec 10, 2021
Merged

Group Data Provider updated to newest Group Key Management spec. #12840

merged 2 commits into from
Dec 10, 2021

Conversation

rcasallas-silabs
Copy link
Contributor

Problem

The Group Data Provider lacks support for the new Group Key Management attributes.

Change overview

  • Group Key Management interface updated:
    • GroupMapping functions replaced. The data provider should support two types of mappings, groups to endpoint, and groups to keysets.
    • Three new sections replace GroupMappings: GroupInfo, Endpoints, and GroupKeys.
    • Unit tests updated to support the new functions.
    • Groups cluster server updated to use the new interface.

Testing

  • Unit tests run successfully (existing KeySet tests, plus new tests).
  • Existing YAML group cluster tests executed successfully.

@github-actions
Copy link

github-actions bot commented Dec 9, 2021

PR #12840: Size comparison from 7b66b77 to 61d3405

Increases above 0.2%:

platform target config section 7b66b77 61d3405 change % change
efr32 lighting-app BRD4161A (read only) 807428 810852 3424 0.4
.text 807420 810844 3424 0.4
window-app BRD4161A (read only) 784164 787568 3404 0.4
.text 784156 787560 3404 0.4
lighting-app BRD4161A+rpc (read only) 795048 798468 3420 0.4
.text 795040 798460 3420 0.4
Increases (3 builds for efr32)
platform target config section 7b66b77 61d3405 change % change
efr32 lighting-app BRD4161A (read only) 807428 810852 3424 0.4
.text 807420 810844 3424 0.4
window-app BRD4161A (read only) 784164 787568 3404 0.4
.text 784156 787560 3404 0.4
lighting-app BRD4161A+rpc (read only) 795048 798468 3420 0.4
.text 795040 798460 3420 0.4
Decreases (3 builds for efr32)
platform target config section 7b66b77 61d3405 change % change
efr32 lighting-app BRD4161A (read/write) 123008 122960 -48 -0.0
.bss 121160 121112 -48 -0.0
window-app BRD4161A (read/write) 121140 121096 -44 -0.0
.bss 119328 119280 -48 -0.0
lighting-app BRD4161A+rpc (read/write) 139696 139644 -52 -0.0
.bss 137736 137688 -48 -0.0
Full report (3 builds for efr32)
platform target config section 7b66b77 61d3405 change % change
efr32 lighting-app BRD4161A (read only) 807428 810852 3424 0.4
(read/write) 123008 122960 -48 -0.0
.bss 121160 121112 -48 -0.0
.data 1848 1848 0 0.0
.text 807420 810844 3424 0.4
window-app BRD4161A (read only) 784164 787568 3404 0.4
(read/write) 121140 121096 -44 -0.0
.bss 119328 119280 -48 -0.0
.data 1812 1812 0 0.0
.text 784156 787560 3404 0.4
lighting-app BRD4161A+rpc (read only) 795048 798468 3420 0.4
(read/write) 139696 139644 -52 -0.0
.bss 137736 137688 -48 -0.0
.data 1956 1956 0 0.0
.text 795040 798460 3420 0.4

bzbarsky-apple
bzbarsky-apple reviewed Dec 10, 2021
View reviewed changes
Copy link
Contributor

@bzbarsky-apple bzbarsky-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: I did not review the GroupDataProviderImpl changes.

src/app/clusters/groups-server/groups-server.cpp Show resolved Hide resolved
@woody-apple
Copy link
Contributor

/rebase

@rcasallas-silabs rcasallas-silabs force-pushed the group_data_provider_update branch 3 times, most recently from 85d9836 to e373dc9 Compare December 10, 2021 10:03
@github-actions
Copy link

github-actions bot commented Dec 10, 2021 •
edited
Loading

PR #12840: Size comparison from 83aac59 to e373dc9

Increases above 0.2%:

platform target config section 83aac59 e373dc90 change % change
efr32 lighting-app BRD4161A (read only) 809188 812628 3440 0.4
.text 809180 812620 3440 0.4
BRD4161A+rpc (read only) 796824 800244 3420 0.4
.text 796816 800236 3420 0.4
window-app BRD4161A (read only) 786164 789584 3420 0.4
.text 786156 789576 3420 0.4
p6 all-clusters-app default .text 1320168 1323560 3392 0.3
light-app default .text 1252984 1256408 3424 0.3
lock-app default .text 1229048 1232472 3424 0.3
Increases (12 builds for efr32, linux, mbed, p6, telink)
platform target config section 83aac59 e373dc90 change % change
efr32 lighting-app BRD4161A (read only) 809188 812628 3440 0.4
.text 809180 812620 3440 0.4
BRD4161A+rpc (read only) 796824 800244 3420 0.4
.text 796816 800236 3420 0.4
window-app BRD4161A (read only) 786164 789584 3420 0.4
.text 786156 789576 3420 0.4
linux chip-tool-ipv6only arm64 .data.rel.ro 208776 208800 24 0.0
.rodata 364700 364708 8 0.0
thermostat-no-ble arm64 .rodata 125444 125460 16 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release .heap 846096 846144 48 0.0
lighting-app CY8CPROTO_062_4343W+release .heap 855096 855144 48 0.0
lock-app CY8CPROTO_062_4343W+release .heap 856064 856112 48 0.0
p6 all-clusters-app default (read/write) 2361904 2365296 3392 0.1
.heap 917576 917624 48 0.0
.text 1320168 1323560 3392 0.3
light-app default (read/write) 2294720 2298144 3424 0.1
.heap 929968 930016 48 0.0
.text 1252984 1256408 3424 0.3
lock-app default (read/write) 2270784 2274208 3424 0.2
.heap 931120 931168 48 0.0
.text 1229048 1232472 3424 0.3
telink lighting-app tlsr9518adk80d text 566032 566058 26 0.0
Decreases (26 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 83aac59 e373dc90 change % change
efr32 lighting-app BRD4161A (read/write) 123148 123100 -48 -0.0
.bss 121288 121240 -48 -0.0
BRD4161A+rpc (read/write) 139824 139776 -48 -0.0
.bss 137864 137816 -48 -0.0
window-app BRD4161A (read/write) 121280 121232 -48 -0.0
.bss 119456 119408 -48 -0.0
esp32 all-clusters-app c3devkit (read only) 862812 862788 -24 -0.0
(read/write) 1306058 1305906 -152 -0.0
.dram0.bss 65832 65784 -48 -0.1
.flash.rodata 173064 172960 -104 -0.1
.flash.text 862812 862788 -24 -0.0
m5stack (read only) 966007 965903 -104 -0.0
(read/write) 451744 451600 -144 -0.0
.dram0.bss 75128 75080 -48 -0.1
.flash.rodata 210772 210676 -96 -0.0
.flash.text 960623 960519 -104 -0.0
k32w lighting-app k32w061+se05x+release (read/write) 669576 669240 -336 -0.1
.bss 73872 73824 -48 -0.1
.text 588012 587724 -288 -0.0
lock-app k32w061+debug (read/write) 619524 619208 -316 -0.1
.bss 72024 71976 -48 -0.1
.text 539848 539580 -268 -0.0
shell k32w061+debug (read/write) 624624 624292 -332 -0.1
.bss 74252 74204 -48 -0.1
.text 542740 542456 -284 -0.1
linux chip-tool-ipv6only arm64 (read only) 6864588 6863716 -872 -0.0
(read/write) 318785 318721 -64 -0.0
.bss 51985 51905 -80 -0.2
.text 5820228 5819220 -1008 -0.0
thermostat-no-ble arm64 (read only) 1947044 1946820 -224 -0.0
(read/write) 137201 137121 -80 -0.1
.bss 59601 59521 -80 -0.1
.got 3592 3584 -8 -0.2
.text 1614096 1613776 -320 -0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2324328 2323824 -504 -0.0
.bss 185108 185060 -48 -0.0
.text 1286904 1286400 -504 -0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2308944 2308696 -248 -0.0
.bss 175824 175776 -48 -0.0
.text 1271544 1271296 -248 -0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2282064 2281816 -248 -0.0
.bss 174864 174816 -48 -0.0
.text 1244664 1244416 -248 -0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 906795 906491 -304 -0.0
bss 116296 116248 -48 -0.0
rodata 101980 101900 -80 -0.1
text 612912 612756 -156 -0.0
nrf52840dk_nrf52840+rpc (read/write) 869827 869523 -304 -0.0
bss 112644 112596 -48 -0.0
rodata 93276 93196 -80 -0.1
text 587640 587484 -156 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 832794 832494 -300 -0.0
bss 117672 117624 -48 -0.0
rodata 97236 97160 -76 -0.1
text 543340 543184 -156 -0.0
lock-app nrf52840dk_nrf52840 (read/write) 879407 879155 -252 -0.0
bss 113560 113512 -48 -0.0
rodata 98096 98020 -76 -0.1
text 592356 592200 -156 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 805666 805394 -272 -0.0
bss 114968 114920 -48 -0.0
rodata 93388 93308 -80 -0.1
text 522876 522720 -156 -0.0
pump-app nrf52840dk_nrf52840 (read/write) 884347 884091 -256 -0.0
bss 113472 113424 -48 -0.0
rodata 99452 99372 -80 -0.1
text 595948 595792 -156 -0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 877587 877283 -304 -0.0
bss 113348 113300 -48 -0.0
rodata 97588 97508 -80 -0.1
text 591144 590988 -156 -0.0
p6 all-clusters-app default .bss 113244 113196 -48 -0.0
light-app default .bss 101016 100968 -48 -0.0
lock-app default .bss 99896 99848 -48 -0.0
qpg lighting-app qpg6100+debug (read only) 521328 521068 -260 -0.0
.bss 82712 82664 -48 -0.1
.text 516008 515748 -260 -0.1
lock-app qpg6100+debug (read only) 495696 495432 -264 -0.1
.bss 81848 81800 -48 -0.1
.text 490376 490112 -264 -0.1
telink lighting-app tlsr9518adk80d (read/write) 810978 810890 -88 -0.0
bss 82864 82816 -48 -0.1
Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 83aac59 e373dc90 change % change
efr32 lighting-app BRD4161A (read only) 809188 812628 3440 0.4
(read/write) 123148 123100 -48 -0.0
.bss 121288 121240 -48 -0.0
.data 1860 1860 0 0.0
.text 809180 812620 3440 0.4
BRD4161A+rpc (read only) 796824 800244 3420 0.4
(read/write) 139824 139776 -48 -0.0
.bss 137864 137816 -48 -0.0
.data 1960 1960 0 0.0
.text 796816 800236 3420 0.4
window-app BRD4161A (read only) 786164 789584 3420 0.4
(read/write) 121280 121232 -48 -0.0
.bss 119456 119408 -48 -0.0
.data 1824 1824 0 0.0
.text 786156 789576 3420 0.4
esp32 all-clusters-app c3devkit (read only) 862812 862788 -24 -0.0
(read/write) 1306058 1305906 -152 -0.0
.dram0.bss 65832 65784 -48 -0.1
.dram0.data 14124 14124 0 0.0
.flash.rodata 173064 172960 -104 -0.1
.flash.text 862812 862788 -24 -0.0
.iram0.text 62076 62076 0 0.0
m5stack (read only) 966007 965903 -104 -0.0
(read/write) 451744 451600 -144 -0.0
.dram0.bss 75128 75080 -48 -0.1
.dram0.data 34056 34056 0 0.0
.flash.rodata 210772 210676 -96 -0.0
.flash.text 960623 960519 -104 -0.0
.iram0.text 123451 123451 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 669576 669240 -336 -0.1
.bss 73872 73824 -48 -0.1
.data 1892 1892 0 0.0
.text 588012 587724 -288 -0.0
lock-app k32w061+debug (read/write) 619524 619208 -316 -0.1
.bss 72024 71976 -48 -0.1
.data 1852 1852 0 0.0
.text 539848 539580 -268 -0.0
shell k32w061+debug (read/write) 624624 624292 -332 -0.1
.bss 74252 74204 -48 -0.1
.data 1832 1832 0 0.0
.text 542740 542456 -284 -0.1
linux chip-tool-ipv6only arm64 (read only) 6864588 6863716 -872 -0.0
(read/write) 318785 318721 -64 -0.0
.bss 51985 51905 -80 -0.2
.data 1192 1192 0 0.0
.data.rel.ro 208776 208800 24 0.0
.dynamic 560 560 0 0.0
.got 53096 53096 0 0.0
.init 24 24 0 0.0
.init_array 176 176 0 0.0
.rodata 364700 364708 8 0.0
.text 5820228 5819220 -1008 -0.0
thermostat-no-ble arm64 (read only) 1947044 1946820 -224 -0.0
(read/write) 137201 137121 -80 -0.1
.bss 59601 59521 -80 -0.1
.data 832 832 0 0.0
.data.rel.ro 70304 70304 0 0.0
.dynamic 560 560 0 0.0
.got 3592 3584 -8 -0.2
.init 24 24 0 0.0
.init_array 272 272 0 0.0
.rodata 125444 125460 16 0.0
.text 1614096 1613776 -320 -0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2324328 2323824 -504 -0.0
.bss 185108 185060 -48 -0.0
.data 5240 5240 0 0.0
.heap 846096 846144 48 0.0
.text 1286904 1286400 -504 -0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2308944 2308696 -248 -0.0
.bss 175824 175776 -48 -0.0
.data 5528 5528 0 0.0
.heap 855096 855144 48 0.0
.text 1271544 1271296 -248 -0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2282064 2281816 -248 -0.0
.bss 174864 174816 -48 -0.0
.data 5520 5520 0 0.0
.heap 856064 856112 48 0.0
.text 1244664 1244416 -248 -0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4376 4376 0 0.0
.heap 1020312 1020312 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2053336 2053336 0 0.0
.bss 156900 156900 0 0.0
.data 4864 4864 0 0.0
.heap 874680 874680 0 0.0
.text 1015936 1015936 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 906795 906491 -304 -0.0
bss 116296 116248 -48 -0.0
rodata 101980 101900 -80 -0.1
text 612912 612756 -156 -0.0
nrf52840dk_nrf52840+rpc (read/write) 869827 869523 -304 -0.0
bss 112644 112596 -48 -0.0
rodata 93276 93196 -80 -0.1
text 587640 587484 -156 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 832794 832494 -300 -0.0
bss 117672 117624 -48 -0.0
rodata 97236 97160 -76 -0.1
text 543340 543184 -156 -0.0
lock-app nrf52840dk_nrf52840 (read/write) 879407 879155 -252 -0.0
bss 113560 113512 -48 -0.0
rodata 98096 98020 -76 -0.1
text 592356 592200 -156 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 805666 805394 -272 -0.0
bss 114968 114920 -48 -0.0
rodata 93388 93308 -80 -0.1
text 522876 522720 -156 -0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497463 497463 0 0.0
bss 51820 51820 0 0.0
rodata 45852 45852 0 0.0
text 339492 339492 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 884347 884091 -256 -0.0
bss 113472 113424 -48 -0.0
rodata 99452 99372 -80 -0.1
text 595948 595792 -156 -0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 877587 877283 -304 -0.0
bss 113348 113300 -48 -0.0
rodata 97588 97508 -80 -0.1
text 591144 590988 -156 -0.0
shell nrf52840dk_nrf52840 (read/write) 781927 781927 0 0.0
bss 109544 109544 0 0.0
rodata 74276 74276 0 0.0
text 523588 523588 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 696974 696974 0 0.0
bss 110524 110524 0 0.0
rodata 68920 68920 0 0.0
text 444228 444228 0 0.0
p6 all-clusters-app default (read/write) 2361904 2365296 3392 0.1
.bss 113244 113196 -48 -0.0
.data 2520 2520 0 0.0
.heap 917576 917624 48 0.0
.text 1320168 1323560 3392 0.3
light-app default (read/write) 2294720 2298144 3424 0.1
.bss 101016 100968 -48 -0.0
.data 2360 2360 0 0.0
.heap 929968 930016 48 0.0
.text 1252984 1256408 3424 0.3
lock-app default (read/write) 2270784 2274208 3424 0.2
.bss 99896 99848 -48 -0.0
.data 2328 2328 0 0.0
.heap 931120 931168 48 0.0
.text 1229048 1232472 3424 0.3
qpg lighting-app qpg6100+debug (read only) 521328 521068 -260 -0.0
(read/write) 122336 122336 0 0.0
.bss 82712 82664 -48 -0.1
.data 992 992 0 0.0
.text 516008 515748 -260 -0.1
lock-app qpg6100+debug (read only) 495696 495432 -264 -0.1
(read/write) 122332 122332 0 0.0
.bss 81848 81800 -48 -0.1
.data 948 948 0 0.0
.text 490376 490112 -264 -0.1
persistent-storage-app qpg6100+debug (read only) 108104 108104 0 0.0
(read/write) 122336 122336 0 0.0
.bss 36160 36160 0 0.0
.data 288 288 0 0.0
.text 102784 102784 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 810978 810890 -88 -0.0
bss 82864 82816 -48 -0.1
noinit 37160 37160 0 0.0
text 566032 566058 26 0.0

@rcasallas-silabs rcasallas-silabs force-pushed the group_data_provider_update branch from e373dc9 to 99c274e Compare December 10, 2021 11:53
@rcasallas-silabs rcasallas-silabs force-pushed the group_data_provider_update branch from 99c274e to 7a65dff Compare December 10, 2021 12:05
@github-actions
Copy link

github-actions bot commented Dec 10, 2021 •
edited
Loading

PR #12840: Size comparison from 39a97d1 to 7a65dff

Increases above 0.2%:

platform target config section 39a97d1 7a65dff change % change
efr32 lighting-app BRD4161A (read only) 809188 812932 3744 0.5
.text 809180 812924 3744 0.5
BRD4161A+rpc (read only) 796824 800548 3724 0.5
.text 796816 800540 3724 0.5
window-app BRD4161A (read only) 786164 789888 3724 0.5
.text 786156 789880 3724 0.5
linux thermostat-no-ble arm64 .got 3592 3616 24 0.7
p6 all-clusters-app default .text 1312808 1316504 3696 0.3
light-app default .text 1252984 1256712 3728 0.3
lock-app default .text 1229048 1232792 3744 0.3
Increases (21 builds for efr32, esp32, linux, mbed, nrfconnect, p6, telink)
platform target config section 39a97d1 7a65dff change % change
efr32 lighting-app BRD4161A (read only) 809188 812932 3744 0.5
.text 809180 812924 3744 0.5
BRD4161A+rpc (read only) 796824 800548 3724 0.5
.text 796816 800540 3724 0.5
window-app BRD4161A (read only) 786164 789888 3724 0.5
.text 786156 789880 3724 0.5
esp32 all-clusters-app c3devkit (read only) 856018 856266 248 0.0
.flash.text 856018 856266 248 0.0
m5stack (read only) 959935 960119 184 0.0
.flash.text 954551 954735 184 0.0
linux chip-tool-ipv6only arm64 (read only) 6848196 6848220 24 0.0
.data.rel.ro 208656 208680 24 0.0
.got 53384 53416 32 0.1
.rodata 364116 364124 8 0.0
thermostat-no-ble arm64 (read only) 1947044 1947732 688 0.0
.got 3592 3616 24 0.7
.rodata 125444 125460 16 0.0
.text 1614096 1614592 496 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release .heap 846912 846960 48 0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2308944 2308952 8 0.0
.heap 855096 855144 48 0.0
.text 1271544 1271552 8 0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2282064 2282072 8 0.0
.heap 856064 856112 48 0.0
.text 1244664 1244672 8 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 text 612912 612996 84 0.0
nrf52840dk_nrf52840+rpc text 587640 587724 84 0.0
nrf5340dk_nrf5340_cpuapp text 543340 543420 80 0.0
lock-app nrf52840dk_nrf52840 text 592356 592440 84 0.0
nrf5340dk_nrf5340_cpuapp text 522876 522956 80 0.0
pump-app nrf52840dk_nrf52840 text 595948 596028 80 0.0
pump-controller-app nrf52840dk_nrf52840 text 591144 591228 84 0.0
p6 all-clusters-app default (read/write) 2354544 2358240 3696 0.2
.heap 918384 918432 48 0.0
.text 1312808 1316504 3696 0.3
light-app default (read/write) 2294720 2298448 3728 0.2
.heap 929968 930016 48 0.0
.text 1252984 1256712 3728 0.3
lock-app default (read/write) 2270784 2274528 3744 0.2
.heap 931120 931168 48 0.0
.text 1229048 1232792 3744 0.3
telink lighting-app tlsr9518adk80d (read/write) 810978 811162 184 0.0
text 566032 566336 304 0.1
Decreases (26 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 39a97d1 7a65dff change % change
efr32 lighting-app BRD4161A (read/write) 123148 123100 -48 -0.0
.bss 121288 121240 -48 -0.0
BRD4161A+rpc (read/write) 139824 139776 -48 -0.0
.bss 137864 137816 -48 -0.0
window-app BRD4161A (read/write) 121280 121232 -48 -0.0
.bss 119456 119408 -48 -0.0
esp32 all-clusters-app c3devkit (read/write) 1305050 1304898 -152 -0.0
.dram0.bss 65032 64984 -48 -0.1
.flash.rodata 172856 172752 -104 -0.1
m5stack (read/write) 450776 450632 -144 -0.0
.dram0.bss 74320 74272 -48 -0.1
.flash.rodata 210620 210524 -96 -0.0
k32w lighting-app k32w061+se05x+release (read/write) 669576 669480 -96 -0.0
.bss 73872 73824 -48 -0.1
.text 588012 587964 -48 -0.0
lock-app k32w061+debug (read/write) 619524 619448 -76 -0.0
.bss 72024 71976 -48 -0.1
.text 539848 539820 -28 -0.0
shell k32w061+debug (read/write) 624624 624532 -92 -0.0
.bss 74252 74204 -48 -0.1
.text 542740 542696 -44 -0.0
linux chip-tool-ipv6only arm64 (read/write) 318945 318929 -16 -0.0
.bss 51985 51905 -80 -0.2
.text 5803380 5803188 -192 -0.0
thermostat-no-ble arm64 (read/write) 137201 137153 -48 -0.0
.bss 59601 59521 -80 -0.1
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2313768 2313448 -320 -0.0
.bss 184300 184252 -48 -0.0
.text 1276344 1276024 -320 -0.0
lighting-app CY8CPROTO_062_4343W+release .bss 175824 175776 -48 -0.0
lock-app CY8CPROTO_062_4343W+release .bss 174864 174816 -48 -0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 906795 906731 -64 -0.0
bss 116296 116248 -48 -0.0
rodata 101980 101900 -80 -0.1
nrf52840dk_nrf52840+rpc (read/write) 869827 869763 -64 -0.0
bss 112644 112596 -48 -0.0
rodata 93276 93196 -80 -0.1
nrf5340dk_nrf5340_cpuapp (read/write) 832794 832734 -60 -0.0
bss 117672 117624 -48 -0.0
rodata 97236 97160 -76 -0.1
lock-app nrf52840dk_nrf52840 (read/write) 879407 879395 -12 -0.0
bss 113560 113512 -48 -0.0
rodata 98096 98020 -76 -0.1
nrf5340dk_nrf5340_cpuapp (read/write) 805666 805634 -32 -0.0
bss 114968 114920 -48 -0.0
rodata 93388 93308 -80 -0.1
pump-app nrf52840dk_nrf52840 (read/write) 884347 884315 -32 -0.0
bss 113472 113424 -48 -0.0
rodata 99452 99372 -80 -0.1
pump-controller-app nrf52840dk_nrf52840 (read/write) 877587 877523 -64 -0.0
bss 113348 113300 -48 -0.0
rodata 97588 97508 -80 -0.1
p6 all-clusters-app default .bss 112436 112388 -48 -0.0
light-app default .bss 101016 100968 -48 -0.0
lock-app default .bss 99896 99848 -48 -0.0
qpg lighting-app qpg6100+debug (read only) 521328 521300 -28 -0.0
.bss 82712 82664 -48 -0.1
.text 516008 515980 -28 -0.0
lock-app qpg6100+debug (read only) 495696 495672 -24 -0.0
.bss 81848 81800 -48 -0.1
.text 490376 490352 -24 -0.0
telink lighting-app tlsr9518adk80d bss 82864 82816 -48 -0.1
Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 39a97d1 7a65dff change % change
efr32 lighting-app BRD4161A (read only) 809188 812932 3744 0.5
(read/write) 123148 123100 -48 -0.0
.bss 121288 121240 -48 -0.0
.data 1860 1860 0 0.0
.text 809180 812924 3744 0.5
BRD4161A+rpc (read only) 796824 800548 3724 0.5
(read/write) 139824 139776 -48 -0.0
.bss 137864 137816 -48 -0.0
.data 1960 1960 0 0.0
.text 796816 800540 3724 0.5
window-app BRD4161A (read only) 786164 789888 3724 0.5
(read/write) 121280 121232 -48 -0.0
.bss 119456 119408 -48 -0.0
.data 1824 1824 0 0.0
.text 786156 789880 3724 0.5
esp32 all-clusters-app c3devkit (read only) 856018 856266 248 0.0
(read/write) 1305050 1304898 -152 -0.0
.dram0.bss 65032 64984 -48 -0.1
.dram0.data 14124 14124 0 0.0
.flash.rodata 172856 172752 -104 -0.1
.flash.text 856018 856266 248 0.0
.iram0.text 62076 62076 0 0.0
m5stack (read only) 959935 960119 184 0.0
(read/write) 450776 450632 -144 -0.0
.dram0.bss 74320 74272 -48 -0.1
.dram0.data 34048 34048 0 0.0
.flash.rodata 210620 210524 -96 -0.0
.flash.text 954551 954735 184 0.0
.iram0.text 123451 123451 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 669576 669480 -96 -0.0
.bss 73872 73824 -48 -0.1
.data 1892 1892 0 0.0
.text 588012 587964 -48 -0.0
lock-app k32w061+debug (read/write) 619524 619448 -76 -0.0
.bss 72024 71976 -48 -0.1
.data 1852 1852 0 0.0
.text 539848 539820 -28 -0.0
shell k32w061+debug (read/write) 624624 624532 -92 -0.0
.bss 74252 74204 -48 -0.1
.data 1832 1832 0 0.0
.text 542740 542696 -44 -0.0
linux chip-tool-ipv6only arm64 (read only) 6848196 6848220 24 0.0
(read/write) 318945 318929 -16 -0.0
.bss 51985 51905 -80 -0.2
.data 1192 1192 0 0.0
.data.rel.ro 208656 208680 24 0.0
.dynamic 560 560 0 0.0
.got 53384 53416 32 0.1
.init 24 24 0 0.0
.init_array 176 176 0 0.0
.rodata 364116 364124 8 0.0
.text 5803380 5803188 -192 -0.0
thermostat-no-ble arm64 (read only) 1947044 1947732 688 0.0
(read/write) 137201 137153 -48 -0.0
.bss 59601 59521 -80 -0.1
.data 832 832 0 0.0
.data.rel.ro 70304 70304 0 0.0
.dynamic 560 560 0 0.0
.got 3592 3616 24 0.7
.init 24 24 0 0.0
.init_array 272 272 0 0.0
.rodata 125444 125460 16 0.0
.text 1614096 1614592 496 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2313768 2313448 -320 -0.0
.bss 184300 184252 -48 -0.0
.data 5232 5232 0 0.0
.heap 846912 846960 48 0.0
.text 1276344 1276024 -320 -0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2308944 2308952 8 0.0
.bss 175824 175776 -48 -0.0
.data 5528 5528 0 0.0
.heap 855096 855144 48 0.0
.text 1271544 1271552 8 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2282064 2282072 8 0.0
.bss 174864 174816 -48 -0.0
.data 5520 5520 0 0.0
.heap 856064 856112 48 0.0
.text 1244664 1244672 8 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4376 4376 0 0.0
.heap 1020312 1020312 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2053336 2053336 0 0.0
.bss 156900 156900 0 0.0
.data 4864 4864 0 0.0
.heap 874680 874680 0 0.0
.text 1015936 1015936 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 906795 906731 -64 -0.0
bss 116296 116248 -48 -0.0
rodata 101980 101900 -80 -0.1
text 612912 612996 84 0.0
nrf52840dk_nrf52840+rpc (read/write) 869827 869763 -64 -0.0
bss 112644 112596 -48 -0.0
rodata 93276 93196 -80 -0.1
text 587640 587724 84 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 832794 832734 -60 -0.0
bss 117672 117624 -48 -0.0
rodata 97236 97160 -76 -0.1
text 543340 543420 80 0.0
lock-app nrf52840dk_nrf52840 (read/write) 879407 879395 -12 -0.0
bss 113560 113512 -48 -0.0
rodata 98096 98020 -76 -0.1
text 592356 592440 84 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 805666 805634 -32 -0.0
bss 114968 114920 -48 -0.0
rodata 93388 93308 -80 -0.1
text 522876 522956 80 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497463 497463 0 0.0
bss 51820 51820 0 0.0
rodata 45852 45852 0 0.0
text 339492 339492 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 884347 884315 -32 -0.0
bss 113472 113424 -48 -0.0
rodata 99452 99372 -80 -0.1
text 595948 596028 80 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 877587 877523 -64 -0.0
bss 113348 113300 -48 -0.0
rodata 97588 97508 -80 -0.1
text 591144 591228 84 0.0
shell nrf52840dk_nrf52840 (read/write) 781927 781927 0 0.0
bss 109544 109544 0 0.0
rodata 74276 74276 0 0.0
text 523588 523588 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 696974 696974 0 0.0
bss 110524 110524 0 0.0
rodata 68920 68920 0 0.0
text 444228 444228 0 0.0
p6 all-clusters-app default (read/write) 2354544 2358240 3696 0.2
.bss 112436 112388 -48 -0.0
.data 2520 2520 0 0.0
.heap 918384 918432 48 0.0
.text 1312808 1316504 3696 0.3
light-app default (read/write) 2294720 2298448 3728 0.2
.bss 101016 100968 -48 -0.0
.data 2360 2360 0 0.0
.heap 929968 930016 48 0.0
.text 1252984 1256712 3728 0.3
lock-app default (read/write) 2270784 2274528 3744 0.2
.bss 99896 99848 -48 -0.0
.data 2328 2328 0 0.0
.heap 931120 931168 48 0.0
.text 1229048 1232792 3744 0.3
qpg lighting-app qpg6100+debug (read only) 521328 521300 -28 -0.0
(read/write) 122336 122336 0 0.0
.bss 82712 82664 -48 -0.1
.data 992 992 0 0.0
.text 516008 515980 -28 -0.0
lock-app qpg6100+debug (read only) 495696 495672 -24 -0.0
(read/write) 122332 122332 0 0.0
.bss 81848 81800 -48 -0.1
.data 948 948 0 0.0
.text 490376 490352 -24 -0.0
persistent-storage-app qpg6100+debug (read only) 108104 108104 0 0.0
(read/write) 122336 122336 0 0.0
.bss 36160 36160 0 0.0
.data 288 288 0 0.0
.text 102784 102784 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 810978 811162 184 0.0
bss 82864 82816 -48 -0.1
noinit 37160 37160 0 0.0
text 566032 566336 304 0.1

@andy31415 andy31415 merged commit c454363 into project-chip:master Dec 10, 2021
@rcasallas-silabs rcasallas-silabs deleted the group_data_provider_update branch February 2, 2022 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple left review comments

@woody-apple woody-apple woody-apple approved these changes

@kpschoedel kpschoedel kpschoedel approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@pan-apple pan-apple Awaiting requested review from pan-apple

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

Assignees
No one assigned
Labels
app lib review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rcasallas-silabs @woody-apple @bzbarsky-apple @kpschoedel @andy31415