Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix IM Event Persistent counter init #12922

Conversation

yunhanw-google
Copy link
Contributor

@yunhanw-google yunhanw-google commented Dec 11, 2021

Problem

Fix M Event Persistent counter init, when Persistent counter init success, use this persistent counter

Change overview

See above

Testing

Manually check persistent counter over several reboot on all-cluster-app

@github-actions
Copy link

github-actions bot commented Dec 11, 2021

PR #12922: Size comparison from edbbd7f to bd57f19

Increases (10 builds for esp32, mbed, nrfconnect)
platform target config section edbbd7f bd57f19 change % change
esp32 all-clusters-app m5stack (read only) 960075 960079 4 0.0
.flash.text 954691 954695 4 0.0
mbed lighting-app CY8CPROTO_062_4343W+release (read/write) 2309040 2309104 64 0.0
.text 1271640 1271704 64 0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2282160 2282224 64 0.0
.text 1244760 1244824 64 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 text 613140 613144 4 0.0
nrf52840dk_nrf52840+rpc (read/write) 869987 870003 16 0.0
text 587884 587888 4 0.0
nrf5340dk_nrf5340_cpuapp text 543568 543572 4 0.0
lock-app nrf52840dk_nrf52840 text 592584 592588 4 0.0
nrf5340dk_nrf5340_cpuapp text 523104 523108 4 0.0
pump-app nrf52840dk_nrf52840 text 596176 596180 4 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 877731 877747 16 0.0
text 591372 591376 4 0.0
Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section edbbd7f bd57f19 change % change
efr32 lighting-app BRD4161A (read only) 814844 814844 0 0.0
(read/write) 123132 123132 0 0.0
.bss 121272 121272 0 0.0
.data 1860 1860 0 0.0
.text 814836 814836 0 0.0
BRD4161A+rpc (read only) 802476 802476 0 0.0
(read/write) 139808 139808 0 0.0
.bss 137848 137848 0 0.0
.data 1960 1960 0 0.0
.text 802468 802468 0 0.0
window-app BRD4161A (read only) 791920 791920 0 0.0
(read/write) 122080 122080 0 0.0
.bss 120256 120256 0 0.0
.data 1824 1824 0 0.0
.text 791912 791912 0 0.0
esp32 all-clusters-app c3devkit (read only) 856438 856438 0 0.0
(read/write) 1304266 1304266 0 0.0
.dram0.bss 64680 64680 0 0.0
.dram0.data 14124 14124 0 0.0
.flash.rodata 172424 172424 0 0.0
.flash.text 856438 856438 0 0.0
.iram0.text 62076 62076 0 0.0
m5stack (read only) 960075 960079 4 0.0
(read/write) 449992 449992 0 0.0
.dram0.bss 73960 73960 0 0.0
.dram0.data 34048 34048 0 0.0
.flash.rodata 210196 210196 0 0.0
.flash.text 954691 954695 4 0.0
.iram0.text 123451 123451 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 669632 669632 0 0.0
.bss 73856 73856 0 0.0
.data 1892 1892 0 0.0
.text 588084 588084 0 0.0
lock-app k32w061+debug (read/write) 619584 619584 0 0.0
.bss 72008 72008 0 0.0
.data 1852 1852 0 0.0
.text 539924 539924 0 0.0
shell k32w061+debug (read/write) 624904 624904 0 0.0
.bss 74316 74316 0 0.0
.data 1832 1832 0 0.0
.text 542956 542956 0 0.0
linux chip-tool-ipv6only arm64 (read only) 6861276 6861276 0 0.0
(read/write) 318657 318657 0 0.0
.bss 51889 51889 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 208384 208384 0 0.0
.dynamic 560 560 0 0.0
.got 53456 53456 0 0.0
.init 24 24 0 0.0
.init_array 176 176 0 0.0
.rodata 364972 364972 0 0.0
.text 5816212 5816212 0 0.0
thermostat-no-ble arm64 (read only) 1947956 1947956 0 0.0
(read/write) 137185 137185 0 0.0
.bss 59505 59505 0 0.0
.data 832 832 0 0.0
.data.rel.ro 70344 70344 0 0.0
.dynamic 560 560 0 0.0
.got 3624 3624 0 0.0
.init 24 24 0 0.0
.init_array 272 272 0 0.0
.rodata 125476 125476 0 0.0
.text 1614704 1614704 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2313248 2313248 0 0.0
.bss 183948 183948 0 0.0
.data 5232 5232 0 0.0
.heap 847264 847264 0 0.0
.text 1275824 1275824 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2309040 2309104 64 0.0
.bss 175808 175808 0 0.0
.data 5528 5528 0 0.0
.heap 855112 855112 0 0.0
.text 1271640 1271704 64 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2282160 2282224 64 0.0
.bss 174848 174848 0 0.0
.data 5520 5520 0 0.0
.heap 856080 856080 0 0.0
.text 1244760 1244824 64 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4376 4376 0 0.0
.heap 1020312 1020312 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2053672 2053672 0 0.0
.bss 156980 156980 0 0.0
.data 4864 4864 0 0.0
.heap 874600 874600 0 0.0
.text 1016272 1016272 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 906939 906939 0 0.0
bss 116280 116280 0 0.0
rodata 101932 101932 0 0.0
text 613140 613144 4 0.0
nrf52840dk_nrf52840+rpc (read/write) 869987 870003 16 0.0
bss 112628 112628 0 0.0
rodata 93228 93228 0 0.0
text 587884 587888 4 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 832938 832938 0 0.0
bss 117656 117656 0 0.0
rodata 97188 97188 0 0.0
text 543568 543572 4 0.0
lock-app nrf52840dk_nrf52840 (read/write) 879599 879599 0 0.0
bss 113544 113544 0 0.0
rodata 98048 98048 0 0.0
text 592584 592588 4 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 805838 805838 0 0.0
bss 114952 114952 0 0.0
rodata 93336 93336 0 0.0
text 523104 523108 4 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497463 497463 0 0.0
bss 51820 51820 0 0.0
rodata 45852 45852 0 0.0
text 339492 339492 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 884535 884535 0 0.0
bss 113456 113456 0 0.0
rodata 99400 99400 0 0.0
text 596176 596180 4 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 877731 877747 16 0.0
bss 113332 113332 0 0.0
rodata 97540 97540 0 0.0
text 591372 591376 4 0.0
shell nrf52840dk_nrf52840 (read/write) 782283 782283 0 0.0
bss 109624 109624 0 0.0
rodata 74296 74296 0 0.0
text 523852 523852 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 697362 697362 0 0.0
bss 110604 110604 0 0.0
rodata 68940 68940 0 0.0
text 444492 444492 0 0.0
p6 all-clusters-app default (read/write) 2359800 2359800 0 0.0
.bss 112148 112148 0 0.0
.data 2520 2520 0 0.0
.heap 918672 918672 0 0.0
.text 1318064 1318064 0 0.0
light-app default (read/write) 2300384 2300384 0 0.0
.bss 101064 101064 0 0.0
.data 2360 2360 0 0.0
.heap 929920 929920 0 0.0
.text 1258648 1258648 0 0.0
lock-app default (read/write) 2276456 2276456 0 0.0
.bss 99944 99944 0 0.0
.data 2328 2328 0 0.0
.heap 931072 931072 0 0.0
.text 1234720 1234720 0 0.0
qpg lighting-app qpg6100+debug (read only) 521412 521412 0 0.0
(read/write) 122336 122336 0 0.0
.bss 82696 82696 0 0.0
.data 992 992 0 0.0
.text 516092 516092 0 0.0
lock-app qpg6100+debug (read only) 495800 495800 0 0.0
(read/write) 122332 122332 0 0.0
.bss 81832 81832 0 0.0
.data 948 948 0 0.0
.text 490480 490480 0 0.0
persistent-storage-app qpg6100+debug (read only) 108104 108104 0 0.0
(read/write) 122336 122336 0 0.0
.bss 36160 36160 0 0.0
.data 288 288 0 0.0
.text 102784 102784 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 811418 811418 0 0.0
bss 82848 82848 0 0.0
noinit 37160 37160 0 0.0
text 566528 566528 0 0.0

@yunhanw-google yunhanw-google merged commit 654c3e1 into project-chip:master Dec 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants