Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[msg] Fix counter init. #12948

Merged
merged 1 commit into from
Dec 14, 2021
Merged

[msg] Fix counter init. #12948

merged 1 commit into from
Dec 14, 2021

Conversation

turon
Copy link
Contributor

@turon turon commented Dec 13, 2021

Problem

Specification updated some details on message initialization to fix rare but possible off-by-one errors.

Change overview

Implement fixes to message initialization mandated by spec.

Testing

local and CI

@github-actions
Copy link

github-actions bot commented Dec 13, 2021 •
edited
Loading

PR #12948: Size comparison from 73776ef to 75bb177

Increases (5 builds for esp32, linux, qpg, telink)
platform target config section 73776ef 75bb177 change % change
esp32 all-clusters-app c3devkit (read only) 857188 857190 2 0.0
.flash.text 857188 857190 2 0.0
m5stack (read only) 961251 961255 4 0.0
.flash.text 955867 955871 4 0.0
linux chip-tool-ipv6only arm64 (read only) 6873564 6873580 16 0.0
.text 5826788 5826804 16 0.0
qpg lighting-app qpg6100+debug (read only) 522160 522168 8 0.0
.text 516840 516848 8 0.0
telink lighting-app tlsr9518adk80d text 567218 567220 2 0.0
Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 73776ef 75bb177 change % change
efr32 lighting-app BRD4161A (read only) 815948 815948 0 0.0
(read/write) 123152 123152 0 0.0
.bss 121288 121288 0 0.0
.data 1864 1864 0 0.0
.text 815940 815940 0 0.0
BRD4161A+rpc (read only) 803580 803580 0 0.0
(read/write) 139828 139828 0 0.0
.bss 137864 137864 0 0.0
.data 1964 1964 0 0.0
.text 803572 803572 0 0.0
window-app BRD4161A (read only) 793008 793008 0 0.0
(read/write) 122104 122104 0 0.0
.bss 120272 120272 0 0.0
.data 1828 1828 0 0.0
.text 793000 793000 0 0.0
esp32 all-clusters-app c3devkit (read only) 857188 857190 2 0.0
(read/write) 1304450 1304450 0 0.0
.dram0.bss 64696 64696 0 0.0
.dram0.data 14164 14164 0 0.0
.flash.rodata 172544 172544 0 0.0
.flash.text 857188 857190 2 0.0
.iram0.text 62076 62076 0 0.0
m5stack (read only) 961251 961255 4 0.0
(read/write) 450260 450260 0 0.0
.dram0.bss 73984 73984 0 0.0
.dram0.data 34048 34048 0 0.0
.flash.rodata 210440 210440 0 0.0
.flash.text 955867 955871 4 0.0
.iram0.text 123451 123451 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 670408 670408 0 0.0
.bss 73872 73872 0 0.0
.data 1896 1896 0 0.0
.text 588840 588840 0 0.0
lock-app k32w061+debug (read/write) 620344 620344 0 0.0
.bss 72024 72024 0 0.0
.data 1856 1856 0 0.0
.text 540664 540664 0 0.0
shell k32w061+debug (read/write) 625712 625712 0 0.0
.bss 74332 74332 0 0.0
.data 1836 1836 0 0.0
.text 543744 543744 0 0.0
linux chip-tool-ipv6only arm64 (read only) 6873564 6873580 16 0.0
(read/write) 319201 319201 0 0.0
.bss 51921 51921 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 208784 208784 0 0.0
.dynamic 560 560 0 0.0
.got 53576 53576 0 0.0
.init 24 24 0 0.0
.init_array 176 176 0 0.0
.rodata 365692 365692 0 0.0
.text 5826788 5826804 16 0.0
thermostat-no-ble arm64 (read only) 1954660 1954660 0 0.0
(read/write) 137537 137537 0 0.0
.bss 59537 59537 0 0.0
.data 832 832 0 0.0
.data.rel.ro 70600 70600 0 0.0
.dynamic 560 560 0 0.0
.got 3680 3680 0 0.0
.init 24 24 0 0.0
.init_array 280 280 0 0.0
.rodata 125796 125796 0 0.0
.text 1620512 1620512 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2314032 2314032 0 0.0
.bss 183964 183964 0 0.0
.data 5240 5240 0 0.0
.heap 847240 847240 0 0.0
.text 1276608 1276608 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2309888 2309888 0 0.0
.bss 175824 175824 0 0.0
.data 5536 5536 0 0.0
.heap 855088 855088 0 0.0
.text 1272488 1272488 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2283000 2283000 0 0.0
.bss 174864 174864 0 0.0
.data 5528 5528 0 0.0
.heap 856056 856056 0 0.0
.text 1245600 1245600 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4376 4376 0 0.0
.heap 1020312 1020312 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2053944 2053944 0 0.0
.bss 156980 156980 0 0.0
.data 4864 4864 0 0.0
.heap 874600 874600 0 0.0
.text 1016544 1016544 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 907723 907723 0 0.0
bss 116300 116300 0 0.0
rodata 102060 102060 0 0.0
text 613756 613756 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 870775 870775 0 0.0
bss 112648 112648 0 0.0
rodata 93360 93360 0 0.0
text 588500 588500 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 833726 833726 0 0.0
bss 117672 117672 0 0.0
rodata 97320 97320 0 0.0
text 544184 544184 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 880339 880339 0 0.0
bss 113560 113560 0 0.0
rodata 98180 98180 0 0.0
text 593192 593192 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 806578 806578 0 0.0
bss 114972 114972 0 0.0
rodata 93468 93468 0 0.0
text 523712 523712 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497463 497463 0 0.0
bss 51820 51820 0 0.0
rodata 45852 45852 0 0.0
text 339492 339492 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 885291 885291 0 0.0
bss 113472 113472 0 0.0
rodata 99532 99532 0 0.0
text 596796 596796 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 878515 878515 0 0.0
bss 113352 113352 0 0.0
rodata 97668 97668 0 0.0
text 591992 591992 0 0.0
shell nrf52840dk_nrf52840 (read/write) 782427 782427 0 0.0
bss 109624 109624 0 0.0
rodata 74296 74296 0 0.0
text 523996 523996 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 697506 697506 0 0.0
bss 110604 110604 0 0.0
rodata 68940 68940 0 0.0
text 444636 444636 0 0.0
p6 all-clusters-app default (read/write) 2360976 2360976 0 0.0
.bss 112164 112164 0 0.0
.data 2528 2528 0 0.0
.heap 918648 918648 0 0.0
.text 1319240 1319240 0 0.0
light-app default (read/write) 2301568 2301568 0 0.0
.bss 101080 101080 0 0.0
.data 2368 2368 0 0.0
.heap 929896 929896 0 0.0
.text 1259832 1259832 0 0.0
lock-app default (read/write) 2277640 2277640 0 0.0
.bss 99960 99960 0 0.0
.data 2328 2328 0 0.0
.heap 931056 931056 0 0.0
.text 1235904 1235904 0 0.0
qpg lighting-app qpg6100+debug (read only) 522160 522168 8 0.0
(read/write) 122332 122332 0 0.0
.bss 82712 82712 0 0.0
.data 996 996 0 0.0
.text 516840 516848 8 0.0
lock-app qpg6100+debug (read only) 496532 496532 0 0.0
(read/write) 122336 122336 0 0.0
.bss 81848 81848 0 0.0
.data 952 952 0 0.0
.text 491212 491212 0 0.0
persistent-storage-app qpg6100+debug (read only) 108104 108104 0 0.0
(read/write) 122336 122336 0 0.0
.bss 36160 36160 0 0.0
.data 288 288 0 0.0
.text 102784 102784 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 812262 812262 0 0.0
bss 82864 82864 0 0.0
noinit 37160 37160 0 0.0
text 567218 567220 2 0.0

andy31415
andy31415 requested changes Dec 13, 2021
View reviewed changes
Copy link
Contributor

@andy31415 andy31415 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Request changes: please prove that GetRandU32() + 1 actually does something useful (show me python code that shows relevance) or remove that change.

@turon turon requested a review from andy31415 December 14, 2021 00:07
@restyled-io restyled-io bot mentioned this pull request Dec 14, 2021
Closed
@github-actions
Copy link

github-actions bot commented Dec 14, 2021 •
edited
Loading

PR #12948: Size comparison from 5d10320 to ee128b0

Increases (6 builds for esp32, linux, qpg, telink)
platform target config section 5d10320 ee128b0 change % change
esp32 all-clusters-app c3devkit (read only) 856682 856684 2 0.0
.flash.text 856682 856684 2 0.0
m5stack (read only) 960783 960787 4 0.0
.flash.text 955399 955403 4 0.0
linux thermostat-no-ble arm64 (read only) 1952452 1952468 16 0.0
.text 1618336 1618352 16 0.0
qpg lighting-app qpg6100+debug (read only) 521840 521848 8 0.0
.text 516520 516528 8 0.0
lock-app qpg6100+debug (read only) 496204 496212 8 0.0
.text 490884 490892 8 0.0
telink lighting-app tlsr9518adk80d (read/write) 811966 811974 8 0.0
text 566724 566726 2 0.0
Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 5d10320 ee128b0 change % change
efr32 lighting-app BRD4161A (read only) 815676 815676 0 0.0
(read/write) 123208 123208 0 0.0
.bss 121344 121344 0 0.0
.data 1864 1864 0 0.0
.text 815668 815668 0 0.0
BRD4161A+rpc (read only) 803292 803292 0 0.0
(read/write) 139884 139884 0 0.0
.bss 137920 137920 0 0.0
.data 1964 1964 0 0.0
.text 803284 803284 0 0.0
window-app BRD4161A (read only) 792752 792752 0 0.0
(read/write) 122160 122160 0 0.0
.bss 120328 120328 0 0.0
.data 1828 1828 0 0.0
.text 792744 792744 0 0.0
esp32 all-clusters-app c3devkit (read only) 856682 856684 2 0.0
(read/write) 1304650 1304650 0 0.0
.dram0.bss 64752 64752 0 0.0
.dram0.data 14164 14164 0 0.0
.flash.rodata 172696 172696 0 0.0
.flash.text 856682 856684 2 0.0
.iram0.text 62076 62076 0 0.0
m5stack (read only) 960783 960787 4 0.0
(read/write) 450468 450468 0 0.0
.dram0.bss 74040 74040 0 0.0
.dram0.data 34048 34048 0 0.0
.flash.rodata 210592 210592 0 0.0
.flash.text 955399 955403 4 0.0
.iram0.text 123451 123451 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 670112 670112 0 0.0
.bss 73928 73928 0 0.0
.data 1896 1896 0 0.0
.text 588488 588488 0 0.0
lock-app k32w061+debug (read/write) 620048 620048 0 0.0
.bss 72080 72080 0 0.0
.data 1856 1856 0 0.0
.text 540312 540312 0 0.0
shell k32w061+debug (read/write) 625416 625416 0 0.0
.bss 74388 74388 0 0.0
.data 1836 1836 0 0.0
.text 543392 543392 0 0.0
linux chip-tool-ipv6only arm64 (read only) 6876732 6876732 0 0.0
(read/write) 319281 319281 0 0.0
.bss 51873 51873 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 208760 208760 0 0.0
.dynamic 560 560 0 0.0
.got 53720 53720 0 0.0
.init 24 24 0 0.0
.init_array 176 176 0 0.0
.rodata 366092 366092 0 0.0
.text 5828772 5828772 0 0.0
thermostat-no-ble arm64 (read only) 1952452 1952468 16 0.0
(read/write) 137681 137681 0 0.0
.bss 59537 59537 0 0.0
.data 832 832 0 0.0
.data.rel.ro 70744 70744 0 0.0
.dynamic 560 560 0 0.0
.got 3680 3680 0 0.0
.init 24 24 0 0.0
.init_array 280 280 0 0.0
.rodata 125764 125764 0 0.0
.text 1618336 1618352 16 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2313720 2313720 0 0.0
.bss 184020 184020 0 0.0
.data 5240 5240 0 0.0
.heap 847184 847184 0 0.0
.text 1276296 1276296 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2309576 2309576 0 0.0
.bss 175880 175880 0 0.0
.data 5536 5536 0 0.0
.heap 855032 855032 0 0.0
.text 1272176 1272176 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2282688 2282688 0 0.0
.bss 174920 174920 0 0.0
.data 5520 5520 0 0.0
.heap 856008 856008 0 0.0
.text 1245288 1245288 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.heap 1020320 1020320 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2053944 2053944 0 0.0
.bss 156980 156980 0 0.0
.data 4864 4864 0 0.0
.heap 874600 874600 0 0.0
.text 1016544 1016544 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 907419 907419 0 0.0
bss 116352 116352 0 0.0
rodata 102220 102220 0 0.0
text 613272 613272 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 870479 870479 0 0.0
bss 112700 112700 0 0.0
rodata 93520 93520 0 0.0
text 588012 588012 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 833422 833422 0 0.0
bss 117728 117728 0 0.0
rodata 97480 97480 0 0.0
text 543696 543696 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 880083 880083 0 0.0
bss 113616 113616 0 0.0
rodata 98340 98340 0 0.0
text 592708 592708 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 806322 806322 0 0.0
bss 115024 115024 0 0.0
rodata 93628 93628 0 0.0
text 523224 523224 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497447 497447 0 0.0
bss 51820 51820 0 0.0
rodata 45852 45852 0 0.0
text 339488 339488 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 885019 885019 0 0.0
bss 113528 113528 0 0.0
rodata 99692 99692 0 0.0
text 596312 596312 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 878227 878227 0 0.0
bss 113404 113404 0 0.0
rodata 97828 97828 0 0.0
text 591508 591508 0 0.0
shell nrf52840dk_nrf52840 (read/write) 782427 782427 0 0.0
bss 109624 109624 0 0.0
rodata 74296 74296 0 0.0
text 523996 523996 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 697506 697506 0 0.0
bss 110604 110604 0 0.0
rodata 68940 68940 0 0.0
text 444636 444636 0 0.0
p6 all-clusters-app default (read/write) 2360712 2360712 0 0.0
.bss 112220 112220 0 0.0
.data 2528 2528 0 0.0
.heap 918592 918592 0 0.0
.text 1318976 1318976 0 0.0
light-app default (read/write) 2301288 2301288 0 0.0
.bss 101136 101136 0 0.0
.data 2368 2368 0 0.0
.heap 929840 929840 0 0.0
.text 1259552 1259552 0 0.0
lock-app default (read/write) 2277376 2277376 0 0.0
.bss 100016 100016 0 0.0
.data 2328 2328 0 0.0
.heap 931000 931000 0 0.0
.text 1235640 1235640 0 0.0
qpg lighting-app qpg6100+debug (read only) 521840 521848 8 0.0
(read/write) 122332 122332 0 0.0
.bss 82768 82768 0 0.0
.data 996 996 0 0.0
.text 516520 516528 8 0.0
lock-app qpg6100+debug (read only) 496204 496212 8 0.0
(read/write) 122336 122336 0 0.0
.bss 81904 81904 0 0.0
.data 952 952 0 0.0
.text 490884 490892 8 0.0
persistent-storage-app qpg6100+debug (read only) 108104 108104 0 0.0
(read/write) 122336 122336 0 0.0
.bss 36160 36160 0 0.0
.data 288 288 0 0.0
.text 102784 102784 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 811966 811974 8 0.0
bss 82920 82920 0 0.0
noinit 37160 37160 0 0.0
text 566724 566726 2 0.0

@andy31415 andy31415 merged commit c7ff229 into project-chip:master Dec 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy31415 andy31415 andy31415 approved these changes

@msandstedt msandstedt msandstedt approved these changes

@emargolis emargolis emargolis approved these changes

@yunhanw-google yunhanw-google yunhanw-google approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@LuDuda LuDuda Awaiting requested review from LuDuda

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@mspang mspang Awaiting requested review from mspang

@pan-apple pan-apple Awaiting requested review from pan-apple

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

Assignees
No one assigned
Labels
review - pending transport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@turon @andy31415 @msandstedt @emargolis @yunhanw-google