Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Inet] Miscellaneous cleanup #12968

Merged
merged 1 commit into from
Dec 14, 2021
Merged

[Inet] Miscellaneous cleanup #12968

merged 1 commit into from
Dec 14, 2021

Conversation

kpschoedel
Copy link
Contributor

Change overview

  • Remove the pointer union from EndPointStateLwIP; the members can be safe private members of the respective EndPoint classes.
  • Remove some unused InetConfig definitions.
  • Remove the unused IPProtocol enum.
  • Streamline EndPointManagerImplPool size. Add k to constants.
  • Additional init/shutdown order checks; fixed TestAdvertiser and messaging/tests/echo shutdown.

Testing

CI; no additional functionality.

@kpschoedel
[Inet] Miscellaneous cleanup
9d8f607 
#### Change overview

- Remove the pointer `union` from `EndPointStateLwIP`; the members can be safe private members of the respective EndPoint classes.
- Remove some unused InetConfig definitions.
- Remove the unused `IPProtocol` enum.
- Streamline `EndPointManagerImplPool` size. Add `k` to constants.
- Additional init/shutdown order checks; fixed `TestAdvertiser` and `messaging/tests/echo` shutdown.

#### Testing

CI; no additional functionality.
@github-actions
Copy link

github-actions bot commented Dec 14, 2021 •
edited
Loading

PR #12968: Size comparison from 5d10320 to 9d8f607

Increases (29 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 5d10320 9d8f607 change % change
efr32 lighting-app BRD4161A (read only) 815676 815756 80 0.0
.text 815668 815748 80 0.0
BRD4161A+rpc (read only) 803292 803372 80 0.0
.text 803284 803364 80 0.0
window-app BRD4161A (read only) 792752 792832 80 0.0
.text 792744 792824 80 0.0
esp32 all-clusters-app c3devkit (read only) 856682 856764 82 0.0
(read/write) 1304650 1304674 24 0.0
.flash.rodata 172696 172720 24 0.0
.flash.text 856682 856764 82 0.0
m5stack (read only) 960783 960895 112 0.0
(read/write) 450468 450500 32 0.0
.flash.rodata 210592 210624 32 0.0
.flash.text 955399 955511 112 0.0
k32w lighting-app k32w061+se05x+release (read/write) 670112 670236 124 0.0
.text 588488 588612 124 0.0
lock-app k32w061+debug (read/write) 620048 620172 124 0.0
.text 540312 540436 124 0.0
shell k32w061+debug (read/write) 625416 625540 124 0.0
.text 543392 543516 124 0.0
linux chip-tool-ipv6only arm64 (read only) 6876732 6877372 640 0.0
.rodata 366092 366204 112 0.0
.text 5828772 5829300 528 0.0
thermostat-no-ble arm64 (read only) 1952452 1953012 560 0.0
.rodata 125764 125892 128 0.1
.text 1618336 1618768 432 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2313720 2313880 160 0.0
.text 1276296 1276456 160 0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2309576 2309728 152 0.0
.text 1272176 1272328 152 0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2282688 2282776 88 0.0
.text 1245288 1245376 88 0.0
shell CY8CPROTO_062_4343W+release (read/write) 2053944 2054192 248 0.0
.text 1016544 1016792 248 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 907419 907543 124 0.0
rodata 102220 102248 28 0.0
text 613272 613360 88 0.0
nrf52840dk_nrf52840+rpc (read/write) 870479 870587 108 0.0
rodata 93520 93548 28 0.0
text 588012 588100 88 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 833422 833546 124 0.0
rodata 97480 97508 28 0.0
text 543696 543788 92 0.0
lock-app nrf52840dk_nrf52840 (read/write) 880083 880191 108 0.0
rodata 98340 98368 28 0.0
text 592708 592796 88 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 806322 806446 124 0.0
rodata 93628 93656 28 0.0
text 523224 523316 92 0.0
pump-app nrf52840dk_nrf52840 (read/write) 885019 885143 124 0.0
rodata 99692 99720 28 0.0
text 596312 596400 88 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 878227 878351 124 0.0
rodata 97828 97856 28 0.0
text 591508 591596 88 0.0
shell nrf52840dk_nrf52840 (read/write) 782427 782583 156 0.0
rodata 74296 74324 28 0.0
text 523996 524124 128 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 697506 697654 148 0.0
rodata 68940 68968 28 0.0
text 444636 444760 124 0.0
p6 all-clusters-app default (read/write) 2360712 2360792 80 0.0
.text 1318976 1319056 80 0.0
light-app default (read/write) 2301288 2301368 80 0.0
.text 1259552 1259632 80 0.0
lock-app default (read/write) 2277376 2277456 80 0.0
.text 1235640 1235720 80 0.0
qpg lighting-app qpg6100+debug (read only) 521840 521956 116 0.0
.text 516520 516636 116 0.0
lock-app qpg6100+debug (read only) 496204 496320 116 0.0
.text 490884 491000 116 0.0
telink lighting-app tlsr9518adk80d (read/write) 811966 812090 124 0.0
text 566724 566820 96 0.0
Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 5d10320 9d8f607 change % change
efr32 lighting-app BRD4161A (read only) 815676 815756 80 0.0
(read/write) 123208 123208 0 0.0
.bss 121344 121344 0 0.0
.data 1864 1864 0 0.0
.text 815668 815748 80 0.0
BRD4161A+rpc (read only) 803292 803372 80 0.0
(read/write) 139884 139884 0 0.0
.bss 137920 137920 0 0.0
.data 1964 1964 0 0.0
.text 803284 803364 80 0.0
window-app BRD4161A (read only) 792752 792832 80 0.0
(read/write) 122160 122160 0 0.0
.bss 120328 120328 0 0.0
.data 1828 1828 0 0.0
.text 792744 792824 80 0.0
esp32 all-clusters-app c3devkit (read only) 856682 856764 82 0.0
(read/write) 1304650 1304674 24 0.0
.dram0.bss 64752 64752 0 0.0
.dram0.data 14164 14164 0 0.0
.flash.rodata 172696 172720 24 0.0
.flash.text 856682 856764 82 0.0
.iram0.text 62076 62076 0 0.0
m5stack (read only) 960783 960895 112 0.0
(read/write) 450468 450500 32 0.0
.dram0.bss 74040 74040 0 0.0
.dram0.data 34048 34048 0 0.0
.flash.rodata 210592 210624 32 0.0
.flash.text 955399 955511 112 0.0
.iram0.text 123451 123451 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 670112 670236 124 0.0
.bss 73928 73928 0 0.0
.data 1896 1896 0 0.0
.text 588488 588612 124 0.0
lock-app k32w061+debug (read/write) 620048 620172 124 0.0
.bss 72080 72080 0 0.0
.data 1856 1856 0 0.0
.text 540312 540436 124 0.0
shell k32w061+debug (read/write) 625416 625540 124 0.0
.bss 74388 74388 0 0.0
.data 1836 1836 0 0.0
.text 543392 543516 124 0.0
linux chip-tool-ipv6only arm64 (read only) 6876732 6877372 640 0.0
(read/write) 319281 319281 0 0.0
.bss 51873 51873 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 208760 208760 0 0.0
.dynamic 560 560 0 0.0
.got 53720 53720 0 0.0
.init 24 24 0 0.0
.init_array 176 176 0 0.0
.rodata 366092 366204 112 0.0
.text 5828772 5829300 528 0.0
thermostat-no-ble arm64 (read only) 1952452 1953012 560 0.0
(read/write) 137681 137681 0 0.0
.bss 59537 59537 0 0.0
.data 832 832 0 0.0
.data.rel.ro 70744 70744 0 0.0
.dynamic 560 560 0 0.0
.got 3680 3680 0 0.0
.init 24 24 0 0.0
.init_array 280 280 0 0.0
.rodata 125764 125892 128 0.1
.text 1618336 1618768 432 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2313720 2313880 160 0.0
.bss 184020 184020 0 0.0
.data 5240 5240 0 0.0
.heap 847184 847184 0 0.0
.text 1276296 1276456 160 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2309576 2309728 152 0.0
.bss 175880 175880 0 0.0
.data 5536 5536 0 0.0
.heap 855032 855032 0 0.0
.text 1272176 1272328 152 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2282688 2282776 88 0.0
.bss 174920 174920 0 0.0
.data 5520 5520 0 0.0
.heap 856008 856008 0 0.0
.text 1245288 1245376 88 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.heap 1020320 1020320 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2053944 2054192 248 0.0
.bss 156980 156980 0 0.0
.data 4864 4864 0 0.0
.heap 874600 874600 0 0.0
.text 1016544 1016792 248 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 907419 907543 124 0.0
bss 116352 116352 0 0.0
rodata 102220 102248 28 0.0
text 613272 613360 88 0.0
nrf52840dk_nrf52840+rpc (read/write) 870479 870587 108 0.0
bss 112700 112700 0 0.0
rodata 93520 93548 28 0.0
text 588012 588100 88 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 833422 833546 124 0.0
bss 117728 117728 0 0.0
rodata 97480 97508 28 0.0
text 543696 543788 92 0.0
lock-app nrf52840dk_nrf52840 (read/write) 880083 880191 108 0.0
bss 113616 113616 0 0.0
rodata 98340 98368 28 0.0
text 592708 592796 88 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 806322 806446 124 0.0
bss 115024 115024 0 0.0
rodata 93628 93656 28 0.0
text 523224 523316 92 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497447 497447 0 0.0
bss 51820 51820 0 0.0
rodata 45852 45852 0 0.0
text 339488 339488 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 885019 885143 124 0.0
bss 113528 113528 0 0.0
rodata 99692 99720 28 0.0
text 596312 596400 88 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 878227 878351 124 0.0
bss 113404 113404 0 0.0
rodata 97828 97856 28 0.0
text 591508 591596 88 0.0
shell nrf52840dk_nrf52840 (read/write) 782427 782583 156 0.0
bss 109624 109624 0 0.0
rodata 74296 74324 28 0.0
text 523996 524124 128 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 697506 697654 148 0.0
bss 110604 110604 0 0.0
rodata 68940 68968 28 0.0
text 444636 444760 124 0.0
p6 all-clusters-app default (read/write) 2360712 2360792 80 0.0
.bss 112220 112220 0 0.0
.data 2528 2528 0 0.0
.heap 918592 918592 0 0.0
.text 1318976 1319056 80 0.0
light-app default (read/write) 2301288 2301368 80 0.0
.bss 101136 101136 0 0.0
.data 2368 2368 0 0.0
.heap 929840 929840 0 0.0
.text 1259552 1259632 80 0.0
lock-app default (read/write) 2277376 2277456 80 0.0
.bss 100016 100016 0 0.0
.data 2328 2328 0 0.0
.heap 931000 931000 0 0.0
.text 1235640 1235720 80 0.0
qpg lighting-app qpg6100+debug (read only) 521840 521956 116 0.0
(read/write) 122332 122332 0 0.0
.bss 82768 82768 0 0.0
.data 996 996 0 0.0
.text 516520 516636 116 0.0
lock-app qpg6100+debug (read only) 496204 496320 116 0.0
(read/write) 122336 122336 0 0.0
.bss 81904 81904 0 0.0
.data 952 952 0 0.0
.text 490884 491000 116 0.0
persistent-storage-app qpg6100+debug (read only) 108104 108104 0 0.0
(read/write) 122336 122336 0 0.0
.bss 36160 36160 0 0.0
.data 288 288 0 0.0
.text 102784 102784 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 811966 812090 124 0.0
bss 82920 82920 0 0.0
noinit 37160 37160 0 0.0
text 566724 566820 96 0.0

@andy31415 andy31415 merged commit f7c8405 into project-chip:master Dec 14, 2021
@kpschoedel kpschoedel deleted the x7715-inet-misc branch December 14, 2021 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msandstedt msandstedt msandstedt approved these changes

@andy31415 andy31415 andy31415 approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@mspang mspang Awaiting requested review from mspang

@pan-apple pan-apple Awaiting requested review from pan-apple

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

Assignees
No one assigned
Labels
inet lib review - approved system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kpschoedel @andy31415 @msandstedt