Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix darwin zap test gen #13002

Merged
merged 1 commit into from
Dec 15, 2021
Merged

Fix darwin zap test gen #13002

merged 1 commit into from
Dec 15, 2021

Conversation

krypton36
Copy link
Contributor

Problem

When generating Darwin tests, there was no defined Log function. Added a Log function and updated string parameter for Darwin.

Change overview

  • Updated Zap files for Darwin to handle Log

Testing

Generated Darwin Zap files and ran XCTest.

@boring-cyborg boring-cyborg bot added the darwin label Dec 14, 2021
@krypton36 krypton36 mentioned this pull request Dec 14, 2021
Merged
@github-actions
Copy link

github-actions bot commented Dec 14, 2021 •
edited
Loading

PR #13002: Size comparison from 2b189f3 to 155706d

Full report (30 builds for efr32, esp32, k32w, mbed, nrfconnect, p6, qpg, telink)
platform target config section 2b189f3 155706d change % change
efr32 lighting-app BRD4161A (read only) 833464 833464 0 0.0
(read/write) 128608 128608 0 0.0
.bss 126744 126744 0 0.0
.data 1864 1864 0 0.0
.text 833456 833456 0 0.0
BRD4161A+rpc (read only) 821052 821052 0 0.0
(read/write) 145284 145284 0 0.0
.bss 143320 143320 0 0.0
.data 1964 1964 0 0.0
.text 821044 821044 0 0.0
window-app BRD4161A (read only) 810688 810688 0 0.0
(read/write) 127560 127560 0 0.0
.bss 125728 125728 0 0.0
.data 1828 1828 0 0.0
.text 810680 810680 0 0.0
esp32 all-clusters-app c3devkit (read only) 876720 876720 0 0.0
(read/write) 1313266 1313266 0 0.0
.dram0.bss 71056 71056 0 0.0
.dram0.data 14220 14220 0 0.0
.flash.rodata 174960 174960 0 0.0
.flash.text 876720 876720 0 0.0
.iram0.text 62076 62076 0 0.0
m5stack (read only) 964659 964659 0 0.0
(read/write) 454564 454564 0 0.0
.dram0.bss 77528 77528 0 0.0
.dram0.data 34048 34048 0 0.0
.flash.rodata 211200 211200 0 0.0
.flash.text 959275 959275 0 0.0
.iram0.text 123451 123451 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 687400 687400 0 0.0
.bss 79328 79328 0 0.0
.data 1896 1896 0 0.0
.text 600376 600376 0 0.0
lock-app k32w061+debug (read/write) 637324 637324 0 0.0
.bss 77480 77480 0 0.0
.data 1856 1856 0 0.0
.text 552188 552188 0 0.0
shell k32w061+debug (read/write) 642728 642728 0 0.0
.bss 79788 79788 0 0.0
.data 1836 1836 0 0.0
.text 555304 555304 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2334712 2334712 0 0.0
.bss 190316 190316 0 0.0
.data 5240 5240 0 0.0
.heap 840888 840888 0 0.0
.text 1297288 1297288 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2330304 2330304 0 0.0
.bss 182176 182176 0 0.0
.data 5536 5536 0 0.0
.heap 848736 848736 0 0.0
.text 1292904 1292904 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2303416 2303416 0 0.0
.bss 181216 181216 0 0.0
.data 5520 5520 0 0.0
.heap 849712 849712 0 0.0
.text 1266016 1266016 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.heap 1020320 1020320 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2054328 2054328 0 0.0
.bss 156980 156980 0 0.0
.data 4864 4864 0 0.0
.heap 874600 874600 0 0.0
.text 1016928 1016928 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 922887 922887 0 0.0
bss 119832 119832 0 0.0
rodata 103544 103544 0 0.0
text 623928 623928 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 885943 885943 0 0.0
bss 116180 116180 0 0.0
rodata 94840 94840 0 0.0
text 598668 598668 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 848902 848902 0 0.0
bss 121208 121208 0 0.0
rodata 98800 98800 0 0.0
text 554368 554368 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 897675 897675 0 0.0
bss 119012 119012 0 0.0
rodata 99660 99660 0 0.0
text 603572 603572 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 823934 823934 0 0.0
bss 120420 120420 0 0.0
rodata 94952 94952 0 0.0
text 534100 534100 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497447 497447 0 0.0
bss 51820 51820 0 0.0
rodata 45852 45852 0 0.0
text 339488 339488 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 902615 902615 0 0.0
bss 118924 118924 0 0.0
rodata 101016 101016 0 0.0
text 607172 607172 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 895823 895823 0 0.0
bss 118800 118800 0 0.0
rodata 99152 99152 0 0.0
text 602372 602372 0 0.0
shell nrf52840dk_nrf52840 (read/write) 782767 782767 0 0.0
bss 109624 109624 0 0.0
rodata 74396 74396 0 0.0
text 524232 524232 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 697838 697838 0 0.0
bss 110604 110604 0 0.0
rodata 69040 69040 0 0.0
text 444868 444868 0 0.0
p6 all-clusters-app default (read/write) 2387432 2387432 0 0.0
.bss 118516 118516 0 0.0
.data 2528 2528 0 0.0
.heap 912296 912296 0 0.0
.text 1345696 1345696 0 0.0
light-app default (read/write) 2327792 2327792 0 0.0
.bss 107432 107432 0 0.0
.data 2368 2368 0 0.0
.heap 923544 923544 0 0.0
.text 1286056 1286056 0 0.0
lock-app default (read/write) 2303856 2303856 0 0.0
.bss 106312 106312 0 0.0
.data 2336 2336 0 0.0
.heap 924696 924696 0 0.0
.text 1262120 1262120 0 0.0
qpg lighting-app qpg6105+debug (read only) 532120 532120 0 0.0
(read/write) 146940 146940 0 0.0
.bss 88080 88080 0 0.0
.data 992 992 0 0.0
.text 526800 526800 0 0.0
lock-app qpg6105+debug (read only) 506464 506464 0 0.0
(read/write) 146936 146936 0 0.0
.bss 87216 87216 0 0.0
.data 948 948 0 0.0
.text 501144 501144 0 0.0
persistent-storage-app qpg6105+debug (read only) 106448 106448 0 0.0
(read/write) 146938 146938 0 0.0
.bss 36146 36146 0 0.0
.data 288 288 0 0.0
.text 101128 101128 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 832126 832126 0 0.0
bss 88320 88320 0 0.0
noinit 37160 37160 0 0.0
text 579914 579914 0 0.0

bzbarsky-apple
bzbarsky-apple requested changes Dec 14, 2021
View reviewed changes
Copy link
Contributor

@bzbarsky-apple bzbarsky-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be exercised? Probably by adding TestLogCommands to the set of tests run on Darwin? This is the part that needs changes.

src/darwin/Framework/CHIP/templates/partials/test_cluster.zapt Show resolved Hide resolved
@krypton36
Copy link
Contributor Author

Shouldn't this be exercised? Probably by adding TestLogCommands to the set of tests run on Darwin? This is the part that needs changes.

I can make it reference TestLogCommands, but the previous functioning were added as objective C functions and I it would need more work to change the testCluster section to abide by using C++ functions.

@bzbarsky-apple
Copy link
Contributor

I'm not sure what C++ functions have do to with this? I was talking about adding 'TestLogCommands' to the Others list in src/darwin/Framework/CHIP/templates/tests.js and then that would exercise the code you are changing. You'll need to implement UserPrompt too, possibly as a no-op for now with a followup.

@github-actions
Copy link

github-actions bot commented Dec 14, 2021 •
edited
Loading

PR #13002: Size comparison from a486165 to db8bd8b

Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section a486165 db8bd8b change % change
efr32 lighting-app BRD4161A (read only) 834376 834376 0 0.0
(read/write) 128632 128632 0 0.0
.bss 126760 126760 0 0.0
.data 1868 1868 0 0.0
.text 834368 834368 0 0.0
BRD4161A+rpc (read only) 821964 821964 0 0.0
(read/write) 145304 145304 0 0.0
.bss 143336 143336 0 0.0
.data 1968 1968 0 0.0
.text 821956 821956 0 0.0
window-app BRD4161A (read only) 811616 811616 0 0.0
(read/write) 127576 127576 0 0.0
.bss 125744 125744 0 0.0
.data 1832 1832 0 0.0
.text 811608 811608 0 0.0
esp32 all-clusters-app c3devkit (read only) 877286 877286 0 0.0
(read/write) 1313434 1313434 0 0.0
.dram0.bss 71080 71080 0 0.0
.dram0.data 14220 14220 0 0.0
.flash.rodata 175096 175096 0 0.0
.flash.text 877286 877286 0 0.0
.iram0.text 62076 62076 0 0.0
m5stack (read only) 965191 965191 0 0.0
(read/write) 454720 454720 0 0.0
.dram0.bss 77552 77552 0 0.0
.dram0.data 34048 34048 0 0.0
.flash.rodata 211332 211332 0 0.0
.flash.text 959807 959807 0 0.0
.iram0.text 123451 123451 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 688072 688072 0 0.0
.bss 79344 79344 0 0.0
.data 1900 1900 0 0.0
.text 601028 601028 0 0.0
lock-app k32w061+debug (read/write) 638012 638012 0 0.0
.bss 77496 77496 0 0.0
.data 1860 1860 0 0.0
.text 552856 552856 0 0.0
shell k32w061+debug (read/write) 643416 643416 0 0.0
.bss 79804 79804 0 0.0
.data 1840 1840 0 0.0
.text 555972 555972 0 0.0
linux chip-tool-ipv6only arm64 (read only) 6894636 6894636 0 0.0
(read/write) 324033 324033 0 0.0
.bss 56001 56001 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 209248 209248 0 0.0
.dynamic 560 560 0 0.0
.got 53864 53864 0 0.0
.init 24 24 0 0.0
.init_array 176 176 0 0.0
.rodata 366380 366380 0 0.0
.text 5844996 5844996 0 0.0
thermostat-no-ble arm64 (read only) 2003596 2003596 0 0.0
(read/write) 145265 145265 0 0.0
.bss 65633 65633 0 0.0
.data 832 832 0 0.0
.data.rel.ro 72064 72064 0 0.0
.dynamic 560 560 0 0.0
.got 3840 3840 0 0.0
.init 24 24 0 0.0
.init_array 288 288 0 0.0
.rodata 127996 127996 0 0.0
.text 1664112 1664112 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2335416 2335416 0 0.0
.bss 190332 190332 0 0.0
.data 5248 5248 0 0.0
.heap 840864 840864 0 0.0
.text 1297992 1297992 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2330952 2330952 0 0.0
.bss 182192 182192 0 0.0
.data 5544 5544 0 0.0
.heap 848712 848712 0 0.0
.text 1293552 1293552 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2304072 2304072 0 0.0
.bss 181232 181232 0 0.0
.data 5528 5528 0 0.0
.heap 849688 849688 0 0.0
.text 1266672 1266672 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.heap 1020320 1020320 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2054328 2054328 0 0.0
.bss 156980 156980 0 0.0
.data 4864 4864 0 0.0
.heap 874600 874600 0 0.0
.text 1016928 1016928 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 923587 923587 0 0.0
bss 119852 119852 0 0.0
rodata 103620 103620 0 0.0
text 624512 624512 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 886627 886627 0 0.0
bss 116200 116200 0 0.0
rodata 94916 94916 0 0.0
text 599248 599248 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 849602 849602 0 0.0
bss 121224 121224 0 0.0
rodata 98876 98876 0 0.0
text 554948 554948 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 898327 898327 0 0.0
bss 119028 119028 0 0.0
rodata 99736 99736 0 0.0
text 604152 604152 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 824586 824586 0 0.0
bss 120440 120440 0 0.0
rodata 95028 95028 0 0.0
text 534684 534684 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497447 497447 0 0.0
bss 51820 51820 0 0.0
rodata 45852 45852 0 0.0
text 339488 339488 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 903283 903283 0 0.0
bss 118940 118940 0 0.0
rodata 101092 101092 0 0.0
text 607756 607756 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 896523 896523 0 0.0
bss 118820 118820 0 0.0
rodata 99228 99228 0 0.0
text 602952 602952 0 0.0
shell nrf52840dk_nrf52840 (read/write) 782767 782767 0 0.0
bss 109624 109624 0 0.0
rodata 74396 74396 0 0.0
text 524232 524232 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 697838 697838 0 0.0
bss 110604 110604 0 0.0
rodata 69040 69040 0 0.0
text 444868 444868 0 0.0
p6 all-clusters-app default (read/write) 2388392 2388392 0 0.0
.bss 118532 118532 0 0.0
.data 2536 2536 0 0.0
.heap 912272 912272 0 0.0
.text 1346656 1346656 0 0.0
light-app default (read/write) 2328696 2328696 0 0.0
.bss 107448 107448 0 0.0
.data 2376 2376 0 0.0
.heap 923520 923520 0 0.0
.text 1286960 1286960 0 0.0
lock-app default (read/write) 2304760 2304760 0 0.0
.bss 106328 106328 0 0.0
.data 2336 2336 0 0.0
.heap 924680 924680 0 0.0
.text 1263024 1263024 0 0.0
qpg lighting-app qpg6105+debug (read only) 532772 532772 0 0.0
(read/write) 146936 146936 0 0.0
.bss 88096 88096 0 0.0
.data 996 996 0 0.0
.text 527452 527452 0 0.0
lock-app qpg6105+debug (read only) 507140 507140 0 0.0
(read/write) 146940 146940 0 0.0
.bss 87232 87232 0 0.0
.data 952 952 0 0.0
.text 501820 501820 0 0.0
persistent-storage-app qpg6105+debug (read only) 106448 106448 0 0.0
(read/write) 146938 146938 0 0.0
.bss 36146 36146 0 0.0
.data 288 288 0 0.0
.text 101128 101128 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 832822 832822 0 0.0
bss 88336 88336 0 0.0
noinit 37160 37160 0 0.0
text 580512 580512 0 0.0

@krypton36
Copy link
Contributor Author

I'm not sure what C++ functions have do to with this? I was talking about adding 'TestLogCommands' to the Others list in src/darwin/Framework/CHIP/templates/tests.js and then that would exercise the code you are changing. You'll need to implement UserPrompt too, possibly as a no-op for now with a followup.

I understand what you are referring to now. I can add that test to the Others list and add a no opt for UserPrompt.

@krypton36
Copy link
Contributor Author

I'm not sure what C++ functions have do to with this? I was talking about adding 'TestLogCommands' to the Others list in src/darwin/Framework/CHIP/templates/tests.js and then that would exercise the code you are changing. You'll need to implement UserPrompt too, possibly as a no-op for now with a followup.

@bzbarsky-apple Ok. Updated the Darwin tests to run TestLogCommands

@github-actions
Copy link

github-actions bot commented Dec 15, 2021 •
edited
Loading

PR #13002: Size comparison from 9cc8269 to e35b65c

Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 9cc8269 e35b65c change % change
efr32 lighting-app BRD4161A (read only) 834376 834376 0 0.0
(read/write) 128632 128632 0 0.0
.bss 126760 126760 0 0.0
.data 1868 1868 0 0.0
.text 834368 834368 0 0.0
BRD4161A+rpc (read only) 821980 821980 0 0.0
(read/write) 145304 145304 0 0.0
.bss 143336 143336 0 0.0
.data 1968 1968 0 0.0
.text 821972 821972 0 0.0
window-app BRD4161A (read only) 811616 811616 0 0.0
(read/write) 127576 127576 0 0.0
.bss 125744 125744 0 0.0
.data 1832 1832 0 0.0
.text 811608 811608 0 0.0
esp32 all-clusters-app c3devkit (read only) 877288 877288 0 0.0
(read/write) 1313434 1313434 0 0.0
.dram0.bss 71080 71080 0 0.0
.dram0.data 14220 14220 0 0.0
.flash.rodata 175096 175096 0 0.0
.flash.text 877288 877288 0 0.0
.iram0.text 62076 62076 0 0.0
m5stack (read only) 965191 965191 0 0.0
(read/write) 454720 454720 0 0.0
.dram0.bss 77552 77552 0 0.0
.dram0.data 34048 34048 0 0.0
.flash.rodata 211332 211332 0 0.0
.flash.text 959807 959807 0 0.0
.iram0.text 123451 123451 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 688072 688072 0 0.0
.bss 79344 79344 0 0.0
.data 1900 1900 0 0.0
.text 601028 601028 0 0.0
lock-app k32w061+debug (read/write) 638012 638012 0 0.0
.bss 77496 77496 0 0.0
.data 1860 1860 0 0.0
.text 552856 552856 0 0.0
shell k32w061+debug (read/write) 643416 643416 0 0.0
.bss 79804 79804 0 0.0
.data 1840 1840 0 0.0
.text 555972 555972 0 0.0
linux chip-tool-ipv6only arm64 (read only) 6894636 6894636 0 0.0
(read/write) 324033 324033 0 0.0
.bss 56001 56001 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 209248 209248 0 0.0
.dynamic 560 560 0 0.0
.got 53864 53864 0 0.0
.init 24 24 0 0.0
.init_array 176 176 0 0.0
.rodata 366380 366380 0 0.0
.text 5844996 5844996 0 0.0
thermostat-no-ble arm64 (read only) 2003596 2003596 0 0.0
(read/write) 145265 145265 0 0.0
.bss 65633 65633 0 0.0
.data 832 832 0 0.0
.data.rel.ro 72064 72064 0 0.0
.dynamic 560 560 0 0.0
.got 3840 3840 0 0.0
.init 24 24 0 0.0
.init_array 288 288 0 0.0
.rodata 127996 127996 0 0.0
.text 1664112 1664112 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2335416 2335416 0 0.0
.bss 190332 190332 0 0.0
.data 5248 5248 0 0.0
.heap 840864 840864 0 0.0
.text 1297992 1297992 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2330952 2330952 0 0.0
.bss 182192 182192 0 0.0
.data 5544 5544 0 0.0
.heap 848712 848712 0 0.0
.text 1293552 1293552 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2304072 2304072 0 0.0
.bss 181232 181232 0 0.0
.data 5528 5528 0 0.0
.heap 849688 849688 0 0.0
.text 1266672 1266672 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.heap 1020320 1020320 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2054328 2054328 0 0.0
.bss 156980 156980 0 0.0
.data 4864 4864 0 0.0
.heap 874600 874600 0 0.0
.text 1016928 1016928 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 923587 923587 0 0.0
bss 119852 119852 0 0.0
rodata 103620 103620 0 0.0
text 624516 624516 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 886627 886627 0 0.0
bss 116200 116200 0 0.0
rodata 94916 94916 0 0.0
text 599252 599252 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 849602 849602 0 0.0
bss 121224 121224 0 0.0
rodata 98876 98876 0 0.0
text 554952 554952 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 898327 898327 0 0.0
bss 119028 119028 0 0.0
rodata 99736 99736 0 0.0
text 604156 604156 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 824602 824602 0 0.0
bss 120440 120440 0 0.0
rodata 95028 95028 0 0.0
text 534688 534688 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497447 497447 0 0.0
bss 51820 51820 0 0.0
rodata 45852 45852 0 0.0
text 339488 339488 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 903283 903283 0 0.0
bss 118940 118940 0 0.0
rodata 101092 101092 0 0.0
text 607760 607760 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 896523 896523 0 0.0
bss 118820 118820 0 0.0
rodata 99228 99228 0 0.0
text 602956 602956 0 0.0
shell nrf52840dk_nrf52840 (read/write) 782767 782767 0 0.0
bss 109624 109624 0 0.0
rodata 74396 74396 0 0.0
text 524232 524232 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 697838 697838 0 0.0
bss 110604 110604 0 0.0
rodata 69040 69040 0 0.0
text 444868 444868 0 0.0
p6 all-clusters-app default (read/write) 2388392 2388392 0 0.0
.bss 118532 118532 0 0.0
.data 2536 2536 0 0.0
.heap 912272 912272 0 0.0
.text 1346656 1346656 0 0.0
light-app default (read/write) 2328696 2328696 0 0.0
.bss 107448 107448 0 0.0
.data 2376 2376 0 0.0
.heap 923520 923520 0 0.0
.text 1286960 1286960 0 0.0
lock-app default (read/write) 2304760 2304760 0 0.0
.bss 106328 106328 0 0.0
.data 2336 2336 0 0.0
.heap 924680 924680 0 0.0
.text 1263024 1263024 0 0.0
qpg lighting-app qpg6105+debug (read only) 532772 532772 0 0.0
(read/write) 146936 146936 0 0.0
.bss 88096 88096 0 0.0
.data 996 996 0 0.0
.text 527452 527452 0 0.0
lock-app qpg6105+debug (read only) 507140 507140 0 0.0
(read/write) 146940 146940 0 0.0
.bss 87232 87232 0 0.0
.data 952 952 0 0.0
.text 501820 501820 0 0.0
persistent-storage-app qpg6105+debug (read only) 106448 106448 0 0.0
(read/write) 146938 146938 0 0.0
.bss 36146 36146 0 0.0
.data 288 288 0 0.0
.text 101128 101128 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 832822 832822 0 0.0
bss 88336 88336 0 0.0
noinit 37160 37160 0 0.0
text 580514 580514 0 0.0

@bzbarsky-apple
Copy link
Contributor

Fast-track: platform-specific test change with platform owner review.

@bzbarsky-apple
Copy link
Contributor

/rebase

@github-actions
Copy link

github-actions bot commented Dec 15, 2021 •
edited
Loading

PR #13002: Size comparison from 9cc8269 to 64ee221

Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 9cc8269 64ee221 change % change
efr32 lighting-app BRD4161A (read only) 834376 834376 0 0.0
(read/write) 128632 128632 0 0.0
.bss 126760 126760 0 0.0
.data 1868 1868 0 0.0
.text 834368 834368 0 0.0
BRD4161A+rpc (read only) 821980 821980 0 0.0
(read/write) 145304 145304 0 0.0
.bss 143336 143336 0 0.0
.data 1968 1968 0 0.0
.text 821972 821972 0 0.0
window-app BRD4161A (read only) 811616 811616 0 0.0
(read/write) 127576 127576 0 0.0
.bss 125744 125744 0 0.0
.data 1832 1832 0 0.0
.text 811608 811608 0 0.0
esp32 all-clusters-app c3devkit (read only) 877288 877288 0 0.0
(read/write) 1313434 1313434 0 0.0
.dram0.bss 71080 71080 0 0.0
.dram0.data 14220 14220 0 0.0
.flash.rodata 175096 175096 0 0.0
.flash.text 877288 877288 0 0.0
.iram0.text 62076 62076 0 0.0
m5stack (read only) 965191 965191 0 0.0
(read/write) 454720 454720 0 0.0
.dram0.bss 77552 77552 0 0.0
.dram0.data 34048 34048 0 0.0
.flash.rodata 211332 211332 0 0.0
.flash.text 959807 959807 0 0.0
.iram0.text 123451 123451 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 688072 688072 0 0.0
.bss 79344 79344 0 0.0
.data 1900 1900 0 0.0
.text 601028 601028 0 0.0
lock-app k32w061+debug (read/write) 638012 638012 0 0.0
.bss 77496 77496 0 0.0
.data 1860 1860 0 0.0
.text 552856 552856 0 0.0
shell k32w061+debug (read/write) 643416 643416 0 0.0
.bss 79804 79804 0 0.0
.data 1840 1840 0 0.0
.text 555972 555972 0 0.0
linux chip-tool-ipv6only arm64 (read only) 6894636 6894636 0 0.0
(read/write) 324033 324033 0 0.0
.bss 56001 56001 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 209248 209248 0 0.0
.dynamic 560 560 0 0.0
.got 53864 53864 0 0.0
.init 24 24 0 0.0
.init_array 176 176 0 0.0
.rodata 366380 366380 0 0.0
.text 5844996 5844996 0 0.0
thermostat-no-ble arm64 (read only) 2003596 2003596 0 0.0
(read/write) 145265 145265 0 0.0
.bss 65633 65633 0 0.0
.data 832 832 0 0.0
.data.rel.ro 72064 72064 0 0.0
.dynamic 560 560 0 0.0
.got 3840 3840 0 0.0
.init 24 24 0 0.0
.init_array 288 288 0 0.0
.rodata 127996 127996 0 0.0
.text 1664112 1664112 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2335416 2335416 0 0.0
.bss 190332 190332 0 0.0
.data 5248 5248 0 0.0
.heap 840864 840864 0 0.0
.text 1297992 1297992 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2330952 2330952 0 0.0
.bss 182192 182192 0 0.0
.data 5544 5544 0 0.0
.heap 848712 848712 0 0.0
.text 1293552 1293552 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2304072 2304072 0 0.0
.bss 181232 181232 0 0.0
.data 5528 5528 0 0.0
.heap 849688 849688 0 0.0
.text 1266672 1266672 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.heap 1020320 1020320 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2054328 2054328 0 0.0
.bss 156980 156980 0 0.0
.data 4864 4864 0 0.0
.heap 874600 874600 0 0.0
.text 1016928 1016928 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 923587 923587 0 0.0
bss 119852 119852 0 0.0
rodata 103620 103620 0 0.0
text 624516 624516 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 886627 886627 0 0.0
bss 116200 116200 0 0.0
rodata 94916 94916 0 0.0
text 599252 599252 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 849602 849602 0 0.0
bss 121224 121224 0 0.0
rodata 98876 98876 0 0.0
text 554952 554952 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 898327 898327 0 0.0
bss 119028 119028 0 0.0
rodata 99736 99736 0 0.0
text 604156 604156 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 824602 824602 0 0.0
bss 120440 120440 0 0.0
rodata 95028 95028 0 0.0
text 534688 534688 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497447 497447 0 0.0
bss 51820 51820 0 0.0
rodata 45852 45852 0 0.0
text 339488 339488 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 903283 903283 0 0.0
bss 118940 118940 0 0.0
rodata 101092 101092 0 0.0
text 607760 607760 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 896523 896523 0 0.0
bss 118820 118820 0 0.0
rodata 99228 99228 0 0.0
text 602956 602956 0 0.0
shell nrf52840dk_nrf52840 (read/write) 782767 782767 0 0.0
bss 109624 109624 0 0.0
rodata 74396 74396 0 0.0
text 524232 524232 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 697838 697838 0 0.0
bss 110604 110604 0 0.0
rodata 69040 69040 0 0.0
text 444868 444868 0 0.0
p6 all-clusters-app default (read/write) 2388392 2388392 0 0.0
.bss 118532 118532 0 0.0
.data 2536 2536 0 0.0
.heap 912272 912272 0 0.0
.text 1346656 1346656 0 0.0
light-app default (read/write) 2328696 2328696 0 0.0
.bss 107448 107448 0 0.0
.data 2376 2376 0 0.0
.heap 923520 923520 0 0.0
.text 1286960 1286960 0 0.0
lock-app default (read/write) 2304760 2304760 0 0.0
.bss 106328 106328 0 0.0
.data 2336 2336 0 0.0
.heap 924680 924680 0 0.0
.text 1263024 1263024 0 0.0
qpg lighting-app qpg6105+debug (read only) 532772 532772 0 0.0
(read/write) 146936 146936 0 0.0
.bss 88096 88096 0 0.0
.data 996 996 0 0.0
.text 527452 527452 0 0.0
lock-app qpg6105+debug (read only) 507140 507140 0 0.0
(read/write) 146940 146940 0 0.0
.bss 87232 87232 0 0.0
.data 952 952 0 0.0
.text 501820 501820 0 0.0
persistent-storage-app qpg6105+debug (read only) 106448 106448 0 0.0
(read/write) 146938 146938 0 0.0
.bss 36146 36146 0 0.0
.data 288 288 0 0.0
.text 101128 101128 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 832822 832822 0 0.0
bss 88336 88336 0 0.0
noinit 37160 37160 0 0.0
text 580514 580514 0 0.0

@bzbarsky-apple bzbarsky-apple merged commit 82cbdc0 into project-chip:master Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@LuDuda LuDuda Awaiting requested review from LuDuda

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@pan-apple pan-apple Awaiting requested review from pan-apple

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@vijs vijs Awaiting requested review from vijs

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

Assignees
No one assigned
Labels
darwin fast track review - pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krypton36 @bzbarsky-apple