Restyle Fix YAML tests handling of lists of structs that contain lists. #13143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![restyled-io[bot]](https://avatars.githubusercontent.com/in/5851?s=60&v=4){kind=small}
The main issue was that comparing to such a value failed because we ended up with "iter" variables for both levels of list nesting that name-collided. The fix for that was to add "depth" disabmbiguation like we have in the Darwin codegen already. While adding a test for this, a few other issues were encountered: 1) The "commandValue" partial, when dealing with an optional or nullable struct, would do an Emplace() or SetNonNull() for every single member, which would wipe out earlier members. The fix for that is to do them once, and then use .Value() for the recursive partial invocation. 2) When sending a struct with optional fields, we were requiring the YAML to specify values for all the fields. Added if_include_struct_item_value to allow the YAML to not include values for such fields. 3) The YAML for checking struct values expected struct field names in the YAML to be lowerCamelCase instead of matching the XML case. The code for sending struct values expected struct field names to match the XML case. This inconsistency was very confusing, and this PR makes both expect the XML case. I verified that the only codegen changes due to this were in the TestModeSelectCluster and Test_TC_DM_2_2 tests. The latter had actually had its struct fields ignored because they were the "wrong" case.... Both tests fixed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A duplicate of #13142 with additional commits that automatically address
incorrect style, created by Restyled.
Please review accordingly.
Since the original Pull Request was opened as a fork in a contributor's
repository, we are unable to create a Pull Request branching from it with only
the style fixes.
The following Restylers made fixes:
To incorporate these changes, you can either:
Merge this Pull Request instead of the original, or
Ask your contributor to locally incorporate these commits and push them to
the original Pull Request
Expand for example instructions
NOTE: As work continues on the original Pull Request, this process will
re-run and update (force-push) this Pull Request with updated style fixes as
necessary. If the style is fixed manually at any point (i.e. this process finds
no fixes to make), this Pull Request will be closed automatically.
Sorry if this was unexpected. To disable it, see our documentation.