Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add initial cluster data version support #13400

Merged
merged 4 commits into from
Feb 1, 2022
Merged

Add initial cluster data version support #13400

merged 4 commits into from
Feb 1, 2022

Conversation

yunhanw-google
Copy link
Contributor

@yunhanw-google yunhanw-google commented Jan 9, 2022 •
edited
Loading

Problem

Need to integrate cluster data version storage with IM

Change overview

Update ReadHandler/Engine to retrieve version from ember, and process version in read client side.

Testing

Manually observe the data version change using IM read/write interaction.

@github-actions
Copy link

github-actions bot commented Jan 9, 2022 •
edited
Loading

PR #13400: Size comparison from b7ff37e to 20dad18

Increases above 0.2%:

platform target config section b7ff37e 20dad18 change % change
linux thermostat-no-ble arm64 .got 4000 4016 16 0.4
Increases (25 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section b7ff37e 20dad18 change % change
efr32 lighting-app BRD4161A (read only) 829244 830100 856 0.1
(read/write) 126996 127004 8 0.0
.bss 125120 125128 8 0.0
.text 829236 830092 856 0.1
BRD4161A+rpc (read only) 816888 817744 856 0.1
(read/write) 143656 143672 16 0.0
.bss 141680 141696 16 0.0
.text 816880 817736 856 0.1
window-app BRD4161A (read only) 802692 803564 872 0.1
(read/write) 125936 125944 8 0.0
.bss 124104 124112 8 0.0
.text 802684 803556 872 0.1
esp32 all-clusters-app c3devkit (read only) 891904 892486 582 0.1
(read/write) 1314010 1314210 200 0.0
.dram0.bss 69464 69480 16 0.0
.flash.rodata 177248 177432 184 0.1
.flash.text 891904 892486 582 0.1
m5stack (read only) 951843 952307 464 0.0
(read/write) 445592 445776 184 0.0
.dram0.bss 73960 73968 8 0.0
.flash.rodata 206560 206736 176 0.1
.flash.text 946459 946923 464 0.0
k32w light k32w061+release (read/write) 655324 656092 768 0.1
.bss 76776 76784 8 0.0
.text 570900 571660 760 0.1
lock k32w061+release (read/write) 659632 660408 776 0.1
.bss 77072 77088 16 0.0
.text 574892 575652 760 0.1
linux chip-tool-ipv6only arm64 (read only) 7105148 7107468 2320 0.0
(read/write) 327009 327137 128 0.0
.bss 54865 54881 16 0.0
.data.rel.ro 209392 209488 96 0.0
.got 57968 57984 16 0.0
.rodata 388884 389156 272 0.1
.text 6019716 6021524 1808 0.0
thermostat-no-ble arm64 (read only) 2033868 2035932 2064 0.1
(read/write) 145089 145217 128 0.1
.bss 64657 64673 16 0.0
.data.rel.ro 72624 72720 96 0.1
.got 4000 4016 16 0.4
.rodata 128988 129260 272 0.2
.text 1691232 1692784 1552 0.1
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2348560 2349288 728 0.0
.bss 188724 188740 16 0.0
.text 1311136 1311864 728 0.1
lighting-app CY8CPROTO_062_4343W+release (read/write) 2330752 2331416 664 0.0
.bss 180544 180560 16 0.0
.text 1293352 1294016 664 0.1
lock-app CY8CPROTO_062_4343W+release (read/write) 2303904 2304576 672 0.0
.bss 179592 179608 16 0.0
.text 1266504 1267176 672 0.1
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 937115 937903 788 0.1
bss 118112 118124 12 0.0
rodata 108120 108332 212 0.2
text 633324 633868 544 0.1
nrf52840dk_nrf52840+rpc (read/write) 923511 924263 752 0.1
bss 115156 115168 12 0.0
rodata 101548 101756 208 0.2
text 628636 629180 544 0.1
nrf5340dk_nrf5340_cpuapp (read/write) 848094 848846 752 0.1
bss 116004 116016 12 0.0
rodata 101296 101504 208 0.2
text 550256 550800 544 0.1
lock-app nrf52840dk_nrf52840 (read/write) 909259 909999 740 0.1
bss 117300 117312 12 0.0
rodata 103392 103604 212 0.2
text 611188 611728 540 0.1
nrf5340dk_nrf5340_cpuapp (read/write) 820418 821170 752 0.1
bss 115220 115232 12 0.0
rodata 96620 96828 208 0.2
text 528164 528704 540 0.1
pump-app nrf52840dk_nrf52840 (read/write) 910523 911275 752 0.1
bss 117060 117072 12 0.0
rodata 103608 103816 208 0.2
text 612404 612944 540 0.1
pump-controller-app nrf52840dk_nrf52840 (read/write) 907339 908111 772 0.1
bss 117088 117100 12 0.0
rodata 102864 103076 212 0.2
text 609936 610476 540 0.1
p6 all-clusters-app default (read/write) 2401656 2402504 848 0.0
.bss 116804 116812 8 0.0
.text 1359920 1360768 848 0.1
light-app default (read/write) 2323680 2324552 872 0.0
.bss 105672 105680 8 0.0
.text 1281944 1282816 872 0.1
lock-app default (read/write) 2295904 2296760 856 0.0
.bss 104552 104560 8 0.0
.text 1254168 1255024 856 0.1
qpg lighting-app qpg6105+debug (read only) 533192 533872 680 0.1
.bss 86624 86632 8 0.0
.text 527872 528552 680 0.1
lock-app qpg6105+debug (read only) 504968 505648 680 0.1
.bss 85760 85768 8 0.0
.text 499648 500328 680 0.1
telink lighting-app tlsr9518adk80d (read/write) 834522 835338 816 0.1
bss 86924 86932 8 0.0
text 582766 583356 590 0.1
Full report (31 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section b7ff37e 20dad18 change % change
efr32 lighting-app BRD4161A (read only) 829244 830100 856 0.1
(read/write) 126996 127004 8 0.0
.bss 125120 125128 8 0.0
.data 1876 1876 0 0.0
.text 829236 830092 856 0.1
BRD4161A+rpc (read only) 816888 817744 856 0.1
(read/write) 143656 143672 16 0.0
.bss 141680 141696 16 0.0
.data 1976 1976 0 0.0
.text 816880 817736 856 0.1
window-app BRD4161A (read only) 802692 803564 872 0.1
(read/write) 125936 125944 8 0.0
.bss 124104 124112 8 0.0
.data 1832 1832 0 0.0
.text 802684 803556 872 0.1
esp32 all-clusters-app c3devkit (read only) 891904 892486 582 0.1
(read/write) 1314010 1314210 200 0.0
.dram0.bss 69464 69480 16 0.0
.dram0.data 14236 14236 0 0.0
.flash.rodata 177248 177432 184 0.1
.flash.text 891904 892486 582 0.1
.iram0.text 62254 62254 0 0.0
m5stack (read only) 951843 952307 464 0.0
(read/write) 445592 445776 184 0.0
.dram0.bss 73960 73968 8 0.0
.dram0.data 34064 34064 0 0.0
.flash.rodata 206560 206736 176 0.1
.flash.text 946459 946923 464 0.0
.iram0.text 122671 122671 0 0.0
k32w light k32w061+release (read/write) 655324 656092 768 0.1
.bss 76776 76784 8 0.0
.data 1848 1848 0 0.0
.text 570900 571660 760 0.1
lock k32w061+release (read/write) 659632 660408 776 0.1
.bss 77072 77088 16 0.0
.data 1868 1868 0 0.0
.text 574892 575652 760 0.1
linux chip-tool-ipv6only arm64 (read only) 7105148 7107468 2320 0.0
(read/write) 327009 327137 128 0.0
.bss 54865 54881 16 0.0
.data 1096 1096 0 0.0
.data.rel.ro 209392 209488 96 0.0
.dynamic 560 560 0 0.0
.got 57968 57984 16 0.0
.init 24 24 0 0.0
.init_array 168 168 0 0.0
.rodata 388884 389156 272 0.1
.text 6019716 6021524 1808 0.0
thermostat-no-ble arm64 (read only) 2033868 2035932 2064 0.1
(read/write) 145089 145217 128 0.1
.bss 64657 64673 16 0.0
.data 880 880 0 0.0
.data.rel.ro 72624 72720 96 0.1
.dynamic 560 560 0 0.0
.got 4000 4016 16 0.4
.init 24 24 0 0.0
.init_array 296 296 0 0.0
.rodata 128988 129260 272 0.2
.text 1691232 1692784 1552 0.1
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2348560 2349288 728 0.0
.bss 188724 188740 16 0.0
.data 5312 5312 0 0.0
.text 1311136 1311864 728 0.1
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2330752 2331416 664 0.0
.bss 180544 180560 16 0.0
.data 5552 5552 0 0.0
.text 1293352 1294016 664 0.1
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2303904 2304576 672 0.0
.bss 179592 179608 16 0.0
.data 5544 5544 0 0.0
.text 1266504 1267176 672 0.1
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2054256 2054256 0 0.0
.bss 157060 157060 0 0.0
.data 4864 4864 0 0.0
.text 1016856 1016856 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 937115 937903 788 0.1
bss 118112 118124 12 0.0
rodata 108120 108332 212 0.2
text 633324 633868 544 0.1
nrf52840dk_nrf52840+rpc (read/write) 923511 924263 752 0.1
bss 115156 115168 12 0.0
rodata 101548 101756 208 0.2
text 628636 629180 544 0.1
nrf5340dk_nrf5340_cpuapp (read/write) 848094 848846 752 0.1
bss 116004 116016 12 0.0
rodata 101296 101504 208 0.2
text 550256 550800 544 0.1
lock-app nrf52840dk_nrf52840 (read/write) 909259 909999 740 0.1
bss 117300 117312 12 0.0
rodata 103392 103604 212 0.2
text 611188 611728 540 0.1
nrf5340dk_nrf5340_cpuapp (read/write) 820418 821170 752 0.1
bss 115220 115232 12 0.0
rodata 96620 96828 208 0.2
text 528164 528704 540 0.1
pigweed-app nrf52840dk_nrf52840 (read/write) 542351 542351 0 0.0
bss 52588 52588 0 0.0
rodata 50668 50668 0 0.0
text 376892 376892 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 910523 911275 752 0.1
bss 117060 117072 12 0.0
rodata 103608 103816 208 0.2
text 612404 612944 540 0.1
pump-controller-app nrf52840dk_nrf52840 (read/write) 907339 908111 772 0.1
bss 117088 117100 12 0.0
rodata 102864 103076 212 0.2
text 609936 610476 540 0.1
shell nrf52840dk_nrf52840 (read/write) 797935 797935 0 0.0
bss 109768 109768 0 0.0
rodata 78148 78148 0 0.0
text 533508 533508 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 710750 710750 0 0.0
bss 107656 107656 0 0.0
rodata 72448 72448 0 0.0
text 451188 451188 0 0.0
p6 all-clusters-app default (read/write) 2401656 2402504 848 0.0
.bss 116804 116812 8 0.0
.data 2592 2592 0 0.0
.text 1359920 1360768 848 0.1
light-app default (read/write) 2323680 2324552 872 0.0
.bss 105672 105680 8 0.0
.data 2384 2384 0 0.0
.text 1281944 1282816 872 0.1
lock-app default (read/write) 2295904 2296760 856 0.0
.bss 104552 104560 8 0.0
.data 2336 2336 0 0.0
.text 1254168 1255024 856 0.1
qpg lighting-app qpg6105+debug (read only) 533192 533872 680 0.1
(read/write) 146936 146936 0 0.0
.bss 86624 86632 8 0.0
.data 1004 1004 0 0.0
.text 527872 528552 680 0.1
lock-app qpg6105+debug (read only) 504968 505648 680 0.1
(read/write) 146940 146940 0 0.0
.bss 85760 85768 8 0.0
.data 952 952 0 0.0
.text 499648 500328 680 0.1
persistent-storage-app qpg6105+debug (read only) 106448 106448 0 0.0
(read/write) 146938 146938 0 0.0
.bss 36146 36146 0 0.0
.data 288 288 0 0.0
.text 101128 101128 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 834522 835338 816 0.1
bss 86924 86932 8 0.0
noinit 37160 37160 0 0.0
text 582766 583356 590 0.1

@yunhanw-google yunhanw-google force-pushed the feature/cluster_data_version1 branch from 20dad18 to f81b247 Compare January 10, 2022 16:55
@yunhanw-google yunhanw-google force-pushed the feature/cluster_data_version1 branch 2 times, most recently from a9ed39a to fb9726f Compare January 29, 2022 05:23
@github-actions
Copy link

github-actions bot commented Jan 29, 2022 •
edited
Loading

PR #13400: Size comparison from 6ba06b2 to fb9726f

Increases above 0.2%:

platform target config section 6ba06b2 fb9726f change % change
nrfconnect lock-app nrf5340dk_nrf5340_cpuapp rodata 97528 97736 208 0.2
pump-controller-app nrf52840dk_nrf52840 rodata 103936 104144 208 0.2
Increases (29 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 6ba06b2 fb9726f change % change
cyw30739 light cyw930739m2evb_01 (read/write) 578426 579050 624 0.1
.app_xip_area 484400 485024 624 0.1
lock-app CYW30739 (read/write) 536486 537110 624 0.1
.app_xip_area 444028 444652 624 0.1
efr32 lighting-app BRD4161A (read only) 843256 843904 648 0.1
.text 843248 843896 648 0.1
BRD4161A+rpc (read only) 830608 831256 648 0.1
.text 830600 831248 648 0.1
window-app BRD4161A (read only) 815848 816512 664 0.1
.text 815840 816504 664 0.1
esp32 all-clusters-app c3devkit (read only) 933898 934274 376 0.0
(read/write) 1398402 1398618 216 0.0
.flash.rodata 195256 195472 216 0.1
.flash.text 933898 934274 376 0.0
m5stack (read only) 981703 982055 352 0.0
(read/write) 462764 462972 208 0.0
.flash.rodata 221868 222076 208 0.1
.flash.text 976319 976671 352 0.0
k32w light k32w061+release (read/write) 663156 663684 528 0.1
.text 579020 579548 528 0.1
lock k32w061+release (read/write) 664188 664716 528 0.1
.text 579716 580244 528 0.1
linux chip-tool-ipv6only arm64 (read only) 6931844 6933668 1824 0.0
.rodata 396844 397036 192 0.0
.text 5952804 5954436 1632 0.0
thermostat-no-ble arm64 (read only) 2082348 2083820 1472 0.1
.rodata 130172 130364 192 0.1
.text 1734896 1736176 1280 0.1
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2383584 2384048 464 0.0
.text 1346184 1346648 464 0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2338040 2338504 464 0.0
.text 1300640 1301104 464 0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2302080 2302608 528 0.0
.text 1264680 1265208 528 0.0
shell CY8CPROTO_062_4343W+release (read/write) 2292756 2293284 528 0.0
.text 1255328 1255856 528 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 981695 982219 524 0.1
rodata 115684 115888 204 0.2
text 668420 668744 324 0.0
nrf52840dk_nrf52840+rpc (read/write) 967243 967771 528 0.1
rodata 107160 107368 208 0.2
text 664860 665188 328 0.0
nrf52840dongle_nrf52840 (read/write) 997747 998291 544 0.1
rodata 114516 114724 208 0.2
text 673828 674156 328 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 890866 891394 528 0.1
rodata 108964 109172 208 0.2
text 584596 584928 332 0.1
lock-app nrf52840dk_nrf52840 (read/write) 914307 914851 544 0.1
rodata 104320 104528 208 0.2
text 614464 614792 328 0.1
nrf5340dk_nrf5340_cpuapp (read/write) 824358 824902 544 0.1
rodata 97528 97736 208 0.2
text 531424 531756 332 0.1
pump-app nrf52840dk_nrf52840 (read/write) 917155 917699 544 0.1
rodata 104832 105040 208 0.2
text 616988 617316 328 0.1
pump-controller-app nrf52840dk_nrf52840 (read/write) 912355 912883 528 0.1
rodata 103936 104144 208 0.2
text 613040 613364 324 0.1
p6 all-clusters-app default (read/write) 2443344 2443992 648 0.0
.text 1401608 1402256 648 0.0
light-app default (read/write) 2338840 2339488 648 0.0
.text 1297104 1297752 648 0.0
lock-app default (read/write) 2304352 2305000 648 0.0
.text 1262616 1263264 648 0.1
qpg lighting-app qpg6105+debug (read only) 571076 571528 452 0.1
.text 565756 566208 452 0.1
lock-app qpg6105+debug (read only) 517252 517704 452 0.1
.text 511932 512384 452 0.1
telink lighting-app tlsr9518adk80d (read/write) 846138 846730 592 0.1
text 592758 593134 376 0.1
Full report (33 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 6ba06b2 fb9726f change % change
cyw30739 light cyw930739m2evb_01 (read/write) 578426 579050 624 0.1
.app_xip_area 484400 485024 624 0.1
.bss 76772 76772 0 0.0
.data 596 596 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock-app CYW30739 (read/write) 536486 537110 624 0.1
.app_xip_area 444028 444652 624 0.1
.bss 75244 75244 0 0.0
.data 560 560 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
efr32 lighting-app BRD4161A (read only) 843256 843904 648 0.1
(read/write) 126320 126320 0 0.0
.bss 124416 124416 0 0.0
.data 1900 1900 0 0.0
.text 843248 843896 648 0.1
BRD4161A+rpc (read only) 830608 831256 648 0.1
(read/write) 142976 142976 0 0.0
.bss 140976 140976 0 0.0
.data 2000 2000 0 0.0
.text 830600 831248 648 0.1
window-app BRD4161A (read only) 815848 816512 664 0.1
(read/write) 124948 124948 0 0.0
.bss 123092 123092 0 0.0
.data 1856 1856 0 0.0
.text 815840 816504 664 0.1
esp32 all-clusters-app c3devkit (read only) 933898 934274 376 0.0
(read/write) 1398402 1398618 216 0.0
.dram0.bss 69992 69992 0 0.0
.dram0.data 14244 14244 0 0.0
.flash.rodata 195256 195472 216 0.1
.flash.text 933898 934274 376 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 981703 982055 352 0.0
(read/write) 462764 462972 208 0.0
.dram0.bss 74744 74744 0 0.0
.dram0.data 34024 34024 0 0.0
.flash.rodata 221868 222076 208 0.1
.flash.text 976319 976671 352 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 663156 663684 528 0.1
.bss 76468 76468 0 0.0
.data 1868 1868 0 0.0
.text 579020 579548 528 0.1
lock k32w061+release (read/write) 664188 664716 528 0.1
.bss 76780 76780 0 0.0
.data 1892 1892 0 0.0
.text 579716 580244 528 0.1
linux chip-tool-ipv6only arm64 (read only) 6931844 6933668 1824 0.0
(read/write) 283201 283201 0 0.0
.bss 55553 55553 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 178216 178216 0 0.0
.dynamic 560 560 0 0.0
.got 44528 44528 0 0.0
.init 24 24 0 0.0
.init_array 200 200 0 0.0
.rodata 396844 397036 192 0.0
.text 5952804 5954436 1632 0.0
thermostat-no-ble arm64 (read only) 2082348 2083820 1472 0.1
(read/write) 149617 149617 0 0.0
.bss 67329 67329 0 0.0
.data 960 960 0 0.0
.data.rel.ro 74216 74216 0 0.0
.dynamic 560 560 0 0.0
.got 4144 4144 0 0.0
.init 24 24 0 0.0
.init_array 336 336 0 0.0
.rodata 130172 130364 192 0.1
.text 1734896 1736176 1280 0.1
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2383584 2384048 464 0.0
.bss 188892 188892 0 0.0
.data 5288 5288 0 0.0
.text 1346184 1346648 464 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2338040 2338504 464 0.0
.bss 179424 179424 0 0.0
.data 5584 5584 0 0.0
.text 1300640 1301104 464 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2302080 2302608 528 0.0
.bss 179296 179296 0 0.0
.data 5552 5552 0 0.0
.text 1264680 1265208 528 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139712 1139712 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103096 103096 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2292756 2293284 528 0.0
.bss 176572 176572 0 0.0
.data 5384 5384 0 0.0
.text 1255328 1255856 528 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 981695 982219 524 0.1
bss 119780 119780 0 0.0
rodata 115684 115888 204 0.2
text 668420 668744 324 0.0
nrf52840dk_nrf52840+rpc (read/write) 967243 967771 528 0.1
bss 116824 116824 0 0.0
rodata 107160 107368 208 0.2
text 664860 665188 328 0.0
nrf52840dongle_nrf52840 (read/write) 997747 998291 544 0.1
bss 120952 120952 0 0.0
rodata 114516 114724 208 0.2
text 673828 674156 328 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 890866 891394 528 0.1
bss 116568 116568 0 0.0
rodata 108964 109172 208 0.2
text 584596 584928 332 0.1
lock-app nrf52840dk_nrf52840 (read/write) 914307 914851 544 0.1
bss 118132 118132 0 0.0
rodata 104320 104528 208 0.2
text 614464 614792 328 0.1
nrf5340dk_nrf5340_cpuapp (read/write) 824358 824902 544 0.1
bss 114948 114948 0 0.0
rodata 97528 97736 208 0.2
text 531424 531756 332 0.1
pigweed-app nrf52840dk_nrf52840 (read/write) 541779 541779 0 0.0
bss 52588 52588 0 0.0
rodata 50048 50048 0 0.0
text 376940 376940 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 917155 917699 544 0.1
bss 117888 117888 0 0.0
rodata 104832 105040 208 0.2
text 616988 617316 328 0.1
pump-controller-app nrf52840dk_nrf52840 (read/write) 912355 912883 528 0.1
bss 117896 117896 0 0.0
rodata 103936 104144 208 0.2
text 613040 613364 324 0.1
shell nrf52840dk_nrf52840 (read/write) 798203 798203 0 0.0
bss 109776 109776 0 0.0
rodata 78288 78288 0 0.0
text 533640 533640 0 0.0
p6 all-clusters-app default (read/write) 2443344 2443992 648 0.0
.bss 117044 117044 0 0.0
.data 2584 2584 0 0.0
.text 1401608 1402256 648 0.0
light-app default (read/write) 2338840 2339488 648 0.0
.bss 104604 104604 0 0.0
.data 2408 2408 0 0.0
.text 1297104 1297752 648 0.0
lock-app default (read/write) 2304352 2305000 648 0.0
.bss 104324 104324 0 0.0
.data 2360 2360 0 0.0
.text 1262616 1263264 648 0.1
qpg lighting-app qpg6105+debug (read only) 571076 571528 452 0.1
(read/write) 146936 146936 0 0.0
.bss 88760 88760 0 0.0
.data 1060 1060 0 0.0
.text 565756 566208 452 0.1
lock-app qpg6105+debug (read only) 517252 517704 452 0.1
(read/write) 146940 146940 0 0.0
.bss 88200 88200 0 0.0
.data 992 992 0 0.0
.text 511932 512384 452 0.1
persistent-storage-app qpg6105+debug (read only) 107140 107140 0 0.0
(read/write) 146940 146940 0 0.0
.bss 38504 38504 0 0.0
.data 288 288 0 0.0
.text 101820 101820 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 846138 846730 592 0.1
bss 86560 86560 0 0.0
noinit 37160 37160 0 0.0
text 592758 593134 376 0.1

@yunhanw-google yunhanw-google force-pushed the feature/cluster_data_version1 branch from fb9726f to 96a4524 Compare January 29, 2022 15:31
@github-actions
Copy link

github-actions bot commented Jan 29, 2022 •
edited
Loading

PR #13400: Size comparison from 43a1e1a to 96a4524

Increases (21 builds for cyw30739, efr32, esp32, k32w, linux, mbed, p6, qpg, telink)
platform target config section 43a1e1a 96a4524 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 578558 579182 624 0.1
.app_xip_area 484532 485156 624 0.1
lock-app CYW30739 (read/write) 536618 537242 624 0.1
.app_xip_area 444160 444784 624 0.1
efr32 lighting-app BRD4161A (read only) 843432 844096 664 0.1
.text 843424 844088 664 0.1
BRD4161A+rpc (read only) 830792 831456 664 0.1
.text 830784 831448 664 0.1
window-app BRD4161A (read only) 816032 816696 664 0.1
.text 816024 816688 664 0.1
esp32 all-clusters-app c3devkit (read only) 934340 934716 376 0.0
(read/write) 1399050 1399266 216 0.0
.flash.rodata 195888 196104 216 0.1
.flash.text 934340 934716 376 0.0
m5stack (read only) 982047 982399 352 0.0
(read/write) 463404 463612 208 0.0
.flash.rodata 222508 222716 208 0.1
.flash.text 976663 977015 352 0.0
k32w light k32w061+release (read/write) 663264 663792 528 0.1
.text 579128 579656 528 0.1
lock k32w061+release (read/write) 664328 664856 528 0.1
.text 579856 580384 528 0.1
linux chip-tool-ipv6only arm64 (read only) 6997916 6999756 1840 0.0
.rodata 398308 398516 208 0.1
.text 6014484 6016116 1632 0.0
thermostat-no-ble arm64 (read only) 2084604 2086060 1456 0.1
.rodata 130812 131004 192 0.1
.text 1736224 1737488 1264 0.1
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2384008 2384472 464 0.0
.text 1346608 1347072 464 0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2338336 2338864 528 0.0
.text 1300936 1301464 528 0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2302440 2302968 528 0.0
.text 1265040 1265568 528 0.0
shell CY8CPROTO_062_4343W+release (read/write) 2293052 2293580 528 0.0
.text 1255624 1256152 528 0.0
p6 all-clusters-app default (read/write) 2444616 2445264 648 0.0
.text 1402880 1403528 648 0.0
light-app default (read/write) 2339984 2340632 648 0.0
.text 1298248 1298896 648 0.0
lock-app default (read/write) 2305496 2306144 648 0.0
.text 1263760 1264408 648 0.1
qpg lighting-app qpg6105+debug (read only) 571208 571668 460 0.1
.text 565888 566348 460 0.1
lock-app qpg6105+debug (read only) 517384 517844 460 0.1
.text 512064 512524 460 0.1
telink lighting-app tlsr9518adk80d (read/write) 846378 846970 592 0.1
text 592934 593310 376 0.1
Full report (23 builds for cyw30739, efr32, esp32, k32w, linux, mbed, p6, qpg, telink)
platform target config section 43a1e1a 96a4524 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 578558 579182 624 0.1
.app_xip_area 484532 485156 624 0.1
.bss 76772 76772 0 0.0
.data 596 596 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock-app CYW30739 (read/write) 536618 537242 624 0.1
.app_xip_area 444160 444784 624 0.1
.bss 75244 75244 0 0.0
.data 560 560 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
efr32 lighting-app BRD4161A (read only) 843432 844096 664 0.1
(read/write) 126320 126320 0 0.0
.bss 124416 124416 0 0.0
.data 1900 1900 0 0.0
.text 843424 844088 664 0.1
BRD4161A+rpc (read only) 830792 831456 664 0.1
(read/write) 142976 142976 0 0.0
.bss 140976 140976 0 0.0
.data 2000 2000 0 0.0
.text 830784 831448 664 0.1
window-app BRD4161A (read only) 816032 816696 664 0.1
(read/write) 124948 124948 0 0.0
.bss 123092 123092 0 0.0
.data 1856 1856 0 0.0
.text 816024 816688 664 0.1
esp32 all-clusters-app c3devkit (read only) 934340 934716 376 0.0
(read/write) 1399050 1399266 216 0.0
.dram0.bss 69992 69992 0 0.0
.dram0.data 14268 14268 0 0.0
.flash.rodata 195888 196104 216 0.1
.flash.text 934340 934716 376 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 982047 982399 352 0.0
(read/write) 463404 463612 208 0.0
.dram0.bss 74744 74744 0 0.0
.dram0.data 34024 34024 0 0.0
.flash.rodata 222508 222716 208 0.1
.flash.text 976663 977015 352 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 663264 663792 528 0.1
.bss 76468 76468 0 0.0
.data 1868 1868 0 0.0
.text 579128 579656 528 0.1
lock k32w061+release (read/write) 664328 664856 528 0.1
.bss 76780 76780 0 0.0
.data 1892 1892 0 0.0
.text 579856 580384 528 0.1
linux chip-tool-ipv6only arm64 (read only) 6997916 6999756 1840 0.0
(read/write) 284257 284257 0 0.0
.bss 55553 55553 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 178728 178728 0 0.0
.dynamic 560 560 0 0.0
.got 45072 45072 0 0.0
.init 24 24 0 0.0
.init_array 200 200 0 0.0
.rodata 398308 398516 208 0.1
.text 6014484 6016116 1632 0.0
thermostat-no-ble arm64 (read only) 2084604 2086060 1456 0.1
(read/write) 149713 149713 0 0.0
.bss 67329 67329 0 0.0
.data 960 960 0 0.0
.data.rel.ro 74288 74288 0 0.0
.dynamic 560 560 0 0.0
.got 4168 4168 0 0.0
.init 24 24 0 0.0
.init_array 336 336 0 0.0
.rodata 130812 131004 192 0.1
.text 1736224 1737488 1264 0.1
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2384008 2384472 464 0.0
.bss 188892 188892 0 0.0
.data 5288 5288 0 0.0
.text 1346608 1347072 464 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2338336 2338864 528 0.0
.bss 179424 179424 0 0.0
.data 5584 5584 0 0.0
.text 1300936 1301464 528 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2302440 2302968 528 0.0
.bss 179296 179296 0 0.0
.data 5552 5552 0 0.0
.text 1265040 1265568 528 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139712 1139712 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103096 103096 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2293052 2293580 528 0.0
.bss 176572 176572 0 0.0
.data 5384 5384 0 0.0
.text 1255624 1256152 528 0.0
p6 all-clusters-app default (read/write) 2444616 2445264 648 0.0
.bss 117044 117044 0 0.0
.data 2584 2584 0 0.0
.text 1402880 1403528 648 0.0
light-app default (read/write) 2339984 2340632 648 0.0
.bss 104604 104604 0 0.0
.data 2408 2408 0 0.0
.text 1298248 1298896 648 0.0
lock-app default (read/write) 2305496 2306144 648 0.0
.bss 104324 104324 0 0.0
.data 2360 2360 0 0.0
.text 1263760 1264408 648 0.1
qpg lighting-app qpg6105+debug (read only) 571208 571668 460 0.1
(read/write) 146936 146936 0 0.0
.bss 88760 88760 0 0.0
.data 1060 1060 0 0.0
.text 565888 566348 460 0.1
lock-app qpg6105+debug (read only) 517384 517844 460 0.1
(read/write) 146940 146940 0 0.0
.bss 88200 88200 0 0.0
.data 992 992 0 0.0
.text 512064 512524 460 0.1
persistent-storage-app qpg6105+debug (read only) 107140 107140 0 0.0
(read/write) 146940 146940 0 0.0
.bss 38504 38504 0 0.0
.data 288 288 0 0.0
.text 101820 101820 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 846378 846970 592 0.1
bss 86560 86560 0 0.0
noinit 37160 37160 0 0.0
text 592934 593310 376 0.1

@yunhanw-google yunhanw-google force-pushed the feature/cluster_data_version1 branch from 96a4524 to 8523384 Compare January 29, 2022 16:51
@github-actions
Copy link

github-actions bot commented Jan 29, 2022 •
edited
Loading

PR #13400: Size comparison from ddb7ce7 to 8523384

Increases above 0.2%:

platform target config section ddb7ce7 8523384 change % change
nrfconnect lock-app nrf5340dk_nrf5340_cpuapp rodata 97592 97800 208 0.2
Increases (29 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section ddb7ce7 8523384 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 578558 579182 624 0.1
.app_xip_area 484532 485156 624 0.1
lock-app CYW30739 (read/write) 536618 537242 624 0.1
.app_xip_area 444160 444784 624 0.1
efr32 lighting-app BRD4161A (read only) 843432 844096 664 0.1
.text 843424 844088 664 0.1
BRD4161A+rpc (read only) 830792 831456 664 0.1
.text 830784 831448 664 0.1
window-app BRD4161A (read only) 816032 816696 664 0.1
.text 816024 816688 664 0.1
esp32 all-clusters-app c3devkit (read only) 934340 934716 376 0.0
(read/write) 1399050 1399266 216 0.0
.flash.rodata 195888 196104 216 0.1
.flash.text 934340 934716 376 0.0
m5stack (read only) 982047 982399 352 0.0
(read/write) 463404 463612 208 0.0
.flash.rodata 222508 222716 208 0.1
.flash.text 976663 977015 352 0.0
k32w light k32w061+release (read/write) 663264 663792 528 0.1
.text 579128 579656 528 0.1
lock k32w061+release (read/write) 664328 664856 528 0.1
.text 579856 580384 528 0.1
linux chip-tool-ipv6only arm64 (read only) 7026076 7027900 1824 0.0
.rodata 398324 398516 192 0.0
.text 6042628 6044260 1632 0.0
thermostat-no-ble arm64 (read only) 2084604 2086060 1456 0.1
.rodata 130812 131004 192 0.1
.text 1736224 1737488 1264 0.1
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2384008 2384472 464 0.0
.text 1346608 1347072 464 0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2338336 2338864 528 0.0
.text 1300936 1301464 528 0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2302440 2302968 528 0.0
.text 1265040 1265568 528 0.0
shell CY8CPROTO_062_4343W+release (read/write) 2293052 2293580 528 0.0
.text 1255624 1256152 528 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 981899 982443 544 0.1
rodata 115744 115952 208 0.2
text 668568 668896 328 0.0
nrf52840dk_nrf52840+rpc (read/write) 967451 967975 524 0.1
rodata 107224 107428 204 0.2
text 665012 665336 324 0.0
nrf52840dongle_nrf52840 (read/write) 997971 998499 528 0.1
rodata 114580 114788 208 0.2
text 673980 674304 324 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 891074 891614 540 0.1
rodata 109028 109232 204 0.2
text 584748 585076 328 0.1
lock-app nrf52840dk_nrf52840 (read/write) 914531 915055 524 0.1
rodata 104384 104588 204 0.2
text 614616 614940 324 0.1
nrf5340dk_nrf5340_cpuapp (read/write) 824582 825110 528 0.1
rodata 97592 97800 208 0.2
text 531576 531904 328 0.1
pump-app nrf52840dk_nrf52840 (read/write) 917379 917907 528 0.1
rodata 104896 105104 208 0.2
text 617140 617464 324 0.1
pump-controller-app nrf52840dk_nrf52840 (read/write) 912563 913107 544 0.1
rodata 104000 104208 208 0.2
text 613188 613516 328 0.1
p6 all-clusters-app default (read/write) 2444616 2445264 648 0.0
.text 1402880 1403528 648 0.0
light-app default (read/write) 2339984 2340632 648 0.0
.text 1298248 1298896 648 0.0
lock-app default (read/write) 2305496 2306144 648 0.0
.text 1263760 1264408 648 0.1
qpg lighting-app qpg6105+debug (read only) 571208 571668 460 0.1
.text 565888 566348 460 0.1
lock-app qpg6105+debug (read only) 517384 517844 460 0.1
.text 512064 512524 460 0.1
telink lighting-app tlsr9518adk80d (read/write) 846378 846970 592 0.1
text 592934 593310 376 0.1
Full report (33 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section ddb7ce7 8523384 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 578558 579182 624 0.1
.app_xip_area 484532 485156 624 0.1
.bss 76772 76772 0 0.0
.data 596 596 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock-app CYW30739 (read/write) 536618 537242 624 0.1
.app_xip_area 444160 444784 624 0.1
.bss 75244 75244 0 0.0
.data 560 560 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
efr32 lighting-app BRD4161A (read only) 843432 844096 664 0.1
(read/write) 126320 126320 0 0.0
.bss 124416 124416 0 0.0
.data 1900 1900 0 0.0
.text 843424 844088 664 0.1
BRD4161A+rpc (read only) 830792 831456 664 0.1
(read/write) 142976 142976 0 0.0
.bss 140976 140976 0 0.0
.data 2000 2000 0 0.0
.text 830784 831448 664 0.1
window-app BRD4161A (read only) 816032 816696 664 0.1
(read/write) 124948 124948 0 0.0
.bss 123092 123092 0 0.0
.data 1856 1856 0 0.0
.text 816024 816688 664 0.1
esp32 all-clusters-app c3devkit (read only) 934340 934716 376 0.0
(read/write) 1399050 1399266 216 0.0
.dram0.bss 69992 69992 0 0.0
.dram0.data 14268 14268 0 0.0
.flash.rodata 195888 196104 216 0.1
.flash.text 934340 934716 376 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 982047 982399 352 0.0
(read/write) 463404 463612 208 0.0
.dram0.bss 74744 74744 0 0.0
.dram0.data 34024 34024 0 0.0
.flash.rodata 222508 222716 208 0.1
.flash.text 976663 977015 352 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 663264 663792 528 0.1
.bss 76468 76468 0 0.0
.data 1868 1868 0 0.0
.text 579128 579656 528 0.1
lock k32w061+release (read/write) 664328 664856 528 0.1
.bss 76780 76780 0 0.0
.data 1892 1892 0 0.0
.text 579856 580384 528 0.1
linux chip-tool-ipv6only arm64 (read only) 7026076 7027900 1824 0.0
(read/write) 284257 284257 0 0.0
.bss 55553 55553 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 178728 178728 0 0.0
.dynamic 560 560 0 0.0
.got 45072 45072 0 0.0
.init 24 24 0 0.0
.init_array 200 200 0 0.0
.rodata 398324 398516 192 0.0
.text 6042628 6044260 1632 0.0
thermostat-no-ble arm64 (read only) 2084604 2086060 1456 0.1
(read/write) 149713 149713 0 0.0
.bss 67329 67329 0 0.0
.data 960 960 0 0.0
.data.rel.ro 74288 74288 0 0.0
.dynamic 560 560 0 0.0
.got 4168 4168 0 0.0
.init 24 24 0 0.0
.init_array 336 336 0 0.0
.rodata 130812 131004 192 0.1
.text 1736224 1737488 1264 0.1
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2384008 2384472 464 0.0
.bss 188892 188892 0 0.0
.data 5288 5288 0 0.0
.text 1346608 1347072 464 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2338336 2338864 528 0.0
.bss 179424 179424 0 0.0
.data 5584 5584 0 0.0
.text 1300936 1301464 528 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2302440 2302968 528 0.0
.bss 179296 179296 0 0.0
.data 5552 5552 0 0.0
.text 1265040 1265568 528 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139712 1139712 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103096 103096 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2293052 2293580 528 0.0
.bss 176572 176572 0 0.0
.data 5384 5384 0 0.0
.text 1255624 1256152 528 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 981899 982443 544 0.1
bss 119780 119780 0 0.0
rodata 115744 115952 208 0.2
text 668568 668896 328 0.0
nrf52840dk_nrf52840+rpc (read/write) 967451 967975 524 0.1
bss 116824 116824 0 0.0
rodata 107224 107428 204 0.2
text 665012 665336 324 0.0
nrf52840dongle_nrf52840 (read/write) 997971 998499 528 0.1
bss 120952 120952 0 0.0
rodata 114580 114788 208 0.2
text 673980 674304 324 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 891074 891614 540 0.1
bss 116568 116568 0 0.0
rodata 109028 109232 204 0.2
text 584748 585076 328 0.1
lock-app nrf52840dk_nrf52840 (read/write) 914531 915055 524 0.1
bss 118132 118132 0 0.0
rodata 104384 104588 204 0.2
text 614616 614940 324 0.1
nrf5340dk_nrf5340_cpuapp (read/write) 824582 825110 528 0.1
bss 114948 114948 0 0.0
rodata 97592 97800 208 0.2
text 531576 531904 328 0.1
pigweed-app nrf52840dk_nrf52840 (read/write) 541779 541779 0 0.0
bss 52588 52588 0 0.0
rodata 50048 50048 0 0.0
text 376940 376940 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 917379 917907 528 0.1
bss 117888 117888 0 0.0
rodata 104896 105104 208 0.2
text 617140 617464 324 0.1
pump-controller-app nrf52840dk_nrf52840 (read/write) 912563 913107 544 0.1
bss 117896 117896 0 0.0
rodata 104000 104208 208 0.2
text 613188 613516 328 0.1
shell nrf52840dk_nrf52840 (read/write) 798379 798379 0 0.0
bss 109776 109776 0 0.0
rodata 78352 78352 0 0.0
text 533752 533752 0 0.0
p6 all-clusters-app default (read/write) 2444616 2445264 648 0.0
.bss 117044 117044 0 0.0
.data 2584 2584 0 0.0
.text 1402880 1403528 648 0.0
light-app default (read/write) 2339984 2340632 648 0.0
.bss 104604 104604 0 0.0
.data 2408 2408 0 0.0
.text 1298248 1298896 648 0.0
lock-app default (read/write) 2305496 2306144 648 0.0
.bss 104324 104324 0 0.0
.data 2360 2360 0 0.0
.text 1263760 1264408 648 0.1
qpg lighting-app qpg6105+debug (read only) 571208 571668 460 0.1
(read/write) 146936 146936 0 0.0
.bss 88760 88760 0 0.0
.data 1060 1060 0 0.0
.text 565888 566348 460 0.1
lock-app qpg6105+debug (read only) 517384 517844 460 0.1
(read/write) 146940 146940 0 0.0
.bss 88200 88200 0 0.0
.data 992 992 0 0.0
.text 512064 512524 460 0.1
persistent-storage-app qpg6105+debug (read only) 107140 107140 0 0.0
(read/write) 146940 146940 0 0.0
.bss 38504 38504 0 0.0
.data 288 288 0 0.0
.text 101820 101820 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 846378 846970 592 0.1
bss 86560 86560 0 0.0
noinit 37160 37160 0 0.0
text 592934 593310 376 0.1

yufengwangca
yufengwangca reviewed Jan 30, 2022
View reviewed changes
src/app/ReadClient.h Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Jan 30, 2022 •
edited
Loading

PR #13400: Size comparison from ddb7ce7 to 07462f0

Increases above 0.2%:

platform target config section ddb7ce7 07462f0 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 578558 580846 2288 0.4
.app_xip_area 484532 486820 2288 0.5
lock-app CYW30739 (read/write) 536618 538902 2284 0.4
.app_xip_area 444160 446444 2284 0.5
efr32 lighting-app BRD4161A (read only) 843432 846160 2728 0.3
.text 843424 846152 2728 0.3
BRD4161A+rpc (read only) 830792 833520 2728 0.3
.text 830784 833512 2728 0.3
window-app BRD4161A (read only) 816032 818760 2728 0.3
.text 816024 818752 2728 0.3
esp32 all-clusters-app c3devkit (read only) 934340 936562 2222 0.2
.flash.rodata 195888 196464 576 0.3
.flash.text 934340 936562 2222 0.2
m5stack .flash.rodata 222508 223060 552 0.2
k32w light k32w061+release (read/write) 663264 665472 2208 0.3
.text 579128 581336 2208 0.4
lock k32w061+release (read/write) 664328 666520 2192 0.3
.text 579856 582048 2192 0.4
linux chip-tool-ipv6only arm64 (read only) 7026076 7056700 30624 0.4
.text 6042628 6071428 28800 0.5
thermostat-no-ble arm64 (read only) 2084604 2093252 8648 0.4
.rodata 130812 131268 456 0.3
.text 1736224 1744368 8144 0.5
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 981899 984107 2208 0.2
rodata 115744 116112 368 0.3
text 668568 670400 1832 0.3
nrf52840dk_nrf52840+rpc (read/write) 967451 969639 2188 0.2
rodata 107224 107588 364 0.3
text 665012 666840 1828 0.3
nrf52840dongle_nrf52840 (read/write) 997971 1000159 2188 0.2
rodata 114580 114944 364 0.3
text 673980 675808 1828 0.3
nrf5340dk_nrf5340_cpuapp (read/write) 891074 893278 2204 0.2
rodata 109028 109392 364 0.3
text 584748 586580 1832 0.3
lock-app nrf52840dk_nrf52840 (read/write) 914531 916719 2188 0.2
rodata 104384 104748 364 0.3
text 614616 616444 1828 0.3
nrf5340dk_nrf5340_cpuapp (read/write) 824582 826770 2188 0.3
rodata 97592 97956 364 0.4
text 531576 533408 1832 0.3
pump-app nrf52840dk_nrf52840 (read/write) 917379 919567 2188 0.2
rodata 104896 105260 364 0.3
text 617140 618968 1828 0.3
pump-controller-app nrf52840dk_nrf52840 (read/write) 912563 914767 2204 0.2
rodata 104000 104364 364 0.3
text 613188 615020 1832 0.3
qpg lighting-app qpg6105+debug (read only) 571208 573336 2128 0.4
.text 565888 568016 2128 0.4
lock-app qpg6105+debug (read only) 517384 519504 2120 0.4
.text 512064 514184 2120 0.4
telink lighting-app tlsr9518adk80d (read/write) 846378 848946 2568 0.3
text 592934 595124 2190 0.4
Increases (29 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section ddb7ce7 07462f0 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 578558 580846 2288 0.4
.app_xip_area 484532 486820 2288 0.5
lock-app CYW30739 (read/write) 536618 538902 2284 0.4
.app_xip_area 444160 446444 2284 0.5
efr32 lighting-app BRD4161A (read only) 843432 846160 2728 0.3
.text 843424 846152 2728 0.3
BRD4161A+rpc (read only) 830792 833520 2728 0.3
.text 830784 833512 2728 0.3
window-app BRD4161A (read only) 816032 818760 2728 0.3
.text 816024 818752 2728 0.3
esp32 all-clusters-app c3devkit (read only) 934340 936562 2222 0.2
(read/write) 1399050 1399642 592 0.0
.dram0.data 14268 14276 8 0.1
.flash.rodata 195888 196464 576 0.3
.flash.text 934340 936562 2222 0.2
m5stack (read only) 982047 983867 1820 0.2
(read/write) 463404 463956 552 0.1
.flash.rodata 222508 223060 552 0.2
.flash.text 976663 978483 1820 0.2
k32w light k32w061+release (read/write) 663264 665472 2208 0.3
.text 579128 581336 2208 0.4
lock k32w061+release (read/write) 664328 666520 2192 0.3
.text 579856 582048 2192 0.4
linux chip-tool-ipv6only arm64 (read only) 7026076 7056700 30624 0.4
(read/write) 284257 284689 432 0.2
.data.rel.ro 178728 179152 424 0.2
.got 45072 45080 8 0.0
.rodata 398324 398852 528 0.1
.text 6042628 6071428 28800 0.5
thermostat-no-ble arm64 (read only) 2084604 2093252 8648 0.4
(read/write) 149713 149745 32 0.0
.data.rel.ro 74288 74312 24 0.0
.got 4168 4176 8 0.2
.rodata 130812 131268 456 0.3
.text 1736224 1744368 8144 0.5
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2384008 2386168 2160 0.1
.text 1346608 1348768 2160 0.2
lighting-app CY8CPROTO_062_4343W+release (read/write) 2338336 2340496 2160 0.1
.text 1300936 1303096 2160 0.2
lock-app CY8CPROTO_062_4343W+release (read/write) 2302440 2304600 2160 0.1
.text 1265040 1267200 2160 0.2
shell CY8CPROTO_062_4343W+release (read/write) 2293052 2295212 2160 0.1
.text 1255624 1257784 2160 0.2
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 981899 984107 2208 0.2
rodata 115744 116112 368 0.3
text 668568 670400 1832 0.3
nrf52840dk_nrf52840+rpc (read/write) 967451 969639 2188 0.2
rodata 107224 107588 364 0.3
text 665012 666840 1828 0.3
nrf52840dongle_nrf52840 (read/write) 997971 1000159 2188 0.2
rodata 114580 114944 364 0.3
text 673980 675808 1828 0.3
nrf5340dk_nrf5340_cpuapp (read/write) 891074 893278 2204 0.2
rodata 109028 109392 364 0.3
text 584748 586580 1832 0.3
lock-app nrf52840dk_nrf52840 (read/write) 914531 916719 2188 0.2
rodata 104384 104748 364 0.3
text 614616 616444 1828 0.3
nrf5340dk_nrf5340_cpuapp (read/write) 824582 826770 2188 0.3
rodata 97592 97956 364 0.4
text 531576 533408 1832 0.3
pump-app nrf52840dk_nrf52840 (read/write) 917379 919567 2188 0.2
rodata 104896 105260 364 0.3
text 617140 618968 1828 0.3
pump-controller-app nrf52840dk_nrf52840 (read/write) 912563 914767 2204 0.2
rodata 104000 104364 364 0.3
text 613188 615020 1832 0.3
p6 all-clusters-app default (read/write) 2444616 2447344 2728 0.1
.text 1402880 1405608 2728 0.2
light-app default (read/write) 2339984 2342712 2728 0.1
.text 1298248 1300976 2728 0.2
lock-app default (read/write) 2305496 2308200 2704 0.1
.text 1263760 1266464 2704 0.2
qpg lighting-app qpg6105+debug (read only) 571208 573336 2128 0.4
.text 565888 568016 2128 0.4
lock-app qpg6105+debug (read only) 517384 519504 2120 0.4
.text 512064 514184 2120 0.4
telink lighting-app tlsr9518adk80d (read/write) 846378 848946 2568 0.3
text 592934 595124 2190 0.4
Full report (33 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section ddb7ce7 07462f0 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 578558 580846 2288 0.4
.app_xip_area 484532 486820 2288 0.5
.bss 76772 76772 0 0.0
.data 596 596 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock-app CYW30739 (read/write) 536618 538902 2284 0.4
.app_xip_area 444160 446444 2284 0.5
.bss 75244 75244 0 0.0
.data 560 560 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
efr32 lighting-app BRD4161A (read only) 843432 846160 2728 0.3
(read/write) 126320 126320 0 0.0
.bss 124416 124416 0 0.0
.data 1900 1900 0 0.0
.text 843424 846152 2728 0.3
BRD4161A+rpc (read only) 830792 833520 2728 0.3
(read/write) 142976 142976 0 0.0
.bss 140976 140976 0 0.0
.data 2000 2000 0 0.0
.text 830784 833512 2728 0.3
window-app BRD4161A (read only) 816032 818760 2728 0.3
(read/write) 124948 124948 0 0.0
.bss 123092 123092 0 0.0
.data 1856 1856 0 0.0
.text 816024 818752 2728 0.3
esp32 all-clusters-app c3devkit (read only) 934340 936562 2222 0.2
(read/write) 1399050 1399642 592 0.0
.dram0.bss 69992 69992 0 0.0
.dram0.data 14268 14276 8 0.1
.flash.rodata 195888 196464 576 0.3
.flash.text 934340 936562 2222 0.2
.iram0.text 62056 62056 0 0.0
m5stack (read only) 982047 983867 1820 0.2
(read/write) 463404 463956 552 0.1
.dram0.bss 74744 74744 0 0.0
.dram0.data 34024 34024 0 0.0
.flash.rodata 222508 223060 552 0.2
.flash.text 976663 978483 1820 0.2
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 663264 665472 2208 0.3
.bss 76468 76468 0 0.0
.data 1868 1868 0 0.0
.text 579128 581336 2208 0.4
lock k32w061+release (read/write) 664328 666520 2192 0.3
.bss 76780 76780 0 0.0
.data 1892 1892 0 0.0
.text 579856 582048 2192 0.4
linux chip-tool-ipv6only arm64 (read only) 7026076 7056700 30624 0.4
(read/write) 284257 284689 432 0.2
.bss 55553 55553 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 178728 179152 424 0.2
.dynamic 560 560 0 0.0
.got 45072 45080 8 0.0
.init 24 24 0 0.0
.init_array 200 200 0 0.0
.rodata 398324 398852 528 0.1
.text 6042628 6071428 28800 0.5
thermostat-no-ble arm64 (read only) 2084604 2093252 8648 0.4
(read/write) 149713 149745 32 0.0
.bss 67329 67329 0 0.0
.data 960 960 0 0.0
.data.rel.ro 74288 74312 24 0.0
.dynamic 560 560 0 0.0
.got 4168 4176 8 0.2
.init 24 24 0 0.0
.init_array 336 336 0 0.0
.rodata 130812 131268 456 0.3
.text 1736224 1744368 8144 0.5
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2384008 2386168 2160 0.1
.bss 188892 188892 0 0.0
.data 5288 5288 0 0.0
.text 1346608 1348768 2160 0.2
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2338336 2340496 2160 0.1
.bss 179424 179424 0 0.0
.data 5584 5584 0 0.0
.text 1300936 1303096 2160 0.2
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2302440 2304600 2160 0.1
.bss 179296 179296 0 0.0
.data 5552 5552 0 0.0
.text 1265040 1267200 2160 0.2
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139712 1139712 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103096 103096 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2293052 2295212 2160 0.1
.bss 176572 176572 0 0.0
.data 5384 5384 0 0.0
.text 1255624 1257784 2160 0.2
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 981899 984107 2208 0.2
bss 119780 119780 0 0.0
rodata 115744 116112 368 0.3
text 668568 670400 1832 0.3
nrf52840dk_nrf52840+rpc (read/write) 967451 969639 2188 0.2
bss 116824 116824 0 0.0
rodata 107224 107588 364 0.3
text 665012 666840 1828 0.3
nrf52840dongle_nrf52840 (read/write) 997971 1000159 2188 0.2
bss 120952 120952 0 0.0
rodata 114580 114944 364 0.3
text 673980 675808 1828 0.3
nrf5340dk_nrf5340_cpuapp (read/write) 891074 893278 2204 0.2
bss 116568 116568 0 0.0
rodata 109028 109392 364 0.3
text 584748 586580 1832 0.3
lock-app nrf52840dk_nrf52840 (read/write) 914531 916719 2188 0.2
bss 118132 118132 0 0.0
rodata 104384 104748 364 0.3
text 614616 616444 1828 0.3
nrf5340dk_nrf5340_cpuapp (read/write) 824582 826770 2188 0.3
bss 114948 114948 0 0.0
rodata 97592 97956 364 0.4
text 531576 533408 1832 0.3
pigweed-app nrf52840dk_nrf52840 (read/write) 541779 541779 0 0.0
bss 52588 52588 0 0.0
rodata 50048 50048 0 0.0
text 376940 376940 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 917379 919567 2188 0.2
bss 117888 117888 0 0.0
rodata 104896 105260 364 0.3
text 617140 618968 1828 0.3
pump-controller-app nrf52840dk_nrf52840 (read/write) 912563 914767 2204 0.2
bss 117896 117896 0 0.0
rodata 104000 104364 364 0.3
text 613188 615020 1832 0.3
shell nrf52840dk_nrf52840 (read/write) 798379 798379 0 0.0
bss 109776 109776 0 0.0
rodata 78352 78352 0 0.0
text 533752 533752 0 0.0
p6 all-clusters-app default (read/write) 2444616 2447344 2728 0.1
.bss 117044 117044 0 0.0
.data 2584 2584 0 0.0
.text 1402880 1405608 2728 0.2
light-app default (read/write) 2339984 2342712 2728 0.1
.bss 104604 104604 0 0.0
.data 2408 2408 0 0.0
.text 1298248 1300976 2728 0.2
lock-app default (read/write) 2305496 2308200 2704 0.1
.bss 104324 104324 0 0.0
.data 2360 2360 0 0.0
.text 1263760 1266464 2704 0.2
qpg lighting-app qpg6105+debug (read only) 571208 573336 2128 0.4
(read/write) 146936 146936 0 0.0
.bss 88760 88760 0 0.0
.data 1060 1060 0 0.0
.text 565888 568016 2128 0.4
lock-app qpg6105+debug (read only) 517384 519504 2120 0.4
(read/write) 146940 146940 0 0.0
.bss 88200 88200 0 0.0
.data 992 992 0 0.0
.text 512064 514184 2120 0.4
persistent-storage-app qpg6105+debug (read only) 107140 107140 0 0.0
(read/write) 146940 146940 0 0.0
.bss 38504 38504 0 0.0
.data 288 288 0 0.0
.text 101820 101820 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 846378 848946 2568 0.3
bss 86560 86560 0 0.0
noinit 37160 37160 0 0.0
text 592934 595124 2190 0.4

mrjerryjohns
mrjerryjohns suggested changes Jan 31, 2022
View reviewed changes
src/app/ReadClient.h Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Jan 31, 2022 •
edited
Loading

PR #13400: Size comparison from ddb7ce7 to 9f5be31

Increases above 0.2%:

platform target config section ddb7ce7 9f5be31 change % change
linux chip-tool-ipv6only arm64 (read only) 7026076 7056332 30256 0.4
.text 6042628 6071060 28432 0.5
Increases (2 builds for linux, qpg)
platform target config section ddb7ce7 9f5be31 change % change
linux chip-tool-ipv6only arm64 (read only) 7026076 7056332 30256 0.4
(read/write) 284257 284689 432 0.2
.data.rel.ro 178728 179152 424 0.2
.got 45072 45080 8 0.0
.rodata 398324 398852 528 0.1
.text 6042628 6071060 28432 0.5
qpg lighting-app qpg6105+debug (read/write) 146936 146940 4 0.0
Decreases (14 builds for cyw30739, efr32, k32w, linux, p6, qpg, telink)
platform target config section ddb7ce7 9f5be31 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 578558 577986 -572 -0.1
.app_xip_area 484532 484312 -220 -0.0
.bss 76772 76420 -352 -0.5
lock-app CYW30739 (read/write) 536618 536002 -616 -0.1
.app_xip_area 444160 443904 -256 -0.1
.bss 75244 74884 -360 -0.5
efr32 lighting-app BRD4161A (read only) 843432 843304 -128 -0.0
(read/write) 126320 125952 -368 -0.3
.bss 124416 124056 -360 -0.3
.data 1900 1892 -8 -0.4
.text 843424 843296 -128 -0.0
BRD4161A+rpc (read only) 830792 830680 -112 -0.0
(read/write) 142976 142608 -368 -0.3
.bss 140976 140616 -360 -0.3
.data 2000 1992 -8 -0.4
.text 830784 830672 -112 -0.0
window-app BRD4161A (read only) 816032 815916 -116 -0.0
(read/write) 124948 124580 -368 -0.3
.bss 123092 122732 -360 -0.3
.data 1856 1848 -8 -0.4
.text 816024 815908 -116 -0.0
k32w light k32w061+release (read/write) 663264 662588 -676 -0.1
.bss 76468 76116 -352 -0.5
.data 1868 1860 -8 -0.4
.text 579128 578812 -316 -0.1
lock k32w061+release (read/write) 664328 663648 -680 -0.1
.bss 76780 76428 -352 -0.5
.text 579856 579528 -328 -0.1
linux thermostat-no-ble arm64 (read only) 2084604 2083380 -1224 -0.1
(read/write) 149713 149441 -272 -0.2
.bss 67329 67121 -208 -0.3
.data 960 952 -8 -0.8
.data.rel.ro 74288 74248 -40 -0.1
.got 4168 4144 -24 -0.6
.rodata 130812 130660 -152 -0.1
.text 1736224 1735344 -880 -0.1
p6 all-clusters-app default (read/write) 2444616 2444344 -272 -0.0
.bss 117044 116932 -112 -0.1
.text 1402880 1402608 -272 -0.0
light-app default (read/write) 2339984 2339856 -128 -0.0
.bss 104604 104244 -360 -0.3
.data 2408 2400 -8 -0.3
.text 1298248 1298120 -128 -0.0
lock-app default (read/write) 2305496 2305328 -168 -0.0
.bss 104324 103964 -360 -0.3
.text 1263760 1263592 -168 -0.0
qpg lighting-app qpg6105+debug (read only) 571208 570924 -284 -0.0
.bss 88760 88400 -360 -0.4
.data 1060 1056 -4 -0.4
.text 565888 565604 -284 -0.1
lock-app qpg6105+debug (read only) 517384 517068 -316 -0.1
.bss 88200 87840 -360 -0.4
.text 512064 511748 -316 -0.1
telink lighting-app tlsr9518adk80d (read/write) 846378 845750 -628 -0.1
bss 86560 86448 -112 -0.1
text 592934 592422 -512 -0.1
Full report (16 builds for cyw30739, efr32, k32w, linux, p6, qpg, telink)
platform target config section ddb7ce7 9f5be31 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 578558 577986 -572 -0.1
.app_xip_area 484532 484312 -220 -0.0
.bss 76772 76420 -352 -0.5
.data 596 596 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock-app CYW30739 (read/write) 536618 536002 -616 -0.1
.app_xip_area 444160 443904 -256 -0.1
.bss 75244 74884 -360 -0.5
.data 560 560 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
efr32 lighting-app BRD4161A (read only) 843432 843304 -128 -0.0
(read/write) 126320 125952 -368 -0.3
.bss 124416 124056 -360 -0.3
.data 1900 1892 -8 -0.4
.text 843424 843296 -128 -0.0
BRD4161A+rpc (read only) 830792 830680 -112 -0.0
(read/write) 142976 142608 -368 -0.3
.bss 140976 140616 -360 -0.3
.data 2000 1992 -8 -0.4
.text 830784 830672 -112 -0.0
window-app BRD4161A (read only) 816032 815916 -116 -0.0
(read/write) 124948 124580 -368 -0.3
.bss 123092 122732 -360 -0.3
.data 1856 1848 -8 -0.4
.text 816024 815908 -116 -0.0
k32w light k32w061+release (read/write) 663264 662588 -676 -0.1
.bss 76468 76116 -352 -0.5
.data 1868 1860 -8 -0.4
.text 579128 578812 -316 -0.1
lock k32w061+release (read/write) 664328 663648 -680 -0.1
.bss 76780 76428 -352 -0.5
.data 1892 1892 0 0.0
.text 579856 579528 -328 -0.1
linux chip-tool-ipv6only arm64 (read only) 7026076 7056332 30256 0.4
(read/write) 284257 284689 432 0.2
.bss 55553 55553 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 178728 179152 424 0.2
.dynamic 560 560 0 0.0
.got 45072 45080 8 0.0
.init 24 24 0 0.0
.init_array 200 200 0 0.0
.rodata 398324 398852 528 0.1
.text 6042628 6071060 28432 0.5
thermostat-no-ble arm64 (read only) 2084604 2083380 -1224 -0.1
(read/write) 149713 149441 -272 -0.2
.bss 67329 67121 -208 -0.3
.data 960 952 -8 -0.8
.data.rel.ro 74288 74248 -40 -0.1
.dynamic 560 560 0 0.0
.got 4168 4144 -24 -0.6
.init 24 24 0 0.0
.init_array 336 336 0 0.0
.rodata 130812 130660 -152 -0.1
.text 1736224 1735344 -880 -0.1
p6 all-clusters-app default (read/write) 2444616 2444344 -272 -0.0
.bss 117044 116932 -112 -0.1
.data 2584 2584 0 0.0
.text 1402880 1402608 -272 -0.0
light-app default (read/write) 2339984 2339856 -128 -0.0
.bss 104604 104244 -360 -0.3
.data 2408 2400 -8 -0.3
.text 1298248 1298120 -128 -0.0
lock-app default (read/write) 2305496 2305328 -168 -0.0
.bss 104324 103964 -360 -0.3
.data 2360 2360 0 0.0
.text 1263760 1263592 -168 -0.0
qpg lighting-app qpg6105+debug (read only) 571208 570924 -284 -0.0
(read/write) 146936 146940 4 0.0
.bss 88760 88400 -360 -0.4
.data 1060 1056 -4 -0.4
.text 565888 565604 -284 -0.1
lock-app qpg6105+debug (read only) 517384 517068 -316 -0.1
(read/write) 146940 146940 0 0.0
.bss 88200 87840 -360 -0.4
.data 992 992 0 0.0
.text 512064 511748 -316 -0.1
persistent-storage-app qpg6105+debug (read only) 107140 107140 0 0.0
(read/write) 146940 146940 0 0.0
.bss 38504 38504 0 0.0
.data 288 288 0 0.0
.text 101820 101820 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 846378 845750 -628 -0.1
bss 86560 86448 -112 -0.1
noinit 37160 37160 0 0.0
text 592934 592422 -512 -0.1

@mrjerryjohns
Copy link
Contributor

Where are the checks of the data version in the ReadRequest against the version currently present on the server, and omitting data if that matches? That presumably is the biggest reason we're doing this whole version feature, which is to optimize out traffic for reads/subscribes.

mrjerryjohns
mrjerryjohns reviewed Jan 31, 2022
View reviewed changes
src/app/reporting/Engine.cpp Show resolved Hide resolved
src/app/util/ember-compatibility-functions.cpp Outdated Show resolved Hide resolved
src/controller/python/chip/clusters/Attribute.py Outdated Show resolved Hide resolved
src/controller/python/chip/clusters/Attribute.py Outdated Show resolved Hide resolved
@yunhanw-google yunhanw-google mentioned this pull request Jan 31, 2022
Closed
@yunhanw-google
Copy link
Contributor Author

Where are the checks of the data version in the ReadRequest against the version currently present on the server, and omitting data if that matches? That presumably is the biggest reason we're doing this whole version feature, which is to optimize out traffic for reads/subscribes.

DataVersionFilters has not yet been implemented in this PR, would happen in next PR, thanks

@github-actions
Copy link

github-actions bot commented Jan 31, 2022 •
edited
Loading

PR #13400: Size comparison from ddb7ce7 to 0d52ab6

Increases above 0.2%:

platform target config section ddb7ce7 0d52ab6 change % change
linux chip-tool-ipv6only arm64 (read only) 7026076 7056380 30304 0.4
.text 6042628 6071108 28480 0.5
Increases (4 builds for esp32, linux, qpg)
platform target config section ddb7ce7 0d52ab6 change % change
esp32 all-clusters-app c3devkit (read/write) 1399050 1399098 48 0.0
.flash.rodata 195888 196048 160 0.1
m5stack (read/write) 463404 463452 48 0.0
.flash.rodata 222508 222668 160 0.1
linux chip-tool-ipv6only arm64 (read only) 7026076 7056380 30304 0.4
(read/write) 284257 284689 432 0.2
.data.rel.ro 178728 179152 424 0.2
.got 45072 45080 8 0.0
.rodata 398324 398852 528 0.1
.text 6042628 6071108 28480 0.5
qpg lighting-app qpg6105+debug (read/write) 146936 146940 4 0.0
Decreases (20 builds for cyw30739, efr32, esp32, k32w, linux, mbed, p6, qpg, telink)
platform target config section ddb7ce7 0d52ab6 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 578558 577914 -644 -0.1
.app_xip_area 484532 484240 -292 -0.1
.bss 76772 76420 -352 -0.5
lock-app CYW30739 (read/write) 536618 535922 -696 -0.1
.app_xip_area 444160 443824 -336 -0.1
.bss 75244 74884 -360 -0.5
efr32 lighting-app BRD4161A (read only) 843432 843304 -128 -0.0
(read/write) 126320 125952 -368 -0.3
.bss 124416 124056 -360 -0.3
.data 1900 1892 -8 -0.4
.text 843424 843296 -128 -0.0
BRD4161A+rpc (read only) 830792 830680 -112 -0.0
(read/write) 142976 142608 -368 -0.3
.bss 140976 140616 -360 -0.3
.data 2000 1992 -8 -0.4
.text 830784 830672 -112 -0.0
window-app BRD4161A (read only) 816032 815932 -100 -0.0
(read/write) 124948 124580 -368 -0.3
.bss 123092 122732 -360 -0.3
.data 1856 1848 -8 -0.4
.text 816024 815924 -100 -0.0
esp32 all-clusters-app c3devkit (read only) 934340 933686 -654 -0.1
.dram0.bss 69992 69880 -112 -0.2
.flash.text 934340 933686 -654 -0.1
m5stack (read only) 982047 981531 -516 -0.1
.dram0.bss 74744 74632 -112 -0.1
.flash.text 976663 976147 -516 -0.1
k32w light k32w061+release (read/write) 663264 662588 -676 -0.1
.bss 76468 76116 -352 -0.5
.data 1868 1860 -8 -0.4
.text 579128 578812 -316 -0.1
lock k32w061+release (read/write) 664328 663648 -680 -0.1
.bss 76780 76428 -352 -0.5
.text 579856 579528 -328 -0.1
linux thermostat-no-ble arm64 (read only) 2084604 2083428 -1176 -0.1
(read/write) 149713 149441 -272 -0.2
.bss 67329 67121 -208 -0.3
.data 960 952 -8 -0.8
.data.rel.ro 74288 74248 -40 -0.1
.got 4168 4144 -24 -0.6
.rodata 130812 130660 -152 -0.1
.text 1736224 1735392 -832 -0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2384008 2383392 -616 -0.0
.bss 188892 188780 -112 -0.1
.text 1346608 1345992 -616 -0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2338336 2338024 -312 -0.0
.bss 179424 179064 -360 -0.2
.data 5584 5576 -8 -0.1
.text 1300936 1300624 -312 -0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2302440 2302064 -376 -0.0
.bss 179296 178936 -360 -0.2
.data 5552 5544 -8 -0.1
.text 1265040 1264664 -376 -0.0
shell CY8CPROTO_062_4343W+release (read/write) 2293052 2292668 -384 -0.0
.bss 176572 176220 -352 -0.2
.data 5384 5376 -8 -0.1
.text 1255624 1255240 -384 -0.0
p6 all-clusters-app default (read/write) 2444616 2444344 -272 -0.0
.bss 117044 116932 -112 -0.1
.text 1402880 1402608 -272 -0.0
light-app default (read/write) 2339984 2339856 -128 -0.0
.bss 104604 104244 -360 -0.3
.data 2408 2400 -8 -0.3
.text 1298248 1298120 -128 -0.0
lock-app default (read/write) 2305496 2305328 -168 -0.0
.bss 104324 103964 -360 -0.3
.text 1263760 1263592 -168 -0.0
qpg lighting-app qpg6105+debug (read only) 571208 570924 -284 -0.0
.bss 88760 88400 -360 -0.4
.data 1060 1056 -4 -0.4
.text 565888 565604 -284 -0.1
lock-app qpg6105+debug (read only) 517384 517068 -316 -0.1
.bss 88200 87840 -360 -0.4
.text 512064 511748 -316 -0.1
telink lighting-app tlsr9518adk80d (read/write) 846378 845750 -628 -0.1
bss 86560 86448 -112 -0.1
text 592934 592424 -510 -0.1
Full report (23 builds for cyw30739, efr32, esp32, k32w, linux, mbed, p6, qpg, telink)
platform target config section ddb7ce7 0d52ab6 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 578558 577914 -644 -0.1
.app_xip_area 484532 484240 -292 -0.1
.bss 76772 76420 -352 -0.5
.data 596 596 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock-app CYW30739 (read/write) 536618 535922 -696 -0.1
.app_xip_area 444160 443824 -336 -0.1
.bss 75244 74884 -360 -0.5
.data 560 560 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
efr32 lighting-app BRD4161A (read only) 843432 843304 -128 -0.0
(read/write) 126320 125952 -368 -0.3
.bss 124416 124056 -360 -0.3
.data 1900 1892 -8 -0.4
.text 843424 843296 -128 -0.0
BRD4161A+rpc (read only) 830792 830680 -112 -0.0
(read/write) 142976 142608 -368 -0.3
.bss 140976 140616 -360 -0.3
.data 2000 1992 -8 -0.4
.text 830784 830672 -112 -0.0
window-app BRD4161A (read only) 816032 815932 -100 -0.0
(read/write) 124948 124580 -368 -0.3
.bss 123092 122732 -360 -0.3
.data 1856 1848 -8 -0.4
.text 816024 815924 -100 -0.0
esp32 all-clusters-app c3devkit (read only) 934340 933686 -654 -0.1
(read/write) 1399050 1399098 48 0.0
.dram0.bss 69992 69880 -112 -0.2
.dram0.data 14268 14268 0 0.0
.flash.rodata 195888 196048 160 0.1
.flash.text 934340 933686 -654 -0.1
.iram0.text 62056 62056 0 0.0
m5stack (read only) 982047 981531 -516 -0.1
(read/write) 463404 463452 48 0.0
.dram0.bss 74744 74632 -112 -0.1
.dram0.data 34024 34024 0 0.0
.flash.rodata 222508 222668 160 0.1
.flash.text 976663 976147 -516 -0.1
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 663264 662588 -676 -0.1
.bss 76468 76116 -352 -0.5
.data 1868 1860 -8 -0.4
.text 579128 578812 -316 -0.1
lock k32w061+release (read/write) 664328 663648 -680 -0.1
.bss 76780 76428 -352 -0.5
.data 1892 1892 0 0.0
.text 579856 579528 -328 -0.1
linux chip-tool-ipv6only arm64 (read only) 7026076 7056380 30304 0.4
(read/write) 284257 284689 432 0.2
.bss 55553 55553 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 178728 179152 424 0.2
.dynamic 560 560 0 0.0
.got 45072 45080 8 0.0
.init 24 24 0 0.0
.init_array 200 200 0 0.0
.rodata 398324 398852 528 0.1
.text 6042628 6071108 28480 0.5
thermostat-no-ble arm64 (read only) 2084604 2083428 -1176 -0.1
(read/write) 149713 149441 -272 -0.2
.bss 67329 67121 -208 -0.3
.data 960 952 -8 -0.8
.data.rel.ro 74288 74248 -40 -0.1
.dynamic 560 560 0 0.0
.got 4168 4144 -24 -0.6
.init 24 24 0 0.0
.init_array 336 336 0 0.0
.rodata 130812 130660 -152 -0.1
.text 1736224 1735392 -832 -0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2384008 2383392 -616 -0.0
.bss 188892 188780 -112 -0.1
.data 5288 5288 0 0.0
.text 1346608 1345992 -616 -0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2338336 2338024 -312 -0.0
.bss 179424 179064 -360 -0.2
.data 5584 5576 -8 -0.1
.text 1300936 1300624 -312 -0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2302440 2302064 -376 -0.0
.bss 179296 178936 -360 -0.2
.data 5552 5544 -8 -0.1
.text 1265040 1264664 -376 -0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139712 1139712 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103096 103096 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2293052 2292668 -384 -0.0
.bss 176572 176220 -352 -0.2
.data 5384 5376 -8 -0.1
.text 1255624 1255240 -384 -0.0
p6 all-clusters-app default (read/write) 2444616 2444344 -272 -0.0
.bss 117044 116932 -112 -0.1
.data 2584 2584 0 0.0
.text 1402880 1402608 -272 -0.0
light-app default (read/write) 2339984 2339856 -128 -0.0
.bss 104604 104244 -360 -0.3
.data 2408 2400 -8 -0.3
.text 1298248 1298120 -128 -0.0
lock-app default (read/write) 2305496 2305328 -168 -0.0
.bss 104324 103964 -360 -0.3
.data 2360 2360 0 0.0
.text 1263760 1263592 -168 -0.0
qpg lighting-app qpg6105+debug (read only) 571208 570924 -284 -0.0
(read/write) 146936 146940 4 0.0
.bss 88760 88400 -360 -0.4
.data 1060 1056 -4 -0.4
.text 565888 565604 -284 -0.1
lock-app qpg6105+debug (read only) 517384 517068 -316 -0.1
(read/write) 146940 146940 0 0.0
.bss 88200 87840 -360 -0.4
.data 992 992 0 0.0
.text 512064 511748 -316 -0.1
persistent-storage-app qpg6105+debug (read only) 107140 107140 0 0.0
(read/write) 146940 146940 0 0.0
.bss 38504 38504 0 0.0
.data 288 288 0 0.0
.text 101820 101820 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 846378 845750 -628 -0.1
bss 86560 86448 -112 -0.1
noinit 37160 37160 0 0.0
text 592934 592424 -510 -0.1

@yunhanw-google yunhanw-google mentioned this pull request Jan 31, 2022
Closed
@yunhanw-google
Copy link
Contributor Author

Where are the checks of the data version in the ReadRequest against the version currently present on the server, and omitting data if that matches? That presumably is the biggest reason we're doing this whole version feature, which is to optimize out traffic for reads/subscribes.

DataVersionFilters has not yet been implemented in this PR, would happen in next PR, thanks

#14588

@yunhanw-google
Copy link
Contributor Author

/rebase

@woody-apple woody-apple force-pushed the feature/cluster_data_version1 branch from 0d52ab6 to f7fa122 Compare January 31, 2022 20:06
@github-actions
Copy link

github-actions bot commented Jan 31, 2022 •
edited
Loading

PR #13400: Size comparison from fb256c5 to f7fa122

Increases above 0.2%:

platform target config section fb256c5 f7fa122 change % change
nrfconnect lock-app nrf5340dk_nrf5340_cpuapp rodata 97304 97512 208 0.2
pump-controller-app nrf52840dk_nrf52840 rodata 103716 103924 208 0.2
Increases (29 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section fb256c5 f7fa122 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 575582 576110 528 0.1
.app_xip_area 482804 483332 528 0.1
lock-app CYW30739 (read/write) 533602 534122 520 0.1
.app_xip_area 442400 442920 520 0.1
efr32 lighting-app BRD4161A (read only) 841496 842112 616 0.1
.text 841488 842104 616 0.1
BRD4161A+rpc (read only) 828856 829488 632 0.1
.text 828848 829480 632 0.1
window-app BRD4161A (read only) 814108 814740 632 0.1
.text 814100 814732 632 0.1
esp32 all-clusters-app c3devkit (read only) 932520 932830 310 0.0
(read/write) 1397882 1398098 216 0.0
.flash.rodata 195744 195960 216 0.1
.flash.text 932520 932830 310 0.0
m5stack (read only) 980491 980803 312 0.0
(read/write) 462248 462456 208 0.0
.flash.rodata 222368 222576 208 0.1
.flash.text 975107 975419 312 0.0
k32w light k32w061+release (read/write) 660276 660788 512 0.1
.text 577412 577924 512 0.1
lock k32w061+release (read/write) 661352 661880 528 0.1
.text 578128 578656 528 0.1
linux chip-tool-ipv6only arm64 (read only) 6985972 6987492 1520 0.0
.rodata 387068 387276 208 0.1
.text 6002436 6003748 1312 0.0
thermostat-no-ble arm64 (read only) 2079596 2080876 1280 0.1
.rodata 130252 130444 192 0.1
.text 1732144 1733232 1088 0.1
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2382064 2382528 464 0.0
.text 1344664 1345128 464 0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2336632 2337096 464 0.0
.text 1299232 1299696 464 0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2300736 2301200 464 0.0
.text 1263336 1263800 464 0.0
shell CY8CPROTO_062_4343W+release (read/write) 2291348 2291812 464 0.0
.text 1253920 1254384 464 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 978979 979507 528 0.1
rodata 115464 115672 208 0.2
text 667216 667524 308 0.0
nrf52840dk_nrf52840+rpc (read/write) 964555 965067 512 0.1
rodata 106936 107144 208 0.2
text 663660 663968 308 0.0
nrf52840dongle_nrf52840 (read/write) 995063 995571 508 0.1
rodata 114296 114500 204 0.2
text 672608 672916 308 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 888178 888706 528 0.1
rodata 108740 108948 208 0.2
text 583400 583712 312 0.1
lock-app nrf52840dk_nrf52840 (read/write) 911623 912135 512 0.1
rodata 104100 104308 208 0.2
text 613248 613556 308 0.1
nrf5340dk_nrf5340_cpuapp (read/write) 821670 822198 528 0.1
rodata 97304 97512 208 0.2
text 530212 530524 312 0.1
pump-app nrf52840dk_nrf52840 (read/write) 914495 915023 528 0.1
rodata 104612 104820 208 0.2
text 615772 616080 308 0.1
pump-controller-app nrf52840dk_nrf52840 (read/write) 909671 910183 512 0.1
rodata 103716 103924 208 0.2
text 611820 612128 308 0.1
p6 all-clusters-app default (read/write) 2442616 2443232 616 0.0
.text 1400880 1401496 616 0.0
light-app default (read/write) 2338192 2338808 616 0.0
.text 1296456 1297072 616 0.0
lock-app default (read/write) 2303664 2304280 616 0.0
.text 1261928 1262544 616 0.0
qpg lighting-app qpg6105+debug (read only) 569648 570076 428 0.1
.text 564328 564756 428 0.1
lock-app qpg6105+debug (read only) 515764 516208 444 0.1
.text 510444 510888 444 0.1
telink lighting-app tlsr9518adk80d (read/write) 843362 843930 568 0.1
text 591236 591584 348 0.1
Full report (33 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section fb256c5 f7fa122 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 575582 576110 528 0.1
.app_xip_area 482804 483332 528 0.1
.bss 75524 75524 0 0.0
.data 596 596 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock-app CYW30739 (read/write) 533602 534122 520 0.1
.app_xip_area 442400 442920 520 0.1
.bss 73988 73988 0 0.0
.data 560 560 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
efr32 lighting-app BRD4161A (read only) 841496 842112 616 0.1
(read/write) 125056 125056 0 0.0
.bss 123160 123160 0 0.0
.data 1892 1892 0 0.0
.text 841488 842104 616 0.1
BRD4161A+rpc (read only) 828856 829488 632 0.1
(read/write) 141712 141712 0 0.0
.bss 139720 139720 0 0.0
.data 1992 1992 0 0.0
.text 828848 829480 632 0.1
window-app BRD4161A (read only) 814108 814740 632 0.1
(read/write) 123684 123684 0 0.0
.bss 121836 121836 0 0.0
.data 1848 1848 0 0.0
.text 814100 814732 632 0.1
esp32 all-clusters-app c3devkit (read only) 932520 932830 310 0.0
(read/write) 1397882 1398098 216 0.0
.dram0.bss 68968 68968 0 0.0
.dram0.data 14268 14268 0 0.0
.flash.rodata 195744 195960 216 0.1
.flash.text 932520 932830 310 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 980491 980803 312 0.0
(read/write) 462248 462456 208 0.0
.dram0.bss 73728 73728 0 0.0
.dram0.data 34024 34024 0 0.0
.flash.rodata 222368 222576 208 0.1
.flash.text 975107 975419 312 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 660276 660788 512 0.1
.bss 75212 75212 0 0.0
.data 1852 1852 0 0.0
.text 577412 577924 512 0.1
lock k32w061+release (read/write) 661352 661880 528 0.1
.bss 75532 75532 0 0.0
.data 1892 1892 0 0.0
.text 578128 578656 528 0.1
linux chip-tool-ipv6only arm64 (read only) 6985972 6987492 1520 0.0
(read/write) 288945 288945 0 0.0
.bss 54593 54593 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 184384 184384 0 0.0
.dynamic 560 560 0 0.0
.got 45072 45072 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 387068 387276 208 0.1
.text 6002436 6003748 1312 0.0
thermostat-no-ble arm64 (read only) 2079596 2080876 1280 0.1
(read/write) 148433 148433 0 0.0
.bss 66177 66177 0 0.0
.data 952 952 0 0.0
.data.rel.ro 74200 74200 0 0.0
.dynamic 560 560 0 0.0
.got 4136 4136 0 0.0
.init 24 24 0 0.0
.init_array 336 336 0 0.0
.rodata 130252 130444 192 0.1
.text 1732144 1733232 1088 0.1
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2382064 2382528 464 0.0
.bss 187884 187884 0 0.0
.data 5288 5288 0 0.0
.text 1344664 1345128 464 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2336632 2337096 464 0.0
.bss 178160 178160 0 0.0
.data 5568 5568 0 0.0
.text 1299232 1299696 464 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2300736 2301200 464 0.0
.bss 178040 178040 0 0.0
.data 5544 5544 0 0.0
.text 1263336 1263800 464 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139712 1139712 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103096 103096 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2291348 2291812 464 0.0
.bss 175316 175316 0 0.0
.data 5368 5368 0 0.0
.text 1253920 1254384 464 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 978979 979507 528 0.1
bss 118528 118528 0 0.0
rodata 115464 115672 208 0.2
text 667216 667524 308 0.0
nrf52840dk_nrf52840+rpc (read/write) 964555 965067 512 0.1
bss 115572 115572 0 0.0
rodata 106936 107144 208 0.2
text 663660 663968 308 0.0
nrf52840dongle_nrf52840 (read/write) 995063 995571 508 0.1
bss 119700 119700 0 0.0
rodata 114296 114500 204 0.2
text 672608 672916 308 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 888178 888706 528 0.1
bss 115316 115316 0 0.0
rodata 108740 108948 208 0.2
text 583400 583712 312 0.1
lock-app nrf52840dk_nrf52840 (read/write) 911623 912135 512 0.1
bss 116888 116888 0 0.0
rodata 104100 104308 208 0.2
text 613248 613556 308 0.1
nrf5340dk_nrf5340_cpuapp (read/write) 821670 822198 528 0.1
bss 113704 113704 0 0.0
rodata 97304 97512 208 0.2
text 530212 530524 312 0.1
pigweed-app nrf52840dk_nrf52840 (read/write) 541779 541779 0 0.0
bss 52588 52588 0 0.0
rodata 50048 50048 0 0.0
text 376940 376940 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 914495 915023 528 0.1
bss 116644 116644 0 0.0
rodata 104612 104820 208 0.2
text 615772 616080 308 0.1
pump-controller-app nrf52840dk_nrf52840 (read/write) 909671 910183 512 0.1
bss 116652 116652 0 0.0
rodata 103716 103924 208 0.2
text 611820 612128 308 0.1
shell nrf52840dk_nrf52840 (read/write) 798379 798379 0 0.0
bss 109776 109776 0 0.0
rodata 78352 78352 0 0.0
text 533752 533752 0 0.0
p6 all-clusters-app default (read/write) 2442616 2443232 616 0.0
.bss 116028 116028 0 0.0
.data 2576 2576 0 0.0
.text 1400880 1401496 616 0.0
light-app default (read/write) 2338192 2338808 616 0.0
.bss 103348 103348 0 0.0
.data 2400 2400 0 0.0
.text 1296456 1297072 616 0.0
lock-app default (read/write) 2303664 2304280 616 0.0
.bss 103068 103068 0 0.0
.data 2360 2360 0 0.0
.text 1261928 1262544 616 0.0
qpg lighting-app qpg6105+debug (read only) 569648 570076 428 0.1
(read/write) 146940 146940 0 0.0
.bss 87504 87504 0 0.0
.data 1056 1056 0 0.0
.text 564328 564756 428 0.1
lock-app qpg6105+debug (read only) 515764 516208 444 0.1
(read/write) 146940 146940 0 0.0
.bss 86944 86944 0 0.0
.data 992 992 0 0.0
.text 510444 510888 444 0.1
persistent-storage-app qpg6105+debug (read only) 107140 107140 0 0.0
(read/write) 146940 146940 0 0.0
.bss 38504 38504 0 0.0
.data 288 288 0 0.0
.text 101820 101820 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 843362 843930 568 0.1
bss 85552 85552 0 0.0
noinit 37160 37160 0 0.0
text 591236 591584 348 0.1

@yunhanw-google yunhanw-google merged commit f09c5fc into project-chip:master Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@yufengwangca yufengwangca yufengwangca approved these changes

@woody-apple woody-apple woody-apple approved these changes

@mrjerryjohns mrjerryjohns mrjerryjohns approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@LuDuda LuDuda Awaiting requested review from LuDuda

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@msandstedt msandstedt Awaiting requested review from msandstedt

@pan-apple pan-apple Awaiting requested review from pan-apple

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@xylophone21 xylophone21 Awaiting requested review from xylophone21

Assignees
No one assigned
Labels
app controller darwin examples fast track lib review - pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@yunhanw-google @woody-apple @mrjerryjohns @yufengwangca @bzbarsky-apple