-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix SEGFAULT when running minmdns client #13423
Merged
andy31415
merged 2 commits into
project-chip:master
from
andy31415:fix_minmdns_client_crash
Jan 11, 2022
Merged
Fix SEGFAULT when running minmdns client #13423
andy31415
merged 2 commits into
project-chip:master
from
andy31415:fix_minmdns_client_crash
Jan 11, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
balducci-apple,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
hawk248,
holbrookt,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
LuDuda,
lzgrablic02,
mlepage-google,
mrjerryjohns,
msandstedt,
pan-apple,
sagar-apple and
saurabhst
January 10, 2022 20:07
pullapprove
bot
requested review from
selissia,
tcarmelveilleux,
tecimovic,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
January 10, 2022 20:07
PR #13423: Size comparison from 46cd8db to ce00701 Decreases (5 builds for linux, p6)
Full report (11 builds for k32w, linux, p6, qpg, telink)
|
msandstedt
approved these changes
Jan 10, 2022
PR #13423: Size comparison from 46cd8db to 15ffbdf Increases above 0.2%:
Increases (1 build for linux)
Decreases (7 builds for efr32, linux, p6)
Full report (14 builds for efr32, k32w, linux, p6, qpg, telink)
|
/rebase |
woody-apple
force-pushed
the
fix_minmdns_client_crash
branch
from
January 11, 2022 02:54
15ffbdf
to
25e873e
Compare
PR #13423: Size comparison from 19f61eb to 25e873e Decreases (11 builds for esp32, linux, mbed, p6)
Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
fast track: trivial change in example code, has a checkmark and sufficient time passed for all timezone review. |
step0035
pushed a commit
to hank820/connectedhomeip
that referenced
this pull request
Feb 8, 2022
* Fix SEGFAULT when running minmdns client * Fix typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Chip MDNS client uses a timeout to schedule a 'platform shutdown'.
When shutting down, the MinMDNS Server still holds UDP references and attempts to release them in its destructor, which crashes since SystemLayer has been shut down and is likely deallocated.
Change overview
Shutdown the mdns server before attempting to shut down the rest of the platform.
Testing
Rand minmdns client binary and observed no more SEGFAULT.