-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EFR32 OTA] Invoke Silabs API for writing, verifying and applying the image #13499
Merged
woody-apple
merged 13 commits into
project-chip:master
from
selissia:silabs_bootloader_1
Jan 13, 2022
Merged
[EFR32 OTA] Invoke Silabs API for writing, verifying and applying the image #13499
woody-apple
merged 13 commits into
project-chip:master
from
selissia:silabs_bootloader_1
Jan 13, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #13499: Size comparison from 1181e94 to 1265e61 Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
PR #13499: Size comparison from 60347b6 to 2ed0c90 Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
* Close exchange when session is released * Add clearRetransTable parameter to DoClose call Co-authored-by: Andrei Litvin <andy314@gmail.com>
…meip into silabs_bootloader_1
selissia
changed the title
Work in progress silabs_bootloader_1 branch PR
[EFR32 OTA] Invoke Silabs API for writing, verifying and applying the image
Jan 13, 2022
pullapprove
bot
requested review from
andy31415,
anush-apple,
balducci-apple,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu and
chulspro
January 13, 2022 14:57
pullapprove
bot
requested review from
holbrookt,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kpschoedel,
LuDuda,
mlepage-google,
msandstedt,
mspang,
pan-apple,
robszewczyk,
sagar-apple,
saurabhst,
tecimovic,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yunhanw-google
January 13, 2022 14:57
PR #13499: Size comparison from 60347b6 to cd5c399 Increases above 0.2%:
Increases (17 builds for esp32, mbed, nrfconnect, telink)
Decreases (8 builds for nrfconnect)
Full report (19 builds for esp32, mbed, nrfconnect, telink)
|
woody-apple
approved these changes
Jan 13, 2022
Fast tracking, given platform changes by a platform maintainer. |
selissia
added a commit
to selissia/connectedhomeip
that referenced
this pull request
Jan 28, 2022
… image (project-chip#13499) * Code for testing bootloader integration * Add bootloader API calls * Add the rest of booloader calls to EFR32 OTA Requestor * Call the OTARequestor Init() method * Use correct booloader API * Close exchange when session is released (project-chip#13448) * Close exchange when session is released * Add clearRetransTable parameter to DoClose call Co-authored-by: Andrei Litvin <andy314@gmail.com> * Clean up comments and debug code * Restyled by whitespace * Restyled by clang-format Co-authored-by: Zang MingJie <mingjiez@google.com> Co-authored-by: Andrei Litvin <andy314@gmail.com> Co-authored-by: Restyled.io <commits@restyled.io>
step0035
pushed a commit
to hank820/connectedhomeip
that referenced
this pull request
Feb 8, 2022
… image (project-chip#13499) * Code for testing bootloader integration * Add bootloader API calls * Add the rest of booloader calls to EFR32 OTA Requestor * Call the OTARequestor Init() method * Use correct booloader API * Close exchange when session is released (project-chip#13448) * Close exchange when session is released * Add clearRetransTable parameter to DoClose call Co-authored-by: Andrei Litvin <andy314@gmail.com> * Clean up comments and debug code * Restyled by whitespace * Restyled by clang-format Co-authored-by: Zang MingJie <mingjiez@google.com> Co-authored-by: Andrei Litvin <andy314@gmail.com> Co-authored-by: Restyled.io <commits@restyled.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
EFR32 implementation must invoke correct image management API
Change overview
Invoke Silabs API for writing, verifying and applying the image
Testing
Tested Provider->Requestor image download over Thread. Provider/Requestor message exchange completes, BDX download starts.
The above test was done on commit #13448 as the Provider/Requestor session establishment is broken on the current master.