Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[K32W0] Fix OTA memory allocation #13530

Merged
merged 3 commits into from
Jan 24, 2022
Merged

[K32W0] Fix OTA memory allocation #13530

merged 3 commits into from
Jan 24, 2022

Conversation

doru91
Copy link
Contributor

@doru91 doru91 commented Jan 13, 2022 •
edited
Loading

Problem

Change overview

Use the non-buggy version from ESP32.

Testing

How was this tested? (at least one bullet point required)

  • not tested yet, still working on OTA end-to-end flow

@doru91
[K32W0] Fix OTA memory allocation
8c36012 
Use the non-buggy version from ESP32.
See also: project-chip#1339

Signed-off-by: Doru Gucea <doru-cristian.gucea@nxp.com>
@restyled-io restyled-io bot mentioned this pull request Jan 13, 2022
Closed
@github-actions
Copy link

github-actions bot commented Jan 13, 2022 •
edited
Loading

PR #13530: Size comparison from cd9bea7 to a757ae7

Increases (1 build for k32w)
platform target config section cd9bea7 a757ae7 change % change
k32w light k32w061+release (read/write) 657384 657400 16 0.0
.text 572596 572612 16 0.0
Full report (30 builds for efr32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section cd9bea7 a757ae7 change % change
efr32 lighting-app BRD4161A (read only) 831456 831456 0 0.0
(read/write) 127612 127612 0 0.0
.bss 125732 125732 0 0.0
.data 1880 1880 0 0.0
.text 831448 831448 0 0.0
BRD4161A+rpc (read only) 818852 818852 0 0.0
(read/write) 144272 144272 0 0.0
.bss 142292 142292 0 0.0
.data 1980 1980 0 0.0
.text 818844 818844 0 0.0
window-app BRD4161A (read only) 805336 805336 0 0.0
(read/write) 126320 126320 0 0.0
.bss 124480 124480 0 0.0
.data 1836 1836 0 0.0
.text 805328 805328 0 0.0
k32w light k32w061+release (read/write) 657384 657400 16 0.0
.bss 77136 77136 0 0.0
.data 1852 1852 0 0.0
.text 572596 572612 16 0.0
lock k32w061+release (read/write) 661668 661668 0 0.0
.bss 77432 77432 0 0.0
.data 1872 1872 0 0.0
.text 576564 576564 0 0.0
linux chip-tool-ipv6only arm64 (read only) 7742916 7742916 0 0.0
(read/write) 360817 360817 0 0.0
.bss 55217 55217 0 0.0
.data 1096 1096 0 0.0
.data.rel.ro 239216 239216 0 0.0
.dynamic 560 560 0 0.0
.got 61592 61592 0 0.0
.init 24 24 0 0.0
.init_array 168 168 0 0.0
.rodata 404124 404124 0 0.0
.text 6573700 6573700 0 0.0
thermostat-no-ble arm64 (read only) 2040908 2040908 0 0.0
(read/write) 145969 145969 0 0.0
.bss 65089 65089 0 0.0
.data 880 880 0 0.0
.data.rel.ro 73016 73016 0 0.0
.dynamic 560 560 0 0.0
.got 4048 4048 0 0.0
.init 24 24 0 0.0
.init_array 304 304 0 0.0
.rodata 129868 129868 0 0.0
.text 1696448 1696448 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2346360 2346360 0 0.0
.bss 189188 189188 0 0.0
.data 5320 5320 0 0.0
.text 1308936 1308936 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2331392 2331392 0 0.0
.bss 180728 180728 0 0.0
.data 5552 5552 0 0.0
.text 1293992 1293992 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2304552 2304552 0 0.0
.bss 179768 179768 0 0.0
.data 5544 5544 0 0.0
.text 1267152 1267152 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139712 1139712 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103096 103096 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2054392 2054392 0 0.0
.bss 156876 156876 0 0.0
.data 4864 4864 0 0.0
.text 1016992 1016992 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 940411 940411 0 0.0
bss 119596 119596 0 0.0
rodata 108600 108600 0 0.0
text 634632 634632 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 925843 925843 0 0.0
bss 116640 116640 0 0.0
rodata 101048 101048 0 0.0
text 629984 629984 0 0.0
nrf52840dongle_nrf52840 (read/write) 991071 991071 0 0.0
bss 122440 122440 0 0.0
rodata 113352 113352 0 0.0
text 666828 666828 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 850238 850238 0 0.0
bss 116384 116384 0 0.0
rodata 101776 101776 0 0.0
text 551552 551552 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 912651 912651 0 0.0
bss 118784 118784 0 0.0
rodata 103872 103872 0 0.0
text 612624 612624 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 822718 822718 0 0.0
bss 115600 115600 0 0.0
rodata 97096 97096 0 0.0
text 529584 529584 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 541835 541835 0 0.0
bss 52588 52588 0 0.0
rodata 50104 50104 0 0.0
text 376940 376940 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 913963 913963 0 0.0
bss 118544 118544 0 0.0
rodata 104088 104088 0 0.0
text 613884 613884 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 910763 910763 0 0.0
bss 118572 118572 0 0.0
rodata 103344 103344 0 0.0
text 611372 611372 0 0.0
shell nrf52840dk_nrf52840 (read/write) 798627 798627 0 0.0
bss 109776 109776 0 0.0
rodata 78376 78376 0 0.0
text 533968 533968 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 711446 711446 0 0.0
bss 107664 107664 0 0.0
rodata 72680 72680 0 0.0
text 451648 451648 0 0.0
p6 all-clusters-app default (read/write) 2400512 2400512 0 0.0
.bss 117460 117460 0 0.0
.data 2592 2592 0 0.0
.text 1358776 1358776 0 0.0
light-app default (read/write) 2326232 2326232 0 0.0
.bss 106040 106040 0 0.0
.data 2384 2384 0 0.0
.text 1284496 1284496 0 0.0
lock-app default (read/write) 2298464 2298464 0 0.0
.bss 104920 104920 0 0.0
.data 2344 2344 0 0.0
.text 1256728 1256728 0 0.0
qpg lighting-app qpg6105+debug (read only) 535100 535100 0 0.0
(read/write) 146940 146940 0 0.0
.bss 89336 89336 0 0.0
.data 1008 1008 0 0.0
.text 529780 529780 0 0.0
lock-app qpg6105+debug (read only) 507008 507008 0 0.0
(read/write) 146936 146936 0 0.0
.bss 88472 88472 0 0.0
.data 956 956 0 0.0
.text 501688 501688 0 0.0
persistent-storage-app qpg6105+debug (read only) 106848 106848 0 0.0
(read/write) 146940 146940 0 0.0
.bss 38504 38504 0 0.0
.data 288 288 0 0.0
.text 101528 101528 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 837062 837062 0 0.0
bss 87288 87288 0 0.0
noinit 37160 37160 0 0.0
text 584334 584334 0 0.0

woody-apple
woody-apple approved these changes Jan 13, 2022
View reviewed changes
Copy link
Contributor

@woody-apple woody-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fast tracking, given platform changes by a platform maintainer.

@doru91
[K32W0] Remove unneeded memory free
9900259 
Signed-off-by: Doru Gucea <doru-cristian.gucea@nxp.com>
@andy31415 andy31415 merged commit b7854c5 into project-chip:master Jan 24, 2022
selissia pushed a commit to selissia/connectedhomeip that referenced this pull request Jan 28, 2022
@doru91 @restyled-commits @selissia
[K32W0] Fix OTA memory allocation (project-chip#13530)
a7e90d9 
* [K32W0] Fix OTA memory allocation

Use the non-buggy version from ESP32.
See also: project-chip#1339

Signed-off-by: Doru Gucea <doru-cristian.gucea@nxp.com>

* Restyled by clang-format

* [K32W0] Remove unneeded memory free

Signed-off-by: Doru Gucea <doru-cristian.gucea@nxp.com>

Co-authored-by: Restyled.io <commits@restyled.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple left review comments

@woody-apple woody-apple woody-apple approved these changes

@selissia selissia selissia approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@pan-apple pan-apple Awaiting requested review from pan-apple

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@tecimovic tecimovic Awaiting requested review from tecimovic

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
fast track platform review - pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@doru91 @woody-apple @selissia @carol-apple @bzbarsky-apple @andy31415 @restyled-commits