-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable android studio build #13631
Merged
andy31415
merged 1 commit into
project-chip:master
from
andy31415:disable_android_studio_build
Jan 17, 2022
Merged
Disable android studio build #13631
andy31415
merged 1 commit into
project-chip:master
from
andy31415:disable_android_studio_build
Jan 17, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
balducci-apple,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs and
kghost
January 17, 2022 16:14
pullapprove
bot
requested review from
LuDuda,
woody-apple,
lzgrablic02,
xylophone21,
yufengwangca,
mlepage-google,
mrjerryjohns,
yunhanw-google,
msandstedt,
pan-apple,
sagar-apple,
saurabhst,
selissia,
tecimovic,
turon,
vijs,
vivien-apple and
wbschiller
January 17, 2022 16:14
PR #13631: Size comparison from 9109dff to f22b372 Full report (21 builds for efr32, esp32, k32w, linux, mbed, p6, qpg, telink)
|
Android build seems to complete now. I still see it taking a long time in "Cleaning orphan processes" so may our build leaks somehow ... still needs to be investigated, but at least this should move ToT towards green. Marking as hotfix. |
selissia
pushed a commit
to selissia/connectedhomeip
that referenced
this pull request
Jan 28, 2022
step0035
pushed a commit
to hank820/connectedhomeip
that referenced
this pull request
Feb 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Android studio compilation seems to hang.
Change overview
Disable it. We still test general android compilation without studio.
We lose android studio configuration validation, however that does not seem as critical as training people to ignore android CI.
Testing
CI will test this for android being able to complete. Change is generally quite safe as it just disables a build step.