Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add operational cluster commands to simulated device. #13777

Merged
merged 2 commits into from
Jan 21, 2022
Merged

Add operational cluster commands to simulated device. #13777

merged 2 commits into from
Jan 21, 2022

Conversation

krypton36
Copy link
Contributor

Problem

Simulated device is missing Operation Credential commands to generate code for tests.

Change overview

Changed app ZAP file to contain commands for test generation.
Generated code.

Testing

Created a YAML file to generate missing command and compiled apps.

@github-actions
Copy link

github-actions bot commented Jan 20, 2022 •
edited
Loading

PR #13777: Size comparison from fd815cd to 4795836

Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section fd815cd 4795836 change % change
efr32 lighting-app BRD4161A (read only) 833628 833628 0 0.0
(read/write) 127032 127032 0 0.0
.bss 125136 125136 0 0.0
.data 1896 1896 0 0.0
.text 833620 833620 0 0.0
BRD4161A+rpc (read only) 821008 821008 0 0.0
(read/write) 143696 143696 0 0.0
.bss 141696 141696 0 0.0
.data 1996 1996 0 0.0
.text 821000 821000 0 0.0
window-app BRD4161A (read only) 804196 804196 0 0.0
(read/write) 125720 125720 0 0.0
.bss 123872 123872 0 0.0
.data 1848 1848 0 0.0
.text 804188 804188 0 0.0
esp32 all-clusters-app c3devkit (read only) 916854 916854 0 0.0
(read/write) 1317522 1317522 0 0.0
.dram0.bss 70720 70720 0 0.0
.dram0.data 14244 14244 0 0.0
.flash.rodata 178968 178968 0 0.0
.flash.text 916854 916854 0 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 965463 965463 0 0.0
(read/write) 449480 449480 0 0.0
.dram0.bss 75184 75184 0 0.0
.dram0.data 34032 34032 0 0.0
.flash.rodata 208136 208136 0 0.0
.flash.text 960079 960079 0 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 658924 658924 0 0.0
.bss 76584 76584 0 0.0
.data 1864 1864 0 0.0
.text 574676 574676 0 0.0
lock k32w061+release (read/write) 659704 659704 0 0.0
.bss 76824 76824 0 0.0
.data 1884 1884 0 0.0
.text 575196 575196 0 0.0
linux chip-tool-ipv6only arm64 (read only) 8390652 8390652 0 0.0
(read/write) 386417 386417 0 0.0
.bss 56049 56049 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 257432 257432 0 0.0
.dynamic 560 560 0 0.0
.got 68056 68056 0 0.0
.init 24 24 0 0.0
.init_array 200 200 0 0.0
.rodata 430228 430228 0 0.0
.text 7131620 7131620 0 0.0
thermostat-no-ble arm64 (read only) 2043324 2043324 0 0.0
(read/write) 145425 145425 0 0.0
.bss 64753 64753 0 0.0
.data 904 904 0 0.0
.data.rel.ro 72752 72752 0 0.0
.dynamic 560 560 0 0.0
.got 4064 4064 0 0.0
.init 24 24 0 0.0
.init_array 312 312 0 0.0
.rodata 130028 130028 0 0.0
.text 1699136 1699136 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2349968 2349968 0 0.0
.bss 189428 189428 0 0.0
.data 5296 5296 0 0.0
.text 1312544 1312544 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2332728 2332728 0 0.0
.bss 180936 180936 0 0.0
.data 5576 5576 0 0.0
.text 1295328 1295328 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2303080 2303080 0 0.0
.bss 179936 179936 0 0.0
.data 5560 5560 0 0.0
.text 1265680 1265680 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139712 1139712 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103096 103096 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2054256 2054256 0 0.0
.bss 156876 156876 0 0.0
.data 4864 4864 0 0.0
.text 1016856 1016856 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 941287 941287 0 0.0
bss 119020 119020 0 0.0
rodata 108508 108508 0 0.0
text 636164 636164 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 926751 926751 0 0.0
bss 116064 116064 0 0.0
rodata 100956 100956 0 0.0
text 631560 631560 0 0.0
nrf52840dongle_nrf52840 (read/write) 991963 991963 0 0.0
bss 121864 121864 0 0.0
rodata 113260 113260 0 0.0
text 668364 668364 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 851114 851114 0 0.0
bss 115808 115808 0 0.0
rodata 101684 101684 0 0.0
text 553088 553088 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 910631 910631 0 0.0
bss 118176 118176 0 0.0
rodata 103476 103476 0 0.0
text 611612 611612 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 820698 820698 0 0.0
bss 114992 114992 0 0.0
rodata 96700 96700 0 0.0
text 528568 528568 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 541835 541835 0 0.0
bss 52588 52588 0 0.0
rodata 50104 50104 0 0.0
text 376940 376940 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 913503 913503 0 0.0
bss 117940 117940 0 0.0
rodata 103836 103836 0 0.0
text 614260 614260 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 908583 908583 0 0.0
bss 117964 117964 0 0.0
rodata 102948 102948 0 0.0
text 610188 610188 0 0.0
shell nrf52840dk_nrf52840 (read/write) 798479 798479 0 0.0
bss 109776 109776 0 0.0
rodata 78324 78324 0 0.0
text 533872 533872 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 711278 711278 0 0.0
bss 107664 107664 0 0.0
rodata 72624 72624 0 0.0
text 451548 451548 0 0.0
p6 all-clusters-app default (read/write) 2407464 2407464 0 0.0
.bss 117764 117764 0 0.0
.data 2576 2576 0 0.0
.text 1365728 1365728 0 0.0
light-app default (read/write) 2328696 2328696 0 0.0
.bss 105520 105520 0 0.0
.data 2408 2408 0 0.0
.text 1286960 1286960 0 0.0
lock-app default (read/write) 2297704 2297704 0 0.0
.bss 104368 104368 0 0.0
.data 2352 2352 0 0.0
.text 1255968 1255968 0 0.0
qpg lighting-app qpg6105+debug (read only) 565720 565720 0 0.0
(read/write) 146936 146936 0 0.0
.bss 89672 89672 0 0.0
.data 1060 1060 0 0.0
.text 560400 560400 0 0.0
lock-app qpg6105+debug (read only) 514212 514212 0 0.0
(read/write) 146940 146940 0 0.0
.bss 88240 88240 0 0.0
.data 984 984 0 0.0
.text 508892 508892 0 0.0
persistent-storage-app qpg6105+debug (read only) 106848 106848 0 0.0
(read/write) 146940 146940 0 0.0
.bss 38512 38512 0 0.0
.data 288 288 0 0.0
.text 101528 101528 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 839882 839882 0 0.0
bss 87468 87468 0 0.0
noinit 37160 37160 0 0.0
text 586962 586962 0 0.0

@krypton36 krypton36 force-pushed the AddOperationalCluster branch from 4795836 to 59fac87 Compare January 21, 2022 15:46
@github-actions
Copy link

github-actions bot commented Jan 21, 2022 •
edited
Loading

PR #13777: Size comparison from b519c8e to 59fac87

Full report (15 builds for cyw30739, efr32, k32w, linux, p6, qpg, telink)
platform target config section b519c8e 59fac87 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 573814 573814 0 0.0
.app_xip_area 478836 478836 0 0.0
.bss 77716 77716 0 0.0
.data 604 604 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
efr32 lighting-app BRD4161A (read only) 834948 834948 0 0.0
(read/write) 127244 127244 0 0.0
.bss 125344 125344 0 0.0
.data 1900 1900 0 0.0
.text 834940 834940 0 0.0
BRD4161A+rpc (read only) 822352 822352 0 0.0
(read/write) 143904 143904 0 0.0
.bss 141904 141904 0 0.0
.data 2000 2000 0 0.0
.text 822344 822344 0 0.0
window-app BRD4161A (read only) 805508 805508 0 0.0
(read/write) 125812 125812 0 0.0
.bss 123960 123960 0 0.0
.data 1852 1852 0 0.0
.text 805500 805500 0 0.0
k32w light k32w061+release (read/write) 659928 659928 0 0.0
.bss 76600 76600 0 0.0
.data 1868 1868 0 0.0
.text 575660 575660 0 0.0
lock k32w061+release (read/write) 660732 660732 0 0.0
.bss 76848 76848 0 0.0
.data 1888 1888 0 0.0
.text 576196 576196 0 0.0
linux chip-tool-ipv6only arm64 (read only) 8472012 8472012 0 0.0
(read/write) 390001 390001 0 0.0
.bss 56049 56049 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 260368 260368 0 0.0
.dynamic 560 560 0 0.0
.got 68704 68704 0 0.0
.init 24 24 0 0.0
.init_array 200 200 0 0.0
.rodata 435188 435188 0 0.0
.text 7200308 7200308 0 0.0
thermostat-no-ble arm64 (read only) 2048444 2048444 0 0.0
(read/write) 145681 145681 0 0.0
.bss 64785 64785 0 0.0
.data 904 904 0 0.0
.data.rel.ro 72968 72968 0 0.0
.dynamic 560 560 0 0.0
.got 4064 4064 0 0.0
.init 24 24 0 0.0
.init_array 320 320 0 0.0
.rodata 130380 130380 0 0.0
.text 1703648 1703648 0 0.0
p6 all-clusters-app default (read/write) 2409072 2409072 0 0.0
.bss 117788 117788 0 0.0
.data 2584 2584 0 0.0
.text 1367336 1367336 0 0.0
light-app default (read/write) 2330040 2330040 0 0.0
.bss 105536 105536 0 0.0
.data 2408 2408 0 0.0
.text 1288304 1288304 0 0.0
lock-app default (read/write) 2299024 2299024 0 0.0
.bss 104392 104392 0 0.0
.data 2360 2360 0 0.0
.text 1257288 1257288 0 0.0
qpg lighting-app qpg6105+debug (read only) 566840 566840 0 0.0
(read/write) 146940 146940 0 0.0
.bss 89680 89680 0 0.0
.data 1064 1064 0 0.0
.text 561520 561520 0 0.0
lock-app qpg6105+debug (read only) 515336 515336 0 0.0
(read/write) 146936 146936 0 0.0
.bss 88256 88256 0 0.0
.data 988 988 0 0.0
.text 510016 510016 0 0.0
persistent-storage-app qpg6105+debug (read only) 107140 107140 0 0.0
(read/write) 146940 146940 0 0.0
.bss 38504 38504 0 0.0
.data 288 288 0 0.0
.text 101820 101820 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 840934 840934 0 0.0
bss 87488 87488 0 0.0
noinit 37160 37160 0 0.0
text 587730 587730 0 0.0

@krypton36
Copy link
Contributor Author

/rebase

@woody-apple woody-apple force-pushed the AddOperationalCluster branch from 59fac87 to 4180069 Compare January 21, 2022 16:42
@github-actions
Copy link

github-actions bot commented Jan 21, 2022 •
edited
Loading

PR #13777: Size comparison from 6e1a741 to 4180069

Full report (33 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 6e1a741 4180069 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 574238 574238 0 0.0
.app_xip_area 479252 479252 0 0.0
.bss 77724 77724 0 0.0
.data 604 604 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
efr32 lighting-app BRD4161A (read only) 835452 835452 0 0.0
(read/write) 127244 127244 0 0.0
.bss 125344 125344 0 0.0
.data 1900 1900 0 0.0
.text 835444 835444 0 0.0
BRD4161A+rpc (read only) 822848 822848 0 0.0
(read/write) 143904 143904 0 0.0
.bss 141904 141904 0 0.0
.data 2000 2000 0 0.0
.text 822840 822840 0 0.0
window-app BRD4161A (read only) 806004 806004 0 0.0
(read/write) 125812 125812 0 0.0
.bss 123960 123960 0 0.0
.data 1852 1852 0 0.0
.text 805996 805996 0 0.0
esp32 all-clusters-app c3devkit (read only) 918262 918262 0 0.0
(read/write) 1383402 1383402 0 0.0
.dram0.bss 70704 70704 0 0.0
.dram0.data 14260 14260 0 0.0
.flash.rodata 179312 179312 0 0.0
.flash.text 918262 918262 0 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 966615 966615 0 0.0
(read/write) 449804 449804 0 0.0
.dram0.bss 75168 75168 0 0.0
.dram0.data 34032 34032 0 0.0
.flash.rodata 208476 208476 0 0.0
.flash.text 961231 961231 0 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 660332 660332 0 0.0
.bss 76608 76608 0 0.0
.data 1868 1868 0 0.0
.text 576056 576056 0 0.0
lock k32w061+release (read/write) 661148 661148 0 0.0
.bss 76848 76848 0 0.0
.data 1888 1888 0 0.0
.text 576612 576612 0 0.0
linux chip-tool-ipv6only arm64 (read only) 8472892 8472892 0 0.0
(read/write) 390081 390081 0 0.0
.bss 56049 56049 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 260440 260440 0 0.0
.dynamic 560 560 0 0.0
.got 68720 68720 0 0.0
.init 24 24 0 0.0
.init_array 200 200 0 0.0
.rodata 435236 435236 0 0.0
.text 7200932 7200932 0 0.0
thermostat-no-ble arm64 (read only) 2049644 2049644 0 0.0
(read/write) 145697 145697 0 0.0
.bss 64785 64785 0 0.0
.data 904 904 0 0.0
.data.rel.ro 72984 72984 0 0.0
.dynamic 560 560 0 0.0
.got 4064 4064 0 0.0
.init 24 24 0 0.0
.init_array 320 320 0 0.0
.rodata 130492 130492 0 0.0
.text 1704656 1704656 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2351464 2351464 0 0.0
.bss 189412 189412 0 0.0
.data 5304 5304 0 0.0
.text 1314040 1314040 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2334144 2334144 0 0.0
.bss 180960 180960 0 0.0
.data 5584 5584 0 0.0
.text 1296744 1296744 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2304496 2304496 0 0.0
.bss 179960 179960 0 0.0
.data 5560 5560 0 0.0
.text 1267096 1267096 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139712 1139712 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103096 103096 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2054256 2054256 0 0.0
.bss 156876 156876 0 0.0
.data 4864 4864 0 0.0
.text 1016856 1016856 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 942715 942715 0 0.0
bss 119044 119044 0 0.0
rodata 108896 108896 0 0.0
text 637168 637168 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 928183 928183 0 0.0
bss 116088 116088 0 0.0
rodata 101348 101348 0 0.0
text 632564 632564 0 0.0
nrf52840dongle_nrf52840 (read/write) 993359 993359 0 0.0
bss 121884 121884 0 0.0
rodata 113648 113648 0 0.0
text 669368 669368 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 852542 852542 0 0.0
bss 115828 115828 0 0.0
rodata 102072 102072 0 0.0
text 554088 554088 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 912059 912059 0 0.0
bss 118196 118196 0 0.0
rodata 103864 103864 0 0.0
text 612608 612608 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 822130 822130 0 0.0
bss 115016 115016 0 0.0
rodata 97092 97092 0 0.0
text 529564 529564 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 541835 541835 0 0.0
bss 52588 52588 0 0.0
rodata 50104 50104 0 0.0
text 376940 376940 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 914915 914915 0 0.0
bss 117960 117960 0 0.0
rodata 104224 104224 0 0.0
text 615256 615256 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 910103 910103 0 0.0
bss 117984 117984 0 0.0
rodata 103380 103380 0 0.0
text 611280 611280 0 0.0
shell nrf52840dk_nrf52840 (read/write) 798527 798527 0 0.0
bss 109776 109776 0 0.0
rodata 78324 78324 0 0.0
text 533928 533928 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 711342 711342 0 0.0
bss 107664 107664 0 0.0
rodata 72624 72624 0 0.0
text 451608 451608 0 0.0
p6 all-clusters-app default (read/write) 2409552 2409552 0 0.0
.bss 117756 117756 0 0.0
.data 2584 2584 0 0.0
.text 1367816 1367816 0 0.0
light-app default (read/write) 2330536 2330536 0 0.0
.bss 105544 105544 0 0.0
.data 2408 2408 0 0.0
.text 1288800 1288800 0 0.0
lock-app default (read/write) 2299528 2299528 0 0.0
.bss 104392 104392 0 0.0
.data 2360 2360 0 0.0
.text 1257792 1257792 0 0.0
qpg lighting-app qpg6105+debug (read only) 567240 567240 0 0.0
(read/write) 146940 146940 0 0.0
.bss 89688 89688 0 0.0
.data 1064 1064 0 0.0
.text 561920 561920 0 0.0
lock-app qpg6105+debug (read only) 515752 515752 0 0.0
(read/write) 146936 146936 0 0.0
.bss 88256 88256 0 0.0
.data 988 988 0 0.0
.text 510432 510432 0 0.0
persistent-storage-app qpg6105+debug (read only) 107140 107140 0 0.0
(read/write) 146940 146940 0 0.0
.bss 38504 38504 0 0.0
.data 288 288 0 0.0
.text 101820 101820 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 841514 841514 0 0.0
bss 87492 87492 0 0.0
noinit 37160 37160 0 0.0
text 588162 588162 0 0.0

@woody-apple
Copy link
Contributor

Fast tracking given this is adding tests.

@andy31415 andy31415 merged commit 225a20b into project-chip:master Jan 21, 2022
selissia pushed a commit to selissia/connectedhomeip that referenced this pull request Jan 28, 2022
@selissia
Add operational cluster commands to simulated device. (project-chip#1…
e0df1ef 
…3777)

* Enable cient side clusters.

* Generated Code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@pan-apple pan-apple Awaiting requested review from pan-apple

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

Assignees
No one assigned
Labels
examples fast track review - pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@krypton36 @woody-apple @bzbarsky-apple @andy31415