-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update loop function signature #13828
Merged
bzbarsky-apple
merged 1 commit into
project-chip:master
from
mkardous-silabs:fix/loop_build
Jan 21, 2022
Merged
Update loop function signature #13828
bzbarsky-apple
merged 1 commit into
project-chip:master
from
mkardous-silabs:fix/loop_build
Jan 21, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
balducci-apple,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kpschoedel,
LuDuda,
mlepage-google and
mrjerryjohns
January 21, 2022 18:18
pullapprove
bot
requested review from
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt,
mspang,
pan-apple,
sagar-apple,
saurabhst,
selissia,
tecimovic,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
January 21, 2022 18:18
PR #13828: Size comparison from a5a7d92 to 6bf41bd Increases (6 builds for efr32, p6)
Decreases (17 builds for cyw30739, k32w, linux, mbed, nrfconnect, qpg, telink)
Full report (31 builds for cyw30739, efr32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
bzbarsky-apple
approved these changes
Jan 21, 2022
Looks like the code we merged builds with the old XCode GitHub Enterprise uses, but not newer XCode versions (like what Github personal uses, or most people at home). |
yufengwangca
approved these changes
Jan 21, 2022
austinh0
pushed a commit
to austinh0/connectedhomeip
that referenced
this pull request
Jan 24, 2022
andy31415
added a commit
that referenced
this pull request
Jan 25, 2022
* Complex types in Java * Regenerate * loop fix (#13828) * Ran zap regen (#13837) * Update ZAP to pick up reportability changes. (#13802) We can now explicitly default all attributes to "reportable". XML files will be able to set reportingPolicy="prohibited" for things that the Matter spec decides are not subscribable. * Use UniquePtr, fix templates * Regen with updated ZAP * Regen again Co-authored-by: mkardous-silabs <84793247+mkardous-silabs@users.noreply.github.com> Co-authored-by: Andrei Litvin <andrei@andy314.com> Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
selissia
pushed a commit
to selissia/connectedhomeip
that referenced
this pull request
Jan 28, 2022
selissia
pushed a commit
to selissia/connectedhomeip
that referenced
this pull request
Jan 28, 2022
* Complex types in Java * Regenerate * loop fix (project-chip#13828) * Ran zap regen (project-chip#13837) * Update ZAP to pick up reportability changes. (project-chip#13802) We can now explicitly default all attributes to "reportable". XML files will be able to set reportingPolicy="prohibited" for things that the Matter spec decides are not subscribable. * Use UniquePtr, fix templates * Regen with updated ZAP * Regen again Co-authored-by: mkardous-silabs <84793247+mkardous-silabs@users.noreply.github.com> Co-authored-by: Andrei Litvin <andrei@andy314.com> Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Change overview
Testing