-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for out of tree LayerImpl implementation #14452
Merged
andy31415
merged 1 commit into
project-chip:master
from
dnicoara:out-of-tree-layer-impl
Jan 31, 2022
Merged
Add support for out of tree LayerImpl implementation #14452
andy31415
merged 1 commit into
project-chip:master
from
dnicoara:out-of-tree-layer-impl
Jan 31, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnicoara
force-pushed
the
out-of-tree-layer-impl
branch
from
January 27, 2022 21:10
addfa55
to
90fca37
Compare
andy31415
approved these changes
Jan 27, 2022
bzbarsky-apple
approved these changes
Jan 28, 2022
PR #14452: Size comparison from 33c4854 to 90fca37 Increases (7 builds for cyw30739, efr32, esp32, p6, qpg, telink)
Decreases (3 builds for efr32, mbed, qpg)
Full report (33 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
pullapprove
bot
requested review from
Byungjoo-Lee,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
gjc13,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
LuDuda,
msandstedt,
saurabhst,
selissia,
tecimovic,
vijs,
wbschiller and
xylophone21
January 28, 2022 21:22
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Embedders currently need to add local patches in order to provide an out of tree implementation of SystemLayerImpl.
Change overview
This change adds a GN flag allowing embedders to define CHIP_SYSTEM_LAYER_IMPL_CONFIG_FILE to point to whatever file they want.
Testing
gn gen
and build without definingchip_system_layer_impl_config_file
to verify that default configuration does not break.gn gen
and build withchip_system_layer_impl_config_file
to verify that the file is correctly customized.