Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move the access control ownership and initialization to Server. #14680

Merged
merged 2 commits into from
Feb 4, 2022
Merged

Move the access control ownership and initialization to Server. #14680

merged 2 commits into from
Feb 4, 2022

Conversation

harimau-qirex
Copy link
Contributor

Problem

The simple ACL storage added in #14253 is only supported by Linux and MacOS. By moving the ownership of the AccessControl object to Server and using the platform storage delegate that it owns, all platforms that use Server will get ACL persistence.
Fixes #10251.

Change overview

  • Move the ownership of the AccessControl object from the ACL cluster to Server.
  • Remove the ACL storage delegate from the AppMain.cpp used by Linux and MacOS.
  • Initializing ACL without storage or stored ACL data is no longer considered a failure.

Testing

  • Manually tested on MacOS by commissioning all-clusters-app, writing ACL entries, then restarting all-clusters-app and verifying the entries were still present.

@github-actions
Copy link

github-actions bot commented Feb 1, 2022 •
edited
Loading

PR #14680: Size comparison from 9f16e9a to 8ded51f

Increases above 0.2%:

platform target config section 9f16e9a 8ded51f change % change
cyw30739 light cyw930739m2evb_01 (read/write) 577150 582130 4980 0.9
.app_xip_area 484356 488456 4100 0.8
.bss 75540 76396 856 1.1
.data 596 620 24 4.0
lock cyw930739m2evb_01 (read/write) 535146 540130 4984 0.9
.app_xip_area 443920 448024 4104 0.9
.bss 74012 74868 856 1.2
.data 560 584 24 4.3
ota-requestor cyw930739m2evb_01 (read/write) 559890 564854 4964 0.9
.app_xip_area 459360 463444 4084 0.9
.bss 82988 83844 856 1.0
.data 504 528 24 4.8
efr32 lighting-app BRD4161A (read only) 843616 849712 6096 0.7
(read/write) 125072 126152 1080 0.9
.bss 123176 124224 1048 0.9
.data 1896 1924 28 1.5
.text 843608 849704 6096 0.7
BRD4161A+rpc (read only) 830984 837088 6104 0.7
(read/write) 141736 142808 1072 0.8
.bss 139736 140784 1048 0.7
.data 1996 2024 28 1.4
.text 830976 837080 6104 0.7
window-app BRD4161A (read only) 816164 822260 6096 0.7
(read/write) 123704 124784 1080 0.9
.bss 121852 122904 1052 0.9
.data 1852 1880 28 1.5
.text 816156 822252 6096 0.7
linux bridge-app debug+rpc (read only) 1633069 1655813 22744 1.4
(read/write) 87912 91536 3624 4.1
.bss 43808 47008 3200 7.3
.data 1794 1858 64 3.6
.data.rel.ro 37152 37512 360 1.0
.init_array 544 552 8 1.5
.rodata 138196 138804 608 0.4
.text 1379925 1401077 21152 1.5
chip-tool debug (read only) 7085917 7108357 22440 0.3
(read/write) 187304 190928 3624 1.9
.bss 36264 39432 3168 8.7
.data 1088 1152 64 5.9
.data.rel.ro 143968 144336 368 0.3
.init_array 600 608 8 1.3
.text 6315269 6336149 20880 0.3
chip-tool-ipv6only arm64 (read only) 7036484 7055924 19440 0.3
(read/write) 289857 293457 3600 1.2
.bss 54593 57777 3184 5.8
.data 1128 1176 48 4.3
.init_array 184 192 8 4.3
.text 6049796 6067860 18064 0.3
ota-provider-app debug (read only) 1633465 1646409 12944 0.8
.data.rel.ro 32216 32296 80 0.2
.text 1368050 1381362 13312 1.0
ota-requestor-app debug (read only) 1642177 1655121 12944 0.8
.data.rel.ro 34136 34216 80 0.2
.text 1381570 1394882 13312 1.0
tv-app debug .data 2944 2976 32 1.1
mbed lighting-app CY8CPROTO_062_4343W+release .bss 178176 181344 3168 1.8
.data 5568 5600 32 0.6
.text 1300792 1304936 4144 0.3
lock-app CY8CPROTO_062_4343W+release .bss 178056 181224 3168 1.8
.data 5552 5576 24 0.4
.text 1264896 1268976 4080 0.3
shell CY8CPROTO_062_4343W+release .bss 175332 178500 3168 1.8
.data 5368 5400 32 0.6
.text 1255536 1259616 4080 0.3
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 980539 985723 5184 0.5
bss 118544 119592 1048 0.9
rodata 115840 116328 488 0.4
text 668364 671964 3600 0.5
nrf52840dk_nrf52840+rpc (read/write) 966115 971259 5144 0.5
bss 115588 116636 1048 0.9
rodata 107312 107808 496 0.5
text 664808 668404 3596 0.5
nrf52840dongle_nrf52840 (read/write) 996623 1001759 5136 0.5
bss 119716 120764 1048 0.9
rodata 114672 115160 488 0.4
text 673756 677356 3600 0.5
nrf5340dk_nrf5340_cpuapp (read/write) 889754 894890 5136 0.6
bss 115332 116380 1048 0.9
rodata 109116 109604 488 0.4
text 584560 588156 3596 0.6
lock-app nrf52840dk_nrf52840 (read/write) 913151 918287 5136 0.6
bss 116904 117952 1048 0.9
rodata 104476 104964 488 0.5
text 614368 617964 3596 0.6
nrf5340dk_nrf5340_cpuapp (read/write) 823186 828350 5164 0.6
bss 113720 114768 1048 0.9
rodata 97684 98168 484 0.5
text 531344 534940 3596 0.7
pump-app nrf52840dk_nrf52840 (read/write) 916011 921175 5164 0.6
bss 116660 117708 1048 0.9
rodata 104992 105476 484 0.5
text 616892 620488 3596 0.6
pump-controller-app nrf52840dk_nrf52840 (read/write) 911171 916335 5164 0.6
bss 116668 117716 1048 0.9
rodata 104096 104580 484 0.5
text 612940 616540 3600 0.6
p6 light-app default (read/write) 2340320 2346440 6120 0.3
.bss 103364 106528 3164 3.1
.data 2408 2432 24 1.0
.text 1298584 1304704 6120 0.5
lock-app default (read/write) 2305728 2311848 6120 0.3
.bss 103084 106248 3164 3.1
.data 2368 2392 24 1.0
.text 1263992 1270112 6120 0.5
qpg lighting-app qpg6105+debug (read only) 570700 574384 3684 0.6
.bss 87520 88376 856 1.0
.data 1060 1088 28 2.6
.text 565380 569064 3684 0.7
lock-app qpg6105+debug (read only) 516816 520488 3672 0.7
.bss 86960 87816 856 1.0
.data 996 1024 28 2.8
.text 511496 515168 3672 0.7
telink lighting-app tlsr9518adk80d (read/write) 845134 852902 7768 0.9
bss 85568 88732 3164 3.7
text 592564 596638 4074 0.7
Increases (36 builds for cyw30739, efr32, esp32, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 9f16e9a 8ded51f change % change
cyw30739 light cyw930739m2evb_01 (read/write) 577150 582130 4980 0.9
.app_xip_area 484356 488456 4100 0.8
.bss 75540 76396 856 1.1
.data 596 620 24 4.0
lock cyw930739m2evb_01 (read/write) 535146 540130 4984 0.9
.app_xip_area 443920 448024 4104 0.9
.bss 74012 74868 856 1.2
.data 560 584 24 4.3
ota-requestor cyw930739m2evb_01 (read/write) 559890 564854 4964 0.9
.app_xip_area 459360 463444 4084 0.9
.bss 82988 83844 856 1.0
.data 504 528 24 4.8
efr32 lighting-app BRD4161A (read only) 843616 849712 6096 0.7
(read/write) 125072 126152 1080 0.9
.bss 123176 124224 1048 0.9
.data 1896 1924 28 1.5
.text 843608 849704 6096 0.7
BRD4161A+rpc (read only) 830984 837088 6104 0.7
(read/write) 141736 142808 1072 0.8
.bss 139736 140784 1048 0.7
.data 1996 2024 28 1.4
.text 830976 837080 6104 0.7
window-app BRD4161A (read only) 816164 822260 6096 0.7
(read/write) 123704 124784 1080 0.9
.bss 121852 122904 1052 0.9
.data 1852 1880 28 1.5
.text 816156 822252 6096 0.7
esp32 all-clusters-app c3devkit (read/write) 1399890 1399946 56 0.0
.dram0.bss 70344 70352 8 0.0
.flash.rodata 196376 196432 56 0.0
m5stack (read/write) 464236 464288 52 0.0
.flash.rodata 222988 223040 52 0.0
linux all-clusters-app debug (read/write) 147168 147200 32 0.0
.bss 63072 63136 64 0.1
bridge-app debug+rpc (read only) 1633069 1655813 22744 1.4
(read/write) 87912 91536 3624 4.1
.bss 43808 47008 3200 7.3
.data 1794 1858 64 3.6
.data.rel.ro 37152 37512 360 1.0
.init_array 544 552 8 1.5
.rodata 138196 138804 608 0.4
.text 1379925 1401077 21152 1.5
chip-tool debug (read only) 7085917 7108357 22440 0.3
(read/write) 187304 190928 3624 1.9
.bss 36264 39432 3168 8.7
.data 1088 1152 64 5.9
.data.rel.ro 143968 144336 368 0.3
.init_array 600 608 8 1.3
.rodata 404597 405173 576 0.1
.text 6315269 6336149 20880 0.3
chip-tool-ipv6only arm64 (read only) 7036484 7055924 19440 0.3
(read/write) 289857 293457 3600 1.2
.bss 54593 57777 3184 5.8
.data 1128 1176 48 4.3
.data.rel.ro 185152 185504 352 0.2
.got 45200 45208 8 0.0
.init_array 184 192 8 4.3
.rodata 387804 388172 368 0.1
.text 6049796 6067860 18064 0.3
door-lock-app debug .bss 49888 49920 32 0.1
lighting-app debug+rpc .bss 50840 50872 32 0.1
ota-provider-app debug (read only) 1633465 1646409 12944 0.8
(read/write) 87560 87624 64 0.1
.data.rel.ro 32216 32296 80 0.2
.text 1368050 1381362 13312 1.0
ota-requestor-app debug (read only) 1642177 1655121 12944 0.8
(read/write) 90608 90672 64 0.1
.data.rel.ro 34136 34216 80 0.2
.text 1381570 1394882 13312 1.0
shell debug (read only) 2277961 2278121 160 0.0
.text 1918530 1918690 160 0.0
tv-app debug (read/write) 318000 318064 64 0.0
.bss 237344 237376 32 0.0
.data 2944 2976 32 1.1
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2384584 2384640 56 0.0
.bss 189260 189268 8 0.0
.text 1347184 1347240 56 0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2338192 2342336 4144 0.2
.bss 178176 181344 3168 1.8
.data 5568 5600 32 0.6
.text 1300792 1304936 4144 0.3
lock-app CY8CPROTO_062_4343W+release (read/write) 2302296 2306376 4080 0.2
.bss 178056 181224 3168 1.8
.data 5552 5576 24 0.4
.text 1264896 1268976 4080 0.3
shell CY8CPROTO_062_4343W+release (read/write) 2292964 2297044 4080 0.2
.bss 175332 178500 3168 1.8
.data 5368 5400 32 0.6
.text 1255536 1259616 4080 0.3
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 980539 985723 5184 0.5
bss 118544 119592 1048 0.9
rodata 115840 116328 488 0.4
text 668364 671964 3600 0.5
nrf52840dk_nrf52840+rpc (read/write) 966115 971259 5144 0.5
bss 115588 116636 1048 0.9
rodata 107312 107808 496 0.5
text 664808 668404 3596 0.5
nrf52840dongle_nrf52840 (read/write) 996623 1001759 5136 0.5
bss 119716 120764 1048 0.9
rodata 114672 115160 488 0.4
text 673756 677356 3600 0.5
nrf5340dk_nrf5340_cpuapp (read/write) 889754 894890 5136 0.6
bss 115332 116380 1048 0.9
rodata 109116 109604 488 0.4
text 584560 588156 3596 0.6
lock-app nrf52840dk_nrf52840 (read/write) 913151 918287 5136 0.6
bss 116904 117952 1048 0.9
rodata 104476 104964 488 0.5
text 614368 617964 3596 0.6
nrf5340dk_nrf5340_cpuapp (read/write) 823186 828350 5164 0.6
bss 113720 114768 1048 0.9
rodata 97684 98168 484 0.5
text 531344 534940 3596 0.7
pump-app nrf52840dk_nrf52840 (read/write) 916011 921175 5164 0.6
bss 116660 117708 1048 0.9
rodata 104992 105476 484 0.5
text 616892 620488 3596 0.6
pump-controller-app nrf52840dk_nrf52840 (read/write) 911171 916335 5164 0.6
bss 116668 117716 1048 0.9
rodata 104096 104580 484 0.5
text 612940 616540 3600 0.6
p6 all-clusters-app default (read/write) 2445880 2445960 80 0.0
.bss 117404 117408 4 0.0
.text 1404144 1404224 80 0.0
light-app default (read/write) 2340320 2346440 6120 0.3
.bss 103364 106528 3164 3.1
.data 2408 2432 24 1.0
.text 1298584 1304704 6120 0.5
lock-app default (read/write) 2305728 2311848 6120 0.3
.bss 103084 106248 3164 3.1
.data 2368 2392 24 1.0
.text 1263992 1270112 6120 0.5
qpg lighting-app qpg6105+debug (read only) 570700 574384 3684 0.6
(read/write) 146936 146940 4 0.0
.bss 87520 88376 856 1.0
.data 1060 1088 28 2.6
.text 565380 569064 3684 0.7
lock-app qpg6105+debug (read only) 516816 520488 3672 0.7
(read/write) 146936 146940 4 0.0
.bss 86960 87816 856 1.0
.data 996 1024 28 2.8
.text 511496 515168 3672 0.7
telink lighting-app tlsr9518adk80d (read/write) 845134 852902 7768 0.9
bss 85568 88732 3164 3.7
text 592564 596638 4074 0.7
Decreases (9 builds for esp32, linux)
platform target config section 9f16e9a 8ded51f change % change
esp32 all-clusters-app c3devkit (read only) 934322 934318 -4 -0.0
.flash.text 934322 934318 -4 -0.0
m5stack (read only) 982339 982311 -28 -0.0
.flash.text 976955 976927 -28 -0.0
linux all-clusters-app debug (read only) 2301529 2300825 -704 -0.0
.data.rel.ro 77224 77176 -48 -0.1
.rodata 203813 203749 -64 -0.0
.text 1936914 1936418 -496 -0.0
door-lock-app debug (read only) 1854057 1853625 -432 -0.0
(read/write) 117824 117760 -64 -0.1
.data.rel.ro 61552 61480 -72 -0.1
.rodata 171516 171420 -96 -0.1
.text 1534642 1534450 -192 -0.0
lighting-app debug+rpc (read only) 1954785 1954353 -432 -0.0
(read/write) 122784 122720 -64 -0.1
.data 1392 1352 -40 -2.9
.data.rel.ro 65056 65016 -40 -0.1
.rodata 161265 161169 -96 -0.1
.text 1639602 1639410 -192 -0.0
ota-provider-app debug .rodata 148190 147582 -608 -0.4
ota-requestor-app debug .rodata 144463 143855 -608 -0.4
thermostat-no-ble arm64 (read only) 2087388 2087044 -344 -0.0
(read/write) 148529 148449 -80 -0.1
.data 952 944 -8 -0.8
.data.rel.ro 74248 74192 -56 -0.1
.got 4136 4128 -8 -0.2
.init_array 344 336 -8 -2.3
.rodata 130780 130724 -56 -0.0
.text 1739280 1739184 -96 -0.0
tv-app debug (read only) 2408921 2408513 -408 -0.0
.data.rel.ro 71720 71696 -24 -0.0
.rodata 191948 191876 -72 -0.0
.text 2046498 2046306 -192 -0.0
Full report (41 builds for cyw30739, efr32, esp32, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 9f16e9a 8ded51f change % change
cyw30739 light cyw930739m2evb_01 (read/write) 577150 582130 4980 0.9
.app_xip_area 484356 488456 4100 0.8
.bss 75540 76396 856 1.1
.data 596 620 24 4.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 535146 540130 4984 0.9
.app_xip_area 443920 448024 4104 0.9
.bss 74012 74868 856 1.2
.data 560 584 24 4.3
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 559890 564854 4964 0.9
.app_xip_area 459360 463444 4084 0.9
.bss 82988 83844 856 1.0
.data 504 528 24 4.8
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 843616 849712 6096 0.7
(read/write) 125072 126152 1080 0.9
.bss 123176 124224 1048 0.9
.data 1896 1924 28 1.5
.text 843608 849704 6096 0.7
BRD4161A+rpc (read only) 830984 837088 6104 0.7
(read/write) 141736 142808 1072 0.8
.bss 139736 140784 1048 0.7
.data 1996 2024 28 1.4
.text 830976 837080 6104 0.7
window-app BRD4161A (read only) 816164 822260 6096 0.7
(read/write) 123704 124784 1080 0.9
.bss 121852 122904 1052 0.9
.data 1852 1880 28 1.5
.text 816156 822252 6096 0.7
esp32 all-clusters-app c3devkit (read only) 934322 934318 -4 -0.0
(read/write) 1399890 1399946 56 0.0
.dram0.bss 70344 70352 8 0.0
.dram0.data 14268 14268 0 0.0
.flash.rodata 196376 196432 56 0.0
.flash.text 934322 934318 -4 -0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 982339 982311 -28 -0.0
(read/write) 464236 464288 52 0.0
.dram0.bss 75096 75096 0 0.0
.dram0.data 34024 34024 0 0.0
.flash.rodata 222988 223040 52 0.0
.flash.text 976955 976927 -28 -0.0
.iram0.text 123399 123399 0 0.0
linux all-clusters-app debug (read only) 2301529 2300825 -704 -0.0
(read/write) 147168 147200 32 0.0
.bss 63072 63136 64 0.1
.data 1200 1200 0 0.0
.data.rel.ro 77224 77176 -48 -0.1
.dynamic 592 592 0 0.0
.got 4128 4128 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 203813 203749 -64 -0.0
.text 1936914 1936418 -496 -0.0
bridge-app debug+rpc (read only) 1633069 1655813 22744 1.4
(read/write) 87912 91536 3624 4.1
.bss 43808 47008 3200 7.3
.data 1794 1858 64 3.6
.data.rel.ro 37152 37512 360 1.0
.dynamic 592 592 0 0.0
.got 3968 3968 0 0.0
.init 27 27 0 0.0
.init_array 544 552 8 1.5
.rodata 138196 138804 608 0.4
.text 1379925 1401077 21152 1.5
chip-tool debug (read only) 7085917 7108357 22440 0.3
(read/write) 187304 190928 3624 1.9
.bss 36264 39432 3168 8.7
.data 1088 1152 64 5.9
.data.rel.ro 143968 144336 368 0.3
.dynamic 608 608 0 0.0
.got 4760 4760 0 0.0
.init 27 27 0 0.0
.init_array 600 608 8 1.3
.rodata 404597 405173 576 0.1
.text 6315269 6336149 20880 0.3
chip-tool-ipv6only arm64 (read only) 7036484 7055924 19440 0.3
(read/write) 289857 293457 3600 1.2
.bss 54593 57777 3184 5.8
.data 1128 1176 48 4.3
.data.rel.ro 185152 185504 352 0.2
.dynamic 560 560 0 0.0
.got 45200 45208 8 0.0
.init 24 24 0 0.0
.init_array 184 192 8 4.3
.rodata 387804 388172 368 0.1
.text 6049796 6067860 18064 0.3
door-lock-app debug (read only) 1854057 1853625 -432 -0.0
(read/write) 117824 117760 -64 -0.1
.bss 49888 49920 32 0.1
.data 962 962 0 0.0
.data.rel.ro 61552 61480 -72 -0.1
.dynamic 592 592 0 0.0
.got 4104 4104 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 171516 171420 -96 -0.1
.text 1534642 1534450 -192 -0.0
lighting-app debug+rpc (read only) 1954785 1954353 -432 -0.0
(read/write) 122784 122720 -64 -0.1
.bss 50840 50872 32 0.1
.data 1392 1352 -40 -2.9
.data.rel.ro 65056 65016 -40 -0.1
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 704 704 0 0.0
.rodata 161265 161169 -96 -0.1
.text 1639602 1639410 -192 -0.0
ota-provider-app debug (read only) 1633465 1646409 12944 0.8
(read/write) 87560 87624 64 0.1
.bss 48768 48768 0 0.0
.data 1064 1064 0 0.0
.data.rel.ro 32216 32296 80 0.2
.dynamic 608 608 0 0.0
.got 4240 4240 0 0.0
.init 27 27 0 0.0
.init_array 608 608 0 0.0
.rodata 148190 147582 -608 -0.4
.text 1368050 1381362 13312 1.0
ota-requestor-app debug (read only) 1642177 1655121 12944 0.8
(read/write) 90608 90672 64 0.1
.bss 50080 50080 0 0.0
.data 1096 1096 0 0.0
.data.rel.ro 34136 34216 80 0.2
.dynamic 592 592 0 0.0
.got 4032 4032 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 144463 143855 -608 -0.4
.text 1381570 1394882 13312 1.0
shell debug (read only) 2277961 2278121 160 0.0
(read/write) 148944 148944 0 0.0
.bss 70784 70784 0 0.0
.data 768 768 0 0.0
.data.rel.ro 71712 71712 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 204562 204562 0 0.0
.text 1918530 1918690 160 0.0
thermostat-no-ble arm64 (read only) 2087388 2087044 -344 -0.0
(read/write) 148529 148449 -80 -0.1
.bss 66209 66209 0 0.0
.data 952 944 -8 -0.8
.data.rel.ro 74248 74192 -56 -0.1
.dynamic 560 560 0 0.0
.got 4136 4128 -8 -0.2
.init 24 24 0 0.0
.init_array 344 336 -8 -2.3
.rodata 130780 130724 -56 -0.0
.text 1739280 1739184 -96 -0.0
tv-app debug (read only) 2408921 2408513 -408 -0.0
(read/write) 318000 318064 64 0.0
.bss 237344 237376 32 0.0
.data 2944 2976 32 1.1
.data.rel.ro 71720 71696 -24 -0.0
.dynamic 592 592 0 0.0
.got 4520 4520 0 0.0
.init 27 27 0 0.0
.init_array 872 872 0 0.0
.rodata 191948 191876 -72 -0.0
.text 2046498 2046306 -192 -0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2384584 2384640 56 0.0
.bss 189260 189268 8 0.0
.data 5288 5288 0 0.0
.text 1347184 1347240 56 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2338192 2342336 4144 0.2
.bss 178176 181344 3168 1.8
.data 5568 5600 32 0.6
.text 1300792 1304936 4144 0.3
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2302296 2306376 4080 0.2
.bss 178056 181224 3168 1.8
.data 5552 5576 24 0.4
.text 1264896 1268976 4080 0.3
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139712 1139712 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103096 103096 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2292964 2297044 4080 0.2
.bss 175332 178500 3168 1.8
.data 5368 5400 32 0.6
.text 1255536 1259616 4080 0.3
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 980539 985723 5184 0.5
bss 118544 119592 1048 0.9
rodata 115840 116328 488 0.4
text 668364 671964 3600 0.5
nrf52840dk_nrf52840+rpc (read/write) 966115 971259 5144 0.5
bss 115588 116636 1048 0.9
rodata 107312 107808 496 0.5
text 664808 668404 3596 0.5
nrf52840dongle_nrf52840 (read/write) 996623 1001759 5136 0.5
bss 119716 120764 1048 0.9
rodata 114672 115160 488 0.4
text 673756 677356 3600 0.5
nrf5340dk_nrf5340_cpuapp (read/write) 889754 894890 5136 0.6
bss 115332 116380 1048 0.9
rodata 109116 109604 488 0.4
text 584560 588156 3596 0.6
lock-app nrf52840dk_nrf52840 (read/write) 913151 918287 5136 0.6
bss 116904 117952 1048 0.9
rodata 104476 104964 488 0.5
text 614368 617964 3596 0.6
nrf5340dk_nrf5340_cpuapp (read/write) 823186 828350 5164 0.6
bss 113720 114768 1048 0.9
rodata 97684 98168 484 0.5
text 531344 534940 3596 0.7
pigweed-app nrf52840dk_nrf52840 (read/write) 541779 541779 0 0.0
bss 52588 52588 0 0.0
rodata 50048 50048 0 0.0
text 376940 376940 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 916011 921175 5164 0.6
bss 116660 117708 1048 0.9
rodata 104992 105476 484 0.5
text 616892 620488 3596 0.6
pump-controller-app nrf52840dk_nrf52840 (read/write) 911171 916335 5164 0.6
bss 116668 117716 1048 0.9
rodata 104096 104580 484 0.5
text 612940 616540 3600 0.6
shell nrf52840dk_nrf52840 (read/write) 798395 798395 0 0.0
bss 109776 109776 0 0.0
rodata 78352 78352 0 0.0
text 533760 533760 0 0.0
p6 all-clusters-app default (read/write) 2445880 2445960 80 0.0
.bss 117404 117408 4 0.0
.data 2576 2576 0 0.0
.text 1404144 1404224 80 0.0
light-app default (read/write) 2340320 2346440 6120 0.3
.bss 103364 106528 3164 3.1
.data 2408 2432 24 1.0
.text 1298584 1304704 6120 0.5
lock-app default (read/write) 2305728 2311848 6120 0.3
.bss 103084 106248 3164 3.1
.data 2368 2392 24 1.0
.text 1263992 1270112 6120 0.5
qpg lighting-app qpg6105+debug (read only) 570700 574384 3684 0.6
(read/write) 146936 146940 4 0.0
.bss 87520 88376 856 1.0
.data 1060 1088 28 2.6
.text 565380 569064 3684 0.7
lock-app qpg6105+debug (read only) 516816 520488 3672 0.7
(read/write) 146936 146940 4 0.0
.bss 86960 87816 856 1.0
.data 996 1024 28 2.8
.text 511496 515168 3672 0.7
persistent-storage-app qpg6105+debug (read only) 107140 107140 0 0.0
(read/write) 146940 146940 0 0.0
.bss 38504 38504 0 0.0
.data 288 288 0 0.0
.text 101820 101820 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 845134 852902 7768 0.9
bss 85568 88732 3164 3.7
noinit 37160 37160 0 0.0
text 592564 596638 4074 0.7

@bzbarsky-apple
Copy link
Contributor

Just as a note, this is adding several KB or RAM use. We should probably have followup issue to reduce that...

@mlepage-google
Copy link
Contributor

We do already have issue #14450 for general Access Control performance (all aspects), @bzbarsky-apple is that sufficient or do we also want a more targeted/specific issue?

@andy31415 andy31415 added the V1.0 label Feb 2, 2022
@harimau-qirex harimau-qirex marked this pull request as ready for review February 2, 2022 19:51
@harimau-qirex
Copy link
Contributor Author

I'm currently looking into the cause of the size differences to see if it's something not already covered by #14450.

@bzbarsky-apple
Copy link
Contributor

is that sufficient or do we also want a more targeted/specific issue?

@mlepage-google I would prefer a more targeted issue, for this and the increase from #14657 (which might be the same increase?).

@mlepage-google mlepage-google mentioned this pull request Feb 3, 2022
Closed
@harimau-qirex
Copy link
Contributor Author

harimau-qirex commented Feb 3, 2022 •
edited
Loading

My investigations showed that the size increases for the apps I could check were generally due to the ACL code. It was previously removed from the build.

Edit: Specifically the increase is from references to the ExampleAccessControlDelegate implementation.

@bzbarsky-apple
Copy link
Contributor

It was previously removed from the build.

How could it have been removed from the build when it was used in the acl cluster?

@bzbarsky-apple bzbarsky-apple merged commit 62e37a2 into project-chip:master Feb 4, 2022
@harimau-qirex harimau-qirex deleted the server-owned-acl branch February 4, 2022 16:04
@harimau-qirex harimau-qirex mentioned this pull request Feb 4, 2022
Closed
@mlepage-google mlepage-google mentioned this pull request Feb 15, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mlepage-google mlepage-google mlepage-google left review comments

@tcarmelveilleux tcarmelveilleux tcarmelveilleux approved these changes

@msandstedt msandstedt msandstedt approved these changes

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@mspang mspang Awaiting requested review from mspang

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

Assignees
No one assigned
Labels
app examples fast track review - pending V1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement simple access control cluster persistence/storage
6 participants
@harimau-qirex @bzbarsky-apple @mlepage-google @tcarmelveilleux @msandstedt @andy31415