Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

esp32: Make SoftwareVersion configurable from application #14693

Merged
merged 3 commits into from
Feb 3, 2022
Merged

esp32: Make SoftwareVersion configurable from application #14693

merged 3 commits into from
Feb 3, 2022

Conversation

shubhamdp
Copy link
Contributor

@shubhamdp shubhamdp commented Feb 2, 2022 •
edited
Loading

Problem

Change overview

  • Added an config option to configure software version. This value will be read on reading basic cluster software version attribute.
  • Added a comment explaining why the MTU won't overflow

Testing

Read basic cluster software version using chip-tool

@github-actions
Copy link

github-actions bot commented Feb 2, 2022 •
edited
Loading

PR #14693: Size comparison from 63a5c52 to 2806126

Full report (34 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 63a5c52 2806126 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 577526 577526 0 0.0
.app_xip_area 484756 484756 0 0.0
.bss 75516 75516 0 0.0
.data 596 596 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 535150 535150 0 0.0
.app_xip_area 443948 443948 0 0.0
.bss 73988 73988 0 0.0
.data 560 560 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 559706 559706 0 0.0
.app_xip_area 459192 459192 0 0.0
.bss 82972 82972 0 0.0
.data 504 504 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 843824 843824 0 0.0
(read/write) 125056 125056 0 0.0
.bss 123160 123160 0 0.0
.data 1892 1892 0 0.0
.text 843816 843816 0 0.0
BRD4161A+rpc (read only) 831200 831200 0 0.0
(read/write) 141712 141712 0 0.0
.bss 139720 139720 0 0.0
.data 1992 1992 0 0.0
.text 831192 831192 0 0.0
window-app BRD4161A (read only) 816076 816076 0 0.0
(read/write) 123684 123684 0 0.0
.bss 121836 121836 0 0.0
.data 1848 1848 0 0.0
.text 816068 816068 0 0.0
esp32 all-clusters-app c3devkit (read only) 934022 934022 0 0.0
(read/write) 1401482 1401482 0 0.0
.dram0.bss 70320 70320 0 0.0
.dram0.data 14268 14268 0 0.0
.flash.rodata 198000 198000 0 0.0
.flash.text 934022 934022 0 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 982071 982071 0 0.0
(read/write) 465832 465832 0 0.0
.dram0.bss 75072 75072 0 0.0
.dram0.data 34024 34024 0 0.0
.flash.rodata 224608 224608 0 0.0
.flash.text 976687 976687 0 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 661708 661708 0 0.0
.bss 75212 75212 0 0.0
.data 1852 1852 0 0.0
.text 578844 578844 0 0.0
lock k32w061+release (read/write) 662892 662892 0 0.0
.bss 75532 75532 0 0.0
.data 1892 1892 0 0.0
.text 579668 579668 0 0.0
linux chip-tool-ipv6only arm64 (read only) 7088532 7088532 0 0.0
(read/write) 290881 290881 0 0.0
.bss 54577 54577 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 186160 186160 0 0.0
.dynamic 560 560 0 0.0
.got 45232 45232 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 390460 390460 0 0.0
.text 6097780 6097780 0 0.0
thermostat-no-ble arm64 (read only) 2086380 2086380 0 0.0
(read/write) 148865 148865 0 0.0
.bss 66177 66177 0 0.0
.data 952 952 0 0.0
.data.rel.ro 74624 74624 0 0.0
.dynamic 560 560 0 0.0
.got 4136 4136 0 0.0
.init 24 24 0 0.0
.init_array 336 336 0 0.0
.rodata 131004 131004 0 0.0
.text 1737648 1737648 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2385832 2385832 0 0.0
.bss 189236 189236 0 0.0
.data 5288 5288 0 0.0
.text 1348432 1348432 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2338640 2338640 0 0.0
.bss 178152 178152 0 0.0
.data 5568 5568 0 0.0
.text 1301240 1301240 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2302296 2302296 0 0.0
.bss 178032 178032 0 0.0
.data 5544 5544 0 0.0
.text 1264896 1264896 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139712 1139712 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103096 103096 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2292804 2292804 0 0.0
.bss 175316 175316 0 0.0
.data 5368 5368 0 0.0
.text 1255376 1255376 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 980927 980927 0 0.0
bss 118524 118524 0 0.0
rodata 116548 116548 0 0.0
text 668068 668068 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 966487 966487 0 0.0
bss 115568 115568 0 0.0
rodata 108020 108020 0 0.0
text 664508 664508 0 0.0
nrf52840dongle_nrf52840 (read/write) 996995 996995 0 0.0
bss 119696 119696 0 0.0
rodata 115380 115380 0 0.0
text 673460 673460 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 890126 890126 0 0.0
bss 115312 115312 0 0.0
rodata 109824 109824 0 0.0
text 584256 584256 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 913143 913143 0 0.0
bss 116884 116884 0 0.0
rodata 104804 104804 0 0.0
text 614068 614068 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 823210 823210 0 0.0
bss 113700 113700 0 0.0
rodata 98012 98012 0 0.0
text 531040 531040 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 541779 541779 0 0.0
bss 52588 52588 0 0.0
rodata 50048 50048 0 0.0
text 376940 376940 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 915927 915927 0 0.0
bss 116640 116640 0 0.0
rodata 105324 105324 0 0.0
text 616524 616524 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 911135 911135 0 0.0
bss 116648 116648 0 0.0
rodata 104428 104428 0 0.0
text 612576 612576 0 0.0
shell nrf52840dk_nrf52840 (read/write) 798379 798379 0 0.0
bss 109772 109772 0 0.0
rodata 78352 78352 0 0.0
text 533752 533752 0 0.0
p6 all-clusters-app default (read/write) 2446944 2446944 0 0.0
.bss 117388 117388 0 0.0
.data 2576 2576 0 0.0
.text 1405208 1405208 0 0.0
light-app default (read/write) 2340536 2340536 0 0.0
.bss 103348 103348 0 0.0
.data 2400 2400 0 0.0
.text 1298800 1298800 0 0.0
lock-app default (read/write) 2305560 2305560 0 0.0
.bss 103068 103068 0 0.0
.data 2360 2360 0 0.0
.text 1263824 1263824 0 0.0
qpg lighting-app qpg6105+debug (read only) 571104 571104 0 0.0
(read/write) 146940 146940 0 0.0
.bss 87496 87496 0 0.0
.data 1056 1056 0 0.0
.text 565784 565784 0 0.0
lock-app qpg6105+debug (read only) 516840 516840 0 0.0
(read/write) 146940 146940 0 0.0
.bss 86936 86936 0 0.0
.data 992 992 0 0.0
.text 511520 511520 0 0.0
persistent-storage-app qpg6105+debug (read only) 107140 107140 0 0.0
(read/write) 146940 146940 0 0.0
.bss 38504 38504 0 0.0
.data 288 288 0 0.0
.text 101820 101820 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 845494 845494 0 0.0
bss 85552 85552 0 0.0
noinit 37160 37160 0 0.0
text 592264 592264 0 0.0

@shubhamdp shubhamdp mentioned this pull request Feb 3, 2022
Merged
@shubhamdp
Copy link
Contributor Author

/rebase

@woody-apple woody-apple force-pushed the esp32_make_sw_version_configurable branch from 1cbbf7b to 7954083 Compare February 3, 2022 12:28
@github-actions
Copy link

github-actions bot commented Feb 3, 2022 •
edited
Loading

PR #14693: Size comparison from 2294bcc to 7954083

Full report (34 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 2294bcc 7954083 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 577390 577390 0 0.0
.app_xip_area 484884 484884 0 0.0
.bss 75252 75252 0 0.0
.data 596 596 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 535134 535134 0 0.0
.app_xip_area 444196 444196 0 0.0
.bss 73724 73724 0 0.0
.data 560 560 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 559618 559618 0 0.0
.app_xip_area 459360 459360 0 0.0
.bss 82716 82716 0 0.0
.data 504 504 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 844328 844328 0 0.0
(read/write) 124792 124792 0 0.0
.bss 122896 122896 0 0.0
.data 1892 1892 0 0.0
.text 844320 844320 0 0.0
BRD4161A+rpc (read only) 831704 831704 0 0.0
(read/write) 141448 141448 0 0.0
.bss 139456 139456 0 0.0
.data 1992 1992 0 0.0
.text 831696 831696 0 0.0
window-app BRD4161A (read only) 816404 816404 0 0.0
(read/write) 123412 123412 0 0.0
.bss 121564 121564 0 0.0
.data 1848 1848 0 0.0
.text 816396 816396 0 0.0
esp32 all-clusters-app c3devkit (read only) 934598 934598 0 0.0
(read/write) 1401002 1401002 0 0.0
.dram0.bss 70048 70048 0 0.0
.dram0.data 14268 14268 0 0.0
.flash.rodata 197792 197792 0 0.0
.flash.text 934598 934598 0 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 982723 982723 0 0.0
(read/write) 465360 465360 0 0.0
.dram0.bss 74808 74808 0 0.0
.dram0.data 34024 34024 0 0.0
.flash.rodata 224400 224400 0 0.0
.flash.text 977339 977339 0 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 661620 661620 0 0.0
.bss 74948 74948 0 0.0
.data 1852 1852 0 0.0
.text 579020 579020 0 0.0
lock k32w061+release (read/write) 662880 662880 0 0.0
.bss 75268 75268 0 0.0
.data 1892 1892 0 0.0
.text 579920 579920 0 0.0
linux chip-tool-ipv6only arm64 (read only) 7120532 7120532 0 0.0
(read/write) 284545 284545 0 0.0
.bss 47585 47585 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 186712 186712 0 0.0
.dynamic 560 560 0 0.0
.got 45336 45336 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 391564 391564 0 0.0
.text 6127236 6127236 0 0.0
thermostat-no-ble arm64 (read only) 2091484 2091484 0 0.0
(read/write) 140401 140401 0 0.0
.bss 57713 57713 0 0.0
.data 952 952 0 0.0
.data.rel.ro 74624 74624 0 0.0
.dynamic 560 560 0 0.0
.got 4136 4136 0 0.0
.init 24 24 0 0.0
.init_array 336 336 0 0.0
.rodata 130764 130764 0 0.0
.text 1743008 1743008 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2386056 2386056 0 0.0
.bss 188964 188964 0 0.0
.data 5288 5288 0 0.0
.text 1348656 1348656 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2338744 2338744 0 0.0
.bss 177888 177888 0 0.0
.data 5568 5568 0 0.0
.text 1301344 1301344 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2302600 2302600 0 0.0
.bss 177776 177776 0 0.0
.data 5544 5544 0 0.0
.text 1265200 1265200 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139712 1139712 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103096 103096 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2292980 2292980 0 0.0
.bss 175052 175052 0 0.0
.data 5368 5368 0 0.0
.text 1255552 1255552 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 980975 980975 0 0.0
bss 118260 118260 0 0.0
rodata 116324 116324 0 0.0
text 668596 668596 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 966535 966535 0 0.0
bss 115304 115304 0 0.0
rodata 107796 107796 0 0.0
text 665040 665040 0 0.0
nrf52840dongle_nrf52840 (read/write) 997039 997039 0 0.0
bss 119432 119432 0 0.0
rodata 115168 115168 0 0.0
text 673972 673972 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 890190 890190 0 0.0
bss 115044 115044 0 0.0
rodata 109616 109616 0 0.0
text 584788 584788 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 913319 913319 0 0.0
bss 116620 116620 0 0.0
rodata 104596 104596 0 0.0
text 614704 614704 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 823350 823350 0 0.0
bss 113440 113440 0 0.0
rodata 97800 97800 0 0.0
text 531672 531672 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 541779 541779 0 0.0
bss 52588 52588 0 0.0
rodata 50048 50048 0 0.0
text 376940 376940 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 915987 915987 0 0.0
bss 116380 116380 0 0.0
rodata 105112 105112 0 0.0
text 617048 617048 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 911195 911195 0 0.0
bss 116388 116388 0 0.0
rodata 104216 104216 0 0.0
text 613104 613104 0 0.0
shell nrf52840dk_nrf52840 (read/write) 798875 798875 0 0.0
bss 109776 109776 0 0.0
rodata 78352 78352 0 0.0
text 534248 534248 0 0.0
p6 all-clusters-app default (read/write) 2447224 2447224 0 0.0
.bss 117116 117116 0 0.0
.data 2576 2576 0 0.0
.text 1405488 1405488 0 0.0
light-app default (read/write) 2340864 2340864 0 0.0
.bss 103084 103084 0 0.0
.data 2400 2400 0 0.0
.text 1299128 1299128 0 0.0
lock-app default (read/write) 2305896 2305896 0 0.0
.bss 102804 102804 0 0.0
.data 2360 2360 0 0.0
.text 1264160 1264160 0 0.0
qpg lighting-app qpg6105+debug (read only) 571244 571244 0 0.0
(read/write) 146940 146940 0 0.0
.bss 87232 87232 0 0.0
.data 1056 1056 0 0.0
.text 565924 565924 0 0.0
lock-app qpg6105+debug (read only) 517084 517084 0 0.0
(read/write) 146940 146940 0 0.0
.bss 86680 86680 0 0.0
.data 992 992 0 0.0
.text 511764 511764 0 0.0
persistent-storage-app qpg6105+debug (read only) 107140 107140 0 0.0
(read/write) 146940 146940 0 0.0
.bss 38504 38504 0 0.0
.data 288 288 0 0.0
.text 101820 101820 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 845594 845594 0 0.0
bss 85288 85288 0 0.0
noinit 37160 37160 0 0.0
text 592830 592830 0 0.0

@andy31415 andy31415 merged commit ed29ecd into project-chip:master Feb 3, 2022
@shubhamdp shubhamdp deleted the esp32_make_sw_version_configurable branch February 3, 2022 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhrishi dhrishi dhrishi approved these changes

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@harsha-rajendran harsha-rajendran harsha-rajendran approved these changes

@msandstedt msandstedt msandstedt approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@hawk248 hawk248 Awaiting requested review from hawk248

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@mspang mspang Awaiting requested review from mspang

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
config esp32 examples platform review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BLEManagerImpl may have MTU overflow its storage
6 participants
@shubhamdp @msandstedt @dhrishi @harsha-rajendran @bzbarsky-apple @andy31415