-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DataVersionFilter for read/subscribe #14711
Merged
yunhanw-google
merged 4 commits into
project-chip:master
from
yunhanw-google:feature/add_data_version_support
Feb 11, 2022
Merged
Add DataVersionFilter for read/subscribe #14711
yunhanw-google
merged 4 commits into
project-chip:master
from
yunhanw-google:feature/add_data_version_support
Feb 11, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
balducci-apple,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
hawk248,
holbrookt,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kpschoedel,
LuDuda,
lzgrablic02,
mlepage-google,
mrjerryjohns and
msandstedt
February 2, 2022 19:30
yunhanw-google
force-pushed
the
feature/add_data_version_support
branch
2 times, most recently
from
February 9, 2022 06:42
f336442
to
a73d83a
Compare
This was referenced Feb 10, 2022
bzbarsky-apple
approved these changes
Feb 11, 2022
yufengwangca
approved these changes
Feb 11, 2022
yunhanw-google
force-pushed
the
feature/add_data_version_support
branch
from
February 11, 2022 03:55
3aafcf6
to
64da74f
Compare
PR #14711: Size comparison from 24271c7 to f9775de Increases above 0.2%:
Increases (10 builds for k32w, linux, p6, qpg, telink)
Full report (11 builds for k32w, linux, p6, qpg, telink)
|
yunhanw-google
force-pushed
the
feature/add_data_version_support
branch
from
February 11, 2022 04:46
f9775de
to
d2a455f
Compare
PR #14711: Size comparison from 6380d38 to d2a455f Increases above 0.2%:
Increases (7 builds for k32w, linux, qpg, telink)
Full report (8 builds for k32w, linux, qpg, telink)
|
yunhanw-google
force-pushed
the
feature/add_data_version_support
branch
from
February 11, 2022 05:12
d2a455f
to
0ceb23f
Compare
PR #14711: Size comparison from 6380d38 to 0ceb23f Increases above 0.2%:
Increases (10 builds for k32w, linux, p6, qpg, telink)
Full report (11 builds for k32w, linux, p6, qpg, telink)
|
yunhanw-google
force-pushed
the
feature/add_data_version_support
branch
from
February 11, 2022 06:03
318c9ca
to
ea224cd
Compare
PR #14711: Size comparison from 681e9b9 to ea224cd Increases above 0.2%:
Increases (19 builds for k32w, linux, p6, qpg, telink)
Full report (20 builds for k32w, linux, p6, qpg, telink)
|
PR #14711: Size comparison from 681e9b9 to fd8f90c Increases above 0.2%:
Increases (39 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Decreases (3 builds for cyw30739)
Full report (43 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
This was referenced Feb 12, 2022
jamesluo11
pushed a commit
to jamesluo11/connectedhomeip
that referenced
this pull request
Apr 26, 2022
* Add DataVersionFilter support for read/subscribe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
IM read/subscribe's request should be able to specify the cluster version via DataVersionFilters, in server side, if the DataVersion field of a matching DataVersionFilterIB does not match the data version of the cluster instance in the path, the corresponding attributeDataIB would be generated.
Change overview
--Implement DataVersionFilter in ReadClient, process it in ReadHandler and report engine where the filters would be allocated from clusterInfo pool and then it would filter out the attribute change with version equal to the related one in DataVersionFilter
Testing
Add python integration test to check the version change.
Add unit test to test read and subscribe with data version filter, observe the eventfilter change for subscribe.
Manually run chip-tool to read/read_with_version/write/read_with_version