Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make WriteHandler an ExchangeDelegate #14821

Merged
merged 4 commits into from
Feb 8, 2022
Merged

Make WriteHandler an ExchangeDelegate #14821

merged 4 commits into from
Feb 8, 2022

Conversation

mrjerryjohns
Copy link
Contributor

@mrjerryjohns mrjerryjohns commented Feb 5, 2022 •
edited
Loading

This is a meant to setup the WriteHandler's messaging processing
pathways correctly to permit chunking to get implemented correctly
(which will utilize this feature).

Also fixed some logic with the ChipError macros for composing an IM status code.

@github-actions
Copy link

github-actions bot commented Feb 5, 2022 •
edited
Loading

PR #14821: Size comparison from a932c01 to 19c5ec0

Increases (30 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section a932c01 19c5ec0 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 587670 587762 92 0.0
.app_xip_area 494404 494496 92 0.0
lock cyw930739m2evb_01 (read/write) 545586 545678 92 0.0
.app_xip_area 453880 453972 92 0.0
ota-requestor cyw930739m2evb_01 (read/write) 570010 570102 92 0.0
.app_xip_area 468984 469076 92 0.0
efr32 lighting-app BRD4161A (read only) 857496 857616 120 0.0
.text 857488 857608 120 0.0
BRD4161A+rpc (read only) 844848 844984 136 0.0
.text 844840 844976 136 0.0
window-app BRD4161A (read only) 829732 829852 120 0.0
.text 829724 829844 120 0.0
esp32 all-clusters-app c3devkit (read only) 936986 937050 64 0.0
(read/write) 1401242 1401298 56 0.0
.flash.rodata 198000 198056 56 0.0
.flash.text 936986 937050 64 0.0
m5stack (read only) 984975 985031 56 0.0
(read/write) 465592 465648 56 0.0
.flash.rodata 224608 224664 56 0.0
.flash.text 979591 979647 56 0.0
k32w light k32w061+release (read/write) 672212 672312 100 0.0
.text 588840 588940 100 0.0
lock k32w061+release (read/write) 673744 673844 100 0.0
.text 590004 590104 100 0.0
linux chip-tool-ipv6only arm64 (read only) 7238916 7239284 368 0.0
(read/write) 287921 287953 32 0.0
.data.rel.ro 186528 186560 32 0.0
.rodata 392812 392860 48 0.0
.text 6241268 6241492 224 0.0
thermostat-no-ble arm64 (read only) 2127300 2127620 320 0.0
(read/write) 140561 140593 32 0.0
.data.rel.ro 74872 74904 32 0.0
.rodata 131412 131444 32 0.0
.text 1777936 1778128 192 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2389192 2389312 120 0.0
.text 1351792 1351912 120 0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2348448 2348568 120 0.0
.text 1311048 1311168 120 0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2312368 2312488 120 0.0
.text 1274968 1275088 120 0.0
shell CY8CPROTO_062_4343W+release (read/write) 2302708 2302828 120 0.0
.text 1265280 1265400 120 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 998095 998199 104 0.0
rodata 117308 117364 56 0.0
text 681464 681508 44 0.0
nrf52840dk_nrf52840+rpc (read/write) 969451 969551 100 0.0
rodata 108696 108748 52 0.0
text 666020 666068 48 0.0
nrf52840dongle_nrf52840 (read/write) 1014783 1014887 104 0.0
rodata 116144 116200 56 0.0
text 686956 687004 48 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 904786 904890 104 0.0
rodata 110564 110620 56 0.1
text 596472 596520 48 0.0
lock-app nrf52840dk_nrf52840 (read/write) 930235 930339 104 0.0
rodata 105656 105712 56 0.1
text 627324 627368 44 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 837762 837846 84 0.0
rodata 98828 98880 52 0.1
text 543108 543152 44 0.0
pump-app nrf52840dk_nrf52840 (read/write) 932867 932967 100 0.0
rodata 106128 106180 52 0.0
text 629660 629708 48 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 927807 927907 100 0.0
rodata 105132 105184 52 0.0
text 625600 625648 48 0.0
p6 all-clusters-app default (read/write) 2450304 2450440 136 0.0
.text 1408568 1408704 136 0.0
light-app default (read/write) 2353736 2353856 120 0.0
.text 1312000 1312120 120 0.0
lock-app default (read/write) 2318944 2319080 136 0.0
.text 1277208 1277344 136 0.0
qpg lighting-app qpg6105+debug (read only) 580468 580500 32 0.0
.text 575148 575180 32 0.0
lock-app qpg6105+debug (read only) 526548 526580 32 0.0
.text 521228 521260 32 0.0
telink lighting-app tlsr9518adk80d (read/write) 859102 859214 112 0.0
text 602176 602232 56 0.0
Full report (34 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section a932c01 19c5ec0 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 587670 587762 92 0.0
.app_xip_area 494404 494496 92 0.0
.bss 75988 75988 0 0.0
.data 624 624 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 545586 545678 92 0.0
.app_xip_area 453880 453972 92 0.0
.bss 74460 74460 0 0.0
.data 588 588 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 570010 570102 92 0.0
.app_xip_area 468984 469076 92 0.0
.bss 83452 83452 0 0.0
.data 532 532 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 857496 857616 120 0.0
(read/write) 125744 125744 0 0.0
.bss 123816 123816 0 0.0
.data 1924 1924 0 0.0
.text 857488 857608 120 0.0
BRD4161A+rpc (read only) 844848 844984 136 0.0
(read/write) 142400 142400 0 0.0
.bss 140376 140376 0 0.0
.data 2024 2024 0 0.0
.text 844840 844976 136 0.0
window-app BRD4161A (read only) 829732 829852 120 0.0
(read/write) 124384 124384 0 0.0
.bss 122504 122504 0 0.0
.data 1880 1880 0 0.0
.text 829724 829844 120 0.0
esp32 all-clusters-app c3devkit (read only) 936986 937050 64 0.0
(read/write) 1401242 1401298 56 0.0
.dram0.bss 70064 70064 0 0.0
.dram0.data 14276 14276 0 0.0
.flash.rodata 198000 198056 56 0.0
.flash.text 936986 937050 64 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 984975 985031 56 0.0
(read/write) 465592 465648 56 0.0
.dram0.bss 74816 74816 0 0.0
.dram0.data 34040 34040 0 0.0
.flash.rodata 224608 224664 56 0.0
.flash.text 979591 979647 56 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 672212 672312 100 0.0
.bss 75688 75688 0 0.0
.data 1884 1884 0 0.0
.text 588840 588940 100 0.0
lock k32w061+release (read/write) 673744 673844 100 0.0
.bss 76016 76016 0 0.0
.data 1924 1924 0 0.0
.text 590004 590104 100 0.0
linux chip-tool-ipv6only arm64 (read only) 7238916 7239284 368 0.0
(read/write) 287921 287953 32 0.0
.bss 50641 50641 0 0.0
.data 1176 1176 0 0.0
.data.rel.ro 186528 186560 32 0.0
.dynamic 560 560 0 0.0
.got 45784 45784 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 392812 392860 48 0.0
.text 6241268 6241492 224 0.0
thermostat-no-ble arm64 (read only) 2127300 2127620 320 0.0
(read/write) 140561 140593 32 0.0
.bss 57601 57601 0 0.0
.data 968 968 0 0.0
.data.rel.ro 74872 74904 32 0.0
.dynamic 560 560 0 0.0
.got 4152 4152 0 0.0
.init 24 24 0 0.0
.init_array 328 328 0 0.0
.rodata 131412 131444 32 0.0
.text 1777936 1778128 192 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2389192 2389312 120 0.0
.bss 188972 188972 0 0.0
.data 5296 5296 0 0.0
.text 1351792 1351912 120 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2348448 2348568 120 0.0
.bss 180936 180936 0 0.0
.data 5600 5600 0 0.0
.text 1311048 1311168 120 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2312368 2312488 120 0.0
.bss 180824 180824 0 0.0
.data 5584 5584 0 0.0
.text 1274968 1275088 120 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139712 1139712 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103096 103096 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2302708 2302828 120 0.0
.bss 178100 178100 0 0.0
.data 5400 5400 0 0.0
.text 1265280 1265400 120 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 998095 998199 104 0.0
bss 120404 120404 0 0.0
rodata 117308 117364 56 0.0
text 681464 681508 44 0.0
nrf52840dk_nrf52840+rpc (read/write) 969451 969551 100 0.0
bss 116260 116260 0 0.0
rodata 108696 108748 52 0.0
text 666020 666068 48 0.0
nrf52840dongle_nrf52840 (read/write) 1014783 1014887 104 0.0
bss 121768 121768 0 0.0
rodata 116144 116200 56 0.0
text 686956 687004 48 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 904786 904890 104 0.0
bss 116964 116964 0 0.0
rodata 110564 110620 56 0.1
text 596472 596520 48 0.0
lock-app nrf52840dk_nrf52840 (read/write) 930235 930339 104 0.0
bss 118740 118740 0 0.0
rodata 105656 105712 56 0.1
text 627324 627368 44 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 837762 837846 84 0.0
bss 115336 115336 0 0.0
rodata 98828 98880 52 0.1
text 543108 543152 44 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 541779 541779 0 0.0
bss 52588 52588 0 0.0
rodata 50048 50048 0 0.0
text 376940 376940 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 932867 932967 100 0.0
bss 118492 118492 0 0.0
rodata 106128 106180 52 0.0
text 629660 629708 48 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 927807 927907 100 0.0
bss 118496 118496 0 0.0
rodata 105132 105184 52 0.0
text 625600 625648 48 0.0
shell nrf52840dk_nrf52840 (read/write) 802811 802811 0 0.0
bss 110968 110968 0 0.0
rodata 78480 78480 0 0.0
text 535792 535792 0 0.0
p6 all-clusters-app default (read/write) 2450304 2450440 136 0.0
.bss 117128 117128 0 0.0
.data 2584 2584 0 0.0
.text 1408568 1408704 136 0.0
light-app default (read/write) 2353736 2353856 120 0.0
.bss 106128 106128 0 0.0
.data 2432 2432 0 0.0
.text 1312000 1312120 120 0.0
lock-app default (read/write) 2318944 2319080 136 0.0
.bss 105848 105848 0 0.0
.data 2392 2392 0 0.0
.text 1277208 1277344 136 0.0
qpg lighting-app qpg6105+debug (read only) 580468 580500 32 0.0
(read/write) 146940 146940 0 0.0
.bss 87976 87976 0 0.0
.data 1088 1088 0 0.0
.text 575148 575180 32 0.0
lock-app qpg6105+debug (read only) 526548 526580 32 0.0
(read/write) 146940 146940 0 0.0
.bss 87424 87424 0 0.0
.data 1024 1024 0 0.0
.text 521228 521260 32 0.0
persistent-storage-app qpg6105+debug (read only) 107140 107140 0 0.0
(read/write) 146940 146940 0 0.0
.bss 38504 38504 0 0.0
.data 288 288 0 0.0
.text 101820 101820 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 859102 859214 112 0.0
bss 88332 88332 0 0.0
noinit 37160 37160 0 0.0
text 602176 602232 56 0.0

@mrjerryjohns mrjerryjohns force-pushed the write-handler-ec-delegate branch from 19c5ec0 to df514db Compare February 6, 2022 06:49
@github-actions
Copy link

github-actions bot commented Feb 6, 2022 •
edited
Loading

PR #14821: Size comparison from a932c01 to df514db

Increases (22 builds for cyw30739, efr32, esp32, k32w, linux, mbed, p6, qpg, telink)
platform target config section a932c01 df514db change % change
cyw30739 light cyw930739m2evb_01 (read/write) 587670 587762 92 0.0
.app_xip_area 494404 494496 92 0.0
lock cyw930739m2evb_01 (read/write) 545586 545678 92 0.0
.app_xip_area 453880 453972 92 0.0
ota-requestor cyw930739m2evb_01 (read/write) 570010 570102 92 0.0
.app_xip_area 468984 469076 92 0.0
efr32 lighting-app BRD4161A (read only) 857496 857616 120 0.0
.text 857488 857608 120 0.0
BRD4161A+rpc (read only) 844848 844984 136 0.0
.text 844840 844976 136 0.0
window-app BRD4161A (read only) 829732 829852 120 0.0
.text 829724 829844 120 0.0
esp32 all-clusters-app c3devkit (read only) 936986 937050 64 0.0
(read/write) 1401242 1401298 56 0.0
.flash.rodata 198000 198056 56 0.0
.flash.text 936986 937050 64 0.0
m5stack (read only) 984975 985031 56 0.0
(read/write) 465592 465648 56 0.0
.flash.rodata 224608 224664 56 0.0
.flash.text 979591 979647 56 0.0
k32w light k32w061+release (read/write) 672212 672312 100 0.0
.text 588840 588940 100 0.0
lock k32w061+release (read/write) 673744 673844 100 0.0
.text 590004 590104 100 0.0
linux chip-tool-ipv6only arm64 (read only) 7238916 7239300 384 0.0
(read/write) 287921 287953 32 0.0
.data.rel.ro 186528 186560 32 0.0
.rodata 392812 392860 48 0.0
.text 6241268 6241508 240 0.0
thermostat-no-ble arm64 (read only) 2127300 2127636 336 0.0
(read/write) 140561 140593 32 0.0
.data.rel.ro 74872 74904 32 0.0
.rodata 131412 131444 32 0.0
.text 1777936 1778144 208 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2389192 2389312 120 0.0
.text 1351792 1351912 120 0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2348448 2348568 120 0.0
.text 1311048 1311168 120 0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2312368 2312488 120 0.0
.text 1274968 1275088 120 0.0
shell CY8CPROTO_062_4343W+release (read/write) 2302708 2302828 120 0.0
.text 1265280 1265400 120 0.0
p6 all-clusters-app default (read/write) 2450304 2450440 136 0.0
.text 1408568 1408704 136 0.0
light-app default (read/write) 2353736 2353856 120 0.0
.text 1312000 1312120 120 0.0
lock-app default (read/write) 2318944 2319080 136 0.0
.text 1277208 1277344 136 0.0
qpg lighting-app qpg6105+debug (read only) 580468 580500 32 0.0
.text 575148 575180 32 0.0
lock-app qpg6105+debug (read only) 526548 526580 32 0.0
.text 521228 521260 32 0.0
telink lighting-app tlsr9518adk80d (read/write) 859102 859222 120 0.0
text 602176 602236 60 0.0
Full report (24 builds for cyw30739, efr32, esp32, k32w, linux, mbed, p6, qpg, telink)
platform target config section a932c01 df514db change % change
cyw30739 light cyw930739m2evb_01 (read/write) 587670 587762 92 0.0
.app_xip_area 494404 494496 92 0.0
.bss 75988 75988 0 0.0
.data 624 624 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 545586 545678 92 0.0
.app_xip_area 453880 453972 92 0.0
.bss 74460 74460 0 0.0
.data 588 588 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 570010 570102 92 0.0
.app_xip_area 468984 469076 92 0.0
.bss 83452 83452 0 0.0
.data 532 532 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 857496 857616 120 0.0
(read/write) 125744 125744 0 0.0
.bss 123816 123816 0 0.0
.data 1924 1924 0 0.0
.text 857488 857608 120 0.0
BRD4161A+rpc (read only) 844848 844984 136 0.0
(read/write) 142400 142400 0 0.0
.bss 140376 140376 0 0.0
.data 2024 2024 0 0.0
.text 844840 844976 136 0.0
window-app BRD4161A (read only) 829732 829852 120 0.0
(read/write) 124384 124384 0 0.0
.bss 122504 122504 0 0.0
.data 1880 1880 0 0.0
.text 829724 829844 120 0.0
esp32 all-clusters-app c3devkit (read only) 936986 937050 64 0.0
(read/write) 1401242 1401298 56 0.0
.dram0.bss 70064 70064 0 0.0
.dram0.data 14276 14276 0 0.0
.flash.rodata 198000 198056 56 0.0
.flash.text 936986 937050 64 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 984975 985031 56 0.0
(read/write) 465592 465648 56 0.0
.dram0.bss 74816 74816 0 0.0
.dram0.data 34040 34040 0 0.0
.flash.rodata 224608 224664 56 0.0
.flash.text 979591 979647 56 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 672212 672312 100 0.0
.bss 75688 75688 0 0.0
.data 1884 1884 0 0.0
.text 588840 588940 100 0.0
lock k32w061+release (read/write) 673744 673844 100 0.0
.bss 76016 76016 0 0.0
.data 1924 1924 0 0.0
.text 590004 590104 100 0.0
linux chip-tool-ipv6only arm64 (read only) 7238916 7239300 384 0.0
(read/write) 287921 287953 32 0.0
.bss 50641 50641 0 0.0
.data 1176 1176 0 0.0
.data.rel.ro 186528 186560 32 0.0
.dynamic 560 560 0 0.0
.got 45784 45784 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 392812 392860 48 0.0
.text 6241268 6241508 240 0.0
thermostat-no-ble arm64 (read only) 2127300 2127636 336 0.0
(read/write) 140561 140593 32 0.0
.bss 57601 57601 0 0.0
.data 968 968 0 0.0
.data.rel.ro 74872 74904 32 0.0
.dynamic 560 560 0 0.0
.got 4152 4152 0 0.0
.init 24 24 0 0.0
.init_array 328 328 0 0.0
.rodata 131412 131444 32 0.0
.text 1777936 1778144 208 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2389192 2389312 120 0.0
.bss 188972 188972 0 0.0
.data 5296 5296 0 0.0
.text 1351792 1351912 120 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2348448 2348568 120 0.0
.bss 180936 180936 0 0.0
.data 5600 5600 0 0.0
.text 1311048 1311168 120 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2312368 2312488 120 0.0
.bss 180824 180824 0 0.0
.data 5584 5584 0 0.0
.text 1274968 1275088 120 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139712 1139712 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103096 103096 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2302708 2302828 120 0.0
.bss 178100 178100 0 0.0
.data 5400 5400 0 0.0
.text 1265280 1265400 120 0.0
p6 all-clusters-app default (read/write) 2450304 2450440 136 0.0
.bss 117128 117128 0 0.0
.data 2584 2584 0 0.0
.text 1408568 1408704 136 0.0
light-app default (read/write) 2353736 2353856 120 0.0
.bss 106128 106128 0 0.0
.data 2432 2432 0 0.0
.text 1312000 1312120 120 0.0
lock-app default (read/write) 2318944 2319080 136 0.0
.bss 105848 105848 0 0.0
.data 2392 2392 0 0.0
.text 1277208 1277344 136 0.0
qpg lighting-app qpg6105+debug (read only) 580468 580500 32 0.0
(read/write) 146940 146940 0 0.0
.bss 87976 87976 0 0.0
.data 1088 1088 0 0.0
.text 575148 575180 32 0.0
lock-app qpg6105+debug (read only) 526548 526580 32 0.0
(read/write) 146940 146940 0 0.0
.bss 87424 87424 0 0.0
.data 1024 1024 0 0.0
.text 521228 521260 32 0.0
persistent-storage-app qpg6105+debug (read only) 107140 107140 0 0.0
(read/write) 146940 146940 0 0.0
.bss 38504 38504 0 0.0
.data 288 288 0 0.0
.text 101820 101820 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 859102 859222 120 0.0
bss 88332 88332 0 0.0
noinit 37160 37160 0 0.0
text 602176 602236 60 0.0

@mrjerryjohns mrjerryjohns mentioned this pull request Feb 6, 2022
Merged
@mrjerryjohns mrjerryjohns force-pushed the write-handler-ec-delegate branch 2 times, most recently from db96886 to fb7646d Compare February 6, 2022 23:43
@github-actions
Copy link

github-actions bot commented Feb 7, 2022 •
edited
Loading

PR #14821: Size comparison from 0f7be8b to fb7646d

Increases (16 builds for cyw30739, efr32, k32w, linux, p6, qpg, telink)
platform target config section 0f7be8b fb7646d change % change
cyw30739 light cyw930739m2evb_01 (read/write) 587670 587762 92 0.0
.app_xip_area 494404 494496 92 0.0
lock cyw930739m2evb_01 (read/write) 545586 545678 92 0.0
.app_xip_area 453880 453972 92 0.0
ota-requestor cyw930739m2evb_01 (read/write) 570010 570102 92 0.0
.app_xip_area 468984 469076 92 0.0
efr32 lighting-app BRD4161A (read only) 857496 857616 120 0.0
.text 857488 857608 120 0.0
BRD4161A+rpc (read only) 844848 844984 136 0.0
.text 844840 844976 136 0.0
window-app BRD4161A (read only) 829732 829852 120 0.0
.text 829724 829844 120 0.0
k32w light k32w061+release (read/write) 672212 672312 100 0.0
.text 588840 588940 100 0.0
lock k32w061+release (read/write) 673744 673844 100 0.0
.text 590004 590104 100 0.0
linux chip-tool-ipv6only arm64 (read only) 7238916 7239348 432 0.0
(read/write) 287921 287985 64 0.0
.bss 50641 50673 32 0.1
.data.rel.ro 186528 186560 32 0.0
.rodata 392812 392860 48 0.0
.text 6241268 6241556 288 0.0
thermostat-no-ble arm64 (read only) 2127300 2127684 384 0.0
(read/write) 140561 140625 64 0.0
.bss 57601 57633 32 0.1
.data.rel.ro 74872 74904 32 0.0
.rodata 131412 131444 32 0.0
.text 1777936 1778192 256 0.0
p6 all-clusters-app default (read/write) 2450304 2450440 136 0.0
.text 1408568 1408704 136 0.0
light-app default (read/write) 2353736 2353856 120 0.0
.text 1312000 1312120 120 0.0
lock-app default (read/write) 2318944 2319080 136 0.0
.text 1277208 1277344 136 0.0
qpg lighting-app qpg6105+debug (read only) 580468 580500 32 0.0
.text 575148 575180 32 0.0
lock-app qpg6105+debug (read only) 526548 526580 32 0.0
.text 521228 521260 32 0.0
telink lighting-app tlsr9518adk80d (read/write) 859102 859222 120 0.0
text 602176 602236 60 0.0
Full report (17 builds for cyw30739, efr32, k32w, linux, p6, qpg, telink)
platform target config section 0f7be8b fb7646d change % change
cyw30739 light cyw930739m2evb_01 (read/write) 587670 587762 92 0.0
.app_xip_area 494404 494496 92 0.0
.bss 75988 75988 0 0.0
.data 624 624 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 545586 545678 92 0.0
.app_xip_area 453880 453972 92 0.0
.bss 74460 74460 0 0.0
.data 588 588 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 570010 570102 92 0.0
.app_xip_area 468984 469076 92 0.0
.bss 83452 83452 0 0.0
.data 532 532 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 857496 857616 120 0.0
(read/write) 125744 125744 0 0.0
.bss 123816 123816 0 0.0
.data 1924 1924 0 0.0
.text 857488 857608 120 0.0
BRD4161A+rpc (read only) 844848 844984 136 0.0
(read/write) 142400 142400 0 0.0
.bss 140376 140376 0 0.0
.data 2024 2024 0 0.0
.text 844840 844976 136 0.0
window-app BRD4161A (read only) 829732 829852 120 0.0
(read/write) 124384 124384 0 0.0
.bss 122504 122504 0 0.0
.data 1880 1880 0 0.0
.text 829724 829844 120 0.0
k32w light k32w061+release (read/write) 672212 672312 100 0.0
.bss 75688 75688 0 0.0
.data 1884 1884 0 0.0
.text 588840 588940 100 0.0
lock k32w061+release (read/write) 673744 673844 100 0.0
.bss 76016 76016 0 0.0
.data 1924 1924 0 0.0
.text 590004 590104 100 0.0
linux chip-tool-ipv6only arm64 (read only) 7238916 7239348 432 0.0
(read/write) 287921 287985 64 0.0
.bss 50641 50673 32 0.1
.data 1176 1176 0 0.0
.data.rel.ro 186528 186560 32 0.0
.dynamic 560 560 0 0.0
.got 45784 45784 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 392812 392860 48 0.0
.text 6241268 6241556 288 0.0
thermostat-no-ble arm64 (read only) 2127300 2127684 384 0.0
(read/write) 140561 140625 64 0.0
.bss 57601 57633 32 0.1
.data 968 968 0 0.0
.data.rel.ro 74872 74904 32 0.0
.dynamic 560 560 0 0.0
.got 4152 4152 0 0.0
.init 24 24 0 0.0
.init_array 328 328 0 0.0
.rodata 131412 131444 32 0.0
.text 1777936 1778192 256 0.0
p6 all-clusters-app default (read/write) 2450304 2450440 136 0.0
.bss 117128 117128 0 0.0
.data 2584 2584 0 0.0
.text 1408568 1408704 136 0.0
light-app default (read/write) 2353736 2353856 120 0.0
.bss 106128 106128 0 0.0
.data 2432 2432 0 0.0
.text 1312000 1312120 120 0.0
lock-app default (read/write) 2318944 2319080 136 0.0
.bss 105848 105848 0 0.0
.data 2392 2392 0 0.0
.text 1277208 1277344 136 0.0
qpg lighting-app qpg6105+debug (read only) 580468 580500 32 0.0
(read/write) 146940 146940 0 0.0
.bss 87976 87976 0 0.0
.data 1088 1088 0 0.0
.text 575148 575180 32 0.0
lock-app qpg6105+debug (read only) 526548 526580 32 0.0
(read/write) 146940 146940 0 0.0
.bss 87424 87424 0 0.0
.data 1024 1024 0 0.0
.text 521228 521260 32 0.0
persistent-storage-app qpg6105+debug (read only) 107140 107140 0 0.0
(read/write) 146940 146940 0 0.0
.bss 38504 38504 0 0.0
.data 288 288 0 0.0
.text 101820 101820 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 859102 859222 120 0.0
bss 88332 88332 0 0.0
noinit 37160 37160 0 0.0
text 602176 602236 60 0.0

bzbarsky-apple
bzbarsky-apple approved these changes Feb 7, 2022
View reviewed changes
Copy link
Contributor

@bzbarsky-apple bzbarsky-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for doing this!

src/app/tests/TestWriteInteraction.cpp Outdated Show resolved Hide resolved
src/lib/core/CHIPError.h Outdated Show resolved Hide resolved
@woody-apple
Copy link
Contributor

/rebase

@bzbarsky-apple bzbarsky-apple force-pushed the write-handler-ec-delegate branch from 5b78da3 to 0f5f595 Compare February 8, 2022 04:39
@github-actions
Copy link

github-actions bot commented Feb 8, 2022 •
edited
Loading

PR #14821: Size comparison from 97cf4ff to 0f5f595

Increases (30 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 97cf4ff 0f5f595 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 594398 594490 92 0.0
.app_xip_area 500252 500344 92 0.0
lock cyw930739m2evb_01 (read/write) 552298 552390 92 0.0
.app_xip_area 459712 459804 92 0.0
ota-requestor cyw930739m2evb_01 (read/write) 576306 576398 92 0.0
.app_xip_area 474400 474492 92 0.0
efr32 lighting-app BRD4161A (read only) 865756 865876 120 0.0
.text 865748 865868 120 0.0
BRD4161A+rpc (read only) 853212 853332 120 0.0
.text 853204 853324 120 0.0
window-app BRD4161A (read only) 837960 838080 120 0.0
.text 837952 838072 120 0.0
esp32 all-clusters-app c3devkit (read only) 937916 937980 64 0.0
(read/write) 1401098 1401154 56 0.0
.flash.rodata 198464 198520 56 0.0
.flash.text 937916 937980 64 0.0
m5stack (read only) 986251 986299 48 0.0
(read/write) 466136 466192 56 0.0
.flash.rodata 225376 225432 56 0.0
.flash.text 980867 980915 48 0.0
k32w light k32w061+release (read/write) 678488 678572 84 0.0
.text 594236 594320 84 0.0
lock k32w061+release (read/write) 680388 680488 100 0.0
.text 595768 595868 100 0.0
linux chip-tool-ipv6only arm64 (read only) 7315220 7315604 384 0.0
(read/write) 289681 289713 32 0.0
.data.rel.ro 187544 187576 32 0.0
.rodata 396380 396428 48 0.0
.text 6309684 6309924 240 0.0
thermostat-no-ble arm64 (read only) 2129612 2129948 336 0.0
(read/write) 140641 140673 32 0.0
.data.rel.ro 74872 74904 32 0.0
.rodata 131932 131964 32 0.0
.text 1779712 1779920 208 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2389632 2389752 120 0.0
.text 1352232 1352352 120 0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2348800 2348920 120 0.0
.text 1311400 1311520 120 0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2312720 2312840 120 0.0
.text 1275320 1275440 120 0.0
shell CY8CPROTO_062_4343W+release (read/write) 2302692 2302812 120 0.0
.text 1265264 1265384 120 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 1004731 1004835 104 0.0
rodata 118072 118128 56 0.0
text 686436 686484 48 0.0
nrf52840dk_nrf52840+rpc (read/write) 976207 976311 104 0.0
rodata 109532 109588 56 0.1
text 671076 671124 48 0.0
nrf52840dongle_nrf52840 (read/write) 1021535 1021639 104 0.0
rodata 116960 117016 56 0.0
text 692004 692052 48 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 911394 911494 100 0.0
rodata 111332 111384 52 0.0
text 601460 601508 48 0.0
lock-app nrf52840dk_nrf52840 (read/write) 936987 937091 104 0.0
rodata 106472 106528 56 0.1
text 632356 632404 48 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 844482 844586 104 0.0
rodata 99644 99700 56 0.1
text 548156 548204 48 0.0
pump-app nrf52840dk_nrf52840 (read/write) 939219 939323 104 0.0
rodata 106656 106712 56 0.1
text 634600 634648 48 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 934559 934663 104 0.0
rodata 105948 106004 56 0.1
text 630632 630680 48 0.0
p6 all-clusters-app default (read/write) 2463712 2463848 136 0.0
.text 1421976 1422112 136 0.0
light-app default (read/write) 2367176 2367296 120 0.0
.text 1325440 1325560 120 0.0
lock-app default (read/write) 2332344 2332480 136 0.0
.text 1290608 1290744 136 0.0
qpg lighting-app qpg6105+debug (read only) 585768 585808 40 0.0
.text 580448 580488 40 0.0
lock-app qpg6105+debug (read only) 531844 531884 40 0.0
.text 526524 526564 40 0.0
telink lighting-app tlsr9518adk80d (read/write) 865702 865822 120 0.0
text 607624 607684 60 0.0
Full report (34 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 97cf4ff 0f5f595 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 594398 594490 92 0.0
.app_xip_area 500252 500344 92 0.0
.bss 76868 76868 0 0.0
.data 624 624 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 552298 552390 92 0.0
.app_xip_area 459712 459804 92 0.0
.bss 75340 75340 0 0.0
.data 588 588 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 576306 576398 92 0.0
.app_xip_area 474400 474492 92 0.0
.bss 84332 84332 0 0.0
.data 532 532 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 865756 865876 120 0.0
(read/write) 126620 126620 0 0.0
.bss 124696 124696 0 0.0
.data 1924 1924 0 0.0
.text 865748 865868 120 0.0
BRD4161A+rpc (read only) 853212 853332 120 0.0
(read/write) 143280 143280 0 0.0
.bss 141256 141256 0 0.0
.data 2024 2024 0 0.0
.text 853204 853324 120 0.0
window-app BRD4161A (read only) 837960 838080 120 0.0
(read/write) 125264 125264 0 0.0
.bss 123384 123384 0 0.0
.data 1880 1880 0 0.0
.text 837952 838072 120 0.0
esp32 all-clusters-app c3devkit (read only) 937916 937980 64 0.0
(read/write) 1401098 1401154 56 0.0
.dram0.bss 69448 69448 0 0.0
.dram0.data 14276 14276 0 0.0
.flash.rodata 198464 198520 56 0.0
.flash.text 937916 937980 64 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 986251 986299 48 0.0
(read/write) 466136 466192 56 0.0
.dram0.bss 74592 74592 0 0.0
.dram0.data 34040 34040 0 0.0
.flash.rodata 225376 225432 56 0.0
.flash.text 980867 980915 48 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 678488 678572 84 0.0
.bss 76568 76568 0 0.0
.data 1884 1884 0 0.0
.text 594236 594320 84 0.0
lock k32w061+release (read/write) 680388 680488 100 0.0
.bss 76896 76896 0 0.0
.data 1924 1924 0 0.0
.text 595768 595868 100 0.0
linux chip-tool-ipv6only arm64 (read only) 7315220 7315604 384 0.0
(read/write) 289681 289713 32 0.0
.bss 50641 50641 0 0.0
.data 1176 1176 0 0.0
.data.rel.ro 187544 187576 32 0.0
.dynamic 560 560 0 0.0
.got 46528 46528 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 396380 396428 48 0.0
.text 6309684 6309924 240 0.0
thermostat-no-ble arm64 (read only) 2129612 2129948 336 0.0
(read/write) 140641 140673 32 0.0
.bss 57665 57665 0 0.0
.data 984 984 0 0.0
.data.rel.ro 74872 74904 32 0.0
.dynamic 560 560 0 0.0
.got 4152 4152 0 0.0
.init 24 24 0 0.0
.init_array 328 328 0 0.0
.rodata 131932 131964 32 0.0
.text 1779712 1779920 208 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2389632 2389752 120 0.0
.bss 188356 188356 0 0.0
.data 5296 5296 0 0.0
.text 1352232 1352352 120 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2348800 2348920 120 0.0
.bss 180936 180936 0 0.0
.data 5600 5600 0 0.0
.text 1311400 1311520 120 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2312720 2312840 120 0.0
.bss 180824 180824 0 0.0
.data 5584 5584 0 0.0
.text 1275320 1275440 120 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139648 1139648 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103032 103032 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2302692 2302812 120 0.0
.bss 178100 178100 0 0.0
.data 5400 5400 0 0.0
.text 1265264 1265384 120 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 1004731 1004835 104 0.0
bss 121280 121280 0 0.0
rodata 118072 118128 56 0.0
text 686436 686484 48 0.0
nrf52840dk_nrf52840+rpc (read/write) 976207 976311 104 0.0
bss 117136 117136 0 0.0
rodata 109532 109588 56 0.1
text 671076 671124 48 0.0
nrf52840dongle_nrf52840 (read/write) 1021535 1021639 104 0.0
bss 122644 122644 0 0.0
rodata 116960 117016 56 0.0
text 692004 692052 48 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 911394 911494 100 0.0
bss 117840 117840 0 0.0
rodata 111332 111384 52 0.0
text 601460 601508 48 0.0
lock-app nrf52840dk_nrf52840 (read/write) 936987 937091 104 0.0
bss 119616 119616 0 0.0
rodata 106472 106528 56 0.1
text 632356 632404 48 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 844482 844586 104 0.0
bss 116212 116212 0 0.0
rodata 99644 99700 56 0.1
text 548156 548204 48 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 541747 541747 0 0.0
bss 52588 52588 0 0.0
rodata 50048 50048 0 0.0
text 376920 376920 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 939219 939323 104 0.0
bss 119368 119368 0 0.0
rodata 106656 106712 56 0.1
text 634600 634648 48 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 934559 934663 104 0.0
bss 119372 119372 0 0.0
rodata 105948 106004 56 0.1
text 630632 630680 48 0.0
shell nrf52840dk_nrf52840 (read/write) 803151 803151 0 0.0
bss 111232 111232 0 0.0
rodata 78532 78532 0 0.0
text 535824 535824 0 0.0
p6 all-clusters-app default (read/write) 2463712 2463848 136 0.0
.bss 117976 117976 0 0.0
.data 2584 2584 0 0.0
.text 1421976 1422112 136 0.0
light-app default (read/write) 2367176 2367296 120 0.0
.bss 107600 107600 0 0.0
.data 2432 2432 0 0.0
.text 1325440 1325560 120 0.0
lock-app default (read/write) 2332344 2332480 136 0.0
.bss 107304 107304 0 0.0
.data 2392 2392 0 0.0
.text 1290608 1290744 136 0.0
qpg lighting-app qpg6105+debug (read only) 585768 585808 40 0.0
(read/write) 146936 146936 0 0.0
.bss 88856 88856 0 0.0
.data 1084 1084 0 0.0
.text 580448 580488 40 0.0
lock-app qpg6105+debug (read only) 531844 531884 40 0.0
(read/write) 146940 146940 0 0.0
.bss 88304 88304 0 0.0
.data 1024 1024 0 0.0
.text 526524 526564 40 0.0
persistent-storage-app qpg6105+debug (read only) 99520 99520 0 0.0
(read/write) 146940 146940 0 0.0
.bss 24004 24004 0 0.0
.data 176 176 0 0.0
.text 94200 94200 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 865702 865822 120 0.0
bss 88592 88592 0 0.0
noinit 37160 37160 0 0.0
text 607624 607684 60 0.0

@bzbarsky-apple
Copy link
Contributor

/rebase

mrjerryjohns and others added 4 commits February 8, 2022 07:29
@mrjerryjohns @bzbarsky-apple
Make WriteHandler an ExchangeDelegate
d6d825d 
This is a meant to setup the WriteHandler's messaging processing
pathways correctly to permit chunking to get implemented correctly
(which will utilize this feature).
@mrjerryjohns @bzbarsky-apple
Removed the EnableResponseGeneration method that I added to the
6fb0c52 
WriteHandler since that required enabling CONFIG_IM_BUILD_FOR_UNIT_TEST
when building the src/app/tests/*. This caused issues when building
these tests on EFR32 platforms which didn't have that defined.

So rather than disable those tests outright for those platforms, or do
some other hackery, I decided to just enable async dispatch for just the
test I was modifying to make it more representative of real-world
scenarios and consequently, avoid the special logic.
@mrjerryjohns @bzbarsky-apple
Added some comments
c1045a9
@bzbarsky-apple @msandstedt
Fix comment typo.
f92f3e5 
Co-authored-by: Michael Sandstedt <michael.sandstedt@gmail.com>
@woody-apple woody-apple force-pushed the write-handler-ec-delegate branch from 0f5f595 to f92f3e5 Compare February 8, 2022 07:29
@github-actions
Copy link

github-actions bot commented Feb 8, 2022 •
edited
Loading

PR #14821: Size comparison from b4901db to f92f3e5

Increases (39 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section b4901db f92f3e5 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 594398 594490 92 0.0
.app_xip_area 500252 500344 92 0.0
lock cyw930739m2evb_01 (read/write) 552298 552390 92 0.0
.app_xip_area 459712 459804 92 0.0
ota-requestor cyw930739m2evb_01 (read/write) 576306 576398 92 0.0
.app_xip_area 474400 474492 92 0.0
efr32 lighting-app BRD4161A (read only) 865756 865876 120 0.0
.text 865748 865868 120 0.0
BRD4161A+rpc (read only) 853212 853332 120 0.0
.text 853204 853324 120 0.0
window-app BRD4161A (read only) 837960 838080 120 0.0
.text 837952 838072 120 0.0
esp32 all-clusters-app c3devkit (read only) 937920 937984 64 0.0
(read/write) 1401106 1401162 56 0.0
.flash.rodata 198472 198528 56 0.0
.flash.text 937920 937984 64 0.0
m5stack (read only) 986255 986303 48 0.0
(read/write) 466144 466200 56 0.0
.flash.rodata 225384 225440 56 0.0
.flash.text 980871 980919 48 0.0
k32w light k32w061+release (read/write) 678488 678572 84 0.0
.text 594236 594320 84 0.0
lock k32w061+release (read/write) 680388 680488 100 0.0
.text 595768 595868 100 0.0
linux all-clusters-app debug (read only) 2327337 2327673 336 0.0
(read/write) 140064 140096 32 0.0
.data.rel.ro 78504 78536 32 0.0
.rodata 205029 205061 32 0.0
.text 1960082 1960290 208 0.0
bridge-app debug+rpc (read only) 1704053 1704373 320 0.0
(read/write) 84296 84328 32 0.0
.data.rel.ro 38088 38120 32 0.1
.rodata 140172 140204 32 0.0
.text 1447429 1447621 192 0.0
chip-tool debug (read only) 7383957 7384309 352 0.0
(read/write) 185392 185424 32 0.0
.data.rel.ro 145888 145920 32 0.0
.rodata 413077 413109 32 0.0
.text 6599045 6599269 224 0.0
chip-tool-ipv6only arm64 (read only) 7315220 7315604 384 0.0
(read/write) 289681 289713 32 0.0
.data.rel.ro 187544 187576 32 0.0
.rodata 396380 396428 48 0.0
.text 6309684 6309924 240 0.0
door-lock-app debug (read only) 1908457 1908777 320 0.0
(read/write) 110552 110584 32 0.0
.data.rel.ro 62096 62128 32 0.1
.rodata 172786 172818 32 0.0
.text 1587250 1587442 192 0.0
lighting-app debug+rpc (read only) 2003289 2003609 320 0.0
(read/write) 115600 115632 32 0.0
.data.rel.ro 65640 65672 32 0.0
.rodata 162865 162897 32 0.0
.text 1685874 1686066 192 0.0
ota-provider-app debug (read only) 1711905 1712241 336 0.0
(read/write) 81336 81368 32 0.0
.data.rel.ro 33528 33560 32 0.1
.rodata 151206 151238 32 0.0
.text 1442114 1442322 208 0.0
ota-requestor-app debug (read only) 1701321 1701673 352 0.0
(read/write) 83288 83320 32 0.0
.data.rel.ro 34584 34616 32 0.1
.rodata 144823 144887 64 0.0
.text 1439698 1439890 192 0.0
shell debug (read only) 2300761 2301113 352 0.0
(read/write) 141616 141648 32 0.0
.data.rel.ro 73040 73072 32 0.0
.rodata 205778 205810 32 0.0
.text 1938562 1938786 224 0.0
thermostat-no-ble arm64 (read only) 2129596 2129932 336 0.0
(read/write) 140641 140673 32 0.0
.data.rel.ro 74872 74904 32 0.0
.rodata 131932 131964 32 0.0
.text 1779696 1779904 208 0.0
tv-app debug (read only) 2525545 2525897 352 0.0
(read/write) 139800 139832 32 0.0
.data.rel.ro 73336 73368 32 0.0
.rodata 195532 195564 32 0.0
.text 2156402 2156626 224 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2389632 2389752 120 0.0
.text 1352232 1352352 120 0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2348800 2348920 120 0.0
.text 1311400 1311520 120 0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2312720 2312840 120 0.0
.text 1275320 1275440 120 0.0
shell CY8CPROTO_062_4343W+release (read/write) 2302692 2302812 120 0.0
.text 1265264 1265384 120 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 1004731 1004835 104 0.0
rodata 118072 118128 56 0.0
text 686436 686484 48 0.0
nrf52840dk_nrf52840+rpc (read/write) 976207 976311 104 0.0
rodata 109532 109588 56 0.1
text 671076 671124 48 0.0
nrf52840dongle_nrf52840 (read/write) 1021535 1021639 104 0.0
rodata 116960 117016 56 0.0
text 692004 692052 48 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 911394 911494 100 0.0
rodata 111332 111384 52 0.0
text 601460 601508 48 0.0
lock-app nrf52840dk_nrf52840 (read/write) 936987 937091 104 0.0
rodata 106472 106528 56 0.1
text 632356 632404 48 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 844482 844586 104 0.0
rodata 99644 99700 56 0.1
text 548156 548204 48 0.0
pump-app nrf52840dk_nrf52840 (read/write) 939219 939323 104 0.0
rodata 106656 106712 56 0.1
text 634600 634648 48 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 934559 934663 104 0.0
rodata 105948 106004 56 0.1
text 630632 630680 48 0.0
p6 all-clusters-app default (read/write) 2463712 2463848 136 0.0
.text 1421976 1422112 136 0.0
light-app default (read/write) 2367176 2367296 120 0.0
.text 1325440 1325560 120 0.0
lock-app default (read/write) 2332344 2332480 136 0.0
.text 1290608 1290744 136 0.0
qpg lighting-app qpg6105+debug (read only) 585768 585808 40 0.0
.text 580448 580488 40 0.0
lock-app qpg6105+debug (read only) 531844 531884 40 0.0
.text 526524 526564 40 0.0
telink lighting-app tlsr9518adk80d (read/write) 865702 865822 120 0.0
text 607624 607684 60 0.0
Full report (43 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section b4901db f92f3e5 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 594398 594490 92 0.0
.app_xip_area 500252 500344 92 0.0
.bss 76868 76868 0 0.0
.data 624 624 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 552298 552390 92 0.0
.app_xip_area 459712 459804 92 0.0
.bss 75340 75340 0 0.0
.data 588 588 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 576306 576398 92 0.0
.app_xip_area 474400 474492 92 0.0
.bss 84332 84332 0 0.0
.data 532 532 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 865756 865876 120 0.0
(read/write) 126620 126620 0 0.0
.bss 124696 124696 0 0.0
.data 1924 1924 0 0.0
.text 865748 865868 120 0.0
BRD4161A+rpc (read only) 853212 853332 120 0.0
(read/write) 143280 143280 0 0.0
.bss 141256 141256 0 0.0
.data 2024 2024 0 0.0
.text 853204 853324 120 0.0
window-app BRD4161A (read only) 837960 838080 120 0.0
(read/write) 125264 125264 0 0.0
.bss 123384 123384 0 0.0
.data 1880 1880 0 0.0
.text 837952 838072 120 0.0
esp32 all-clusters-app c3devkit (read only) 937920 937984 64 0.0
(read/write) 1401106 1401162 56 0.0
.dram0.bss 69448 69448 0 0.0
.dram0.data 14276 14276 0 0.0
.flash.rodata 198472 198528 56 0.0
.flash.text 937920 937984 64 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 986255 986303 48 0.0
(read/write) 466144 466200 56 0.0
.dram0.bss 74592 74592 0 0.0
.dram0.data 34040 34040 0 0.0
.flash.rodata 225384 225440 56 0.0
.flash.text 980871 980919 48 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 678488 678572 84 0.0
.bss 76568 76568 0 0.0
.data 1884 1884 0 0.0
.text 594236 594320 84 0.0
lock k32w061+release (read/write) 680388 680488 100 0.0
.bss 76896 76896 0 0.0
.data 1924 1924 0 0.0
.text 595768 595868 100 0.0
linux all-clusters-app debug (read only) 2327337 2327673 336 0.0
(read/write) 140064 140096 32 0.0
.bss 54688 54688 0 0.0
.data 1200 1200 0 0.0
.data.rel.ro 78504 78536 32 0.0
.dynamic 592 592 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 205029 205061 32 0.0
.text 1960082 1960290 208 0.0
bridge-app debug+rpc (read only) 1704053 1704373 320 0.0
(read/write) 84296 84328 32 0.0
.bss 39088 39088 0 0.0
.data 1970 1970 0 0.0
.data.rel.ro 38088 38120 32 0.1
.dynamic 592 592 0 0.0
.got 3976 3976 0 0.0
.init 27 27 0 0.0
.init_array 560 560 0 0.0
.rodata 140172 140204 32 0.0
.text 1447429 1447621 192 0.0
chip-tool debug (read only) 7383957 7384309 352 0.0
(read/write) 185392 185424 32 0.0
.bss 32360 32360 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 145888 145920 32 0.0
.dynamic 608 608 0 0.0
.got 4760 4760 0 0.0
.init 27 27 0 0.0
.init_array 608 608 0 0.0
.rodata 413077 413109 32 0.0
.text 6599045 6599269 224 0.0
chip-tool-ipv6only arm64 (read only) 7315220 7315604 384 0.0
(read/write) 289681 289713 32 0.0
.bss 50641 50641 0 0.0
.data 1176 1176 0 0.0
.data.rel.ro 187544 187576 32 0.0
.dynamic 560 560 0 0.0
.got 46528 46528 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 396380 396428 48 0.0
.text 6309684 6309924 240 0.0
door-lock-app debug (read only) 1908457 1908777 320 0.0
(read/write) 110552 110584 32 0.0
.bss 42096 42096 0 0.0
.data 946 946 0 0.0
.data.rel.ro 62096 62128 32 0.1
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 172786 172818 32 0.0
.text 1587250 1587442 192 0.0
lighting-app debug+rpc (read only) 2003289 2003609 320 0.0
(read/write) 115600 115632 32 0.0
.bss 43104 43104 0 0.0
.data 1368 1368 0 0.0
.data.rel.ro 65640 65672 32 0.0
.dynamic 608 608 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 712 712 0 0.0
.rodata 162865 162897 32 0.0
.text 1685874 1686066 192 0.0
ota-provider-app debug (read only) 1711905 1712241 336 0.0
(read/write) 81336 81368 32 0.0
.bss 41120 41120 0 0.0
.data 1160 1160 0 0.0
.data.rel.ro 33528 33560 32 0.1
.dynamic 608 608 0 0.0
.got 4240 4240 0 0.0
.init 27 27 0 0.0
.init_array 624 624 0 0.0
.rodata 151206 151238 32 0.0
.text 1442114 1442322 208 0.0
ota-requestor-app debug (read only) 1701321 1701673 352 0.0
(read/write) 83288 83320 32 0.0
.bss 42272 42272 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 34584 34616 32 0.1
.dynamic 592 592 0 0.0
.got 4040 4040 0 0.0
.init 27 27 0 0.0
.init_array 624 624 0 0.0
.rodata 144823 144887 64 0.0
.text 1439698 1439890 192 0.0
shell debug (read only) 2300761 2301113 352 0.0
(read/write) 141616 141648 32 0.0
.bss 62080 62080 0 0.0
.data 800 800 0 0.0
.data.rel.ro 73040 73072 32 0.0
.dynamic 592 592 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 205778 205810 32 0.0
.text 1938562 1938786 224 0.0
thermostat-no-ble arm64 (read only) 2129596 2129932 336 0.0
(read/write) 140641 140673 32 0.0
.bss 57665 57665 0 0.0
.data 984 984 0 0.0
.data.rel.ro 74872 74904 32 0.0
.dynamic 560 560 0 0.0
.got 4152 4152 0 0.0
.init 24 24 0 0.0
.init_array 328 328 0 0.0
.rodata 131932 131964 32 0.0
.text 1779696 1779904 208 0.0
tv-app debug (read only) 2525545 2525897 352 0.0
(read/write) 139800 139832 32 0.0
.bss 57280 57280 0 0.0
.data 3168 3168 0 0.0
.data.rel.ro 73336 73368 32 0.0
.dynamic 592 592 0 0.0
.got 4528 4528 0 0.0
.init 27 27 0 0.0
.init_array 880 880 0 0.0
.rodata 195532 195564 32 0.0
.text 2156402 2156626 224 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2389632 2389752 120 0.0
.bss 188356 188356 0 0.0
.data 5296 5296 0 0.0
.text 1352232 1352352 120 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2348800 2348920 120 0.0
.bss 180936 180936 0 0.0
.data 5600 5600 0 0.0
.text 1311400 1311520 120 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2312720 2312840 120 0.0
.bss 180824 180824 0 0.0
.data 5584 5584 0 0.0
.text 1275320 1275440 120 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139648 1139648 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103032 103032 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2302692 2302812 120 0.0
.bss 178100 178100 0 0.0
.data 5400 5400 0 0.0
.text 1265264 1265384 120 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 1004731 1004835 104 0.0
bss 121280 121280 0 0.0
rodata 118072 118128 56 0.0
text 686436 686484 48 0.0
nrf52840dk_nrf52840+rpc (read/write) 976207 976311 104 0.0
bss 117136 117136 0 0.0
rodata 109532 109588 56 0.1
text 671076 671124 48 0.0
nrf52840dongle_nrf52840 (read/write) 1021535 1021639 104 0.0
bss 122644 122644 0 0.0
rodata 116960 117016 56 0.0
text 692004 692052 48 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 911394 911494 100 0.0
bss 117840 117840 0 0.0
rodata 111332 111384 52 0.0
text 601460 601508 48 0.0
lock-app nrf52840dk_nrf52840 (read/write) 936987 937091 104 0.0
bss 119616 119616 0 0.0
rodata 106472 106528 56 0.1
text 632356 632404 48 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 844482 844586 104 0.0
bss 116212 116212 0 0.0
rodata 99644 99700 56 0.1
text 548156 548204 48 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 541747 541747 0 0.0
bss 52588 52588 0 0.0
rodata 50048 50048 0 0.0
text 376920 376920 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 939219 939323 104 0.0
bss 119368 119368 0 0.0
rodata 106656 106712 56 0.1
text 634600 634648 48 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 934559 934663 104 0.0
bss 119372 119372 0 0.0
rodata 105948 106004 56 0.1
text 630632 630680 48 0.0
shell nrf52840dk_nrf52840 (read/write) 803151 803151 0 0.0
bss 111232 111232 0 0.0
rodata 78532 78532 0 0.0
text 535824 535824 0 0.0
p6 all-clusters-app default (read/write) 2463712 2463848 136 0.0
.bss 117976 117976 0 0.0
.data 2584 2584 0 0.0
.text 1421976 1422112 136 0.0
light-app default (read/write) 2367176 2367296 120 0.0
.bss 107600 107600 0 0.0
.data 2432 2432 0 0.0
.text 1325440 1325560 120 0.0
lock-app default (read/write) 2332344 2332480 136 0.0
.bss 107304 107304 0 0.0
.data 2392 2392 0 0.0
.text 1290608 1290744 136 0.0
qpg lighting-app qpg6105+debug (read only) 585768 585808 40 0.0
(read/write) 146936 146936 0 0.0
.bss 88856 88856 0 0.0
.data 1084 1084 0 0.0
.text 580448 580488 40 0.0
lock-app qpg6105+debug (read only) 531844 531884 40 0.0
(read/write) 146940 146940 0 0.0
.bss 88304 88304 0 0.0
.data 1024 1024 0 0.0
.text 526524 526564 40 0.0
persistent-storage-app qpg6105+debug (read only) 99520 99520 0 0.0
(read/write) 146940 146940 0 0.0
.bss 24004 24004 0 0.0
.data 176 176 0 0.0
.text 94200 94200 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 865702 865822 120 0.0
bss 88592 88592 0 0.0
noinit 37160 37160 0 0.0
text 607624 607684 60 0.0

@erjiaqing erjiaqing merged commit bed61c3 into project-chip:master Feb 8, 2022
erjiaqing added a commit to erjiaqing/connectedhomeip that referenced this pull request Feb 8, 2022
@erjiaqing
Adapt WriteHandler for project-chip#14821
31f5f44
mrjerryjohns added a commit that referenced this pull request Feb 10, 2022
@erjiaqing @mrjerryjohns
[IM] Write Chunking Support (#13641)
56634bf 
* [IM] Implement write chunking with set+append for large lists

* Python API update

* Update LongListAttribute

* Update TestSuite

* Add more tests

* Fix WriteClient construct call

* Run Codegen

* Address comments

* Restyle

* Fix test

* Run Codegen

* Fix dirty merge

* Address comments

* Update access-control-server

* Fix merge

* Updated code-gen

* Address comments

* Fix unclean merge

* Fix GroupWrite Encoding

* Fix merge and make access-control-server diff readable

* Fix dirty merge

* Update group-key-mgmt-server

* Fix GroupWrite attribute path on the server side

* Adapt WriteHandler for #14821

* Add ACL check cache

* Resolve comments

* Fix typo and fix merge

* Fix

* Comment out #if CONFIG_IM_BUILD_FOR_UNIT_TEST in WriteClient.h

* Comment out #if CONFIG_IM_BUILD_FOR_UNIT_TEST in WriteClient.h

Co-authored-by: Jerry Johns <johnsj@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@yunhanw-google yunhanw-google yunhanw-google approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mspang mspang Awaiting requested review from mspang

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@msandstedt msandstedt Awaiting requested review from msandstedt

@woody-apple woody-apple Awaiting requested review from woody-apple

Assignees
No one assigned
Labels
app controller lib review - approved transport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mrjerryjohns @woody-apple @bzbarsky-apple @msandstedt @yunhanw-google @erjiaqing