Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Group] Add source Node Id to group session #15038

Merged
merged 2 commits into from
Feb 10, 2022
Merged

[Group] Add source Node Id to group session #15038

merged 2 commits into from
Feb 10, 2022

Conversation

jepenven-silabs
Copy link
Contributor

Problem

According to spec : 4.4.1.6 and 4.7.2 the source NodeId needs to be present in the packet header for group messages. This is not case.

Change overview

Added the source NodeId to the constructor of the GroupSession so that the SessionManager can retrieve it.
This solution was implemented because it's the easiest way to retrieve the Sender nodeId without adding any dependency from the transport layer to the other layers. The transport layer should, in a perfect world, only deal with what it is given without having to search/retrieve for what it needs.

This also move the burden of providing a sourceNodeId closer to the app layer.

Testing

  • Unit test
  • Test suite

@jepenven-silabs jepenven-silabs mentioned this pull request Feb 10, 2022
Merged
@github-actions
Copy link

github-actions bot commented Feb 10, 2022 •
edited
Loading

PR #15038: Size comparison from a08613b to f72d150

Increases (22 builds for cyw30739, efr32, esp32, k32w, linux, mbed, p6, qpg, telink)
platform target config section a08613be f72d150 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 606702 606874 172 0.0
.app_xip_area 508132 508160 28 0.0
.bss 81268 81412 144 0.2
lock cyw930739m2evb_01 (read/write) 563174 563346 172 0.0
.app_xip_area 466164 466192 28 0.0
.bss 79740 79884 144 0.2
ota-requestor cyw930739m2evb_01 (read/write) 584190 584354 164 0.0
.app_xip_area 477932 477952 20 0.0
.bss 88660 88804 144 0.2
efr32 lighting-app BRD4161A (read only) 906824 906936 112 0.0
(read/write) 129000 129072 72 0.1
.bss 126960 127032 72 0.1
.text 906816 906928 112 0.0
BRD4161A+rpc (read only) 894268 894396 128 0.0
(read/write) 145656 145728 72 0.0
.bss 143520 143592 72 0.1
.text 894260 894388 128 0.0
window-app BRD4161A (read only) 841936 842048 112 0.0
(read/write) 127064 127136 72 0.1
.bss 125160 125232 72 0.1
.text 841928 842040 112 0.0
esp32 all-clusters-app c3devkit (read only) 943304 943370 66 0.0
(read/write) 1400250 1400314 64 0.0
.dram0.bss 68024 68096 72 0.1
.flash.text 943304 943370 66 0.0
m5stack (read only) 990967 991063 96 0.0
(read/write) 465080 465152 72 0.0
.dram0.bss 73168 73240 72 0.1
.flash.text 985583 985679 96 0.0
k32w light k32w061+release (read/write) 683560 683680 120 0.0
.bss 78264 78336 72 0.1
.text 597588 597636 48 0.0
lock k32w061+release (read/write) 688440 688544 104 0.0
.bss 78664 78736 72 0.1
.text 602024 602056 32 0.0
linux chip-tool-ipv6only arm64 (read only) 7478108 7478348 240 0.0
(read/write) 303409 303473 64 0.0
.bss 51777 51841 64 0.1
.text 6435220 6435460 240 0.0
thermostat-no-ble arm64 (read only) 2139804 2139916 112 0.0
(read/write) 142273 142337 64 0.0
.bss 59201 59265 64 0.1
.text 1788736 1788848 112 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release .bss 190092 190164 72 0.0
lighting-app CY8CPROTO_062_4343W+release .bss 182704 182776 72 0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2321288 2321352 64 0.0
.bss 182592 182664 72 0.0
.text 1283888 1283952 64 0.0
shell CY8CPROTO_062_4343W+release (read/write) 2307292 2307356 64 0.0
.bss 179844 179916 72 0.0
.text 1269864 1269928 64 0.0
p6 all-clusters-app default (read/write) 2482336 2482352 16 0.0
.bss 119704 119776 72 0.1
.text 1440600 1440616 16 0.0
light-app default (read/write) 2388664 2388680 16 0.0
.bss 109352 109424 72 0.1
.text 1346928 1346944 16 0.0
lock-app default (read/write) 2352120 2352136 16 0.0
.bss 109072 109144 72 0.1
.text 1310384 1310400 16 0.0
qpg lighting-app qpg6105+debug (read only) 592980 593020 40 0.0
.bss 90536 90608 72 0.1
.text 587660 587700 40 0.0
lock-app qpg6105+debug (read only) 558732 558772 40 0.0
.bss 90520 90592 72 0.1
.text 553412 553452 40 0.0
telink lighting-app tlsr9518adk80d (read/write) 874334 874454 120 0.0
bss 90352 90424 72 0.1
text 613082 613122 40 0.0
Full report (24 builds for cyw30739, efr32, esp32, k32w, linux, mbed, p6, qpg, telink)
platform target config section a08613be f72d150 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 606702 606874 172 0.0
.app_xip_area 508132 508160 28 0.0
.bss 81268 81412 144 0.2
.data 648 648 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 563174 563346 172 0.0
.app_xip_area 466164 466192 28 0.0
.bss 79740 79884 144 0.2
.data 612 612 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 584190 584354 164 0.0
.app_xip_area 477932 477952 20 0.0
.bss 88660 88804 144 0.2
.data 556 556 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 906824 906936 112 0.0
(read/write) 129000 129072 72 0.1
.bss 126960 127032 72 0.1
.data 2036 2036 0 0.0
.text 906816 906928 112 0.0
BRD4161A+rpc (read only) 894268 894396 128 0.0
(read/write) 145656 145728 72 0.0
.bss 143520 143592 72 0.1
.data 2136 2136 0 0.0
.text 894260 894388 128 0.0
window-app BRD4161A (read only) 841936 842048 112 0.0
(read/write) 127064 127136 72 0.1
.bss 125160 125232 72 0.1
.data 1904 1904 0 0.0
.text 841928 842040 112 0.0
esp32 all-clusters-app c3devkit (read only) 943304 943370 66 0.0
(read/write) 1400250 1400314 64 0.0
.dram0.bss 68024 68096 72 0.1
.dram0.data 14276 14276 0 0.0
.flash.rodata 199040 199040 0 0.0
.flash.text 943304 943370 66 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 990967 991063 96 0.0
(read/write) 465080 465152 72 0.0
.dram0.bss 73168 73240 72 0.1
.dram0.data 34072 34072 0 0.0
.flash.rodata 225712 225712 0 0.0
.flash.text 985583 985679 96 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 683560 683680 120 0.0
.bss 78264 78336 72 0.1
.data 1908 1908 0 0.0
.text 597588 597636 48 0.0
lock k32w061+release (read/write) 688440 688544 104 0.0
.bss 78664 78736 72 0.1
.data 1952 1952 0 0.0
.text 602024 602056 32 0.0
linux chip-tool-ipv6only arm64 (read only) 7478108 7478348 240 0.0
(read/write) 303409 303473 64 0.0
.bss 51777 51841 64 0.1
.data 1224 1224 0 0.0
.data.rel.ro 199520 199520 0 0.0
.dynamic 560 560 0 0.0
.got 47088 47088 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 403012 403012 0 0.0
.text 6435220 6435460 240 0.0
thermostat-no-ble arm64 (read only) 2139804 2139916 112 0.0
(read/write) 142273 142337 64 0.0
.bss 59201 59265 64 0.1
.data 1040 1040 0 0.0
.data.rel.ro 74912 74912 0 0.0
.dynamic 560 560 0 0.0
.got 4152 4152 0 0.0
.init 24 24 0 0.0
.init_array 328 328 0 0.0
.rodata 132956 132956 0 0.0
.text 1788736 1788848 112 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2396136 2396136 0 0.0
.bss 190092 190164 72 0.0
.data 5320 5320 0 0.0
.text 1358736 1358736 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2357760 2357760 0 0.0
.bss 182704 182776 72 0.0
.data 5632 5632 0 0.0
.text 1320360 1320360 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2321288 2321352 64 0.0
.bss 182592 182664 72 0.0
.data 5608 5608 0 0.0
.text 1283888 1283952 64 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139648 1139648 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103032 103032 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2307292 2307356 64 0.0
.bss 179844 179916 72 0.0
.data 5424 5424 0 0.0
.text 1269864 1269928 64 0.0
p6 all-clusters-app default (read/write) 2482336 2482352 16 0.0
.bss 119704 119776 72 0.1
.data 2672 2672 0 0.0
.text 1440600 1440616 16 0.0
light-app default (read/write) 2388664 2388680 16 0.0
.bss 109352 109424 72 0.1
.data 2528 2528 0 0.0
.text 1346928 1346944 16 0.0
lock-app default (read/write) 2352120 2352136 16 0.0
.bss 109072 109144 72 0.1
.data 2488 2488 0 0.0
.text 1310384 1310400 16 0.0
qpg lighting-app qpg6105+debug (read only) 592980 593020 40 0.0
(read/write) 146940 146940 0 0.0
.bss 90536 90608 72 0.1
.data 1112 1112 0 0.0
.text 587660 587700 40 0.0
lock-app qpg6105+debug (read only) 558732 558772 40 0.0
(read/write) 146940 146940 0 0.0
.bss 90520 90592 72 0.1
.data 1064 1064 0 0.0
.text 553412 553452 40 0.0
persistent-storage-app qpg6105+debug (read only) 99520 99520 0 0.0
(read/write) 146940 146940 0 0.0
.bss 24004 24004 0 0.0
.data 176 176 0 0.0
.text 94200 94200 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 874334 874454 120 0.0
bss 90352 90424 72 0.1
noinit 37160 37160 0 0.0
text 613082 613122 40 0.0

@boring-cyborg boring-cyborg bot added the lib label Feb 10, 2022
@github-actions
Copy link

github-actions bot commented Feb 10, 2022 •
edited
Loading

PR #15038: Size comparison from a08613b to 983d6f5

Increases above 0.2%:

platform target config section a08613be 983d6f5 change % change
linux chip-tool debug (read only) 7571909 8229725 657816 8.7
(read/write) 198520 232152 33632 16.9
.data.rel.ro 157768 191528 33760 21.4
.rodata 421397 456309 34912 8.3
.text 6749621 7292773 543152 8.0
chip-tool-ipv6only arm64 (read only) 7478108 8053276 575168 7.7
(read/write) 303409 339377 35968 11.9
.data.rel.ro 199520 233784 34264 17.2
.got 47088 48904 1816 3.9
.rodata 403012 433156 30144 7.5
.text 6435220 6894548 459328 7.1
Increases (37 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, qpg, telink)
platform target config section a08613be 983d6f5 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 606702 607074 372 0.1
.app_xip_area 508132 508552 420 0.1
lock cyw930739m2evb_01 (read/write) 563174 563778 604 0.1
.app_xip_area 466164 466824 660 0.1
ota-requestor cyw930739m2evb_01 (read/write) 584190 584546 356 0.1
.app_xip_area 477932 478344 412 0.1
efr32 lighting-app BRD4161A (read only) 906824 907616 792 0.1
.text 906816 907608 792 0.1
BRD4161A+rpc (read only) 894268 895060 792 0.1
.text 894260 895052 792 0.1
window-app BRD4161A (read only) 841936 842712 776 0.1
.text 841928 842704 776 0.1
esp32 all-clusters-app c3devkit (read only) 943304 943900 596 0.1
.flash.text 943304 943900 596 0.1
m5stack (read only) 990967 991195 228 0.0
.flash.text 985583 985811 228 0.0
k32w light k32w061+release (read/write) 683560 684224 664 0.1
.text 597588 598280 692 0.1
lock k32w061+release (read/write) 688440 689088 648 0.1
.text 602024 602700 676 0.1
linux all-clusters-app debug (read only) 2345665 2346377 712 0.0
.text 1977746 1978898 1152 0.1
bridge-app debug+rpc (read only) 1713293 1714021 728 0.0
.text 1455349 1456485 1136 0.1
chip-tool debug (read only) 7571909 8229725 657816 8.7
(read/write) 198520 232152 33632 16.9
.data.rel.ro 157768 191528 33760 21.4
.rodata 421397 456309 34912 8.3
.text 6749621 7292773 543152 8.0
chip-tool-ipv6only arm64 (read only) 7478108 8053276 575168 7.7
(read/write) 303409 339377 35968 11.9
.data.rel.ro 199520 233784 34264 17.2
.got 47088 48904 1816 3.9
.rodata 403012 433156 30144 7.5
.text 6435220 6894548 459328 7.1
door-lock-app debug (read only) 1918481 1919193 712 0.0
.text 1597138 1598290 1152 0.1
lighting-app debug+rpc (read only) 2042785 2043497 712 0.0
.text 1721618 1722770 1152 0.1
ota-provider-app debug (read only) 1858137 1858849 712 0.0
.text 1549170 1550322 1152 0.1
ota-requestor-app debug (read only) 1852849 1853561 712 0.0
.text 1552178 1553330 1152 0.1
shell debug (read only) 2319425 2320137 712 0.0
.text 1956306 1957458 1152 0.1
thermostat-no-ble arm64 (read only) 2139804 2140156 352 0.0
.data.rel.ro 74912 74960 48 0.1
.text 1788736 1789584 848 0.0
tv-app debug (read only) 2515289 2516033 744 0.0
.text 2144674 2145826 1152 0.1
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2396136 2396832 696 0.0
.text 1358736 1359432 696 0.1
lighting-app CY8CPROTO_062_4343W+release (read/write) 2357760 2358456 696 0.0
.text 1320360 1321056 696 0.1
lock-app CY8CPROTO_062_4343W+release (read/write) 2321288 2321984 696 0.0
.text 1283888 1284584 696 0.1
shell CY8CPROTO_062_4343W+release (read/write) 2307292 2307988 696 0.0
.text 1269864 1270560 696 0.1
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 1015395 1015947 552 0.1
rodata 119416 119528 112 0.1
text 693940 694508 568 0.1
nrf52840dk_nrf52840+rpc (read/write) 984215 984763 548 0.1
rodata 110780 110896 116 0.1
text 673552 674120 568 0.1
nrf52840dongle_nrf52840 (read/write) 1031099 1031791 692 0.1
rodata 118276 118392 116 0.1
text 698556 699124 568 0.1
nrf5340dk_nrf5340_cpuapp (read/write) 921990 922674 684 0.1
rodata 112656 112772 116 0.1
text 608976 609544 568 0.1
lock-app nrf52840dk_nrf52840 (read/write) 945099 945791 692 0.1
rodata 108160 108276 116 0.1
text 636968 637536 568 0.1
nrf5340dk_nrf5340_cpuapp (read/write) 852610 853266 656 0.1
rodata 101332 101444 112 0.1
text 552776 553344 568 0.1
pump-app nrf52840dk_nrf52840 (read/write) 944539 945203 664 0.1
rodata 107520 107632 112 0.1
text 637228 637796 568 0.1
pump-controller-app nrf52840dk_nrf52840 (read/write) 939863 940551 688 0.1
rodata 106812 106924 112 0.1
text 633264 633832 568 0.1
shell nrf52840dk_nrf52840 (read/write) 805927 806223 296 0.0
rodata 78812 78948 136 0.2
text 537036 537320 284 0.1
qpg lighting-app qpg6105+debug (read only) 592980 593656 676 0.1
.text 587660 588336 676 0.1
lock-app qpg6105+debug (read only) 558732 559408 676 0.1
.text 553412 554088 676 0.1
telink lighting-app tlsr9518adk80d (read/write) 874334 874870 536 0.1
text 613082 613516 434 0.1
Decreases (40 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section a08613be 983d6f5 change % change
cyw30739 light cyw930739m2evb_01 .bss 81268 81220 -48 -0.1
.data 648 644 -4 -0.6
lock cyw930739m2evb_01 .bss 79740 79692 -48 -0.1
.data 612 608 -4 -0.7
ota-requestor cyw930739m2evb_01 .bss 88660 88612 -48 -0.1
.data 556 552 -4 -0.7
efr32 lighting-app BRD4161A (read/write) 129000 128968 -32 -0.0
.bss 126960 126936 -24 -0.0
.data 2036 2032 -4 -0.2
BRD4161A+rpc (read/write) 145656 145628 -28 -0.0
.bss 143520 143496 -24 -0.0
.data 2136 2132 -4 -0.2
window-app BRD4161A (read/write) 127064 127040 -24 -0.0
.bss 125160 125136 -24 -0.0
.data 1904 1900 -4 -0.2
esp32 all-clusters-app c3devkit (read/write) 1400250 1399738 -512 -0.0
.dram0.bss 68024 68000 -24 -0.0
.dram0.data 14276 14268 -8 -0.1
.flash.rodata 199040 198576 -464 -0.2
m5stack (read/write) 465080 464584 -496 -0.1
.dram0.bss 73168 73144 -24 -0.0
.dram0.data 34072 34064 -8 -0.0
.flash.rodata 225712 225248 -464 -0.2
k32w light k32w061+release .bss 78264 78240 -24 -0.0
.data 1908 1904 -4 -0.2
lock k32w061+release .bss 78664 78640 -24 -0.0
.data 1952 1948 -4 -0.2
linux all-clusters-app debug (read/write) 141696 141600 -96 -0.1
.bss 56224 56128 -96 -0.2
.data 1312 1296 -16 -1.2
.rodata 205669 205253 -416 -0.2
bridge-app debug+rpc (read/write) 85864 85768 -96 -0.1
.bss 40624 40528 -96 -0.2
.rodata 141420 141036 -384 -0.3
chip-tool debug .bss 33512 33416 -96 -0.3
.data 1200 1184 -16 -1.3
chip-tool-ipv6only arm64 .bss 51777 51681 -96 -0.2
.data 1224 1216 -8 -0.7
door-lock-app debug (read/write) 112184 112088 -96 -0.1
.bss 43696 43600 -96 -0.2
.rodata 172850 172434 -416 -0.2
lighting-app debug+rpc (read/write) 117464 117368 -96 -0.1
.bss 44672 44576 -96 -0.2
.rodata 166353 165937 -416 -0.3
ota-provider-app debug (read/write) 107928 107832 -96 -0.1
.bss 43648 43552 -96 -0.2
.rodata 158398 157982 -416 -0.3
ota-requestor-app debug (read/write) 109048 108952 -96 -0.1
.bss 43936 43840 -96 -0.2
.rodata 151823 151407 -416 -0.3
shell debug (read/write) 144720 144496 -224 -0.2
.bss 65120 64928 -192 -0.3
.data 848 832 -16 -1.9
.rodata 206674 206258 -416 -0.2
thermostat-no-ble arm64 (read/write) 142273 142209 -64 -0.0
.bss 59201 59105 -96 -0.2
.data 1040 1032 -8 -0.8
.got 4152 4144 -8 -0.2
.rodata 132956 132460 -496 -0.4
tv-app debug (read/write) 141056 140960 -96 -0.1
.bss 58848 58752 -96 -0.2
.rodata 197676 197292 -384 -0.2
mbed all-clusters-app CY8CPROTO_062_4343W+release .bss 190092 190068 -24 -0.0
lighting-app CY8CPROTO_062_4343W+release .bss 182704 182680 -24 -0.0
.data 5632 5624 -8 -0.1
lock-app CY8CPROTO_062_4343W+release .bss 182592 182568 -24 -0.0
.data 5608 5600 -8 -0.1
shell CY8CPROTO_062_4343W+release .bss 179844 179820 -24 -0.0
nrfconnect lighting-app nrf52840dk_nrf52840 bss 123020 122996 -24 -0.0
nrf52840dk_nrf52840+rpc bss 120208 120184 -24 -0.0
nrf52840dongle_nrf52840 bss 124416 124392 -24 -0.0
nrf5340dk_nrf5340_cpuapp bss 119584 119560 -24 -0.0
lock-app nrf52840dk_nrf52840 bss 121400 121376 -24 -0.0
nrf5340dk_nrf5340_cpuapp bss 117992 117968 -24 -0.0
pump-app nrf52840dk_nrf52840 bss 121120 121096 -24 -0.0
pump-controller-app nrf52840dk_nrf52840 bss 121124 121100 -24 -0.0
shell nrf52840dk_nrf52840 bss 112400 112376 -24 -0.0
p6 all-clusters-app default (read/write) 2482336 2482288 -48 -0.0
.bss 119704 119680 -24 -0.0
.text 1440600 1440552 -48 -0.0
light-app default (read/write) 2388664 2388616 -48 -0.0
.bss 109352 109328 -24 -0.0
.data 2528 2520 -8 -0.3
.text 1346928 1346880 -48 -0.0
lock-app default (read/write) 2352120 2352056 -64 -0.0
.bss 109072 109048 -24 -0.0
.data 2488 2480 -8 -0.3
.text 1310384 1310320 -64 -0.0
qpg lighting-app qpg6105+debug (read/write) 146940 146936 -4 -0.0
.bss 90536 90512 -24 -0.0
.data 1112 1108 -4 -0.4
lock-app qpg6105+debug (read/write) 146940 146936 -4 -0.0
.bss 90520 90496 -24 -0.0
.data 1064 1060 -4 -0.4
telink lighting-app tlsr9518adk80d bss 90352 90328 -24 -0.0
Full report (43 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section a08613be 983d6f5 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 606702 607074 372 0.1
.app_xip_area 508132 508552 420 0.1
.bss 81268 81220 -48 -0.1
.data 648 644 -4 -0.6
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 563174 563778 604 0.1
.app_xip_area 466164 466824 660 0.1
.bss 79740 79692 -48 -0.1
.data 612 608 -4 -0.7
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 584190 584546 356 0.1
.app_xip_area 477932 478344 412 0.1
.bss 88660 88612 -48 -0.1
.data 556 552 -4 -0.7
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 906824 907616 792 0.1
(read/write) 129000 128968 -32 -0.0
.bss 126960 126936 -24 -0.0
.data 2036 2032 -4 -0.2
.text 906816 907608 792 0.1
BRD4161A+rpc (read only) 894268 895060 792 0.1
(read/write) 145656 145628 -28 -0.0
.bss 143520 143496 -24 -0.0
.data 2136 2132 -4 -0.2
.text 894260 895052 792 0.1
window-app BRD4161A (read only) 841936 842712 776 0.1
(read/write) 127064 127040 -24 -0.0
.bss 125160 125136 -24 -0.0
.data 1904 1900 -4 -0.2
.text 841928 842704 776 0.1
esp32 all-clusters-app c3devkit (read only) 943304 943900 596 0.1
(read/write) 1400250 1399738 -512 -0.0
.dram0.bss 68024 68000 -24 -0.0
.dram0.data 14276 14268 -8 -0.1
.flash.rodata 199040 198576 -464 -0.2
.flash.text 943304 943900 596 0.1
.iram0.text 62056 62056 0 0.0
m5stack (read only) 990967 991195 228 0.0
(read/write) 465080 464584 -496 -0.1
.dram0.bss 73168 73144 -24 -0.0
.dram0.data 34072 34064 -8 -0.0
.flash.rodata 225712 225248 -464 -0.2
.flash.text 985583 985811 228 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 683560 684224 664 0.1
.bss 78264 78240 -24 -0.0
.data 1908 1904 -4 -0.2
.text 597588 598280 692 0.1
lock k32w061+release (read/write) 688440 689088 648 0.1
.bss 78664 78640 -24 -0.0
.data 1952 1948 -4 -0.2
.text 602024 602700 676 0.1
linux all-clusters-app debug (read only) 2345665 2346377 712 0.0
(read/write) 141696 141600 -96 -0.1
.bss 56224 56128 -96 -0.2
.data 1312 1296 -16 -1.2
.data.rel.ro 78488 78488 0 0.0
.dynamic 592 592 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 205669 205253 -416 -0.2
.text 1977746 1978898 1152 0.1
bridge-app debug+rpc (read only) 1713293 1714021 728 0.0
(read/write) 85864 85768 -96 -0.1
.bss 40624 40528 -96 -0.2
.data 2034 2034 0 0.0
.data.rel.ro 38056 38056 0 0.0
.dynamic 592 592 0 0.0
.got 3976 3976 0 0.0
.init 27 27 0 0.0
.init_array 560 560 0 0.0
.rodata 141420 141036 -384 -0.3
.text 1455349 1456485 1136 0.1
chip-tool debug (read only) 7571909 8229725 657816 8.7
(read/write) 198520 232152 33632 16.9
.bss 33512 33416 -96 -0.3
.data 1200 1184 -16 -1.3
.data.rel.ro 157768 191528 33760 21.4
.dynamic 608 608 0 0.0
.got 4784 4784 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 421397 456309 34912 8.3
.text 6749621 7292773 543152 8.0
chip-tool-ipv6only arm64 (read only) 7478108 8053276 575168 7.7
(read/write) 303409 339377 35968 11.9
.bss 51777 51681 -96 -0.2
.data 1224 1216 -8 -0.7
.data.rel.ro 199520 233784 34264 17.2
.dynamic 560 560 0 0.0
.got 47088 48904 1816 3.9
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 403012 433156 30144 7.5
.text 6435220 6894548 459328 7.1
door-lock-app debug (read only) 1918481 1919193 712 0.0
(read/write) 112184 112088 -96 -0.1
.bss 43696 43600 -96 -0.2
.data 1010 1010 0 0.0
.data.rel.ro 62064 62064 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 172850 172434 -416 -0.2
.text 1597138 1598290 1152 0.1
lighting-app debug+rpc (read only) 2042785 2043497 712 0.0
(read/write) 117464 117368 -96 -0.1
.bss 44672 44576 -96 -0.2
.data 1464 1464 0 0.0
.data.rel.ro 65832 65832 0 0.0
.dynamic 608 608 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 720 720 0 0.0
.rodata 166353 165937 -416 -0.3
.text 1721618 1722770 1152 0.1
ota-provider-app debug (read only) 1858137 1858849 712 0.0
(read/write) 107928 107832 -96 -0.1
.bss 43648 43552 -96 -0.2
.data 1192 1192 0 0.0
.data.rel.ro 57448 57448 0 0.0
.dynamic 608 608 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 624 624 0 0.0
.rodata 158398 157982 -416 -0.3
.text 1549170 1550322 1152 0.1
ota-requestor-app debug (read only) 1852849 1853561 712 0.0
(read/write) 109048 108952 -96 -0.1
.bss 43936 43840 -96 -0.2
.data 1160 1160 0 0.0
.data.rel.ro 58504 58504 0 0.0
.dynamic 592 592 0 0.0
.got 4176 4176 0 0.0
.init 27 27 0 0.0
.init_array 624 624 0 0.0
.rodata 151823 151407 -416 -0.3
.text 1552178 1553330 1152 0.1
shell debug (read only) 2319425 2320137 712 0.0
(read/write) 144720 144496 -224 -0.2
.bss 65120 64928 -192 -0.3
.data 848 832 -16 -1.9
.data.rel.ro 73040 73040 0 0.0
.dynamic 592 592 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 206674 206258 -416 -0.2
.text 1956306 1957458 1152 0.1
thermostat-no-ble arm64 (read only) 2139804 2140156 352 0.0
(read/write) 142273 142209 -64 -0.0
.bss 59201 59105 -96 -0.2
.data 1040 1032 -8 -0.8
.data.rel.ro 74912 74960 48 0.1
.dynamic 560 560 0 0.0
.got 4152 4144 -8 -0.2
.init 24 24 0 0.0
.init_array 328 328 0 0.0
.rodata 132956 132460 -496 -0.4
.text 1788736 1789584 848 0.0
tv-app debug (read only) 2515289 2516033 744 0.0
(read/write) 141056 140960 -96 -0.1
.bss 58848 58752 -96 -0.2
.data 3200 3200 0 0.0
.data.rel.ro 72984 72984 0 0.0
.dynamic 592 592 0 0.0
.got 4528 4528 0 0.0
.init 27 27 0 0.0
.init_array 888 888 0 0.0
.rodata 197676 197292 -384 -0.2
.text 2144674 2145826 1152 0.1
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2396136 2396832 696 0.0
.bss 190092 190068 -24 -0.0
.data 5320 5320 0 0.0
.text 1358736 1359432 696 0.1
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2357760 2358456 696 0.0
.bss 182704 182680 -24 -0.0
.data 5632 5624 -8 -0.1
.text 1320360 1321056 696 0.1
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2321288 2321984 696 0.0
.bss 182592 182568 -24 -0.0
.data 5608 5600 -8 -0.1
.text 1283888 1284584 696 0.1
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139648 1139648 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103032 103032 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2307292 2307988 696 0.0
.bss 179844 179820 -24 -0.0
.data 5424 5424 0 0.0
.text 1269864 1270560 696 0.1
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 1015395 1015947 552 0.1
bss 123020 122996 -24 -0.0
rodata 119416 119528 112 0.1
text 693940 694508 568 0.1
nrf52840dk_nrf52840+rpc (read/write) 984215 984763 548 0.1
bss 120208 120184 -24 -0.0
rodata 110780 110896 116 0.1
text 673552 674120 568 0.1
nrf52840dongle_nrf52840 (read/write) 1031099 1031791 692 0.1
bss 124416 124392 -24 -0.0
rodata 118276 118392 116 0.1
text 698556 699124 568 0.1
nrf5340dk_nrf5340_cpuapp (read/write) 921990 922674 684 0.1
bss 119584 119560 -24 -0.0
rodata 112656 112772 116 0.1
text 608976 609544 568 0.1
lock-app nrf52840dk_nrf52840 (read/write) 945099 945791 692 0.1
bss 121400 121376 -24 -0.0
rodata 108160 108276 116 0.1
text 636968 637536 568 0.1
nrf5340dk_nrf5340_cpuapp (read/write) 852610 853266 656 0.1
bss 117992 117968 -24 -0.0
rodata 101332 101444 112 0.1
text 552776 553344 568 0.1
pigweed-app nrf52840dk_nrf52840 (read/write) 527595 527595 0 0.0
bss 53632 53632 0 0.0
rodata 49976 49976 0 0.0
text 361016 361016 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 944539 945203 664 0.1
bss 121120 121096 -24 -0.0
rodata 107520 107632 112 0.1
text 637228 637796 568 0.1
pump-controller-app nrf52840dk_nrf52840 (read/write) 939863 940551 688 0.1
bss 121124 121100 -24 -0.0
rodata 106812 106924 112 0.1
text 633264 633832 568 0.1
shell nrf52840dk_nrf52840 (read/write) 805927 806223 296 0.0
bss 112400 112376 -24 -0.0
rodata 78812 78948 136 0.2
text 537036 537320 284 0.1
p6 all-clusters-app default (read/write) 2482336 2482288 -48 -0.0
.bss 119704 119680 -24 -0.0
.data 2672 2672 0 0.0
.text 1440600 1440552 -48 -0.0
light-app default (read/write) 2388664 2388616 -48 -0.0
.bss 109352 109328 -24 -0.0
.data 2528 2520 -8 -0.3
.text 1346928 1346880 -48 -0.0
lock-app default (read/write) 2352120 2352056 -64 -0.0
.bss 109072 109048 -24 -0.0
.data 2488 2480 -8 -0.3
.text 1310384 1310320 -64 -0.0
qpg lighting-app qpg6105+debug (read only) 592980 593656 676 0.1
(read/write) 146940 146936 -4 -0.0
.bss 90536 90512 -24 -0.0
.data 1112 1108 -4 -0.4
.text 587660 588336 676 0.1
lock-app qpg6105+debug (read only) 558732 559408 676 0.1
(read/write) 146940 146936 -4 -0.0
.bss 90520 90496 -24 -0.0
.data 1064 1060 -4 -0.4
.text 553412 554088 676 0.1
persistent-storage-app qpg6105+debug (read only) 99520 99520 0 0.0
(read/write) 146940 146940 0 0.0
.bss 24004 24004 0 0.0
.data 176 176 0 0.0
.text 94200 94200 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 874334 874870 536 0.1
bss 90352 90328 -24 -0.0
noinit 37160 37160 0 0.0
text 613082 613516 434 0.1

@jepenven-silabs jepenven-silabs merged commit 4126b1c into project-chip:master Feb 10, 2022
tcarmelveilleux
tcarmelveilleux reviewed Feb 11, 2022
View reviewed changes
Copy link
Contributor

@tcarmelveilleux tcarmelveilleux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tcarmelveilleux tcarmelveilleux tcarmelveilleux left review comments

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@jmartinez-silabs jmartinez-silabs jmartinez-silabs approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

Assignees
No one assigned
Labels
controller examples lib review - approved transport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jepenven-silabs @tcarmelveilleux @bzbarsky-apple @jmartinez-silabs