-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix mac address get for dnssd #15221
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #15221: Size comparison from 6c28ec3 to ec853a2 Increases (18 builds for cyw30739, efr32, esp32, k32w, linux, p6, qpg, telink)
Full report (19 builds for cyw30739, efr32, esp32, k32w, linux, p6, qpg, telink)
|
woody-apple
approved these changes
Feb 15, 2022
PR #15221: Size comparison from 6c28ec3 to 51fa7da Increases above 0.2%:
Increases (13 builds for cyw30739, k32w, linux, p6, qpg, telink)
Full report (14 builds for cyw30739, k32w, linux, p6, qpg, telink)
|
PR #15221: Size comparison from 6c28ec3 to c5ed007 Increases above 0.2%:
Increases (22 builds for cyw30739, efr32, esp32, k32w, linux, mbed, p6, qpg, telink)
Full report (24 builds for cyw30739, efr32, esp32, k32w, linux, mbed, p6, qpg, telink)
|
kkasperczyk-no
approved these changes
Feb 16, 2022
bzbarsky-apple
approved these changes
Feb 16, 2022
tcarmelveilleux
approved these changes
Feb 16, 2022
PR #15221: Size comparison from 4b2bf6a to fd11b72 Increases (29 builds for cyw30739, efr32, k32w, linux, mbed, p6, qpg, telink)
Full report (31 builds for cyw30739, efr32, k32w, linux, mbed, p6, qpg, telink)
|
…e no active IP interface to get a mac from
PR #15221: Size comparison from 4b2bf6a to 7fcf708 Increases above 0.2%:
Increases (40 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Decreases (1 build for telink)
Full report (43 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
jamesluo11
pushed a commit
to jamesluo11/connectedhomeip
that referenced
this pull request
Apr 26, 2022
* Fix mac address get for dnssd * Stop asserting that the primary mac getting returns a default - it should not * remove one more use of the default mac * Use DRBG_get_bytes to get a random mac * Remove the NO_ERROR assumption for getting primary mac. Emulators have no active IP interface to get a mac from
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Linux compiles with Openthread enabled, but if no openthread IP address, the fallback should still be wifi IP (if one exists).
Code before #10222 did this
Change overview
Testing
Manually ran linux all-clusters app and noticed mac is now picked up