New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[gn] Vscode integration. Fixes #1526. #1527

Merged

BroderickCarlin merged 2 commits into project-chip:master from turon:pr/gn/vcode

Jul 10, 2020

Contributor

turon commented Jul 9, 2020

Problem

The new GN build system isn't integrated yet into vscode

Summary of Changes

Add vscode integration

fixes #1526

turon requested review from andy31415, anush-apple, BroderickCarlin, chrisdecenzo, hawk248, jelderton, robszewczyk, saurabhst and woody-apple as code owners

July 9, 2020 08:39

CLAassistant commented Jul 9, 2020 •

edited

Loading

All committers have signed the CLA.

andy31415 approved these changes

View reviewed changes

BroderickCarlin approved these changes

View reviewed changes

woody-apple approved these changes

View reviewed changes

Contributor

woody-apple commented Jul 10, 2020

@turon can you sign the CLA (again) and fix the merge here?


          [gn] Vscode integration. Fixes project-chip#1526.

d9de589

turon force-pushed the pr/gn/vcode branch from 3133342 to d9de589 Compare

July 10, 2020 19:04

restyled-io bot mentioned this pull request

Restyle [gn] Vscode integration. Fixes #1526. #1560

Closed

turon commented

View reviewed changes

gn_build.sh


		_chip_banner "Build: Ninja build"

		time ninja -C "$CHIP_ROOT/out/debug" all check

Contributor Author

turon Jul 10, 2020

Moved the build step to take place after instructions, so the result of last build is easily visible for both command line and in vscode.


          [gn] Fix merge conflict.

a997279

turon force-pushed the pr/gn/vcode branch from 6b20901 to a997279 Compare

July 10, 2020 19:11

BroderickCarlin merged commit 52b6f03 into project-chip:master

github-actions bot commented Jul 10, 2020

Size increase report for "nrf-example-build"

File	Section	File	VM

Full report output

BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-nrf52840-lock-example.out and ./pull_artifact/chip-nrf52840-lock-example.out:

sections,vmsize,filesize

github-actions bot commented Jul 10, 2020

Size increase report for "linux-example-build"

File	Section	File	VM

Full report output

BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-standalone-demo.out and ./pull_artifact/chip-standalone-demo.out:

sections,vmsize,filesize

github-actions bot commented Jul 10, 2020

Size increase report for "esp32-example-build"

File	Section	File	VM

Full report output

BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-wifi-echo.elf and ./pull_artifact/chip-wifi-echo.elf:

sections,vmsize,filesize

mspang added a commit to mspang/connectedhomeip that referenced this pull request


          Fix nRF5 lock app build instructions

85f9c91

After 52b6f03 ("[gn] Vscode integration. Fixes project-chip#1526. (project-chip#1527)")
the args are missing due to being set later in the script. Rearrange
so the correct comment is printed.

mspang mentioned this pull request

Fix nRF5 lock app build instructions #1572

Merged

andy31415 pushed a commit that referenced this pull request


          Fix nRF5 lock app build instructions (#1572)

f305152

After 52b6f03 ("[gn] Vscode integration. Fixes #1526. (#1527)")
the args are missing due to being set later in the script. Rearrange
so the correct comment is printed.

turon deleted the pr/gn/vcode branch

July 14, 2020 21:49

kedars pushed a commit to kedars/connectedhomeip that referenced this pull request


          [gn] Vscode integration. Fixes project-chip#1526. (project-chip#1527)

10a664a

* [gn] Vscode integration. Fixes project-chip#1526.

* [gn] Fix merge conflict.

kedars pushed a commit to kedars/connectedhomeip that referenced this pull request


          Fix nRF5 lock app build instructions (project-chip#1572)

68ae230

After 52b6f03 ("[gn] Vscode integration. Fixes project-chip#1526. (project-chip#1527)")
the args are missing due to being set later in the script. Rearrange
so the correct comment is printed.

kedars pushed a commit to kedars/connectedhomeip that referenced this pull request


          [gn] Vscode integration. Fixes project-chip#1526. (project-chip#1527)

fd6da1d

* [gn] Vscode integration. Fixes project-chip#1526.

* [gn] Fix merge conflict.

kedars pushed a commit to kedars/connectedhomeip that referenced this pull request


          Fix nRF5 lock app build instructions (project-chip#1572)

e7166ab

After 52b6f03 ("[gn] Vscode integration. Fixes project-chip#1526. (project-chip#1527)")
the args are missing due to being set later in the script. Rearrange
so the correct comment is printed.

kedars pushed a commit to kedars/connectedhomeip that referenced this pull request


          [gn] Vscode integration. Fixes project-chip#1526. (project-chip#1527)

2e13e59

* [gn] Vscode integration. Fixes project-chip#1526.

* [gn] Fix merge conflict.

kedars pushed a commit to kedars/connectedhomeip that referenced this pull request


          Fix nRF5 lock app build instructions (project-chip#1572)

7b00302

After 52b6f03 ("[gn] Vscode integration. Fixes project-chip#1526. (project-chip#1527)")
the args are missing due to being set later in the script. Rearrange
so the correct comment is printed.

kedars pushed a commit to kedars/connectedhomeip that referenced this pull request


          [gn] Vscode integration. Fixes project-chip#1526. (project-chip#1527)

ff69591

* [gn] Vscode integration. Fixes project-chip#1526.

* [gn] Fix merge conflict.

kedars pushed a commit to kedars/connectedhomeip that referenced this pull request


          Fix nRF5 lock app build instructions (project-chip#1572)

5144d8f

After 52b6f03 ("[gn] Vscode integration. Fixes project-chip#1526. (project-chip#1527)")
the args are missing due to being set later in the script. Rearrange
so the correct comment is printed.

kedars pushed a commit to kedars/connectedhomeip that referenced this pull request


          [gn] Vscode integration. Fixes project-chip#1526. (project-chip#1527)

5b26501

* [gn] Vscode integration. Fixes project-chip#1526.

* [gn] Fix merge conflict.

kedars pushed a commit to kedars/connectedhomeip that referenced this pull request


          Fix nRF5 lock app build instructions (project-chip#1572)

783dcfe

After 52b6f03 ("[gn] Vscode integration. Fixes project-chip#1526. (project-chip#1527)")
the args are missing due to being set later in the script. Rearrange
so the correct comment is printed.

jmartinez-silabs pushed a commit to SiliconLabs/matter that referenced this pull request


          Pull request project-chip#1527: Updating wifi_sdk to v3.1.3

d1fe8e7

Merge in WMN_TOOLS/matter from feature/updating_wifisdk_to_v3.1.3 to RC_2.3.0-1.3

Squashed commit of the following:

commit 1c75b7c32e2268b340288823c741cc7040b5b6ab
Author: Arun Padakanti <arunkumar.padakanti@silabs.com>
Date:   Thu Feb 1 09:42:36 2024 +0530

    Updated gitmodules as per comments

commit 868b100c9bdba2c0e609a6f705d669f16ae4af13
Author: Arun Padakanti <arunkumar.padakanti@silabs.com>
Date:   Wed Jan 31 20:34:59 2024 +0530

    Updating wifi_sdk to v3.1.3

rcasallas-silabs pushed a commit to rcasallas-silabs/connectedhomeip that referenced this pull request


          Pull request project-chip#1527: Updating wifi_sdk to v3.1.3

b6f8e12

Merge in WMN_TOOLS/matter from feature/updating_wifisdk_to_v3.1.3 to RC_2.3.0-1.3

Squashed commit of the following:

commit 1c75b7c32e2268b340288823c741cc7040b5b6ab
Author: Arun Padakanti <arunkumar.padakanti@silabs.com>
Date:   Thu Feb 1 09:42:36 2024 +0530

    Updated gitmodules as per comments

commit 868b100c9bdba2c0e609a6f705d669f16ae4af13
Author: Arun Padakanti <arunkumar.padakanti@silabs.com>
Date:   Wed Jan 31 20:34:59 2024 +0530

    Updating wifi_sdk to v3.1.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

woody-apple woody-apple approved these changes

BroderickCarlin BroderickCarlin approved these changes

andy31415 andy31415 approved these changes

anush-apple Awaiting requested review from anush-apple

chrisdecenzo Awaiting requested review from chrisdecenzo

hawk248 Awaiting requested review from hawk248

jelderton Awaiting requested review from jelderton

robszewczyk Awaiting requested review from robszewczyk

saurabhst Awaiting requested review from saurabhst

Labels

None yet