-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add lock/unlock calls for efr32 examples #15365
Merged
jmartinez-silabs
merged 11 commits into
project-chip:master
from
mkardous-silabs:fix/sem_lock
Feb 22, 2022
Merged
Add lock/unlock calls for efr32 examples #15365
jmartinez-silabs
merged 11 commits into
project-chip:master
from
mkardous-silabs:fix/sem_lock
Feb 22, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #15365: Size comparison from f2b344c to 9c24c36 Increases (3 builds for efr32)
Full report (43 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
jmartinez-silabs
approved these changes
Feb 18, 2022
bzbarsky-apple
requested changes
Feb 19, 2022
PR #15365: Size comparison from f2b344c to 1a6b41a Increases (9 builds for nrfconnect)
Full report (15 builds for mbed, nrfconnect)
|
woody-apple
approved these changes
Feb 21, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fast tracking platform changes.
jmeg-sfy
reviewed
Feb 22, 2022
jmeg-sfy
approved these changes
Feb 22, 2022
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
ec88b20
to
85becff
Compare
bzbarsky-apple
approved these changes
Feb 22, 2022
PR #15365: Size comparison from cbdecce to 85becff Increases (3 builds for efr32)
Full report (34 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
jmeg-sfy
pushed a commit
that referenced
this pull request
Mar 8, 2022
* add lock/unlock to lighting app * add lock/unlock to light-switch app * add lock/unlock to lock app * Move event loop start for shell app * add lock / unlock to window app * disable lock tracking for ota-requestor-app * PR review comments * Update scheduleWork for light-switch Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * fix task start * align window app tilt and lift * Comment Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Change overview
Testing