Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AccessControl] Add Access Control checks to event management #15376

Merged
merged 8 commits into from
Mar 2, 2022
Merged

[AccessControl] Add Access Control checks to event management #15376

merged 8 commits into from
Mar 2, 2022

Conversation

erjiaqing
Copy link
Contributor

Problem

Fixes #14435

Change overview

  • Add code for checking ACL when fetching events

Testing

@mlepage-google will add test cases and fix potential bugs.

@boring-cyborg boring-cyborg bot added the app label Feb 21, 2022
@github-actions
Copy link

github-actions bot commented Feb 21, 2022 •
edited
Loading

PR #15376: Size comparison from e71be1c to 16ed696

Increases (30 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section e71be1c3 16ed696 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 599502 600222 720 0.1
.app_xip_area 503436 504148 712 0.1
.bss 78764 78772 8 0.0
lock cyw930739m2evb_01 (read/write) 557538 558258 720 0.1
.app_xip_area 463016 463728 712 0.2
.bss 77260 77268 8 0.0
ota-requestor cyw930739m2evb_01 (read/write) 578774 579502 728 0.1
.app_xip_area 474828 475548 720 0.2
.bss 86356 86364 8 0.0
efr32 lighting-app BRD4161A (read only) 916484 917316 832 0.1
(read/write) 129500 129508 8 0.0
.bss 127464 127472 8 0.0
.text 916476 917308 832 0.1
BRD4161A+rpc (read only) 945192 946024 832 0.1
(read/write) 146416 146424 8 0.0
.bss 144240 144248 8 0.0
.text 945184 946016 832 0.1
window-app BRD4161A (read only) 850304 851152 848 0.1
(read/write) 127416 127424 8 0.0
.bss 125512 125520 8 0.0
.text 850296 851144 848 0.1
esp32 all-clusters-app c3devkit (read only) 950408 951200 792 0.1
.dram0.bss 67144 67152 8 0.0
.flash.text 950408 951200 792 0.1
m5stack (read only) 999903 1000563 660 0.1
(read/write) 465560 465568 8 0.0
.dram0.bss 72296 72304 8 0.0
.flash.text 994519 995179 660 0.1
k32w light k32w061+release (read/write) 692692 693420 728 0.1
.bss 78384 78392 8 0.0
.text 606596 607316 720 0.1
lock k32w061+release (read/write) 695256 695984 728 0.1
.bss 78600 78608 8 0.0
.text 608904 609624 720 0.1
linux chip-tool-ipv6only arm64 (read only) 8781772 8785676 3904 0.0
(read/write) 432641 432705 64 0.0
.bss 58977 58993 16 0.0
.data.rel.ro 317776 317824 48 0.0
.rodata 454596 454612 16 0.0
.text 7412804 7416644 3840 0.1
thermostat-no-ble arm64 (read only) 2167740 2171644 3904 0.2
(read/write) 151137 151185 48 0.0
.data.rel.ro 75384 75432 48 0.1
.rodata 134060 134076 16 0.0
.text 1814240 1818080 3840 0.2
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2430660 2431364 704 0.0
.bss 194564 194572 8 0.0
.text 1393232 1393936 704 0.1
lighting-app CY8CPROTO_062_4343W+release (read/write) 2392780 2393484 704 0.0
.bss 188432 188440 8 0.0
.text 1355352 1356056 704 0.1
lock-app CY8CPROTO_062_4343W+release (read/write) 2328224 2328928 704 0.0
.bss 187432 187440 8 0.0
.text 1290824 1291528 704 0.1
shell CY8CPROTO_062_4343W+release (read/write) 2319124 2319828 704 0.0
.bss 185980 185988 8 0.0
.text 1281696 1282400 704 0.1
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 1023579 1024283 704 0.1
bss 123528 123536 8 0.0
text 700044 700756 712 0.1
nrf52840dk_nrf52840+rpc (read/write) 992891 993595 704 0.1
bss 120716 120724 8 0.0
text 679948 680660 712 0.1
nrf52840dongle_nrf52840 (read/write) 1038335 1039039 704 0.1
bss 124748 124756 8 0.0
text 703856 704568 712 0.1
nrf5340dk_nrf5340_cpuapp (read/write) 930190 930894 704 0.1
bss 120088 120096 8 0.0
text 615072 615784 712 0.1
lock-app nrf52840dk_nrf52840 (read/write) 952343 953047 704 0.1
bss 121756 121764 8 0.0
text 642160 642872 712 0.1
nrf5340dk_nrf5340_cpuapp (read/write) 859822 860526 704 0.1
bss 118348 118356 8 0.0
text 557964 558680 716 0.1
pump-app nrf52840dk_nrf52840 (read/write) 950919 951623 704 0.1
bss 121476 121484 8 0.0
text 641980 642692 712 0.1
pump-controller-app nrf52840dk_nrf52840 (read/write) 946867 947587 720 0.1
bss 121480 121488 8 0.0
text 638220 638932 712 0.1
p6 all-clusters-app default (read/write) 2489048 2489880 832 0.0
.bss 122872 122880 8 0.0
.text 1447312 1448144 832 0.1
light-app default (read/write) 2394600 2395448 848 0.0
.bss 113896 113904 8 0.0
.text 1352864 1353712 848 0.1
lock-app default (read/write) 2358176 2359024 848 0.0
.bss 113648 113656 8 0.0
.text 1316440 1317288 848 0.1
qpg lighting-app qpg6105+debug (read only) 600348 601068 720 0.1
.bss 90944 90952 8 0.0
.text 595028 595748 720 0.1
lock-app qpg6105+debug (read only) 566108 566828 720 0.1
.bss 90952 90960 8 0.0
.text 560788 561508 720 0.1
telink lighting-app tlsr9518adk80d (read/write) 878766 879566 800 0.1
bss 87500 87508 8 0.0
text 618928 619716 788 0.1
Full report (34 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section e71be1c3 16ed696 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 599502 600222 720 0.1
.app_xip_area 503436 504148 712 0.1
.bss 78764 78772 8 0.0
.data 644 644 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 557538 558258 720 0.1
.app_xip_area 463016 463728 712 0.2
.bss 77260 77268 8 0.0
.data 608 608 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 578774 579502 728 0.1
.app_xip_area 474828 475548 720 0.2
.bss 86356 86364 8 0.0
.data 552 552 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 916484 917316 832 0.1
(read/write) 129500 129508 8 0.0
.bss 127464 127472 8 0.0
.data 2036 2036 0 0.0
.text 916476 917308 832 0.1
BRD4161A+rpc (read only) 945192 946024 832 0.1
(read/write) 146416 146424 8 0.0
.bss 144240 144248 8 0.0
.data 2176 2176 0 0.0
.text 945184 946016 832 0.1
window-app BRD4161A (read only) 850304 851152 848 0.1
(read/write) 127416 127424 8 0.0
.bss 125512 125520 8 0.0
.data 1904 1904 0 0.0
.text 850296 851144 848 0.1
esp32 all-clusters-app c3devkit (read only) 950408 951200 792 0.1
(read/write) 1400290 1400290 0 0.0
.dram0.bss 67144 67152 8 0.0
.dram0.data 14156 14156 0 0.0
.flash.rodata 200088 200088 0 0.0
.flash.text 950408 951200 792 0.1
.iram0.text 62056 62056 0 0.0
m5stack (read only) 999903 1000563 660 0.1
(read/write) 465560 465568 8 0.0
.dram0.bss 72296 72304 8 0.0
.dram0.data 34064 34064 0 0.0
.flash.rodata 227072 227072 0 0.0
.flash.text 994519 995179 660 0.1
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 692692 693420 728 0.1
.bss 78384 78392 8 0.0
.data 1912 1912 0 0.0
.text 606596 607316 720 0.1
lock k32w061+release (read/write) 695256 695984 728 0.1
.bss 78600 78608 8 0.0
.data 1952 1952 0 0.0
.text 608904 609624 720 0.1
linux chip-tool-ipv6only arm64 (read only) 8781772 8785676 3904 0.0
(read/write) 432641 432705 64 0.0
.bss 58977 58993 16 0.0
.data 1216 1216 0 0.0
.data.rel.ro 317776 317824 48 0.0
.dynamic 560 560 0 0.0
.got 50880 50880 0 0.0
.init 24 24 0 0.0
.init_array 200 200 0 0.0
.rodata 454596 454612 16 0.0
.text 7412804 7416644 3840 0.1
thermostat-no-ble arm64 (read only) 2167740 2171644 3904 0.2
(read/write) 151137 151185 48 0.0
.bss 67521 67521 0 0.0
.data 1032 1032 0 0.0
.data.rel.ro 75384 75432 48 0.1
.dynamic 560 560 0 0.0
.got 4216 4216 0 0.0
.init 24 24 0 0.0
.init_array 336 336 0 0.0
.rodata 134060 134076 16 0.0
.text 1814240 1818080 3840 0.2
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2430660 2431364 704 0.0
.bss 194564 194572 8 0.0
.data 5328 5328 0 0.0
.text 1393232 1393936 704 0.1
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2392780 2393484 704 0.0
.bss 188432 188440 8 0.0
.data 5632 5632 0 0.0
.text 1355352 1356056 704 0.1
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2328224 2328928 704 0.0
.bss 187432 187440 8 0.0
.data 5608 5608 0 0.0
.text 1290824 1291528 704 0.1
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139840 1139840 0 0.0
.bss 11796 11796 0 0.0
.data 4368 4368 0 0.0
.text 103224 103224 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2319124 2319828 704 0.0
.bss 185980 185988 8 0.0
.data 5440 5440 0 0.0
.text 1281696 1282400 704 0.1
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 1023579 1024283 704 0.1
bss 123528 123536 8 0.0
rodata 120984 120984 0 0.0
text 700044 700756 712 0.1
nrf52840dk_nrf52840+rpc (read/write) 992891 993595 704 0.1
bss 120716 120724 8 0.0
rodata 112528 112528 0 0.0
text 679948 680660 712 0.1
nrf52840dongle_nrf52840 (read/write) 1038335 1039039 704 0.1
bss 124748 124756 8 0.0
rodata 119816 119816 0 0.0
text 703856 704568 712 0.1
nrf5340dk_nrf5340_cpuapp (read/write) 930190 930894 704 0.1
bss 120088 120096 8 0.0
rodata 114240 114240 0 0.0
text 615072 615784 712 0.1
lock-app nrf52840dk_nrf52840 (read/write) 952343 953047 704 0.1
bss 121756 121764 8 0.0
rodata 109820 109820 0 0.0
text 642160 642872 712 0.1
nrf5340dk_nrf5340_cpuapp (read/write) 859822 860526 704 0.1
bss 118348 118356 8 0.0
rodata 102992 102992 0 0.0
text 557964 558680 716 0.1
pigweed-app nrf52840dk_nrf52840 (read/write) 527595 527595 0 0.0
bss 53632 53632 0 0.0
rodata 49976 49976 0 0.0
text 361016 361016 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 950919 951623 704 0.1
bss 121476 121484 8 0.0
rodata 108772 108772 0 0.0
text 641980 642692 712 0.1
pump-controller-app nrf52840dk_nrf52840 (read/write) 946867 947587 720 0.1
bss 121480 121488 8 0.0
rodata 108472 108472 0 0.0
text 638220 638932 712 0.1
shell nrf52840dk_nrf52840 (read/write) 811543 811543 0 0.0
bss 113324 113324 0 0.0
rodata 79756 79756 0 0.0
text 540812 540812 0 0.0
p6 all-clusters-app default (read/write) 2489048 2489880 832 0.0
.bss 122872 122880 8 0.0
.data 2672 2672 0 0.0
.text 1447312 1448144 832 0.1
light-app default (read/write) 2394600 2395448 848 0.0
.bss 113896 113904 8 0.0
.data 2528 2528 0 0.0
.text 1352864 1353712 848 0.1
lock-app default (read/write) 2358176 2359024 848 0.0
.bss 113648 113656 8 0.0
.data 2488 2488 0 0.0
.text 1316440 1317288 848 0.1
qpg lighting-app qpg6105+debug (read only) 600348 601068 720 0.1
(read/write) 146940 146940 0 0.0
.bss 90944 90952 8 0.0
.data 1112 1112 0 0.0
.text 595028 595748 720 0.1
lock-app qpg6105+debug (read only) 566108 566828 720 0.1
(read/write) 146940 146940 0 0.0
.bss 90952 90960 8 0.0
.data 1064 1064 0 0.0
.text 560788 561508 720 0.1
persistent-storage-app qpg6105+debug (read only) 99536 99536 0 0.0
(read/write) 146941 146941 0 0.0
.bss 24001 24001 0 0.0
.data 180 180 0 0.0
.text 94216 94216 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 878766 879566 800 0.1
bss 87500 87508 8 0.0
noinit 37160 37160 0 0.0
text 618928 619716 788 0.1

@github-actions
Copy link

github-actions bot commented Feb 21, 2022 •
edited
Loading

PR #15376: Size comparison from e71be1c to abc556f

Increases (30 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section e71be1c3 abc556f change % change
cyw30739 light cyw930739m2evb_01 (read/write) 599502 600222 720 0.1
.app_xip_area 503436 504148 712 0.1
.bss 78764 78772 8 0.0
lock cyw930739m2evb_01 (read/write) 557538 558258 720 0.1
.app_xip_area 463016 463728 712 0.2
.bss 77260 77268 8 0.0
ota-requestor cyw930739m2evb_01 (read/write) 578774 579502 728 0.1
.app_xip_area 474828 475548 720 0.2
.bss 86356 86364 8 0.0
efr32 lighting-app BRD4161A (read only) 916484 917316 832 0.1
(read/write) 129500 129508 8 0.0
.bss 127464 127472 8 0.0
.text 916476 917308 832 0.1
BRD4161A+rpc (read only) 945192 946024 832 0.1
(read/write) 146416 146424 8 0.0
.bss 144240 144248 8 0.0
.text 945184 946016 832 0.1
window-app BRD4161A (read only) 850304 851152 848 0.1
(read/write) 127416 127424 8 0.0
.bss 125512 125520 8 0.0
.text 850296 851144 848 0.1
esp32 all-clusters-app c3devkit (read only) 950408 951200 792 0.1
.dram0.bss 67144 67152 8 0.0
.flash.text 950408 951200 792 0.1
m5stack (read only) 999903 1000563 660 0.1
(read/write) 465560 465568 8 0.0
.dram0.bss 72296 72304 8 0.0
.flash.text 994519 995179 660 0.1
k32w light k32w061+release (read/write) 692692 693420 728 0.1
.bss 78384 78392 8 0.0
.text 606596 607316 720 0.1
lock k32w061+release (read/write) 695256 695984 728 0.1
.bss 78600 78608 8 0.0
.text 608904 609624 720 0.1
linux chip-tool-ipv6only arm64 (read only) 8781772 8785676 3904 0.0
(read/write) 432641 432705 64 0.0
.bss 58977 58993 16 0.0
.data.rel.ro 317776 317824 48 0.0
.rodata 454596 454612 16 0.0
.text 7412804 7416644 3840 0.1
thermostat-no-ble arm64 (read only) 2167740 2171644 3904 0.2
(read/write) 151137 151185 48 0.0
.data.rel.ro 75384 75432 48 0.1
.rodata 134060 134076 16 0.0
.text 1814240 1818080 3840 0.2
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2430660 2431364 704 0.0
.bss 194564 194572 8 0.0
.text 1393232 1393936 704 0.1
lighting-app CY8CPROTO_062_4343W+release (read/write) 2392780 2393484 704 0.0
.bss 188432 188440 8 0.0
.text 1355352 1356056 704 0.1
lock-app CY8CPROTO_062_4343W+release (read/write) 2328224 2328928 704 0.0
.bss 187432 187440 8 0.0
.text 1290824 1291528 704 0.1
shell CY8CPROTO_062_4343W+release (read/write) 2319124 2319828 704 0.0
.bss 185980 185988 8 0.0
.text 1281696 1282400 704 0.1
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 1023579 1024283 704 0.1
bss 123528 123536 8 0.0
text 700044 700756 712 0.1
nrf52840dk_nrf52840+rpc (read/write) 992891 993595 704 0.1
bss 120716 120724 8 0.0
text 679948 680660 712 0.1
nrf52840dongle_nrf52840 (read/write) 1038335 1039039 704 0.1
bss 124748 124756 8 0.0
text 703856 704568 712 0.1
nrf5340dk_nrf5340_cpuapp (read/write) 930190 930894 704 0.1
bss 120088 120096 8 0.0
text 615072 615784 712 0.1
lock-app nrf52840dk_nrf52840 (read/write) 952343 953047 704 0.1
bss 121756 121764 8 0.0
text 642160 642872 712 0.1
nrf5340dk_nrf5340_cpuapp (read/write) 859822 860526 704 0.1
bss 118348 118356 8 0.0
text 557964 558680 716 0.1
pump-app nrf52840dk_nrf52840 (read/write) 950919 951623 704 0.1
bss 121476 121484 8 0.0
text 641980 642692 712 0.1
pump-controller-app nrf52840dk_nrf52840 (read/write) 946867 947587 720 0.1
bss 121480 121488 8 0.0
text 638220 638932 712 0.1
p6 all-clusters-app default (read/write) 2489048 2489880 832 0.0
.bss 122872 122880 8 0.0
.text 1447312 1448144 832 0.1
light-app default (read/write) 2394600 2395448 848 0.0
.bss 113896 113904 8 0.0
.text 1352864 1353712 848 0.1
lock-app default (read/write) 2358176 2359024 848 0.0
.bss 113648 113656 8 0.0
.text 1316440 1317288 848 0.1
qpg lighting-app qpg6105+debug (read only) 600348 601068 720 0.1
.bss 90944 90952 8 0.0
.text 595028 595748 720 0.1
lock-app qpg6105+debug (read only) 566108 566828 720 0.1
.bss 90952 90960 8 0.0
.text 560788 561508 720 0.1
telink lighting-app tlsr9518adk80d (read/write) 878766 879566 800 0.1
bss 87500 87508 8 0.0
text 618928 619716 788 0.1
Full report (34 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section e71be1c3 abc556f change % change
cyw30739 light cyw930739m2evb_01 (read/write) 599502 600222 720 0.1
.app_xip_area 503436 504148 712 0.1
.bss 78764 78772 8 0.0
.data 644 644 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 557538 558258 720 0.1
.app_xip_area 463016 463728 712 0.2
.bss 77260 77268 8 0.0
.data 608 608 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 578774 579502 728 0.1
.app_xip_area 474828 475548 720 0.2
.bss 86356 86364 8 0.0
.data 552 552 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 916484 917316 832 0.1
(read/write) 129500 129508 8 0.0
.bss 127464 127472 8 0.0
.data 2036 2036 0 0.0
.text 916476 917308 832 0.1
BRD4161A+rpc (read only) 945192 946024 832 0.1
(read/write) 146416 146424 8 0.0
.bss 144240 144248 8 0.0
.data 2176 2176 0 0.0
.text 945184 946016 832 0.1
window-app BRD4161A (read only) 850304 851152 848 0.1
(read/write) 127416 127424 8 0.0
.bss 125512 125520 8 0.0
.data 1904 1904 0 0.0
.text 850296 851144 848 0.1
esp32 all-clusters-app c3devkit (read only) 950408 951200 792 0.1
(read/write) 1400290 1400290 0 0.0
.dram0.bss 67144 67152 8 0.0
.dram0.data 14156 14156 0 0.0
.flash.rodata 200088 200088 0 0.0
.flash.text 950408 951200 792 0.1
.iram0.text 62056 62056 0 0.0
m5stack (read only) 999903 1000563 660 0.1
(read/write) 465560 465568 8 0.0
.dram0.bss 72296 72304 8 0.0
.dram0.data 34064 34064 0 0.0
.flash.rodata 227072 227072 0 0.0
.flash.text 994519 995179 660 0.1
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 692692 693420 728 0.1
.bss 78384 78392 8 0.0
.data 1912 1912 0 0.0
.text 606596 607316 720 0.1
lock k32w061+release (read/write) 695256 695984 728 0.1
.bss 78600 78608 8 0.0
.data 1952 1952 0 0.0
.text 608904 609624 720 0.1
linux chip-tool-ipv6only arm64 (read only) 8781772 8785676 3904 0.0
(read/write) 432641 432705 64 0.0
.bss 58977 58993 16 0.0
.data 1216 1216 0 0.0
.data.rel.ro 317776 317824 48 0.0
.dynamic 560 560 0 0.0
.got 50880 50880 0 0.0
.init 24 24 0 0.0
.init_array 200 200 0 0.0
.rodata 454596 454612 16 0.0
.text 7412804 7416644 3840 0.1
thermostat-no-ble arm64 (read only) 2167740 2171644 3904 0.2
(read/write) 151137 151185 48 0.0
.bss 67521 67521 0 0.0
.data 1032 1032 0 0.0
.data.rel.ro 75384 75432 48 0.1
.dynamic 560 560 0 0.0
.got 4216 4216 0 0.0
.init 24 24 0 0.0
.init_array 336 336 0 0.0
.rodata 134060 134076 16 0.0
.text 1814240 1818080 3840 0.2
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2430660 2431364 704 0.0
.bss 194564 194572 8 0.0
.data 5328 5328 0 0.0
.text 1393232 1393936 704 0.1
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2392780 2393484 704 0.0
.bss 188432 188440 8 0.0
.data 5632 5632 0 0.0
.text 1355352 1356056 704 0.1
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2328224 2328928 704 0.0
.bss 187432 187440 8 0.0
.data 5608 5608 0 0.0
.text 1290824 1291528 704 0.1
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139840 1139840 0 0.0
.bss 11796 11796 0 0.0
.data 4368 4368 0 0.0
.text 103224 103224 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2319124 2319828 704 0.0
.bss 185980 185988 8 0.0
.data 5440 5440 0 0.0
.text 1281696 1282400 704 0.1
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 1023579 1024283 704 0.1
bss 123528 123536 8 0.0
rodata 120984 120984 0 0.0
text 700044 700756 712 0.1
nrf52840dk_nrf52840+rpc (read/write) 992891 993595 704 0.1
bss 120716 120724 8 0.0
rodata 112528 112528 0 0.0
text 679948 680660 712 0.1
nrf52840dongle_nrf52840 (read/write) 1038335 1039039 704 0.1
bss 124748 124756 8 0.0
rodata 119816 119816 0 0.0
text 703856 704568 712 0.1
nrf5340dk_nrf5340_cpuapp (read/write) 930190 930894 704 0.1
bss 120088 120096 8 0.0
rodata 114240 114240 0 0.0
text 615072 615784 712 0.1
lock-app nrf52840dk_nrf52840 (read/write) 952343 953047 704 0.1
bss 121756 121764 8 0.0
rodata 109820 109820 0 0.0
text 642160 642872 712 0.1
nrf5340dk_nrf5340_cpuapp (read/write) 859822 860526 704 0.1
bss 118348 118356 8 0.0
rodata 102992 102992 0 0.0
text 557964 558680 716 0.1
pigweed-app nrf52840dk_nrf52840 (read/write) 527595 527595 0 0.0
bss 53632 53632 0 0.0
rodata 49976 49976 0 0.0
text 361016 361016 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 950919 951623 704 0.1
bss 121476 121484 8 0.0
rodata 108772 108772 0 0.0
text 641980 642692 712 0.1
pump-controller-app nrf52840dk_nrf52840 (read/write) 946867 947587 720 0.1
bss 121480 121488 8 0.0
rodata 108472 108472 0 0.0
text 638220 638932 712 0.1
shell nrf52840dk_nrf52840 (read/write) 811543 811543 0 0.0
bss 113324 113324 0 0.0
rodata 79756 79756 0 0.0
text 540812 540812 0 0.0
p6 all-clusters-app default (read/write) 2489048 2489880 832 0.0
.bss 122872 122880 8 0.0
.data 2672 2672 0 0.0
.text 1447312 1448144 832 0.1
light-app default (read/write) 2394600 2395448 848 0.0
.bss 113896 113904 8 0.0
.data 2528 2528 0 0.0
.text 1352864 1353712 848 0.1
lock-app default (read/write) 2358176 2359024 848 0.0
.bss 113648 113656 8 0.0
.data 2488 2488 0 0.0
.text 1316440 1317288 848 0.1
qpg lighting-app qpg6105+debug (read only) 600348 601068 720 0.1
(read/write) 146940 146940 0 0.0
.bss 90944 90952 8 0.0
.data 1112 1112 0 0.0
.text 595028 595748 720 0.1
lock-app qpg6105+debug (read only) 566108 566828 720 0.1
(read/write) 146940 146940 0 0.0
.bss 90952 90960 8 0.0
.data 1064 1064 0 0.0
.text 560788 561508 720 0.1
persistent-storage-app qpg6105+debug (read only) 99536 99536 0 0.0
(read/write) 146941 146941 0 0.0
.bss 24001 24001 0 0.0
.data 180 180 0 0.0
.text 94216 94216 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 878766 879566 800 0.1
bss 87500 87508 8 0.0
noinit 37160 37160 0 0.0
text 618928 619716 788 0.1

bzbarsky-apple
bzbarsky-apple requested changes Feb 22, 2022
View reviewed changes
src/app/EventManagement.cpp Outdated Show resolved Hide resolved
src/app/EventManagement.h Outdated Show resolved Hide resolved
src/app/tests/TestReadInteraction.cpp Outdated Show resolved Hide resolved
src/app/tests/TestReadInteraction.cpp Outdated Show resolved Hide resolved
src/app/tests/TestReadInteraction.cpp Outdated Show resolved Hide resolved
src/controller/TypedReadCallback.h Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Feb 25, 2022 •
edited
Loading

PR #15376: Size comparison from e7484ee to a20b424

Increases above 0.2%:

platform target config section e7484ee a20b424 change % change
linux all-clusters-app debug (read only) 2392241 2397601 5360 0.2
.text 2025682 2030978 5296 0.3
bridge-app debug+rpc (read only) 1718125 1723469 5344 0.3
.text 1461717 1466997 5280 0.4
door-lock-app debug (read only) 1933753 1939113 5360 0.3
.text 1612658 1617954 5296 0.3
lighting-app debug+rpc (read only) 2068617 2073961 5344 0.3
.text 1747954 1753234 5280 0.3
ota-provider-app debug (read only) 1866321 1871665 5344 0.3
.text 1558002 1563282 5280 0.3
ota-requestor-app debug (read only) 1877041 1882369 5328 0.3
.text 1576674 1581970 5296 0.3
shell debug (read only) 2360441 2365753 5312 0.2
.text 2000114 2005394 5280 0.3
tv-app debug (read only) 2587033 2592377 5344 0.2
.text 2215506 2220786 5280 0.2
Increases (26 builds for cyw30739, efr32, k32w, linux, p6, qpg, telink)
platform target config section e7484ee a20b424 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 599238 599934 696 0.1
.app_xip_area 504084 504780 696 0.1
lock cyw930739m2evb_01 (read/write) 557290 557986 696 0.1
.app_xip_area 463672 464368 696 0.2
ota-requestor cyw930739m2evb_01 (read/write) 578006 578702 696 0.1
.app_xip_area 474964 475660 696 0.1
efr32 lighting-app BRD4161A (read only) 916292 917108 816 0.1
.text 916284 917100 816 0.1
BRD4161A+rpc (read only) 946396 947196 800 0.1
.text 946388 947188 800 0.1
lock-app BRD4161A+wf200 (read only) 986028 986844 816 0.1
.text 986020 986836 816 0.1
window-app BRD4161A (read only) 850188 851004 816 0.1
.text 850180 850996 816 0.1
k32w light k32w061+release (read/write) 691776 692480 704 0.1
.text 606580 607284 704 0.1
lock k32w061+release (read/write) 694880 695584 704 0.1
.text 609428 610132 704 0.1
linux all-clusters-app debug (read only) 2392241 2397601 5360 0.2
.rodata 203813 203877 64 0.0
.text 2025682 2030978 5296 0.3
bridge-app debug+rpc (read only) 1718125 1723469 5344 0.3
.rodata 140628 140692 64 0.0
.text 1461717 1466997 5280 0.4
chip-tool debug (read only) 8994701 9000013 5312 0.1
.rodata 480501 480533 32 0.0
.text 7905749 7911029 5280 0.1
chip-tool-ipv6only arm64 (read only) 8749020 8753244 4224 0.0
(read/write) 411601 411665 64 0.0
.bss 58609 58625 16 0.0
.data.rel.ro 296568 296616 48 0.0
.rodata 456644 456660 16 0.0
.text 7427924 7432084 4160 0.1
door-lock-app debug (read only) 1933753 1939113 5360 0.3
.rodata 172636 172700 64 0.0
.text 1612658 1617954 5296 0.3
lighting-app debug+rpc (read only) 2068617 2073961 5344 0.3
.rodata 165233 165297 64 0.0
.text 1747954 1753234 5280 0.3
ota-provider-app debug (read only) 1866321 1871665 5344 0.3
.rodata 157779 157843 64 0.0
.text 1558002 1563282 5280 0.3
ota-requestor-app debug (read only) 1877041 1882369 5328 0.3
.rodata 151556 151588 32 0.0
.text 1576674 1581970 5296 0.3
shell debug (read only) 2360441 2365753 5312 0.2
.rodata 203794 203826 32 0.0
.text 2000114 2005394 5280 0.3
thermostat-no-ble arm64 (read only) 2160964 2165188 4224 0.2
(read/write) 148577 148625 48 0.0
.data.rel.ro 75080 75128 48 0.1
.rodata 132308 132324 16 0.0
.text 1810352 1814512 4160 0.2
tv-app debug (read only) 2587033 2592377 5344 0.2
.rodata 197789 197853 64 0.0
.text 2215506 2220786 5280 0.2
p6 all-clusters-app default (read/write) 2487712 2488512 800 0.0
.text 1445976 1446776 800 0.1
light-app default (read/write) 2394912 2395712 800 0.0
.text 1353176 1353976 800 0.1
lock-app default (read/write) 2358448 2359248 800 0.0
.text 1316712 1317512 800 0.1
qpg lighting-app qpg6105+debug (read only) 600988 601692 704 0.1
.text 595668 596372 704 0.1
lock-app qpg6105+debug (read only) 566764 567468 704 0.1
.text 561444 562148 704 0.1
telink lighting-app tlsr9518adk80d (read/write) 882402 883178 776 0.1
text 623648 624422 774 0.1
Full report (27 builds for cyw30739, efr32, k32w, linux, p6, qpg, telink)
platform target config section e7484ee a20b424 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 599238 599934 696 0.1
.app_xip_area 504084 504780 696 0.1
.bss 77844 77844 0 0.0
.data 652 652 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 557290 557986 696 0.1
.app_xip_area 463672 464368 696 0.2
.bss 76348 76348 0 0.0
.data 616 616 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 578006 578702 696 0.1
.app_xip_area 474964 475660 696 0.1
.bss 85444 85444 0 0.0
.data 560 560 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 916292 917108 816 0.1
(read/write) 128608 128608 0 0.0
.bss 126560 126560 0 0.0
.data 2048 2048 0 0.0
.text 916284 917100 816 0.1
BRD4161A+rpc (read only) 946396 947196 800 0.1
(read/write) 145548 145548 0 0.0
.bss 143336 143336 0 0.0
.data 2212 2212 0 0.0
.text 946388 947188 800 0.1
lock-app BRD4161A+wf200 (read only) 986028 986844 816 0.1
(read/write) 120360 120360 0 0.0
.bss 118436 118436 0 0.0
.data 1924 1924 0 0.0
.text 986020 986836 816 0.1
window-app BRD4161A (read only) 850188 851004 816 0.1
(read/write) 126836 126836 0 0.0
.bss 124920 124920 0 0.0
.data 1916 1916 0 0.0
.text 850180 850996 816 0.1
k32w light k32w061+release (read/write) 691776 692480 704 0.1
.bss 77472 77472 0 0.0
.data 1924 1924 0 0.0
.text 606580 607284 704 0.1
lock k32w061+release (read/write) 694880 695584 704 0.1
.bss 77688 77688 0 0.0
.data 1964 1964 0 0.0
.text 609428 610132 704 0.1
linux all-clusters-app debug (read only) 2392241 2397601 5360 0.2
(read/write) 144688 144688 0 0.0
.bss 59232 59232 0 0.0
.data 1360 1360 0 0.0
.data.rel.ro 78392 78392 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 203813 203877 64 0.0
.text 2025682 2030978 5296 0.3
bridge-app debug+rpc (read only) 1718125 1723469 5344 0.3
(read/write) 92736 92736 0 0.0
.bss 47552 47552 0 0.0
.data 2042 2042 0 0.0
.data.rel.ro 38088 38088 0 0.0
.dynamic 592 592 0 0.0
.got 3912 3912 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 140628 140692 64 0.0
.text 1461717 1466997 5280 0.4
chip-tool debug (read only) 8994701 9000013 5312 0.1
(read/write) 298488 298488 0 0.0
.bss 40384 40384 0 0.0
.data 1164 1164 0 0.0
.data.rel.ro 250872 250872 0 0.0
.dynamic 608 608 0 0.0
.got 4784 4784 0 0.0
.init 27 27 0 0.0
.init_array 624 624 0 0.0
.rodata 480501 480533 32 0.0
.text 7905749 7911029 5280 0.1
chip-tool-ipv6only arm64 (read only) 8749020 8753244 4224 0.0
(read/write) 411601 411665 64 0.0
.bss 58609 58625 16 0.0
.data 1216 1216 0 0.0
.data.rel.ro 296568 296616 48 0.0
.dynamic 560 560 0 0.0
.got 51408 51408 0 0.0
.init 24 24 0 0.0
.init_array 208 208 0 0.0
.rodata 456644 456660 16 0.0
.text 7427924 7432084 4160 0.1
door-lock-app debug (read only) 1933753 1939113 5360 0.3
(read/write) 119128 119128 0 0.0
.bss 50496 50496 0 0.0
.data 1050 1050 0 0.0
.data.rel.ro 62200 62200 0 0.0
.dynamic 592 592 0 0.0
.got 4096 4096 0 0.0
.init 27 27 0 0.0
.init_array 656 656 0 0.0
.rodata 172636 172700 64 0.0
.text 1612658 1617954 5296 0.3
lighting-app debug+rpc (read only) 2068617 2073961 5344 0.3
(read/write) 124488 124488 0 0.0
.bss 51424 51424 0 0.0
.data 1472 1472 0 0.0
.data.rel.ro 66144 66144 0 0.0
.dynamic 608 608 0 0.0
.got 4128 4128 0 0.0
.init 27 27 0 0.0
.init_array 704 704 0 0.0
.rodata 165233 165297 64 0.0
.text 1747954 1753234 5280 0.3
ota-provider-app debug (read only) 1866321 1871665 5344 0.3
(read/write) 114792 114792 0 0.0
.bss 50368 50368 0 0.0
.data 1320 1320 0 0.0
.data.rel.ro 57480 57480 0 0.0
.dynamic 608 608 0 0.0
.got 4352 4352 0 0.0
.init 27 27 0 0.0
.init_array 608 608 0 0.0
.rodata 157779 157843 64 0.0
.text 1558002 1563282 5280 0.3
ota-requestor-app debug (read only) 1877041 1882369 5328 0.3
(read/write) 116560 116560 0 0.0
.bss 51232 51232 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 58744 58744 0 0.0
.dynamic 592 592 0 0.0
.got 4152 4152 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 151556 151588 32 0.0
.text 1576674 1581970 5296 0.3
shell debug (read only) 2360441 2365753 5312 0.2
(read/write) 147168 147168 0 0.0
.bss 67552 67552 0 0.0
.data 864 864 0 0.0
.data.rel.ro 73096 73096 0 0.0
.dynamic 592 592 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 888 888 0 0.0
.rodata 203794 203826 32 0.0
.text 2000114 2005394 5280 0.3
thermostat-no-ble arm64 (read only) 2160964 2165188 4224 0.2
(read/write) 148577 148625 48 0.0
.bss 65265 65265 0 0.0
.data 1056 1056 0 0.0
.data.rel.ro 75080 75128 48 0.1
.dynamic 560 560 0 0.0
.got 4216 4216 0 0.0
.init 24 24 0 0.0
.init_array 352 352 0 0.0
.rodata 132308 132324 16 0.0
.text 1810352 1814512 4160 0.2
tv-app debug (read only) 2587033 2592377 5344 0.2
(read/write) 148624 148624 0 0.0
.bss 65824 65824 0 0.0
.data 3168 3168 0 0.0
.data.rel.ro 73624 73624 0 0.0
.dynamic 592 592 0 0.0
.got 4528 4528 0 0.0
.init 27 27 0 0.0
.init_array 872 872 0 0.0
.rodata 197789 197853 64 0.0
.text 2215506 2220786 5280 0.2
p6 all-clusters-app default (read/write) 2487712 2488512 800 0.0
.bss 118656 118656 0 0.0
.data 2688 2688 0 0.0
.text 1445976 1446776 800 0.1
light-app default (read/write) 2394912 2395712 800 0.0
.bss 112976 112976 0 0.0
.data 2536 2536 0 0.0
.text 1353176 1353976 800 0.1
lock-app default (read/write) 2358448 2359248 800 0.0
.bss 112720 112720 0 0.0
.data 2496 2496 0 0.0
.text 1316712 1317512 800 0.1
qpg lighting-app qpg6105+debug (read only) 600988 601692 704 0.1
(read/write) 146936 146936 0 0.0
.bss 90904 90904 0 0.0
.data 1124 1124 0 0.0
.text 595668 596372 704 0.1
lock-app qpg6105+debug (read only) 566764 567468 704 0.1
(read/write) 146936 146936 0 0.0
.bss 90912 90912 0 0.0
.data 1076 1076 0 0.0
.text 561444 562148 704 0.1
persistent-storage-app qpg6105+debug (read only) 99536 99536 0 0.0
(read/write) 146941 146941 0 0.0
.bss 24001 24001 0 0.0
.data 180 180 0 0.0
.text 94216 94216 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 882402 883178 776 0.1
bss 86336 86336 0 0.0
noinit 37160 37160 0 0.0
text 623648 624422 774 0.1

@mlepage-google
Copy link
Contributor

mlepage-google commented Feb 25, 2022 •
edited
Loading

Terminology wise, please change "ACL check" to "Access Control check" where it occurs. Access can be granted without an ACL (e.g. during commissioning) and involves more than just ACLs. I only actually use the term ACL (more specifically, ACL entry) for the data thing that is used as part of those checks. Thanks.

@erjiaqing erjiaqing changed the title [ACL] Add ACL checks to event management [ACL] Add Access Control checks to event management Feb 28, 2022
@github-actions
Copy link

github-actions bot commented Feb 28, 2022 •
edited
Loading

PR #15376: Size comparison from 4668421 to ab1082a

Increases (29 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 4668421 ab1082a change % change
cyw30739 light cyw930739m2evb_01 (read/write) 599542 600246 704 0.1
.app_xip_area 504388 505092 704 0.1
lock cyw930739m2evb_01 (read/write) 557614 558318 704 0.1
.app_xip_area 463996 464700 704 0.2
ota-requestor cyw930739m2evb_01 (read/write) 578138 578842 704 0.1
.app_xip_area 475088 475792 704 0.1
efr32 lighting-app BRD4161A (read only) 916516 917316 800 0.1
.text 916508 917308 800 0.1
BRD4161A+rpc (read only) 946604 947420 816 0.1
.text 946596 947412 816 0.1
lock-app BRD4161A+wf200 (read only) 986436 987252 816 0.1
.text 986428 987244 816 0.1
window-app BRD4161A (read only) 850596 851412 816 0.1
.text 850588 851404 816 0.1
esp32 all-clusters-app c3devkit (read only) 956534 957312 778 0.1
.flash.text 956534 957312 778 0.1
m5stack (read only) 1004671 1005511 840 0.1
.flash.text 999287 1000127 840 0.1
k32w light k32w061+release (read/write) 691904 692608 704 0.1
.text 606700 607404 704 0.1
lock k32w061+release (read/write) 695176 695880 704 0.1
.text 609724 610428 704 0.1
linux chip-tool-ipv6only arm64 (read only) 8757372 8761596 4224 0.0
(read/write) 412049 412113 64 0.0
.bss 58673 58689 16 0.0
.data.rel.ro 296840 296888 48 0.0
.rodata 456996 457012 16 0.0
.text 7435092 7439252 4160 0.1
thermostat-no-ble arm64 (read only) 2162916 2167140 4224 0.2
(read/write) 148577 148641 64 0.0
.bss 65265 65281 16 0.0
.data.rel.ro 75080 75128 48 0.1
.rodata 132964 132980 16 0.0
.text 1811648 1815808 4160 0.2
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2350140 2350844 704 0.0
.text 1312740 1313444 704 0.1
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1038907 1039611 704 0.1
text 700036 700740 704 0.1
lighting-app nrf52840dk_nrf52840 (read/write) 1002695 1003399 704 0.1
text 686984 687688 704 0.1
nrf52840dk_nrf52840+rpc (read/write) 969007 969711 704 0.1
text 664208 664912 704 0.1
nrf52840dongle_nrf52840 (read/write) 1018207 1018911 704 0.1
text 691124 691828 704 0.1
nrf5340dk_nrf5340_cpuapp (read/write) 905538 906242 704 0.1
text 596696 597400 704 0.1
lock-app nrf52840dk_nrf52840 (read/write) 931223 931927 704 0.1
text 628904 629608 704 0.1
nrf5340dk_nrf5340_cpuapp (read/write) 834846 835550 704 0.1
text 539380 540084 704 0.1
pump-app nrf52840dk_nrf52840 (read/write) 929467 930171 704 0.1
text 628332 629036 704 0.1
pump-controller-app nrf52840dk_nrf52840 (read/write) 925443 926147 704 0.1
text 624588 625292 704 0.1
p6 all-clusters-app default (read/write) 2488104 2488904 800 0.0
.text 1446368 1447168 800 0.1
light-app default (read/write) 2395304 2396104 800 0.0
.text 1353568 1354368 800 0.1
lock-app default (read/write) 2358880 2359680 800 0.0
.text 1317144 1317944 800 0.1
qpg lighting-app qpg6105+debug (read only) 601168 601872 704 0.1
.text 595848 596552 704 0.1
lock-app qpg6105+debug (read only) 566964 567668 704 0.1
.text 561644 562348 704 0.1
telink lighting-app tlsr9518adk80d (read/write) 883086 883854 768 0.1
text 623942 624716 774 0.1
Full report (32 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 4668421 ab1082a change % change
cyw30739 light cyw930739m2evb_01 (read/write) 599542 600246 704 0.1
.app_xip_area 504388 505092 704 0.1
.bss 77844 77844 0 0.0
.data 652 652 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 557614 558318 704 0.1
.app_xip_area 463996 464700 704 0.2
.bss 76348 76348 0 0.0
.data 616 616 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 578138 578842 704 0.1
.app_xip_area 475088 475792 704 0.1
.bss 85452 85452 0 0.0
.data 560 560 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 916516 917316 800 0.1
(read/write) 128608 128608 0 0.0
.bss 126560 126560 0 0.0
.data 2048 2048 0 0.0
.text 916508 917308 800 0.1
BRD4161A+rpc (read only) 946604 947420 816 0.1
(read/write) 145548 145548 0 0.0
.bss 143336 143336 0 0.0
.data 2212 2212 0 0.0
.text 946596 947412 816 0.1
lock-app BRD4161A+wf200 (read only) 986436 987252 816 0.1
(read/write) 120360 120360 0 0.0
.bss 118436 118436 0 0.0
.data 1924 1924 0 0.0
.text 986428 987244 816 0.1
window-app BRD4161A (read only) 850596 851412 816 0.1
(read/write) 126844 126844 0 0.0
.bss 124928 124928 0 0.0
.data 1916 1916 0 0.0
.text 850588 851404 816 0.1
esp32 all-clusters-app c3devkit (read only) 956534 957312 778 0.1
(read/write) 1392986 1392986 0 0.0
.dram0.bss 62592 62592 0 0.0
.dram0.data 14228 14228 0 0.0
.flash.rodata 197248 197248 0 0.0
.flash.text 956534 957312 778 0.1
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1004671 1005511 840 0.1
(read/write) 458264 458264 0 0.0
.dram0.bss 68096 68096 0 0.0
.dram0.data 34072 34072 0 0.0
.flash.rodata 224600 224600 0 0.0
.flash.text 999287 1000127 840 0.1
.iram0.text 122767 122767 0 0.0
k32w light k32w061+release (read/write) 691904 692608 704 0.1
.bss 77480 77480 0 0.0
.data 1924 1924 0 0.0
.text 606700 607404 704 0.1
lock k32w061+release (read/write) 695176 695880 704 0.1
.bss 77688 77688 0 0.0
.data 1964 1964 0 0.0
.text 609724 610428 704 0.1
linux chip-tool-ipv6only arm64 (read only) 8757372 8761596 4224 0.0
(read/write) 412049 412113 64 0.0
.bss 58673 58689 16 0.0
.data 1216 1216 0 0.0
.data.rel.ro 296840 296888 48 0.0
.dynamic 560 560 0 0.0
.got 51512 51512 0 0.0
.init 24 24 0 0.0
.init_array 208 208 0 0.0
.rodata 456996 457012 16 0.0
.text 7435092 7439252 4160 0.1
thermostat-no-ble arm64 (read only) 2162916 2167140 4224 0.2
(read/write) 148577 148641 64 0.0
.bss 65265 65281 16 0.0
.data 1056 1056 0 0.0
.data.rel.ro 75080 75128 48 0.1
.dynamic 560 560 0 0.0
.got 4216 4216 0 0.0
.init 24 24 0 0.0
.init_array 352 352 0 0.0
.rodata 132964 132980 16 0.0
.text 1811648 1815808 4160 0.2
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2350140 2350844 704 0.0
.bss 187092 187092 0 0.0
.data 5776 5776 0 0.0
.text 1312740 1313444 704 0.1
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1038907 1039611 704 0.1
bss 125756 125756 0 0.0
rodata 135900 135900 0 0.0
text 700036 700740 704 0.1
lighting-app nrf52840dk_nrf52840 (read/write) 1002695 1003399 704 0.1
bss 122080 122080 0 0.0
rodata 116144 116144 0 0.0
text 686984 687688 704 0.1
nrf52840dk_nrf52840+rpc (read/write) 969007 969711 704 0.1
bss 119164 119164 0 0.0
rodata 107520 107520 0 0.0
text 664208 664912 704 0.1
nrf52840dongle_nrf52840 (read/write) 1018207 1018911 704 0.1
bss 123112 123112 0 0.0
rodata 115828 115828 0 0.0
text 691124 691828 704 0.1
nrf5340dk_nrf5340_cpuapp (read/write) 905538 906242 704 0.1
bss 119368 119368 0 0.0
rodata 108256 108256 0 0.0
text 596696 597400 704 0.1
lock-app nrf52840dk_nrf52840 (read/write) 931223 931927 704 0.1
bss 120280 120280 0 0.0
rodata 104976 104976 0 0.0
text 628904 629608 704 0.1
nrf5340dk_nrf5340_cpuapp (read/write) 834846 835550 704 0.1
bss 117600 117600 0 0.0
rodata 97004 97004 0 0.0
text 539380 540084 704 0.1
pigweed-app nrf52840dk_nrf52840 (read/write) 501603 501603 0 0.0
bss 52584 52584 0 0.0
rodata 44500 44500 0 0.0
text 342712 342712 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 929467 930171 704 0.1
bss 120012 120012 0 0.0
rodata 103956 103956 0 0.0
text 628332 629036 704 0.1
pump-controller-app nrf52840dk_nrf52840 (read/write) 925443 926147 704 0.1
bss 120016 120016 0 0.0
rodata 103652 103652 0 0.0
text 624588 625292 704 0.1
shell nrf52840dk_nrf52840 (read/write) 788811 788811 0 0.0
bss 112360 112360 0 0.0
rodata 74836 74836 0 0.0
text 525504 525504 0 0.0
p6 all-clusters-app default (read/write) 2488104 2488904 800 0.0
.bss 118664 118664 0 0.0
.data 2688 2688 0 0.0
.text 1446368 1447168 800 0.1
light-app default (read/write) 2395304 2396104 800 0.0
.bss 112984 112984 0 0.0
.data 2536 2536 0 0.0
.text 1353568 1354368 800 0.1
lock-app default (read/write) 2358880 2359680 800 0.0
.bss 112728 112728 0 0.0
.data 2496 2496 0 0.0
.text 1317144 1317944 800 0.1
qpg lighting-app qpg6105+debug (read only) 601168 601872 704 0.1
(read/write) 146936 146936 0 0.0
.bss 90904 90904 0 0.0
.data 1124 1124 0 0.0
.text 595848 596552 704 0.1
lock-app qpg6105+debug (read only) 566964 567668 704 0.1
(read/write) 146936 146936 0 0.0
.bss 90912 90912 0 0.0
.data 1076 1076 0 0.0
.text 561644 562348 704 0.1
persistent-storage-app qpg6105+debug (read only) 99536 99536 0 0.0
(read/write) 146941 146941 0 0.0
.bss 24001 24001 0 0.0
.data 180 180 0 0.0
.text 94216 94216 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 883086 883854 768 0.1
bss 86336 86336 0 0.0
noinit 37160 37160 0 0.0
text 623942 624716 774 0.1

@erjiaqing erjiaqing requested a review from bzbarsky-apple March 1, 2022 02:00
bzbarsky-apple
bzbarsky-apple reviewed Mar 1, 2022
View reviewed changes
src/app/EventManagement.cpp Outdated Show resolved Hide resolved
src/app/EventManagement.h Outdated Show resolved Hide resolved
src/app/EventManagement.h Show resolved Hide resolved
src/app/EventManagement.h Show resolved Hide resolved
src/controller/TypedReadCallback.h Outdated Show resolved Hide resolved
src/app/tests/TestReadInteraction.cpp Outdated Show resolved Hide resolved
@erjiaqing erjiaqing changed the title [ACL] Add Access Control checks to event management [AccessControl] Add Access Control checks to event management Mar 2, 2022
@erjiaqing erjiaqing requested a review from bzbarsky-apple March 2, 2022 07:02
@erjiaqing erjiaqing mentioned this pull request Mar 2, 2022
Open
@woody-apple woody-apple merged commit 1ccc2af into project-chip:master Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mlepage-google mlepage-google mlepage-google left review comments

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@woody-apple woody-apple woody-apple approved these changes

@yunhanw-google yunhanw-google yunhanw-google approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@msandstedt msandstedt Awaiting requested review from msandstedt

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

Assignees
No one assigned
Labels
app controller review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add access control check for IM read events
5 participants
@erjiaqing @mlepage-google @yunhanw-google @woody-apple @bzbarsky-apple