-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Enable test discovery again #15452
Merged
bzbarsky-apple
merged 2 commits into
project-chip:master
from
vivien-apple:CI_EnableTestDiscoveryAgain
Feb 24, 2022
Merged
[CI] Enable test discovery again #15452
bzbarsky-apple
merged 2 commits into
project-chip:master
from
vivien-apple:CI_EnableTestDiscoveryAgain
Feb 24, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
austinh0,
balducci-apple,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
erjiaqing,
franck-apple,
gjc13,
hawk248,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
kpschoedel,
lazarkov and
LuDuda
February 23, 2022 11:56
pullapprove
bot
requested review from
mlepage-google,
msandstedt,
mspang,
robszewczyk,
sagar-apple,
saurabhst,
selissia,
tecimovic,
vijs,
wbschiller,
woody-apple,
xylophone21 and
yufengwangca
February 23, 2022 11:56
vivien-apple
changed the title
Ci enable test discovery again
[CI] Enable test discovery again
Feb 23, 2022
PR #15452: Size comparison from ca38f0b to 8ef8b04 Decreases (2 builds for linux)
Full report (43 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
andy31415
approved these changes
Feb 23, 2022
|
Test Suites is green (again), I will re-run it to make sure it stays green. |
vivien-apple
force-pushed
the
CI_EnableTestDiscoveryAgain
branch
from
February 23, 2022 17:46
8ef8b04
to
0397af6
Compare
PR #15452: Size comparison from 70ae428 to 0397af6 Decreases (2 builds for linux)
Full report (43 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
bzbarsky-apple
approved these changes
Feb 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
This PR tries to moves back
TestDiscovery
to the list of tests that are automatically runs on CI now that #15411 has landed and it should limit the scope of the mdns advertisements.Change overview
TestDiscovery
to the list of tests automatically runnedTestDiscovery
to not wait for the device advertisement itself before browsing, that should makes it clearer if Add --interface-id option to examples/platform/Linux #15411 works properly or not.Testing
TestDiscovery
will run automatically .