Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore forcing of lists to be external storage. #15502

Merged
merged 1 commit into from
Feb 24, 2022
Merged

Restore forcing of lists to be external storage. #15502

merged 1 commit into from
Feb 24, 2022

Conversation

bzbarsky-apple
Copy link
Contributor

#13609 had a bad
merge and ended up reverting part of
#13846.

This just restores the reverted bits, so we go back to forcing lists
to be external storage.

Problem

See above.

Change overview

See above.

Testing

Looked at resulting codegen changes. Should be no behavior changes, except with less memory use.

@bzbarsky-apple
Restore forcing of lists to be external storage.
8dfa648 
project-chip#13609 had a bad
merge and ended up reverting part of
project-chip#13846.

This just restores the reverted bits, so we go back to forcing lists
to be external storage.
@boring-cyborg boring-cyborg bot added the app label Feb 24, 2022
@github-actions
Copy link

github-actions bot commented Feb 24, 2022 •
edited
Loading

PR #15502: Size comparison from f2c450c to 8dfa648

Decreases (38 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section f2c450c 8dfa648 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 599062 599034 -28 -0.0
.app_xip_area 503876 503864 -12 -0.0
.bss 77876 77860 -16 -0.0
lock cyw930739m2evb_01 (read/write) 557114 557094 -20 -0.0
.app_xip_area 463472 463460 -12 -0.0
.bss 76372 76364 -8 -0.0
ota-requestor cyw930739m2evb_01 (read/write) 577838 577818 -20 -0.0
.app_xip_area 474764 474752 -12 -0.0
.bss 85476 85468 -8 -0.0
efr32 lighting-app BRD4161A (read only) 916024 916016 -8 -0.0
(read/write) 128640 128624 -16 -0.0
.bss 126592 126576 -16 -0.0
.text 916016 916008 -8 -0.0
BRD4161A+rpc (read only) 944716 944700 -16 -0.0
(read/write) 145556 145540 -16 -0.0
.bss 143368 143352 -16 -0.0
.text 944708 944692 -16 -0.0
lock-app BRD4161A+wf200 (read only) 985968 985960 -8 -0.0
(read/write) 121020 121012 -8 -0.0
.bss 119092 119084 -8 -0.0
.text 985960 985952 -8 -0.0
window-app BRD4161A (read only) 850288 850264 -24 -0.0
(read/write) 126544 126528 -16 -0.0
.bss 124624 124608 -16 -0.0
.text 850280 850256 -24 -0.0
esp32 all-clusters-app c3devkit (read/write) 1399602 1393442 -6160 -0.4
.dram0.bss 66672 63592 -3080 -4.6
.flash.rodata 199864 196776 -3088 -1.5
m5stack (read/write) 465104 458928 -6176 -1.3
.dram0.bss 71824 68736 -3088 -4.3
.flash.rodata 227080 223992 -3088 -1.4
k32w light k32w061+release (read/write) 691628 691600 -28 -0.0
.bss 77512 77496 -16 -0.0
.text 606392 606380 -12 -0.0
lock k32w061+release (read/write) 694716 694696 -20 -0.0
.bss 77712 77704 -8 -0.0
.text 609240 609228 -12 -0.0
linux all-clusters-app debug (read only) 2395457 2392097 -3360 -0.1
(read/write) 148400 145328 -3072 -2.1
.bss 62944 59872 -3072 -4.9
.rodata 206629 203557 -3072 -1.5
bridge-app debug+rpc (read only) 1718237 1717933 -304 -0.0
(read/write) 93664 93408 -256 -0.3
.bss 48480 48224 -256 -0.5
.rodata 140660 140404 -256 -0.2
door-lock-app debug (read only) 1933649 1933625 -24 -0.0
lighting-app debug+rpc (read only) 2063305 2063281 -24 -0.0
(read/write) 124680 124648 -32 -0.0
.bss 52128 52096 -32 -0.1
ota-provider-app debug (read only) 1865777 1865721 -56 -0.0
(read/write) 115464 115432 -32 -0.0
.bss 51040 51008 -32 -0.1
.rodata 157331 157299 -32 -0.0
ota-requestor-app debug (read only) 1876985 1876929 -56 -0.0
.rodata 151364 151332 -32 -0.0
shell debug (read only) 2363705 2360345 -3360 -0.1
(read/write) 150912 147840 -3072 -2.0
.bss 71296 68224 -3072 -4.3
.rodata 206674 203602 -3072 -1.5
thermostat-no-ble arm64 (read only) 2161588 2160996 -592 -0.0
(read/write) 149745 149217 -528 -0.4
.bss 66433 65905 -528 -0.8
.rodata 132708 132180 -528 -0.4
tv-app debug (read only) 2589617 2586681 -2936 -0.1
(read/write) 151920 149296 -2624 -1.7
.bss 69120 66496 -2624 -3.8
.rodata 200221 197597 -2624 -1.3
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2452552 2449472 -3080 -0.1
.bss 194752 191664 -3088 -1.6
.text 1415124 1412044 -3080 -0.2
lighting-app CY8CPROTO_062_4343W+release (read/write) 2413864 2413856 -8 -0.0
.bss 188852 188836 -16 -0.0
.text 1376436 1376428 -8 -0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2349620 2349612 -8 -0.0
.bss 187756 187740 -16 -0.0
.text 1312220 1312212 -8 -0.0
shell CY8CPROTO_062_4343W+release (read/write) 2339992 2339976 -16 -0.0
.bss 186392 186384 -8 -0.0
.text 1302564 1302548 -16 -0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 1001503 1001459 -44 -0.0
bss 122092 122080 -12 -0.0
rodata 115752 115740 -12 -0.0
nrf52840dk_nrf52840+rpc (read/write) 967031 966987 -44 -0.0
bss 119176 119164 -12 -0.0
rodata 106856 106844 -12 -0.0
nrf52840dongle_nrf52840 (read/write) 1017503 1017459 -44 -0.0
bss 123140 123128 -12 -0.0
rodata 115396 115384 -12 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 904318 904306 -12 -0.0
bss 119380 119368 -12 -0.0
rodata 107868 107856 -12 -0.0
lock-app nrf52840dk_nrf52840 (read/write) 930499 930487 -12 -0.0
bss 120308 120296 -12 -0.0
rodata 104540 104528 -12 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 834126 834114 -12 -0.0
bss 117628 117616 -12 -0.0
rodata 96572 96560 -12 -0.0
pump-app nrf52840dk_nrf52840 (read/write) 928759 928715 -44 -0.0
bss 120040 120028 -12 -0.0
rodata 103520 103508 -12 -0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 924719 924675 -44 -0.0
bss 120044 120032 -12 -0.0
rodata 103216 103204 -12 -0.0
p6 all-clusters-app default (read/write) 2490728 2487640 -3088 -0.1
.bss 122392 119312 -3080 -2.5
.text 1448992 1445904 -3088 -0.2
light-app default (read/write) 2394856 2394840 -16 -0.0
.bss 113640 113632 -8 -0.0
.text 1353120 1353104 -16 -0.0
lock-app default (read/write) 2358392 2358376 -16 -0.0
.bss 113392 113376 -16 -0.0
.text 1316656 1316640 -16 -0.0
qpg lighting-app qpg6105+debug (read only) 600752 600740 -12 -0.0
.bss 90928 90920 -8 -0.0
.text 595432 595420 -12 -0.0
lock-app qpg6105+debug (read only) 566536 566524 -12 -0.0
.bss 90936 90928 -8 -0.0
.text 561216 561204 -12 -0.0
telink lighting-app tlsr9518adk80d (read/write) 882206 882178 -28 -0.0
bss 86364 86352 -12 -0.0
Full report (44 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section f2c450c 8dfa648 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 599062 599034 -28 -0.0
.app_xip_area 503876 503864 -12 -0.0
.bss 77876 77860 -16 -0.0
.data 652 652 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 557114 557094 -20 -0.0
.app_xip_area 463472 463460 -12 -0.0
.bss 76372 76364 -8 -0.0
.data 616 616 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 577838 577818 -20 -0.0
.app_xip_area 474764 474752 -12 -0.0
.bss 85476 85468 -8 -0.0
.data 560 560 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 916024 916016 -8 -0.0
(read/write) 128640 128624 -16 -0.0
.bss 126592 126576 -16 -0.0
.data 2048 2048 0 0.0
.text 916016 916008 -8 -0.0
BRD4161A+rpc (read only) 944716 944700 -16 -0.0
(read/write) 145556 145540 -16 -0.0
.bss 143368 143352 -16 -0.0
.data 2188 2188 0 0.0
.text 944708 944692 -16 -0.0
lock-app BRD4161A+wf200 (read only) 985968 985960 -8 -0.0
(read/write) 121020 121012 -8 -0.0
.bss 119092 119084 -8 -0.0
.data 1924 1924 0 0.0
.text 985960 985952 -8 -0.0
window-app BRD4161A (read only) 850288 850264 -24 -0.0
(read/write) 126544 126528 -16 -0.0
.bss 124624 124608 -16 -0.0
.data 1916 1916 0 0.0
.text 850280 850256 -24 -0.0
esp32 all-clusters-app c3devkit (read only) 952148 952148 0 0.0
(read/write) 1399602 1393442 -6160 -0.4
.dram0.bss 66672 63592 -3080 -4.6
.dram0.data 14172 14172 0 0.0
.flash.rodata 199864 196776 -3088 -1.5
.flash.text 952148 952148 0 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 1002271 1002271 0 0.0
(read/write) 465104 458928 -6176 -1.3
.dram0.bss 71824 68736 -3088 -4.3
.dram0.data 34072 34072 0 0.0
.flash.rodata 227080 223992 -3088 -1.4
.flash.text 996887 996887 0 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 691628 691600 -28 -0.0
.bss 77512 77496 -16 -0.0
.data 1924 1924 0 0.0
.text 606392 606380 -12 -0.0
lock k32w061+release (read/write) 694716 694696 -20 -0.0
.bss 77712 77704 -8 -0.0
.data 1964 1964 0 0.0
.text 609240 609228 -12 -0.0
linux all-clusters-app debug (read only) 2395457 2392097 -3360 -0.1
(read/write) 148400 145328 -3072 -2.1
.bss 62944 59872 -3072 -4.9
.data 1360 1360 0 0.0
.data.rel.ro 78392 78392 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 206629 203557 -3072 -1.5
.text 2025794 2025794 0 0.0
bridge-app debug+rpc (read only) 1718237 1717933 -304 -0.0
(read/write) 93664 93408 -256 -0.3
.bss 48480 48224 -256 -0.5
.data 2042 2042 0 0.0
.data.rel.ro 38088 38088 0 0.0
.dynamic 592 592 0 0.0
.got 3912 3912 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 140660 140404 -256 -0.2
.text 1461749 1461749 0 0.0
chip-tool debug (read only) 8993757 8993757 0 0.0
(read/write) 299128 299128 0 0.0
.bss 41024 41024 0 0.0
.data 1164 1164 0 0.0
.data.rel.ro 250872 250872 0 0.0
.dynamic 608 608 0 0.0
.got 4784 4784 0 0.0
.init 27 27 0 0.0
.init_array 624 624 0 0.0
.rodata 480373 480373 0 0.0
.text 7904933 7904933 0 0.0
chip-tool-ipv6only arm64 (read only) 8748292 8748292 0 0.0
(read/write) 412241 412241 0 0.0
.bss 59265 59265 0 0.0
.data 1216 1216 0 0.0
.data.rel.ro 296568 296568 0 0.0
.dynamic 560 560 0 0.0
.got 51392 51392 0 0.0
.init 24 24 0 0.0
.init_array 208 208 0 0.0
.rodata 456668 456668 0 0.0
.text 7427220 7427220 0 0.0
door-lock-app debug (read only) 1933649 1933625 -24 -0.0
(read/write) 119800 119800 0 0.0
.bss 51168 51168 0 0.0
.data 1050 1050 0 0.0
.data.rel.ro 62200 62200 0 0.0
.dynamic 592 592 0 0.0
.got 4096 4096 0 0.0
.init 27 27 0 0.0
.init_array 656 656 0 0.0
.rodata 172412 172412 0 0.0
.text 1612754 1612754 0 0.0
lighting-app debug+rpc (read only) 2063305 2063281 -24 -0.0
(read/write) 124680 124648 -32 -0.0
.bss 52128 52096 -32 -0.1
.data 1408 1408 0 0.0
.data.rel.ro 65696 65696 0 0.0
.dynamic 608 608 0 0.0
.got 4128 4128 0 0.0
.init 27 27 0 0.0
.init_array 704 704 0 0.0
.rodata 164945 164945 0 0.0
.text 1743746 1743746 0 0.0
ota-provider-app debug (read only) 1865777 1865721 -56 -0.0
(read/write) 115464 115432 -32 -0.0
.bss 51040 51008 -32 -0.1
.data 1320 1320 0 0.0
.data.rel.ro 57480 57480 0 0.0
.dynamic 608 608 0 0.0
.got 4352 4352 0 0.0
.init 27 27 0 0.0
.init_array 608 608 0 0.0
.rodata 157331 157299 -32 -0.0
.text 1557906 1557906 0 0.0
ota-requestor-app debug (read only) 1876985 1876929 -56 -0.0
(read/write) 117200 117200 0 0.0
.bss 51872 51872 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 58744 58744 0 0.0
.dynamic 592 592 0 0.0
.got 4152 4152 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 151364 151332 -32 -0.0
.text 1576786 1576786 0 0.0
shell debug (read only) 2363705 2360345 -3360 -0.1
(read/write) 150912 147840 -3072 -2.0
.bss 71296 68224 -3072 -4.3
.data 864 864 0 0.0
.data.rel.ro 73096 73096 0 0.0
.dynamic 592 592 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 888 888 0 0.0
.rodata 206674 203602 -3072 -1.5
.text 2000210 2000210 0 0.0
thermostat-no-ble arm64 (read only) 2161588 2160996 -592 -0.0
(read/write) 149745 149217 -528 -0.4
.bss 66433 65905 -528 -0.8
.data 1056 1056 0 0.0
.data.rel.ro 75080 75080 0 0.0
.dynamic 560 560 0 0.0
.got 4216 4216 0 0.0
.init 24 24 0 0.0
.init_array 352 352 0 0.0
.rodata 132708 132180 -528 -0.4
.text 1810512 1810512 0 0.0
tv-app debug (read only) 2589617 2586681 -2936 -0.1
(read/write) 151920 149296 -2624 -1.7
.bss 69120 66496 -2624 -3.8
.data 3168 3168 0 0.0
.data.rel.ro 73624 73624 0 0.0
.dynamic 592 592 0 0.0
.got 4528 4528 0 0.0
.init 27 27 0 0.0
.init_array 872 872 0 0.0
.rodata 200221 197597 -2624 -1.3
.text 2215346 2215346 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2452552 2449472 -3080 -0.1
.bss 194752 191664 -3088 -1.6
.data 5512 5512 0 0.0
.text 1415124 1412044 -3080 -0.2
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2413864 2413856 -8 -0.0
.bss 188852 188836 -16 -0.0
.data 5800 5800 0 0.0
.text 1376436 1376428 -8 -0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2349620 2349612 -8 -0.0
.bss 187756 187740 -16 -0.0
.data 5776 5776 0 0.0
.text 1312220 1312212 -8 -0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1155428 1155428 0 0.0
.bss 11952 11952 0 0.0
.data 4512 4512 0 0.0
.text 118812 118812 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2339992 2339976 -16 -0.0
.bss 186392 186384 -8 -0.0
.data 5608 5608 0 0.0
.text 1302564 1302548 -16 -0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 1001503 1001459 -44 -0.0
bss 122092 122080 -12 -0.0
rodata 115752 115740 -12 -0.0
text 686156 686156 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 967031 966987 -44 -0.0
bss 119176 119164 -12 -0.0
rodata 106856 106844 -12 -0.0
text 662872 662872 0 0.0
nrf52840dongle_nrf52840 (read/write) 1017503 1017459 -44 -0.0
bss 123140 123128 -12 -0.0
rodata 115396 115384 -12 -0.0
text 690808 690808 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 904318 904306 -12 -0.0
bss 119380 119368 -12 -0.0
rodata 107868 107856 -12 -0.0
text 595868 595868 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 930499 930487 -12 -0.0
bss 120308 120296 -12 -0.0
rodata 104540 104528 -12 -0.0
text 628588 628588 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 834126 834114 -12 -0.0
bss 117628 117616 -12 -0.0
rodata 96572 96560 -12 -0.0
text 539064 539064 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 501603 501603 0 0.0
bss 52584 52584 0 0.0
rodata 44500 44500 0 0.0
text 342712 342712 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 928759 928715 -44 -0.0
bss 120040 120028 -12 -0.0
rodata 103520 103508 -12 -0.0
text 628016 628016 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 924719 924675 -44 -0.0
bss 120044 120032 -12 -0.0
rodata 103216 103204 -12 -0.0
text 624272 624272 0 0.0
shell nrf52840dk_nrf52840 (read/write) 788643 788643 0 0.0
bss 112360 112360 0 0.0
rodata 74716 74716 0 0.0
text 525452 525452 0 0.0
p6 all-clusters-app default (read/write) 2490728 2487640 -3088 -0.1
.bss 122392 119312 -3080 -2.5
.data 2688 2688 0 0.0
.text 1448992 1445904 -3088 -0.2
light-app default (read/write) 2394856 2394840 -16 -0.0
.bss 113640 113632 -8 -0.0
.data 2536 2536 0 0.0
.text 1353120 1353104 -16 -0.0
lock-app default (read/write) 2358392 2358376 -16 -0.0
.bss 113392 113376 -16 -0.0
.data 2496 2496 0 0.0
.text 1316656 1316640 -16 -0.0
qpg lighting-app qpg6105+debug (read only) 600752 600740 -12 -0.0
(read/write) 146936 146936 0 0.0
.bss 90928 90920 -8 -0.0
.data 1124 1124 0 0.0
.text 595432 595420 -12 -0.0
lock-app qpg6105+debug (read only) 566536 566524 -12 -0.0
(read/write) 146936 146936 0 0.0
.bss 90936 90928 -8 -0.0
.data 1076 1076 0 0.0
.text 561216 561204 -12 -0.0
persistent-storage-app qpg6105+debug (read only) 99536 99536 0 0.0
(read/write) 146941 146941 0 0.0
.bss 24001 24001 0 0.0
.data 180 180 0 0.0
.text 94216 94216 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 882206 882178 -28 -0.0
bss 86364 86352 -12 -0.0
noinit 37160 37160 0 0.0
text 623528 623528 0 0.0

@andy31415 andy31415 merged commit 47682fb into project-chip:master Feb 24, 2022
@bzbarsky-apple bzbarsky-apple deleted the fix-bad-merge branch February 24, 2022 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Damian-Nordic Damian-Nordic Damian-Nordic approved these changes

@vivien-apple vivien-apple vivien-apple approved these changes

@yunhanw-google yunhanw-google yunhanw-google approved these changes

@austinh0 austinh0 Awaiting requested review from austinh0

Assignees
No one assigned
Labels
app
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bzbarsky-apple @yunhanw-google @vivien-apple @Damian-Nordic @andy31415