[Group] Remove TODO #15650
Closed
[Group] Remove TODO #15650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
balducci-apple,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
hawk248,
holbrookt,
harsha-rajendran,
isiu-apple,
jelderton,
jmartinez-silabs,
kghost,
lazarkov,
LuDuda,
lzgrablic02,
mlepage-google,
msandstedt and
mspang
pullapprove
bot
requested review from
holbrookt,
harsha-rajendran,
isiu-apple,
jelderton,
jmartinez-silabs,
kghost,
lazarkov,
LuDuda,
lzgrablic02,
mlepage-google,
msandstedt,
mspang,
sagar-apple,
saurabhst,
selissia,
tecimovic,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
| @@ -42,10 +42,11 @@ CHIP_ERROR ClusterBase::Associate(DeviceProxy * device, EndpointId endpoint) | |||
| return err; | |||
| } | |||
|
|
|||
| /** | |||
| * To be used in a test context where a SecureSession is already present | |||
| */ | |||
| CHIP_ERROR ClusterBase::AssociateWithGroup(DeviceProxy * device, GroupId groupId) | |||
There was a problem hiding this comment.
So this function cannot be used outside of a YAML context? What's the plan to enable this in chip-tool?
If I'm reading the current logic correctly, it requires mDevice to always have a valid secure session ahead of time to permit using it in a group setting, which is an odd pre-requisite.
This is all because mDevice is starting out pointing to a unicast destination - why can't it start out pointing to a groupcast destination instead?
|
PR #15650: Size comparison from 7421db3 to b374d91 Increases above 0.2%:
Increases (1 build for nrfconnect)
Full report (31 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
bzbarsky-apple
requested changes
Mar 1, 2022
| @@ -42,10 +42,11 @@ CHIP_ERROR ClusterBase::Associate(DeviceProxy * device, EndpointId endpoint) | |||
| return err; | |||
| } | |||
|
|
|||
| /** | |||
| * To be used in a test context where a SecureSession is already present | |||
| */ | |||
| CHIP_ERROR ClusterBase::AssociateWithGroup(DeviceProxy * device, GroupId groupId) | |||
There was a problem hiding this comment.
It seems like the right fix should be to change AssociateWithGroup to take the args relevant to a group and not take a DeviceProxy at all.... We should not be creating separate APIs/codepaths for tests vs non-tests if we can avoid it.
|
Closing for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
fix #11850
Change overview
Removed TODO since changes are not needed.
Testing
Not Tested, comments only.