Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused SetupEmberAfCommandSender function. #15945

Merged

Conversation

bzbarsky-apple
Copy link
Contributor

We have not been using this since we stopped going through generic dispatch for CommandSender.

Problem

Unused code.

Change overview

Remove it.

Testing

It's not used.

We have not been using this since we stopped going through generic dispatch for CommandSender.
@github-actions
Copy link

github-actions bot commented Mar 8, 2022

PR #15945: Size comparison from 1f458a5 to 8d269a6

Increases (8 builds for cyw30739, k32w, mbed, nrfconnect, telink)
platform target config section 1f458a5 8d269a6 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 601770 601802 32 0.0
.app_xip_area 506312 506344 32 0.0
lock cyw930739m2evb_01 (read/write) 559690 559722 32 0.0
.app_xip_area 465768 465800 32 0.0
ota-requestor cyw930739m2evb_01 (read/write) 581878 581910 32 0.0
.app_xip_area 478276 478308 32 0.0
k32w light k32w061+release (read/write) 694820 694852 32 0.0
.text 609352 609384 32 0.0
lock k32w061+release (read/write) 696424 696456 32 0.0
.text 610980 611012 32 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2350812 2350876 64 0.0
.text 1313412 1313476 64 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1151795 1151827 32 0.0
text 785512 785544 32 0.0
telink lighting-app tlsr9518adk80d (read/write) 888946 888978 32 0.0
text 628306 628342 36 0.0
Decreases (2 builds for esp32)
platform target config section 1f458a5 8d269a6 change % change
esp32 all-clusters-app c3devkit (read only) 957534 957506 -28 -0.0
.flash.text 957534 957506 -28 -0.0
m5stack (read only) 1012295 1012255 -40 -0.0
.flash.text 1006911 1006871 -40 -0.0
Full report (18 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 1f458a5 8d269a6 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 601770 601802 32 0.0
.app_xip_area 506312 506344 32 0.0
.bss 78140 78140 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 559690 559722 32 0.0
.app_xip_area 465768 465800 32 0.0
.bss 76644 76644 0 0.0
.data 624 624 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 581878 581910 32 0.0
.app_xip_area 478276 478308 32 0.0
.bss 85972 85972 0 0.0
.data 592 592 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 920868 920868 0 0.0
(read/write) 128848 128848 0 0.0
.bss 126768 126768 0 0.0
.data 2080 2080 0 0.0
.text 920860 920860 0 0.0
BRD4161A+rpc (read only) 949688 949688 0 0.0
(read/write) 144808 144808 0 0.0
.bss 142544 142544 0 0.0
.data 2260 2260 0 0.0
.text 949680 949680 0 0.0
window-app BRD4161A (read only) 853888 853888 0 0.0
(read/write) 126840 126840 0 0.0
.bss 124912 124912 0 0.0
.data 1924 1924 0 0.0
.text 853880 853880 0 0.0
esp32 all-clusters-app c3devkit (read only) 957534 957506 -28 -0.0
(read/write) 1393618 1393618 0 0.0
.dram0.bss 63432 63432 0 0.0
.dram0.data 14236 14236 0 0.0
.flash.rodata 197032 197032 0 0.0
.flash.text 957534 957506 -28 -0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1012295 1012255 -40 -0.0
(read/write) 460724 460724 0 0.0
.dram0.bss 68960 68960 0 0.0
.dram0.data 34080 34080 0 0.0
.flash.rodata 225848 225848 0 0.0
.flash.text 1006911 1006871 -40 -0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 694820 694852 32 0.0
.bss 77704 77704 0 0.0
.data 1964 1964 0 0.0
.text 609352 609384 32 0.0
lock k32w061+release (read/write) 696424 696456 32 0.0
.bss 77672 77672 0 0.0
.data 1972 1972 0 0.0
.text 610980 611012 32 0.0
linux chip-tool-ipv6only arm64 (read only) 9430548 9430548 0 0.0
(read/write) 454177 454177 0 0.0
.bss 43825 43825 0 0.0
.data 1200 1200 0 0.0
.data.rel.ro 351000 351000 0 0.0
.dynamic 560 560 0 0.0
.got 54360 54360 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 486556 486556 0 0.0
.text 7940244 7940244 0 0.0
thermostat-no-ble arm64 (read only) 2174612 2174612 0 0.0
(read/write) 148465 148465 0 0.0
.bss 65201 65201 0 0.0
.data 1080 1080 0 0.0
.data.rel.ro 75000 75000 0 0.0
.dynamic 560 560 0 0.0
.got 4216 4216 0 0.0
.init 24 24 0 0.0
.init_array 352 352 0 0.0
.rodata 133012 133012 0 0.0
.text 1823312 1823312 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2350812 2350876 64 0.0
.bss 186084 186084 0 0.0
.data 5800 5800 0 0.0
.text 1313412 1313476 64 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1151795 1151827 32 0.0
bss 146792 146792 0 0.0
rodata 144300 144300 0 0.0
text 785512 785544 32 0.0
p6 all-clusters-app default (read/write) 2494064 2494064 0 0.0
.bss 119504 119504 0 0.0
.data 2696 2696 0 0.0
.text 1452328 1452328 0 0.0
light-app default (read/write) 2397504 2397504 0 0.0
.bss 112976 112976 0 0.0
.data 2544 2544 0 0.0
.text 1355768 1355768 0 0.0
lock-app default (read/write) 2360936 2360936 0 0.0
.bss 112720 112720 0 0.0
.data 2504 2504 0 0.0
.text 1319200 1319200 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 888946 888978 32 0.0
bss 86928 86928 0 0.0
noinit 37160 37160 0 0.0
text 628306 628342 36 0.0

@woody-apple
Copy link
Contributor

Fast tracking pure code deletion that has passed CI

@woody-apple woody-apple merged commit 832fb4d into project-chip:master Mar 8, 2022
@bzbarsky-apple bzbarsky-apple deleted the remove-unused-sender-setup branch March 8, 2022 06:57
mykrupp referenced this pull request in mykrupp/connectedhomeip-1 Mar 8, 2022
We have not been using this since we stopped going through generic dispatch for CommandSender.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants