-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unused SetupEmberAfCommandSender function. #15945
Merged
woody-apple
merged 1 commit into
project-chip:master
from
bzbarsky-apple:remove-unused-sender-setup
Mar 8, 2022
Merged
Remove unused SetupEmberAfCommandSender function. #15945
woody-apple
merged 1 commit into
project-chip:master
from
bzbarsky-apple:remove-unused-sender-setup
Mar 8, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have not been using this since we stopped going through generic dispatch for CommandSender.
pullapprove
bot
requested review from
anush-apple,
austinh0,
balducci-apple,
Byungjoo-Lee,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
hawk248,
holbrookt,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kpschoedel,
lazarkov,
LuDuda,
mlepage-google,
mrjerryjohns and
msandstedt
March 8, 2022 04:43
pullapprove
bot
requested review from
robszewczyk,
sagar-apple,
saurabhst,
selissia,
tecimovic,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yunhanw-google
March 8, 2022 04:43
PR #15945: Size comparison from 1f458a5 to 8d269a6 Increases (8 builds for cyw30739, k32w, mbed, nrfconnect, telink)
Decreases (2 builds for esp32)
Full report (18 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
woody-apple
approved these changes
Mar 8, 2022
Fast tracking pure code deletion that has passed CI |
mykrupp
referenced
this pull request
in mykrupp/connectedhomeip-1
Mar 8, 2022
We have not been using this since we stopped going through generic dispatch for CommandSender.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have not been using this since we stopped going through generic dispatch for CommandSender.
Problem
Unused code.
Change overview
Remove it.
Testing
It's not used.