Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added New BytesToHex() Helper Functions. #15947

Merged
merged 1 commit into from
Mar 8, 2022
Merged

Added New BytesToHex() Helper Functions. #15947

merged 1 commit into from
Mar 8, 2022

Conversation

emargolis
Copy link
Contributor

Problem

Need to add new BytesToHex() and HexToBytes() and use them in various places in SDK.

Change overview

Using these new functions in the CHIP Cert encoding/decoding methods.

Testing

existing tests.

@boring-cyborg boring-cyborg bot added the lib label Mar 8, 2022
@github-actions
Copy link

github-actions bot commented Mar 8, 2022 •
edited
Loading

PR #15947: Size comparison from 1f458a5 to b8576b8

Increases (18 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 1f458a5 b8576b8 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 601770 601826 56 0.0
.app_xip_area 506312 506368 56 0.0
lock cyw930739m2evb_01 (read/write) 559690 559746 56 0.0
.app_xip_area 465768 465824 56 0.0
ota-requestor cyw930739m2evb_01 (read/write) 581878 581934 56 0.0
.app_xip_area 478276 478332 56 0.0
efr32 lighting-app BRD4161A (read only) 920868 920900 32 0.0
.text 920860 920892 32 0.0
BRD4161A+rpc (read only) 949688 949736 48 0.0
.text 949680 949728 48 0.0
window-app BRD4161A (read only) 853888 853920 32 0.0
.text 853880 853912 32 0.0
esp32 all-clusters-app c3devkit (read only) 957534 957576 42 0.0
.flash.text 957534 957576 42 0.0
m5stack (read only) 1012295 1012339 44 0.0
.flash.text 1006911 1006955 44 0.0
k32w light k32w061+release (read/write) 694820 694884 64 0.0
.text 609352 609416 64 0.0
lock k32w061+release (read/write) 696424 696472 48 0.0
.text 610980 611028 48 0.0
linux chip-tool-ipv6only arm64 (read only) 9430548 9430964 416 0.0
.text 7940244 7940708 464 0.0
thermostat-no-ble arm64 (read only) 2174612 2175188 576 0.0
.text 1823312 1823904 592 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2350812 2350876 64 0.0
.text 1313412 1313476 64 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1151795 1151859 64 0.0
text 785512 785568 56 0.0
p6 all-clusters-app default (read/write) 2494064 2494112 48 0.0
.text 1452328 1452376 48 0.0
light-app default (read/write) 2397504 2397536 32 0.0
.text 1355768 1355800 32 0.0
lock-app default (read/write) 2360936 2360968 32 0.0
.text 1319200 1319232 32 0.0
telink lighting-app tlsr9518adk80d (read/write) 888946 889018 72 0.0
text 628306 628378 72 0.0
Decreases (2 builds for linux)
platform target config section 1f458a5 b8576b8 change % change
linux chip-tool-ipv6only arm64 (read/write) 454177 454161 -16 -0.0
.data.rel.ro 351000 350976 -24 -0.0
.rodata 486556 486540 -16 -0.0
thermostat-no-ble arm64 .rodata 133012 132996 -16 -0.0
Full report (18 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 1f458a5 b8576b8 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 601770 601826 56 0.0
.app_xip_area 506312 506368 56 0.0
.bss 78140 78140 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 559690 559746 56 0.0
.app_xip_area 465768 465824 56 0.0
.bss 76644 76644 0 0.0
.data 624 624 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 581878 581934 56 0.0
.app_xip_area 478276 478332 56 0.0
.bss 85972 85972 0 0.0
.data 592 592 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 920868 920900 32 0.0
(read/write) 128848 128848 0 0.0
.bss 126768 126768 0 0.0
.data 2080 2080 0 0.0
.text 920860 920892 32 0.0
BRD4161A+rpc (read only) 949688 949736 48 0.0
(read/write) 144808 144808 0 0.0
.bss 142544 142544 0 0.0
.data 2260 2260 0 0.0
.text 949680 949728 48 0.0
window-app BRD4161A (read only) 853888 853920 32 0.0
(read/write) 126840 126840 0 0.0
.bss 124912 124912 0 0.0
.data 1924 1924 0 0.0
.text 853880 853912 32 0.0
esp32 all-clusters-app c3devkit (read only) 957534 957576 42 0.0
(read/write) 1393618 1393618 0 0.0
.dram0.bss 63432 63432 0 0.0
.dram0.data 14236 14236 0 0.0
.flash.rodata 197032 197032 0 0.0
.flash.text 957534 957576 42 0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1012295 1012339 44 0.0
(read/write) 460724 460724 0 0.0
.dram0.bss 68960 68960 0 0.0
.dram0.data 34080 34080 0 0.0
.flash.rodata 225848 225848 0 0.0
.flash.text 1006911 1006955 44 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 694820 694884 64 0.0
.bss 77704 77704 0 0.0
.data 1964 1964 0 0.0
.text 609352 609416 64 0.0
lock k32w061+release (read/write) 696424 696472 48 0.0
.bss 77672 77672 0 0.0
.data 1972 1972 0 0.0
.text 610980 611028 48 0.0
linux chip-tool-ipv6only arm64 (read only) 9430548 9430964 416 0.0
(read/write) 454177 454161 -16 -0.0
.bss 43825 43825 0 0.0
.data 1200 1200 0 0.0
.data.rel.ro 351000 350976 -24 -0.0
.dynamic 560 560 0 0.0
.got 54360 54360 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 486556 486540 -16 -0.0
.text 7940244 7940708 464 0.0
thermostat-no-ble arm64 (read only) 2174612 2175188 576 0.0
(read/write) 148465 148465 0 0.0
.bss 65201 65201 0 0.0
.data 1080 1080 0 0.0
.data.rel.ro 75000 75000 0 0.0
.dynamic 560 560 0 0.0
.got 4216 4216 0 0.0
.init 24 24 0 0.0
.init_array 352 352 0 0.0
.rodata 133012 132996 -16 -0.0
.text 1823312 1823904 592 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2350812 2350876 64 0.0
.bss 186084 186084 0 0.0
.data 5800 5800 0 0.0
.text 1313412 1313476 64 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1151795 1151859 64 0.0
bss 146792 146792 0 0.0
rodata 144300 144300 0 0.0
text 785512 785568 56 0.0
p6 all-clusters-app default (read/write) 2494064 2494112 48 0.0
.bss 119504 119504 0 0.0
.data 2696 2696 0 0.0
.text 1452328 1452376 48 0.0
light-app default (read/write) 2397504 2397536 32 0.0
.bss 112976 112976 0 0.0
.data 2544 2544 0 0.0
.text 1355768 1355800 32 0.0
lock-app default (read/write) 2360936 2360968 32 0.0
.bss 112720 112720 0 0.0
.data 2504 2504 0 0.0
.text 1319200 1319232 32 0.0
telink lighting-app tlsr9518adk80d (read/write) 888946 889018 72 0.0
bss 86928 86928 0 0.0
noinit 37160 37160 0 0.0
text 628306 628378 72 0.0

Damian-Nordic
Damian-Nordic approved these changes Mar 8, 2022
View reviewed changes
src/lib/support/BytesToHex.h Outdated Show resolved Hide resolved
src/credentials/CHIPCertFromX509.cpp Outdated Show resolved Hide resolved
@emargolis emargolis force-pushed the emargolis/feature/bytes-to-hex branch from b8576b8 to cfdd6e8 Compare March 8, 2022 17:05
@github-actions
Copy link

github-actions bot commented Mar 8, 2022 •
edited
Loading

PR #15947: Size comparison from 1b2aa17 to cfdd6e8

Increases (27 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 1b2aa17 cfdd6e8 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 601810 601866 56 0.0
.app_xip_area 506352 506408 56 0.0
lock cyw930739m2evb_01 (read/write) 559722 559778 56 0.0
.app_xip_area 465800 465856 56 0.0
ota-requestor cyw930739m2evb_01 (read/write) 581918 581974 56 0.0
.app_xip_area 478316 478372 56 0.0
efr32 lighting-app BRD4161A (read only) 920868 920900 32 0.0
.text 920860 920892 32 0.0
BRD4161A+rpc (read only) 949688 949736 48 0.0
.text 949680 949728 48 0.0
window-app BRD4161A (read only) 853888 853920 32 0.0
.text 853880 853912 32 0.0
esp32 all-clusters-app c3devkit (read only) 957506 957548 42 0.0
.flash.text 957506 957548 42 0.0
m5stack (read only) 1012267 1012311 44 0.0
.flash.text 1006883 1006927 44 0.0
k32w light k32w061+release (read/write) 694852 694916 64 0.0
.text 609384 609448 64 0.0
lock k32w061+release (read/write) 696456 696504 48 0.0
.text 611012 611060 48 0.0
linux all-clusters-app debug (read only) 2426809 2427401 592 0.0
.text 2058434 2059026 592 0.0
bridge-app debug+rpc (read only) 1731837 1732445 608 0.0
.text 1474213 1474821 608 0.0
chip-tool debug (read only) 9758533 9759269 736 0.0
.text 8508373 8509109 736 0.0
chip-tool-ipv6only arm64 (read only) 9430548 9430964 416 0.0
.text 7940244 7940708 464 0.0
door-lock-app debug (read only) 1946161 1946737 576 0.0
.text 1623954 1624562 608 0.0
lighting-app debug+rpc (read only) 2078233 2078841 608 0.0
.text 1756866 1757474 608 0.0
ota-provider-app debug (read only) 1879017 1879625 608 0.0
.text 1569490 1570098 608 0.0
ota-requestor-app debug (read only) 1901001 1901593 592 0.0
.text 1596850 1597474 624 0.0
shell debug (read only) 2392969 2393545 576 0.0
.text 2031058 2031666 608 0.0
thermostat-no-ble arm64 (read only) 2174612 2175188 576 0.0
.text 1823312 1823904 592 0.0
tv-app debug (read only) 2617097 2617849 752 0.0
.text 2243746 2244498 752 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2350876 2350940 64 0.0
.text 1313476 1313540 64 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1151827 1151891 64 0.0
text 785544 785600 56 0.0
p6 all-clusters-app default (read/write) 2494064 2494112 48 0.0
.text 1452328 1452376 48 0.0
light-app default (read/write) 2397504 2397536 32 0.0
.text 1355768 1355800 32 0.0
lock-app default (read/write) 2360936 2360968 32 0.0
.text 1319200 1319232 32 0.0
telink lighting-app tlsr9518adk80d (read/write) 888986 889058 72 0.0
text 628350 628422 72 0.0
Decreases (5 builds for linux)
platform target config section 1b2aa17 cfdd6e8 change % change
linux chip-tool-ipv6only arm64 (read/write) 454177 454161 -16 -0.0
.data.rel.ro 351000 350976 -24 -0.0
.rodata 486556 486540 -16 -0.0
door-lock-app debug .rodata 173660 173628 -32 -0.0
ota-requestor-app debug .rodata 154188 154156 -32 -0.0
shell debug .rodata 205458 205426 -32 -0.0
thermostat-no-ble arm64 .rodata 133012 132996 -16 -0.0
Full report (27 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 1b2aa17 cfdd6e8 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 601810 601866 56 0.0
.app_xip_area 506352 506408 56 0.0
.bss 78140 78140 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 559722 559778 56 0.0
.app_xip_area 465800 465856 56 0.0
.bss 76644 76644 0 0.0
.data 624 624 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 581918 581974 56 0.0
.app_xip_area 478316 478372 56 0.0
.bss 85972 85972 0 0.0
.data 592 592 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 920868 920900 32 0.0
(read/write) 128848 128848 0 0.0
.bss 126768 126768 0 0.0
.data 2080 2080 0 0.0
.text 920860 920892 32 0.0
BRD4161A+rpc (read only) 949688 949736 48 0.0
(read/write) 144808 144808 0 0.0
.bss 142544 142544 0 0.0
.data 2260 2260 0 0.0
.text 949680 949728 48 0.0
window-app BRD4161A (read only) 853888 853920 32 0.0
(read/write) 126840 126840 0 0.0
.bss 124912 124912 0 0.0
.data 1924 1924 0 0.0
.text 853880 853912 32 0.0
esp32 all-clusters-app c3devkit (read only) 957506 957548 42 0.0
(read/write) 1393618 1393618 0 0.0
.dram0.bss 63432 63432 0 0.0
.dram0.data 14236 14236 0 0.0
.flash.rodata 197032 197032 0 0.0
.flash.text 957506 957548 42 0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1012267 1012311 44 0.0
(read/write) 460724 460724 0 0.0
.dram0.bss 68960 68960 0 0.0
.dram0.data 34080 34080 0 0.0
.flash.rodata 225848 225848 0 0.0
.flash.text 1006883 1006927 44 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 694852 694916 64 0.0
.bss 77704 77704 0 0.0
.data 1964 1964 0 0.0
.text 609384 609448 64 0.0
lock k32w061+release (read/write) 696456 696504 48 0.0
.bss 77672 77672 0 0.0
.data 1972 1972 0 0.0
.text 611012 611060 48 0.0
linux all-clusters-app debug (read only) 2426809 2427401 592 0.0
(read/write) 145600 145600 0 0.0
.bss 60128 60128 0 0.0
.data 1392 1392 0 0.0
.data.rel.ro 78360 78360 0 0.0
.dynamic 592 592 0 0.0
.got 4176 4176 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 205509 205509 0 0.0
.text 2058434 2059026 592 0.0
bridge-app debug+rpc (read only) 1731837 1732445 608 0.0
(read/write) 92560 92560 0 0.0
.bss 47432 47432 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 38008 38008 0 0.0
.dynamic 592 592 0 0.0
.got 3928 3928 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 141748 141748 0 0.0
.text 1474213 1474821 608 0.0
chip-tool debug (read only) 9758533 9759269 736 0.0
(read/write) 338488 338488 0 0.0
.bss 25512 25512 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 305816 305816 0 0.0
.dynamic 608 608 0 0.0
.got 4776 4776 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 510868 510868 0 0.0
.text 8508373 8509109 736 0.0
chip-tool-ipv6only arm64 (read only) 9430548 9430964 416 0.0
(read/write) 454177 454161 -16 -0.0
.bss 43825 43825 0 0.0
.data 1200 1200 0 0.0
.data.rel.ro 351000 350976 -24 -0.0
.dynamic 560 560 0 0.0
.got 54360 54360 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 486556 486540 -16 -0.0
.text 7940244 7940708 464 0.0
door-lock-app debug (read only) 1946161 1946737 576 0.0
(read/write) 119008 119008 0 0.0
.bss 50432 50432 0 0.0
.data 1056 1056 0 0.0
.data.rel.ro 62136 62136 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 173660 173628 -32 -0.0
.text 1623954 1624562 608 0.0
lighting-app debug+rpc (read only) 2078233 2078841 608 0.0
(read/write) 124376 124376 0 0.0
.bss 51264 51264 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 66040 66040 0 0.0
.dynamic 608 608 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 720 720 0 0.0
.rodata 165852 165852 0 0.0
.text 1756866 1757474 608 0.0
ota-provider-app debug (read only) 1879017 1879625 608 0.0
(read/write) 114640 114640 0 0.0
.bss 50240 50240 0 0.0
.data 1352 1352 0 0.0
.data.rel.ro 57416 57416 0 0.0
.dynamic 608 608 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 158899 158899 0 0.0
.text 1569490 1570098 608 0.0
ota-requestor-app debug (read only) 1901001 1901593 592 0.0
(read/write) 117352 117352 0 0.0
.bss 51296 51296 0 0.0
.data 1512 1512 0 0.0
.data.rel.ro 59112 59112 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 154188 154156 -32 -0.0
.text 1596850 1597474 624 0.0
shell debug (read only) 2392969 2393545 576 0.0
(read/write) 149752 149752 0 0.0
.bss 70216 70216 0 0.0
.data 864 864 0 0.0
.data.rel.ro 73008 73008 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 205458 205426 -32 -0.0
.text 2031058 2031666 608 0.0
thermostat-no-ble arm64 (read only) 2174612 2175188 576 0.0
(read/write) 148465 148465 0 0.0
.bss 65201 65201 0 0.0
.data 1080 1080 0 0.0
.data.rel.ro 75000 75000 0 0.0
.dynamic 560 560 0 0.0
.got 4216 4216 0 0.0
.init 24 24 0 0.0
.init_array 352 352 0 0.0
.rodata 133012 132996 -16 -0.0
.text 1823312 1823904 592 0.0
tv-app debug (read only) 2617097 2617849 752 0.0
(read/write) 250648 250648 0 0.0
.bss 167904 167904 0 0.0
.data 3200 3200 0 0.0
.data.rel.ro 73504 73504 0 0.0
.dynamic 592 592 0 0.0
.got 4544 4544 0 0.0
.init 27 27 0 0.0
.init_array 880 880 0 0.0
.rodata 199453 199453 0 0.0
.text 2243746 2244498 752 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2350876 2350940 64 0.0
.bss 186084 186084 0 0.0
.data 5800 5800 0 0.0
.text 1313476 1313540 64 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1151827 1151891 64 0.0
bss 146792 146792 0 0.0
rodata 144300 144300 0 0.0
text 785544 785600 56 0.0
p6 all-clusters-app default (read/write) 2494064 2494112 48 0.0
.bss 119504 119504 0 0.0
.data 2696 2696 0 0.0
.text 1452328 1452376 48 0.0
light-app default (read/write) 2397504 2397536 32 0.0
.bss 112976 112976 0 0.0
.data 2544 2544 0 0.0
.text 1355768 1355800 32 0.0
lock-app default (read/write) 2360936 2360968 32 0.0
.bss 112720 112720 0 0.0
.data 2504 2504 0 0.0
.text 1319200 1319232 32 0.0
telink lighting-app tlsr9518adk80d (read/write) 888986 889058 72 0.0
bss 86928 86928 0 0.0
noinit 37160 37160 0 0.0
text 628350 628422 72 0.0

@emargolis
Added New BytesToHex() Helper Functions.
b40e8a9 
Using these new functions in the CHIP Cert encoding/decoding mothods.
@emargolis emargolis force-pushed the emargolis/feature/bytes-to-hex branch from cfdd6e8 to b40e8a9 Compare March 8, 2022 20:02
@github-actions
Copy link

github-actions bot commented Mar 8, 2022 •
edited
Loading

PR #15947: Size comparison from a69fde3 to b40e8a9

Increases (23 builds for cyw30739, efr32, k32w, linux, nrfconnect, p6, telink)
platform target config section a69fde3 b40e8a9 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 602090 602098 8 0.0
.app_xip_area 506608 506616 8 0.0
lock cyw930739m2evb_01 (read/write) 559998 560006 8 0.0
.app_xip_area 466052 466060 8 0.0
ota-requestor cyw930739m2evb_01 (read/write) 582190 582198 8 0.0
.app_xip_area 478564 478572 8 0.0
efr32 lighting-app BRD4161A (read only) 921344 921376 32 0.0
.text 921336 921368 32 0.0
BRD4161A+rpc (read only) 950180 950196 16 0.0
.text 950172 950188 16 0.0
window-app BRD4161A (read only) 854380 854396 16 0.0
.text 854372 854388 16 0.0
k32w light k32w061+release (read/write) 695256 695272 16 0.0
.text 609764 609780 16 0.0
linux all-clusters-app debug (read only) 2428721 2429265 544 0.0
.text 2060194 2060738 544 0.0
bridge-app debug+rpc (read only) 1733421 1733997 576 0.0
.text 1475701 1476277 576 0.0
chip-tool debug (read only) 9762741 9763429 688 0.0
.text 8512389 8513077 688 0.0
chip-tool-ipv6only arm64 (read only) 9434788 9435204 416 0.0
.text 7944148 7944596 448 0.0
door-lock-app debug (read only) 1947745 1948289 544 0.0
.text 1625442 1626018 576 0.0
lighting-app debug+rpc (read only) 2080025 2080601 576 0.0
.text 1758546 1759122 576 0.0
ota-provider-app debug (read only) 1880601 1881177 576 0.0
.text 1570978 1571554 576 0.0
ota-requestor-app debug (read only) 1902617 1903161 544 0.0
.text 1598338 1598914 576 0.0
shell debug (read only) 2394833 2395377 544 0.0
.text 2032802 2033378 576 0.0
thermostat-no-ble arm64 (read only) 2176500 2177060 560 0.0
.text 1824912 1825488 576 0.0
tv-app debug (read only) 2620537 2621241 704 0.0
.text 2246994 2247698 704 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1152335 1152351 16 0.0
text 785912 785920 8 0.0
p6 all-clusters-app default (read/write) 2494568 2494584 16 0.0
.text 1452832 1452848 16 0.0
light-app default (read/write) 2398000 2398016 16 0.0
.text 1356264 1356280 16 0.0
lock-app default (read/write) 2361432 2361448 16 0.0
.text 1319696 1319712 16 0.0
telink lighting-app tlsr9518adk80d (read/write) 889534 889606 72 0.0
text 628840 628912 72 0.0
Decreases (6 builds for esp32, linux)
platform target config section a69fde3 b40e8a9 change % change
esp32 all-clusters-app c3devkit (read only) 957942 957904 -38 -0.0
.flash.text 957942 957904 -38 -0.0
linux chip-tool-ipv6only arm64 (read/write) 454337 454305 -32 -0.0
.data.rel.ro 351136 351112 -24 -0.0
.rodata 486588 486572 -16 -0.0
door-lock-app debug .rodata 173660 173628 -32 -0.0
ota-requestor-app debug .rodata 154220 154188 -32 -0.0
shell debug .rodata 205458 205426 -32 -0.0
thermostat-no-ble arm64 .rodata 133012 132996 -16 -0.0
Full report (26 builds for cyw30739, efr32, esp32, k32w, linux, nrfconnect, p6, telink)
platform target config section a69fde3 b40e8a9 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 602090 602098 8 0.0
.app_xip_area 506608 506616 8 0.0
.bss 78172 78172 0 0.0
.data 652 652 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 559998 560006 8 0.0
.app_xip_area 466052 466060 8 0.0
.bss 76676 76676 0 0.0
.data 616 616 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 582190 582198 8 0.0
.app_xip_area 478564 478572 8 0.0
.bss 86004 86004 0 0.0
.data 584 584 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 921344 921376 32 0.0
(read/write) 128872 128872 0 0.0
.bss 126800 126800 0 0.0
.data 2072 2072 0 0.0
.text 921336 921368 32 0.0
BRD4161A+rpc (read only) 950180 950196 16 0.0
(read/write) 144828 144828 0 0.0
.bss 142576 142576 0 0.0
.data 2252 2252 0 0.0
.text 950172 950188 16 0.0
window-app BRD4161A (read only) 854380 854396 16 0.0
(read/write) 126852 126852 0 0.0
.bss 124936 124936 0 0.0
.data 1916 1916 0 0.0
.text 854372 854388 16 0.0
esp32 all-clusters-app c3devkit (read only) 957942 957904 -38 -0.0
(read/write) 1393674 1393674 0 0.0
.dram0.bss 63480 63480 0 0.0
.dram0.data 14220 14220 0 0.0
.flash.rodata 197056 197056 0 0.0
.flash.text 957942 957904 -38 -0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1012743 1012743 0 0.0
(read/write) 460772 460772 0 0.0
.dram0.bss 69000 69000 0 0.0
.dram0.data 34064 34064 0 0.0
.flash.rodata 225872 225872 0 0.0
.flash.text 1007359 1007359 0 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 695256 695272 16 0.0
.bss 77736 77736 0 0.0
.data 1956 1956 0 0.0
.text 609764 609780 16 0.0
lock k32w061+release (read/write) 696860 696860 0 0.0
.bss 77704 77704 0 0.0
.data 1964 1964 0 0.0
.text 611392 611392 0 0.0
linux all-clusters-app debug (read only) 2428721 2429265 544 0.0
(read/write) 145712 145712 0 0.0
.bss 60192 60192 0 0.0
.data 1360 1360 0 0.0
.data.rel.ro 78424 78424 0 0.0
.dynamic 592 592 0 0.0
.got 4176 4176 0 0.0
.init 27 27 0 0.0
.init_array 936 936 0 0.0
.rodata 205541 205541 0 0.0
.text 2060194 2060738 544 0.0
bridge-app debug+rpc (read only) 1733421 1733997 576 0.0
(read/write) 92656 92656 0 0.0
.bss 47496 47496 0 0.0
.data 2016 2016 0 0.0
.data.rel.ro 38064 38064 0 0.0
.dynamic 592 592 0 0.0
.got 3928 3928 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 141748 141748 0 0.0
.text 1475701 1476277 576 0.0
chip-tool debug (read only) 9762741 9763429 688 0.0
(read/write) 338616 338616 0 0.0
.bss 25512 25512 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 305928 305928 0 0.0
.dynamic 608 608 0 0.0
.got 4776 4776 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 510868 510868 0 0.0
.text 8512389 8513077 688 0.0
chip-tool-ipv6only arm64 (read only) 9434788 9435204 416 0.0
(read/write) 454337 454305 -32 -0.0
.bss 43825 43825 0 0.0
.data 1200 1200 0 0.0
.data.rel.ro 351136 351112 -24 -0.0
.dynamic 560 560 0 0.0
.got 54376 54376 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 486588 486572 -16 -0.0
.text 7944148 7944596 448 0.0
door-lock-app debug (read only) 1947745 1948289 544 0.0
(read/write) 119136 119136 0 0.0
.bss 50496 50496 0 0.0
.data 1056 1056 0 0.0
.data.rel.ro 62184 62184 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 173660 173628 -32 -0.0
.text 1625442 1626018 576 0.0
lighting-app debug+rpc (read only) 2080025 2080601 576 0.0
(read/write) 124456 124456 0 0.0
.bss 51296 51296 0 0.0
.data 1536 1536 0 0.0
.data.rel.ro 66104 66104 0 0.0
.dynamic 608 608 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 736 736 0 0.0
.rodata 165820 165820 0 0.0
.text 1758546 1759122 576 0.0
ota-provider-app debug (read only) 1880601 1881177 576 0.0
(read/write) 114736 114736 0 0.0
.bss 50304 50304 0 0.0
.data 1320 1320 0 0.0
.data.rel.ro 57464 57464 0 0.0
.dynamic 608 608 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 158899 158899 0 0.0
.text 1570978 1571554 576 0.0
ota-requestor-app debug (read only) 1902617 1903161 544 0.0
(read/write) 117448 117448 0 0.0
.bss 51360 51360 0 0.0
.data 1480 1480 0 0.0
.data.rel.ro 59176 59176 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 154220 154188 -32 -0.0
.text 1598338 1598914 576 0.0
shell debug (read only) 2394833 2395377 544 0.0
(read/write) 149928 149928 0 0.0
.bss 70312 70312 0 0.0
.data 864 864 0 0.0
.data.rel.ro 73064 73064 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 205458 205426 -32 -0.0
.text 2032802 2033378 576 0.0
thermostat-no-ble arm64 (read only) 2176500 2177060 560 0.0
(read/write) 148673 148673 0 0.0
.bss 65281 65281 0 0.0
.data 1048 1048 0 0.0
.data.rel.ro 75136 75136 0 0.0
.dynamic 560 560 0 0.0
.got 4240 4240 0 0.0
.init 24 24 0 0.0
.init_array 352 352 0 0.0
.rodata 133012 132996 -16 -0.0
.text 1824912 1825488 576 0.0
tv-app debug (read only) 2620537 2621241 704 0.0
(read/write) 250840 250840 0 0.0
.bss 168000 168000 0 0.0
.data 3168 3168 0 0.0
.data.rel.ro 73624 73624 0 0.0
.dynamic 592 592 0 0.0
.got 4544 4544 0 0.0
.init 27 27 0 0.0
.init_array 880 880 0 0.0
.rodata 199453 199453 0 0.0
.text 2246994 2247698 704 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1152335 1152351 16 0.0
bss 146832 146832 0 0.0
rodata 144328 144328 0 0.0
text 785912 785920 8 0.0
p6 all-clusters-app default (read/write) 2494568 2494584 16 0.0
.bss 119544 119544 0 0.0
.data 2680 2680 0 0.0
.text 1452832 1452848 16 0.0
light-app default (read/write) 2398000 2398016 16 0.0
.bss 113008 113008 0 0.0
.data 2536 2536 0 0.0
.text 1356264 1356280 16 0.0
lock-app default (read/write) 2361432 2361448 16 0.0
.bss 112752 112752 0 0.0
.data 2496 2496 0 0.0
.text 1319696 1319712 16 0.0
telink lighting-app tlsr9518adk80d (read/write) 889534 889606 72 0.0
bss 86968 86968 0 0.0
noinit 37160 37160 0 0.0
text 628840 628912 72 0.0

@emargolis emargolis merged commit 0d21c79 into project-chip:master Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Damian-Nordic Damian-Nordic Damian-Nordic approved these changes

@woody-apple woody-apple woody-apple approved these changes

@tcarmelveilleux tcarmelveilleux tcarmelveilleux approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
lib review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@emargolis @tcarmelveilleux @woody-apple @Damian-Nordic