Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PRId64 log message for efr32 devices #15978

Merged
merged 2 commits into from
Mar 10, 2022
Merged

Fix PRId64 log message for efr32 devices #15978

merged 2 commits into from
Mar 10, 2022

Conversation

mkardous-silabs
Copy link
Contributor

@mkardous-silabs mkardous-silabs commented Mar 8, 2022 •
edited
Loading

Problem

  • Not all boards support the PRId64 macro which causes undefined behaviour
  • BRD4186A uart hangs because flow control is enabled

Change overview

  • Place PRId64 macro at the end of the print out to prevent undefined behaviour
  • Disable flow control for BRD4186A

Testing

  • Manual test with ERF32 Mg24

@github-actions
Copy link

github-actions bot commented Mar 8, 2022 •
edited
Loading

PR #15978: Size comparison from a69fde3 to ae93f82

Increases (8 builds for efr32, esp32, linux, nrfconnect, p6)
platform target config section a69fde3 ae93f82 change % change
efr32 lighting-app BRD4161A (read only) 921344 921352 8 0.0
.text 921336 921344 8 0.0
BRD4161A+rpc (read only) 950180 950196 16 0.0
.text 950172 950188 16 0.0
window-app BRD4161A (read only) 854380 854404 24 0.0
.text 854372 854396 24 0.0
esp32 all-clusters-app m5stack (read only) 1012743 1012751 8 0.0
.flash.text 1007359 1007367 8 0.0
linux lighting-app debug+rpc (read only) 2080025 2080041 16 0.0
.text 1758546 1758562 16 0.0
ota-requestor-app debug .text 1598338 1598354 16 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1152335 1152343 8 0.0
text 785912 785920 8 0.0
p6 all-clusters-app default (read/write) 2494568 2494576 8 0.0
.text 1452832 1452840 8 0.0
Decreases (14 builds for cyw30739, esp32, k32w, linux, nrfconnect, telink)
platform target config section a69fde3 ae93f82 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 602090 602086 -4 -0.0
.app_xip_area 506608 506604 -4 -0.0
lock cyw930739m2evb_01 (read/write) 559998 559994 -4 -0.0
.app_xip_area 466052 466048 -4 -0.0
ota-requestor cyw930739m2evb_01 (read/write) 582190 582186 -4 -0.0
.app_xip_area 478564 478560 -4 -0.0
esp32 all-clusters-app c3devkit (read only) 957942 957940 -2 -0.0
(read/write) 1393674 1393666 -8 -0.0
.flash.rodata 197056 197048 -8 -0.0
.flash.text 957942 957940 -2 -0.0
m5stack (read/write) 460772 460764 -8 -0.0
.flash.rodata 225872 225864 -8 -0.0
k32w light k32w061+release (read/write) 695256 695248 -8 -0.0
.text 609764 609756 -8 -0.0
lock k32w061+release (read/write) 696860 696852 -8 -0.0
.text 611392 611384 -8 -0.0
linux all-clusters-app debug (read only) 2428721 2428689 -32 -0.0
.rodata 205541 205509 -32 -0.0
bridge-app debug+rpc (read only) 1733421 1733389 -32 -0.0
.rodata 141748 141716 -32 -0.0
chip-tool-ipv6only arm64 (read only) 9434788 9434772 -16 -0.0
.rodata 486588 486572 -16 -0.0
ota-requestor-app debug (read only) 1902617 1902601 -16 -0.0
.rodata 154220 154188 -32 -0.0
shell debug (read only) 2394833 2394801 -32 -0.0
.rodata 205458 205426 -32 -0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 rodata 144328 144320 -8 -0.0
telink lighting-app tlsr9518adk80d (read/write) 889534 889522 -12 -0.0
text 628840 628838 -2 -0.0
Full report (26 builds for cyw30739, efr32, esp32, k32w, linux, nrfconnect, p6, telink)
platform target config section a69fde3 ae93f82 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 602090 602086 -4 -0.0
.app_xip_area 506608 506604 -4 -0.0
.bss 78172 78172 0 0.0
.data 652 652 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 559998 559994 -4 -0.0
.app_xip_area 466052 466048 -4 -0.0
.bss 76676 76676 0 0.0
.data 616 616 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 582190 582186 -4 -0.0
.app_xip_area 478564 478560 -4 -0.0
.bss 86004 86004 0 0.0
.data 584 584 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 921344 921352 8 0.0
(read/write) 128872 128872 0 0.0
.bss 126800 126800 0 0.0
.data 2072 2072 0 0.0
.text 921336 921344 8 0.0
BRD4161A+rpc (read only) 950180 950196 16 0.0
(read/write) 144828 144828 0 0.0
.bss 142576 142576 0 0.0
.data 2252 2252 0 0.0
.text 950172 950188 16 0.0
window-app BRD4161A (read only) 854380 854404 24 0.0
(read/write) 126852 126852 0 0.0
.bss 124936 124936 0 0.0
.data 1916 1916 0 0.0
.text 854372 854396 24 0.0
esp32 all-clusters-app c3devkit (read only) 957942 957940 -2 -0.0
(read/write) 1393674 1393666 -8 -0.0
.dram0.bss 63480 63480 0 0.0
.dram0.data 14220 14220 0 0.0
.flash.rodata 197056 197048 -8 -0.0
.flash.text 957942 957940 -2 -0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1012743 1012751 8 0.0
(read/write) 460772 460764 -8 -0.0
.dram0.bss 69000 69000 0 0.0
.dram0.data 34064 34064 0 0.0
.flash.rodata 225872 225864 -8 -0.0
.flash.text 1007359 1007367 8 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 695256 695248 -8 -0.0
.bss 77736 77736 0 0.0
.data 1956 1956 0 0.0
.text 609764 609756 -8 -0.0
lock k32w061+release (read/write) 696860 696852 -8 -0.0
.bss 77704 77704 0 0.0
.data 1964 1964 0 0.0
.text 611392 611384 -8 -0.0
linux all-clusters-app debug (read only) 2428721 2428689 -32 -0.0
(read/write) 145712 145712 0 0.0
.bss 60192 60192 0 0.0
.data 1360 1360 0 0.0
.data.rel.ro 78424 78424 0 0.0
.dynamic 592 592 0 0.0
.got 4176 4176 0 0.0
.init 27 27 0 0.0
.init_array 936 936 0 0.0
.rodata 205541 205509 -32 -0.0
.text 2060194 2060194 0 0.0
bridge-app debug+rpc (read only) 1733421 1733389 -32 -0.0
(read/write) 92656 92656 0 0.0
.bss 47496 47496 0 0.0
.data 2016 2016 0 0.0
.data.rel.ro 38064 38064 0 0.0
.dynamic 592 592 0 0.0
.got 3928 3928 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 141748 141716 -32 -0.0
.text 1475701 1475701 0 0.0
chip-tool debug (read only) 9762741 9762741 0 0.0
(read/write) 338616 338616 0 0.0
.bss 25512 25512 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 305928 305928 0 0.0
.dynamic 608 608 0 0.0
.got 4776 4776 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 510868 510868 0 0.0
.text 8512389 8512389 0 0.0
chip-tool-ipv6only arm64 (read only) 9434788 9434772 -16 -0.0
(read/write) 454337 454337 0 0.0
.bss 43825 43825 0 0.0
.data 1200 1200 0 0.0
.data.rel.ro 351136 351136 0 0.0
.dynamic 560 560 0 0.0
.got 54376 54376 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 486588 486572 -16 -0.0
.text 7944148 7944148 0 0.0
door-lock-app debug (read only) 1947745 1947745 0 0.0
(read/write) 119136 119136 0 0.0
.bss 50496 50496 0 0.0
.data 1056 1056 0 0.0
.data.rel.ro 62184 62184 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 173660 173660 0 0.0
.text 1625442 1625442 0 0.0
lighting-app debug+rpc (read only) 2080025 2080041 16 0.0
(read/write) 124456 124456 0 0.0
.bss 51296 51296 0 0.0
.data 1536 1536 0 0.0
.data.rel.ro 66104 66104 0 0.0
.dynamic 608 608 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 736 736 0 0.0
.rodata 165820 165820 0 0.0
.text 1758546 1758562 16 0.0
ota-provider-app debug (read only) 1880601 1880601 0 0.0
(read/write) 114736 114736 0 0.0
.bss 50304 50304 0 0.0
.data 1320 1320 0 0.0
.data.rel.ro 57464 57464 0 0.0
.dynamic 608 608 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 158899 158899 0 0.0
.text 1570978 1570978 0 0.0
ota-requestor-app debug (read only) 1902617 1902601 -16 -0.0
(read/write) 117448 117448 0 0.0
.bss 51360 51360 0 0.0
.data 1480 1480 0 0.0
.data.rel.ro 59176 59176 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 154220 154188 -32 -0.0
.text 1598338 1598354 16 0.0
shell debug (read only) 2394833 2394801 -32 -0.0
(read/write) 149928 149928 0 0.0
.bss 70312 70312 0 0.0
.data 864 864 0 0.0
.data.rel.ro 73064 73064 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 205458 205426 -32 -0.0
.text 2032802 2032802 0 0.0
thermostat-no-ble arm64 (read only) 2176500 2176500 0 0.0
(read/write) 148673 148673 0 0.0
.bss 65281 65281 0 0.0
.data 1048 1048 0 0.0
.data.rel.ro 75136 75136 0 0.0
.dynamic 560 560 0 0.0
.got 4240 4240 0 0.0
.init 24 24 0 0.0
.init_array 352 352 0 0.0
.rodata 133012 133012 0 0.0
.text 1824912 1824912 0 0.0
tv-app debug (read only) 2620537 2620537 0 0.0
(read/write) 250840 250840 0 0.0
.bss 168000 168000 0 0.0
.data 3168 3168 0 0.0
.data.rel.ro 73624 73624 0 0.0
.dynamic 592 592 0 0.0
.got 4544 4544 0 0.0
.init 27 27 0 0.0
.init_array 880 880 0 0.0
.rodata 199453 199453 0 0.0
.text 2246994 2246994 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1152335 1152343 8 0.0
bss 146832 146832 0 0.0
rodata 144328 144320 -8 -0.0
text 785912 785920 8 0.0
p6 all-clusters-app default (read/write) 2494568 2494576 8 0.0
.bss 119544 119544 0 0.0
.data 2680 2680 0 0.0
.text 1452832 1452840 8 0.0
light-app default (read/write) 2398000 2398000 0 0.0
.bss 113008 113008 0 0.0
.data 2536 2536 0 0.0
.text 1356264 1356264 0 0.0
lock-app default (read/write) 2361432 2361432 0 0.0
.bss 112752 112752 0 0.0
.data 2496 2496 0 0.0
.text 1319696 1319696 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 889534 889522 -12 -0.0
bss 86968 86968 0 0.0
noinit 37160 37160 0 0.0
text 628840 628838 -2 -0.0

bzbarsky-apple
bzbarsky-apple requested changes Mar 9, 2022
View reviewed changes
src/transport/SessionManager.cpp Outdated Show resolved Hide resolved
bzbarsky-apple
bzbarsky-apple reviewed Mar 9, 2022
View reviewed changes
Copy link
Contributor

@bzbarsky-apple bzbarsky-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the efr submodule update on purpose, @mkardous-silabs ?

@mkardous-silabs
Copy link
Contributor Author

Is the efr submodule update on purpose, @mkardous-silabs ?

@bzbarsky-apple yes, updating a uart config for one of boards that was causing problems with the matter shell

@jepenven-silabs jepenven-silabs merged commit 1105f3e into project-chip:master Mar 10, 2022
@mkardous-silabs mkardous-silabs deleted the fix/mg24_logs branch March 10, 2022 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmeg-sfy jmeg-sfy jmeg-sfy approved these changes

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

Assignees
No one assigned
Labels
review - approved transport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mkardous-silabs @bzbarsky-apple @jepenven-silabs @jmeg-sfy