Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce CommissionableDataProvider for discriminator and verifier #16020

Merged

Conversation

tcarmelveilleux
Copy link
Contributor

Problem

  • Current API in ConfigurationManager makes it very hard to provide
    spec-mandated per-device SPAKE2+ parameters (verifier, salt, iteration
    counts) and discovery discriminator, since it expects "in-app" common
    SDK handling of the data for something that actually usually
    comes from the factory.

Fixes #15543

Change overview

  • Adds CommissionableDataProvider interface, of which an instance
    is known to the ConfigurationManager.
  • Adds a legacy path to avoid requiring setting a
    CommissionableDataProvider in the short term
  • A linux implementation of CommissionableDataProvider showcasing
    providing externally generated SPAKE2+ verifier/salt/iterations
  • Refactoring of all direct usage of ConfigurationManager to
    get discriminator/SPAKE2+ parameters

Testing

  • Cert tests still pass with no change
  • All unit tests still pass, including those modified
  • Setting GN arg chip_use_transitional_commissionable_data_provider=0
    properly causes targets that don't provide an implementation
    from running.
  • Manually verified the new Linux command-line arguments to
    all-clusters-app allow passing custom version of verifier or iteration
    counts.

- Current API in ConfigurationManager makes it very hard to provide
  spec-mandated per-device SPAKE2+ parameters (verifier, salt, iteration
  counts) and discovery discriminator, since it expects "in-app" common
  SDK handling of the data for something that actually usually
  comes from the factory.

This PR does the following:

- Adds CommissionableDataProvider interface, of which an instance
  is known to the ConfigurationManager.
- Adds a legacy path to avoid requiring setting a
  CommissionableDataProvider in the short term
- A linux implementation of CommissionableDataProvider showcasing
  providing externally generated SPAKE2+ verifier/salt/iterations
- Refactoring of all direct usage of ConfigurationManager to
  get discriminator/SPAKE2+ parameters

Testing done:
- Cert tests still pass with no change
- All unit tests still pass, including those modified
- Setting GN arg `chip_use_transitional_commissionable_data_provider=0`
  properly causes targets that don't provide an implementation
  from running.
- Manually verified the new Linux command-line arguments to
  all-clusters-app allow passing custom version of verifier or iteration
  counts.

Fixes project-chip#15543
@github-actions
Copy link

github-actions bot commented Mar 10, 2022

PR #16020: Size comparison from c49b115 to 82b4b25

Increases above 0.2%:

platform target config section c49b115 82b4b25 change % change
linux all-clusters-app debug (read only) 2430753 2453145 22392 0.9
.bss 60352 60576 224 0.4
.rodata 205797 213669 7872 3.8
.text 2061970 2076418 14448 0.7
bridge-app debug+rpc .rodata 141964 144748 2784 2.0
chip-tool debug .bss 25640 25704 64 0.2
.rodata 514388 517396 3008 0.6
door-lock-app debug (read only) 1950353 1971129 20776 1.1
.bss 50656 50880 224 0.4
.rodata 173884 180028 6144 3.5
.text 1627826 1642386 14560 0.9
lighting-app debug+rpc (read only) 2082521 2102737 20216 1.0
(read/write) 124616 124904 288 0.2
.bss 51456 51680 224 0.4
.rodata 166076 172540 6464 3.9
.text 1760786 1774466 13680 0.8
ota-provider-app debug (read only) 1883753 1904097 20344 1.1
(read/write) 114896 115152 256 0.2
.bss 50464 50688 224 0.4
.rodata 159091 164787 5696 3.6
.text 1573938 1588514 14576 0.9
ota-requestor-app debug (read only) 1911497 1932065 20568 1.1
.bss 51552 51776 224 0.4
.rodata 155084 161004 5920 3.8
.text 1605538 1620114 14576 0.9
shell debug .rodata 205746 211250 5504 2.7
tv-app debug (read only) 2622457 2645337 22880 0.9
.rodata 199389 207653 8264 4.1
.text 2248978 2263522 14544 0.6
Increases (28 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section c49b115 82b4b25 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 598102 598654 552 0.1
.app_xip_area 505684 506224 540 0.1
.bss 75108 75168 60 0.1
lock cyw930739m2evb_01 (read/write) 555970 556426 456 0.1
.app_xip_area 465088 465524 436 0.1
.bss 73612 73672 60 0.1
ota-requestor cyw930739m2evb_01 (read/write) 565978 566534 556 0.1
.app_xip_area 465408 465952 544 0.1
.bss 82980 83032 52 0.1
efr32 lighting-app BRD4161A (read only) 919808 921700 1892 0.2
(read/write) 128256 128280 24 0.0
.bss 126216 126280 64 0.1
.text 919800 921692 1892 0.2
BRD4161A+rpc (read only) 948620 950560 1940 0.2
(read/write) 144212 144240 28 0.0
.bss 141992 142056 64 0.0
.text 948612 950552 1940 0.2
window-app BRD4161A (read only) 852364 854276 1912 0.2
(read/write) 126220 126244 24 0.0
.bss 124304 124368 64 0.1
.text 852356 854268 1912 0.2
esp32 all-clusters-app c3devkit (read only) 957766 958180 414 0.0
(read/write) 1393810 1394074 264 0.0
.dram0.bss 63576 63640 64 0.1
.flash.rodata 197096 197312 216 0.1
.flash.text 957766 958180 414 0.0
m5stack (read only) 1012875 1013423 548 0.1
(read/write) 461052 461292 240 0.1
.dram0.bss 69096 69152 56 0.1
.flash.rodata 226056 226272 216 0.1
.flash.text 1007491 1008039 548 0.1
k32w light k32w061+release (read/write) 694464 695076 612 0.1
.bss 77152 77200 48 0.1
.text 609588 610192 604 0.1
lock k32w061+release (read/write) 695324 695952 628 0.1
.bss 77072 77136 64 0.1
.text 610488 611092 604 0.1
linux all-clusters-app debug (read only) 2430753 2453145 22392 0.9
(read/write) 145872 146128 256 0.2
.bss 60352 60576 224 0.4
.data.rel.ro 78424 78488 64 0.1
.rodata 205797 213669 7872 3.8
.text 2061970 2076418 14448 0.7
bridge-app debug+rpc (read only) 1736053 1736301 248 0.0
.bss 47624 47688 64 0.1
.rodata 141964 144748 2784 2.0
chip-tool debug (read only) 10093029 10093309 280 0.0
.bss 25640 25704 64 0.2
.rodata 514388 517396 3008 0.6
door-lock-app debug (read only) 1950353 1971129 20776 1.1
(read/write) 119296 119520 224 0.2
.bss 50656 50880 224 0.4
.data.rel.ro 62184 62232 48 0.1
.rodata 173884 180028 6144 3.5
.text 1627826 1642386 14560 0.9
lighting-app debug+rpc (read only) 2082521 2102737 20216 1.0
(read/write) 124616 124904 288 0.2
.bss 51456 51680 224 0.4
.data.rel.ro 66104 66200 96 0.1
.rodata 166076 172540 6464 3.9
.text 1760786 1774466 13680 0.8
ota-provider-app debug (read only) 1883753 1904097 20344 1.1
(read/write) 114896 115152 256 0.2
.bss 50464 50688 224 0.4
.data.rel.ro 57464 57528 64 0.1
.rodata 159091 164787 5696 3.6
.text 1573938 1588514 14576 0.9
ota-requestor-app debug (read only) 1911497 1932065 20568 1.1
(read/write) 117992 118216 224 0.2
.bss 51552 51776 224 0.4
.data.rel.ro 59512 59560 48 0.1
.rodata 155084 161004 5920 3.8
.text 1605538 1620114 14576 0.9
shell debug (read only) 2396769 2399817 3048 0.1
.bss 70472 70536 64 0.1
.rodata 205746 211250 5504 2.7
tv-app debug (read only) 2622457 2645337 22880 0.9
(read/write) 250360 250656 296 0.1
.bss 167520 167784 264 0.2
.data.rel.ro 73624 73688 64 0.1
.rodata 199389 207653 8264 4.1
.text 2248978 2263522 14544 0.6
mbed all-clusters-app CY8CPROTO_062_4343W+release .bss 192160 192200 40 0.0
lighting-app CY8CPROTO_062_4343W+release .bss 187476 187508 32 0.0
lock-app CY8CPROTO_062_4343W+release .bss 186212 186252 40 0.0
shell CY8CPROTO_062_4343W+release .bss 186016 186056 40 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1151675 1152207 532 0.0
bss 146208 146264 56 0.0
rodata 144452 144664 212 0.1
text 785760 786124 364 0.0
p6 all-clusters-app default (read/write) 2494296 2496192 1896 0.1
.bss 119640 119680 40 0.0
.text 1452560 1454456 1896 0.1
light-app default (read/write) 2398312 2400160 1848 0.1
.bss 113104 113144 40 0.0
.text 1356576 1358424 1848 0.1
lock-app default (read/write) 2361856 2363720 1864 0.1
.bss 112848 112888 40 0.0
.text 1320120 1321984 1864 0.1
telink lighting-app tlsr9518adk80d (read/write) 888878 889510 632 0.1
bss 86968 87024 56 0.1
text 628158 628558 400 0.1
Decreases (26 builds for cyw30739, efr32, esp32, k32w, linux, mbed, p6)
platform target config section c49b115 82b4b25 change % change
cyw30739 light cyw930739m2evb_01 .data 652 612 -40 -6.1
lock cyw930739m2evb_01 .data 616 576 -40 -6.5
ota-requestor cyw930739m2evb_01 .data 552 516 -36 -6.5
efr32 lighting-app BRD4161A .data 2040 2000 -40 -2.0
BRD4161A+rpc .data 2220 2180 -40 -1.8
window-app BRD4161A .data 1916 1876 -40 -2.1
esp32 all-clusters-app c3devkit .dram0.data 14220 14196 -24 -0.2
m5stack .dram0.data 34064 34032 -32 -0.1
k32w light k32w061+release .data 1924 1884 -40 -2.1
lock k32w061+release .data 1964 1924 -40 -2.0
linux all-clusters-app debug .data 1360 1328 -32 -2.4
bridge-app debug+rpc (read/write) 92784 92624 -160 -0.2
.data 2016 1984 -32 -1.6
.data.rel.ro 38064 37872 -192 -0.5
.text 1478117 1476181 -1936 -0.1
chip-tool debug (read/write) 358168 357976 -192 -0.1
.data 1152 1088 -64 -5.6
.data.rel.ro 325352 325160 -192 -0.1
.text 8795957 8793829 -2128 -0.0
door-lock-app debug .data 1056 1024 -32 -3.0
lighting-app debug+rpc .data 1536 1504 -32 -2.1
ota-provider-app debug .data 1320 1288 -32 -2.4
ota-requestor-app debug .data 1480 1448 -32 -2.2
shell debug (read/write) 150088 149864 -224 -0.1
.data 864 800 -64 -7.4
.data.rel.ro 73064 72840 -224 -0.3
.text 2034450 2032594 -1856 -0.1
tv-app debug .data 3168 3136 -32 -1.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2456840 2456288 -552 -0.0
.data 5504 5464 -40 -0.7
.text 1419412 1418860 -552 -0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2418240 2417688 -552 -0.0
.data 5816 5792 -24 -0.4
.text 1380812 1380260 -552 -0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2351484 2350868 -616 -0.0
.data 5792 5768 -24 -0.4
.text 1314084 1313468 -616 -0.0
shell CY8CPROTO_062_4343W+release (read/write) 2344464 2343904 -560 -0.0
.data 5608 5576 -32 -0.6
.text 1307036 1306476 -560 -0.0
p6 all-clusters-app default .data 2680 2648 -32 -1.2
light-app default .data 2536 2504 -32 -1.3
lock-app default .data 2496 2464 -32 -1.3
Full report (28 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section c49b115 82b4b25 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 598102 598654 552 0.1
.app_xip_area 505684 506224 540 0.1
.bss 75108 75168 60 0.1
.data 652 612 -40 -6.1
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 555970 556426 456 0.1
.app_xip_area 465088 465524 436 0.1
.bss 73612 73672 60 0.1
.data 616 576 -40 -6.5
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 565978 566534 556 0.1
.app_xip_area 465408 465952 544 0.1
.bss 82980 83032 52 0.1
.data 552 516 -36 -6.5
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 919808 921700 1892 0.2
(read/write) 128256 128280 24 0.0
.bss 126216 126280 64 0.1
.data 2040 2000 -40 -2.0
.text 919800 921692 1892 0.2
BRD4161A+rpc (read only) 948620 950560 1940 0.2
(read/write) 144212 144240 28 0.0
.bss 141992 142056 64 0.0
.data 2220 2180 -40 -1.8
.text 948612 950552 1940 0.2
window-app BRD4161A (read only) 852364 854276 1912 0.2
(read/write) 126220 126244 24 0.0
.bss 124304 124368 64 0.1
.data 1916 1876 -40 -2.1
.text 852356 854268 1912 0.2
esp32 all-clusters-app c3devkit (read only) 957766 958180 414 0.0
(read/write) 1393810 1394074 264 0.0
.dram0.bss 63576 63640 64 0.1
.dram0.data 14220 14196 -24 -0.2
.flash.rodata 197096 197312 216 0.1
.flash.text 957766 958180 414 0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1012875 1013423 548 0.1
(read/write) 461052 461292 240 0.1
.dram0.bss 69096 69152 56 0.1
.dram0.data 34064 34032 -32 -0.1
.flash.rodata 226056 226272 216 0.1
.flash.text 1007491 1008039 548 0.1
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 694464 695076 612 0.1
.bss 77152 77200 48 0.1
.data 1924 1884 -40 -2.1
.text 609588 610192 604 0.1
lock k32w061+release (read/write) 695324 695952 628 0.1
.bss 77072 77136 64 0.1
.data 1964 1924 -40 -2.0
.text 610488 611092 604 0.1
linux all-clusters-app debug (read only) 2430753 2453145 22392 0.9
(read/write) 145872 146128 256 0.2
.bss 60352 60576 224 0.4
.data 1360 1328 -32 -2.4
.data.rel.ro 78424 78488 64 0.1
.dynamic 592 592 0 0.0
.got 4176 4176 0 0.0
.init 27 27 0 0.0
.init_array 936 936 0 0.0
.rodata 205797 213669 7872 3.8
.text 2061970 2076418 14448 0.7
bridge-app debug+rpc (read only) 1736053 1736301 248 0.0
(read/write) 92784 92624 -160 -0.2
.bss 47624 47688 64 0.1
.data 2016 1984 -32 -1.6
.data.rel.ro 38064 37872 -192 -0.5
.dynamic 592 592 0 0.0
.got 3928 3928 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 141964 144748 2784 2.0
.text 1478117 1476181 -1936 -0.1
chip-tool debug (read only) 10093029 10093309 280 0.0
(read/write) 358168 357976 -192 -0.1
.bss 25640 25704 64 0.2
.data 1152 1088 -64 -5.6
.data.rel.ro 325352 325160 -192 -0.1
.dynamic 608 608 0 0.0
.got 4776 4776 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 514388 517396 3008 0.6
.text 8795957 8793829 -2128 -0.0
door-lock-app debug (read only) 1950353 1971129 20776 1.1
(read/write) 119296 119520 224 0.2
.bss 50656 50880 224 0.4
.data 1056 1024 -32 -3.0
.data.rel.ro 62184 62232 48 0.1
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 173884 180028 6144 3.5
.text 1627826 1642386 14560 0.9
lighting-app debug+rpc (read only) 2082521 2102737 20216 1.0
(read/write) 124616 124904 288 0.2
.bss 51456 51680 224 0.4
.data 1536 1504 -32 -2.1
.data.rel.ro 66104 66200 96 0.1
.dynamic 608 608 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 736 736 0 0.0
.rodata 166076 172540 6464 3.9
.text 1760786 1774466 13680 0.8
ota-provider-app debug (read only) 1883753 1904097 20344 1.1
(read/write) 114896 115152 256 0.2
.bss 50464 50688 224 0.4
.data 1320 1288 -32 -2.4
.data.rel.ro 57464 57528 64 0.1
.dynamic 608 608 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 159091 164787 5696 3.6
.text 1573938 1588514 14576 0.9
ota-requestor-app debug (read only) 1911497 1932065 20568 1.1
(read/write) 117992 118216 224 0.2
.bss 51552 51776 224 0.4
.data 1480 1448 -32 -2.2
.data.rel.ro 59512 59560 48 0.1
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 155084 161004 5920 3.8
.text 1605538 1620114 14576 0.9
shell debug (read only) 2396769 2399817 3048 0.1
(read/write) 150088 149864 -224 -0.1
.bss 70472 70536 64 0.1
.data 864 800 -64 -7.4
.data.rel.ro 73064 72840 -224 -0.3
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 205746 211250 5504 2.7
.text 2034450 2032594 -1856 -0.1
tv-app debug (read only) 2622457 2645337 22880 0.9
(read/write) 250360 250656 296 0.1
.bss 167520 167784 264 0.2
.data 3168 3136 -32 -1.0
.data.rel.ro 73624 73688 64 0.1
.dynamic 592 592 0 0.0
.got 4544 4544 0 0.0
.init 27 27 0 0.0
.init_array 880 880 0 0.0
.rodata 199389 207653 8264 4.1
.text 2248978 2263522 14544 0.6
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2456840 2456288 -552 -0.0
.bss 192160 192200 40 0.0
.data 5504 5464 -40 -0.7
.text 1419412 1418860 -552 -0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2418240 2417688 -552 -0.0
.bss 187476 187508 32 0.0
.data 5816 5792 -24 -0.4
.text 1380812 1380260 -552 -0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2351484 2350868 -616 -0.0
.bss 186212 186252 40 0.0
.data 5792 5768 -24 -0.4
.text 1314084 1313468 -616 -0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2344464 2343904 -560 -0.0
.bss 186016 186056 40 0.0
.data 5608 5576 -32 -0.6
.text 1307036 1306476 -560 -0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1151675 1152207 532 0.0
bss 146208 146264 56 0.0
rodata 144452 144664 212 0.1
text 785760 786124 364 0.0
p6 all-clusters-app default (read/write) 2494296 2496192 1896 0.1
.bss 119640 119680 40 0.0
.data 2680 2648 -32 -1.2
.text 1452560 1454456 1896 0.1
light-app default (read/write) 2398312 2400160 1848 0.1
.bss 113104 113144 40 0.0
.data 2536 2504 -32 -1.3
.text 1356576 1358424 1848 0.1
lock-app default (read/write) 2361856 2363720 1864 0.1
.bss 112848 112888 40 0.0
.data 2496 2464 -32 -1.3
.text 1320120 1321984 1864 0.1
telink lighting-app tlsr9518adk80d (read/write) 888878 889510 632 0.1
bss 86968 87024 56 0.1
noinit 37160 37160 0 0.0
text 628158 628558 400 0.1

src/platform/BUILD.gn Outdated Show resolved Hide resolved
src/include/platform/ConfigurationManager.h Outdated Show resolved Hide resolved
src/include/platform/CommissionableDataProvider.h Outdated Show resolved Hide resolved
src/include/platform/CommissionableDataProvider.h Outdated Show resolved Hide resolved
src/app/server/OnboardingCodesUtil.cpp Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Mar 10, 2022

PR #16020: Size comparison from c49b115 to 19194fa

Increases above 0.2%:

platform target config section c49b115 19194fa change % change
linux all-clusters-app debug (read only) 2430753 2453337 22584 0.9
.bss 60352 60576 224 0.4
.rodata 205797 213701 7904 3.8
.text 2061970 2076578 14608 0.7
bridge-app debug+rpc .rodata 141964 144748 2784 2.0
chip-tool debug .bss 25640 25704 64 0.2
.rodata 514388 517428 3040 0.6
door-lock-app debug (read only) 1950353 1971321 20968 1.1
.bss 50656 50880 224 0.4
.rodata 173884 180060 6176 3.6
.text 1627826 1642546 14720 0.9
lighting-app debug+rpc (read only) 2082521 2102897 20376 1.0
(read/write) 124616 124904 288 0.2
.bss 51456 51680 224 0.4
.rodata 166076 172540 6464 3.9
.text 1760786 1774626 13840 0.8
ota-provider-app debug (read only) 1883753 1904289 20536 1.1
(read/write) 114896 115152 256 0.2
.bss 50464 50688 224 0.4
.rodata 159091 164819 5728 3.6
.text 1573938 1588674 14736 0.9
ota-requestor-app debug (read only) 1911497 1932241 20744 1.1
.bss 51552 51776 224 0.4
.rodata 155084 161036 5952 3.8
.text 1605538 1620258 14720 0.9
shell debug .rodata 205746 211282 5536 2.7
thermostat-no-ble arm64 (read only) 2178892 2194900 16008 0.7
.bss 65393 65601 208 0.3
.data 1048 1056 8 0.8
.init_array 352 360 8 2.3
.rodata 133132 136020 2888 2.2
.text 1827184 1839920 12736 0.7
tv-app debug (read only) 2622457 2645529 23072 0.9
.rodata 199389 207685 8296 4.2
.text 2248978 2263682 14704 0.7
Increases (30 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section c49b115 19194fa change % change
cyw30739 light cyw930739m2evb_01 (read/write) 598102 598762 660 0.1
.app_xip_area 505684 506332 648 0.1
.bss 75108 75168 60 0.1
lock cyw930739m2evb_01 (read/write) 555970 556534 564 0.1
.app_xip_area 465088 465632 544 0.1
.bss 73612 73672 60 0.1
ota-requestor cyw930739m2evb_01 (read/write) 565978 566534 556 0.1
.app_xip_area 465408 465952 544 0.1
.bss 82980 83032 52 0.1
efr32 lighting-app BRD4161A (read only) 919808 921804 1996 0.2
(read/write) 128256 128280 24 0.0
.bss 126216 126280 64 0.1
.text 919800 921796 1996 0.2
BRD4161A+rpc (read only) 948620 950648 2028 0.2
(read/write) 144212 144240 28 0.0
.bss 141992 142056 64 0.0
.text 948612 950640 2028 0.2
window-app BRD4161A (read only) 852364 854364 2000 0.2
(read/write) 126220 126244 24 0.0
.bss 124304 124368 64 0.1
.text 852356 854356 2000 0.2
esp32 all-clusters-app c3devkit (read only) 957766 958220 454 0.0
(read/write) 1393810 1394114 304 0.0
.dram0.bss 63576 63640 64 0.1
.flash.rodata 197096 197352 256 0.1
.flash.text 957766 958220 454 0.0
m5stack (read only) 1012875 1013471 596 0.1
(read/write) 461052 461324 272 0.1
.dram0.bss 69096 69152 56 0.1
.flash.rodata 226056 226304 248 0.1
.flash.text 1007491 1008087 596 0.1
k32w light k32w061+release (read/write) 694464 695176 712 0.1
.bss 77152 77200 48 0.1
.text 609588 610292 704 0.1
lock k32w061+release (read/write) 695324 696068 744 0.1
.bss 77072 77136 64 0.1
.text 610488 611208 720 0.1
linux all-clusters-app debug (read only) 2430753 2453337 22584 0.9
(read/write) 145872 146128 256 0.2
.bss 60352 60576 224 0.4
.data.rel.ro 78424 78488 64 0.1
.rodata 205797 213701 7904 3.8
.text 2061970 2076578 14608 0.7
bridge-app debug+rpc (read only) 1736053 1736461 408 0.0
.bss 47624 47688 64 0.1
.rodata 141964 144748 2784 2.0
chip-tool debug (read only) 10093029 10093501 472 0.0
.bss 25640 25704 64 0.2
.rodata 514388 517428 3040 0.6
chip-tool-ipv6only arm64 .bss 43953 44001 48 0.1
.rodata 492084 492148 64 0.0
door-lock-app debug (read only) 1950353 1971321 20968 1.1
(read/write) 119296 119520 224 0.2
.bss 50656 50880 224 0.4
.data.rel.ro 62184 62232 48 0.1
.rodata 173884 180060 6176 3.6
.text 1627826 1642546 14720 0.9
lighting-app debug+rpc (read only) 2082521 2102897 20376 1.0
(read/write) 124616 124904 288 0.2
.bss 51456 51680 224 0.4
.data.rel.ro 66104 66200 96 0.1
.rodata 166076 172540 6464 3.9
.text 1760786 1774626 13840 0.8
ota-provider-app debug (read only) 1883753 1904289 20536 1.1
(read/write) 114896 115152 256 0.2
.bss 50464 50688 224 0.4
.data.rel.ro 57464 57528 64 0.1
.rodata 159091 164819 5728 3.6
.text 1573938 1588674 14736 0.9
ota-requestor-app debug (read only) 1911497 1932241 20744 1.1
(read/write) 117992 118216 224 0.2
.bss 51552 51776 224 0.4
.data.rel.ro 59512 59560 48 0.1
.rodata 155084 161036 5952 3.8
.text 1605538 1620258 14720 0.9
shell debug (read only) 2396769 2400009 3240 0.1
.bss 70472 70536 64 0.1
.rodata 205746 211282 5536 2.7
thermostat-no-ble arm64 (read only) 2178892 2194900 16008 0.7
(read/write) 148801 149153 352 0.2
.bss 65393 65601 208 0.3
.data 1048 1056 8 0.8
.data.rel.ro 75160 75280 120 0.2
.got 4232 4240 8 0.2
.init_array 352 360 8 2.3
.rodata 133132 136020 2888 2.2
.text 1827184 1839920 12736 0.7
tv-app debug (read only) 2622457 2645529 23072 0.9
(read/write) 250360 250656 296 0.1
.bss 167520 167784 264 0.2
.data.rel.ro 73624 73688 64 0.1
.rodata 199389 207685 8296 4.2
.text 2248978 2263682 14704 0.7
mbed all-clusters-app CY8CPROTO_062_4343W+release .bss 192160 192200 40 0.0
lighting-app CY8CPROTO_062_4343W+release .bss 187476 187508 32 0.0
lock-app CY8CPROTO_062_4343W+release .bss 186212 186252 40 0.0
shell CY8CPROTO_062_4343W+release .bss 186016 186056 40 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1151675 1152315 640 0.1
bss 146208 146264 56 0.0
rodata 144452 144692 240 0.2
text 785760 786196 436 0.1
p6 all-clusters-app default (read/write) 2494296 2496280 1984 0.1
.bss 119640 119680 40 0.0
.text 1452560 1454544 1984 0.1
light-app default (read/write) 2398312 2400264 1952 0.1
.bss 113104 113144 40 0.0
.text 1356576 1358528 1952 0.1
lock-app default (read/write) 2361856 2363808 1952 0.1
.bss 112848 112888 40 0.0
.text 1320120 1322072 1952 0.1
telink lighting-app tlsr9518adk80d (read/write) 888878 889578 700 0.1
bss 86968 87024 56 0.1
text 628158 628594 436 0.1
Decreases (27 builds for cyw30739, efr32, esp32, k32w, linux, mbed, p6)
platform target config section c49b115 19194fa change % change
cyw30739 light cyw930739m2evb_01 .data 652 612 -40 -6.1
lock cyw930739m2evb_01 .data 616 576 -40 -6.5
ota-requestor cyw930739m2evb_01 .data 552 516 -36 -6.5
efr32 lighting-app BRD4161A .data 2040 2000 -40 -2.0
BRD4161A+rpc .data 2220 2180 -40 -1.8
window-app BRD4161A .data 1916 1876 -40 -2.1
esp32 all-clusters-app c3devkit .dram0.data 14220 14196 -24 -0.2
m5stack .dram0.data 34064 34032 -32 -0.1
k32w light k32w061+release .data 1924 1884 -40 -2.1
lock k32w061+release .data 1964 1924 -40 -2.0
linux all-clusters-app debug .data 1360 1328 -32 -2.4
bridge-app debug+rpc (read/write) 92784 92624 -160 -0.2
.data 2016 1984 -32 -1.6
.data.rel.ro 38064 37872 -192 -0.5
.text 1478117 1476341 -1776 -0.1
chip-tool debug (read/write) 358168 357976 -192 -0.1
.data 1152 1088 -64 -5.6
.data.rel.ro 325352 325160 -192 -0.1
.text 8795957 8793989 -1968 -0.0
chip-tool-ipv6only arm64 (read only) 9728988 9727228 -1760 -0.0
(read/write) 475953 475777 -176 -0.0
.data 1200 1160 -40 -3.3
.data.rel.ro 371712 371544 -168 -0.0
.got 55296 55272 -24 -0.0
.text 8185732 8184388 -1344 -0.0
door-lock-app debug .data 1056 1024 -32 -3.0
lighting-app debug+rpc .data 1536 1504 -32 -2.1
ota-provider-app debug .data 1320 1288 -32 -2.4
ota-requestor-app debug .data 1480 1448 -32 -2.2
shell debug (read/write) 150088 149864 -224 -0.1
.data 864 800 -64 -7.4
.data.rel.ro 73064 72840 -224 -0.3
.text 2034450 2032754 -1696 -0.1
tv-app debug .data 3168 3136 -32 -1.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2456840 2456384 -456 -0.0
.data 5504 5464 -40 -0.7
.text 1419412 1418956 -456 -0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2418240 2417784 -456 -0.0
.data 5816 5792 -24 -0.4
.text 1380812 1380356 -456 -0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2351484 2350964 -520 -0.0
.data 5792 5768 -24 -0.4
.text 1314084 1313564 -520 -0.0
shell CY8CPROTO_062_4343W+release (read/write) 2344464 2344008 -456 -0.0
.data 5608 5576 -32 -0.6
.text 1307036 1306580 -456 -0.0
p6 all-clusters-app default .data 2680 2648 -32 -1.2
light-app default .data 2536 2504 -32 -1.3
lock-app default .data 2496 2464 -32 -1.3
Full report (30 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section c49b115 19194fa change % change
cyw30739 light cyw930739m2evb_01 (read/write) 598102 598762 660 0.1
.app_xip_area 505684 506332 648 0.1
.bss 75108 75168 60 0.1
.data 652 612 -40 -6.1
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 555970 556534 564 0.1
.app_xip_area 465088 465632 544 0.1
.bss 73612 73672 60 0.1
.data 616 576 -40 -6.5
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 565978 566534 556 0.1
.app_xip_area 465408 465952 544 0.1
.bss 82980 83032 52 0.1
.data 552 516 -36 -6.5
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 919808 921804 1996 0.2
(read/write) 128256 128280 24 0.0
.bss 126216 126280 64 0.1
.data 2040 2000 -40 -2.0
.text 919800 921796 1996 0.2
BRD4161A+rpc (read only) 948620 950648 2028 0.2
(read/write) 144212 144240 28 0.0
.bss 141992 142056 64 0.0
.data 2220 2180 -40 -1.8
.text 948612 950640 2028 0.2
window-app BRD4161A (read only) 852364 854364 2000 0.2
(read/write) 126220 126244 24 0.0
.bss 124304 124368 64 0.1
.data 1916 1876 -40 -2.1
.text 852356 854356 2000 0.2
esp32 all-clusters-app c3devkit (read only) 957766 958220 454 0.0
(read/write) 1393810 1394114 304 0.0
.dram0.bss 63576 63640 64 0.1
.dram0.data 14220 14196 -24 -0.2
.flash.rodata 197096 197352 256 0.1
.flash.text 957766 958220 454 0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1012875 1013471 596 0.1
(read/write) 461052 461324 272 0.1
.dram0.bss 69096 69152 56 0.1
.dram0.data 34064 34032 -32 -0.1
.flash.rodata 226056 226304 248 0.1
.flash.text 1007491 1008087 596 0.1
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 694464 695176 712 0.1
.bss 77152 77200 48 0.1
.data 1924 1884 -40 -2.1
.text 609588 610292 704 0.1
lock k32w061+release (read/write) 695324 696068 744 0.1
.bss 77072 77136 64 0.1
.data 1964 1924 -40 -2.0
.text 610488 611208 720 0.1
linux all-clusters-app debug (read only) 2430753 2453337 22584 0.9
(read/write) 145872 146128 256 0.2
.bss 60352 60576 224 0.4
.data 1360 1328 -32 -2.4
.data.rel.ro 78424 78488 64 0.1
.dynamic 592 592 0 0.0
.got 4176 4176 0 0.0
.init 27 27 0 0.0
.init_array 936 936 0 0.0
.rodata 205797 213701 7904 3.8
.text 2061970 2076578 14608 0.7
bridge-app debug+rpc (read only) 1736053 1736461 408 0.0
(read/write) 92784 92624 -160 -0.2
.bss 47624 47688 64 0.1
.data 2016 1984 -32 -1.6
.data.rel.ro 38064 37872 -192 -0.5
.dynamic 592 592 0 0.0
.got 3928 3928 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 141964 144748 2784 2.0
.text 1478117 1476341 -1776 -0.1
chip-tool debug (read only) 10093029 10093501 472 0.0
(read/write) 358168 357976 -192 -0.1
.bss 25640 25704 64 0.2
.data 1152 1088 -64 -5.6
.data.rel.ro 325352 325160 -192 -0.1
.dynamic 608 608 0 0.0
.got 4776 4776 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 514388 517428 3040 0.6
.text 8795957 8793989 -1968 -0.0
chip-tool-ipv6only arm64 (read only) 9728988 9727228 -1760 -0.0
(read/write) 475953 475777 -176 -0.0
.bss 43953 44001 48 0.1
.data 1200 1160 -40 -3.3
.data.rel.ro 371712 371544 -168 -0.0
.dynamic 560 560 0 0.0
.got 55296 55272 -24 -0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 492084 492148 64 0.0
.text 8185732 8184388 -1344 -0.0
door-lock-app debug (read only) 1950353 1971321 20968 1.1
(read/write) 119296 119520 224 0.2
.bss 50656 50880 224 0.4
.data 1056 1024 -32 -3.0
.data.rel.ro 62184 62232 48 0.1
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 173884 180060 6176 3.6
.text 1627826 1642546 14720 0.9
lighting-app debug+rpc (read only) 2082521 2102897 20376 1.0
(read/write) 124616 124904 288 0.2
.bss 51456 51680 224 0.4
.data 1536 1504 -32 -2.1
.data.rel.ro 66104 66200 96 0.1
.dynamic 608 608 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 736 736 0 0.0
.rodata 166076 172540 6464 3.9
.text 1760786 1774626 13840 0.8
ota-provider-app debug (read only) 1883753 1904289 20536 1.1
(read/write) 114896 115152 256 0.2
.bss 50464 50688 224 0.4
.data 1320 1288 -32 -2.4
.data.rel.ro 57464 57528 64 0.1
.dynamic 608 608 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 159091 164819 5728 3.6
.text 1573938 1588674 14736 0.9
ota-requestor-app debug (read only) 1911497 1932241 20744 1.1
(read/write) 117992 118216 224 0.2
.bss 51552 51776 224 0.4
.data 1480 1448 -32 -2.2
.data.rel.ro 59512 59560 48 0.1
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 155084 161036 5952 3.8
.text 1605538 1620258 14720 0.9
shell debug (read only) 2396769 2400009 3240 0.1
(read/write) 150088 149864 -224 -0.1
.bss 70472 70536 64 0.1
.data 864 800 -64 -7.4
.data.rel.ro 73064 72840 -224 -0.3
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 205746 211282 5536 2.7
.text 2034450 2032754 -1696 -0.1
thermostat-no-ble arm64 (read only) 2178892 2194900 16008 0.7
(read/write) 148801 149153 352 0.2
.bss 65393 65601 208 0.3
.data 1048 1056 8 0.8
.data.rel.ro 75160 75280 120 0.2
.dynamic 560 560 0 0.0
.got 4232 4240 8 0.2
.init 24 24 0 0.0
.init_array 352 360 8 2.3
.rodata 133132 136020 2888 2.2
.text 1827184 1839920 12736 0.7
tv-app debug (read only) 2622457 2645529 23072 0.9
(read/write) 250360 250656 296 0.1
.bss 167520 167784 264 0.2
.data 3168 3136 -32 -1.0
.data.rel.ro 73624 73688 64 0.1
.dynamic 592 592 0 0.0
.got 4544 4544 0 0.0
.init 27 27 0 0.0
.init_array 880 880 0 0.0
.rodata 199389 207685 8296 4.2
.text 2248978 2263682 14704 0.7
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2456840 2456384 -456 -0.0
.bss 192160 192200 40 0.0
.data 5504 5464 -40 -0.7
.text 1419412 1418956 -456 -0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2418240 2417784 -456 -0.0
.bss 187476 187508 32 0.0
.data 5816 5792 -24 -0.4
.text 1380812 1380356 -456 -0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2351484 2350964 -520 -0.0
.bss 186212 186252 40 0.0
.data 5792 5768 -24 -0.4
.text 1314084 1313564 -520 -0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2344464 2344008 -456 -0.0
.bss 186016 186056 40 0.0
.data 5608 5576 -32 -0.6
.text 1307036 1306580 -456 -0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1151675 1152315 640 0.1
bss 146208 146264 56 0.0
rodata 144452 144692 240 0.2
text 785760 786196 436 0.1
p6 all-clusters-app default (read/write) 2494296 2496280 1984 0.1
.bss 119640 119680 40 0.0
.data 2680 2648 -32 -1.2
.text 1452560 1454544 1984 0.1
light-app default (read/write) 2398312 2400264 1952 0.1
.bss 113104 113144 40 0.0
.data 2536 2504 -32 -1.3
.text 1356576 1358528 1952 0.1
lock-app default (read/write) 2361856 2363808 1952 0.1
.bss 112848 112888 40 0.0
.data 2496 2464 -32 -1.3
.text 1320120 1322072 1952 0.1
telink lighting-app tlsr9518adk80d (read/write) 888878 889578 700 0.1
bss 86968 87024 56 0.1
noinit 37160 37160 0 0.0
text 628158 628594 436 0.1

@github-actions
Copy link

github-actions bot commented Mar 10, 2022

PR #16020: Size comparison from c49b115 to 0fa9255

Increases above 0.2%:

platform target config section c49b115 0fa9255 change % change
linux all-clusters-app debug (read only) 2430753 2453321 22568 0.9
.bss 60352 60576 224 0.4
.rodata 205797 213701 7904 3.8
.text 2061970 2076562 14592 0.7
bridge-app debug+rpc .rodata 141964 144748 2784 2.0
chip-tool debug .bss 25640 25704 64 0.2
.rodata 514388 517428 3040 0.6
door-lock-app debug (read only) 1950353 1971305 20952 1.1
.bss 50656 50880 224 0.4
.rodata 173884 180060 6176 3.6
.text 1627826 1642530 14704 0.9
lighting-app debug+rpc (read only) 2082521 2102881 20360 1.0
(read/write) 124616 124904 288 0.2
.bss 51456 51680 224 0.4
.rodata 166076 172540 6464 3.9
.text 1760786 1774610 13824 0.8
ota-provider-app debug (read only) 1883753 1904273 20520 1.1
(read/write) 114896 115152 256 0.2
.bss 50464 50688 224 0.4
.rodata 159091 164819 5728 3.6
.text 1573938 1588658 14720 0.9
ota-requestor-app debug (read only) 1911497 1932369 20872 1.1
.bss 51552 51776 224 0.4
.rodata 155084 161036 5952 3.8
.text 1605538 1620386 14848 0.9
shell debug .rodata 205746 211282 5536 2.7
thermostat-no-ble arm64 (read only) 2178892 2194820 15928 0.7
.bss 65393 65601 208 0.3
.data 1048 1056 8 0.8
.init_array 352 360 8 2.3
.rodata 133132 136020 2888 2.2
.text 1827184 1839840 12656 0.7
tv-app debug (read only) 2622457 2645497 23040 0.9
.rodata 199389 207685 8296 4.2
.text 2248978 2263650 14672 0.7
Increases (30 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section c49b115 0fa9255 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 598102 598726 624 0.1
.app_xip_area 505684 506296 612 0.1
.bss 75108 75168 60 0.1
lock cyw930739m2evb_01 (read/write) 555970 556498 528 0.1
.app_xip_area 465088 465596 508 0.1
.bss 73612 73672 60 0.1
ota-requestor cyw930739m2evb_01 (read/write) 565978 566514 536 0.1
.app_xip_area 465408 465932 524 0.1
.bss 82980 83032 52 0.1
efr32 lighting-app BRD4161A (read only) 919808 921788 1980 0.2
(read/write) 128256 128280 24 0.0
.bss 126216 126280 64 0.1
.text 919800 921780 1980 0.2
BRD4161A+rpc (read only) 948620 950632 2012 0.2
(read/write) 144212 144240 28 0.0
.bss 141992 142056 64 0.0
.text 948612 950624 2012 0.2
window-app BRD4161A (read only) 852364 854332 1968 0.2
(read/write) 126220 126244 24 0.0
.bss 124304 124368 64 0.1
.text 852356 854324 1968 0.2
esp32 all-clusters-app c3devkit (read only) 957766 958190 424 0.0
(read/write) 1393810 1394114 304 0.0
.dram0.bss 63576 63640 64 0.1
.flash.rodata 197096 197352 256 0.1
.flash.text 957766 958190 424 0.0
m5stack (read only) 1012875 1013443 568 0.1
(read/write) 461052 461324 272 0.1
.dram0.bss 69096 69152 56 0.1
.flash.rodata 226056 226304 248 0.1
.flash.text 1007491 1008059 568 0.1
k32w light k32w061+release (read/write) 694464 695160 696 0.1
.bss 77152 77200 48 0.1
.text 609588 610276 688 0.1
lock k32w061+release (read/write) 695324 696036 712 0.1
.bss 77072 77136 64 0.1
.text 610488 611176 688 0.1
linux all-clusters-app debug (read only) 2430753 2453321 22568 0.9
(read/write) 145872 146128 256 0.2
.bss 60352 60576 224 0.4
.data.rel.ro 78424 78488 64 0.1
.rodata 205797 213701 7904 3.8
.text 2061970 2076562 14592 0.7
bridge-app debug+rpc (read only) 1736053 1736493 440 0.0
.bss 47624 47688 64 0.1
.rodata 141964 144748 2784 2.0
chip-tool debug (read only) 10093029 10093613 584 0.0
.bss 25640 25704 64 0.2
.rodata 514388 517428 3040 0.6
chip-tool-ipv6only arm64 .bss 43953 44001 48 0.1
.rodata 492084 492148 64 0.0
door-lock-app debug (read only) 1950353 1971305 20952 1.1
(read/write) 119296 119520 224 0.2
.bss 50656 50880 224 0.4
.data.rel.ro 62184 62232 48 0.1
.rodata 173884 180060 6176 3.6
.text 1627826 1642530 14704 0.9
lighting-app debug+rpc (read only) 2082521 2102881 20360 1.0
(read/write) 124616 124904 288 0.2
.bss 51456 51680 224 0.4
.data.rel.ro 66104 66200 96 0.1
.rodata 166076 172540 6464 3.9
.text 1760786 1774610 13824 0.8
ota-provider-app debug (read only) 1883753 1904273 20520 1.1
(read/write) 114896 115152 256 0.2
.bss 50464 50688 224 0.4
.data.rel.ro 57464 57528 64 0.1
.rodata 159091 164819 5728 3.6
.text 1573938 1588658 14720 0.9
ota-requestor-app debug (read only) 1911497 1932369 20872 1.1
(read/write) 117992 118216 224 0.2
.bss 51552 51776 224 0.4
.data.rel.ro 59512 59560 48 0.1
.rodata 155084 161036 5952 3.8
.text 1605538 1620386 14848 0.9
shell debug (read only) 2396769 2400041 3272 0.1
.bss 70472 70536 64 0.1
.rodata 205746 211282 5536 2.7
thermostat-no-ble arm64 (read only) 2178892 2194820 15928 0.7
(read/write) 148801 149153 352 0.2
.bss 65393 65601 208 0.3
.data 1048 1056 8 0.8
.data.rel.ro 75160 75280 120 0.2
.got 4232 4240 8 0.2
.init_array 352 360 8 2.3
.rodata 133132 136020 2888 2.2
.text 1827184 1839840 12656 0.7
tv-app debug (read only) 2622457 2645497 23040 0.9
(read/write) 250360 250656 296 0.1
.bss 167520 167784 264 0.2
.data.rel.ro 73624 73688 64 0.1
.rodata 199389 207685 8296 4.2
.text 2248978 2263650 14672 0.7
mbed all-clusters-app CY8CPROTO_062_4343W+release .bss 192160 192200 40 0.0
lighting-app CY8CPROTO_062_4343W+release .bss 187476 187508 32 0.0
lock-app CY8CPROTO_062_4343W+release .bss 186212 186252 40 0.0
shell CY8CPROTO_062_4343W+release .bss 186016 186056 40 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1151675 1152315 640 0.1
bss 146208 146264 56 0.0
rodata 144452 144692 240 0.2
text 785760 786192 432 0.1
p6 all-clusters-app default (read/write) 2494296 2496248 1952 0.1
.bss 119640 119680 40 0.0
.text 1452560 1454512 1952 0.1
light-app default (read/write) 2398312 2400232 1920 0.1
.bss 113104 113144 40 0.0
.text 1356576 1358496 1920 0.1
lock-app default (read/write) 2361856 2363792 1936 0.1
.bss 112848 112888 40 0.0
.text 1320120 1322056 1936 0.1
telink lighting-app tlsr9518adk80d (read/write) 888878 889538 660 0.1
bss 86968 87024 56 0.1
text 628158 628558 400 0.1
Decreases (27 builds for cyw30739, efr32, esp32, k32w, linux, mbed, p6)
platform target config section c49b115 0fa9255 change % change
cyw30739 light cyw930739m2evb_01 .data 652 612 -40 -6.1
lock cyw930739m2evb_01 .data 616 576 -40 -6.5
ota-requestor cyw930739m2evb_01 .data 552 516 -36 -6.5
efr32 lighting-app BRD4161A .data 2040 2000 -40 -2.0
BRD4161A+rpc .data 2220 2180 -40 -1.8
window-app BRD4161A .data 1916 1876 -40 -2.1
esp32 all-clusters-app c3devkit .dram0.data 14220 14196 -24 -0.2
m5stack .dram0.data 34064 34032 -32 -0.1
k32w light k32w061+release .data 1924 1884 -40 -2.1
lock k32w061+release .data 1964 1924 -40 -2.0
linux all-clusters-app debug .data 1360 1328 -32 -2.4
bridge-app debug+rpc (read/write) 92784 92624 -160 -0.2
.data 2016 1984 -32 -1.6
.data.rel.ro 38064 37872 -192 -0.5
.text 1478117 1476373 -1744 -0.1
chip-tool debug (read/write) 358168 357976 -192 -0.1
.data 1152 1088 -64 -5.6
.data.rel.ro 325352 325160 -192 -0.1
.text 8795957 8794101 -1856 -0.0
chip-tool-ipv6only arm64 (read only) 9728988 9727308 -1680 -0.0
(read/write) 475953 475777 -176 -0.0
.data 1200 1160 -40 -3.3
.data.rel.ro 371712 371544 -168 -0.0
.got 55296 55272 -24 -0.0
.text 8185732 8184468 -1264 -0.0
door-lock-app debug .data 1056 1024 -32 -3.0
lighting-app debug+rpc .data 1536 1504 -32 -2.1
ota-provider-app debug .data 1320 1288 -32 -2.4
ota-requestor-app debug .data 1480 1448 -32 -2.2
shell debug (read/write) 150088 149864 -224 -0.1
.data 864 800 -64 -7.4
.data.rel.ro 73064 72840 -224 -0.3
.text 2034450 2032786 -1664 -0.1
tv-app debug .data 3168 3136 -32 -1.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2456840 2456384 -456 -0.0
.data 5504 5464 -40 -0.7
.text 1419412 1418956 -456 -0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2418240 2417784 -456 -0.0
.data 5816 5792 -24 -0.4
.text 1380812 1380356 -456 -0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2351484 2350964 -520 -0.0
.data 5792 5768 -24 -0.4
.text 1314084 1313564 -520 -0.0
shell CY8CPROTO_062_4343W+release (read/write) 2344464 2343944 -520 -0.0
.data 5608 5576 -32 -0.6
.text 1307036 1306516 -520 -0.0
p6 all-clusters-app default .data 2680 2648 -32 -1.2
light-app default .data 2536 2504 -32 -1.3
lock-app default .data 2496 2464 -32 -1.3
Full report (30 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section c49b115 0fa9255 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 598102 598726 624 0.1
.app_xip_area 505684 506296 612 0.1
.bss 75108 75168 60 0.1
.data 652 612 -40 -6.1
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 555970 556498 528 0.1
.app_xip_area 465088 465596 508 0.1
.bss 73612 73672 60 0.1
.data 616 576 -40 -6.5
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 565978 566514 536 0.1
.app_xip_area 465408 465932 524 0.1
.bss 82980 83032 52 0.1
.data 552 516 -36 -6.5
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 919808 921788 1980 0.2
(read/write) 128256 128280 24 0.0
.bss 126216 126280 64 0.1
.data 2040 2000 -40 -2.0
.text 919800 921780 1980 0.2
BRD4161A+rpc (read only) 948620 950632 2012 0.2
(read/write) 144212 144240 28 0.0
.bss 141992 142056 64 0.0
.data 2220 2180 -40 -1.8
.text 948612 950624 2012 0.2
window-app BRD4161A (read only) 852364 854332 1968 0.2
(read/write) 126220 126244 24 0.0
.bss 124304 124368 64 0.1
.data 1916 1876 -40 -2.1
.text 852356 854324 1968 0.2
esp32 all-clusters-app c3devkit (read only) 957766 958190 424 0.0
(read/write) 1393810 1394114 304 0.0
.dram0.bss 63576 63640 64 0.1
.dram0.data 14220 14196 -24 -0.2
.flash.rodata 197096 197352 256 0.1
.flash.text 957766 958190 424 0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1012875 1013443 568 0.1
(read/write) 461052 461324 272 0.1
.dram0.bss 69096 69152 56 0.1
.dram0.data 34064 34032 -32 -0.1
.flash.rodata 226056 226304 248 0.1
.flash.text 1007491 1008059 568 0.1
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 694464 695160 696 0.1
.bss 77152 77200 48 0.1
.data 1924 1884 -40 -2.1
.text 609588 610276 688 0.1
lock k32w061+release (read/write) 695324 696036 712 0.1
.bss 77072 77136 64 0.1
.data 1964 1924 -40 -2.0
.text 610488 611176 688 0.1
linux all-clusters-app debug (read only) 2430753 2453321 22568 0.9
(read/write) 145872 146128 256 0.2
.bss 60352 60576 224 0.4
.data 1360 1328 -32 -2.4
.data.rel.ro 78424 78488 64 0.1
.dynamic 592 592 0 0.0
.got 4176 4176 0 0.0
.init 27 27 0 0.0
.init_array 936 936 0 0.0
.rodata 205797 213701 7904 3.8
.text 2061970 2076562 14592 0.7
bridge-app debug+rpc (read only) 1736053 1736493 440 0.0
(read/write) 92784 92624 -160 -0.2
.bss 47624 47688 64 0.1
.data 2016 1984 -32 -1.6
.data.rel.ro 38064 37872 -192 -0.5
.dynamic 592 592 0 0.0
.got 3928 3928 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 141964 144748 2784 2.0
.text 1478117 1476373 -1744 -0.1
chip-tool debug (read only) 10093029 10093613 584 0.0
(read/write) 358168 357976 -192 -0.1
.bss 25640 25704 64 0.2
.data 1152 1088 -64 -5.6
.data.rel.ro 325352 325160 -192 -0.1
.dynamic 608 608 0 0.0
.got 4776 4776 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 514388 517428 3040 0.6
.text 8795957 8794101 -1856 -0.0
chip-tool-ipv6only arm64 (read only) 9728988 9727308 -1680 -0.0
(read/write) 475953 475777 -176 -0.0
.bss 43953 44001 48 0.1
.data 1200 1160 -40 -3.3
.data.rel.ro 371712 371544 -168 -0.0
.dynamic 560 560 0 0.0
.got 55296 55272 -24 -0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 492084 492148 64 0.0
.text 8185732 8184468 -1264 -0.0
door-lock-app debug (read only) 1950353 1971305 20952 1.1
(read/write) 119296 119520 224 0.2
.bss 50656 50880 224 0.4
.data 1056 1024 -32 -3.0
.data.rel.ro 62184 62232 48 0.1
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 173884 180060 6176 3.6
.text 1627826 1642530 14704 0.9
lighting-app debug+rpc (read only) 2082521 2102881 20360 1.0
(read/write) 124616 124904 288 0.2
.bss 51456 51680 224 0.4
.data 1536 1504 -32 -2.1
.data.rel.ro 66104 66200 96 0.1
.dynamic 608 608 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 736 736 0 0.0
.rodata 166076 172540 6464 3.9
.text 1760786 1774610 13824 0.8
ota-provider-app debug (read only) 1883753 1904273 20520 1.1
(read/write) 114896 115152 256 0.2
.bss 50464 50688 224 0.4
.data 1320 1288 -32 -2.4
.data.rel.ro 57464 57528 64 0.1
.dynamic 608 608 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 159091 164819 5728 3.6
.text 1573938 1588658 14720 0.9
ota-requestor-app debug (read only) 1911497 1932369 20872 1.1
(read/write) 117992 118216 224 0.2
.bss 51552 51776 224 0.4
.data 1480 1448 -32 -2.2
.data.rel.ro 59512 59560 48 0.1
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 155084 161036 5952 3.8
.text 1605538 1620386 14848 0.9
shell debug (read only) 2396769 2400041 3272 0.1
(read/write) 150088 149864 -224 -0.1
.bss 70472 70536 64 0.1
.data 864 800 -64 -7.4
.data.rel.ro 73064 72840 -224 -0.3
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 205746 211282 5536 2.7
.text 2034450 2032786 -1664 -0.1
thermostat-no-ble arm64 (read only) 2178892 2194820 15928 0.7
(read/write) 148801 149153 352 0.2
.bss 65393 65601 208 0.3
.data 1048 1056 8 0.8
.data.rel.ro 75160 75280 120 0.2
.dynamic 560 560 0 0.0
.got 4232 4240 8 0.2
.init 24 24 0 0.0
.init_array 352 360 8 2.3
.rodata 133132 136020 2888 2.2
.text 1827184 1839840 12656 0.7
tv-app debug (read only) 2622457 2645497 23040 0.9
(read/write) 250360 250656 296 0.1
.bss 167520 167784 264 0.2
.data 3168 3136 -32 -1.0
.data.rel.ro 73624 73688 64 0.1
.dynamic 592 592 0 0.0
.got 4544 4544 0 0.0
.init 27 27 0 0.0
.init_array 880 880 0 0.0
.rodata 199389 207685 8296 4.2
.text 2248978 2263650 14672 0.7
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2456840 2456384 -456 -0.0
.bss 192160 192200 40 0.0
.data 5504 5464 -40 -0.7
.text 1419412 1418956 -456 -0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2418240 2417784 -456 -0.0
.bss 187476 187508 32 0.0
.data 5816 5792 -24 -0.4
.text 1380812 1380356 -456 -0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2351484 2350964 -520 -0.0
.bss 186212 186252 40 0.0
.data 5792 5768 -24 -0.4
.text 1314084 1313564 -520 -0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2344464 2343944 -520 -0.0
.bss 186016 186056 40 0.0
.data 5608 5576 -32 -0.6
.text 1307036 1306516 -520 -0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1151675 1152315 640 0.1
bss 146208 146264 56 0.0
rodata 144452 144692 240 0.2
text 785760 786192 432 0.1
p6 all-clusters-app default (read/write) 2494296 2496248 1952 0.1
.bss 119640 119680 40 0.0
.data 2680 2648 -32 -1.2
.text 1452560 1454512 1952 0.1
light-app default (read/write) 2398312 2400232 1920 0.1
.bss 113104 113144 40 0.0
.data 2536 2504 -32 -1.3
.text 1356576 1358496 1920 0.1
lock-app default (read/write) 2361856 2363792 1936 0.1
.bss 112848 112888 40 0.0
.data 2496 2464 -32 -1.3
.text 1320120 1322056 1936 0.1
telink lighting-app tlsr9518adk80d (read/write) 888878 889538 660 0.1
bss 86968 87024 56 0.1
noinit 37160 37160 0 0.0
text 628158 628558 400 0.1

@github-actions
Copy link

github-actions bot commented Mar 10, 2022

PR #16020: Size comparison from c49b115 to f36fc92

Increases above 0.2%:

platform target config section c49b115 f36fc92 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 598102 599674 1572 0.3
.app_xip_area 505684 507244 1560 0.3
lock cyw930739m2evb_01 (read/write) 555970 557458 1488 0.3
.app_xip_area 465088 466556 1468 0.3
ota-requestor cyw930739m2evb_01 (read/write) 565978 567454 1476 0.3
.app_xip_area 465408 466872 1464 0.3
efr32 lighting-app BRD4161A (read only) 919808 922900 3092 0.3
.text 919800 922892 3092 0.3
BRD4161A+rpc (read only) 948620 951752 3132 0.3
.text 948612 951744 3132 0.3
window-app BRD4161A (read only) 852364 855444 3080 0.4
.text 852356 855436 3080 0.4
k32w light k32w061+release .text 609588 611224 1636 0.3
lock k32w061+release .text 610488 612124 1636 0.3
linux all-clusters-app debug (read only) 2430753 2458409 27656 1.1
.bss 60352 60576 224 0.4
.rodata 205797 214053 8256 4.0
.text 2061970 2081298 19328 0.9
bridge-app debug+rpc (read only) 1736053 1741613 5560 0.3
.rodata 141964 145100 3136 2.2
.text 1478117 1481141 3024 0.2
chip-tool debug .bss 25640 25704 64 0.2
.rodata 514388 517524 3136 0.6
door-lock-app debug (read only) 1950353 1976473 26120 1.3
.bss 50656 50880 224 0.4
.rodata 173884 180444 6560 3.8
.text 1627826 1647314 19488 1.2
lighting-app debug+rpc (read only) 2082521 2108017 25496 1.2
(read/write) 124616 124904 288 0.2
.bss 51456 51680 224 0.4
.rodata 166076 172892 6816 4.1
.text 1760786 1779394 18608 1.1
ota-provider-app debug (read only) 1883753 1909409 25656 1.4
(read/write) 114896 115152 256 0.2
.bss 50464 50688 224 0.4
.rodata 159091 165171 6080 3.8
.text 1573938 1593442 19504 1.2
ota-requestor-app debug (read only) 1911497 1937505 26008 1.4
.bss 51552 51776 224 0.4
.rodata 155084 161388 6304 4.1
.text 1605538 1625170 19632 1.2
shell debug (read only) 2396769 2405113 8344 0.3
.rodata 205746 211602 5856 2.8
thermostat-no-ble arm64 (read only) 2178892 2197612 18720 0.9
.bss 65393 65601 208 0.3
.data 1048 1056 8 0.8
.got 4232 4280 48 1.1
.init_array 352 360 8 2.3
.rodata 133132 136268 3136 2.4
.text 1827184 1842320 15136 0.8
tv-app debug (read only) 2622457 2650585 28128 1.1
.rodata 199389 208037 8648 4.3
.text 2248978 2268386 19408 0.9
Increases (30 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section c49b115 f36fc92 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 598102 599674 1572 0.3
.app_xip_area 505684 507244 1560 0.3
.bss 75108 75168 60 0.1
lock cyw930739m2evb_01 (read/write) 555970 557458 1488 0.3
.app_xip_area 465088 466556 1468 0.3
.bss 73612 73672 60 0.1
ota-requestor cyw930739m2evb_01 (read/write) 565978 567454 1476 0.3
.app_xip_area 465408 466872 1464 0.3
.bss 82980 83032 52 0.1
efr32 lighting-app BRD4161A (read only) 919808 922900 3092 0.3
(read/write) 128256 128280 24 0.0
.bss 126216 126280 64 0.1
.text 919800 922892 3092 0.3
BRD4161A+rpc (read only) 948620 951752 3132 0.3
(read/write) 144212 144240 28 0.0
.bss 141992 142056 64 0.0
.text 948612 951744 3132 0.3
window-app BRD4161A (read only) 852364 855444 3080 0.4
(read/write) 126220 126244 24 0.0
.bss 124304 124368 64 0.1
.text 852356 855436 3080 0.4
esp32 all-clusters-app c3devkit (read only) 957766 958852 1086 0.1
(read/write) 1393810 1394162 352 0.0
.dram0.bss 63576 63640 64 0.1
.flash.rodata 197096 197400 304 0.2
.flash.text 957766 958852 1086 0.1
m5stack (read only) 1012875 1014651 1776 0.2
(read/write) 461052 461380 328 0.1
.dram0.bss 69096 69152 56 0.1
.flash.rodata 226056 226360 304 0.1
.flash.text 1007491 1009267 1776 0.2
k32w light k32w061+release (read/write) 694464 696108 1644 0.2
.bss 77152 77200 48 0.1
.text 609588 611224 1636 0.3
lock k32w061+release (read/write) 695324 696984 1660 0.2
.bss 77072 77136 64 0.1
.text 610488 612124 1636 0.3
linux all-clusters-app debug (read only) 2430753 2458409 27656 1.1
(read/write) 145872 146128 256 0.2
.bss 60352 60576 224 0.4
.data.rel.ro 78424 78488 64 0.1
.rodata 205797 214053 8256 4.0
.text 2061970 2081298 19328 0.9
bridge-app debug+rpc (read only) 1736053 1741613 5560 0.3
.bss 47624 47688 64 0.1
.rodata 141964 145100 3136 2.2
.text 1478117 1481141 3024 0.2
chip-tool debug (read only) 10093029 10097549 4520 0.0
.bss 25640 25704 64 0.2
.rodata 514388 517524 3136 0.6
.text 8795957 8797941 1984 0.0
chip-tool-ipv6only arm64 .bss 43953 44001 48 0.1
.rodata 492084 492180 96 0.0
.text 8185732 8186084 352 0.0
door-lock-app debug (read only) 1950353 1976473 26120 1.3
(read/write) 119296 119520 224 0.2
.bss 50656 50880 224 0.4
.data.rel.ro 62184 62232 48 0.1
.rodata 173884 180444 6560 3.8
.text 1627826 1647314 19488 1.2
lighting-app debug+rpc (read only) 2082521 2108017 25496 1.2
(read/write) 124616 124904 288 0.2
.bss 51456 51680 224 0.4
.data.rel.ro 66104 66200 96 0.1
.rodata 166076 172892 6816 4.1
.text 1760786 1779394 18608 1.1
ota-provider-app debug (read only) 1883753 1909409 25656 1.4
(read/write) 114896 115152 256 0.2
.bss 50464 50688 224 0.4
.data.rel.ro 57464 57528 64 0.1
.rodata 159091 165171 6080 3.8
.text 1573938 1593442 19504 1.2
ota-requestor-app debug (read only) 1911497 1937505 26008 1.4
(read/write) 117992 118216 224 0.2
.bss 51552 51776 224 0.4
.data.rel.ro 59512 59560 48 0.1
.rodata 155084 161388 6304 4.1
.text 1605538 1625170 19632 1.2
shell debug (read only) 2396769 2405113 8344 0.3
.bss 70472 70536 64 0.1
.rodata 205746 211602 5856 2.8
.text 2034450 2037538 3088 0.2
thermostat-no-ble arm64 (read only) 2178892 2197612 18720 0.9
(read/write) 148801 149153 352 0.2
.bss 65393 65601 208 0.3
.data 1048 1056 8 0.8
.data.rel.ro 75160 75232 72 0.1
.got 4232 4280 48 1.1
.init_array 352 360 8 2.3
.rodata 133132 136268 3136 2.4
.text 1827184 1842320 15136 0.8
tv-app debug (read only) 2622457 2650585 28128 1.1
(read/write) 250360 250656 296 0.1
.bss 167520 167784 264 0.2
.data.rel.ro 73624 73688 64 0.1
.rodata 199389 208037 8648 4.3
.text 2248978 2268386 19408 0.9
mbed all-clusters-app CY8CPROTO_062_4343W+release .bss 192160 192200 40 0.0
lighting-app CY8CPROTO_062_4343W+release .bss 187476 187508 32 0.0
lock-app CY8CPROTO_062_4343W+release .bss 186212 186252 40 0.0
shell CY8CPROTO_062_4343W+release .bss 186016 186056 40 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1151675 1153243 1568 0.1
bss 146208 146264 56 0.0
rodata 144452 144772 320 0.2
text 785760 787052 1292 0.2
p6 all-clusters-app default (read/write) 2494296 2497352 3056 0.1
.bss 119640 119680 40 0.0
.text 1452560 1455616 3056 0.2
light-app default (read/write) 2398312 2401336 3024 0.1
.bss 113104 113144 40 0.0
.text 1356576 1359600 3024 0.2
lock-app default (read/write) 2361856 2364896 3040 0.1
.bss 112848 112888 40 0.0
.text 1320120 1323160 3040 0.2
telink lighting-app tlsr9518adk80d (read/write) 888878 890358 1480 0.2
bss 86968 87024 56 0.1
text 628158 629280 1122 0.2
Decreases (27 builds for cyw30739, efr32, esp32, k32w, linux, mbed, p6)
platform target config section c49b115 f36fc92 change % change
cyw30739 light cyw930739m2evb_01 .data 652 612 -40 -6.1
lock cyw930739m2evb_01 .data 616 576 -40 -6.5
ota-requestor cyw930739m2evb_01 .data 552 516 -36 -6.5
efr32 lighting-app BRD4161A .data 2040 2000 -40 -2.0
BRD4161A+rpc .data 2220 2180 -40 -1.8
window-app BRD4161A .data 1916 1876 -40 -2.1
esp32 all-clusters-app c3devkit .dram0.data 14220 14204 -16 -0.1
m5stack .dram0.data 34064 34032 -32 -0.1
k32w light k32w061+release .data 1924 1884 -40 -2.1
lock k32w061+release .data 1964 1924 -40 -2.0
linux all-clusters-app debug .data 1360 1328 -32 -2.4
bridge-app debug+rpc (read/write) 92784 92624 -160 -0.2
.data 2016 1984 -32 -1.6
.data.rel.ro 38064 37872 -192 -0.5
chip-tool debug (read/write) 358168 357976 -192 -0.1
.data 1152 1088 -64 -5.6
.data.rel.ro 325352 325160 -192 -0.1
chip-tool-ipv6only arm64 (read only) 9728988 9728908 -80 -0.0
(read/write) 475953 475729 -224 -0.0
.data 1200 1160 -40 -3.3
.data.rel.ro 371712 371496 -216 -0.1
.got 55296 55272 -24 -0.0
door-lock-app debug .data 1056 1024 -32 -3.0
lighting-app debug+rpc .data 1536 1504 -32 -2.1
ota-provider-app debug .data 1320 1288 -32 -2.4
ota-requestor-app debug .data 1480 1448 -32 -2.2
shell debug (read/write) 150088 149864 -224 -0.1
.data 864 800 -64 -7.4
.data.rel.ro 73064 72840 -224 -0.3
tv-app debug .data 3168 3136 -32 -1.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2456840 2455768 -1072 -0.0
.data 5504 5464 -40 -0.7
.text 1419412 1418340 -1072 -0.1
lighting-app CY8CPROTO_062_4343W+release (read/write) 2418240 2417168 -1072 -0.0
.data 5816 5792 -24 -0.4
.text 1380812 1379740 -1072 -0.1
lock-app CY8CPROTO_062_4343W+release (read/write) 2351484 2350348 -1136 -0.0
.data 5792 5768 -24 -0.4
.text 1314084 1312948 -1136 -0.1
shell CY8CPROTO_062_4343W+release (read/write) 2344464 2343384 -1080 -0.0
.data 5608 5576 -32 -0.6
.text 1307036 1305956 -1080 -0.1
p6 all-clusters-app default .data 2680 2648 -32 -1.2
light-app default .data 2536 2504 -32 -1.3
lock-app default .data 2496 2464 -32 -1.3
Full report (30 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section c49b115 f36fc92 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 598102 599674 1572 0.3
.app_xip_area 505684 507244 1560 0.3
.bss 75108 75168 60 0.1
.data 652 612 -40 -6.1
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 555970 557458 1488 0.3
.app_xip_area 465088 466556 1468 0.3
.bss 73612 73672 60 0.1
.data 616 576 -40 -6.5
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 565978 567454 1476 0.3
.app_xip_area 465408 466872 1464 0.3
.bss 82980 83032 52 0.1
.data 552 516 -36 -6.5
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 919808 922900 3092 0.3
(read/write) 128256 128280 24 0.0
.bss 126216 126280 64 0.1
.data 2040 2000 -40 -2.0
.text 919800 922892 3092 0.3
BRD4161A+rpc (read only) 948620 951752 3132 0.3
(read/write) 144212 144240 28 0.0
.bss 141992 142056 64 0.0
.data 2220 2180 -40 -1.8
.text 948612 951744 3132 0.3
window-app BRD4161A (read only) 852364 855444 3080 0.4
(read/write) 126220 126244 24 0.0
.bss 124304 124368 64 0.1
.data 1916 1876 -40 -2.1
.text 852356 855436 3080 0.4
esp32 all-clusters-app c3devkit (read only) 957766 958852 1086 0.1
(read/write) 1393810 1394162 352 0.0
.dram0.bss 63576 63640 64 0.1
.dram0.data 14220 14204 -16 -0.1
.flash.rodata 197096 197400 304 0.2
.flash.text 957766 958852 1086 0.1
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1012875 1014651 1776 0.2
(read/write) 461052 461380 328 0.1
.dram0.bss 69096 69152 56 0.1
.dram0.data 34064 34032 -32 -0.1
.flash.rodata 226056 226360 304 0.1
.flash.text 1007491 1009267 1776 0.2
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 694464 696108 1644 0.2
.bss 77152 77200 48 0.1
.data 1924 1884 -40 -2.1
.text 609588 611224 1636 0.3
lock k32w061+release (read/write) 695324 696984 1660 0.2
.bss 77072 77136 64 0.1
.data 1964 1924 -40 -2.0
.text 610488 612124 1636 0.3
linux all-clusters-app debug (read only) 2430753 2458409 27656 1.1
(read/write) 145872 146128 256 0.2
.bss 60352 60576 224 0.4
.data 1360 1328 -32 -2.4
.data.rel.ro 78424 78488 64 0.1
.dynamic 592 592 0 0.0
.got 4176 4176 0 0.0
.init 27 27 0 0.0
.init_array 936 936 0 0.0
.rodata 205797 214053 8256 4.0
.text 2061970 2081298 19328 0.9
bridge-app debug+rpc (read only) 1736053 1741613 5560 0.3
(read/write) 92784 92624 -160 -0.2
.bss 47624 47688 64 0.1
.data 2016 1984 -32 -1.6
.data.rel.ro 38064 37872 -192 -0.5
.dynamic 592 592 0 0.0
.got 3928 3928 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 141964 145100 3136 2.2
.text 1478117 1481141 3024 0.2
chip-tool debug (read only) 10093029 10097549 4520 0.0
(read/write) 358168 357976 -192 -0.1
.bss 25640 25704 64 0.2
.data 1152 1088 -64 -5.6
.data.rel.ro 325352 325160 -192 -0.1
.dynamic 608 608 0 0.0
.got 4776 4776 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 514388 517524 3136 0.6
.text 8795957 8797941 1984 0.0
chip-tool-ipv6only arm64 (read only) 9728988 9728908 -80 -0.0
(read/write) 475953 475729 -224 -0.0
.bss 43953 44001 48 0.1
.data 1200 1160 -40 -3.3
.data.rel.ro 371712 371496 -216 -0.1
.dynamic 560 560 0 0.0
.got 55296 55272 -24 -0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 492084 492180 96 0.0
.text 8185732 8186084 352 0.0
door-lock-app debug (read only) 1950353 1976473 26120 1.3
(read/write) 119296 119520 224 0.2
.bss 50656 50880 224 0.4
.data 1056 1024 -32 -3.0
.data.rel.ro 62184 62232 48 0.1
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 173884 180444 6560 3.8
.text 1627826 1647314 19488 1.2
lighting-app debug+rpc (read only) 2082521 2108017 25496 1.2
(read/write) 124616 124904 288 0.2
.bss 51456 51680 224 0.4
.data 1536 1504 -32 -2.1
.data.rel.ro 66104 66200 96 0.1
.dynamic 608 608 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 736 736 0 0.0
.rodata 166076 172892 6816 4.1
.text 1760786 1779394 18608 1.1
ota-provider-app debug (read only) 1883753 1909409 25656 1.4
(read/write) 114896 115152 256 0.2
.bss 50464 50688 224 0.4
.data 1320 1288 -32 -2.4
.data.rel.ro 57464 57528 64 0.1
.dynamic 608 608 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 159091 165171 6080 3.8
.text 1573938 1593442 19504 1.2
ota-requestor-app debug (read only) 1911497 1937505 26008 1.4
(read/write) 117992 118216 224 0.2
.bss 51552 51776 224 0.4
.data 1480 1448 -32 -2.2
.data.rel.ro 59512 59560 48 0.1
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 155084 161388 6304 4.1
.text 1605538 1625170 19632 1.2
shell debug (read only) 2396769 2405113 8344 0.3
(read/write) 150088 149864 -224 -0.1
.bss 70472 70536 64 0.1
.data 864 800 -64 -7.4
.data.rel.ro 73064 72840 -224 -0.3
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 205746 211602 5856 2.8
.text 2034450 2037538 3088 0.2
thermostat-no-ble arm64 (read only) 2178892 2197612 18720 0.9
(read/write) 148801 149153 352 0.2
.bss 65393 65601 208 0.3
.data 1048 1056 8 0.8
.data.rel.ro 75160 75232 72 0.1
.dynamic 560 560 0 0.0
.got 4232 4280 48 1.1
.init 24 24 0 0.0
.init_array 352 360 8 2.3
.rodata 133132 136268 3136 2.4
.text 1827184 1842320 15136 0.8
tv-app debug (read only) 2622457 2650585 28128 1.1
(read/write) 250360 250656 296 0.1
.bss 167520 167784 264 0.2
.data 3168 3136 -32 -1.0
.data.rel.ro 73624 73688 64 0.1
.dynamic 592 592 0 0.0
.got 4544 4544 0 0.0
.init 27 27 0 0.0
.init_array 880 880 0 0.0
.rodata 199389 208037 8648 4.3
.text 2248978 2268386 19408 0.9
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2456840 2455768 -1072 -0.0
.bss 192160 192200 40 0.0
.data 5504 5464 -40 -0.7
.text 1419412 1418340 -1072 -0.1
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2418240 2417168 -1072 -0.0
.bss 187476 187508 32 0.0
.data 5816 5792 -24 -0.4
.text 1380812 1379740 -1072 -0.1
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2351484 2350348 -1136 -0.0
.bss 186212 186252 40 0.0
.data 5792 5768 -24 -0.4
.text 1314084 1312948 -1136 -0.1
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2344464 2343384 -1080 -0.0
.bss 186016 186056 40 0.0
.data 5608 5576 -32 -0.6
.text 1307036 1305956 -1080 -0.1
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1151675 1153243 1568 0.1
bss 146208 146264 56 0.0
rodata 144452 144772 320 0.2
text 785760 787052 1292 0.2
p6 all-clusters-app default (read/write) 2494296 2497352 3056 0.1
.bss 119640 119680 40 0.0
.data 2680 2648 -32 -1.2
.text 1452560 1455616 3056 0.2
light-app default (read/write) 2398312 2401336 3024 0.1
.bss 113104 113144 40 0.0
.data 2536 2504 -32 -1.3
.text 1356576 1359600 3024 0.2
lock-app default (read/write) 2361856 2364896 3040 0.1
.bss 112848 112888 40 0.0
.data 2496 2464 -32 -1.3
.text 1320120 1323160 3040 0.2
telink lighting-app tlsr9518adk80d (read/write) 888878 890358 1480 0.2
bss 86968 87024 56 0.1
noinit 37160 37160 0 0.0
text 628158 629280 1122 0.2

Copy link
Contributor

@Damian-Nordic Damian-Nordic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have some further suggestions and there's one duplication in BUILD.gn, but looking good overall.

@tcarmelveilleux
Copy link
Contributor Author

Have some further suggestions and there's one duplication in BUILD.gn, but looking good overall.

Will fix as a follow-up today

@github-actions
Copy link

github-actions bot commented Mar 11, 2022

PR #16020: Size comparison from 31037c1 to 3f7ed46

Increases above 0.2%:

platform target config section 31037c1 3f7ed46 change % change
linux all-clusters-app debug (read only) 2436881 2454265 17384 0.7
.bss 60352 60576 224 0.4
.rodata 206213 209541 3328 1.6
.text 2067730 2081858 14128 0.7
bridge-app debug+rpc .bss 47624 47720 96 0.2
chip-tool debug .bss 25640 25704 64 0.2
door-lock-app debug (read only) 1956545 1974025 17480 0.9
.bss 50656 50912 256 0.5
.rodata 174332 177628 3296 1.9
.text 1633618 1647874 14256 0.9
lighting-app debug+rpc (read only) 2088681 2105185 16504 0.8
(read/write) 124584 124872 288 0.2
.bss 51456 51712 256 0.5
.rodata 166492 169756 3264 2.0
.text 1766578 1779890 13312 0.8
ota-provider-app debug (read only) 1889961 1907433 17472 0.9
.bss 50496 50752 256 0.5
.rodata 159539 162827 3288 2.1
.text 1579746 1594002 14256 0.9
ota-requestor-app debug (read only) 1917593 1935097 17504 0.9
.bss 51552 51808 256 0.5
.rodata 155500 158820 3320 2.1
.text 1611266 1625522 14256 0.9
thermostat-no-ble arm64 (read only) 2181588 2197132 15544 0.7
.bss 65409 65617 208 0.3
.init_array 352 360 8 2.3
.rodata 133444 136268 2824 2.1
.text 1829984 1842368 12384 0.7
tv-app debug (read only) 2628553 2645865 17312 0.7
.rodata 199805 203029 3224 1.6
.text 2254706 2268866 14160 0.6
Increases (30 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 31037c1 3f7ed46 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 599102 599538 436 0.1
.app_xip_area 506700 507116 416 0.1
.bss 75108 75176 68 0.1
lock cyw930739m2evb_01 (read/write) 556986 557398 412 0.1
.app_xip_area 466112 466504 392 0.1
.bss 73612 73680 68 0.1
ota-requestor cyw930739m2evb_01 (read/write) 566766 567226 460 0.1
.app_xip_area 466228 466684 456 0.1
.bss 82932 82984 52 0.1
efr32 lighting-app BRD4161A (read only) 921128 922884 1756 0.2
(read/write) 128232 128256 24 0.0
.bss 126176 126248 72 0.1
.text 921120 922876 1756 0.2
BRD4161A+rpc (read only) 949940 951704 1764 0.2
(read/write) 144184 144216 32 0.0
.bss 141952 142024 72 0.1
.text 949932 951696 1764 0.2
window-app BRD4161A (read only) 853732 855508 1776 0.2
(read/write) 126216 126240 24 0.0
.bss 124312 124376 64 0.1
.text 853724 855500 1776 0.2
esp32 all-clusters-app c3devkit (read only) 958524 958850 326 0.0
(read/write) 1393858 1394058 200 0.0
.dram0.bss 63584 63648 64 0.1
.flash.rodata 197144 197312 168 0.1
.flash.text 958524 958850 326 0.0
m5stack (read only) 1014127 1014575 448 0.0
(read/write) 461092 461292 200 0.0
.dram0.bss 69104 69168 64 0.1
.flash.rodata 226104 226272 168 0.1
.flash.text 1008743 1009191 448 0.0
k32w light k32w061+release (read/write) 695388 695904 516 0.1
.bss 77112 77160 48 0.1
.text 610548 611056 508 0.1
lock k32w061+release (read/write) 696360 696896 536 0.1
.bss 77080 77152 72 0.1
.text 611528 612036 508 0.1
linux all-clusters-app debug (read only) 2436881 2454265 17384 0.7
(read/write) 145840 146064 224 0.2
.bss 60352 60576 224 0.4
.data.rel.ro 78424 78440 16 0.0
.rodata 206213 209541 3328 1.6
.text 2067730 2081858 14128 0.7
bridge-app debug+rpc .bss 47624 47720 96 0.2
.rodata 142348 142508 160 0.1
chip-tool debug .bss 25640 25704 64 0.2
.rodata 514516 514612 96 0.0
chip-tool-ipv6only arm64 .bss 43953 44017 64 0.1
.rodata 492148 492180 32 0.0
door-lock-app debug (read only) 1956545 1974025 17480 0.9
(read/write) 119264 119488 224 0.2
.bss 50656 50912 256 0.5
.rodata 174332 177628 3296 1.9
.text 1633618 1647874 14256 0.9
lighting-app debug+rpc (read only) 2088681 2105185 16504 0.8
(read/write) 124584 124872 288 0.2
.bss 51456 51712 256 0.5
.data.rel.ro 66104 66168 64 0.1
.rodata 166492 169756 3264 2.0
.text 1766578 1779890 13312 0.8
ota-provider-app debug (read only) 1889961 1907433 17472 0.9
(read/write) 114896 115120 224 0.2
.bss 50496 50752 256 0.5
.data.rel.ro 57464 57480 16 0.0
.rodata 159539 162827 3288 2.1
.text 1579746 1594002 14256 0.9
ota-requestor-app debug (read only) 1917593 1935097 17504 0.9
(read/write) 117960 118184 224 0.2
.bss 51552 51808 256 0.5
.rodata 155500 158820 3320 2.1
.text 1611266 1625522 14256 0.9
shell debug .bss 70472 70568 96 0.1
.rodata 206162 206354 192 0.1
thermostat-no-ble arm64 (read only) 2181588 2197132 15544 0.7
(read/write) 148625 148961 336 0.2
.bss 65409 65617 208 0.3
.data.rel.ro 74968 75072 104 0.1
.got 4256 4264 8 0.2
.init_array 352 360 8 2.3
.rodata 133444 136268 2824 2.1
.text 1829984 1842368 12384 0.7
tv-app debug (read only) 2628553 2645865 17312 0.7
(read/write) 250360 250648 288 0.1
.bss 167520 167808 288 0.2
.data.rel.ro 73624 73656 32 0.0
.rodata 199805 203029 3224 1.6
.text 2254706 2268866 14160 0.6
mbed all-clusters-app CY8CPROTO_062_4343W+release .bss 192136 192184 48 0.0
lighting-app CY8CPROTO_062_4343W+release .bss 187452 187492 40 0.0
lock-app CY8CPROTO_062_4343W+release .bss 186212 186260 48 0.0
shell CY8CPROTO_062_4343W+release .bss 185992 186032 40 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1152643 1153075 432 0.0
bss 146188 146248 60 0.0
rodata 144516 144684 168 0.1
text 786676 786980 304 0.0
p6 all-clusters-app default (read/write) 2495680 2497416 1736 0.1
.bss 119640 119680 40 0.0
.text 1453944 1455680 1736 0.1
light-app default (read/write) 2399680 2401400 1720 0.1
.bss 113104 113144 40 0.0
.text 1357944 1359664 1720 0.1
lock-app default (read/write) 2363240 2364944 1704 0.1
.bss 112848 112888 40 0.0
.text 1321504 1323208 1704 0.1
telink lighting-app tlsr9518adk80d (read/write) 889766 890270 504 0.1
bss 86976 87032 56 0.1
text 628970 629278 308 0.0
Decreases (27 builds for cyw30739, efr32, esp32, k32w, linux, mbed, p6)
platform target config section 31037c1 3f7ed46 change % change
cyw30739 light cyw930739m2evb_01 .data 640 596 -44 -6.9
lock cyw930739m2evb_01 .data 604 560 -44 -7.3
ota-requestor cyw930739m2evb_01 .data 564 520 -44 -7.8
efr32 lighting-app BRD4161A .data 2052 2008 -44 -2.1
BRD4161A+rpc .data 2232 2188 -44 -2.0
window-app BRD4161A .data 1904 1864 -40 -2.1
esp32 all-clusters-app c3devkit .dram0.data 14220 14188 -32 -0.2
m5stack .dram0.data 34048 34016 -32 -0.1
k32w light k32w061+release .data 1928 1888 -40 -2.1
lock k32w061+release .data 1952 1908 -44 -2.3
linux all-clusters-app debug .data 1328 1296 -32 -2.4
bridge-app debug+rpc (read only) 1742165 1739357 -2808 -0.2
(read/write) 92784 92592 -192 -0.2
.data 2016 1952 -64 -3.2
.data.rel.ro 38064 37824 -240 -0.6
.text 1483893 1481669 -2224 -0.1
chip-tool debug (read only) 10096133 10093261 -2872 -0.0
(read/write) 357976 357752 -224 -0.1
.data 1120 1056 -64 -5.7
.data.rel.ro 325208 324968 -240 -0.1
.text 8799365 8797141 -2224 -0.0
chip-tool-ipv6only arm64 (read only) 9729660 9727596 -2064 -0.0
(read/write) 475729 475537 -192 -0.0
.data 1176 1128 -48 -4.1
.data.rel.ro 371520 371336 -184 -0.0
.got 55280 55256 -24 -0.0
.text 8186868 8185300 -1568 -0.0
door-lock-app debug .data 1024 992 -32 -3.1
lighting-app debug+rpc .data 1504 1472 -32 -2.1
ota-provider-app debug .data 1288 1256 -32 -2.5
ota-requestor-app debug .data 1448 1416 -32 -2.2
shell debug (read only) 2402881 2400153 -2728 -0.1
(read/write) 150088 149864 -224 -0.1
.data 848 784 -64 -7.5
.data.rel.ro 73064 72808 -256 -0.4
.text 2040194 2038018 -2176 -0.1
tv-app debug .data 3168 3136 -32 -1.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2456368 2455624 -744 -0.0
.data 5488 5448 -40 -0.7
.text 1418940 1418196 -744 -0.1
lighting-app CY8CPROTO_062_4343W+release (read/write) 2417768 2417024 -744 -0.0
.data 5808 5776 -32 -0.6
.text 1380340 1379596 -744 -0.1
lock-app CY8CPROTO_062_4343W+release (read/write) 2351012 2350268 -744 -0.0
.data 5784 5752 -32 -0.6
.text 1313612 1312868 -744 -0.1
shell CY8CPROTO_062_4343W+release (read/write) 2344000 2343248 -752 -0.0
.data 5592 5560 -32 -0.6
.text 1306572 1305820 -752 -0.1
p6 all-clusters-app default .data 2672 2632 -40 -1.5
light-app default .data 2528 2488 -40 -1.6
lock-app default .data 2488 2448 -40 -1.6
Full report (30 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 31037c1 3f7ed46 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 599102 599538 436 0.1
.app_xip_area 506700 507116 416 0.1
.bss 75108 75176 68 0.1
.data 640 596 -44 -6.9
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 556986 557398 412 0.1
.app_xip_area 466112 466504 392 0.1
.bss 73612 73680 68 0.1
.data 604 560 -44 -7.3
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 566766 567226 460 0.1
.app_xip_area 466228 466684 456 0.1
.bss 82932 82984 52 0.1
.data 564 520 -44 -7.8
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 921128 922884 1756 0.2
(read/write) 128232 128256 24 0.0
.bss 126176 126248 72 0.1
.data 2052 2008 -44 -2.1
.text 921120 922876 1756 0.2
BRD4161A+rpc (read only) 949940 951704 1764 0.2
(read/write) 144184 144216 32 0.0
.bss 141952 142024 72 0.1
.data 2232 2188 -44 -2.0
.text 949932 951696 1764 0.2
window-app BRD4161A (read only) 853732 855508 1776 0.2
(read/write) 126216 126240 24 0.0
.bss 124312 124376 64 0.1
.data 1904 1864 -40 -2.1
.text 853724 855500 1776 0.2
esp32 all-clusters-app c3devkit (read only) 958524 958850 326 0.0
(read/write) 1393858 1394058 200 0.0
.dram0.bss 63584 63648 64 0.1
.dram0.data 14220 14188 -32 -0.2
.flash.rodata 197144 197312 168 0.1
.flash.text 958524 958850 326 0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1014127 1014575 448 0.0
(read/write) 461092 461292 200 0.0
.dram0.bss 69104 69168 64 0.1
.dram0.data 34048 34016 -32 -0.1
.flash.rodata 226104 226272 168 0.1
.flash.text 1008743 1009191 448 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 695388 695904 516 0.1
.bss 77112 77160 48 0.1
.data 1928 1888 -40 -2.1
.text 610548 611056 508 0.1
lock k32w061+release (read/write) 696360 696896 536 0.1
.bss 77080 77152 72 0.1
.data 1952 1908 -44 -2.3
.text 611528 612036 508 0.1
linux all-clusters-app debug (read only) 2436881 2454265 17384 0.7
(read/write) 145840 146064 224 0.2
.bss 60352 60576 224 0.4
.data 1328 1296 -32 -2.4
.data.rel.ro 78424 78440 16 0.0
.dynamic 592 592 0 0.0
.got 4176 4176 0 0.0
.init 27 27 0 0.0
.init_array 936 936 0 0.0
.rodata 206213 209541 3328 1.6
.text 2067730 2081858 14128 0.7
bridge-app debug+rpc (read only) 1742165 1739357 -2808 -0.2
(read/write) 92784 92592 -192 -0.2
.bss 47624 47720 96 0.2
.data 2016 1952 -64 -3.2
.data.rel.ro 38064 37824 -240 -0.6
.dynamic 592 592 0 0.0
.got 3928 3928 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 142348 142508 160 0.1
.text 1483893 1481669 -2224 -0.1
chip-tool debug (read only) 10096133 10093261 -2872 -0.0
(read/write) 357976 357752 -224 -0.1
.bss 25640 25704 64 0.2
.data 1120 1056 -64 -5.7
.data.rel.ro 325208 324968 -240 -0.1
.dynamic 608 608 0 0.0
.got 4776 4776 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 514516 514612 96 0.0
.text 8799365 8797141 -2224 -0.0
chip-tool-ipv6only arm64 (read only) 9729660 9727596 -2064 -0.0
(read/write) 475729 475537 -192 -0.0
.bss 43953 44017 64 0.1
.data 1176 1128 -48 -4.1
.data.rel.ro 371520 371336 -184 -0.0
.dynamic 560 560 0 0.0
.got 55280 55256 -24 -0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 492148 492180 32 0.0
.text 8186868 8185300 -1568 -0.0
door-lock-app debug (read only) 1956545 1974025 17480 0.9
(read/write) 119264 119488 224 0.2
.bss 50656 50912 256 0.5
.data 1024 992 -32 -3.1
.data.rel.ro 62184 62184 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 174332 177628 3296 1.9
.text 1633618 1647874 14256 0.9
lighting-app debug+rpc (read only) 2088681 2105185 16504 0.8
(read/write) 124584 124872 288 0.2
.bss 51456 51712 256 0.5
.data 1504 1472 -32 -2.1
.data.rel.ro 66104 66168 64 0.1
.dynamic 608 608 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 736 736 0 0.0
.rodata 166492 169756 3264 2.0
.text 1766578 1779890 13312 0.8
ota-provider-app debug (read only) 1889961 1907433 17472 0.9
(read/write) 114896 115120 224 0.2
.bss 50496 50752 256 0.5
.data 1288 1256 -32 -2.5
.data.rel.ro 57464 57480 16 0.0
.dynamic 608 608 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 159539 162827 3288 2.1
.text 1579746 1594002 14256 0.9
ota-requestor-app debug (read only) 1917593 1935097 17504 0.9
(read/write) 117960 118184 224 0.2
.bss 51552 51808 256 0.5
.data 1448 1416 -32 -2.2
.data.rel.ro 59512 59512 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 155500 158820 3320 2.1
.text 1611266 1625522 14256 0.9
shell debug (read only) 2402881 2400153 -2728 -0.1
(read/write) 150088 149864 -224 -0.1
.bss 70472 70568 96 0.1
.data 848 784 -64 -7.5
.data.rel.ro 73064 72808 -256 -0.4
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 206162 206354 192 0.1
.text 2040194 2038018 -2176 -0.1
thermostat-no-ble arm64 (read only) 2181588 2197132 15544 0.7
(read/write) 148625 148961 336 0.2
.bss 65409 65617 208 0.3
.data 1024 1024 0 0.0
.data.rel.ro 74968 75072 104 0.1
.dynamic 560 560 0 0.0
.got 4256 4264 8 0.2
.init 24 24 0 0.0
.init_array 352 360 8 2.3
.rodata 133444 136268 2824 2.1
.text 1829984 1842368 12384 0.7
tv-app debug (read only) 2628553 2645865 17312 0.7
(read/write) 250360 250648 288 0.1
.bss 167520 167808 288 0.2
.data 3168 3136 -32 -1.0
.data.rel.ro 73624 73656 32 0.0
.dynamic 592 592 0 0.0
.got 4544 4544 0 0.0
.init 27 27 0 0.0
.init_array 880 880 0 0.0
.rodata 199805 203029 3224 1.6
.text 2254706 2268866 14160 0.6
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2456368 2455624 -744 -0.0
.bss 192136 192184 48 0.0
.data 5488 5448 -40 -0.7
.text 1418940 1418196 -744 -0.1
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2417768 2417024 -744 -0.0
.bss 187452 187492 40 0.0
.data 5808 5776 -32 -0.6
.text 1380340 1379596 -744 -0.1
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2351012 2350268 -744 -0.0
.bss 186212 186260 48 0.0
.data 5784 5752 -32 -0.6
.text 1313612 1312868 -744 -0.1
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2344000 2343248 -752 -0.0
.bss 185992 186032 40 0.0
.data 5592 5560 -32 -0.6
.text 1306572 1305820 -752 -0.1
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1152643 1153075 432 0.0
bss 146188 146248 60 0.0
rodata 144516 144684 168 0.1
text 786676 786980 304 0.0
p6 all-clusters-app default (read/write) 2495680 2497416 1736 0.1
.bss 119640 119680 40 0.0
.data 2672 2632 -40 -1.5
.text 1453944 1455680 1736 0.1
light-app default (read/write) 2399680 2401400 1720 0.1
.bss 113104 113144 40 0.0
.data 2528 2488 -40 -1.6
.text 1357944 1359664 1720 0.1
lock-app default (read/write) 2363240 2364944 1704 0.1
.bss 112848 112888 40 0.0
.data 2488 2448 -40 -1.6
.text 1321504 1323208 1704 0.1
telink lighting-app tlsr9518adk80d (read/write) 889766 890270 504 0.1
bss 86976 87032 56 0.1
noinit 37160 37160 0 0.0
text 628970 629278 308 0.0

@tcarmelveilleux tcarmelveilleux merged commit 8f86c43 into project-chip:master Mar 11, 2022
andrei-menzopol pushed a commit to andrei-menzopol/connectedhomeip that referenced this pull request Apr 14, 2022
…roject-chip#16020)

* Introduce CommissionableDataProvider for discriminator and verifier

- Current API in ConfigurationManager makes it very hard to provide
  spec-mandated per-device SPAKE2+ parameters (verifier, salt, iteration
  counts) and discovery discriminator, since it expects "in-app" common
  SDK handling of the data for something that actually usually
  comes from the factory.

This PR does the following:

- Adds CommissionableDataProvider interface, of which an instance
  is known to the ConfigurationManager.
- Adds a legacy path to avoid requiring setting a
  CommissionableDataProvider in the short term
- A linux implementation of CommissionableDataProvider showcasing
  providing externally generated SPAKE2+ verifier/salt/iterations
- Refactoring of all direct usage of ConfigurationManager to
  get discriminator/SPAKE2+ parameters

Testing done:
- Cert tests still pass with no change
- All unit tests still pass, including those modified
- Setting GN arg `chip_use_transitional_commissionable_data_provider=0`
  properly causes targets that don't provide an implementation
  from running.
- Manually verified the new Linux command-line arguments to
  all-clusters-app allow passing custom version of verifier or iteration
  counts.

Fixes project-chip#15543

* Restyled by clang-format

* Restyled by gn

* Fix PRIu32

* Fix more presubmit rework failures

* Fix one missing override

* Address review comments

* Restyled by clang-format

* Fix more CI, do more renames

* Restyled by clang-format

* Address review comments

* Restyled by clang-format

* Restyled by gn

* Fix doxygen stuff

* Fix fake ConfigurationaManagerImpl.h

* Fix cirque

* Address review comments from PR project-chip#16020

* Fix CI after refactor based on review comments

Co-authored-by: Restyled.io <commits@restyled.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add verifier interface to ConfigurationManager to allow per-device PAKE Verifier
5 participants