Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OTA] Remove extraneous using-declaration of ProviderLocationType #16054

Conversation

carol-apple
Copy link
Contributor

Problem

using ProviderLocationType = app::Clusters::OtaSoftwareUpdateRequestor::Structs::ProviderLocation::Type;is being used in multiple places within OTA components

Change overview

Minimize this declaration to only files that must declare it

Testing

Tree compiles

@github-actions
Copy link

github-actions bot commented Mar 10, 2022

PR #16054: Size comparison from 2727739 to b22cfa8

Full report (17 builds for cyw30739, efr32, esp32, k32w, linux, mbed, p6, telink)
platform target config section 2727739 b22cfa8 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 598026 598026 0 0.0
.app_xip_area 505608 505608 0 0.0
.bss 75108 75108 0 0.0
.data 652 652 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 555894 555894 0 0.0
.app_xip_area 465012 465012 0 0.0
.bss 73612 73612 0 0.0
.data 616 616 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 565998 565998 0 0.0
.app_xip_area 465412 465412 0 0.0
.bss 82996 82996 0 0.0
.data 552 552 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 919824 919824 0 0.0
(read/write) 128264 128264 0 0.0
.bss 126224 126224 0 0.0
.data 2040 2040 0 0.0
.text 919816 919816 0 0.0
BRD4161A+rpc (read only) 948652 948652 0 0.0
(read/write) 144220 144220 0 0.0
.bss 142000 142000 0 0.0
.data 2220 2220 0 0.0
.text 948644 948644 0 0.0
window-app BRD4161A (read only) 852300 852300 0 0.0
(read/write) 126220 126220 0 0.0
.bss 124304 124304 0 0.0
.data 1916 1916 0 0.0
.text 852292 852292 0 0.0
esp32 all-clusters-app c3devkit (read only) 957672 957672 0 0.0
(read/write) 1393778 1393778 0 0.0
.dram0.bss 63576 63576 0 0.0
.dram0.data 14220 14220 0 0.0
.flash.rodata 197064 197064 0 0.0
.flash.text 957672 957672 0 0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1012855 1012855 0 0.0
(read/write) 461028 461028 0 0.0
.dram0.bss 69096 69096 0 0.0
.dram0.data 34064 34064 0 0.0
.flash.rodata 226032 226032 0 0.0
.flash.text 1007471 1007471 0 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 694460 694460 0 0.0
.bss 77160 77160 0 0.0
.data 1924 1924 0 0.0
.text 609576 609576 0 0.0
lock k32w061+release (read/write) 695260 695260 0 0.0
.bss 77072 77072 0 0.0
.data 1964 1964 0 0.0
.text 610424 610424 0 0.0
linux chip-tool-ipv6only arm64 (read only) 9728940 9728940 0 0.0
(read/write) 475969 475969 0 0.0
.bss 43953 43953 0 0.0
.data 1200 1200 0 0.0
.data.rel.ro 371712 371712 0 0.0
.dynamic 560 560 0 0.0
.got 55304 55304 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 491892 491892 0 0.0
.text 8185860 8185860 0 0.0
thermostat-no-ble arm64 (read only) 2178588 2178588 0 0.0
(read/write) 148817 148817 0 0.0
.bss 65393 65393 0 0.0
.data 1048 1048 0 0.0
.data.rel.ro 75160 75160 0 0.0
.dynamic 560 560 0 0.0
.got 4240 4240 0 0.0
.init 24 24 0 0.0
.init_array 352 352 0 0.0
.rodata 133116 133116 0 0.0
.text 1826880 1826880 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2351388 2351388 0 0.0
.bss 186212 186212 0 0.0
.data 5792 5792 0 0.0
.text 1313988 1313988 0 0.0
p6 all-clusters-app default (read/write) 2494184 2494184 0 0.0
.bss 119640 119640 0 0.0
.data 2680 2680 0 0.0
.text 1452448 1452448 0 0.0
light-app default (read/write) 2398248 2398248 0 0.0
.bss 113104 113104 0 0.0
.data 2536 2536 0 0.0
.text 1356512 1356512 0 0.0
lock-app default (read/write) 2361808 2361808 0 0.0
.bss 112848 112848 0 0.0
.data 2496 2496 0 0.0
.text 1320072 1320072 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 888838 888838 0 0.0
bss 86968 86968 0 0.0
noinit 37160 37160 0 0.0
text 628138 628138 0 0.0

@tcarmelveilleux tcarmelveilleux merged commit c8a3dd3 into project-chip:master Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants