-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-instate reverted PR: TLV to JSON converter #16086
Merged
andy31415
merged 1 commit into
project-chip:master
from
mrjerryjohns:tlv-json-attempt-2
Mar 14, 2022
Merged
Re-instate reverted PR: TLV to JSON converter #16086
andy31415
merged 1 commit into
project-chip:master
from
mrjerryjohns:tlv-json-attempt-2
Mar 14, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austinh0
approved these changes
Mar 10, 2022
PR #16086: Size comparison from 89b4bad to 83ceebc Full report (15 builds for cyw30739, efr32, k32w, linux, mbed, p6, telink)
|
This adds a TLV to JSON converter to provide a means to deal with TLV in a more human-readable format. This does not rely on any schema information and instead, just dumps out raw TLV present in cluster payloads into a JSON format. This relies on the jsoncpp third party library. Testing Added a unit-test.
mrjerryjohns
force-pushed
the
tlv-json-attempt-2
branch
from
March 11, 2022 00:14
83ceebc
to
1717e7b
Compare
pullapprove
bot
requested review from
anush-apple,
balducci-apple,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
hawk248,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
lazarkov,
LuDuda,
msandstedt,
sagar-apple and
saurabhst
March 11, 2022 00:15
pullapprove
bot
requested review from
selissia,
tecimovic,
vijs,
vivien-apple,
wbschiller,
woody-apple and
xylophone21
March 11, 2022 00:15
PR #16086: Size comparison from 10ab541 to 1717e7b Full report (27 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
Fast-track for PR re-submission. |
andrei-menzopol
pushed a commit
to andrei-menzopol/connectedhomeip
that referenced
this pull request
Apr 14, 2022
This adds a TLV to JSON converter to provide a means to deal with TLV in a more human-readable format. This does not rely on any schema information and instead, just dumps out raw TLV present in cluster payloads into a JSON format. This relies on the jsoncpp third party library. Testing Added a unit-test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: This is re-instating a PR that was reverted here.