-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add BLE and thread pairing capabilities to chip-tool-darwin. #16126
Merged
bzbarsky-apple
merged 1 commit into
project-chip:master
from
krypton36:AddBLEThreadDarwin
Mar 27, 2022
Merged
Add BLE and thread pairing capabilities to chip-tool-darwin. #16126
bzbarsky-apple
merged 1 commit into
project-chip:master
from
krypton36:AddBLEThreadDarwin
Mar 27, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #16126: Size comparison from 86a8444 to ad4c255 Full report (18 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
pullapprove
bot
requested review from
andy31415,
anush-apple,
balducci-apple,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
hawk248,
holbrookt,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
kpschoedel,
lazarkov and
LuDuda
March 11, 2022 17:19
pullapprove
bot
requested review from
tcarmelveilleux,
tecimovic,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yufengwangca
March 11, 2022 17:19
krypton36
force-pushed
the
AddBLEThreadDarwin
branch
from
March 11, 2022 18:26
ad4c255
to
d2de86e
Compare
PR #16126: Size comparison from 31037c1 to d2de86e Full report (27 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
bzbarsky-apple
approved these changes
Mar 12, 2022
examples/chip-tool-darwin/commands/pairing/PairingDelegateBridge.h
Outdated
Show resolved
Hide resolved
examples/chip-tool-darwin/commands/pairing/PairingDelegateBridge.h
Outdated
Show resolved
Hide resolved
examples/chip-tool-darwin/commands/pairing/PairingDelegateBridge.mm
Outdated
Show resolved
Hide resolved
krypton36
force-pushed
the
AddBLEThreadDarwin
branch
from
March 15, 2022 19:39
d2de86e
to
218db4c
Compare
krypton36
force-pushed
the
AddBLEThreadDarwin
branch
from
March 15, 2022 19:43
218db4c
to
6c4a159
Compare
PR #16126: Size comparison from 85b4e5c to 6c4a159 Full report (27 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
krypton36
force-pushed
the
AddBLEThreadDarwin
branch
from
March 21, 2022 16:29
6c4a159
to
b9daafb
Compare
PR #16126: Size comparison from 7d1256f to b9daafb Full report (27 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
Fast tracking given this has had > 3 days for review. |
krypton36
force-pushed
the
AddBLEThreadDarwin
branch
from
March 26, 2022 05:15
b9daafb
to
f605367
Compare
krypton36
force-pushed
the
AddBLEThreadDarwin
branch
from
March 26, 2022 05:21
f605367
to
fb00870
Compare
PR #16126: Size comparison from e5c39d4 to fb00870 Full report (27 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
rochaferraz
pushed a commit
to rochaferraz/connectedhomeip
that referenced
this pull request
Mar 31, 2022
andrei-menzopol
pushed a commit
to andrei-menzopol/connectedhomeip
that referenced
this pull request
Apr 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
BLE and Thread commissioning is missing in chip-tool-darwin.
Change overview
Testing