[TI] Test Event #8 feedback #16495
Merged
[TI] Test Event #8 feedback #16495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OpenThread config added DNS client support to fully enable SRP. Configuration limiting OpenThread message buffers removed for higher memory devices. It was found that the OpenThread stack would not de-fragment the long packets needed for OTA. This ended up silently failing before the packets reached the LwIP stack. GN build updated to include missing dependencies. KVS updated to return proper CHIP_ERROR value instead of a platform error. AES hardware acceleration disabled due to a runtime error. This is likely a missing `mbedtls_aes_free()` call. Further debug is required before re-enabling.
pullapprove
bot
requested review from
anush-apple,
austinh0,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
erjiaqing,
franck-apple,
gjc13,
hawk248,
holbrookt,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
lazarkov,
LuDuda,
lzgrablic02 and
mlepage-google
pullapprove
bot
requested review from
tecimovic,
xylophone21,
yunhanw-google,
turon and
vijs
pullapprove
bot
requested review from
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yunhanw-google
|
PR #16495: Size comparison from c8efa21 to 8111dfa Full report (27 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
bzbarsky-apple
approved these changes
Mar 22, 2022
|
PR #16495: Size comparison from c8efa21 to 1cb1949 Increases (1 build for nrfconnect)
Full report (2 builds for mbed, nrfconnect)
|
|
PR #16495: Size comparison from a9bca9b to 37dcbfb Full report (18 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
ReneJosefsen
approved these changes
Mar 23, 2022
andy31415
approved these changes
Mar 24, 2022
andrei-menzopol
pushed a commit
to andrei-menzopol/connectedhomeip
that referenced
this pull request
Apr 14, 2022
* Platform updates found from TE#8 OpenThread config added DNS client support to fully enable SRP. Configuration limiting OpenThread message buffers removed for higher memory devices. It was found that the OpenThread stack would not de-fragment the long packets needed for OTA. This ended up silently failing before the packets reached the LwIP stack. GN build updated to include missing dependencies. KVS updated to return proper CHIP_ERROR value instead of a platform error. AES hardware acceleration disabled due to a runtime error. This is likely a missing `mbedtls_aes_free()` call. Further debug is required before re-enabling. * Centralize TI OpenThread config * Restyled by whitespace * Restyled by clang-format * Restyled by gn * add CHIP DNS configuration * Update length calculation for NVS * Restyled by clang-format Co-authored-by: Restyled.io <commits@restyled.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Issues found during Test Event #8
Change overview
OpenThread config added DNS client support to fully enable SRP.
Configuration limiting OpenThread message buffers removed for higher memory
devices. It was found that the OpenThread stack would not de-fragment the long
packets needed for OTA. This ended up silently failing before the packets
reached the LwIP stack.
GN build updated to include missing dependencies.
KVS updated to return proper CHIP_ERROR value instead of a platform error.
AES hardware acceleration disabled due to a runtime error. This is likely a
missing
mbedtls_aes_free()call. Further debug is required beforere-enabling.
Centralize TI OpenThread config
Testing
Running test steps in TE#8.