-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't lose enableServerInteractions state when controller restarts. #16504
Merged
bzbarsky-apple
merged 1 commit into
project-chip:master
from
bzbarsky-apple:preserve-server-interaction-state
Mar 22, 2022
Merged
Don't lose enableServerInteractions state when controller restarts. #16504
bzbarsky-apple
merged 1 commit into
project-chip:master
from
bzbarsky-apple:preserve-server-interaction-state
Mar 22, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we shut down and restart the last controller, we shut down and reinitialize the system state. Since we were not storing the enableServerInteractions state in either the SystemState or the CHIPDeviceControllerFactory, it was getting lost during this process. The fix is to store the state in CHIPDeviceControllerFactory.
PR #16504: Size comparison from a72ab9b to 2c1a6d7 Increases (3 builds for linux)
Full report (27 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
carol-apple
approved these changes
Mar 22, 2022
andy31415
approved these changes
Mar 22, 2022
andrei-menzopol
pushed a commit
to andrei-menzopol/connectedhomeip
that referenced
this pull request
Apr 14, 2022
…roject-chip#16504) When we shut down and restart the last controller, we shut down and reinitialize the system state. Since we were not storing the enableServerInteractions state in either the SystemState or the CHIPDeviceControllerFactory, it was getting lost during this process. The fix is to store the state in CHIPDeviceControllerFactory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we shut down and restart the last controller, we shut down and
reinitialize the system state. Since we were not storing the
enableServerInteractions state in either the SystemState or the
CHIPDeviceControllerFactory, it was getting lost during this process.
The fix is to store the state in CHIPDeviceControllerFactory.
Problem
See above.
Change overview
See above.
Testing
In iOS CHIPTool app, verified that after I go through the QR code screen and pair a device the device can open a CASE session to CHIPTool. Without this change it can't.