Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[general-diagnostics] Use type-safe BootReasonType enum #16556

Merged
merged 2 commits into from
Mar 26, 2022
Merged

[general-diagnostics] Use type-safe BootReasonType enum #16556

merged 2 commits into from
Mar 26, 2022

Conversation

Damian-Nordic
Copy link
Contributor

Problem

DiagnosticDataProvider interface uses raw uint8_t to pass boot reasons.

Change overview

  1. Switch from EmberAfBootReasonType to type-safe BootReasonType enum class.
  2. Use BootReasonType in DiagnosticDataProvider interface.

Testing

CI only.

@Damian-Nordic Damian-Nordic mentioned this pull request Mar 23, 2022
Merged
@Damian-Nordic Damian-Nordic changed the title [general-diagnostics] Use type-safe BootReaonType enum [general-diagnostics] Use type-safe BootReasonType enum Mar 23, 2022
@github-actions
Copy link

github-actions bot commented Mar 23, 2022 •
edited
Loading

PR #16556: Size comparison from a041a2c to 9ba15c1

Increases (15 builds for cyw30739, esp32, linux, nrfconnect, telink)
platform target config section a041a2c 9ba15c1 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 604314 604338 24 0.0
.app_xip_area 511412 511436 24 0.0
lock cyw930739m2evb_01 (read/write) 562102 562118 16 0.0
.app_xip_area 470728 470744 16 0.0
esp32 all-clusters-app c3devkit (read only) 964156 964162 6 0.0
.flash.text 964156 964162 6 0.0
m5stack (read only) 1020679 1020699 20 0.0
.flash.text 1015295 1015315 20 0.0
linux thermostat-no-ble arm64 (read only) 2262596 2263028 432 0.0
.text 1899600 1900032 432 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1156239 1156255 16 0.0
text 788528 788548 20 0.0
lighting-app nrf52840dk_nrf52840 (read/write) 1142635 1142651 16 0.0
text 797272 797292 20 0.0
nrf52840dk_nrf52840+rpc (read/write) 1091247 1091263 16 0.0
text 762108 762128 20 0.0
nrf52840dongle_nrf52840 (read/write) 1155099 1155115 16 0.0
text 799100 799120 20 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 1048638 1048654 16 0.0
text 710972 710992 20 0.0
lock-app nrf52840dk_nrf52840 (read/write) 1042959 1042975 16 0.0
text 715052 715076 24 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 949226 949258 32 0.0
text 628908 628928 20 0.0
pump-app nrf52840dk_nrf52840 (read/write) 1060983 1061015 32 0.0
text 731152 731176 24 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 1044219 1044235 16 0.0
text 718060 718084 24 0.0
telink lighting-app tlsr9518adk80d (read/write) 896850 896858 8 0.0
text 634304 634310 6 0.0
Decreases (1 build for efr32)
platform target config section a041a2c 9ba15c1 change % change
efr32 lighting-app BRD4161A+rpc (read only) 951024 951008 -16 -0.0
.text 951016 951000 -16 -0.0
Full report (24 builds for cyw30739, efr32, esp32, linux, mbed, nrfconnect, p6, telink)
platform target config section a041a2c 9ba15c1 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 604314 604338 24 0.0
.app_xip_area 511412 511436 24 0.0
.bss 75656 75656 0 0.0
.data 596 596 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 562102 562118 16 0.0
.app_xip_area 470728 470744 16 0.0
.bss 74160 74160 0 0.0
.data 560 560 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 571950 571950 0 0.0
.app_xip_area 470928 470928 0 0.0
.bss 83488 83488 0 0.0
.data 500 500 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 922196 922196 0 0.0
(read/write) 128756 128756 0 0.0
.bss 126768 126768 0 0.0
.data 1988 1988 0 0.0
.text 922188 922188 0 0.0
BRD4161A+rpc (read only) 951024 951008 -16 -0.0
(read/write) 144712 144712 0 0.0
.bss 142544 142544 0 0.0
.data 2168 2168 0 0.0
.text 951016 951000 -16 -0.0
window-app BRD4161A (read only) 852556 852556 0 0.0
(read/write) 126720 126720 0 0.0
.bss 124856 124856 0 0.0
.data 1864 1864 0 0.0
.text 852548 852548 0 0.0
esp32 all-clusters-app c3devkit (read only) 964156 964162 6 0.0
(read/write) 1393610 1393610 0 0.0
.dram0.bss 62072 62072 0 0.0
.dram0.data 14188 14188 0 0.0
.flash.rodata 198432 198432 0 0.0
.flash.text 964156 964162 6 0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1020679 1020699 20 0.0
(read/write) 461388 461388 0 0.0
.dram0.bss 67600 67600 0 0.0
.dram0.data 34016 34016 0 0.0
.flash.rodata 227936 227936 0 0.0
.flash.text 1015295 1015315 20 0.0
.iram0.text 123107 123107 0 0.0
linux chip-tool-ipv6only arm64 (read only) 9785084 9785084 0 0.0
(read/write) 472961 472961 0 0.0
.bss 40625 40625 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 371880 371880 0 0.0
.dynamic 560 560 0 0.0
.got 55528 55528 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 494308 494308 0 0.0
.text 8238692 8238692 0 0.0
thermostat-no-ble arm64 (read only) 2262596 2263028 432 0.0
(read/write) 148273 148273 0 0.0
.bss 62753 62753 0 0.0
.data 1024 1024 0 0.0
.data.rel.ro 77000 77000 0 0.0
.dynamic 560 560 0 0.0
.got 4480 4480 0 0.0
.init 24 24 0 0.0
.init_array 360 360 0 0.0
.rodata 139684 139684 0 0.0
.text 1899600 1900032 432 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2353532 2353532 0 0.0
.bss 184652 184652 0 0.0
.data 5752 5752 0 0.0
.text 1316132 1316132 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1156239 1156255 16 0.0
bss 146740 146740 0 0.0
rodata 145840 145840 0 0.0
text 788528 788548 20 0.0
lighting-app nrf52840dk_nrf52840 (read/write) 1142635 1142651 16 0.0
bss 143180 143180 0 0.0
rodata 123372 123372 0 0.0
text 797272 797292 20 0.0
nrf52840dk_nrf52840+rpc (read/write) 1091247 1091263 16 0.0
bss 139264 139264 0 0.0
rodata 110960 110960 0 0.0
text 762108 762128 20 0.0
nrf52840dongle_nrf52840 (read/write) 1155099 1155115 16 0.0
bss 144172 144172 0 0.0
rodata 122056 122056 0 0.0
text 799100 799120 20 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 1048638 1048654 16 0.0
bss 140244 140244 0 0.0
rodata 115516 115516 0 0.0
text 710972 710992 20 0.0
lock-app nrf52840dk_nrf52840 (read/write) 1042959 1042975 16 0.0
bss 133128 133128 0 0.0
rodata 116072 116072 0 0.0
text 715052 715076 24 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 949226 949258 32 0.0
bss 130224 130224 0 0.0
rodata 108272 108272 0 0.0
text 628908 628928 20 0.0
pump-app nrf52840dk_nrf52840 (read/write) 1060983 1061015 32 0.0
bss 133040 133040 0 0.0
rodata 118016 118016 0 0.0
text 731152 731176 24 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 1044219 1044235 16 0.0
bss 132788 132788 0 0.0
rodata 114596 114596 0 0.0
text 718060 718084 24 0.0
p6 all-clusters-app default (read/write) 2493488 2493488 0 0.0
.bss 118072 118072 0 0.0
.data 2632 2632 0 0.0
.text 1451752 1451752 0 0.0
light-app default (read/write) 2396672 2396672 0 0.0
.bss 111544 111544 0 0.0
.data 2488 2488 0 0.0
.text 1354936 1354936 0 0.0
lock-app default (read/write) 2360208 2360208 0 0.0
.bss 111288 111288 0 0.0
.data 2448 2448 0 0.0
.text 1318472 1318472 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 896850 896858 8 0.0
bss 87444 87444 0 0.0
noinit 37160 37160 0 0.0
text 634304 634310 6 0.0

@Damian-Nordic
[general-diagnostics] Use type-safe BootReaonType enum
0631f01 
1. Switch from EmberAfBootReasonType to type-safe
   BootReasonType.
2. Use BootReasonType in DiagnosticDataProvider interface.
@Damian-Nordic Damian-Nordic force-pushed the boot-reason-type-safety branch from 9ba15c1 to 0631f01 Compare March 23, 2022 12:10
@github-actions
Copy link

github-actions bot commented Mar 23, 2022 •
edited
Loading

PR #16556: Size comparison from 83df109 to 0631f01

Increases (4 builds for cyw30739, linux, telink)
platform target config section 83df109 0631f01 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 603478 603502 24 0.0
.app_xip_area 510576 510600 24 0.0
lock cyw930739m2evb_01 (read/write) 561274 561290 16 0.0
.app_xip_area 469900 469916 16 0.0
linux thermostat-no-ble arm64 (read only) 2262692 2263124 432 0.0
.text 1899600 1900032 432 0.0
telink lighting-app tlsr9518adk80d (read/write) 896954 896962 8 0.0
text 634304 634310 6 0.0
Decreases (1 build for efr32)
platform target config section 83df109 0631f01 change % change
efr32 lighting-app BRD4161A+rpc (read only) 951128 951112 -16 -0.0
.text 951120 951104 -16 -0.0
Full report (13 builds for cyw30739, efr32, linux, mbed, p6, telink)
platform target config section 83df109 0631f01 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 603478 603502 24 0.0
.app_xip_area 510576 510600 24 0.0
.bss 75656 75656 0 0.0
.data 596 596 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 561274 561290 16 0.0
.app_xip_area 469900 469916 16 0.0
.bss 74160 74160 0 0.0
.data 560 560 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 572806 572806 0 0.0
.app_xip_area 471784 471784 0 0.0
.bss 83488 83488 0 0.0
.data 500 500 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 922300 922300 0 0.0
(read/write) 128756 128756 0 0.0
.bss 126768 126768 0 0.0
.data 1988 1988 0 0.0
.text 922292 922292 0 0.0
BRD4161A+rpc (read only) 951128 951112 -16 -0.0
(read/write) 144712 144712 0 0.0
.bss 142544 142544 0 0.0
.data 2168 2168 0 0.0
.text 951120 951104 -16 -0.0
window-app BRD4161A (read only) 852660 852660 0 0.0
(read/write) 126720 126720 0 0.0
.bss 124856 124856 0 0.0
.data 1864 1864 0 0.0
.text 852652 852652 0 0.0
linux chip-tool-ipv6only arm64 (read only) 9785084 9785084 0 0.0
(read/write) 472961 472961 0 0.0
.bss 40625 40625 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 371880 371880 0 0.0
.dynamic 560 560 0 0.0
.got 55528 55528 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 494308 494308 0 0.0
.text 8238692 8238692 0 0.0
thermostat-no-ble arm64 (read only) 2262692 2263124 432 0.0
(read/write) 148273 148273 0 0.0
.bss 62753 62753 0 0.0
.data 1024 1024 0 0.0
.data.rel.ro 77000 77000 0 0.0
.dynamic 560 560 0 0.0
.got 4480 4480 0 0.0
.init 24 24 0 0.0
.init_array 360 360 0 0.0
.rodata 139780 139780 0 0.0
.text 1899600 1900032 432 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2353636 2353636 0 0.0
.bss 184652 184652 0 0.0
.data 5752 5752 0 0.0
.text 1316236 1316236 0 0.0
p6 all-clusters-app default (read/write) 2493592 2493592 0 0.0
.bss 118072 118072 0 0.0
.data 2632 2632 0 0.0
.text 1451856 1451856 0 0.0
light-app default (read/write) 2396776 2396776 0 0.0
.bss 111544 111544 0 0.0
.data 2488 2488 0 0.0
.text 1355040 1355040 0 0.0
lock-app default (read/write) 2360312 2360312 0 0.0
.bss 111288 111288 0 0.0
.data 2448 2448 0 0.0
.text 1318576 1318576 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 896954 896962 8 0.0
bss 87444 87444 0 0.0
noinit 37160 37160 0 0.0
text 634304 634310 6 0.0

@Damian-Nordic Damian-Nordic force-pushed the boot-reason-type-safety branch from 416a825 to db04715 Compare March 23, 2022 13:24
@github-actions
Copy link

github-actions bot commented Mar 23, 2022 •
edited
Loading

PR #16556: Size comparison from 7172ac9 to db04715

Increases (25 builds for cyw30739, esp32, k32w, linux, nrfconnect, telink)
platform target config section 7172ac9 db04715 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 603478 603502 24 0.0
.app_xip_area 510576 510600 24 0.0
lock cyw930739m2evb_01 (read/write) 561274 561290 16 0.0
.app_xip_area 469900 469916 16 0.0
esp32 all-clusters-app c3devkit (read only) 964156 964162 6 0.0
.flash.text 964156 964162 6 0.0
m5stack (read only) 1020687 1020707 20 0.0
.flash.text 1015303 1015323 20 0.0
k32w lock k32w061+release (read/write) 701088 701104 16 0.0
.text 615756 615772 16 0.0
linux all-clusters-app debug (read only) 2478329 2478905 576 0.0
.text 2102914 2103490 576 0.0
bridge-app debug+rpc (read only) 1753373 1753949 576 0.0
.text 1493605 1494181 576 0.0
chip-tool debug (read only) 10163805 10163821 16 0.0
.text 8862405 8862421 16 0.0
door-lock-app debug (read only) 2005129 2005705 576 0.0
.text 1674482 1675058 576 0.0
lighting-app debug+rpc (read only) 2178777 2179353 576 0.0
.text 1844594 1845170 576 0.0
ota-provider-app debug (read only) 1946513 1946545 32 0.0
.text 1627810 1627842 32 0.0
ota-requestor-app debug (read only) 1969953 1969985 32 0.0
.text 1654962 1654994 32 0.0
shell debug (read only) 2427657 2428249 592 0.0
.text 2061570 2062162 592 0.0
thermostat-no-ble arm64 (read only) 2262692 2263124 432 0.0
.text 1899600 1900032 432 0.0
tv-app debug (read only) 2678521 2679097 576 0.0
.text 2296514 2297090 576 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1138947 1138979 32 0.0
text 780084 780108 24 0.0
lighting-app nrf52840dk_nrf52840 (read/write) 1125071 1125103 32 0.0
text 788964 788988 24 0.0
nrf52840dk_nrf52840+rpc (read/write) 1088723 1088739 16 0.0
text 760808 760828 20 0.0
nrf52840dongle_nrf52840 (read/write) 1139619 1139635 16 0.0
text 791788 791808 20 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 1033790 1033806 16 0.0
text 704144 704168 24 0.0
lock-app nrf52840dk_nrf52840 (read/write) 1025331 1025347 16 0.0
text 706780 706804 24 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 934422 934454 32 0.0
text 622116 622136 20 0.0
pump-app nrf52840dk_nrf52840 (read/write) 1043331 1043363 32 0.0
text 722860 722880 20 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 1026567 1026583 16 0.0
text 709760 709780 20 0.0
telink lighting-app tlsr9518adk80d (read/write) 896954 896962 8 0.0
text 634304 634310 6 0.0
Decreases (1 build for efr32)
platform target config section 7172ac9 db04715 change % change
efr32 lighting-app BRD4161A+rpc (read only) 951128 951112 -16 -0.0
.text 951120 951104 -16 -0.0
Full report (35 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 7172ac9 db04715 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 603478 603502 24 0.0
.app_xip_area 510576 510600 24 0.0
.bss 75656 75656 0 0.0
.data 596 596 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 561274 561290 16 0.0
.app_xip_area 469900 469916 16 0.0
.bss 74160 74160 0 0.0
.data 560 560 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 572806 572806 0 0.0
.app_xip_area 471784 471784 0 0.0
.bss 83488 83488 0 0.0
.data 500 500 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 922300 922300 0 0.0
(read/write) 128756 128756 0 0.0
.bss 126768 126768 0 0.0
.data 1988 1988 0 0.0
.text 922292 922292 0 0.0
BRD4161A+rpc (read only) 951128 951112 -16 -0.0
(read/write) 144712 144712 0 0.0
.bss 142544 142544 0 0.0
.data 2168 2168 0 0.0
.text 951120 951104 -16 -0.0
window-app BRD4161A (read only) 852660 852660 0 0.0
(read/write) 126720 126720 0 0.0
.bss 124856 124856 0 0.0
.data 1864 1864 0 0.0
.text 852652 852652 0 0.0
esp32 all-clusters-app c3devkit (read only) 964156 964162 6 0.0
(read/write) 1393714 1393714 0 0.0
.dram0.bss 62072 62072 0 0.0
.dram0.data 14188 14188 0 0.0
.flash.rodata 198536 198536 0 0.0
.flash.text 964156 964162 6 0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1020687 1020707 20 0.0
(read/write) 461492 461492 0 0.0
.dram0.bss 67600 67600 0 0.0
.dram0.data 34016 34016 0 0.0
.flash.rodata 228040 228040 0 0.0
.flash.text 1015303 1015323 20 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 701120 701120 0 0.0
.bss 77656 77656 0 0.0
.data 1868 1868 0 0.0
.text 615796 615796 0 0.0
lock k32w061+release (read/write) 701088 701104 16 0.0
.bss 77624 77624 0 0.0
.data 1908 1908 0 0.0
.text 615756 615772 16 0.0
linux all-clusters-app debug (read only) 2478329 2478905 576 0.0
(read/write) 143216 143216 0 0.0
.bss 57312 57312 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 78904 78904 0 0.0
.dynamic 592 592 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 936 936 0 0.0
.rodata 211941 211941 0 0.0
.text 2102914 2103490 576 0.0
bridge-app debug+rpc (read only) 1753373 1753949 576 0.0
(read/write) 89424 89424 0 0.0
.bss 44456 44456 0 0.0
.data 1952 1952 0 0.0
.data.rel.ro 37944 37944 0 0.0
.dynamic 592 592 0 0.0
.got 3920 3920 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 144556 144556 0 0.0
.text 1493605 1494181 576 0.0
chip-tool debug (read only) 10163805 10163821 16 0.0
(read/write) 354944 354944 0 0.0
.bss 22336 22336 0 0.0
.data 1072 1072 0 0.0
.data.rel.ro 325472 325472 0 0.0
.dynamic 608 608 0 0.0
.got 4784 4784 0 0.0
.init 27 27 0 0.0
.init_array 632 632 0 0.0
.rodata 518677 518677 0 0.0
.text 8862405 8862421 16 0.0
chip-tool-ipv6only arm64 (read only) 9785084 9785084 0 0.0
(read/write) 472961 472961 0 0.0
.bss 40625 40625 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 371880 371880 0 0.0
.dynamic 560 560 0 0.0
.got 55528 55528 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 494308 494308 0 0.0
.text 8238692 8238692 0 0.0
door-lock-app debug (read only) 2005129 2005705 576 0.0
(read/write) 116832 116832 0 0.0
.bss 47584 47584 0 0.0
.data 992 992 0 0.0
.data.rel.ro 62856 62856 0 0.0
.dynamic 592 592 0 0.0
.got 4120 4120 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 180988 180988 0 0.0
.text 1674482 1675058 576 0.0
lighting-app debug+rpc (read only) 2178777 2179353 576 0.0
(read/write) 123792 123792 0 0.0
.bss 48864 48864 0 0.0
.data 1472 1472 0 0.0
.data.rel.ro 67928 67928 0 0.0
.dynamic 608 608 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 744 744 0 0.0
.rodata 175164 175164 0 0.0
.text 1844594 1845170 576 0.0
ota-provider-app debug (read only) 1946513 1946545 32 0.0
(read/write) 112560 112560 0 0.0
.bss 47456 47456 0 0.0
.data 1256 1256 0 0.0
.data.rel.ro 58200 58200 0 0.0
.dynamic 608 608 0 0.0
.got 4376 4376 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 166987 166987 0 0.0
.text 1627810 1627842 32 0.0
ota-requestor-app debug (read only) 1969953 1969985 32 0.0
(read/write) 115592 115592 0 0.0
.bss 48480 48480 0 0.0
.data 1416 1416 0 0.0
.data.rel.ro 60264 60264 0 0.0
.dynamic 592 592 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 162980 162980 0 0.0
.text 1654962 1654994 32 0.0
shell debug (read only) 2427657 2428249 592 0.0
(read/write) 147272 147272 0 0.0
.bss 67240 67240 0 0.0
.data 784 784 0 0.0
.data.rel.ro 73536 73536 0 0.0
.dynamic 592 592 0 0.0
.got 4152 4152 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 209362 209362 0 0.0
.text 2061570 2062162 592 0.0
thermostat-no-ble arm64 (read only) 2262692 2263124 432 0.0
(read/write) 148273 148273 0 0.0
.bss 62753 62753 0 0.0
.data 1024 1024 0 0.0
.data.rel.ro 77000 77000 0 0.0
.dynamic 560 560 0 0.0
.got 4480 4480 0 0.0
.init 24 24 0 0.0
.init_array 360 360 0 0.0
.rodata 139780 139780 0 0.0
.text 1899600 1900032 432 0.0
tv-app debug (read only) 2678521 2679097 576 0.0
(read/write) 247744 247744 0 0.0
.bss 164416 164416 0 0.0
.data 3104 3104 0 0.0
.data.rel.ro 74168 74168 0 0.0
.dynamic 592 592 0 0.0
.got 4552 4552 0 0.0
.init 27 27 0 0.0
.init_array 888 888 0 0.0
.rodata 207157 207157 0 0.0
.text 2296514 2297090 576 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2353636 2353636 0 0.0
.bss 184652 184652 0 0.0
.data 5752 5752 0 0.0
.text 1316236 1316236 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1138947 1138979 32 0.0
bss 142588 142588 0 0.0
rodata 141516 141516 0 0.0
text 780084 780108 24 0.0
lighting-app nrf52840dk_nrf52840 (read/write) 1125071 1125103 32 0.0
bss 139028 139028 0 0.0
rodata 118512 118512 0 0.0
text 788964 788988 24 0.0
nrf52840dk_nrf52840+rpc (read/write) 1088723 1088739 16 0.0
bss 139264 139264 0 0.0
rodata 109748 109748 0 0.0
text 760808 760828 20 0.0
nrf52840dongle_nrf52840 (read/write) 1139619 1139635 16 0.0
bss 140020 140020 0 0.0
rodata 118408 118408 0 0.0
text 791788 791808 20 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 1033790 1033806 16 0.0
bss 136092 136092 0 0.0
rodata 111708 111708 0 0.0
text 704144 704168 24 0.0
lock-app nrf52840dk_nrf52840 (read/write) 1025331 1025347 16 0.0
bss 128976 128976 0 0.0
rodata 111228 111228 0 0.0
text 706780 706804 24 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 934422 934454 32 0.0
bss 126072 126072 0 0.0
rodata 104476 104476 0 0.0
text 622116 622136 20 0.0
pump-app nrf52840dk_nrf52840 (read/write) 1043331 1043363 32 0.0
bss 128888 128888 0 0.0
rodata 113164 113164 0 0.0
text 722860 722880 20 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 1026567 1026583 16 0.0
bss 128636 128636 0 0.0
rodata 109744 109744 0 0.0
text 709760 709780 20 0.0
p6 all-clusters-app default (read/write) 2493592 2493592 0 0.0
.bss 118072 118072 0 0.0
.data 2632 2632 0 0.0
.text 1451856 1451856 0 0.0
light-app default (read/write) 2396776 2396776 0 0.0
.bss 111544 111544 0 0.0
.data 2488 2488 0 0.0
.text 1355040 1355040 0 0.0
lock-app default (read/write) 2360312 2360312 0 0.0
.bss 111288 111288 0 0.0
.data 2448 2448 0 0.0
.text 1318576 1318576 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 896954 896962 8 0.0
bss 87444 87444 0 0.0
noinit 37160 37160 0 0.0
text 634304 634310 6 0.0

bzbarsky-apple
bzbarsky-apple approved these changes Mar 24, 2022
View reviewed changes
Copy link
Contributor

@bzbarsky-apple bzbarsky-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@woody-apple
Copy link
Contributor

Fast tracking given this has had > 3 days for review.

@woody-apple woody-apple merged commit 30b8330 into project-chip:master Mar 26, 2022
rochaferraz pushed a commit to rochaferraz/connectedhomeip that referenced this pull request Mar 31, 2022
@Damian-Nordic @rochaferraz
[general-diagnostics] Use type-safe BootReasonType enum (project-chip…
f2441a5 
…#16556)

* [general-diagnostics] Use type-safe BootReaonType enum

1. Switch from EmberAfBootReasonType to type-safe
   BootReasonType.
2. Use BootReasonType in DiagnosticDataProvider interface.

* Fix K32W build
andrei-menzopol pushed a commit to andrei-menzopol/connectedhomeip that referenced this pull request Apr 14, 2022
@Damian-Nordic @andrei-menzopol
[general-diagnostics] Use type-safe BootReasonType enum (project-chip…
744a80c 
…#16556)

* [general-diagnostics] Use type-safe BootReaonType enum

1. Switch from EmberAfBootReasonType to type-safe
   BootReasonType.
2. Use BootReasonType in DiagnosticDataProvider interface.

* Fix K32W build
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

Assignees
No one assigned
Labels
app darwin efr32 esp32 examples fast track linux platform review - pending zephyr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Damian-Nordic @woody-apple @bzbarsky-apple