Restyle Add custom privileges for opcreds cluster #16591
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![restyled-io[bot]](https://avatars.githubusercontent.com/in/5851?s=60&v=4){kind=small}
One attribute and most commands require administer privilege. (Cluster has no events.) Commissioning chip-all-clusters-app via chip-tool on Linux results in the following commands and their required privilege: GeneralCommissioning/ArmFailSafe --> 0x30 0x0 --> operate GeneralCommissioning/SetRegulatoryConfig --> 0x30 0x2 --> operate OperationalCredentials/CertificateChainRequest --> 0x3e 0x2 --> administer OperationalCredentials/CertificateChainRequest --> 0x3e 0x2 --> administer OperationalCredentials/AttestationRequest --> 0x3e 0x0 --> administer OperationalCredentials/CSRRequest --> 0x3e 0x4 --> administer OperationalCredentials/AddTrustedRootCertificate --> 0x3e 0xb --> administer OperationalCredentials/AddNOC --> 0x3e 0x6 --> administer GeneralCommissioning/CommissioningComplete --> 0x30 0x4 --> operate The last is satisfied over CASE (via the AddNOC installed ACL) and the others before it are satisfied by implicit administer privilege over PASE during commissioning.
pullapprove
bot
requested review from
anush-apple,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
hawk248,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
lazarkov,
LuDuda,
lzgrablic02,
mrjerryjohns,
msandstedt and
mspang
pullapprove
bot
requested review from
robszewczyk,
sagar-apple,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
restyled-io
bot
force-pushed
the
restyled/access-for-opcreds
branch
from
09e2185 to
79c6b68
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A duplicate of #16590 with additional commits that automatically address
incorrect style, created by Restyled.
Please review accordingly.
Since the original Pull Request was opened as a fork in a contributor's
repository, we are unable to create a Pull Request branching from it with only
the style fixes.
The following Restylers made fixes:
To incorporate these changes, you can either:
Merge this Pull Request instead of the original, or
Ask your contributor to locally incorporate these commits and push them to
the original Pull Request
Expand for example instructions
NOTE: As work continues on the original Pull Request, this process will
re-run and update (force-push) this Pull Request with updated style fixes as
necessary. If the style is fixed manually at any point (i.e. this process finds
no fixes to make), this Pull Request will be closed automatically.
Sorry if this was unexpected. To disable it, see our documentation.