Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve missing attributes darwin #16595

Merged

Conversation

krypton36
Copy link
Contributor

Problem

There are some attributes missing in chip-tool-darwin. See issues below:

Change overview

  • Removes unsupported check

Testing

  • Generated code
  • Compiled
  • Tested missing attributes

@github-actions
Copy link

github-actions bot commented Mar 24, 2022

PR #16595: Size comparison from 1f3467e to e22aa4f

Full report (27 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 1f3467e e22aa4f change % change
cyw30739 light cyw930739m2evb_01 (read/write) 603334 603334 0 0.0
.app_xip_area 510424 510424 0 0.0
.bss 75656 75656 0 0.0
.data 604 604 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 561122 561122 0 0.0
.app_xip_area 469740 469740 0 0.0
.bss 74160 74160 0 0.0
.data 568 568 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 573206 573206 0 0.0
.app_xip_area 472176 472176 0 0.0
.bss 83488 83488 0 0.0
.data 508 508 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 922876 922876 0 0.0
(read/write) 128756 128756 0 0.0
.bss 126760 126760 0 0.0
.data 1996 1996 0 0.0
.text 922868 922868 0 0.0
BRD4161A+rpc (read only) 951684 951684 0 0.0
(read/write) 144712 144712 0 0.0
.bss 142536 142536 0 0.0
.data 2176 2176 0 0.0
.text 951676 951676 0 0.0
window-app BRD4161A (read only) 852680 852680 0 0.0
(read/write) 126728 126728 0 0.0
.bss 124856 124856 0 0.0
.data 1872 1872 0 0.0
.text 852672 852672 0 0.0
esp32 all-clusters-app c3devkit (read only) 964186 964186 0 0.0
(read/write) 1393842 1393842 0 0.0
.dram0.bss 62072 62072 0 0.0
.dram0.data 14204 14204 0 0.0
.flash.rodata 198648 198648 0 0.0
.flash.text 964186 964186 0 0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1020723 1020723 0 0.0
(read/write) 461620 461620 0 0.0
.dram0.bss 67600 67600 0 0.0
.dram0.data 34024 34024 0 0.0
.flash.rodata 228160 228160 0 0.0
.flash.text 1015339 1015339 0 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 701500 701500 0 0.0
.bss 77648 77648 0 0.0
.data 1876 1876 0 0.0
.text 616176 616176 0 0.0
lock k32w061+release (read/write) 700936 700936 0 0.0
.bss 77624 77624 0 0.0
.data 1916 1916 0 0.0
.text 615596 615596 0 0.0
linux all-clusters-app debug (read only) 2478273 2478273 0 0.0
(read/write) 143184 143184 0 0.0
.bss 57312 57312 0 0.0
.data 1280 1280 0 0.0
.data.rel.ro 78872 78872 0 0.0
.dynamic 592 592 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 936 936 0 0.0
.rodata 211845 211845 0 0.0
.text 2103026 2103026 0 0.0
bridge-app debug+rpc (read only) 1753061 1753061 0 0.0
(read/write) 89424 89424 0 0.0
.bss 44456 44456 0 0.0
.data 1984 1984 0 0.0
.data.rel.ro 37912 37912 0 0.0
.dynamic 592 592 0 0.0
.got 3920 3920 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 144300 144300 0 0.0
.text 1493621 1493621 0 0.0
chip-tool debug (read only) 10186893 10186893 0 0.0
(read/write) 355072 355072 0 0.0
.bss 22400 22400 0 0.0
.data 1072 1072 0 0.0
.data.rel.ro 325496 325496 0 0.0
.dynamic 608 608 0 0.0
.got 4816 4816 0 0.0
.init 27 27 0 0.0
.init_array 632 632 0 0.0
.rodata 520405 520405 0 0.0
.text 8883301 8883301 0 0.0
chip-tool-ipv6only arm64 (read only) 9806636 9806636 0 0.0
(read/write) 473297 473297 0 0.0
.bss 40673 40673 0 0.0
.data 1144 1144 0 0.0
.data.rel.ro 371968 371968 0 0.0
.dynamic 560 560 0 0.0
.got 55704 55704 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 495780 495780 0 0.0
.text 8258020 8258020 0 0.0
door-lock-app debug (read only) 2005121 2005121 0 0.0
(read/write) 116800 116800 0 0.0
.bss 47584 47584 0 0.0
.data 992 992 0 0.0
.data.rel.ro 62824 62824 0 0.0
.dynamic 592 592 0 0.0
.got 4120 4120 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 180956 180956 0 0.0
.text 1674578 1674578 0 0.0
lighting-app debug+rpc (read only) 2178497 2178497 0 0.0
(read/write) 123760 123760 0 0.0
.bss 48864 48864 0 0.0
.data 1472 1472 0 0.0
.data.rel.ro 67896 67896 0 0.0
.dynamic 608 608 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 744 744 0 0.0
.rodata 174940 174940 0 0.0
.text 1844610 1844610 0 0.0
ota-provider-app debug (read only) 1946169 1946169 0 0.0
(read/write) 112528 112528 0 0.0
.bss 47456 47456 0 0.0
.data 1256 1256 0 0.0
.data.rel.ro 58168 58168 0 0.0
.dynamic 608 608 0 0.0
.got 4376 4376 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 166699 166699 0 0.0
.text 1627826 1627826 0 0.0
ota-requestor-app debug (read only) 1972977 1972977 0 0.0
(read/write) 115784 115784 0 0.0
.bss 48448 48448 0 0.0
.data 1480 1480 0 0.0
.data.rel.ro 60392 60392 0 0.0
.dynamic 592 592 0 0.0
.got 4184 4184 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 162692 162692 0 0.0
.text 1657730 1657730 0 0.0
shell debug (read only) 2427633 2427633 0 0.0
(read/write) 147240 147240 0 0.0
.bss 67240 67240 0 0.0
.data 800 800 0 0.0
.data.rel.ro 73504 73504 0 0.0
.dynamic 592 592 0 0.0
.got 4152 4152 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 209298 209298 0 0.0
.text 2061682 2061682 0 0.0
thermostat-no-ble arm64 (read only) 2262588 2262588 0 0.0
(read/write) 148257 148257 0 0.0
.bss 62753 62753 0 0.0
.data 1040 1040 0 0.0
.data.rel.ro 76968 76968 0 0.0
.dynamic 560 560 0 0.0
.got 4480 4480 0 0.0
.init 24 24 0 0.0
.init_array 360 360 0 0.0
.rodata 139564 139564 0 0.0
.text 1899776 1899776 0 0.0
tv-app debug (read only) 2678929 2678929 0 0.0
(read/write) 247712 247712 0 0.0
.bss 164416 164416 0 0.0
.data 3136 3136 0 0.0
.data.rel.ro 74104 74104 0 0.0
.dynamic 592 592 0 0.0
.got 4552 4552 0 0.0
.init 27 27 0 0.0
.init_array 888 888 0 0.0
.rodata 206901 206901 0 0.0
.text 2297250 2297250 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2353428 2353428 0 0.0
.bss 184652 184652 0 0.0
.data 5760 5760 0 0.0
.text 1316028 1316028 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1139283 1139283 0 0.0
bss 142588 142588 0 0.0
rodata 141508 141508 0 0.0
text 780416 780416 0 0.0
p6 all-clusters-app default (read/write) 2493816 2493816 0 0.0
.bss 118072 118072 0 0.0
.data 2640 2640 0 0.0
.text 1452080 1452080 0 0.0
light-app default (read/write) 2396752 2396752 0 0.0
.bss 111544 111544 0 0.0
.data 2496 2496 0 0.0
.text 1355016 1355016 0 0.0
lock-app default (read/write) 2360288 2360288 0 0.0
.bss 111288 111288 0 0.0
.data 2456 2456 0 0.0
.text 1318552 1318552 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 896794 896794 0 0.0
bss 87444 87444 0 0.0
noinit 37160 37160 0 0.0
text 634212 634212 0 0.0

@bzbarsky-apple
Copy link
Contributor

Fast-tracking platform-specific code.

@bzbarsky-apple bzbarsky-apple merged commit 026e01d into project-chip:master Mar 24, 2022
andrei-menzopol pushed a commit to andrei-menzopol/connectedhomeip that referenced this pull request Apr 14, 2022
* Resolve missing attributes in chip-tool-darwin

* Generated Code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants