Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quick editorial follow-ups on IPK for CASE #16856

Merged
merged 2 commits into from
Mar 31, 2022
Merged

Quick editorial follow-ups on IPK for CASE #16856

merged 2 commits into from
Mar 31, 2022

Conversation

tcarmelveilleux
Copy link
Contributor

Change overview

Testing

  • Unit tests still passa
  • Cert tests pass

@tcarmelveilleux
Quick editorial follow-ups on IPK for CASE
1d3d64c 
- Fixes the follow-up editorial comments from
  @bzbarsky-apple on project-chip#16737

- Unit tests still passa
- Cert tests pass
@restyled-io restyled-io bot mentioned this pull request Mar 30, 2022
Closed
@github-actions
Copy link

github-actions bot commented Mar 30, 2022 •
edited
Loading

PR #16856: Size comparison from 1c03d9c to 2b8b37b

Increases (26 builds for cyw30739, efr32, esp32, k32w, linux, nrfconnect, p6, telink)
platform target config section 1c03d9c 2b8b37b change % change
cyw30739 light cyw930739m2evb_01 (read/write) 609770 609786 16 0.0
.app_xip_area 516520 516536 16 0.0
lock cyw930739m2evb_01 (read/write) 567314 567330 16 0.0
.app_xip_area 475600 475616 16 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 579214 579230 16 0.0
.app_xip_area 477836 477852 16 0.0
efr32 lighting-app BRD4161A (read only) 930500 930532 32 0.0
.text 930492 930524 32 0.0
BRD4161A+rpc (read only) 959492 959524 32 0.0
.text 959484 959516 32 0.0
window-app BRD4161A (read only) 860016 860048 32 0.0
.text 860008 860040 32 0.0
esp32 all-clusters-app c3devkit (read only) 969946 969982 36 0.0
.flash.text 969946 969982 36 0.0
m5stack (read only) 1025671 1025715 44 0.0
.flash.text 1020287 1020331 44 0.0
k32w light k32w061+release (read/write) 707524 707540 16 0.0
.text 621860 621876 16 0.0
lock k32w061+release (read/write) 706632 706648 16 0.0
.text 620960 620976 16 0.0
linux all-clusters-app debug (read only) 2547457 2547697 240 0.0
.rodata 217189 217349 160 0.1
.text 2166274 2166354 80 0.0
bridge-app debug+rpc (read only) 1779533 1779757 224 0.0
.rodata 145247 145393 146 0.1
.text 1518757 1518837 80 0.0
chip-tool debug (read only) 10312789 10312981 192 0.0
.rodata 527573 527733 160 0.0
.text 8997973 8998005 32 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9922020 9922052 32 0.0
.text 8362532 8362564 32 0.0
door-lock-app debug (read only) 2032161 2032385 224 0.0
.rodata 181842 181985 143 0.1
.text 1700338 1700418 80 0.0
lighting-app debug+rpc (read only) 2209921 2210145 224 0.0
.rodata 175857 176001 144 0.1
.text 1874722 1874802 80 0.0
ota-provider-app debug (read only) 1971985 1972217 232 0.0
.rodata 167499 167651 152 0.1
.text 1652450 1652530 80 0.0
ota-requestor-app debug (read only) 1999769 2000009 240 0.0
.rodata 163780 163940 160 0.1
.text 1682946 1683026 80 0.0
shell debug (read only) 2462729 2462969 240 0.0
.rodata 210322 210482 160 0.1
.text 2095218 2095298 80 0.0
thermostat-no-ble arm64 (read only) 2289044 2289124 80 0.0
.text 1925312 1925392 80 0.0
tv-app debug (read only) 2711065 2711225 160 0.0
.rodata 207019 207147 128 0.1
.text 2329250 2329282 32 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1146855 1146871 16 0.0
text 786264 786284 20 0.0
p6 all-clusters-app default (read/write) 2502408 2502424 16 0.0
.text 1460672 1460688 16 0.0
light-app default (read/write) 2404568 2404584 16 0.0
.text 1362832 1362848 16 0.0
lock-app default (read/write) 2368176 2368208 32 0.0
.text 1326440 1326472 32 0.0
telink lighting-app tlsr9518adk80d (read/write) 791484 791508 24 0.0
text 561450 561476 26 0.0
Full report (27 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 1c03d9c 2b8b37b change % change
cyw30739 light cyw930739m2evb_01 (read/write) 609770 609786 16 0.0
.app_xip_area 516520 516536 16 0.0
.bss 75996 75996 0 0.0
.data 600 600 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 567314 567330 16 0.0
.app_xip_area 475600 475616 16 0.0
.bss 74500 74500 0 0.0
.data 564 564 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 579214 579230 16 0.0
.app_xip_area 477836 477852 16 0.0
.bss 83836 83836 0 0.0
.data 504 504 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 930500 930532 32 0.0
(read/write) 129120 129120 0 0.0
.bss 127128 127128 0 0.0
.data 1992 1992 0 0.0
.text 930492 930524 32 0.0
BRD4161A+rpc (read only) 959492 959524 32 0.0
(read/write) 145084 145084 0 0.0
.bss 142912 142912 0 0.0
.data 2172 2172 0 0.0
.text 959484 959516 32 0.0
window-app BRD4161A (read only) 860016 860048 32 0.0
(read/write) 127088 127088 0 0.0
.bss 125216 125216 0 0.0
.data 1868 1868 0 0.0
.text 860008 860040 32 0.0
esp32 all-clusters-app c3devkit (read only) 969946 969982 36 0.0
(read/write) 1394914 1394914 0 0.0
.dram0.bss 62432 62432 0 0.0
.dram0.data 14220 14220 0 0.0
.flash.rodata 199352 199352 0 0.0
.flash.text 969946 969982 36 0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1025671 1025715 44 0.0
(read/write) 462684 462684 0 0.0
.dram0.bss 67960 67960 0 0.0
.dram0.data 34024 34024 0 0.0
.flash.rodata 228864 228864 0 0.0
.flash.text 1020287 1020331 44 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 707524 707540 16 0.0
.bss 77992 77992 0 0.0
.data 1872 1872 0 0.0
.text 621860 621876 16 0.0
lock k32w061+release (read/write) 706632 706648 16 0.0
.bss 77960 77960 0 0.0
.data 1912 1912 0 0.0
.text 620960 620976 16 0.0
linux all-clusters-app debug (read only) 2547457 2547697 240 0.0
(read/write) 143448 143448 0 0.0
.bss 57408 57408 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 79032 79032 0 0.0
.dynamic 592 592 0 0.0
.got 4184 4184 0 0.0
.init 27 27 0 0.0
.init_array 944 944 0 0.0
.rodata 217189 217349 160 0.1
.text 2166274 2166354 80 0.0
bridge-app debug+rpc (read only) 1779533 1779757 224 0.0
(read/write) 89632 89632 0 0.0
.bss 44536 44536 0 0.0
.data 1968 1968 0 0.0
.data.rel.ro 38040 38040 0 0.0
.dynamic 592 592 0 0.0
.got 3928 3928 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 145247 145393 146 0.1
.text 1518757 1518837 80 0.0
chip-tool debug (read only) 10312789 10312981 192 0.0
(read/write) 356240 356240 0 0.0
.bss 22048 22048 0 0.0
.data 1072 1072 0 0.0
.data.rel.ro 326944 326944 0 0.0
.dynamic 624 624 0 0.0
.got 4872 4872 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 527573 527733 160 0.0
.text 8997973 8998005 32 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9922020 9922052 32 0.0
(read/write) 475185 475185 0 0.0
.bss 40385 40385 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 373656 373656 0 0.0
.dynamic 560 560 0 0.0
.got 56208 56208 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 501692 501692 0 0.0
.text 8362532 8362564 32 0.0
door-lock-app debug (read only) 2032161 2032385 224 0.0
(read/write) 117056 117056 0 0.0
.bss 47648 47648 0 0.0
.data 1008 1008 0 0.0
.data.rel.ro 62984 62984 0 0.0
.dynamic 592 592 0 0.0
.got 4128 4128 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 181842 181985 143 0.1
.text 1700338 1700418 80 0.0
lighting-app debug+rpc (read only) 2209921 2210145 224 0.0
(read/write) 124080 124080 0 0.0
.bss 48960 48960 0 0.0
.data 1488 1488 0 0.0
.data.rel.ro 68056 68056 0 0.0
.dynamic 608 608 0 0.0
.got 4176 4176 0 0.0
.init 27 27 0 0.0
.init_array 744 744 0 0.0
.rodata 175857 176001 144 0.1
.text 1874722 1874802 80 0.0
ota-provider-app debug (read only) 1971985 1972217 232 0.0
(read/write) 112816 112816 0 0.0
.bss 47584 47584 0 0.0
.data 1288 1288 0 0.0
.data.rel.ro 58296 58296 0 0.0
.dynamic 608 608 0 0.0
.got 4384 4384 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 167499 167651 152 0.1
.text 1652450 1652530 80 0.0
ota-requestor-app debug (read only) 1999769 2000009 240 0.0
(read/write) 116008 116008 0 0.0
.bss 48512 48512 0 0.0
.data 1480 1480 0 0.0
.data.rel.ro 60552 60552 0 0.0
.dynamic 592 592 0 0.0
.got 4192 4192 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 163780 163940 160 0.1
.text 1682946 1683026 80 0.0
shell debug (read only) 2462729 2462969 240 0.0
(read/write) 147496 147496 0 0.0
.bss 67304 67304 0 0.0
.data 784 784 0 0.0
.data.rel.ro 73696 73696 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 210322 210482 160 0.1
.text 2095218 2095298 80 0.0
thermostat-no-ble arm64 (read only) 2289044 2289124 80 0.0
(read/write) 148433 148433 0 0.0
.bss 62833 62833 0 0.0
.data 1032 1032 0 0.0
.data.rel.ro 77040 77040 0 0.0
.dynamic 560 560 0 0.0
.got 4512 4512 0 0.0
.init 24 24 0 0.0
.init_array 360 360 0 0.0
.rodata 140228 140228 0 0.0
.text 1925312 1925392 80 0.0
tv-app debug (read only) 2711065 2711225 160 0.0
(read/write) 247968 247968 0 0.0
.bss 164608 164608 0 0.0
.data 3136 3136 0 0.0
.data.rel.ro 74176 74176 0 0.0
.dynamic 592 592 0 0.0
.got 4552 4552 0 0.0
.init 27 27 0 0.0
.init_array 888 888 0 0.0
.rodata 207019 207147 128 0.1
.text 2329250 2329282 32 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2358540 2358540 0 0.0
.bss 185044 185044 0 0.0
.data 5760 5760 0 0.0
.text 1321140 1321140 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1146855 1146871 16 0.0
bss 143076 143076 0 0.0
rodata 142696 142696 0 0.0
text 786264 786284 20 0.0
p6 all-clusters-app default (read/write) 2502408 2502424 16 0.0
.bss 118464 118464 0 0.0
.data 2640 2640 0 0.0
.text 1460672 1460688 16 0.0
light-app default (read/write) 2404568 2404584 16 0.0
.bss 111936 111936 0 0.0
.data 2496 2496 0 0.0
.text 1362832 1362848 16 0.0
lock-app default (read/write) 2368176 2368208 32 0.0
.bss 111680 111680 0 0.0
.data 2456 2456 0 0.0
.text 1326440 1326472 32 0.0
telink lighting-app tlsr9518adk80d (read/write) 791484 791508 24 0.0
bss 70288 70288 0 0.0
noinit 40416 40416 0 0.0
text 561450 561476 26 0.0

bzbarsky-apple
bzbarsky-apple approved these changes Mar 31, 2022
View reviewed changes
Copy link
Contributor

@bzbarsky-apple bzbarsky-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@bzbarsky-apple bzbarsky-apple merged commit 5ec5bb1 into project-chip:master Mar 31, 2022
rochaferraz pushed a commit to rochaferraz/connectedhomeip that referenced this pull request Mar 31, 2022
@tcarmelveilleux @restyled-commits @rochaferraz
Quick editorial follow-ups on IPK for CASE (project-chip#16856)
88b75c0 
* Quick editorial follow-ups on IPK for CASE

- Fixes the follow-up editorial comments from
  @bzbarsky-apple on project-chip#16737

- Unit tests still passa
- Cert tests pass

* Restyled by clang-format

Co-authored-by: Restyled.io <commits@restyled.io>
andrei-menzopol pushed a commit to andrei-menzopol/connectedhomeip that referenced this pull request Apr 14, 2022
@tcarmelveilleux @restyled-commits @andrei-menzopol
Quick editorial follow-ups on IPK for CASE (project-chip#16856)
5e56c68 
* Quick editorial follow-ups on IPK for CASE

- Fixes the follow-up editorial comments from
  @bzbarsky-apple on project-chip#16737

- Unit tests still passa
- Cert tests pass

* Restyled by clang-format

Co-authored-by: Restyled.io <commits@restyled.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@mspang mspang Awaiting requested review from mspang

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

@msandstedt msandstedt Awaiting requested review from msandstedt

Assignees
No one assigned
Labels
app controller review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tcarmelveilleux @msandstedt @bzbarsky-apple @restyled-commits