-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use iteration pattern to get the fixed user label list #16861
Merged
yufengwangca
merged 2 commits into
project-chip:master
from
yufengwangca:pr/api/fixlabel
Mar 31, 2022
Merged
Use iteration pattern to get the fixed user label list #16861
yufengwangca
merged 2 commits into
project-chip:master
from
yufengwangca:pr/api/fixlabel
Mar 31, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
austinh0,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
hawk248,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
kpschoedel,
lazarkov and
LuDuda
March 31, 2022 01:51
pullapprove
bot
requested review from
turon,
tecimovic,
vijs,
vivien-apple,
wbschiller,
woody-apple and
xylophone21
March 31, 2022 01:51
bzbarsky-apple
approved these changes
Mar 31, 2022
PR #16861: Size comparison from 8928308 to cabb5fc Increases above 0.2%:
Increases (27 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
Decreases (18 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, mbed, nrfconnect, p6, telink)
Full report (31 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
yunhanw-google
approved these changes
Mar 31, 2022
PR #16861: Size comparison from 8928308 to 799ae90 Increases above 0.2%:
Increases (26 builds for cc13x2_26x2, cyw30739, efr32, esp32, linux, mbed, nrfconnect, p6, telink)
Decreases (16 builds for cc13x2_26x2, cyw30739, efr32, k32w, mbed, p6, telink)
Full report (31 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
rochaferraz
pushed a commit
to rochaferraz/connectedhomeip
that referenced
this pull request
Mar 31, 2022
…16861) * Use iteration pattern to get the fixed user label list * Remove the unnecessary check condition
This was referenced Apr 1, 2022
andrei-menzopol
pushed a commit
to andrei-menzopol/connectedhomeip
that referenced
this pull request
Apr 14, 2022
…16861) * Use iteration pattern to get the fixed user label list * Remove the unnecessary check condition
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
What is being fixed? Examples:
Change overview
Use iteration pattern to get the fixed user label list so each fixed label get encoded in place.
Testing
How was this tested? (at least one bullet point required)