add attribute change callback hook for speaker endpoint #16944

chrisdecenzo · 2022-04-01T18:46:57Z

Problem

Speaker endpoint attribute callbacks not working on tv-app #16942: Speaker endpoint attribute callbacks not working on tv-app

Change overview

Add MatterPostAttributeChangeCallback so that onOff and level attribute changes get routed to tv-app
Add af_get_event.h magic so that tick callbacks work

Testing

tested using chip-tool commands against tv-app

woody-apple · 2022-04-01T19:23:57Z

Fast tracking platform changes.

github-actions · 2022-04-01T21:19:50Z

PR #16944: Size comparison from 358986a to d01b246

Full report (16 builds for cc13x2_26x2, esp32, k32w, linux, mbed, nrfconnect, p6, telink)

platform	target	config	section	`358986a`	`d01b246`
cc13x2_26x2	lock-ftd	LP_CC2652R7	(read only)	667283	667283
			(read/write)	184444	184444
			.bss	81768	81768
			.data	3132	3132
			.rodata	79595	79595
			.text	587208	587208
	lock-mtd	LP_CC2652R7	(read only)	616411	616411
			(read/write)	154484	154484
			.bss	77496	77496
			.data	3132	3132
			.rodata	79475	79475
			.text	536448	536448
	pump-app	LP_CC2652R7	(read only)	686743	686743
			(read/write)	166144	166144
			.bss	82160	82160
			.data	3164	3164
			.rodata	81671	81671
			.text	604588	604588
	pump-controller-app	LP_CC2652R7	(read only)	668967	668967
			(read/write)	183664	183664
			.bss	81904	81904
			.data	3128	3128
			.rodata	78007	78007
			.text	590476	590476
esp32	all-clusters-app	c3devkit	(read only)	985074	985074
			(read/write)	1460498	1460498
			.dram0.bss	62952	62952
			.dram0.data	14172	14172
			.flash.rodata	197896	197896
			.flash.text	985074	985074
			.iram0.text	62572	62572
		m5stack	(read only)	1037635	1037635
			(read/write)	461520	461520
			.dram0.bss	68480	68480
			.dram0.data	34024	34024
			.flash.rodata	226872	226872
			.flash.text	1032251	1032251
			.iram0.text	123415	123415
k32w	light	k32w061+release	(read/write)	707112	707112
			.bss	77976	77976
			.data	1872	1872
			.text	621464	621464
	lock	k32w061+release	(read/write)	706520	706520
			.bss	77960	77960
			.data	1912	1912
			.text	620848	620848
linux	chip-tool-no-interactive-ipv6only	arm64	(read only)	10031924	10031924
			(read/write)	477585	477585
			.bss	40401	40401
			.data	1136	1136
			.data.rel.ro	375576	375576
			.dynamic	560	560
			.got	56672	56672
			.init	24	24
			.init_array	192	192
			.rodata	505916	505916
			.text	8462900	8462900
	thermostat-no-ble	arm64	(read only)	2294132	2294132
			(read/write)	148785	148785
			.bss	62849	62849
			.data	1040	1040
			.data.rel.ro	77328	77328
			.dynamic	560	560
			.got	4552	4552
			.init	24	24
			.init_array	360	360
			.rodata	142164	142164
			.text	`1927744`	`1927744`
mbed	lock-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224
			(read/write)	2358540	2358540
			.bss	185052	185052
			.data	5760	5760
			.text	1321140	1321140
nrfconnect	all-clusters-app	nrf52840dk_nrf52840	(read/write)	1147967	1147967
			bss	143076	143076
			rodata	143232	143232
			text	786840	786840
p6	all-clusters-app	default	(read/write)	2503128	2503128
			.bss	118488	118488
			.data	2640	2640
			.text	`1461392`	`1461392`
	light-app	default	(read/write)	2404312	2404312
			.bss	111944	111944
			.data	2496	2496
			.text	1362576	1362576
	lock-app	default	(read/write)	2367920	2367920
			.bss	111688	111688
			.data	2456	2456
			.text	1326184	1326184
telink	lighting-app	tlsr9518adk80d	(read/write)	791300	791300
			bss	70296	70296
			noinit	40416	40416
			text	561262	561262

examples/tv-app/linux/ZclCallbacks.cpp

github-actions · 2022-04-03T14:27:06Z

PR #16944: Size comparison from a673eb7 to 072f205

Increases (11 builds for cc13x2_26x2, cyw30739, linux, mbed, nrfconnect)

platform	target	config	section	`a673eb7`	`072f205`	change	% change
cc13x2_26x2	lock-ftd	LP_CC2652R7	(read only)	667427	667715	288	0.0
			.rodata	79707	79747	40	0.1
			.text	587240	587488	248	0.0
	lock-mtd	LP_CC2652R7	(read only)	616555	616843	288	0.0
			.rodata	79587	79627	40	0.1
			.text	536480	536728	248	0.0
	pump-app	LP_CC2652R7	(read only)	686887	687175	288	0.0
			.rodata	81783	81823	40	0.0
			.text	604620	604868	248	0.0
	pump-controller-app	LP_CC2652R7	(read only)	669111	669399	288	0.0
			.rodata	78119	78159	40	0.1
			.text	590508	590756	248	0.0
cyw30739	light	cyw930739m2evb_01	(read/write)	609810	610098	288	0.0
			.app_xip_area	516552	516840	288	0.1
	lock	cyw930739m2evb_01	(read/write)	567322	567602	280	0.0
			.app_xip_area	475600	475880	280	0.1
	ota-requestor-no-progress-logging	cyw930739m2evb_01	(read/write)	578942	579214	272	0.0
			.app_xip_area	477580	477852	272	0.1
linux	chip-tool-no-interactive-ipv6only	arm64	(read only)	10025340	10033756	8416	0.1
			(read/write)	477521	478177	656	0.1
			.data.rel.ro	375576	376144	568	0.2
			.got	56680	56768	88	0.2
			.rodata	506044	506572	528	0.1
			.text	8456260	8462660	6400	0.1
	thermostat-no-ble	arm64	(read only)	2308604	2309868	1264	0.1
			(read/write)	149137	149185	48	0.0
			.data.rel.ro	77496	77552	56	0.1
			.rodata	143036	143052	16	0.0
			.text	1940384	1941536	1152	0.1
mbed	lock-app	CY8CPROTO_062_4343W+release	(read/write)	2358716	2359004	288	0.0
			.text	1321316	1321604	288	0.0
nrfconnect	all-clusters-app	nrf52840dk_nrf52840	(read/write)	1148055	1148347	292	0.0
			rodata	143320	143356	36	0.0
			text	786840	787092	252	0.0

Decreases (3 builds for cc13x2_26x2)

platform	target	config	section	`a673eb7`	`072f205`	change	% change
cc13x2_26x2	lock-ftd	LP_CC2652R7	(read/write)	184300	184012	-288	-0.2
	pump-app	LP_CC2652R7	(read/write)	166000	165712	-288	-0.2
	pump-controller-app	LP_CC2652R7	(read/write)	183520	183232	-288	-0.2

Full report (11 builds for cc13x2_26x2, cyw30739, linux, mbed, nrfconnect)

platform	target	config	section	`a673eb7`	`072f205`	change	% change
cc13x2_26x2	lock-ftd	LP_CC2652R7	(read only)	667427	667715	288	0.0
			(read/write)	184300	184012	-288	-0.2
			.bss	81768	81768	0	0.0
			.data	3132	3132	0	0.0
			.rodata	79707	79747	40	0.1
			.text	587240	587488	248	0.0
	lock-mtd	LP_CC2652R7	(read only)	616555	616843	288	0.0
			(read/write)	154484	154484	0	0.0
			.bss	77496	77496	0	0.0
			.data	3132	3132	0	0.0
			.rodata	79587	79627	40	0.1
			.text	536480	536728	248	0.0
	pump-app	LP_CC2652R7	(read only)	686887	687175	288	0.0
			(read/write)	166000	165712	-288	-0.2
			.bss	82160	82160	0	0.0
			.data	3164	3164	0	0.0
			.rodata	81783	81823	40	0.0
			.text	604620	604868	248	0.0
	pump-controller-app	LP_CC2652R7	(read only)	669111	669399	288	0.0
			(read/write)	183520	183232	-288	-0.2
			.bss	81904	81904	0	0.0
			.data	3128	3128	0	0.0
			.rodata	78119	78159	40	0.1
			.text	590508	590756	248	0.0
cyw30739	light	cyw930739m2evb_01	(read/write)	609810	610098	288	0.0
			.app_xip_area	516552	516840	288	0.1
			.bss	76004	76004	0	0.0
			.data	600	600	0	0.0
			.rodata	0	0	0	0.0
			.text	0	0	0	0.0
	lock	cyw930739m2evb_01	(read/write)	567322	567602	280	0.0
			.app_xip_area	475600	475880	280	0.1
			.bss	74508	74508	0	0.0
			.data	564	564	0	0.0
			.rodata	0	0	0	0.0
			.text	0	0	0	0.0
	ota-requestor-no-progress-logging	cyw930739m2evb_01	(read/write)	578942	579214	272	0.0
			.app_xip_area	477580	477852	272	0.1
			.bss	83820	83820	0	0.0
			.data	504	504	0	0.0
			.rodata	0	0	0	0.0
			.text	112	112	0	0.0
linux	chip-tool-no-interactive-ipv6only	arm64	(read only)	10025340	10033756	8416	0.1
			(read/write)	477521	478177	656	0.1
			.bss	40337	40337	0	0.0
			.data	1136	1136	0	0.0
			.data.rel.ro	375576	376144	568	0.2
			.dynamic	560	560	0	0.0
			.got	56680	56768	88	0.2
			.init	24	24	0	0.0
			.init_array	184	184	0	0.0
			.rodata	506044	506572	528	0.1
			.text	8456260	8462660	6400	0.1
	thermostat-no-ble	arm64	(read only)	2308604	2309868	1264	0.1
			(read/write)	149137	149185	48	0.0
			.bss	62961	62961	0	0.0
			.data	1080	1080	0	0.0
			.data.rel.ro	77496	77552	56	0.1
			.dynamic	560	560	0	0.0
			.got	4576	4576	0	0.0
			.init	24	24	0	0.0
			.init_array	368	368	0	0.0
			.rodata	143036	143052	16	0.0
			.text	1940384	1941536	1152	0.1
mbed	lock-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0	0.0
			(read/write)	2358716	2359004	288	0.0
			.bss	185052	185052	0	0.0
			.data	5760	5760	0	0.0
			.text	1321316	1321604	288	0.0
nrfconnect	all-clusters-app	nrf52840dk_nrf52840	(read/write)	1148055	1148347	292	0.0
			bss	143076	143076	0	0.0
			rodata	143320	143356	36	0.0
			text	786840	787092	252	0.0

Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>

Revert change pending feedback on level control cluster on endpoint 1

* Restyled by whitespace * Restyled by gn Co-authored-by: Restyled.io <commits@restyled.io>

…#16944) * add attribute change callback hook for speaker endpoint * Update examples/tv-app/linux/ZclCallbacks.cpp Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Update examples/tv-app/linux/ZclCallbacks.cpp Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Delete af-gen-event.h Revert change pending feedback on level control cluster on endpoint 1 * add back af-gen-events * Restyle add attribute change callback hook for speaker endpoint (project-chip#16945) * Restyled by whitespace * Restyled by gn Co-authored-by: Restyled.io <commits@restyled.io> Co-authored-by: Justin Wood <woody@apple.com> Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> Co-authored-by: restyled-io[bot] <32688539+restyled-io[bot]@users.noreply.github.com> Co-authored-by: Restyled.io <commits@restyled.io>

add attribute change callback hook for speaker endpoint

11d77c1

boring-cyborg bot added the examples label Apr 1, 2022

pullapprove bot requested review from saurabhst, selissia, tecimovic, turon, vijs, vivien-apple, wbschiller, woody-apple and xylophone21 April 1, 2022 18:47

restyled-io bot mentioned this pull request Apr 1, 2022

Restyle add attribute change callback hook for speaker endpoint #16945

Merged

pullapprove bot added review - pending and removed V1.0 labels Apr 1, 2022

Merge branch 'master' into tv-apps10

d01b246

woody-apple approved these changes Apr 1, 2022

View reviewed changes

woody-apple added the fast track label Apr 1, 2022

bzbarsky-apple approved these changes Apr 1, 2022

View reviewed changes

examples/tv-app/linux/ZclCallbacks.cpp Outdated Show resolved Hide resolved

examples/tv-app/linux/ZclCallbacks.cpp Outdated Show resolved Hide resolved

chrisdecenzo added 2 commits April 3, 2022 07:03

sync with TOT

6dc264a

sync with TOT

072f205

woody-apple and others added 4 commits April 4, 2022 17:44

Update examples/tv-app/linux/ZclCallbacks.cpp

6935b18

Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>

Update examples/tv-app/linux/ZclCallbacks.cpp

d09e524

Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>

Delete af-gen-event.h

d056256

Revert change pending feedback on level control cluster on endpoint 1

add back af-gen-events

9e81cc3

lazarkov approved these changes Apr 6, 2022

View reviewed changes

Restyle add attribute change callback hook for speaker endpoint (#16945)

9383f24

* Restyled by whitespace * Restyled by gn Co-authored-by: Restyled.io <commits@restyled.io>

andy31415 merged commit f7b39db into master Apr 6, 2022

andy31415 deleted the tv-apps10 branch April 6, 2022 21:18

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add attribute change callback hook for speaker endpoint #16944

add attribute change callback hook for speaker endpoint #16944

chrisdecenzo commented Apr 1, 2022

woody-apple commented Apr 1, 2022

github-actions bot commented Apr 1, 2022

github-actions bot commented Apr 3, 2022 •

edited

Loading

add attribute change callback hook for speaker endpoint #16944

add attribute change callback hook for speaker endpoint #16944

Conversation

chrisdecenzo commented Apr 1, 2022

Problem

Change overview

Testing

woody-apple commented Apr 1, 2022

github-actions bot commented Apr 1, 2022

github-actions bot commented Apr 3, 2022 • edited Loading

github-actions bot commented Apr 3, 2022 •

edited

Loading