Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid CAT check routine in generate-cert #16977

Merged
merged 1 commit into from
Apr 4, 2022

Conversation

joonhaengHeo
Copy link
Contributor

Problem

What is being fixed? Examples:

  • After adding CAT option in generate-cert tool, Cert is not generated.

Change overview

Change invalid CAT check routine.

Testing

How was this tested? (at least one bullet point required)

  • Generate cert using chip-cert tool.

@github-actions
Copy link

github-actions bot commented Apr 4, 2022

PR #16977: Size comparison from 41a431d to 13dd234

Full report (22 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 41a431d 13dd234 change % change
cc13x2_26x2 lock-ftd LP_CC2652R7 (read only) 668091 668091 0 0.0
(read/write) 183604 183604 0 0.0
.bss 81736 81736 0 0.0
.data 3128 3128 0 0.0
.rodata 79683 79683 0 0.0
.text 587928 587928 0 0.0
lock-mtd LP_CC2652R7 (read only) 617211 617211 0 0.0
(read/write) 154448 154448 0 0.0
.bss 77464 77464 0 0.0
.data 3128 3128 0 0.0
.rodata 79563 79563 0 0.0
.text 537160 537160 0 0.0
pump-app LP_CC2652R7 (read only) 687543 687543 0 0.0
(read/write) 165312 165312 0 0.0
.bss 82128 82128 0 0.0
.data 3160 3160 0 0.0
.rodata 81759 81759 0 0.0
.text 605300 605300 0 0.0
pump-controller-app LP_CC2652R7 (read only) 669775 669775 0 0.0
(read/write) 182824 182824 0 0.0
.bss 81872 81872 0 0.0
.data 3124 3124 0 0.0
.rodata 78095 78095 0 0.0
.text 591196 591196 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 610682 610682 0 0.0
.app_xip_area 517456 517456 0 0.0
.bss 75980 75980 0 0.0
.data 596 596 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 568202 568202 0 0.0
.app_xip_area 476504 476504 0 0.0
.bss 74484 74484 0 0.0
.data 560 560 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 579790 579790 0 0.0
.app_xip_area 478460 478460 0 0.0
.bss 83796 83796 0 0.0
.data 500 500 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 916168 916168 0 0.0
(read/write) 129728 129728 0 0.0
.bss 127768 127768 0 0.0
.data 1956 1956 0 0.0
.text 916160 916160 0 0.0
BRD4161A+rpc (read only) 944048 944048 0 0.0
(read/write) 145680 145680 0 0.0
.bss 143544 143544 0 0.0
.data 2136 2136 0 0.0
.text 944040 944040 0 0.0
window-app BRD4161A (read only) 851480 851480 0 0.0
(read/write) 127752 127752 0 0.0
.bss 125912 125912 0 0.0
.data 1836 1836 0 0.0
.text 851472 851472 0 0.0
esp32 all-clusters-app c3devkit (read only) 985940 985940 0 0.0
(read/write) 1460530 1460530 0 0.0
.dram0.bss 62920 62920 0 0.0
.dram0.data 14164 14164 0 0.0
.flash.rodata 197960 197960 0 0.0
.flash.text 985940 985940 0 0.0
.iram0.text 62572 62572 0 0.0
m5stack (read only) 1038339 1038339 0 0.0
(read/write) 461544 461544 0 0.0
.dram0.bss 68448 68448 0 0.0
.dram0.data 34024 34024 0 0.0
.flash.rodata 226928 226928 0 0.0
.flash.text 1032955 1032955 0 0.0
.iram0.text 123415 123415 0 0.0
k32w light k32w061+release (read/write) 707908 707908 0 0.0
.bss 77944 77944 0 0.0
.data 1868 1868 0 0.0
.text 622296 622296 0 0.0
lock k32w061+release (read/write) 707316 707316 0 0.0
.bss 77928 77928 0 0.0
.data 1908 1908 0 0.0
.text 621680 621680 0 0.0
linux chip-tool-no-interactive-ipv6only arm64 (read only) 10035356 10035356 0 0.0
(read/write) 478177 478177 0 0.0
.bss 40337 40337 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 376144 376144 0 0.0
.dynamic 560 560 0 0.0
.got 56768 56768 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 506476 506476 0 0.0
.text 8464356 8464356 0 0.0
thermostat-no-ble arm64 (read only) 2311068 2311068 0 0.0
(read/write) 149057 149057 0 0.0
.bss 62913 62913 0 0.0
.data 1072 1072 0 0.0
.data.rel.ro 77488 77488 0 0.0
.dynamic 560 560 0 0.0
.got 4568 4568 0 0.0
.init 24 24 0 0.0
.init_array 368 368 0 0.0
.rodata 142908 142908 0 0.0
.text 1943040 1943040 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2360020 2360020 0 0.0
.bss 185020 185020 0 0.0
.data 5752 5752 0 0.0
.text 1322620 1322620 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1148763 1148763 0 0.0
bss 143044 143044 0 0.0
rodata 143292 143292 0 0.0
text 787572 787572 0 0.0
p6 all-clusters-app default (read/write) 2504592 2504592 0 0.0
.bss 118456 118456 0 0.0
.data 2632 2632 0 0.0
.text 1462856 1462856 0 0.0
light-app default (read/write) 2405752 2405752 0 0.0
.bss 111912 111912 0 0.0
.data 2488 2488 0 0.0
.text 1364016 1364016 0 0.0
lock-app default (read/write) 2369384 2369384 0 0.0
.bss 111656 111656 0 0.0
.data 2448 2448 0 0.0
.text 1327648 1327648 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 792300 792300 0 0.0
bss 70264 70264 0 0.0
noinit 40416 40416 0 0.0
text 562216 562216 0 0.0

@emargolis
Copy link
Contributor

Thanks for catching this typo. I also noticed this in #16900

@woody-apple woody-apple merged commit b1b85db into project-chip:master Apr 4, 2022
chencheung pushed a commit to chencheung/connectedhomeip that referenced this pull request Apr 6, 2022
chencheung pushed a commit to chencheung/connectedhomeip that referenced this pull request Apr 6, 2022
andrei-menzopol pushed a commit to andrei-menzopol/connectedhomeip that referenced this pull request Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants