-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fail A record parsing if IPV4 is disabled in CHIP #17074
Merged
andy31415
merged 2 commits into
project-chip:master
from
andy31415:bug/fail_ipv4_parse_if_disabled
Apr 5, 2022
Merged
Fail A record parsing if IPV4 is disabled in CHIP #17074
andy31415
merged 2 commits into
project-chip:master
from
andy31415:bug/fail_ipv4_parse_if_disabled
Apr 5, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
austinh0,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
hawk248,
holbrookt,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
kpschoedel,
lazarkov,
LuDuda,
mrjerryjohns,
msandstedt and
mspang
April 5, 2022 17:34
pullapprove
bot
requested review from
lazarkov,
LuDuda,
mrjerryjohns,
msandstedt,
mspang,
robszewczyk,
sagar-apple,
saurabhst,
selissia,
tecimovic,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
April 5, 2022 17:34
cecille
approved these changes
Apr 5, 2022
mrjerryjohns
reviewed
Apr 5, 2022
PR #17074: Size comparison from bc01144 to 51941d6 Decreases (1 build for linux)
Full report (28 builds for cc13x2_26x2, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
bzbarsky-apple
approved these changes
Apr 5, 2022
chencheung
pushed a commit
to chencheung/connectedhomeip
that referenced
this pull request
Apr 6, 2022
* Fail A record parsing if IPV4 is disabled in CHIP * Enable ARecord parse test in IPV6 as well
chencheung
pushed a commit
to chencheung/connectedhomeip
that referenced
this pull request
Apr 6, 2022
* Fail A record parsing if IPV4 is disabled in CHIP * Enable ARecord parse test in IPV6 as well
andrei-menzopol
pushed a commit
to andrei-menzopol/connectedhomeip
that referenced
this pull request
Apr 14, 2022
* Fail A record parsing if IPV4 is disabled in CHIP * Enable ARecord parse test in IPV6 as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
MinMDNS blindly parses A records even though code relies that IPV4 disabled means no IPV4 addresses anywhere.
Change overview
Refuse to parse A records if no IPV4 support.
Fixes #16837
Testing
Compile and unit test updated.