Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable featuremap for color control server #17082

Merged
merged 1 commit into from
Apr 6, 2022
Merged

Enable featuremap for color control server #17082

merged 1 commit into from
Apr 6, 2022

Conversation

jmartinez-silabs
Copy link
Member

Problem

Change overview

Enable featuremap for color control server and update cluster revision for all-cluster app and ligthing-app.
regen

Testing

send command
./chip-tool colorcontrol read feature-map 1339 1
on lighting app. Response is successful and the expected value (31)

@github-actions
Copy link

github-actions bot commented Apr 5, 2022 •
edited
Loading

PR #17082: Size comparison from 929b39b to 3c33e3a

Increases (12 builds for efr32, esp32, k32w, linux, nrfconnect, p6, telink)
platform target config section 929b39b 3c33e3a change % change
efr32 lighting-app BRD4161A (read only) 919564 919580 16 0.0
.text 919556 919572 16 0.0
BRD4161A+rpc (read only) 947476 947492 16 0.0
.text 947468 947484 16 0.0
esp32 all-clusters-app c3devkit (read/write) 1460922 1460946 24 0.0
.flash.rodata 198288 198312 24 0.0
m5stack (read only) 1040787 1040795 8 0.0
(read/write) 461912 461936 24 0.0
.flash.rodata 227232 227256 24 0.0
.flash.text 1035403 1035411 8 0.0
k32w light k32w061+release (read/write) 681640 681656 16 0.0
.text 595664 595680 16 0.0
linux all-clusters-app debug (read only) 2595721 2595745 24 0.0
(read/write) 144872 144904 32 0.0
.data.rel.ro 79880 79912 32 0.0
lighting-app debug+rpc (read only) 2255481 2255505 24 0.0
(read/write) 125312 125344 32 0.0
.data.rel.ro 68808 68840 32 0.0
shell debug (read only) 2491433 2491457 24 0.0
(read/write) 148336 148368 32 0.0
.data.rel.ro 74424 74456 32 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1149495 1149515 20 0.0
bss 135556 135560 4 0.0
rodata 145088 145108 20 0.0
p6 all-clusters-app default (read/write) 2507928 2507952 24 0.0
.text 1466192 1466216 24 0.0
light-app default (read/write) 2409120 2409144 24 0.0
.text 1367384 1367408 24 0.0
telink lighting-app tlsr9518adk80d (read/write) 794888 794908 20 0.0
bss 70044 70048 4 0.0
Full report (28 builds for cc13x2_26x2, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 929b39b 3c33e3a change % change
cc13x2_26x2 lock-ftd LP_CC2652R7 (read only) 670815 670815 0 0.0
(read/write) 180648 180648 0 0.0
.bss 81504 81504 0 0.0
.data 3164 3164 0 0.0
.rodata 80039 80039 0 0.0
.text 590296 590296 0 0.0
lock-mtd LP_CC2652R7 (read only) 619943 619943 0 0.0
(read/write) 154252 154252 0 0.0
.bss 77232 77232 0 0.0
.data 3164 3164 0 0.0
.rodata 79927 79927 0 0.0
.text 539528 539528 0 0.0
pump-app LP_CC2652R7 (read only) 690231 690231 0 0.0
(read/write) 162408 162408 0 0.0
.bss 81912 81912 0 0.0
.data 3196 3196 0 0.0
.rodata 82127 82127 0 0.0
.text 607620 607620 0 0.0
pump-controller-app LP_CC2652R7 (read only) 672471 672471 0 0.0
(read/write) 179896 179896 0 0.0
.bss 81640 81640 0 0.0
.data 3160 3160 0 0.0
.rodata 78463 78463 0 0.0
.text 593524 593524 0 0.0
efr32 lighting-app BRD4161A (read only) 919564 919580 16 0.0
(read/write) 129536 129536 0 0.0
.bss 127544 127544 0 0.0
.data 1992 1992 0 0.0
.text 919556 919572 16 0.0
BRD4161A+rpc (read only) 947476 947492 16 0.0
(read/write) 145484 145484 0 0.0
.bss 143312 143312 0 0.0
.data 2172 2172 0 0.0
.text 947468 947484 16 0.0
window-app BRD4161A (read only) 854732 854732 0 0.0
(read/write) 127560 127560 0 0.0
.bss 125688 125688 0 0.0
.data 1872 1872 0 0.0
.text 854724 854724 0 0.0
esp32 all-clusters-app c3devkit (read only) 988422 988422 0 0.0
(read/write) 1460922 1460946 24 0.0
.dram0.bss 62952 62952 0 0.0
.dram0.data 14196 14196 0 0.0
.flash.rodata 198288 198312 24 0.0
.flash.text 988422 988422 0 0.0
.iram0.text 62572 62572 0 0.0
m5stack (read only) 1040787 1040795 8 0.0
(read/write) 461912 461936 24 0.0
.dram0.bss 68480 68480 0 0.0
.dram0.data 34056 34056 0 0.0
.flash.rodata 227232 227256 24 0.0
.flash.text 1035403 1035411 8 0.0
.iram0.text 123415 123415 0 0.0
k32w light k32w061+release (read/write) 681640 681656 16 0.0
.bss 78192 78192 0 0.0
.data 1984 1984 0 0.0
.text 595664 595680 16 0.0
lock k32w061+release (read/write) 686120 686120 0 0.0
.bss 78776 78776 0 0.0
.data 1944 1944 0 0.0
.text 599600 599600 0 0.0
linux all-clusters-app debug (read only) 2595721 2595745 24 0.0
(read/write) 144872 144904 32 0.0
.bss 57664 57664 0 0.0
.data 1440 1440 0 0.0
.data.rel.ro 79880 79912 32 0.0
.dynamic 592 592 0 0.0
.got 4312 4312 0 0.0
.init 27 27 0 0.0
.init_array 960 960 0 0.0
.rodata 221285 221285 0 0.0
.text 2206418 2206418 0 0.0
bridge-app debug+rpc (read only) 1804485 1804485 0 0.0
(read/write) 90296 90296 0 0.0
.bss 44584 44584 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 38584 38584 0 0.0
.dynamic 592 592 0 0.0
.got 3928 3928 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 147513 147513 0 0.0
.text 1540341 1540341 0 0.0
chip-tool debug (read only) 10632245 10632245 0 0.0
(read/write) 370520 370520 0 0.0
.bss 22592 22592 0 0.0
.data 1040 1040 0 0.0
.data.rel.ro 340656 340656 0 0.0
.dynamic 624 624 0 0.0
.got 4928 4928 0 0.0
.init 27 27 0 0.0
.init_array 656 656 0 0.0
.rodata 535949 535949 0 0.0
.text 9269493 9269493 0 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 10242460 10242460 0 0.0
(read/write) 490609 490609 0 0.0
.bss 40897 40897 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 387648 387648 0 0.0
.dynamic 560 560 0 0.0
.got 57128 57128 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 510412 510412 0 0.0
.text 8632292 8632292 0 0.0
door-lock-app debug (read only) 2075969 2075969 0 0.0
(read/write) 118320 118320 0 0.0
.bss 47904 47904 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 63704 63704 0 0.0
.dynamic 592 592 0 0.0
.got 4256 4256 0 0.0
.init 27 27 0 0.0
.init_array 680 680 0 0.0
.rodata 185513 185513 0 0.0
.text 1736642 1736642 0 0.0
lighting-app debug+rpc (read only) 2255481 2255505 24 0.0
(read/write) 125312 125344 32 0.0
.bss 49216 49216 0 0.0
.data 1600 1600 0 0.0
.data.rel.ro 68808 68840 32 0.0
.dynamic 608 608 0 0.0
.got 4304 4304 0 0.0
.init 27 27 0 0.0
.init_array 760 760 0 0.0
.rodata 179625 179625 0 0.0
.text 1912578 1912578 0 0.0
ota-provider-app debug (read only) 2013889 2013889 0 0.0
(read/write) 113888 113888 0 0.0
.bss 47744 47744 0 0.0
.data 1384 1384 0 0.0
.data.rel.ro 59032 59032 0 0.0
.dynamic 608 608 0 0.0
.got 4456 4456 0 0.0
.init 27 27 0 0.0
.init_array 632 632 0 0.0
.rodata 171403 171403 0 0.0
.text 1687762 1687762 0 0.0
ota-requestor-app debug (read only) 2043465 2043465 0 0.0
(read/write) 117208 117208 0 0.0
.bss 48736 48736 0 0.0
.data 1608 1608 0 0.0
.data.rel.ro 61272 61272 0 0.0
.dynamic 592 592 0 0.0
.got 4296 4296 0 0.0
.init 27 27 0 0.0
.init_array 656 656 0 0.0
.rodata 167892 167892 0 0.0
.text 1719074 1719074 0 0.0
shell debug (read only) 2491433 2491457 24 0.0
(read/write) 148336 148368 32 0.0
.bss 67336 67336 0 0.0
.data 848 848 0 0.0
.data.rel.ro 74424 74456 32 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 212978 212978 0 0.0
.text 2119922 2119922 0 0.0
thermostat-no-ble arm64 (read only) 2327068 2327068 0 0.0
(read/write) 149521 149521 0 0.0
.bss 62977 62977 0 0.0
.data 1136 1136 0 0.0
.data.rel.ro 77760 77760 0 0.0
.dynamic 560 560 0 0.0
.got 4632 4632 0 0.0
.init 24 24 0 0.0
.init_array 368 368 0 0.0
.rodata 143340 143340 0 0.0
.text 1957888 1957888 0 0.0
tv-app debug (read only) 2764873 2764873 0 0.0
(read/write) 249984 249984 0 0.0
.bss 165360 165360 0 0.0
.data 3392 3392 0 0.0
.data.rel.ro 75040 75040 0 0.0
.dynamic 592 592 0 0.0
.got 4672 4672 0 0.0
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 211467 211467 0 0.0
.text 2374578 2374578 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2363084 2363084 0 0.0
.bss 185052 185052 0 0.0
.data 5784 5784 0 0.0
.text 1325684 1325684 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1149495 1149515 20 0.0
bss 135556 135560 4 0.0
rodata 145088 145108 20 0.0
text 790228 790228 0 0.0
p6 all-clusters-app default (read/write) 2507928 2507952 24 0.0
.bss 118480 118480 0 0.0
.data 2672 2672 0 0.0
.text 1466192 1466216 24 0.0
light-app default (read/write) 2409120 2409144 24 0.0
.bss 111944 111944 0 0.0
.data 2528 2528 0 0.0
.text 1367384 1367408 24 0.0
lock-app default (read/write) 2372816 2372816 0 0.0
.bss 111688 111688 0 0.0
.data 2488 2488 0 0.0
.text 1331080 1331080 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 794888 794908 20 0.0
bss 70044 70048 4 0.0
noinit 40416 40416 0 0.0
text 564606 564606 0 0.0

@jmartinez-silabs jmartinez-silabs merged commit 42d1e4d into project-chip:master Apr 6, 2022
@jmartinez-silabs jmartinez-silabs deleted the color_featuremap branch April 6, 2022 12:49
andrei-menzopol pushed a commit to andrei-menzopol/connectedhomeip that referenced this pull request Apr 14, 2022
@jmartinez-silabs @andrei-menzopol
Enable featuremap for color control server and update cluster revision (
a846fe9 
project-chip#17082)
mspang pushed a commit that referenced this pull request Apr 21, 2022
@jmartinez-silabs @mspang
Enable featuremap for color control server and update cluster revision (
b3c47ab 
#17082)

(cherry picked from commit 42d1e4d)
@bzbarsky-apple bzbarsky-apple mentioned this pull request May 22, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy31415 andy31415 andy31415 approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@kghost kghost Awaiting requested review from kghost

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@msandstedt msandstedt Awaiting requested review from msandstedt

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

Assignees
No one assigned
Labels
app controller darwin examples review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

If feature-map is read in Color Control Cluster it throws error code as 0x86(unsupported attribute)
3 participants
@jmartinez-silabs @andy31415 @bzbarsky-apple