-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EFR32] Update EFR32 Thread Stack Manager Impl #17111
Merged
jepenven-silabs
merged 1 commit into
project-chip:master
from
jepenven-silabs:efr32_openthread_impl_update
Apr 6, 2022
Merged
[EFR32] Update EFR32 Thread Stack Manager Impl #17111
jepenven-silabs
merged 1 commit into
project-chip:master
from
jepenven-silabs:efr32_openthread_impl_update
Apr 6, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Damian-Nordic
approved these changes
Apr 6, 2022
andy31415
approved these changes
Apr 6, 2022
pullapprove
bot
requested review from
anush-apple,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
hawk248,
harsha-rajendran,
isiu-apple,
jelderton,
jmartinez-silabs,
lazarkov,
msandstedt,
sagar-apple,
saurabhst,
selissia,
tecimovic,
vijs and
vivien-apple
April 6, 2022 14:01
jmeg-sfy
approved these changes
Apr 6, 2022
PR #17111: Size comparison from fc1eae7 to 5878beb Increases above 0.2%:
Increases (3 builds for efr32)
Decreases (3 builds for efr32)
Full report (19 builds for cc13x2_26x2, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
jmartinez-silabs
approved these changes
Apr 6, 2022
andrei-menzopol
pushed a commit
to andrei-menzopol/connectedhomeip
that referenced
this pull request
Apr 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Having LwIP Impl on top of the UDPEndpointImplOpenThread cause a lot of bloating in the EFR32 platform implementation
Change overview
Switch from GenericThreadStackManagerImpl_OpenThread_LwIP to GenericThreadStackManagerImpl_OpenThread for the EFR32 platform.
Also generic cleanup of the EFR32 platform code
Testing
Unit Test, Yaml test, in house platform test