Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove built-in dnssd cache #17114

Merged
merged 1 commit into from
Apr 6, 2022
Merged

Remove built-in dnssd cache #17114

merged 1 commit into from
Apr 6, 2022

Conversation

andy31415
Copy link
Contributor

Problem

Existing dnssd cache size is already set to 0 across all platforms. Having caching logic increases code complexity and maintenance cost.

Implementation was only ever supported by the PlatformDnssd
implementation, which generally have their own cache (like avahi or
bonjour).

Change overview

Remove DSSSD cache and usage.

Testing

Unit tests executed, CI will validate compilation and more tests.

@andy31415
Remove built-in dnssd cache
b335fe3 
Existing is already set to 0 across all platforms.

Implementation was only ever supported by the PlatformDnssd
implementation, which generally have their own cache (like avahi or
bonjour).
@github-actions
Copy link

github-actions bot commented Apr 6, 2022 •
edited
Loading

PR #17114: Size comparison from 56f738f to b335fe3

Increases (3 builds for cc13x2_26x2)
platform target config section 56f738f b335fe3 change % change
cc13x2_26x2 lock-ftd LP_CC2652R7 (read/write) 177204 177236 32 0.0
pump-app LP_CC2652R7 (read/write) 161064 161096 32 0.0
pump-controller-app LP_CC2652R7 (read/write) 176436 176468 32 0.0
Decreases (23 builds for cc13x2_26x2, efr32, esp32, linux, mbed, nrfconnect, p6, telink)
platform target config section 56f738f b335fe3 change % change
cc13x2_26x2 lock-ftd LP_CC2652R7 (read only) 674307 674275 -32 -0.0
.rodata 80579 80555 -24 -0.0
.text 593248 593240 -8 -0.0
lock-mtd LP_CC2652R7 (read only) 623443 623419 -24 -0.0
.rodata 80467 80443 -24 -0.0
pump-app LP_CC2652R7 (read only) 691607 691575 -32 -0.0
.rodata 82511 82487 -24 -0.0
.text 608612 608604 -8 -0.0
pump-controller-app LP_CC2652R7 (read only) 675979 675947 -32 -0.0
.rodata 79011 78987 -24 -0.0
.text 596484 596476 -8 -0.0
efr32 lighting-app BRD4161A (read only) 923476 923436 -40 -0.0
.text 923468 923428 -40 -0.0
BRD4161A+rpc (read only) 951364 951324 -40 -0.0
.text 951356 951316 -40 -0.0
esp32 all-clusters-app c3devkit (read only) 991668 991666 -2 -0.0
(read/write) 1461530 1461506 -24 -0.0
.flash.rodata 198784 198760 -24 -0.0
.flash.text 991668 991666 -2 -0.0
m5stack (read only) 1043503 1043499 -4 -0.0
(read/write) 462488 462464 -24 -0.0
.flash.rodata 227752 227728 -24 -0.0
.flash.text 1038119 1038115 -4 -0.0
linux chip-tool-no-interactive-ipv6only arm64 (read only) 10278220 10278076 -144 -0.0
.rodata 512396 512364 -32 -0.0
.text 8663044 8662932 -112 -0.0
thermostat-no-ble arm64 (read only) 2344188 2344060 -128 -0.0
.rodata 144364 144348 -16 -0.0
.text 1972672 1972560 -112 -0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2475504 2475480 -24 -0.0
.text 1438076 1438052 -24 -0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2434728 2434704 -24 -0.0
.text 1397300 1397276 -24 -0.0
shell CY8CPROTO_062_4343W+release (read/write) 2360976 2360952 -24 -0.0
.text 1323548 1323524 -24 -0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1152967 1152943 -24 -0.0
rodata 145632 145608 -24 -0.0
text 793156 793152 -4 -0.0
lighting-app nrf52840dk_nrf52840 (read/write) 1139895 1139871 -24 -0.0
rodata 121192 121168 -24 -0.0
text 800792 800788 -4 -0.0
nrf52840dk_nrf52840+rpc (read/write) 1104135 1104111 -24 -0.0
rodata 112320 112296 -24 -0.0
text 773204 773200 -4 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 1048610 1048570 -40 -0.0
rodata 114368 114344 -24 -0.0
text 715956 715952 -4 -0.0
lock-app nrf52840dk_nrf52840 (read/write) 1040239 1040215 -24 -0.0
rodata 114096 114072 -24 -0.0
text 718512 718508 -4 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 949342 949302 -40 -0.0
rodata 107324 107300 -24 -0.0
text 633828 633824 -4 -0.0
pump-app nrf52840dk_nrf52840 (read/write) 1059263 1059239 -24 -0.0
rodata 116176 116152 -24 -0.0
text 735296 735292 -4 -0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 1041435 1041395 -40 -0.0
rodata 112396 112372 -24 -0.0
text 721532 721528 -4 -0.0
p6 all-clusters-app default (read/write) 2511992 2511968 -24 -0.0
.text 1470256 1470232 -24 -0.0
telink lighting-app tlsr9518adk80d (read/write) 798836 798804 -32 -0.0
text 567918 567916 -2 -0.0
Full report (30 builds for cc13x2_26x2, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 56f738f b335fe3 change % change
cc13x2_26x2 lock-ftd LP_CC2652R7 (read only) 674307 674275 -32 -0.0
(read/write) 177204 177236 32 0.0
.bss 81552 81552 0 0.0
.data 3168 3168 0 0.0
.rodata 80579 80555 -24 -0.0
.text 593248 593240 -8 -0.0
lock-mtd LP_CC2652R7 (read only) 623443 623419 -24 -0.0
(read/write) 154304 154304 0 0.0
.bss 77280 77280 0 0.0
.data 3168 3168 0 0.0
.rodata 80467 80443 -24 -0.0
.text 542488 542488 0 0.0
pump-app LP_CC2652R7 (read only) 691607 691575 -32 -0.0
(read/write) 161064 161096 32 0.0
.bss 81944 81944 0 0.0
.data 3200 3200 0 0.0
.rodata 82511 82487 -24 -0.0
.text 608612 608604 -8 -0.0
pump-controller-app LP_CC2652R7 (read only) 675979 675947 -32 -0.0
(read/write) 176436 176468 32 0.0
.bss 81688 81688 0 0.0
.data 3164 3164 0 0.0
.rodata 79011 78987 -24 -0.0
.text 596484 596476 -8 -0.0
efr32 lighting-app BRD4161A (read only) 923476 923436 -40 -0.0
(read/write) 129580 129580 0 0.0
.bss 127584 127584 0 0.0
.data 1996 1996 0 0.0
.text 923468 923428 -40 -0.0
BRD4161A+rpc (read only) 951364 951324 -40 -0.0
(read/write) 145528 145528 0 0.0
.bss 143352 143352 0 0.0
.data 2176 2176 0 0.0
.text 951356 951316 -40 -0.0
window-app BRD4161A (read only) 860796 860796 0 0.0
(read/write) 127640 127640 0 0.0
.bss 125760 125760 0 0.0
.data 1880 1880 0 0.0
.text 860788 860788 0 0.0
esp32 all-clusters-app c3devkit (read only) 991668 991666 -2 -0.0
(read/write) 1461530 1461506 -24 -0.0
.dram0.bss 63000 63000 0 0.0
.dram0.data 14260 14260 0 0.0
.flash.rodata 198784 198760 -24 -0.0
.flash.text 991668 991666 -2 -0.0
.iram0.text 62572 62572 0 0.0
m5stack (read only) 1043503 1043499 -4 -0.0
(read/write) 462488 462464 -24 -0.0
.dram0.bss 68528 68528 0 0.0
.dram0.data 34064 34064 0 0.0
.flash.rodata 227752 227728 -24 -0.0
.flash.text 1038119 1038115 -4 -0.0
.iram0.text 123415 123415 0 0.0
k32w light k32w061+release (read/write) 684828 684828 0 0.0
.bss 78240 78240 0 0.0
.data 1988 1988 0 0.0
.text 598800 598800 0 0.0
lock k32w061+release (read/write) 689668 689668 0 0.0
.bss 78816 78816 0 0.0
.data 1948 1948 0 0.0
.text 603104 603104 0 0.0
linux chip-tool-no-interactive-ipv6only arm64 (read only) 10278220 10278076 -144 -0.0
(read/write) 492033 492033 0 0.0
.bss 41041 41041 0 0.0
.data 1120 1120 0 0.0
.data.rel.ro 388704 388704 0 0.0
.dynamic 560 560 0 0.0
.got 57360 57360 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 512396 512364 -32 -0.0
.text 8663044 8662932 -112 -0.0
thermostat-no-ble arm64 (read only) 2344188 2344060 -128 -0.0
(read/write) 150257 150257 0 0.0
.bss 63169 63169 0 0.0
.data 1136 1136 0 0.0
.data.rel.ro 78184 78184 0 0.0
.dynamic 560 560 0 0.0
.got 4752 4752 0 0.0
.init 24 24 0 0.0
.init_array 368 368 0 0.0
.rodata 144364 144348 -16 -0.0
.text 1972672 1972560 -112 -0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2475504 2475480 -24 -0.0
.bss 191016 191016 0 0.0
.data 5496 5496 0 0.0
.text 1438076 1438052 -24 -0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2434728 2434704 -24 -0.0
.bss 186316 186316 0 0.0
.data 5808 5808 0 0.0
.text 1397300 1397276 -24 -0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2366580 2366580 0 0.0
.bss 185092 185092 0 0.0
.data 5792 5792 0 0.0
.text 1329180 1329180 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2360976 2360952 -24 -0.0
.bss 184856 184856 0 0.0
.data 5600 5600 0 0.0
.text 1323548 1323524 -24 -0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1152967 1152943 -24 -0.0
bss 135604 135604 0 0.0
rodata 145632 145608 -24 -0.0
text 793156 793152 -4 -0.0
lighting-app nrf52840dk_nrf52840 (read/write) 1139895 1139871 -24 -0.0
bss 139308 139308 0 0.0
rodata 121192 121168 -24 -0.0
text 800792 800788 -4 -0.0
nrf52840dk_nrf52840+rpc (read/write) 1104135 1104111 -24 -0.0
bss 139544 139544 0 0.0
rodata 112320 112296 -24 -0.0
text 773204 773200 -4 -0.0
nrf52840dongle_nrf52840 (read/write) 1154287 1154287 0 0.0
bss 140308 140308 0 0.0
rodata 120748 120748 0 0.0
text 803664 803664 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 1048610 1048570 -40 -0.0
bss 136372 136372 0 0.0
rodata 114368 114344 -24 -0.0
text 715956 715952 -4 -0.0
lock-app nrf52840dk_nrf52840 (read/write) 1040239 1040215 -24 -0.0
bss 129252 129252 0 0.0
rodata 114096 114072 -24 -0.0
text 718512 718508 -4 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 949342 949302 -40 -0.0
bss 126348 126348 0 0.0
rodata 107324 107300 -24 -0.0
text 633828 633824 -4 -0.0
pump-app nrf52840dk_nrf52840 (read/write) 1059263 1059239 -24 -0.0
bss 129168 129168 0 0.0
rodata 116176 116152 -24 -0.0
text 735296 735292 -4 -0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 1041435 1041395 -40 -0.0
bss 128912 128912 0 0.0
rodata 112396 112372 -24 -0.0
text 721532 721528 -4 -0.0
p6 all-clusters-app default (read/write) 2511992 2511968 -24 -0.0
.bss 118528 118528 0 0.0
.data 2672 2672 0 0.0
.text 1470256 1470232 -24 -0.0
light-app default (read/write) 2413168 2413168 0 0.0
.bss 111992 111992 0 0.0
.data 2528 2528 0 0.0
.text 1371432 1371432 0 0.0
lock-app default (read/write) 2376848 2376848 0 0.0
.bss 111736 111736 0 0.0
.data 2488 2488 0 0.0
.text 1335112 1335112 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 798836 798804 -32 -0.0
bss 70096 70096 0 0.0
noinit 40416 40416 0 0.0
text 567918 567916 -2 -0.0

@andy31415 andy31415 merged commit e434e64 into project-chip:master Apr 6, 2022
andrei-menzopol pushed a commit to andrei-menzopol/connectedhomeip that referenced this pull request Apr 14, 2022
@andy31415 @andrei-menzopol
Remove built-in dnssd cache (project-chip#17114)
0fbe600 
Existing is already set to 0 across all platforms.

Implementation was only ever supported by the PlatformDnssd
implementation, which generally have their own cache (like avahi or
bonjour).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Damian-Nordic Damian-Nordic Damian-Nordic approved these changes

@msandstedt msandstedt msandstedt approved these changes

@tcarmelveilleux tcarmelveilleux tcarmelveilleux approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mspang mspang Awaiting requested review from mspang

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

Assignees
No one assigned
Labels
app controller efr32 esp32 lib linux nrf connect platform review - approved telink
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andy31415 @tcarmelveilleux @msandstedt @Damian-Nordic