-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop requiring a fabric index to be provided when writing fabric-scoped structs with chip-tool. #17145
Merged
bzbarsky-apple
merged 1 commit into
project-chip:master
from
bzbarsky-apple:chip-tool-no-fabric-index-required
Apr 7, 2022
Merged
Stop requiring a fabric index to be provided when writing fabric-scoped structs with chip-tool. #17145
bzbarsky-apple
merged 1 commit into
project-chip:master
from
bzbarsky-apple:chip-tool-no-fabric-index-required
Apr 7, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed structs with chip-tool. It's ignored on the server anyway, so no need to require people to send it.
pullapprove
bot
requested review from
anush-apple,
austinh0,
Byungjoo-Lee,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
hawk248,
holbrookt,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
lazarkov,
LuDuda and
mrjerryjohns
April 6, 2022 20:11
pullapprove
bot
requested review from
msandstedt,
mspang,
robszewczyk,
sagar-apple,
saurabhst,
selissia,
tecimovic,
vijs,
wbschiller,
woody-apple and
xylophone21
April 6, 2022 20:12
msandstedt
approved these changes
Apr 6, 2022
mlepage-google
approved these changes
Apr 6, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
O frabjous day, calloo, callay!
PR #17145: Size comparison from e434e64 to 5f7212b Decreases (2 builds for linux)
Full report (28 builds for cc13x2_26x2, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
andrei-menzopol
pushed a commit
to andrei-menzopol/connectedhomeip
that referenced
this pull request
Apr 14, 2022
…ed structs with chip-tool. (project-chip#17145) It's ignored on the server anyway, so no need to require people to send it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's ignored on the server anyway, so no need to require people to send it.
Problem
Consumers have to write things like:
and then the fabric index gets ignored.
Change overview
Allow writing:
and having it work.
Testing
Checked that parsing the new syntax does not fail. Examined the generated code to make sure it's sane.