Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused per-controller storage delegate #17258

Merged
merged 7 commits into from
Apr 11, 2022
Merged

Remove unused per-controller storage delegate #17258

merged 7 commits into from
Apr 11, 2022

Conversation

bzbarsky-apple
Copy link
Contributor

Problem

We're passing it around, but nothing actually uses it in practice.

Change overview

Remove a bunch of dead code.

Testing

CI should still pass. Each changeset was tested to compile.

Review notes: Since each changeset here was tested to compile, it might be easier to verify correctness by just looking at the changesets individually.

@github-actions
Copy link

github-actions bot commented Apr 11, 2022 •
edited
Loading

PR #17258: Size comparison from 8720d46 to f9c7706

Decreases (3 builds for linux)
platform target config section 8720d46 f9c7706 change % change
linux chip-tool debug (read only) 10678301 10675437 -2864 -0.0
.rodata 538165 537909 -256 -0.0
.text 9310949 9308341 -2608 -0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 10279260 10276268 -2992 -0.0
(read/write) 492193 492145 -48 -0.0
.data.rel.ro 388824 388776 -48 -0.0
.rodata 512428 512204 -224 -0.0
.text 8663652 8660932 -2720 -0.0
tv-app debug (read only) 2797409 2794545 -2864 -0.1
(read/write) 251576 250520 -1056 -0.4
.bss 165032 163976 -1056 -0.6
.rodata 213451 213227 -224 -0.1
.text 2402754 2400114 -2640 -0.1
Full report (31 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 8720d46 f9c7706 change % change
cc13x2_26x2 lock-ftd LP_CC2652R7 (read only) 639651 639651 0 0.0
(read/write) 151052 151052 0 0.0
.bss 73984 73984 0 0.0
.data 3212 3212 0 0.0
.rodata 80131 80131 0 0.0
.text 559028 559028 0 0.0
lock-mtd LP_CC2652R7 (read only) 588387 588387 0 0.0
(read/write) 146772 146772 0 0.0
.bss 69704 69704 0 0.0
.data 3212 3212 0 0.0
.rodata 80011 80011 0 0.0
.text 507884 507884 0 0.0
pump-app LP_CC2652R7 (read only) 647471 647471 0 0.0
(read/write) 152348 152348 0 0.0
.bss 74480 74480 0 0.0
.data 3244 3244 0 0.0
.rodata 75279 75279 0 0.0
.text 571704 571704 0 0.0
pump-controller-app LP_CC2652R7 (read only) 641699 641699 0 0.0
(read/write) 152016 152016 0 0.0
.bss 74184 74184 0 0.0
.data 3208 3208 0 0.0
.rodata 78947 78947 0 0.0
.text 562264 562264 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 617822 617822 0 0.0
.app_xip_area 524948 524948 0 0.0
.bss 75540 75540 0 0.0
.data 684 684 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 575426 575426 0 0.0
.app_xip_area 484088 484088 0 0.0
.bss 74036 74036 0 0.0
.data 648 648 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 563958 563958 0 0.0
.app_xip_area 462992 462992 0 0.0
.bss 83368 83368 0 0.0
.data 564 564 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 906696 906696 0 0.0
(read/write) 132920 132920 0 0.0
.bss 130880 130880 0 0.0
.data 2040 2040 0 0.0
.text 906688 906688 0 0.0
BRD4161A+rpc (read only) 934568 934568 0 0.0
(read/write) 148872 148872 0 0.0
.bss 146648 146648 0 0.0
.data 2220 2220 0 0.0
.text 934560 934560 0 0.0
window-app BRD4161A (read only) 843688 843688 0 0.0
(read/write) 130992 130992 0 0.0
.bss 129040 129040 0 0.0
.data 1948 1948 0 0.0
.text 843680 843680 0 0.0
esp32 all-clusters-app c3devkit (read only) 992918 992918 0 0.0
(read/write) 1462514 1462514 0 0.0
.dram0.bss 62960 62960 0 0.0
.dram0.data 14364 14364 0 0.0
.flash.rodata 199720 199720 0 0.0
.flash.text 992918 992918 0 0.0
.iram0.text 62572 62572 0 0.0
m5stack (read only) 1045591 1045591 0 0.0
(read/write) 463576 463576 0 0.0
.dram0.bss 68480 68480 0 0.0
.dram0.data 34160 34160 0 0.0
.flash.rodata 228792 228792 0 0.0
.flash.text 1040207 1040207 0 0.0
.iram0.text 123415 123415 0 0.0
k32w light k32w061+release (read/write) 686348 686348 0 0.0
.bss 77968 77968 0 0.0
.data 2036 2036 0 0.0
.text 600544 600544 0 0.0
lock k32w061+release (read/write) 690948 690948 0 0.0
.bss 78544 78544 0 0.0
.data 1996 1996 0 0.0
.text 604608 604608 0 0.0
linux all-clusters-app debug (read only) 2627329 2627329 0 0.0
(read/write) 146248 146248 0 0.0
.bss 57664 57664 0 0.0
.data 1824 1824 0 0.0
.data.rel.ro 80856 80856 0 0.0
.dynamic 592 592 0 0.0
.got 4320 4320 0 0.0
.init 27 27 0 0.0
.init_array 960 960 0 0.0
.rodata 222981 222981 0 0.0
.text 2233746 2233746 0 0.0
bridge-app debug+rpc (read only) 1834861 1834861 0 0.0
(read/write) 91592 91592 0 0.0
.bss 44344 44344 0 0.0
.data 2912 2912 0 0.0
.data.rel.ro 39240 39240 0 0.0
.dynamic 592 592 0 0.0
.got 3936 3936 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 148473 148473 0 0.0
.text 1568053 1568053 0 0.0
chip-tool debug (read only) 10678301 10675437 -2864 -0.0
(read/write) 371800 371800 0 0.0
.bss 22752 22752 0 0.0
.data 1104 1104 0 0.0
.data.rel.ro 341680 341680 0 0.0
.dynamic 624 624 0 0.0
.got 4936 4936 0 0.0
.init 27 27 0 0.0
.init_array 656 656 0 0.0
.rodata 538165 537909 -256 -0.0
.text 9310949 9308341 -2608 -0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 10279260 10276268 -2992 -0.0
(read/write) 492193 492145 -48 -0.0
.bss 41009 41009 0 0.0
.data 1168 1168 0 0.0
.data.rel.ro 388824 388776 -48 -0.0
.dynamic 560 560 0 0.0
.got 57392 57392 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 512428 512204 -224 -0.0
.text 8663652 8660932 -2720 -0.0
door-lock-app debug (read only) 2106209 2106209 0 0.0
(read/write) 119344 119344 0 0.0
.bss 47936 47936 0 0.0
.data 1472 1472 0 0.0
.data.rel.ro 64392 64392 0 0.0
.dynamic 592 592 0 0.0
.got 4264 4264 0 0.0
.init 27 27 0 0.0
.init_array 680 680 0 0.0
.rodata 186665 186665 0 0.0
.text 1763938 1763938 0 0.0
lighting-app debug+rpc (read only) 2311017 2311017 0 0.0
(read/write) 127664 127664 0 0.0
.bss 50144 50144 0 0.0
.data 1952 1952 0 0.0
.data.rel.ro 69864 69864 0 0.0
.dynamic 608 608 0 0.0
.got 4312 4312 0 0.0
.init 27 27 0 0.0
.init_array 776 776 0 0.0
.rodata 182601 182601 0 0.0
.text 1962674 1962674 0 0.0
ota-provider-app debug (read only) 2043393 2043393 0 0.0
(read/write) 114784 114784 0 0.0
.bss 47840 47840 0 0.0
.data 1608 1608 0 0.0
.data.rel.ro 59576 59576 0 0.0
.dynamic 608 608 0 0.0
.got 4464 4464 0 0.0
.init 27 27 0 0.0
.init_array 632 632 0 0.0
.rodata 172451 172451 0 0.0
.text 1714850 1714850 0 0.0
ota-requestor-app debug (read only) 2073801 2073801 0 0.0
(read/write) 118104 118104 0 0.0
.bss 48800 48800 0 0.0
.data 1864 1864 0 0.0
.data.rel.ro 61832 61832 0 0.0
.dynamic 592 592 0 0.0
.got 4304 4304 0 0.0
.init 27 27 0 0.0
.init_array 656 656 0 0.0
.rodata 169356 169356 0 0.0
.text 1746482 1746482 0 0.0
shell debug (read only) 2522177 2522177 0 0.0
(read/write) 149680 149680 0 0.0
.bss 67368 67368 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 75336 75336 0 0.0
.dynamic 592 592 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 214642 214642 0 0.0
.text 2146466 2146466 0 0.0
thermostat-no-ble arm64 (read only) 2351724 2351724 0 0.0
(read/write) 150833 150833 0 0.0
.bss 63025 63025 0 0.0
.data 1424 1424 0 0.0
.data.rel.ro 78600 78600 0 0.0
.dynamic 560 560 0 0.0
.got 4768 4768 0 0.0
.init 24 24 0 0.0
.init_array 368 368 0 0.0
.rodata 144652 144652 0 0.0
.text 1978592 1978592 0 0.0
tv-app debug (read only) 2797409 2794545 -2864 -0.1
(read/write) 251576 250520 -1056 -0.4
.bss 165032 163976 -1056 -0.6
.data 4448 4448 0 0.0
.data.rel.ro 75888 75888 0 0.0
.dynamic 592 592 0 0.0
.got 4688 4688 0 0.0
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 213451 213227 -224 -0.1
.text 2402754 2400114 -2640 -0.1
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2367996 2367996 0 0.0
.bss 185076 185076 0 0.0
.data 5840 5840 0 0.0
.text 1330596 1330596 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1155235 1155235 0 0.0
bss 135304 135304 0 0.0
rodata 146716 146716 0 0.0
text 794500 794500 0 0.0
p6 all-clusters-app default (read/write) 2514152 2514152 0 0.0
.bss 118480 118480 0 0.0
.data 2768 2768 0 0.0
.text 1472416 1472416 0 0.0
light-app default (read/write) 2414840 2414840 0 0.0
.bss 111976 111976 0 0.0
.data 2576 2576 0 0.0
.text 1373104 1373104 0 0.0
lock-app default (read/write) 2378408 2378408 0 0.0
.bss 111720 111720 0 0.0
.data 2536 2536 0 0.0
.text 1336672 1336672 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 800600 800600 0 0.0
bss 69828 69828 0 0.0
noinit 40416 40416 0 0.0
text 569474 569474 0 0.0

@bzbarsky-apple bzbarsky-apple merged commit 97b144a into project-chip:master Apr 11, 2022
@bzbarsky-apple bzbarsky-apple deleted the clean-up-per-controller-storage branch April 11, 2022 22:58
andrei-menzopol pushed a commit to andrei-menzopol/connectedhomeip that referenced this pull request Apr 14, 2022
@bzbarsky-apple @andrei-menzopol
Remove unused per-controller storage delegate (project-chip#17258)
6934682 
* Remove unused DoesDevicePairingExist function.

* Remove write-only mPairedDevicesUpdated field

* Remove write-only mPairedDevices from DeviceController.

The comment about initializing the commissionee device pool was out
of date; the code being removed does not touch that pool.

* Remove use of no-longer-existing storage keys from disabled chip-tool code.

* Remove unused storage delegate from ControllerDeviceInitParams.

* Remove write-only storage delegate field from ControllerInitParams.

* Remove write-only storage delegate field from Controller::SetupParams.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tcarmelveilleux tcarmelveilleux tcarmelveilleux approved these changes

@msandstedt msandstedt msandstedt approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

Assignees
No one assigned
Labels
controller darwin examples lib review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bzbarsky-apple @tcarmelveilleux @msandstedt