Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use docker image 0.5.64 #17320

Merged
merged 2 commits into from
Apr 19, 2022
Merged

use docker image 0.5.64 #17320

merged 2 commits into from
Apr 19, 2022

Conversation

pankore
Copy link
Contributor

@pankore pankore commented Apr 13, 2022

Problem

Move forward to the latest docker images.

Change overview

Change all images to 0.5.64

Testing

CI will validate this

@pankore pankore mentioned this pull request Apr 13, 2022
Merged
@github-actions
Copy link

github-actions bot commented Apr 13, 2022 •
edited
Loading

PR #17320: Size comparison from faabdf9 to c3059e7

Full report (31 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section faabdf9 c3059e7 change % change
cc13x2_26x2 lock-ftd LP_CC2652R7 (read only) 640211 640211 0 0.0
(read/write) 151212 151212 0 0.0
.bss 74144 74144 0 0.0
.data 3212 3212 0 0.0
.rodata 80163 80163 0 0.0
.text 559556 559556 0 0.0
lock-mtd LP_CC2652R7 (read only) 588947 588947 0 0.0
(read/write) 146932 146932 0 0.0
.bss 69864 69864 0 0.0
.data 3212 3212 0 0.0
.rodata 80043 80043 0 0.0
.text 508412 508412 0 0.0
pump-app LP_CC2652R7 (read only) 648287 648287 0 0.0
(read/write) 152508 152508 0 0.0
.bss 74640 74640 0 0.0
.data 3244 3244 0 0.0
.rodata 75351 75351 0 0.0
.text 572448 572448 0 0.0
pump-controller-app LP_CC2652R7 (read only) 642267 642267 0 0.0
(read/write) 152176 152176 0 0.0
.bss 74344 74344 0 0.0
.data 3208 3208 0 0.0
.rodata 78987 78987 0 0.0
.text 562792 562792 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 618818 618818 0 0.0
.app_xip_area 525528 525528 0 0.0
.bss 75956 75956 0 0.0
.data 684 684 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 576414 576414 0 0.0
.app_xip_area 484660 484660 0 0.0
.bss 74452 74452 0 0.0
.data 648 648 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 564938 564938 0 0.0
.app_xip_area 463556 463556 0 0.0
.bss 83784 83784 0 0.0
.data 564 564 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 907300 907300 0 0.0
(read/write) 133080 133080 0 0.0
.bss 131040 131040 0 0.0
.data 2040 2040 0 0.0
.text 907292 907292 0 0.0
BRD4161A+rpc (read only) 941668 941668 0 0.0
(read/write) 149764 149764 0 0.0
.bss 147520 147520 0 0.0
.data 2244 2244 0 0.0
.text 941660 941660 0 0.0
window-app BRD4161A (read only) 844292 844292 0 0.0
(read/write) 131148 131148 0 0.0
.bss 129200 129200 0 0.0
.data 1948 1948 0 0.0
.text 844284 844284 0 0.0
esp32 all-clusters-app c3devkit (read only) 979702 979702 0 0.0
(read/write) 1397514 1397514 0 0.0
.dram0.bss 62624 62624 0 0.0
.dram0.data 14420 14420 0 0.0
.flash.rodata 201552 201552 0 0.0
.flash.text 979702 979702 0 0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1035283 1035283 0 0.0
(read/write) 465252 465252 0 0.0
.dram0.bss 68144 68144 0 0.0
.dram0.data 34152 34152 0 0.0
.flash.rodata 231120 231120 0 0.0
.flash.text 1029899 1029899 0 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 687036 687036 0 0.0
.bss 78128 78128 0 0.0
.data 2036 2036 0 0.0
.text 601072 601072 0 0.0
lock k32w061+release (read/write) 691652 691652 0 0.0
.bss 78704 78704 0 0.0
.data 1996 1996 0 0.0
.text 605152 605152 0 0.0
linux all-clusters-app debug (read only) 2696513 2696513 0 0.0
(read/write) 149120 149120 0 0.0
.bss 60192 60192 0 0.0
.data 1888 1888 0 0.0
.data.rel.ro 80984 80984 0 0.0
.dynamic 608 608 0 0.0
.got 4456 4456 0 0.0
.init 27 27 0 0.0
.init_array 984 984 0 0.0
.rodata 232421 232421 0 0.0
.text 2290098 2290098 0 0.0
bridge-app debug+rpc (read only) 1836109 1836109 0 0.0
(read/write) 91760 91760 0 0.0
.bss 44480 44480 0 0.0
.data 2912 2912 0 0.0
.data.rel.ro 39280 39280 0 0.0
.dynamic 592 592 0 0.0
.got 3936 3936 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 148473 148473 0 0.0
.text 1569205 1569205 0 0.0
chip-tool debug (read only) 10676677 10676677 0 0.0
(read/write) 371832 371832 0 0.0
.bss 22752 22752 0 0.0
.data 1104 1104 0 0.0
.data.rel.ro 341728 341728 0 0.0
.dynamic 624 624 0 0.0
.got 4936 4936 0 0.0
.init 27 27 0 0.0
.init_array 656 656 0 0.0
.rodata 538005 538005 0 0.0
.text 9309365 9309365 0 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 10277348 10277348 0 0.0
(read/write) 492209 492209 0 0.0
.bss 41025 41025 0 0.0
.data 1168 1168 0 0.0
.data.rel.ro 388816 388816 0 0.0
.dynamic 560 560 0 0.0
.got 57392 57392 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 512244 512244 0 0.0
.text 8661844 8661844 0 0.0
door-lock-app debug (read only) 2107489 2107489 0 0.0
(read/write) 119504 119504 0 0.0
.bss 48064 48064 0 0.0
.data 1472 1472 0 0.0
.data.rel.ro 64408 64408 0 0.0
.dynamic 592 592 0 0.0
.got 4264 4264 0 0.0
.init 27 27 0 0.0
.init_array 680 680 0 0.0
.rodata 186697 186697 0 0.0
.text 1765090 1765090 0 0.0
lighting-app debug+rpc (read only) 2312329 2312329 0 0.0
(read/write) 127824 127824 0 0.0
.bss 50272 50272 0 0.0
.data 1952 1952 0 0.0
.data.rel.ro 69896 69896 0 0.0
.dynamic 608 608 0 0.0
.got 4312 4312 0 0.0
.init 27 27 0 0.0
.init_array 776 776 0 0.0
.rodata 182665 182665 0 0.0
.text 1963826 1963826 0 0.0
ota-provider-app debug (read only) 2044673 2044673 0 0.0
(read/write) 114944 114944 0 0.0
.bss 47968 47968 0 0.0
.data 1608 1608 0 0.0
.data.rel.ro 59624 59624 0 0.0
.dynamic 608 608 0 0.0
.got 4464 4464 0 0.0
.init 27 27 0 0.0
.init_array 632 632 0 0.0
.rodata 172483 172483 0 0.0
.text 1716002 1716002 0 0.0
ota-requestor-app debug (read only) 2075049 2075049 0 0.0
(read/write) 118296 118296 0 0.0
.bss 48960 48960 0 0.0
.data 1864 1864 0 0.0
.data.rel.ro 61864 61864 0 0.0
.dynamic 592 592 0 0.0
.got 4304 4304 0 0.0
.init 27 27 0 0.0
.init_array 656 656 0 0.0
.rodata 169356 169356 0 0.0
.text 1747634 1747634 0 0.0
shell debug (read only) 2524353 2524353 0 0.0
(read/write) 149968 149968 0 0.0
.bss 67624 67624 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 75368 75368 0 0.0
.dynamic 592 592 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 214706 214706 0 0.0
.text 2148482 2148482 0 0.0
thermostat-no-ble arm64 (read only) 2352444 2352444 0 0.0
(read/write) 150993 150993 0 0.0
.bss 63153 63153 0 0.0
.data 1424 1424 0 0.0
.data.rel.ro 78632 78632 0 0.0
.dynamic 560 560 0 0.0
.got 4768 4768 0 0.0
.init 24 24 0 0.0
.init_array 368 368 0 0.0
.rodata 144540 144540 0 0.0
.text 1979328 1979328 0 0.0
tv-app debug (read only) 2795825 2795825 0 0.0
(read/write) 250688 250688 0 0.0
.bss 164112 164112 0 0.0
.data 4448 4448 0 0.0
.data.rel.ro 75912 75912 0 0.0
.dynamic 592 592 0 0.0
.got 4688 4688 0 0.0
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 213259 213259 0 0.0
.text 2401266 2401266 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2368260 2368260 0 0.0
.bss 185236 185236 0 0.0
.data 5840 5840 0 0.0
.text 1330860 1330860 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1156151 1156151 0 0.0
bss 135464 135464 0 0.0
rodata 146768 146768 0 0.0
text 795236 795236 0 0.0
p6 all-clusters-app default (read/write) 2514704 2514704 0 0.0
.bss 118640 118640 0 0.0
.data 2768 2768 0 0.0
.text 1472968 1472968 0 0.0
light-app default (read/write) 2415176 2415176 0 0.0
.bss 112136 112136 0 0.0
.data 2576 2576 0 0.0
.text 1373440 1373440 0 0.0
lock-app default (read/write) 2378744 2378744 0 0.0
.bss 111880 111880 0 0.0
.data 2536 2536 0 0.0
.text 1337008 1337008 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 801264 801264 0 0.0
bss 69988 69988 0 0.0
noinit 40416 40416 0 0.0
text 569958 569958 0 0.0

@andy31415
Copy link
Contributor

/rebase

@andy31415
Copy link
Contributor

Amebad seems to be failing:

2022-04-13 12:37:25 INFO    ../../../config/ameba/third_party/connectedhomeip/src/platform/Ameba/AmebaConfig.cpp:92:57: error: cannot convert 'uint32_t*' {aka 'long unsigned int*'} to 'uint8_t*' {aka 'unsigned char*'}
2022-04-13 12:37:25 INFO       92 |     success = getPref_bool_new(key.Namespace, key.Name, &intVal);
2022-04-13 12:37:25 INFO          |                                                         ^~~~~~~
2022-04-13 12:37:25 INFO          |                                                         |
2022-04-13 12:37:25 INFO          |                                                         uint32_t* {aka long unsigned int*}

@pankore
Copy link
Contributor Author

pankore commented Apr 14, 2022

Amebad seems to be failing:

2022-04-13 12:37:25 INFO    ../../../config/ameba/third_party/connectedhomeip/src/platform/Ameba/AmebaConfig.cpp:92:57: error: cannot convert 'uint32_t*' {aka 'long unsigned int*'} to 'uint8_t*' {aka 'unsigned char*'}
2022-04-13 12:37:25 INFO       92 |     success = getPref_bool_new(key.Namespace, key.Name, &intVal);
2022-04-13 12:37:25 INFO          |                                                         ^~~~~~~
2022-04-13 12:37:25 INFO          |                                                         |
2022-04-13 12:37:25 INFO          |                                                         uint32_t* {aka long unsigned int*}

Hi @andy31415 , the error related change was raised on PR #17047 actually, shall we move the change to this PR to let the check pass? As without this PR, the PR #17047 could not pass as well. Thanks

@andy31415
Copy link
Contributor

Amebad seems to be failing:

2022-04-13 12:37:25 INFO    ../../../config/ameba/third_party/connectedhomeip/src/platform/Ameba/AmebaConfig.cpp:92:57: error: cannot convert 'uint32_t*' {aka 'long unsigned int*'} to 'uint8_t*' {aka 'unsigned char*'}
2022-04-13 12:37:25 INFO       92 |     success = getPref_bool_new(key.Namespace, key.Name, &intVal);
2022-04-13 12:37:25 INFO          |                                                         ^~~~~~~
2022-04-13 12:37:25 INFO          |                                                         |
2022-04-13 12:37:25 INFO          |                                                         uint32_t* {aka long unsigned int*}

Hi @andy31415 , the error related change was raised on PR #17047 actually, shall we move the change to this PR to let the check pass? As without this PR, the PR #17047 could not pass as well. Thanks

If two changes are required together to pass CI, then please place them together. We cannot merge anything that fails CI.

@github-actions
Copy link

github-actions bot commented Apr 18, 2022 •
edited
Loading

PR #17320: Size comparison from 20e1a4a to e5040e9

Full report (23 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 20e1a4a e5040e9 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 684415 684415 0 0.0
(read/write) 168752 168752 0 0.0
.bss 76152 76152 0 0.0
.data 3380 3380 0 0.0
.rodata 103367 103367 0 0.0
.text 580568 580568 0 0.0
lock-ftd LP_CC2652R7 (read only) 677311 677311 0 0.0
(read/write) 166800 166800 0 0.0
.bss 74152 74152 0 0.0
.data 3212 3212 0 0.0
.rodata 98847 98847 0 0.0
.text 577980 577980 0 0.0
lock-mtd LP_CC2652R7 (read only) 626055 626055 0 0.0
(read/write) 146940 146940 0 0.0
.bss 69872 69872 0 0.0
.data 3212 3212 0 0.0
.rodata 98727 98727 0 0.0
.text 526836 526836 0 0.0
pump-app LP_CC2652R7 (read only) 649455 649455 0 0.0
(read/write) 152476 152476 0 0.0
.bss 74608 74608 0 0.0
.data 3244 3244 0 0.0
.rodata 75671 75671 0 0.0
.text 573296 573296 0 0.0
pump-controller-app LP_CC2652R7 (read only) 642791 642791 0 0.0
(read/write) 152144 152144 0 0.0
.bss 74312 74312 0 0.0
.data 3208 3208 0 0.0
.rodata 79007 79007 0 0.0
.text 563296 563296 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 619110 619110 0 0.0
.app_xip_area 525868 525868 0 0.0
.bss 75908 75908 0 0.0
.data 684 684 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 613362 613362 0 0.0
.app_xip_area 521624 521624 0 0.0
.bss 74436 74436 0 0.0
.data 648 648 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 566022 566022 0 0.0
.app_xip_area 464688 464688 0 0.0
.bss 83736 83736 0 0.0
.data 564 564 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 908852 908852 0 0.0
(read/write) 133112 133112 0 0.0
.bss 131072 131072 0 0.0
.data 2040 2040 0 0.0
.text 908844 908844 0 0.0
BRD4161A+rpc (read only) 943228 943228 0 0.0
(read/write) 149796 149796 0 0.0
.bss 147552 147552 0 0.0
.data 2244 2244 0 0.0
.text 943220 943220 0 0.0
window-app BRD4161A (read only) 845292 845292 0 0.0
(read/write) 131116 131116 0 0.0
.bss 129168 129168 0 0.0
.data 1948 1948 0 0.0
.text 845284 845284 0 0.0
esp32 all-clusters-app c3devkit (read only) 980476 980476 0 0.0
(read/write) 1397826 1397826 0 0.0
.dram0.bss 62600 62600 0 0.0
.dram0.data 14412 14412 0 0.0
.flash.rodata 201896 201896 0 0.0
.flash.text 980476 980476 0 0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1035975 1035975 0 0.0
(read/write) 465552 465552 0 0.0
.dram0.bss 68112 68112 0 0.0
.dram0.data 34152 34152 0 0.0
.flash.rodata 231452 231452 0 0.0
.flash.text 1030591 1030591 0 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 684684 684684 0 0.0
.bss 77912 77912 0 0.0
.data 1992 1992 0 0.0
.text 598980 598980 0 0.0
lock k32w061+release (read/write) 725540 725540 0 0.0
.bss 78520 78520 0 0.0
.data 1952 1952 0 0.0
.text 639268 639268 0 0.0
linux chip-tool-no-interactive-ipv6only arm64 (read only) 10388564 10388564 0 0.0
(read/write) 493489 493489 0 0.0
.bss 40865 40865 0 0.0
.data 1184 1184 0 0.0
.data.rel.ro 390224 390224 0 0.0
.dynamic 560 560 0 0.0
.got 57408 57408 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 514340 514340 0 0.0
.text 8767108 8767108 0 0.0
thermostat-no-ble arm64 (read only) 2359028 2359028 0 0.0
(read/write) 151137 151137 0 0.0
.bss 62945 62945 0 0.0
.data 1440 1440 0 0.0
.data.rel.ro 78984 78984 0 0.0
.dynamic 560 560 0 0.0
.got 4752 4752 0 0.0
.init 24 24 0 0.0
.init_array 368 368 0 0.0
.rodata 145300 145300 0 0.0
.text 1984736 1984736 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2410124 2410124 0 0.0
.bss 185228 185228 0 0.0
.data 5840 5840 0 0.0
.text 1372724 1372724 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1164339 1164339 0 0.0
bss 136504 136504 0 0.0
rodata 147524 147524 0 0.0
text 801660 801660 0 0.0
p6 all-clusters-app default (read/write) 2516976 2516976 0 0.0
.bss 118624 118624 0 0.0
.data 2768 2768 0 0.0
.text 1475240 1475240 0 0.0
light-app default (read/write) 2416904 2416904 0 0.0
.bss 112104 112104 0 0.0
.data 2576 2576 0 0.0
.text 1375168 1375168 0 0.0
lock-app default (read/write) 2420368 2420368 0 0.0
.bss 111880 111880 0 0.0
.data 2536 2536 0 0.0
.text 1378632 1378632 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 801956 801956 0 0.0
bss 69952 69952 0 0.0
noinit 40416 40416 0 0.0
text 570550 570550 0 0.0

@pankore
Copy link
Contributor Author

pankore commented Apr 18, 2022 •
edited
Loading

Amebad seems to be failing:

2022-04-13 12:37:25 INFO    ../../../config/ameba/third_party/connectedhomeip/src/platform/Ameba/AmebaConfig.cpp:92:57: error: cannot convert 'uint32_t*' {aka 'long unsigned int*'} to 'uint8_t*' {aka 'unsigned char*'}
2022-04-13 12:37:25 INFO       92 |     success = getPref_bool_new(key.Namespace, key.Name, &intVal);
2022-04-13 12:37:25 INFO          |                                                         ^~~~~~~
2022-04-13 12:37:25 INFO          |                                                         |
2022-04-13 12:37:25 INFO          |                                                         uint32_t* {aka long unsigned int*}

Hi @andy31415 , the error related change was raised on PR #17047 actually, shall we move the change to this PR to let the check pass? As without this PR, the PR #17047 could not pass as well. Thanks

If two changes are required together to pass CI, then please place them together. We cannot merge anything that fails CI.

This issue has been fixed by moving the error causing changes from #17047 to this PR.

@pankore pankore requested a review from andy31415 April 18, 2022 13:55
@pankore
Copy link
Contributor Author

pankore commented Apr 19, 2022

Hi @andy31415,
The blocking error has been fixed and all test cases are passed now, please help to merge the PR.
Thanks!

@andy31415 andy31415 merged commit 6a1d09f into project-chip:master Apr 19, 2022
@pankore pankore deleted the docker_0.5.64 branch May 11, 2022 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy31415 andy31415 andy31415 approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@hawk248 hawk248 Awaiting requested review from hawk248

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@msandstedt msandstedt Awaiting requested review from msandstedt

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
fast track github integrations platform review - pending vscode workflows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pankore @andy31415