Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of the concept of client attributes. #17875

Merged
merged 1 commit into from
Apr 30, 2022
Merged

Get rid of the concept of client attributes. #17875

merged 1 commit into from
Apr 30, 2022

Conversation

bzbarsky-apple
Copy link
Contributor

They don't exist in Matter.

We still have some places using *ServerAttribute instead of just *Attribute; that
will be sorted out in a separate PR.

Problem

Extra complexity to deal with potential client attributes.

Change overview

Remove the complexity.

Testing

Should be tested by existing tests. I checked that some apps compile locally.

@github-actions
Copy link

github-actions bot commented Apr 29, 2022 •
edited
Loading

PR #17875: Size comparison from d2e6b99 to 4f9d4e9

Increases (4 builds for cc13x2_26x2)
platform target config section d2e6b99 4f9d4e9 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 164268 164428 160 0.1
lock-ftd LP_CC2652R7 (read/write) 154756 154836 80 0.1
pump-app LP_CC2652R7 (read/write) 183192 183304 112 0.1
pump-controller-app LP_CC2652R7 (read/write) 190032 190096 64 0.0
Decreases (14 builds for cc13x2_26x2, cyw30739, linux, p6, telink)
platform target config section d2e6b99 4f9d4e9 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 687979 687819 -160 -0.0
.text 585992 585832 -160 -0.0
lock-ftd LP_CC2652R7 (read only) 688795 688715 -80 -0.0
.text 585140 585060 -80 -0.0
lock-mtd LP_CC2652R7 (read only) 637539 637459 -80 -0.0
.text 533996 533916 -80 -0.0
pump-app LP_CC2652R7 (read only) 661559 661447 -112 -0.0
.text 580728 580616 -112 -0.0
pump-controller-app LP_CC2652R7 (read only) 654511 654447 -64 -0.0
.text 570648 570584 -64 -0.0
cyw30739 light cyw930739m2evb_01 (read/write) 626774 626670 -104 -0.0
.app_xip_area 529324 529220 -104 -0.0
lock cyw930739m2evb_01 (read/write) 621374 621294 -80 -0.0
.app_xip_area 525396 525316 -80 -0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 574482 574410 -72 -0.0
.app_xip_area 468860 468788 -72 -0.0
linux chip-tool-no-interactive-ipv6only arm64 (read only) 8692644 8692548 -96 -0.0
.text 6865444 6865348 -96 -0.0
thermostat-no-ble arm64 (read only) 2366924 2362812 -4112 -0.2
.rodata 145980 145740 -240 -0.2
.text 1991888 1988016 -3872 -0.2
p6 all-clusters-app default (read/write) 2526824 2526680 -144 -0.0
.text 1485088 1484944 -144 -0.0
light-app default (read/write) 2418752 2418624 -128 -0.0
.text 1377016 1376888 -128 -0.0
lock-app default (read/write) 2422832 2422736 -96 -0.0
.text 1381096 1381000 -96 -0.0
telink lighting-app tlsr9518adk80d (read/write) 807568 807464 -104 -0.0
text 571306 571200 -106 -0.0
Full report (14 builds for cc13x2_26x2, cyw30739, linux, p6, telink)
platform target config section d2e6b99 4f9d4e9 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 687979 687819 -160 -0.0
(read/write) 164268 164428 160 0.1
.bss 75228 75228 0 0.0
.data 3396 3396 0 0.0
.rodata 101507 101507 0 0.0
.text 585992 585832 -160 -0.0
lock-ftd LP_CC2652R7 (read only) 688795 688715 -80 -0.0
(read/write) 154756 154836 80 0.1
.bss 73588 73588 0 0.0
.data 3220 3220 0 0.0
.rodata 103171 103171 0 0.0
.text 585140 585060 -80 -0.0
lock-mtd LP_CC2652R7 (read only) 637539 637459 -80 -0.0
(read/write) 146388 146388 0 0.0
.bss 69308 69308 0 0.0
.data 3220 3220 0 0.0
.rodata 103051 103051 0 0.0
.text 533996 533916 -80 -0.0
pump-app LP_CC2652R7 (read only) 661559 661447 -112 -0.0
(read/write) 183192 183304 112 0.1
.bss 73764 73764 0 0.0
.data 3252 3252 0 0.0
.rodata 80351 80351 0 0.0
.text 580728 580616 -112 -0.0
pump-controller-app LP_CC2652R7 (read only) 654511 654447 -64 -0.0
(read/write) 190032 190096 64 0.0
.bss 73812 73812 0 0.0
.data 3216 3216 0 0.0
.rodata 83383 83383 0 0.0
.text 570648 570584 -64 -0.0
cyw30739 light cyw930739m2evb_01 (read/write) 626774 626670 -104 -0.0
.app_xip_area 529324 529220 -104 -0.0
.bss 80108 80108 0 0.0
.data 692 692 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 621374 621294 -80 -0.0
.app_xip_area 525396 525316 -80 -0.0
.bss 78668 78668 0 0.0
.data 656 656 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 574482 574410 -72 -0.0
.app_xip_area 468860 468788 -72 -0.0
.bss 88016 88016 0 0.0
.data 568 568 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
linux chip-tool-no-interactive-ipv6only arm64 (read only) 8692644 8692548 -96 -0.0
(read/write) 616353 616353 0 0.0
.bss 40897 40897 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 555704 555704 0 0.0
.dynamic 560 560 0 0.0
.got 14744 14744 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 429764 429764 0 0.0
.text 6865444 6865348 -96 -0.0
thermostat-no-ble arm64 (read only) 2366924 2362812 -4112 -0.2
(read/write) 174513 174513 0 0.0
.bss 86257 86257 0 0.0
.data 1488 1488 0 0.0
.data.rel.ro 79000 79000 0 0.0
.dynamic 560 560 0 0.0
.got 4736 4736 0 0.0
.init 24 24 0 0.0
.init_array 368 368 0 0.0
.rodata 145980 145740 -240 -0.2
.text 1991888 1988016 -3872 -0.2
p6 all-clusters-app default (read/write) 2526824 2526680 -144 -0.0
.bss 139248 139248 0 0.0
.data 2784 2784 0 0.0
.text 1485088 1484944 -144 -0.0
light-app default (read/write) 2418752 2418624 -128 -0.0
.bss 132720 132720 0 0.0
.data 2584 2584 0 0.0
.text 1377016 1376888 -128 -0.0
lock-app default (read/write) 2422832 2422736 -96 -0.0
.bss 132520 132520 0 0.0
.data 2544 2544 0 0.0
.text 1381096 1381000 -96 -0.0
telink lighting-app tlsr9518adk80d (read/write) 807568 807464 -104 -0.0
bss 75424 75424 0 0.0
noinit 40416 40416 0 0.0
text 571306 571200 -106 -0.0

@bzbarsky-apple bzbarsky-apple force-pushed the no-more-client-attributes branch from 4f9d4e9 to 6663326 Compare April 29, 2022 01:32
@github-actions
Copy link

github-actions bot commented Apr 29, 2022 •
edited
Loading

PR #17875: Size comparison from d2e6b99 to 6663326

Increases (4 builds for cc13x2_26x2)
platform target config section d2e6b99 6663326 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 164268 164428 160 0.1
lock-ftd LP_CC2652R7 (read/write) 154756 154836 80 0.1
pump-app LP_CC2652R7 (read/write) 183192 183304 112 0.1
pump-controller-app LP_CC2652R7 (read/write) 190032 190096 64 0.0
Decreases (45 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section d2e6b99 6663326 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 687979 687819 -160 -0.0
.text 585992 585832 -160 -0.0
lock-ftd LP_CC2652R7 (read only) 688795 688715 -80 -0.0
.text 585140 585060 -80 -0.0
lock-mtd LP_CC2652R7 (read only) 637539 637459 -80 -0.0
.text 533996 533916 -80 -0.0
pump-app LP_CC2652R7 (read only) 661559 661447 -112 -0.0
.text 580728 580616 -112 -0.0
pump-controller-app LP_CC2652R7 (read only) 654511 654447 -64 -0.0
.text 570648 570584 -64 -0.0
cyw30739 light cyw930739m2evb_01 (read/write) 626774 626670 -104 -0.0
.app_xip_area 529324 529220 -104 -0.0
lock cyw930739m2evb_01 (read/write) 621374 621294 -80 -0.0
.app_xip_area 525396 525316 -80 -0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 574482 574410 -72 -0.0
.app_xip_area 468860 468788 -72 -0.0
efr32 lighting-app BRD4161A (read only) 907744 907664 -80 -0.0
.text 907736 907656 -80 -0.0
BRD4161A+rpc (read only) 942112 942032 -80 -0.0
.text 942104 942024 -80 -0.0
BRD4161A+rs911x (read only) 746060 745964 -96 -0.0
.text 746052 745956 -96 -0.0
lock-app BRD4161A+wf200 (read only) 908716 908588 -128 -0.0
.text 908708 908580 -128 -0.0
window-app BRD4161A (read only) 844952 844888 -64 -0.0
.text 844944 844880 -64 -0.0
esp32 all-clusters-app c3devkit (read only) 999188 999052 -136 -0.0
.flash.text 999188 999052 -136 -0.0
m5stack (read only) 1054603 1054439 -164 -0.0
.flash.text 1049219 1049055 -164 -0.0
k32w light k32w061+release (read/write) 688756 688564 -192 -0.0
.text 599644 599452 -192 -0.0
lock k32w061+release (read/write) 729568 729456 -112 -0.0
.text 640088 639976 -112 -0.0
linux all-clusters-app debug (read only) 2732633 2732249 -384 -0.0
.text 2323554 2323170 -384 -0.0
bridge-app debug+rpc (read only) 1889785 1889497 -288 -0.0
.text 1607410 1607122 -288 -0.0
chip-tool debug (read only) 8850445 8850349 -96 -0.0
.text 7125093 7124997 -96 -0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 8692644 8692548 -96 -0.0
.text 6865444 6865348 -96 -0.0
lighting-app debug+rpc (read only) 2324161 2323921 -240 -0.0
.text 1973794 1973554 -240 -0.0
lock-app debug (read only) 2205193 2205033 -160 -0.0
.text 1853042 1852882 -160 -0.0
ota-provider-app debug (read only) 2058697 2058569 -128 -0.0
.text 1726978 1726850 -128 -0.0
ota-requestor-app debug (read only) 2089817 2089673 -144 -0.0
.text 1760338 1760194 -144 -0.0
shell debug (read only) 2557777 2557393 -384 -0.0
.text 2180002 2179618 -384 -0.0
thermostat-no-ble arm64 (read only) 2366924 2362812 -4112 -0.2
.rodata 145980 145740 -240 -0.2
.text 1991888 1988016 -3872 -0.2
tv-app debug (read only) 2842769 2842529 -240 -0.0
.text 2444034 2443794 -240 -0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2487760 2487632 -128 -0.0
.text 1450332 1450204 -128 -0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2438952 2438888 -64 -0.0
.text 1401524 1401460 -64 -0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2411276 2411148 -128 -0.0
.text 1373876 1373748 -128 -0.0
shell CY8CPROTO_062_4343W+release (read/write) 2365048 2364984 -64 -0.0
.text 1327620 1327556 -64 -0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1179303 1179143 -160 -0.0
text 808520 808356 -164 -0.0
lighting-app nrf52840dk_nrf52840 (read/write) 1155975 1155879 -96 -0.0
text 809808 809704 -104 -0.0
nrf52840dk_nrf52840+rpc (read/write) 1120263 1120151 -112 -0.0
text 782276 782172 -104 -0.0
nrf52840dongle_nrf52840 (read/write) 1063935 1063823 -112 -0.0
text 738296 738192 -104 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 1058366 1058270 -96 -0.0
text 719916 719812 -104 -0.0
lock-app nrf52840dk_nrf52840 (read/write) 1093635 1093555 -80 -0.0
text 745876 745788 -88 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 996350 996270 -80 -0.0
text 656128 656040 -88 -0.0
pump-app nrf52840dk_nrf52840 (read/write) 1076383 1076287 -96 -0.0
text 744700 744596 -104 -0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 1057967 1057903 -64 -0.0
text 730624 730552 -72 -0.0
p6 all-clusters-app default (read/write) 2526824 2526680 -144 -0.0
.text 1485088 1484944 -144 -0.0
light-app default (read/write) 2418752 2418624 -128 -0.0
.text 1377016 1376888 -128 -0.0
lock-app default (read/write) 2422832 2422736 -96 -0.0
.text 1381096 1381000 -96 -0.0
telink lighting-app tlsr9518adk80d (read/write) 807568 807464 -104 -0.0
text 571306 571200 -106 -0.0
Full report (45 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section d2e6b99 6663326 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 687979 687819 -160 -0.0
(read/write) 164268 164428 160 0.1
.bss 75228 75228 0 0.0
.data 3396 3396 0 0.0
.rodata 101507 101507 0 0.0
.text 585992 585832 -160 -0.0
lock-ftd LP_CC2652R7 (read only) 688795 688715 -80 -0.0
(read/write) 154756 154836 80 0.1
.bss 73588 73588 0 0.0
.data 3220 3220 0 0.0
.rodata 103171 103171 0 0.0
.text 585140 585060 -80 -0.0
lock-mtd LP_CC2652R7 (read only) 637539 637459 -80 -0.0
(read/write) 146388 146388 0 0.0
.bss 69308 69308 0 0.0
.data 3220 3220 0 0.0
.rodata 103051 103051 0 0.0
.text 533996 533916 -80 -0.0
pump-app LP_CC2652R7 (read only) 661559 661447 -112 -0.0
(read/write) 183192 183304 112 0.1
.bss 73764 73764 0 0.0
.data 3252 3252 0 0.0
.rodata 80351 80351 0 0.0
.text 580728 580616 -112 -0.0
pump-controller-app LP_CC2652R7 (read only) 654511 654447 -64 -0.0
(read/write) 190032 190096 64 0.0
.bss 73812 73812 0 0.0
.data 3216 3216 0 0.0
.rodata 83383 83383 0 0.0
.text 570648 570584 -64 -0.0
cyw30739 light cyw930739m2evb_01 (read/write) 626774 626670 -104 -0.0
.app_xip_area 529324 529220 -104 -0.0
.bss 80108 80108 0 0.0
.data 692 692 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 621374 621294 -80 -0.0
.app_xip_area 525396 525316 -80 -0.0
.bss 78668 78668 0 0.0
.data 656 656 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 574482 574410 -72 -0.0
.app_xip_area 468860 468788 -72 -0.0
.bss 88016 88016 0 0.0
.data 568 568 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 907744 907664 -80 -0.0
(read/write) 135112 135112 0 0.0
.bss 133064 133064 0 0.0
.data 2044 2044 0 0.0
.text 907736 907656 -80 -0.0
BRD4161A+rpc (read only) 942112 942032 -80 -0.0
(read/write) 151792 151792 0 0.0
.bss 149544 149544 0 0.0
.data 2248 2248 0 0.0
.text 942104 942024 -80 -0.0
BRD4161A+rs911x (read only) 746060 745964 -96 -0.0
(read/write) 129344 129344 0 0.0
.bss 127372 127372 0 0.0
.data 1972 1972 0 0.0
.text 746052 745956 -96 -0.0
lock-app BRD4161A+wf200 (read only) 908716 908588 -128 -0.0
(read/write) 126300 126300 0 0.0
.bss 124380 124380 0 0.0
.data 1920 1920 0 0.0
.text 908708 908580 -128 -0.0
window-app BRD4161A (read only) 844952 844888 -64 -0.0
(read/write) 133200 133200 0 0.0
.bss 131240 131240 0 0.0
.data 1956 1956 0 0.0
.text 844944 844880 -64 -0.0
esp32 all-clusters-app c3devkit (read only) 999188 999052 -136 -0.0
(read/write) 1473778 1473778 0 0.0
.dram0.bss 68360 68360 0 0.0
.dram0.data 14428 14428 0 0.0
.flash.rodata 206536 206536 0 0.0
.flash.text 999188 999052 -136 -0.0
.iram0.text 62020 62020 0 0.0
m5stack (read only) 1054603 1054439 -164 -0.0
(read/write) 476200 476200 0 0.0
.dram0.bss 73880 73880 0 0.0
.dram0.data 34168 34168 0 0.0
.flash.rodata 236316 236316 0 0.0
.flash.text 1049219 1049055 -164 -0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 688756 688564 -192 -0.0
.bss 81312 81312 0 0.0
.data 2000 2000 0 0.0
.text 599644 599452 -192 -0.0
lock k32w061+release (read/write) 729568 729456 -112 -0.0
.bss 81720 81720 0 0.0
.data 1960 1960 0 0.0
.text 640088 639976 -112 -0.0
linux all-clusters-app debug (read only) 2732633 2732249 -384 -0.0
(read/write) 172976 172976 0 0.0
.bss 83328 83328 0 0.0
.data 1984 1984 0 0.0
.data.rel.ro 81560 81560 0 0.0
.dynamic 608 608 0 0.0
.got 4464 4464 0 0.0
.init 27 27 0 0.0
.init_array 1000 1000 0 0.0
.rodata 234501 234501 0 0.0
.text 2323554 2323170 -384 -0.0
bridge-app debug+rpc (read only) 1889785 1889497 -288 -0.0
(read/write) 120336 120336 0 0.0
.bss 71328 71328 0 0.0
.data 3424 3424 0 0.0
.data.rel.ro 40248 40248 0 0.0
.dynamic 592 592 0 0.0
.got 4032 4032 0 0.0
.init 27 27 0 0.0
.init_array 680 680 0 0.0
.rodata 160001 160001 0 0.0
.text 1607410 1607122 -288 -0.0
chip-tool debug (read only) 8850445 8850349 -96 -0.0
(read/write) 550544 550544 0 0.0
.bss 22592 22592 0 0.0
.data 1136 1136 0 0.0
.data.rel.ro 520552 520552 0 0.0
.dynamic 624 624 0 0.0
.got 4952 4952 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 462517 462517 0 0.0
.text 7125093 7124997 -96 -0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 8692644 8692548 -96 -0.0
(read/write) 616353 616353 0 0.0
.bss 40897 40897 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 555704 555704 0 0.0
.dynamic 560 560 0 0.0
.got 14744 14744 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 429764 429764 0 0.0
.text 6865444 6865348 -96 -0.0
lighting-app debug+rpc (read only) 2324161 2323921 -240 -0.0
(read/write) 151288 151288 0 0.0
.bss 73376 73376 0 0.0
.data 1984 1984 0 0.0
.data.rel.ro 70184 70184 0 0.0
.dynamic 608 608 0 0.0
.got 4320 4320 0 0.0
.init 27 27 0 0.0
.init_array 784 784 0 0.0
.rodata 184137 184137 0 0.0
.text 1973794 1973554 -240 -0.0
lock-app debug (read only) 2205193 2205033 -160 -0.0
(read/write) 145640 145640 0 0.0
.bss 71968 71968 0 0.0
.data 1504 1504 0 0.0
.data.rel.ro 66520 66520 0 0.0
.dynamic 592 592 0 0.0
.got 4312 4312 0 0.0
.init 27 27 0 0.0
.init_array 736 736 0 0.0
.rodata 192561 192561 0 0.0
.text 1853042 1852882 -160 -0.0
ota-provider-app debug (read only) 2058697 2058569 -128 -0.0
(read/write) 138920 138920 0 0.0
.bss 71392 71392 0 0.0
.data 1672 1672 0 0.0
.data.rel.ro 60072 60072 0 0.0
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 174619 174619 0 0.0
.text 1726978 1726850 -128 -0.0
ota-requestor-app debug (read only) 2089817 2089673 -144 -0.0
(read/write) 141728 141728 0 0.0
.bss 72032 72032 0 0.0
.data 1928 1928 0 0.0
.data.rel.ro 62136 62136 0 0.0
.dynamic 592 592 0 0.0
.got 4320 4320 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 170892 170892 0 0.0
.text 1760338 1760194 -144 -0.0
shell debug (read only) 2557777 2557393 -384 -0.0
(read/write) 197000 197000 0 0.0
.bss 114056 114056 0 0.0
.data 1360 1360 0 0.0
.data.rel.ro 75856 75856 0 0.0
.dynamic 592 592 0 0.0
.got 4184 4184 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 216274 216274 0 0.0
.text 2180002 2179618 -384 -0.0
thermostat-no-ble arm64 (read only) 2366924 2362812 -4112 -0.2
(read/write) 174513 174513 0 0.0
.bss 86257 86257 0 0.0
.data 1488 1488 0 0.0
.data.rel.ro 79000 79000 0 0.0
.dynamic 560 560 0 0.0
.got 4736 4736 0 0.0
.init 24 24 0 0.0
.init_array 368 368 0 0.0
.rodata 145980 145740 -240 -0.2
.text 1991888 1988016 -3872 -0.2
tv-app debug (read only) 2842769 2842529 -240 -0.0
(read/write) 276568 276568 0 0.0
.bss 189272 189272 0 0.0
.data 4640 4640 0 0.0
.data.rel.ro 76432 76432 0 0.0
.dynamic 592 592 0 0.0
.got 4696 4696 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 216683 216683 0 0.0
.text 2444034 2443794 -240 -0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2487760 2487632 -128 -0.0
.bss 211736 211736 0 0.0
.data 5608 5608 0 0.0
.text 1450332 1450204 -128 -0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2438952 2438888 -64 -0.0
.bss 207044 207044 0 0.0
.data 5872 5872 0 0.0
.text 1401524 1401460 -64 -0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2411276 2411148 -128 -0.0
.bss 205860 205860 0 0.0
.data 5848 5848 0 0.0
.text 1373876 1373748 -128 -0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2365048 2364984 -64 -0.0
.bss 205656 205656 0 0.0
.data 5632 5632 0 0.0
.text 1327620 1327556 -64 -0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1179303 1179143 -160 -0.0
bss 141992 141992 0 0.0
rodata 150104 150104 0 0.0
text 808520 808356 -164 -0.0
lighting-app nrf52840dk_nrf52840 (read/write) 1155975 1155879 -96 -0.0
bss 145708 145708 0 0.0
rodata 121816 121816 0 0.0
text 809808 809704 -104 -0.0
nrf52840dk_nrf52840+rpc (read/write) 1120263 1120151 -112 -0.0
bss 145944 145944 0 0.0
rodata 112928 112928 0 0.0
text 782276 782172 -104 -0.0
nrf52840dongle_nrf52840 (read/write) 1063935 1063823 -112 -0.0
bss 152900 152900 0 0.0
rodata 91872 91872 0 0.0
text 738296 738192 -104 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 1058366 1058270 -96 -0.0
bss 141912 141912 0 0.0
rodata 114572 114572 0 0.0
text 719916 719812 -104 -0.0
lock-app nrf52840dk_nrf52840 (read/write) 1093635 1093555 -80 -0.0
bss 135624 135624 0 0.0
rodata 133612 133612 0 0.0
text 745876 745788 -88 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 996350 996270 -80 -0.0
bss 131860 131860 0 0.0
rodata 126412 126412 0 0.0
text 656128 656040 -88 -0.0
pump-app nrf52840dk_nrf52840 (read/write) 1076383 1076287 -96 -0.0
bss 135712 135712 0 0.0
rodata 117328 117328 0 0.0
text 744700 744596 -104 -0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 1057967 1057903 -64 -0.0
bss 135432 135432 0 0.0
rodata 113280 113280 0 0.0
text 730624 730552 -72 -0.0
p6 all-clusters-app default (read/write) 2526824 2526680 -144 -0.0
.bss 139248 139248 0 0.0
.data 2784 2784 0 0.0
.text 1485088 1484944 -144 -0.0
light-app default (read/write) 2418752 2418624 -128 -0.0
.bss 132720 132720 0 0.0
.data 2584 2584 0 0.0
.text 1377016 1376888 -128 -0.0
lock-app default (read/write) 2422832 2422736 -96 -0.0
.bss 132520 132520 0 0.0
.data 2544 2544 0 0.0
.text 1381096 1381000 -96 -0.0
telink lighting-app tlsr9518adk80d (read/write) 807568 807464 -104 -0.0
bss 75424 75424 0 0.0
noinit 40416 40416 0 0.0
text 571306 571200 -106 -0.0

@bzbarsky-apple bzbarsky-apple force-pushed the no-more-client-attributes branch from 6663326 to 3efb2c8 Compare April 29, 2022 07:12
@github-actions
Copy link

github-actions bot commented Apr 29, 2022 •
edited
Loading

PR #17875: Size comparison from 6672d6e to 3efb2c8

Increases (4 builds for cc13x2_26x2)
platform target config section 6672d6e 3efb2c8 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 164268 164428 160 0.1
lock-ftd LP_CC2652R7 (read/write) 154756 154836 80 0.1
pump-app LP_CC2652R7 (read/write) 183192 183304 112 0.1
pump-controller-app LP_CC2652R7 (read/write) 190032 190096 64 0.0
Decreases (45 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 6672d6e 3efb2c8 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 687979 687819 -160 -0.0
.text 585992 585832 -160 -0.0
lock-ftd LP_CC2652R7 (read only) 688795 688715 -80 -0.0
.text 585140 585060 -80 -0.0
lock-mtd LP_CC2652R7 (read only) 637539 637459 -80 -0.0
.text 533996 533916 -80 -0.0
pump-app LP_CC2652R7 (read only) 661559 661447 -112 -0.0
.text 580728 580616 -112 -0.0
pump-controller-app LP_CC2652R7 (read only) 654511 654447 -64 -0.0
.text 570648 570584 -64 -0.0
cyw30739 light cyw930739m2evb_01 (read/write) 626774 626670 -104 -0.0
.app_xip_area 529324 529220 -104 -0.0
lock cyw930739m2evb_01 (read/write) 621374 621294 -80 -0.0
.app_xip_area 525396 525316 -80 -0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 574482 574410 -72 -0.0
.app_xip_area 468860 468788 -72 -0.0
efr32 lighting-app BRD4161A (read only) 907744 907664 -80 -0.0
.text 907736 907656 -80 -0.0
BRD4161A+rpc (read only) 942112 942032 -80 -0.0
.text 942104 942024 -80 -0.0
BRD4161A+rs911x (read only) 746060 745964 -96 -0.0
.text 746052 745956 -96 -0.0
lock-app BRD4161A+wf200 (read only) 908716 908588 -128 -0.0
.text 908708 908580 -128 -0.0
window-app BRD4161A (read only) 844952 844888 -64 -0.0
.text 844944 844880 -64 -0.0
esp32 all-clusters-app c3devkit (read only) 999188 999052 -136 -0.0
.flash.text 999188 999052 -136 -0.0
m5stack (read only) 1054623 1054459 -164 -0.0
.flash.text 1049239 1049075 -164 -0.0
k32w light k32w061+release (read/write) 688756 688564 -192 -0.0
.text 599644 599452 -192 -0.0
lock k32w061+release (read/write) 729568 729456 -112 -0.0
.text 640088 639976 -112 -0.0
linux all-clusters-app debug (read only) 2732633 2732249 -384 -0.0
.text 2323554 2323170 -384 -0.0
bridge-app debug+rpc (read only) 1889785 1889497 -288 -0.0
.text 1607410 1607122 -288 -0.0
chip-tool debug (read only) 8850245 8850149 -96 -0.0
.text 7125013 7124917 -96 -0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 8692404 8692308 -96 -0.0
.text 6865332 6865236 -96 -0.0
lighting-app debug+rpc (read only) 2324161 2323921 -240 -0.0
.text 1973794 1973554 -240 -0.0
lock-app debug (read only) 2205193 2205033 -160 -0.0
.text 1853042 1852882 -160 -0.0
ota-provider-app debug (read only) 2058697 2058569 -128 -0.0
.text 1726978 1726850 -128 -0.0
ota-requestor-app debug (read only) 2089817 2089673 -144 -0.0
.text 1760338 1760194 -144 -0.0
shell debug (read only) 2557777 2557393 -384 -0.0
.text 2180002 2179618 -384 -0.0
thermostat-no-ble arm64 (read only) 2366924 2362812 -4112 -0.2
.rodata 145980 145740 -240 -0.2
.text 1991888 1988016 -3872 -0.2
tv-app debug (read only) 2842769 2842529 -240 -0.0
.text 2444034 2443794 -240 -0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2487760 2487632 -128 -0.0
.text 1450332 1450204 -128 -0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2438952 2438888 -64 -0.0
.text 1401524 1401460 -64 -0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2411276 2411148 -128 -0.0
.text 1373876 1373748 -128 -0.0
shell CY8CPROTO_062_4343W+release (read/write) 2365048 2364984 -64 -0.0
.text 1327620 1327556 -64 -0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1179303 1179127 -176 -0.0
text 808516 808352 -164 -0.0
lighting-app nrf52840dk_nrf52840 (read/write) 1155975 1155863 -112 -0.0
text 809804 809700 -104 -0.0
nrf52840dk_nrf52840+rpc (read/write) 1120263 1120151 -112 -0.0
text 782272 782168 -104 -0.0
nrf52840dongle_nrf52840 (read/write) 1063919 1063823 -96 -0.0
text 738292 738188 -104 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 1058366 1058254 -112 -0.0
text 719912 719808 -104 -0.0
lock-app nrf52840dk_nrf52840 (read/write) 1093635 1093539 -96 -0.0
text 745872 745784 -88 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 996350 996270 -80 -0.0
text 656124 656036 -88 -0.0
pump-app nrf52840dk_nrf52840 (read/write) 1076383 1076271 -112 -0.0
text 744696 744592 -104 -0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 1057967 1057903 -64 -0.0
text 730620 730548 -72 -0.0
p6 all-clusters-app default (read/write) 2526824 2526680 -144 -0.0
.text 1485088 1484944 -144 -0.0
light-app default (read/write) 2418752 2418624 -128 -0.0
.text 1377016 1376888 -128 -0.0
lock-app default (read/write) 2422832 2422736 -96 -0.0
.text 1381096 1381000 -96 -0.0
telink lighting-app tlsr9518adk80d (read/write) 807560 807456 -104 -0.0
text 571296 571190 -106 -0.0
Full report (45 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 6672d6e 3efb2c8 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 687979 687819 -160 -0.0
(read/write) 164268 164428 160 0.1
.bss 75228 75228 0 0.0
.data 3396 3396 0 0.0
.rodata 101507 101507 0 0.0
.text 585992 585832 -160 -0.0
lock-ftd LP_CC2652R7 (read only) 688795 688715 -80 -0.0
(read/write) 154756 154836 80 0.1
.bss 73588 73588 0 0.0
.data 3220 3220 0 0.0
.rodata 103171 103171 0 0.0
.text 585140 585060 -80 -0.0
lock-mtd LP_CC2652R7 (read only) 637539 637459 -80 -0.0
(read/write) 146388 146388 0 0.0
.bss 69308 69308 0 0.0
.data 3220 3220 0 0.0
.rodata 103051 103051 0 0.0
.text 533996 533916 -80 -0.0
pump-app LP_CC2652R7 (read only) 661559 661447 -112 -0.0
(read/write) 183192 183304 112 0.1
.bss 73764 73764 0 0.0
.data 3252 3252 0 0.0
.rodata 80351 80351 0 0.0
.text 580728 580616 -112 -0.0
pump-controller-app LP_CC2652R7 (read only) 654511 654447 -64 -0.0
(read/write) 190032 190096 64 0.0
.bss 73812 73812 0 0.0
.data 3216 3216 0 0.0
.rodata 83383 83383 0 0.0
.text 570648 570584 -64 -0.0
cyw30739 light cyw930739m2evb_01 (read/write) 626774 626670 -104 -0.0
.app_xip_area 529324 529220 -104 -0.0
.bss 80108 80108 0 0.0
.data 692 692 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 621374 621294 -80 -0.0
.app_xip_area 525396 525316 -80 -0.0
.bss 78668 78668 0 0.0
.data 656 656 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 574482 574410 -72 -0.0
.app_xip_area 468860 468788 -72 -0.0
.bss 88016 88016 0 0.0
.data 568 568 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 907744 907664 -80 -0.0
(read/write) 135112 135112 0 0.0
.bss 133064 133064 0 0.0
.data 2044 2044 0 0.0
.text 907736 907656 -80 -0.0
BRD4161A+rpc (read only) 942112 942032 -80 -0.0
(read/write) 151792 151792 0 0.0
.bss 149544 149544 0 0.0
.data 2248 2248 0 0.0
.text 942104 942024 -80 -0.0
BRD4161A+rs911x (read only) 746060 745964 -96 -0.0
(read/write) 129344 129344 0 0.0
.bss 127372 127372 0 0.0
.data 1972 1972 0 0.0
.text 746052 745956 -96 -0.0
lock-app BRD4161A+wf200 (read only) 908716 908588 -128 -0.0
(read/write) 126300 126300 0 0.0
.bss 124380 124380 0 0.0
.data 1920 1920 0 0.0
.text 908708 908580 -128 -0.0
window-app BRD4161A (read only) 844952 844888 -64 -0.0
(read/write) 133200 133200 0 0.0
.bss 131240 131240 0 0.0
.data 1956 1956 0 0.0
.text 844944 844880 -64 -0.0
esp32 all-clusters-app c3devkit (read only) 999188 999052 -136 -0.0
(read/write) 1473778 1473778 0 0.0
.dram0.bss 68360 68360 0 0.0
.dram0.data 14428 14428 0 0.0
.flash.rodata 206536 206536 0 0.0
.flash.text 999188 999052 -136 -0.0
.iram0.text 62020 62020 0 0.0
m5stack (read only) 1054623 1054459 -164 -0.0
(read/write) 476200 476200 0 0.0
.dram0.bss 73880 73880 0 0.0
.dram0.data 34168 34168 0 0.0
.flash.rodata 236316 236316 0 0.0
.flash.text 1049239 1049075 -164 -0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 688756 688564 -192 -0.0
.bss 81312 81312 0 0.0
.data 2000 2000 0 0.0
.text 599644 599452 -192 -0.0
lock k32w061+release (read/write) 729568 729456 -112 -0.0
.bss 81720 81720 0 0.0
.data 1960 1960 0 0.0
.text 640088 639976 -112 -0.0
linux all-clusters-app debug (read only) 2732633 2732249 -384 -0.0
(read/write) 172976 172976 0 0.0
.bss 83328 83328 0 0.0
.data 1984 1984 0 0.0
.data.rel.ro 81560 81560 0 0.0
.dynamic 608 608 0 0.0
.got 4464 4464 0 0.0
.init 27 27 0 0.0
.init_array 1000 1000 0 0.0
.rodata 234501 234501 0 0.0
.text 2323554 2323170 -384 -0.0
bridge-app debug+rpc (read only) 1889785 1889497 -288 -0.0
(read/write) 120336 120336 0 0.0
.bss 71328 71328 0 0.0
.data 3424 3424 0 0.0
.data.rel.ro 40248 40248 0 0.0
.dynamic 592 592 0 0.0
.got 4032 4032 0 0.0
.init 27 27 0 0.0
.init_array 680 680 0 0.0
.rodata 160001 160001 0 0.0
.text 1607410 1607122 -288 -0.0
chip-tool debug (read only) 8850245 8850149 -96 -0.0
(read/write) 550480 550480 0 0.0
.bss 22592 22592 0 0.0
.data 1136 1136 0 0.0
.data.rel.ro 520504 520504 0 0.0
.dynamic 624 624 0 0.0
.got 4952 4952 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 462517 462517 0 0.0
.text 7125013 7124917 -96 -0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 8692404 8692308 -96 -0.0
(read/write) 616321 616321 0 0.0
.bss 40897 40897 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 555664 555664 0 0.0
.dynamic 560 560 0 0.0
.got 14744 14744 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 429764 429764 0 0.0
.text 6865332 6865236 -96 -0.0
lighting-app debug+rpc (read only) 2324161 2323921 -240 -0.0
(read/write) 151288 151288 0 0.0
.bss 73376 73376 0 0.0
.data 1984 1984 0 0.0
.data.rel.ro 70184 70184 0 0.0
.dynamic 608 608 0 0.0
.got 4320 4320 0 0.0
.init 27 27 0 0.0
.init_array 784 784 0 0.0
.rodata 184137 184137 0 0.0
.text 1973794 1973554 -240 -0.0
lock-app debug (read only) 2205193 2205033 -160 -0.0
(read/write) 145640 145640 0 0.0
.bss 71968 71968 0 0.0
.data 1504 1504 0 0.0
.data.rel.ro 66520 66520 0 0.0
.dynamic 592 592 0 0.0
.got 4312 4312 0 0.0
.init 27 27 0 0.0
.init_array 736 736 0 0.0
.rodata 192561 192561 0 0.0
.text 1853042 1852882 -160 -0.0
ota-provider-app debug (read only) 2058697 2058569 -128 -0.0
(read/write) 138920 138920 0 0.0
.bss 71392 71392 0 0.0
.data 1672 1672 0 0.0
.data.rel.ro 60072 60072 0 0.0
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 174619 174619 0 0.0
.text 1726978 1726850 -128 -0.0
ota-requestor-app debug (read only) 2089817 2089673 -144 -0.0
(read/write) 141728 141728 0 0.0
.bss 72032 72032 0 0.0
.data 1928 1928 0 0.0
.data.rel.ro 62136 62136 0 0.0
.dynamic 592 592 0 0.0
.got 4320 4320 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 170892 170892 0 0.0
.text 1760338 1760194 -144 -0.0
shell debug (read only) 2557777 2557393 -384 -0.0
(read/write) 197000 197000 0 0.0
.bss 114056 114056 0 0.0
.data 1360 1360 0 0.0
.data.rel.ro 75856 75856 0 0.0
.dynamic 592 592 0 0.0
.got 4184 4184 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 216274 216274 0 0.0
.text 2180002 2179618 -384 -0.0
thermostat-no-ble arm64 (read only) 2366924 2362812 -4112 -0.2
(read/write) 174513 174513 0 0.0
.bss 86257 86257 0 0.0
.data 1488 1488 0 0.0
.data.rel.ro 79000 79000 0 0.0
.dynamic 560 560 0 0.0
.got 4736 4736 0 0.0
.init 24 24 0 0.0
.init_array 368 368 0 0.0
.rodata 145980 145740 -240 -0.2
.text 1991888 1988016 -3872 -0.2
tv-app debug (read only) 2842769 2842529 -240 -0.0
(read/write) 276568 276568 0 0.0
.bss 189272 189272 0 0.0
.data 4640 4640 0 0.0
.data.rel.ro 76432 76432 0 0.0
.dynamic 592 592 0 0.0
.got 4696 4696 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 216683 216683 0 0.0
.text 2444034 2443794 -240 -0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2487760 2487632 -128 -0.0
.bss 211736 211736 0 0.0
.data 5608 5608 0 0.0
.text 1450332 1450204 -128 -0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2438952 2438888 -64 -0.0
.bss 207044 207044 0 0.0
.data 5872 5872 0 0.0
.text 1401524 1401460 -64 -0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2411276 2411148 -128 -0.0
.bss 205860 205860 0 0.0
.data 5848 5848 0 0.0
.text 1373876 1373748 -128 -0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2365048 2364984 -64 -0.0
.bss 205656 205656 0 0.0
.data 5632 5632 0 0.0
.text 1327620 1327556 -64 -0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1179303 1179127 -176 -0.0
bss 141992 141992 0 0.0
rodata 150104 150104 0 0.0
text 808516 808352 -164 -0.0
lighting-app nrf52840dk_nrf52840 (read/write) 1155975 1155863 -112 -0.0
bss 145708 145708 0 0.0
rodata 121816 121816 0 0.0
text 809804 809700 -104 -0.0
nrf52840dk_nrf52840+rpc (read/write) 1120263 1120151 -112 -0.0
bss 145944 145944 0 0.0
rodata 112928 112928 0 0.0
text 782272 782168 -104 -0.0
nrf52840dongle_nrf52840 (read/write) 1063919 1063823 -96 -0.0
bss 152900 152900 0 0.0
rodata 91872 91872 0 0.0
text 738292 738188 -104 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 1058366 1058254 -112 -0.0
bss 141912 141912 0 0.0
rodata 114572 114572 0 0.0
text 719912 719808 -104 -0.0
lock-app nrf52840dk_nrf52840 (read/write) 1093635 1093539 -96 -0.0
bss 135624 135624 0 0.0
rodata 133612 133612 0 0.0
text 745872 745784 -88 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 996350 996270 -80 -0.0
bss 131860 131860 0 0.0
rodata 126412 126412 0 0.0
text 656124 656036 -88 -0.0
pump-app nrf52840dk_nrf52840 (read/write) 1076383 1076271 -112 -0.0
bss 135712 135712 0 0.0
rodata 117328 117328 0 0.0
text 744696 744592 -104 -0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 1057967 1057903 -64 -0.0
bss 135432 135432 0 0.0
rodata 113280 113280 0 0.0
text 730620 730548 -72 -0.0
p6 all-clusters-app default (read/write) 2526824 2526680 -144 -0.0
.bss 139248 139248 0 0.0
.data 2784 2784 0 0.0
.text 1485088 1484944 -144 -0.0
light-app default (read/write) 2418752 2418624 -128 -0.0
.bss 132720 132720 0 0.0
.data 2584 2584 0 0.0
.text 1377016 1376888 -128 -0.0
lock-app default (read/write) 2422832 2422736 -96 -0.0
.bss 132520 132520 0 0.0
.data 2544 2544 0 0.0
.text 1381096 1381000 -96 -0.0
telink lighting-app tlsr9518adk80d (read/write) 807560 807456 -104 -0.0
bss 75424 75424 0 0.0
noinit 40416 40416 0 0.0
text 571296 571190 -106 -0.0

@bzbarsky-apple bzbarsky-apple force-pushed the no-more-client-attributes branch 2 times, most recently from 3aaddd9 to 40b7b3b Compare April 29, 2022 16:27
@github-actions
Copy link

github-actions bot commented Apr 29, 2022 •
edited
Loading

PR #17875: Size comparison from 0d3860e to 40b7b3b

Increases (4 builds for cc13x2_26x2)
platform target config section 0d3860e 40b7b3b change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 162960 163120 160 0.1
lock-ftd LP_CC2652R7 (read/write) 154680 154776 96 0.1
pump-app LP_CC2652R7 (read/write) 183172 183284 112 0.1
pump-controller-app LP_CC2652R7 (read/write) 189948 190012 64 0.0
Decreases (45 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 0d3860e 40b7b3b change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 689287 689127 -160 -0.0
.text 586568 586408 -160 -0.0
lock-ftd LP_CC2652R7 (read only) 688871 688775 -96 -0.0
.text 585220 585124 -96 -0.0
lock-mtd LP_CC2652R7 (read only) 637623 637527 -96 -0.0
.text 534084 533988 -96 -0.0
pump-app LP_CC2652R7 (read only) 661579 661467 -112 -0.0
.text 580784 580672 -112 -0.0
pump-controller-app LP_CC2652R7 (read only) 654595 654531 -64 -0.0
.text 570736 570672 -64 -0.0
cyw30739 light cyw930739m2evb_01 (read/write) 626842 626738 -104 -0.0
.app_xip_area 529392 529288 -104 -0.0
lock cyw930739m2evb_01 (read/write) 621466 621370 -96 -0.0
.app_xip_area 525488 525392 -96 -0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 574574 574494 -80 -0.0
.app_xip_area 468952 468872 -80 -0.0
efr32 lighting-app BRD4161A (read only) 907928 907848 -80 -0.0
.text 907920 907840 -80 -0.0
BRD4161A+rpc (read only) 942296 942216 -80 -0.0
.text 942288 942208 -80 -0.0
BRD4161A+rs911x (read only) 746244 746148 -96 -0.0
.text 746236 746140 -96 -0.0
lock-app BRD4161A+wf200 (read only) 908808 908680 -128 -0.0
.text 908800 908672 -128 -0.0
window-app BRD4161A (read only) 845152 845088 -64 -0.0
.text 845144 845080 -64 -0.0
esp32 all-clusters-app c3devkit (read only) 999918 999780 -138 -0.0
.flash.text 999918 999780 -138 -0.0
m5stack (read only) 1055315 1055135 -180 -0.0
.flash.text 1049931 1049751 -180 -0.0
k32w light k32w061+release (read/write) 684720 684528 -192 -0.0
.text 599704 599512 -192 -0.0
lock k32w061+release (read/write) 725564 725436 -128 -0.0
.text 640180 640052 -128 -0.0
linux all-clusters-app debug (read only) 2734457 2734057 -400 -0.0
.text 2325426 2325026 -400 -0.0
bridge-app debug+rpc (read only) 1889753 1889481 -272 -0.0
.text 1607426 1607154 -272 -0.0
chip-tool debug (read only) 8850261 8850133 -128 -0.0
.text 7125077 7124949 -128 -0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 8692484 8692324 -160 -0.0
.text 6865476 6865316 -160 -0.0
lighting-app debug+rpc (read only) 2324129 2323889 -240 -0.0
.text 1973810 1973570 -240 -0.0
lock-app debug (read only) 2205257 2205049 -208 -0.0
.text 1853154 1852946 -208 -0.0
ota-provider-app debug (read only) 2058745 2058585 -160 -0.0
.text 1727074 1726914 -160 -0.0
ota-requestor-app debug (read only) 2089865 2089705 -160 -0.0
.text 1760434 1760274 -160 -0.0
shell debug (read only) 2559681 2559297 -384 -0.0
.text 2181954 2181570 -384 -0.0
thermostat-no-ble arm64 (read only) 2367004 2362828 -4176 -0.2
.rodata 145980 145740 -240 -0.2
.text 1992048 1988112 -3936 -0.2
tv-app debug (read only) 2842281 2842041 -240 -0.0
.text 2443586 2443346 -240 -0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2489168 2488976 -192 -0.0
.text 1451740 1451548 -192 -0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2439072 2438944 -128 -0.0
.text 1401644 1401516 -128 -0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2411340 2411212 -128 -0.0
.text 1373940 1373812 -128 -0.0
shell CY8CPROTO_062_4343W+release (read/write) 2365104 2365040 -64 -0.0
.text 1327676 1327612 -64 -0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1180647 1180487 -160 -0.0
text 809096 808932 -164 -0.0
lighting-app nrf52840dk_nrf52840 (read/write) 1156035 1155939 -96 -0.0
text 809876 809772 -104 -0.0
nrf52840dk_nrf52840+rpc (read/write) 1120323 1120227 -96 -0.0
text 782348 782240 -108 -0.0
nrf52840dongle_nrf52840 (read/write) 1063995 1063883 -112 -0.0
text 738368 738260 -108 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 1058442 1058330 -112 -0.0
text 719992 719884 -108 -0.0
lock-app nrf52840dk_nrf52840 (read/write) 1093727 1093631 -96 -0.0
text 745964 745872 -92 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 996442 996346 -96 -0.0
text 656220 656128 -92 -0.0
pump-app nrf52840dk_nrf52840 (read/write) 1076459 1076347 -112 -0.0
text 744772 744664 -108 -0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 1058059 1057979 -80 -0.0
text 730712 730632 -80 -0.0
p6 all-clusters-app default (read/write) 2528352 2528208 -144 -0.0
.text 1486616 1486472 -144 -0.0
light-app default (read/write) 2418936 2418808 -128 -0.0
.text 1377200 1377072 -128 -0.0
lock-app default (read/write) 2423048 2422936 -112 -0.0
.text 1381312 1381200 -112 -0.0
telink lighting-app tlsr9518adk80d (read/write) 807660 807548 -112 -0.0
text 571400 571292 -108 -0.0
Full report (45 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 0d3860e 40b7b3b change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 689287 689127 -160 -0.0
(read/write) 162960 163120 160 0.1
.bss 75228 75228 0 0.0
.data 3396 3396 0 0.0
.rodata 102239 102239 0 0.0
.text 586568 586408 -160 -0.0
lock-ftd LP_CC2652R7 (read only) 688871 688775 -96 -0.0
(read/write) 154680 154776 96 0.1
.bss 73588 73588 0 0.0
.data 3220 3220 0 0.0
.rodata 103167 103167 0 0.0
.text 585220 585124 -96 -0.0
lock-mtd LP_CC2652R7 (read only) 637623 637527 -96 -0.0
(read/write) 146388 146388 0 0.0
.bss 69308 69308 0 0.0
.data 3220 3220 0 0.0
.rodata 103047 103047 0 0.0
.text 534084 533988 -96 -0.0
pump-app LP_CC2652R7 (read only) 661579 661467 -112 -0.0
(read/write) 183172 183284 112 0.1
.bss 73764 73764 0 0.0
.data 3252 3252 0 0.0
.rodata 80315 80315 0 0.0
.text 580784 580672 -112 -0.0
pump-controller-app LP_CC2652R7 (read only) 654595 654531 -64 -0.0
(read/write) 189948 190012 64 0.0
.bss 73812 73812 0 0.0
.data 3216 3216 0 0.0
.rodata 83379 83379 0 0.0
.text 570736 570672 -64 -0.0
cyw30739 light cyw930739m2evb_01 (read/write) 626842 626738 -104 -0.0
.app_xip_area 529392 529288 -104 -0.0
.bss 80108 80108 0 0.0
.data 692 692 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 621466 621370 -96 -0.0
.app_xip_area 525488 525392 -96 -0.0
.bss 78668 78668 0 0.0
.data 656 656 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 574574 574494 -80 -0.0
.app_xip_area 468952 468872 -80 -0.0
.bss 88016 88016 0 0.0
.data 568 568 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 907928 907848 -80 -0.0
(read/write) 135112 135112 0 0.0
.bss 133064 133064 0 0.0
.data 2044 2044 0 0.0
.text 907920 907840 -80 -0.0
BRD4161A+rpc (read only) 942296 942216 -80 -0.0
(read/write) 151792 151792 0 0.0
.bss 149544 149544 0 0.0
.data 2248 2248 0 0.0
.text 942288 942208 -80 -0.0
BRD4161A+rs911x (read only) 746244 746148 -96 -0.0
(read/write) 129344 129344 0 0.0
.bss 127372 127372 0 0.0
.data 1972 1972 0 0.0
.text 746236 746140 -96 -0.0
lock-app BRD4161A+wf200 (read only) 908808 908680 -128 -0.0
(read/write) 126300 126300 0 0.0
.bss 124380 124380 0 0.0
.data 1920 1920 0 0.0
.text 908800 908672 -128 -0.0
window-app BRD4161A (read only) 845152 845088 -64 -0.0
(read/write) 133200 133200 0 0.0
.bss 131240 131240 0 0.0
.data 1956 1956 0 0.0
.text 845144 845080 -64 -0.0
esp32 all-clusters-app c3devkit (read only) 999918 999780 -138 -0.0
(read/write) 1474562 1474562 0 0.0
.dram0.bss 68360 68360 0 0.0
.dram0.data 14428 14428 0 0.0
.flash.rodata 207320 207320 0 0.0
.flash.text 999918 999780 -138 -0.0
.iram0.text 62020 62020 0 0.0
m5stack (read only) 1055315 1055135 -180 -0.0
(read/write) 476968 476968 0 0.0
.dram0.bss 73880 73880 0 0.0
.dram0.data 34168 34168 0 0.0
.flash.rodata 237084 237084 0 0.0
.flash.text 1049931 1049751 -180 -0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 684720 684528 -192 -0.0
.bss 81312 81312 0 0.0
.data 2000 2000 0 0.0
.text 599704 599512 -192 -0.0
lock k32w061+release (read/write) 725564 725436 -128 -0.0
.bss 81720 81720 0 0.0
.data 1960 1960 0 0.0
.text 640180 640052 -128 -0.0
linux all-clusters-app debug (read only) 2734457 2734057 -400 -0.0
(read/write) 172944 172944 0 0.0
.bss 83328 83328 0 0.0
.data 1984 1984 0 0.0
.data.rel.ro 81544 81544 0 0.0
.dynamic 608 608 0 0.0
.got 4464 4464 0 0.0
.init 27 27 0 0.0
.init_array 1000 1000 0 0.0
.rodata 234501 234501 0 0.0
.text 2325426 2325026 -400 -0.0
bridge-app debug+rpc (read only) 1889753 1889481 -272 -0.0
(read/write) 120304 120304 0 0.0
.bss 71328 71328 0 0.0
.data 3424 3424 0 0.0
.data.rel.ro 40232 40232 0 0.0
.dynamic 592 592 0 0.0
.got 4032 4032 0 0.0
.init 27 27 0 0.0
.init_array 680 680 0 0.0
.rodata 160001 160001 0 0.0
.text 1607426 1607154 -272 -0.0
chip-tool debug (read only) 8850261 8850133 -128 -0.0
(read/write) 550480 550480 0 0.0
.bss 22592 22592 0 0.0
.data 1136 1136 0 0.0
.data.rel.ro 520488 520488 0 0.0
.dynamic 624 624 0 0.0
.got 4952 4952 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 462517 462517 0 0.0
.text 7125077 7124949 -128 -0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 8692484 8692324 -160 -0.0
(read/write) 616289 616289 0 0.0
.bss 40897 40897 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 555648 555648 0 0.0
.dynamic 560 560 0 0.0
.got 14736 14736 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 429764 429764 0 0.0
.text 6865476 6865316 -160 -0.0
lighting-app debug+rpc (read only) 2324129 2323889 -240 -0.0
(read/write) 151256 151256 0 0.0
.bss 73376 73376 0 0.0
.data 1984 1984 0 0.0
.data.rel.ro 70168 70168 0 0.0
.dynamic 608 608 0 0.0
.got 4320 4320 0 0.0
.init 27 27 0 0.0
.init_array 784 784 0 0.0
.rodata 184137 184137 0 0.0
.text 1973810 1973570 -240 -0.0
lock-app debug (read only) 2205257 2205049 -208 -0.0
(read/write) 145640 145640 0 0.0
.bss 71968 71968 0 0.0
.data 1504 1504 0 0.0
.data.rel.ro 66504 66504 0 0.0
.dynamic 592 592 0 0.0
.got 4312 4312 0 0.0
.init 27 27 0 0.0
.init_array 736 736 0 0.0
.rodata 192561 192561 0 0.0
.text 1853154 1852946 -208 -0.0
ota-provider-app debug (read only) 2058745 2058585 -160 -0.0
(read/write) 138888 138888 0 0.0
.bss 71392 71392 0 0.0
.data 1672 1672 0 0.0
.data.rel.ro 60056 60056 0 0.0
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 174619 174619 0 0.0
.text 1727074 1726914 -160 -0.0
ota-requestor-app debug (read only) 2089865 2089705 -160 -0.0
(read/write) 141696 141696 0 0.0
.bss 72032 72032 0 0.0
.data 1928 1928 0 0.0
.data.rel.ro 62120 62120 0 0.0
.dynamic 592 592 0 0.0
.got 4320 4320 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 170892 170892 0 0.0
.text 1760434 1760274 -160 -0.0
shell debug (read only) 2559681 2559297 -384 -0.0
(read/write) 197000 197000 0 0.0
.bss 114056 114056 0 0.0
.data 1360 1360 0 0.0
.data.rel.ro 75840 75840 0 0.0
.dynamic 592 592 0 0.0
.got 4184 4184 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 216274 216274 0 0.0
.text 2181954 2181570 -384 -0.0
thermostat-no-ble arm64 (read only) 2367004 2362828 -4176 -0.2
(read/write) 174481 174481 0 0.0
.bss 86257 86257 0 0.0
.data 1488 1488 0 0.0
.data.rel.ro 78984 78984 0 0.0
.dynamic 560 560 0 0.0
.got 4728 4728 0 0.0
.init 24 24 0 0.0
.init_array 368 368 0 0.0
.rodata 145980 145740 -240 -0.2
.text 1992048 1988112 -3936 -0.2
tv-app debug (read only) 2842281 2842041 -240 -0.0
(read/write) 276536 276536 0 0.0
.bss 189272 189272 0 0.0
.data 4640 4640 0 0.0
.data.rel.ro 76408 76408 0 0.0
.dynamic 592 592 0 0.0
.got 4696 4696 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 216715 216715 0 0.0
.text 2443586 2443346 -240 -0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2489168 2488976 -192 -0.0
.bss 211736 211736 0 0.0
.data 5608 5608 0 0.0
.text 1451740 1451548 -192 -0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2439072 2438944 -128 -0.0
.bss 207044 207044 0 0.0
.data 5872 5872 0 0.0
.text 1401644 1401516 -128 -0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2411340 2411212 -128 -0.0
.bss 205860 205860 0 0.0
.data 5848 5848 0 0.0
.text 1373940 1373812 -128 -0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2365104 2365040 -64 -0.0
.bss 205656 205656 0 0.0
.data 5632 5632 0 0.0
.text 1327676 1327612 -64 -0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1180647 1180487 -160 -0.0
bss 141992 141992 0 0.0
rodata 150872 150872 0 0.0
text 809096 808932 -164 -0.0
lighting-app nrf52840dk_nrf52840 (read/write) 1156035 1155939 -96 -0.0
bss 145708 145708 0 0.0
rodata 121812 121812 0 0.0
text 809876 809772 -104 -0.0
nrf52840dk_nrf52840+rpc (read/write) 1120323 1120227 -96 -0.0
bss 145944 145944 0 0.0
rodata 112924 112924 0 0.0
text 782348 782240 -108 -0.0
nrf52840dongle_nrf52840 (read/write) 1063995 1063883 -112 -0.0
bss 152900 152900 0 0.0
rodata 91868 91868 0 0.0
text 738368 738260 -108 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 1058442 1058330 -112 -0.0
bss 141912 141912 0 0.0
rodata 114568 114568 0 0.0
text 719992 719884 -108 -0.0
lock-app nrf52840dk_nrf52840 (read/write) 1093727 1093631 -96 -0.0
bss 135624 135624 0 0.0
rodata 133608 133608 0 0.0
text 745964 745872 -92 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 996442 996346 -96 -0.0
bss 131860 131860 0 0.0
rodata 126408 126408 0 0.0
text 656220 656128 -92 -0.0
pump-app nrf52840dk_nrf52840 (read/write) 1076459 1076347 -112 -0.0
bss 135712 135712 0 0.0
rodata 117324 117324 0 0.0
text 744772 744664 -108 -0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 1058059 1057979 -80 -0.0
bss 135432 135432 0 0.0
rodata 113276 113276 0 0.0
text 730712 730632 -80 -0.0
p6 all-clusters-app default (read/write) 2528352 2528208 -144 -0.0
.bss 139248 139248 0 0.0
.data 2784 2784 0 0.0
.text 1486616 1486472 -144 -0.0
light-app default (read/write) 2418936 2418808 -128 -0.0
.bss 132720 132720 0 0.0
.data 2584 2584 0 0.0
.text 1377200 1377072 -128 -0.0
lock-app default (read/write) 2423048 2422936 -112 -0.0
.bss 132520 132520 0 0.0
.data 2544 2544 0 0.0
.text 1381312 1381200 -112 -0.0
telink lighting-app tlsr9518adk80d (read/write) 807660 807548 -112 -0.0
bss 75424 75424 0 0.0
noinit 40416 40416 0 0.0
text 571400 571292 -108 -0.0

@bzbarsky-apple bzbarsky-apple force-pushed the no-more-client-attributes branch 2 times, most recently from 6cd018b to c2f0dc6 Compare April 29, 2022 18:59
@github-actions
Copy link

github-actions bot commented Apr 29, 2022 •
edited
Loading

PR #17875: Size comparison from 5104f2d to c2f0dc6

Increases (4 builds for cc13x2_26x2)
platform target config section 5104f2d c2f0dc6 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 162960 163120 160 0.1
lock-ftd LP_CC2652R7 (read/write) 166244 166340 96 0.1
pump-app LP_CC2652R7 (read/write) 183172 183284 112 0.1
pump-controller-app LP_CC2652R7 (read/write) 189948 190012 64 0.0
Decreases (34 builds for cc13x2_26x2, cyw30739, efr32, esp32, linux, mbed, nrfconnect, p6, telink)
platform target config section 5104f2d c2f0dc6 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 689287 689127 -160 -0.0
.text 586568 586408 -160 -0.0
lock-ftd LP_CC2652R7 (read only) 677259 677163 -96 -0.0
.text 582348 582252 -96 -0.0
lock-mtd LP_CC2652R7 (read only) 626003 625907 -96 -0.0
.text 531204 531108 -96 -0.0
pump-app LP_CC2652R7 (read only) 661579 661467 -112 -0.0
.text 580784 580672 -112 -0.0
pump-controller-app LP_CC2652R7 (read only) 654595 654531 -64 -0.0
.text 570736 570672 -64 -0.0
cyw30739 light cyw930739m2evb_01 (read/write) 626842 626738 -104 -0.0
.app_xip_area 529392 529288 -104 -0.0
lock cyw930739m2evb_01 (read/write) 625538 625442 -96 -0.0
.app_xip_area 529544 529448 -96 -0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 574574 574494 -80 -0.0
.app_xip_area 468952 468872 -80 -0.0
efr32 lighting-app BRD4161A (read only) 907928 907848 -80 -0.0
.text 907920 907840 -80 -0.0
BRD4161A+rpc (read only) 942296 942216 -80 -0.0
.text 942288 942208 -80 -0.0
BRD4161A+rs911x (read only) 746244 746148 -96 -0.0
.text 746236 746140 -96 -0.0
lock-app BRD4161A+wf200 (read only) 916968 916872 -96 -0.0
.text 916960 916864 -96 -0.0
window-app BRD4161A (read only) 845152 845088 -64 -0.0
.text 845144 845080 -64 -0.0
esp32 all-clusters-app c3devkit (read only) 999918 999780 -138 -0.0
.flash.text 999918 999780 -138 -0.0
m5stack (read only) 1055315 1055135 -180 -0.0
.flash.text 1049931 1049751 -180 -0.0
linux chip-tool-no-interactive-ipv6only arm64 (read only) 8692404 8692244 -160 -0.0
.text 6865412 6865252 -160 -0.0
thermostat-no-ble arm64 (read only) 2367004 2362828 -4176 -0.2
.rodata 145980 145740 -240 -0.2
.text 1992048 1988112 -3936 -0.2
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2489168 2488976 -192 -0.0
.text 1451740 1451548 -192 -0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2439072 2438944 -128 -0.0
.text 1401644 1401516 -128 -0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2416772 2416644 -128 -0.0
.text 1379372 1379244 -128 -0.0
shell CY8CPROTO_062_4343W+release (read/write) 2365104 2365040 -64 -0.0
.text 1327676 1327612 -64 -0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1180647 1180487 -160 -0.0
text 809096 808932 -164 -0.0
lighting-app nrf52840dk_nrf52840 (read/write) 1156035 1155939 -96 -0.0
text 809876 809772 -104 -0.0
nrf52840dk_nrf52840+rpc (read/write) 1120323 1120227 -96 -0.0
text 782348 782240 -108 -0.0
nrf52840dongle_nrf52840 (read/write) 1063995 1063883 -112 -0.0
text 738368 738260 -108 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 1058442 1058330 -112 -0.0
text 719992 719884 -108 -0.0
lock-app nrf52840dk_nrf52840 (read/write) 1098235 1098139 -96 -0.0
text 749744 749648 -96 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 1000986 1000890 -96 -0.0
text 660000 659904 -96 -0.0
pump-app nrf52840dk_nrf52840 (read/write) 1076459 1076347 -112 -0.0
text 744772 744664 -108 -0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 1058059 1057979 -80 -0.0
text 730712 730632 -80 -0.0
p6 all-clusters-app default (read/write) 2528352 2528208 -144 -0.0
.text 1486616 1486472 -144 -0.0
light-app default (read/write) 2418936 2418808 -128 -0.0
.text 1377200 1377072 -128 -0.0
lock-app default (read/write) 2428192 2428080 -112 -0.0
.text 1386456 1386344 -112 -0.0
telink lighting-app tlsr9518adk80d (read/write) 807660 807548 -112 -0.0
text 571400 571292 -108 -0.0
Full report (34 builds for cc13x2_26x2, cyw30739, efr32, esp32, linux, mbed, nrfconnect, p6, telink)
platform target config section 5104f2d c2f0dc6 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 689287 689127 -160 -0.0
(read/write) 162960 163120 160 0.1
.bss 75228 75228 0 0.0
.data 3396 3396 0 0.0
.rodata 102239 102239 0 0.0
.text 586568 586408 -160 -0.0
lock-ftd LP_CC2652R7 (read only) 677259 677163 -96 -0.0
(read/write) 166244 166340 96 0.1
.bss 73540 73540 0 0.0
.data 3220 3220 0 0.0
.rodata 94427 94427 0 0.0
.text 582348 582252 -96 -0.0
lock-mtd LP_CC2652R7 (read only) 626003 625907 -96 -0.0
(read/write) 146340 146340 0 0.0
.bss 69260 69260 0 0.0
.data 3220 3220 0 0.0
.rodata 94307 94307 0 0.0
.text 531204 531108 -96 -0.0
pump-app LP_CC2652R7 (read only) 661579 661467 -112 -0.0
(read/write) 183172 183284 112 0.1
.bss 73764 73764 0 0.0
.data 3252 3252 0 0.0
.rodata 80315 80315 0 0.0
.text 580784 580672 -112 -0.0
pump-controller-app LP_CC2652R7 (read only) 654595 654531 -64 -0.0
(read/write) 189948 190012 64 0.0
.bss 73812 73812 0 0.0
.data 3216 3216 0 0.0
.rodata 83379 83379 0 0.0
.text 570736 570672 -64 -0.0
cyw30739 light cyw930739m2evb_01 (read/write) 626842 626738 -104 -0.0
.app_xip_area 529392 529288 -104 -0.0
.bss 80108 80108 0 0.0
.data 692 692 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 625538 625442 -96 -0.0
.app_xip_area 529544 529448 -96 -0.0
.bss 78684 78684 0 0.0
.data 656 656 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 574574 574494 -80 -0.0
.app_xip_area 468952 468872 -80 -0.0
.bss 88016 88016 0 0.0
.data 568 568 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 907928 907848 -80 -0.0
(read/write) 135112 135112 0 0.0
.bss 133064 133064 0 0.0
.data 2044 2044 0 0.0
.text 907920 907840 -80 -0.0
BRD4161A+rpc (read only) 942296 942216 -80 -0.0
(read/write) 151792 151792 0 0.0
.bss 149544 149544 0 0.0
.data 2248 2248 0 0.0
.text 942288 942208 -80 -0.0
BRD4161A+rs911x (read only) 746244 746148 -96 -0.0
(read/write) 129344 129344 0 0.0
.bss 127372 127372 0 0.0
.data 1972 1972 0 0.0
.text 746236 746140 -96 -0.0
lock-app BRD4161A+wf200 (read only) 916968 916872 -96 -0.0
(read/write) 127532 127532 0 0.0
.bss 125604 125604 0 0.0
.data 1928 1928 0 0.0
.text 916960 916864 -96 -0.0
window-app BRD4161A (read only) 845152 845088 -64 -0.0
(read/write) 133200 133200 0 0.0
.bss 131240 131240 0 0.0
.data 1956 1956 0 0.0
.text 845144 845080 -64 -0.0
esp32 all-clusters-app c3devkit (read only) 999918 999780 -138 -0.0
(read/write) 1474562 1474562 0 0.0
.dram0.bss 68360 68360 0 0.0
.dram0.data 14428 14428 0 0.0
.flash.rodata 207320 207320 0 0.0
.flash.text 999918 999780 -138 -0.0
.iram0.text 62020 62020 0 0.0
m5stack (read only) 1055315 1055135 -180 -0.0
(read/write) 476968 476968 0 0.0
.dram0.bss 73880 73880 0 0.0
.dram0.data 34168 34168 0 0.0
.flash.rodata 237084 237084 0 0.0
.flash.text 1049931 1049751 -180 -0.0
.iram0.text 123107 123107 0 0.0
linux chip-tool-no-interactive-ipv6only arm64 (read only) 8692404 8692244 -160 -0.0
(read/write) 616289 616289 0 0.0
.bss 40897 40897 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 555648 555648 0 0.0
.dynamic 560 560 0 0.0
.got 14736 14736 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 429748 429748 0 0.0
.text 6865412 6865252 -160 -0.0
thermostat-no-ble arm64 (read only) 2367004 2362828 -4176 -0.2
(read/write) 174481 174481 0 0.0
.bss 86257 86257 0 0.0
.data 1488 1488 0 0.0
.data.rel.ro 78984 78984 0 0.0
.dynamic 560 560 0 0.0
.got 4728 4728 0 0.0
.init 24 24 0 0.0
.init_array 368 368 0 0.0
.rodata 145980 145740 -240 -0.2
.text 1992048 1988112 -3936 -0.2
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2489168 2488976 -192 -0.0
.bss 211736 211736 0 0.0
.data 5608 5608 0 0.0
.text 1451740 1451548 -192 -0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2439072 2438944 -128 -0.0
.bss 207044 207044 0 0.0
.data 5872 5872 0 0.0
.text 1401644 1401516 -128 -0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2416772 2416644 -128 -0.0
.bss 205876 205876 0 0.0
.data 5848 5848 0 0.0
.text 1379372 1379244 -128 -0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2365104 2365040 -64 -0.0
.bss 205656 205656 0 0.0
.data 5632 5632 0 0.0
.text 1327676 1327612 -64 -0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1180647 1180487 -160 -0.0
bss 141992 141992 0 0.0
rodata 150872 150872 0 0.0
text 809096 808932 -164 -0.0
lighting-app nrf52840dk_nrf52840 (read/write) 1156035 1155939 -96 -0.0
bss 145708 145708 0 0.0
rodata 121812 121812 0 0.0
text 809876 809772 -104 -0.0
nrf52840dk_nrf52840+rpc (read/write) 1120323 1120227 -96 -0.0
bss 145944 145944 0 0.0
rodata 112924 112924 0 0.0
text 782348 782240 -108 -0.0
nrf52840dongle_nrf52840 (read/write) 1063995 1063883 -112 -0.0
bss 152900 152900 0 0.0
rodata 91868 91868 0 0.0
text 738368 738260 -108 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 1058442 1058330 -112 -0.0
bss 141912 141912 0 0.0
rodata 114568 114568 0 0.0
text 719992 719884 -108 -0.0
lock-app nrf52840dk_nrf52840 (read/write) 1098235 1098139 -96 -0.0
bss 135644 135644 0 0.0
rodata 134340 134340 0 0.0
text 749744 749648 -96 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 1000986 1000890 -96 -0.0
bss 131876 131876 0 0.0
rodata 127144 127144 0 0.0
text 660000 659904 -96 -0.0
pump-app nrf52840dk_nrf52840 (read/write) 1076459 1076347 -112 -0.0
bss 135712 135712 0 0.0
rodata 117324 117324 0 0.0
text 744772 744664 -108 -0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 1058059 1057979 -80 -0.0
bss 135432 135432 0 0.0
rodata 113276 113276 0 0.0
text 730712 730632 -80 -0.0
p6 all-clusters-app default (read/write) 2528352 2528208 -144 -0.0
.bss 139248 139248 0 0.0
.data 2784 2784 0 0.0
.text 1486616 1486472 -144 -0.0
light-app default (read/write) 2418936 2418808 -128 -0.0
.bss 132720 132720 0 0.0
.data 2584 2584 0 0.0
.text 1377200 1377072 -128 -0.0
lock-app default (read/write) 2428192 2428080 -112 -0.0
.bss 132544 132544 0 0.0
.data 2544 2544 0 0.0
.text 1386456 1386344 -112 -0.0
telink lighting-app tlsr9518adk80d (read/write) 807660 807548 -112 -0.0
bss 75424 75424 0 0.0
noinit 40416 40416 0 0.0
text 571400 571292 -108 -0.0

@bzbarsky-apple bzbarsky-apple force-pushed the no-more-client-attributes branch from c2f0dc6 to d13a427 Compare April 29, 2022 22:45
@github-actions
Copy link

github-actions bot commented Apr 29, 2022 •
edited
Loading

PR #17875: Size comparison from 4a145d6 to d13a427

Increases (4 builds for cc13x2_26x2)
platform target config section 4a145d6 d13a427 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 162744 162904 160 0.1
lock-ftd LP_CC2652R7 (read/write) 166208 166304 96 0.1
pump-app LP_CC2652R7 (read/write) 182796 182916 120 0.1
pump-controller-app LP_CC2652R7 (read/write) 189756 189820 64 0.0
Decreases (29 builds for cc13x2_26x2, cyw30739, k32w, linux, mbed, p6, telink)
platform target config section 4a145d6 d13a427 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 689511 689351 -160 -0.0
.text 586724 586564 -160 -0.0
lock-ftd LP_CC2652R7 (read only) 677303 677207 -96 -0.0
.text 582464 582368 -96 -0.0
lock-mtd LP_CC2652R7 (read only) 626047 625951 -96 -0.0
.text 531312 531216 -96 -0.0
pump-app LP_CC2652R7 (read only) 661955 661835 -120 -0.0
.text 580972 580852 -120 -0.0
pump-controller-app LP_CC2652R7 (read only) 654795 654731 -64 -0.0
.text 570876 570812 -64 -0.0
cyw30739 light cyw930739m2evb_01 (read/write) 626898 626794 -104 -0.0
.app_xip_area 529432 529328 -104 -0.0
lock cyw930739m2evb_01 (read/write) 625594 625498 -96 -0.0
.app_xip_area 529592 529496 -96 -0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 574722 574642 -80 -0.0
.app_xip_area 469100 469020 -80 -0.0
k32w light k32w061+release (read/write) 684860 684668 -192 -0.0
.text 599828 599636 -192 -0.0
lock k32w061+release (read/write) 729676 729564 -112 -0.0
.text 644260 644148 -112 -0.0
linux all-clusters-app debug (read only) 2732721 2732321 -400 -0.0
.text 2323138 2322738 -400 -0.0
bridge-app debug+rpc (read only) 1887905 1887617 -288 -0.0
.text 1605090 1604802 -288 -0.0
chip-tool debug (read only) 8852773 8852645 -128 -0.0
.text 7127525 7127397 -128 -0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 8694996 8694836 -160 -0.0
.text 6867892 6867732 -160 -0.0
lighting-app debug+rpc (read only) 2322281 2322025 -256 -0.0
.text 1971474 1971218 -256 -0.0
lock-app debug (read only) 2228657 2228465 -192 -0.0
.text 1874402 1874210 -192 -0.0
ota-provider-app debug (read only) 2056961 2056785 -176 -0.0
.text 1724738 1724562 -176 -0.0
ota-requestor-app debug (read only) 2088065 2087905 -160 -0.0
.text 1758082 1757922 -160 -0.0
shell debug (read only) 2557913 2557529 -384 -0.0
.text 2179666 2179282 -384 -0.0
thermostat-no-ble arm64 (read only) 2367732 2363556 -4176 -0.2
.rodata 146100 145860 -240 -0.2
.text 1992480 1988544 -3936 -0.2
tv-app debug (read only) 2840625 2840401 -224 -0.0
.text 2441474 2441250 -224 -0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2491224 2491096 -128 -0.0
.text 1453796 1453668 -128 -0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2441192 2441064 -128 -0.0
.text 1403764 1403636 -128 -0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2418892 2418764 -128 -0.0
.text 1381492 1381364 -128 -0.0
shell CY8CPROTO_062_4343W+release (read/write) 2367224 2367160 -64 -0.0
.text 1329796 1329732 -64 -0.0
p6 all-clusters-app default (read/write) 2529352 2529208 -144 -0.0
.text 1487616 1487472 -144 -0.0
light-app default (read/write) 2419912 2419800 -112 -0.0
.text 1378176 1378064 -112 -0.0
lock-app default (read/write) 2429192 2429080 -112 -0.0
.text 1387456 1387344 -112 -0.0
telink lighting-app tlsr9518adk80d (read/write) 808144 808040 -104 -0.0
text 571822 571714 -108 -0.0
Full report (29 builds for cc13x2_26x2, cyw30739, k32w, linux, mbed, p6, telink)
platform target config section 4a145d6 d13a427 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 689511 689351 -160 -0.0
(read/write) 162744 162904 160 0.1
.bss 75236 75236 0 0.0
.data 3400 3400 0 0.0
.rodata 102303 102303 0 0.0
.text 586724 586564 -160 -0.0
lock-ftd LP_CC2652R7 (read only) 677303 677207 -96 -0.0
(read/write) 166208 166304 96 0.1
.bss 73548 73548 0 0.0
.data 3224 3224 0 0.0
.rodata 94359 94359 0 0.0
.text 582464 582368 -96 -0.0
lock-mtd LP_CC2652R7 (read only) 626047 625951 -96 -0.0
(read/write) 146352 146352 0 0.0
.bss 69268 69268 0 0.0
.data 3224 3224 0 0.0
.rodata 94247 94247 0 0.0
.text 531312 531216 -96 -0.0
pump-app LP_CC2652R7 (read only) 661955 661835 -120 -0.0
(read/write) 182796 182916 120 0.1
.bss 73764 73764 0 0.0
.data 3256 3256 0 0.0
.rodata 80499 80499 0 0.0
.text 580972 580852 -120 -0.0
pump-controller-app LP_CC2652R7 (read only) 654795 654731 -64 -0.0
(read/write) 189756 189820 64 0.0
.bss 73820 73820 0 0.0
.data 3220 3220 0 0.0
.rodata 83435 83435 0 0.0
.text 570876 570812 -64 -0.0
cyw30739 light cyw930739m2evb_01 (read/write) 626898 626794 -104 -0.0
.app_xip_area 529432 529328 -104 -0.0
.bss 80116 80116 0 0.0
.data 696 696 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 625594 625498 -96 -0.0
.app_xip_area 529592 529496 -96 -0.0
.bss 78692 78692 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 574722 574642 -80 -0.0
.app_xip_area 469100 469020 -80 -0.0
.bss 88016 88016 0 0.0
.data 572 572 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
k32w light k32w061+release (read/write) 684860 684668 -192 -0.0
.bss 81320 81320 0 0.0
.data 2008 2008 0 0.0
.text 599828 599636 -192 -0.0
lock k32w061+release (read/write) 729676 729564 -112 -0.0
.bss 81744 81744 0 0.0
.data 1968 1968 0 0.0
.text 644260 644148 -112 -0.0
linux all-clusters-app debug (read only) 2732721 2732321 -400 -0.0
(read/write) 173336 173336 0 0.0
.bss 83584 83584 0 0.0
.data 1968 1968 0 0.0
.data.rel.ro 81656 81656 0 0.0
.dynamic 608 608 0 0.0
.got 4464 4464 0 0.0
.init 27 27 0 0.0
.init_array 1008 1008 0 0.0
.rodata 234981 234981 0 0.0
.text 2323138 2322738 -400 -0.0
bridge-app debug+rpc (read only) 1887905 1887617 -288 -0.0
(read/write) 120664 120664 0 0.0
.bss 71584 71584 0 0.0
.data 3424 3424 0 0.0
.data.rel.ro 40312 40312 0 0.0
.dynamic 592 592 0 0.0
.got 4032 4032 0 0.0
.init 27 27 0 0.0
.init_array 688 688 0 0.0
.rodata 160417 160417 0 0.0
.text 1605090 1604802 -288 -0.0
chip-tool debug (read only) 8852773 8852645 -128 -0.0
(read/write) 550704 550704 0 0.0
.bss 22816 22816 0 0.0
.data 1136 1136 0 0.0
.data.rel.ro 520488 520488 0 0.0
.dynamic 624 624 0 0.0
.got 4952 4952 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 462581 462581 0 0.0
.text 7127525 7127397 -128 -0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 8694996 8694836 -160 -0.0
(read/write) 616497 616497 0 0.0
.bss 41105 41105 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 555648 555648 0 0.0
.dynamic 560 560 0 0.0
.got 14736 14736 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 429860 429860 0 0.0
.text 6867892 6867732 -160 -0.0
lighting-app debug+rpc (read only) 2322281 2322025 -256 -0.0
(read/write) 151616 151616 0 0.0
.bss 73632 73632 0 0.0
.data 1984 1984 0 0.0
.data.rel.ro 70248 70248 0 0.0
.dynamic 608 608 0 0.0
.got 4320 4320 0 0.0
.init 27 27 0 0.0
.init_array 792 792 0 0.0
.rodata 184553 184553 0 0.0
.text 1971474 1971218 -256 -0.0
lock-app debug (read only) 2228657 2228465 -192 -0.0
(read/write) 146200 146200 0 0.0
.bss 72256 72256 0 0.0
.data 1504 1504 0 0.0
.data.rel.ro 66760 66760 0 0.0
.dynamic 592 592 0 0.0
.got 4312 4312 0 0.0
.init 27 27 0 0.0
.init_array 752 752 0 0.0
.rodata 194353 194353 0 0.0
.text 1874402 1874210 -192 -0.0
ota-provider-app debug (read only) 2056961 2056785 -176 -0.0
(read/write) 139216 139216 0 0.0
.bss 71648 71648 0 0.0
.data 1672 1672 0 0.0
.data.rel.ro 60104 60104 0 0.0
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 175099 175099 0 0.0
.text 1724738 1724562 -176 -0.0
ota-requestor-app debug (read only) 2088065 2087905 -160 -0.0
(read/write) 142024 142024 0 0.0
.bss 72288 72288 0 0.0
.data 1928 1928 0 0.0
.data.rel.ro 62184 62184 0 0.0
.dynamic 592 592 0 0.0
.got 4320 4320 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 171372 171372 0 0.0
.text 1758082 1757922 -160 -0.0
shell debug (read only) 2557913 2557529 -384 -0.0
(read/write) 197328 197328 0 0.0
.bss 114312 114312 0 0.0
.data 1376 1376 0 0.0
.data.rel.ro 75920 75920 0 0.0
.dynamic 592 592 0 0.0
.got 4184 4184 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 216722 216722 0 0.0
.text 2179666 2179282 -384 -0.0
thermostat-no-ble arm64 (read only) 2367732 2363556 -4176 -0.2
(read/write) 174801 174801 0 0.0
.bss 86481 86481 0 0.0
.data 1496 1496 0 0.0
.data.rel.ro 79048 79048 0 0.0
.dynamic 560 560 0 0.0
.got 4736 4736 0 0.0
.init 24 24 0 0.0
.init_array 376 376 0 0.0
.rodata 146100 145860 -240 -0.2
.text 1992480 1988544 -3936 -0.2
tv-app debug (read only) 2840625 2840401 -224 -0.0
(read/write) 276832 276832 0 0.0
.bss 189496 189496 0 0.0
.data 4640 4640 0 0.0
.data.rel.ro 76456 76456 0 0.0
.dynamic 592 592 0 0.0
.got 4696 4696 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 217099 217099 0 0.0
.text 2441474 2441250 -224 -0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2491224 2491096 -128 -0.0
.bss 211736 211736 0 0.0
.data 5608 5608 0 0.0
.text 1453796 1453668 -128 -0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2441192 2441064 -128 -0.0
.bss 207052 207052 0 0.0
.data 5880 5880 0 0.0
.text 1403764 1403636 -128 -0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2418892 2418764 -128 -0.0
.bss 205884 205884 0 0.0
.data 5856 5856 0 0.0
.text 1381492 1381364 -128 -0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2367224 2367160 -64 -0.0
.bss 205656 205656 0 0.0
.data 5632 5632 0 0.0
.text 1329796 1329732 -64 -0.0
p6 all-clusters-app default (read/write) 2529352 2529208 -144 -0.0
.bss 139256 139256 0 0.0
.data 2792 2792 0 0.0
.text 1487616 1487472 -144 -0.0
light-app default (read/write) 2419912 2419800 -112 -0.0
.bss 132720 132720 0 0.0
.data 2592 2592 0 0.0
.text 1378176 1378064 -112 -0.0
lock-app default (read/write) 2429192 2429080 -112 -0.0
.bss 132544 132544 0 0.0
.data 2552 2552 0 0.0
.text 1387456 1387344 -112 -0.0
telink lighting-app tlsr9518adk80d (read/write) 808144 808040 -104 -0.0
bss 75432 75432 0 0.0
noinit 40416 40416 0 0.0
text 571822 571714 -108 -0.0

@bzbarsky-apple
Get rid of the concept of client attributes.
8795b9b 
They don't exist in Matter.

We still have some places using *ServerAttribute instead of just *Attribute; that
will be sorted out in a separate PR.
@bzbarsky-apple bzbarsky-apple force-pushed the no-more-client-attributes branch from d13a427 to 8795b9b Compare April 30, 2022 00:33
@github-actions
Copy link

github-actions bot commented Apr 30, 2022 •
edited
Loading

PR #17875: Size comparison from 9dc2682 to 8795b9b

Increases (4 builds for cc13x2_26x2)
platform target config section 9dc2682 8795b9b change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 163208 163376 168 0.1
lock-ftd LP_CC2652R7 (read/write) 166680 166776 96 0.1
pump-app LP_CC2652R7 (read/write) 183404 183524 120 0.1
pump-controller-app LP_CC2652R7 (read/write) 190364 190428 64 0.0
Decreases (45 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 9dc2682 8795b9b change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 689047 688879 -168 -0.0
.text 586260 586092 -168 -0.0
lock-ftd LP_CC2652R7 (read only) 676831 676735 -96 -0.0
.text 581992 581896 -96 -0.0
lock-mtd LP_CC2652R7 (read only) 625583 625487 -96 -0.0
.text 530848 530752 -96 -0.0
pump-app LP_CC2652R7 (read only) 661347 661227 -120 -0.0
.text 580476 580356 -120 -0.0
pump-controller-app LP_CC2652R7 (read only) 654187 654123 -64 -0.0
.text 570380 570316 -64 -0.0
cyw30739 light cyw930739m2evb_01 (read/write) 626426 626322 -104 -0.0
.app_xip_area 528960 528856 -104 -0.0
lock cyw930739m2evb_01 (read/write) 625122 625026 -96 -0.0
.app_xip_area 529120 529024 -96 -0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 574250 574170 -80 -0.0
.app_xip_area 468628 468548 -80 -0.0
efr32 lighting-app BRD4161A (read only) 908248 908168 -80 -0.0
.text 908240 908160 -80 -0.0
BRD4161A+rpc (read only) 942592 942512 -80 -0.0
.text 942584 942504 -80 -0.0
BRD4161A+rs911x (read only) 746564 746468 -96 -0.0
.text 746556 746460 -96 -0.0
lock-app BRD4161A+wf200 (read only) 916576 916480 -96 -0.0
.text 916568 916472 -96 -0.0
window-app BRD4161A (read only) 845480 845416 -64 -0.0
.text 845472 845408 -64 -0.0
esp32 all-clusters-app c3devkit (read only) 999708 999570 -138 -0.0
.flash.text 999708 999570 -138 -0.0
m5stack (read only) 1054891 1054731 -160 -0.0
.flash.text 1049507 1049347 -160 -0.0
k32w light k32w061+release (read/write) 684396 684204 -192 -0.0
.text 599364 599172 -192 -0.0
lock k32w061+release (read/write) 729212 729100 -112 -0.0
.text 643796 643684 -112 -0.0
linux all-clusters-app debug (read only) 2730017 2729633 -384 -0.0
.text 2320562 2320178 -384 -0.0
bridge-app debug+rpc (read only) 1885233 1884945 -288 -0.0
.text 1602514 1602226 -288 -0.0
chip-tool debug (read only) 8850101 8849973 -128 -0.0
.text 7124949 7124821 -128 -0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 8692404 8692244 -160 -0.0
.text 6865412 6865252 -160 -0.0
lighting-app debug+rpc (read only) 2319577 2319337 -240 -0.0
.text 1968898 1968658 -240 -0.0
lock-app debug (read only) 2225969 2225761 -208 -0.0
.text 1871842 1871634 -208 -0.0
ota-provider-app debug (read only) 2054257 2054097 -160 -0.0
.text 1722162 1722002 -160 -0.0
ota-requestor-app debug (read only) 2085377 2085201 -176 -0.0
.text 1755522 1755346 -176 -0.0
shell debug (read only) 2555225 2554825 -400 -0.0
.text 2177106 2176706 -400 -0.0
thermostat-no-ble arm64 (read only) 2365124 2360948 -4176 -0.2
.rodata 145988 145748 -240 -0.2
.text 1989984 1986048 -3936 -0.2
tv-app debug (read only) 2837937 2837697 -240 -0.0
.text 2438914 2438674 -240 -0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2490664 2490472 -192 -0.0
.text 1453236 1453044 -192 -0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2440568 2440440 -128 -0.0
.text 1403140 1403012 -128 -0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2418268 2418140 -128 -0.0
.text 1380868 1380740 -128 -0.0
shell CY8CPROTO_062_4343W+release (read/write) 2366600 2366536 -64 -0.0
.text 1329172 1329108 -64 -0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1180251 1180075 -176 -0.0
text 808752 808588 -164 -0.0
lighting-app nrf52840dk_nrf52840 (read/write) 1155671 1155559 -112 -0.0
text 809556 809448 -108 -0.0
nrf52840dk_nrf52840+rpc (read/write) 1119951 1119839 -112 -0.0
text 782028 781924 -104 -0.0
nrf52840dongle_nrf52840 (read/write) 1063603 1063507 -96 -0.0
text 738044 737940 -104 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 1058034 1057938 -96 -0.0
text 719660 719556 -104 -0.0
lock-app nrf52840dk_nrf52840 (read/write) 1097847 1097751 -96 -0.0
text 749420 749328 -92 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 1000606 1000510 -96 -0.0
text 659668 659576 -92 -0.0
pump-app nrf52840dk_nrf52840 (read/write) 1076071 1075959 -112 -0.0
text 744448 744344 -104 -0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 1057667 1057587 -80 -0.0
text 730392 730312 -80 -0.0
p6 all-clusters-app default (read/write) 2528656 2528512 -144 -0.0
.text 1486920 1486776 -144 -0.0
light-app default (read/write) 2419224 2419112 -112 -0.0
.text 1377488 1377376 -112 -0.0
lock-app default (read/write) 2428496 2428384 -112 -0.0
.text 1386760 1386648 -112 -0.0
telink lighting-app tlsr9518adk80d (read/write) 807436 807324 -112 -0.0
text 571226 571118 -108 -0.0
Full report (45 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 9dc2682 8795b9b change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 689047 688879 -168 -0.0
(read/write) 163208 163376 168 0.1
.bss 75236 75236 0 0.0
.data 3400 3400 0 0.0
.rodata 102303 102303 0 0.0
.text 586260 586092 -168 -0.0
lock-ftd LP_CC2652R7 (read only) 676831 676735 -96 -0.0
(read/write) 166680 166776 96 0.1
.bss 73548 73548 0 0.0
.data 3224 3224 0 0.0
.rodata 94359 94359 0 0.0
.text 581992 581896 -96 -0.0
lock-mtd LP_CC2652R7 (read only) 625583 625487 -96 -0.0
(read/write) 146352 146352 0 0.0
.bss 69268 69268 0 0.0
.data 3224 3224 0 0.0
.rodata 94247 94247 0 0.0
.text 530848 530752 -96 -0.0
pump-app LP_CC2652R7 (read only) 661347 661227 -120 -0.0
(read/write) 183404 183524 120 0.1
.bss 73764 73764 0 0.0
.data 3256 3256 0 0.0
.rodata 80387 80387 0 0.0
.text 580476 580356 -120 -0.0
pump-controller-app LP_CC2652R7 (read only) 654187 654123 -64 -0.0
(read/write) 190364 190428 64 0.0
.bss 73820 73820 0 0.0
.data 3220 3220 0 0.0
.rodata 83323 83323 0 0.0
.text 570380 570316 -64 -0.0
cyw30739 light cyw930739m2evb_01 (read/write) 626426 626322 -104 -0.0
.app_xip_area 528960 528856 -104 -0.0
.bss 80116 80116 0 0.0
.data 696 696 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 625122 625026 -96 -0.0
.app_xip_area 529120 529024 -96 -0.0
.bss 78692 78692 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 574250 574170 -80 -0.0
.app_xip_area 468628 468548 -80 -0.0
.bss 88016 88016 0 0.0
.data 572 572 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 908248 908168 -80 -0.0
(read/write) 135128 135128 0 0.0
.bss 133072 133072 0 0.0
.data 2052 2052 0 0.0
.text 908240 908160 -80 -0.0
BRD4161A+rpc (read only) 942592 942512 -80 -0.0
(read/write) 151808 151808 0 0.0
.bss 149552 149552 0 0.0
.data 2256 2256 0 0.0
.text 942584 942504 -80 -0.0
BRD4161A+rs911x (read only) 746564 746468 -96 -0.0
(read/write) 129352 129352 0 0.0
.bss 127372 127372 0 0.0
.data 1980 1980 0 0.0
.text 746556 746460 -96 -0.0
lock-app BRD4161A+wf200 (read only) 916576 916480 -96 -0.0
(read/write) 127540 127540 0 0.0
.bss 125604 125604 0 0.0
.data 1936 1936 0 0.0
.text 916568 916472 -96 -0.0
window-app BRD4161A (read only) 845480 845416 -64 -0.0
(read/write) 133216 133216 0 0.0
.bss 131248 131248 0 0.0
.data 1964 1964 0 0.0
.text 845472 845408 -64 -0.0
esp32 all-clusters-app c3devkit (read only) 999708 999570 -138 -0.0
(read/write) 1474506 1474506 0 0.0
.dram0.bss 68376 68376 0 0.0
.dram0.data 14428 14428 0 0.0
.flash.rodata 207248 207248 0 0.0
.flash.text 999708 999570 -138 -0.0
.iram0.text 62020 62020 0 0.0
m5stack (read only) 1054891 1054731 -160 -0.0
(read/write) 476936 476936 0 0.0
.dram0.bss 73896 73896 0 0.0
.dram0.data 34176 34176 0 0.0
.flash.rodata 237028 237028 0 0.0
.flash.text 1049507 1049347 -160 -0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 684396 684204 -192 -0.0
.bss 81320 81320 0 0.0
.data 2008 2008 0 0.0
.text 599364 599172 -192 -0.0
lock k32w061+release (read/write) 729212 729100 -112 -0.0
.bss 81744 81744 0 0.0
.data 1968 1968 0 0.0
.text 643796 643684 -112 -0.0
linux all-clusters-app debug (read only) 2730017 2729633 -384 -0.0
(read/write) 173112 173112 0 0.0
.bss 83360 83360 0 0.0
.data 1968 1968 0 0.0
.data.rel.ro 81656 81656 0 0.0
.dynamic 608 608 0 0.0
.got 4464 4464 0 0.0
.init 27 27 0 0.0
.init_array 1008 1008 0 0.0
.rodata 234853 234853 0 0.0
.text 2320562 2320178 -384 -0.0
bridge-app debug+rpc (read only) 1885233 1884945 -288 -0.0
(read/write) 120440 120440 0 0.0
.bss 71360 71360 0 0.0
.data 3424 3424 0 0.0
.data.rel.ro 40312 40312 0 0.0
.dynamic 592 592 0 0.0
.got 4032 4032 0 0.0
.init 27 27 0 0.0
.init_array 688 688 0 0.0
.rodata 160321 160321 0 0.0
.text 1602514 1602226 -288 -0.0
chip-tool debug (read only) 8850101 8849973 -128 -0.0
(read/write) 550480 550480 0 0.0
.bss 22592 22592 0 0.0
.data 1136 1136 0 0.0
.data.rel.ro 520488 520488 0 0.0
.dynamic 624 624 0 0.0
.got 4952 4952 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 462485 462485 0 0.0
.text 7124949 7124821 -128 -0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 8692404 8692244 -160 -0.0
(read/write) 616305 616305 0 0.0
.bss 40913 40913 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 555648 555648 0 0.0
.dynamic 560 560 0 0.0
.got 14736 14736 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 429748 429748 0 0.0
.text 6865412 6865252 -160 -0.0
lighting-app debug+rpc (read only) 2319577 2319337 -240 -0.0
(read/write) 151392 151392 0 0.0
.bss 73408 73408 0 0.0
.data 1984 1984 0 0.0
.data.rel.ro 70248 70248 0 0.0
.dynamic 608 608 0 0.0
.got 4320 4320 0 0.0
.init 27 27 0 0.0
.init_array 792 792 0 0.0
.rodata 184425 184425 0 0.0
.text 1968898 1968658 -240 -0.0
lock-app debug (read only) 2225969 2225761 -208 -0.0
(read/write) 145976 145976 0 0.0
.bss 72032 72032 0 0.0
.data 1504 1504 0 0.0
.data.rel.ro 66760 66760 0 0.0
.dynamic 592 592 0 0.0
.got 4312 4312 0 0.0
.init 27 27 0 0.0
.init_array 752 752 0 0.0
.rodata 194225 194225 0 0.0
.text 1871842 1871634 -208 -0.0
ota-provider-app debug (read only) 2054257 2054097 -160 -0.0
(read/write) 138992 138992 0 0.0
.bss 71424 71424 0 0.0
.data 1672 1672 0 0.0
.data.rel.ro 60104 60104 0 0.0
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 174971 174971 0 0.0
.text 1722162 1722002 -160 -0.0
ota-requestor-app debug (read only) 2085377 2085201 -176 -0.0
(read/write) 141800 141800 0 0.0
.bss 72064 72064 0 0.0
.data 1928 1928 0 0.0
.data.rel.ro 62184 62184 0 0.0
.dynamic 592 592 0 0.0
.got 4320 4320 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 171244 171244 0 0.0
.text 1755522 1755346 -176 -0.0
shell debug (read only) 2555225 2554825 -400 -0.0
(read/write) 197104 197104 0 0.0
.bss 114088 114088 0 0.0
.data 1376 1376 0 0.0
.data.rel.ro 75920 75920 0 0.0
.dynamic 592 592 0 0.0
.got 4184 4184 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 216594 216594 0 0.0
.text 2177106 2176706 -400 -0.0
thermostat-no-ble arm64 (read only) 2365124 2360948 -4176 -0.2
(read/write) 174593 174593 0 0.0
.bss 86273 86273 0 0.0
.data 1496 1496 0 0.0
.data.rel.ro 79048 79048 0 0.0
.dynamic 560 560 0 0.0
.got 4736 4736 0 0.0
.init 24 24 0 0.0
.init_array 376 376 0 0.0
.rodata 145988 145748 -240 -0.2
.text 1989984 1986048 -3936 -0.2
tv-app debug (read only) 2837937 2837697 -240 -0.0
(read/write) 276608 276608 0 0.0
.bss 189272 189272 0 0.0
.data 4640 4640 0 0.0
.data.rel.ro 76456 76456 0 0.0
.dynamic 592 592 0 0.0
.got 4696 4696 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 216971 216971 0 0.0
.text 2438914 2438674 -240 -0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2490664 2490472 -192 -0.0
.bss 211736 211736 0 0.0
.data 5608 5608 0 0.0
.text 1453236 1453044 -192 -0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2440568 2440440 -128 -0.0
.bss 207052 207052 0 0.0
.data 5880 5880 0 0.0
.text 1403140 1403012 -128 -0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2418268 2418140 -128 -0.0
.bss 205884 205884 0 0.0
.data 5856 5856 0 0.0
.text 1380868 1380740 -128 -0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2366600 2366536 -64 -0.0
.bss 205656 205656 0 0.0
.data 5632 5632 0 0.0
.text 1329172 1329108 -64 -0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1180251 1180075 -176 -0.0
bss 142000 142000 0 0.0
rodata 150804 150804 0 0.0
text 808752 808588 -164 -0.0
lighting-app nrf52840dk_nrf52840 (read/write) 1155671 1155559 -112 -0.0
bss 145716 145716 0 0.0
rodata 121744 121744 0 0.0
text 809556 809448 -108 -0.0
nrf52840dk_nrf52840+rpc (read/write) 1119951 1119839 -112 -0.0
bss 145952 145952 0 0.0
rodata 112856 112856 0 0.0
text 782028 781924 -104 -0.0
nrf52840dongle_nrf52840 (read/write) 1063603 1063507 -96 -0.0
bss 152908 152908 0 0.0
rodata 91796 91796 0 0.0
text 738044 737940 -104 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 1058034 1057938 -96 -0.0
bss 141920 141920 0 0.0
rodata 114496 114496 0 0.0
text 719660 719556 -104 -0.0
lock-app nrf52840dk_nrf52840 (read/write) 1097847 1097751 -96 -0.0
bss 135652 135652 0 0.0
rodata 134272 134272 0 0.0
text 749420 749328 -92 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 1000606 1000510 -96 -0.0
bss 131884 131884 0 0.0
rodata 127076 127076 0 0.0
text 659668 659576 -92 -0.0
pump-app nrf52840dk_nrf52840 (read/write) 1076071 1075959 -112 -0.0
bss 135720 135720 0 0.0
rodata 117256 117256 0 0.0
text 744448 744344 -104 -0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 1057667 1057587 -80 -0.0
bss 135440 135440 0 0.0
rodata 113204 113204 0 0.0
text 730392 730312 -80 -0.0
p6 all-clusters-app default (read/write) 2528656 2528512 -144 -0.0
.bss 139256 139256 0 0.0
.data 2792 2792 0 0.0
.text 1486920 1486776 -144 -0.0
light-app default (read/write) 2419224 2419112 -112 -0.0
.bss 132720 132720 0 0.0
.data 2592 2592 0 0.0
.text 1377488 1377376 -112 -0.0
lock-app default (read/write) 2428496 2428384 -112 -0.0
.bss 132544 132544 0 0.0
.data 2552 2552 0 0.0
.text 1386760 1386648 -112 -0.0
telink lighting-app tlsr9518adk80d (read/write) 807436 807324 -112 -0.0
bss 75432 75432 0 0.0
noinit 40416 40416 0 0.0
text 571226 571118 -108 -0.0

@bzbarsky-apple bzbarsky-apple merged commit df644b2 into project-chip:master Apr 30, 2022
@bzbarsky-apple bzbarsky-apple deleted the no-more-client-attributes branch April 30, 2022 05:34
@bzbarsky-apple bzbarsky-apple mentioned this pull request May 21, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Damian-Nordic Damian-Nordic Damian-Nordic approved these changes

@tcarmelveilleux tcarmelveilleux tcarmelveilleux approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
examples review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bzbarsky-apple @tcarmelveilleux @Damian-Nordic